[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129029#comment-17129029 ] Benjamin Lerer commented on CASSANDRA-15773: The patch looks good to me. :-) > Add test

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128342#comment-17128342 ] Benjamin Lerer commented on CASSANDRA-15773: [~djoshi] I can take the review if you do

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111412#comment-17111412 ] David Capwell commented on CASSANDRA-15773: --- [~djoshi] can we get your eyes? > Add test

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1747#comment-1747 ] Stephen Mallette commented on CASSANDRA-15773: -- I was just wondering if anything else

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101951#comment-17101951 ] David Capwell commented on CASSANDRA-15773: --- +1 from me. I ran the build and the only

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101895#comment-17101895 ] Stephen Mallette commented on CASSANDRA-15773: -- {{assertThatThrownBy()}} is better -

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101888#comment-17101888 ] David Capwell commented on CASSANDRA-15773: --- bq. I've initialized the test with a fixed

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101742#comment-17101742 ] Stephen Mallette commented on CASSANDRA-15773: -- thanks [~djoshi] > You're making gets

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101123#comment-17101123 ] Dinesh Joshi commented on CASSANDRA-15773: -- [~spmallette] I think the test is ok. I don't

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100695#comment-17100695 ] Stephen Mallette commented on CASSANDRA-15773: -- [~dcapwell] thanks for the feedback: >

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100342#comment-17100342 ] David Capwell commented on CASSANDRA-15773: --- *

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095704#comment-17095704 ] Dinesh Joshi commented on CASSANDRA-15773: -- thanks for the patch [~spmallette]. I've kicked

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095691#comment-17095691 ] David Capwell commented on CASSANDRA-15773: --- have a few things on my plate this week, if

[jira] [Commented] (CASSANDRA-15773) Add test to cover metrics related to the BufferPool

[ https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095572#comment-17095572 ] Stephen Mallette commented on CASSANDRA-15773: -- Please find this new test here for