[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217007#comment-17217007
]
David Capwell commented on CASSANDRA-16057:
---
Starting commit
CI Results (pending):
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214936#comment-17214936
]
David Capwell commented on CASSANDRA-16057:
---
+1
> Should update in-jvm dtest to expose
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214884#comment-17214884
]
Yifan Cai commented on CASSANDRA-16057:
---
CI result from the latest in each branch.
3.11:
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214013#comment-17214013
]
Alex Petrov commented on CASSANDRA-16057:
-
+1
> Should update in-jvm dtest to expose stdout
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214000#comment-17214000
]
Yifan Cai commented on CASSANDRA-16057:
---
Good catch!
It turns out that my previous command
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213989#comment-17213989
]
Alex Petrov commented on CASSANDRA-16057:
-
Code looks good. The only thing is that in 3.11
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213290#comment-17213290
]
Yifan Cai commented on CASSANDRA-16057:
---
Fixed the compilation failure in 3.11.
The dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211322#comment-17211322
]
David Capwell commented on CASSANDRA-16057:
---
code mostly LGTM, basically the same as the
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211311#comment-17211311
]
Yifan Cai commented on CASSANDRA-16057:
---
Listing the files that are still using {{System.out |
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209912#comment-17209912
]
Yifan Cai commented on CASSANDRA-16057:
---
Backports:
2.0:
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208889#comment-17208889
]
Yifan Cai commented on CASSANDRA-16057:
---
Rebased to the trunk. Fixed the added test due to the
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208863#comment-17208863
]
David Capwell commented on CASSANDRA-16057:
---
Starting commit (pending):
CI results
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198563#comment-17198563
]
David Capwell commented on CASSANDRA-16057:
---
committed jvm-dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198562#comment-17198562
]
David Capwell commented on CASSANDRA-16057:
---
+1 the new changes (only skimmed trunk for
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198556#comment-17198556
]
Yifan Cai commented on CASSANDRA-16057:
---
Rebased onto trunk. 2 files conflicted and resolved.
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198522#comment-17198522
]
Alex Petrov commented on CASSANDRA-16057:
-
+1 with new changes. Thank you for the patch!
>
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198496#comment-17198496
]
Yifan Cai commented on CASSANDRA-16057:
---
Updated the dtest-api patch with {{notContains}}
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198489#comment-17198489
]
Yifan Cai commented on CASSANDRA-16057:
---
Thanks for all the feedbacks.
[~stefan.miklosovic],
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198461#comment-17198461
]
David Capwell commented on CASSANDRA-16057:
---
bq. Ultimately, formatted output is good, but
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198180#comment-17198180
]
Stefan Miklosovic commented on CASSANDRA-16057:
---
Ah, looking at Netstats I have _yet
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198157#comment-17198157
]
Stefan Miklosovic commented on CASSANDRA-16057:
---
[~ifesdjeen] [~yifanc]
I have
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198113#comment-17198113
]
Alex Petrov commented on CASSANDRA-16057:
-
I think this is a great addition which will make
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196646#comment-17196646
]
David Capwell commented on CASSANDRA-16057:
---
+1
> Should update in-jvm dtest to expose
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194479#comment-17194479
]
David Capwell commented on CASSANDRA-16057:
---
Overall LGTM, only small comments remaining.
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194461#comment-17194461
]
Yifan Cai commented on CASSANDRA-16057:
---
Thanks David for the review.
Updated the both PRs
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193755#comment-17193755
]
Yifan Cai commented on CASSANDRA-16057:
---
Adding the PR to trunk:
[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193233#comment-17193233
]
Yifan Cai commented on CASSANDRA-16057:
---
Before adding the implementation in the Cassandra
27 matches
Mail list logo