[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208455#comment-17208455
]
David Capwell commented on CASSANDRA-16101:
---
Committed, see
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198504#comment-17198504
]
David Capwell commented on CASSANDRA-16101:
---
+1
> Make sure we don't throw any uncaught
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197865#comment-17197865
]
David Capwell commented on CASSANDRA-16101:
---
Thanks, did a quick review and mostly LGTM
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197655#comment-17197655
]
Marcus Eriksson commented on CASSANDRA-16101:
-
ok, makes sense, added a method to add a
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197079#comment-17197079
]
David Capwell commented on CASSANDRA-16101:
---
One potential would be to add a method to
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197076#comment-17197076
]
David Capwell commented on CASSANDRA-16101:
---
The test I am worried about are (only choose
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196791#comment-17196791
]
Alex Petrov commented on CASSANDRA-16101:
-
[~dcapwell] It looks like the main problem here
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194494#comment-17194494
]
David Capwell commented on CASSANDRA-16101:
---
bq. I did this first, but then thought we
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193998#comment-17193998
]
Marcus Eriksson commented on CASSANDRA-16101:
-
bq. can we also have a way for the test
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193925#comment-17193925
]
David Capwell commented on CASSANDRA-16101:
---
LGTM but left a comment in the cassandra
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192141#comment-17192141
]
Marcus Eriksson commented on CASSANDRA-16101:
-
thanks, merged the dtest pr, will wait
[
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191690#comment-17191690
]
Alex Petrov commented on CASSANDRA-16101:
-
+1, both patches LGTM.
> Make sure we don't
12 matches
Mail list logo