[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227168#comment-17227168
]
Berenguer Blasi commented on CASSANDRA-16121:
-
[~dcapwell] thanks for looking into this
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227083#comment-17227083
]
David Capwell commented on CASSANDRA-16121:
---
Saw test failures, but they pass the next
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227075#comment-17227075
]
David Capwell commented on CASSANDRA-16121:
---
testing out commit but used a slight change;
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227073#comment-17227073
]
David Capwell commented on CASSANDRA-16121:
---
Starting commit
CI Results (pending):
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226880#comment-17226880
]
David Capwell commented on CASSANDRA-16121:
---
thanks for replying [~Bereng], LGTM, will
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226498#comment-17226498
]
Berenguer Blasi commented on CASSANDRA-16121:
-
Hi [~dcapwell] [~e.dimitrova] thx for
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226373#comment-17226373
]
Ekaterina Dimitrova commented on CASSANDRA-16121:
-
+1 as soon as David's comment is
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226336#comment-17226336
]
David Capwell commented on CASSANDRA-16121:
---
Overall +1 from me, only small comment about
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226328#comment-17226328
]
David Capwell commented on CASSANDRA-16121:
---
sorry for the delay, starting back today.
>
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223035#comment-17223035
]
David Capwell commented on CASSANDRA-16121:
---
sorry for the delay, been overloaded. I
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219443#comment-17219443
]
Berenguer Blasi commented on CASSANDRA-16121:
-
CASSANDRA-15944 has been merged recently
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219001#comment-17219001
]
Ekaterina Dimitrova commented on CASSANDRA-16121:
-
[~dcapwell] [~Bereng]
I saw one
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218733#comment-17218733
]
Berenguer Blasi commented on CASSANDRA-16121:
-
Correct, those are 2 diff sets of tests.
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218604#comment-17218604
]
David Capwell commented on CASSANDRA-16121:
---
Talking to [~e.dimitrova] in slack she showed
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218601#comment-17218601
]
David Capwell commented on CASSANDRA-16121:
---
Left comments in PR, but won't to know why
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218600#comment-17218600
]
David Capwell commented on CASSANDRA-16121:
---
[~Bereng] I see Jenkins runs these tests and
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218589#comment-17218589
]
David Capwell commented on CASSANDRA-16121:
---
I can start reviewing.
[~e.dimitrova] did
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206158#comment-17206158
]
Berenguer Blasi commented on CASSANDRA-16121:
-
[~e.dimitrova] iirc the only thing that
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206155#comment-17206155
]
Ekaterina Dimitrova commented on CASSANDRA-16121:
-
Thank you for your work.
One
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203877#comment-17203877
]
Berenguer Blasi commented on CASSANDRA-16121:
-
[~e.dimitrova] executors are now in the
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201281#comment-17201281
]
Berenguer Blasi commented on CASSANDRA-16121:
-
Replied in GH. LGTM it's just {{diff}}
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201149#comment-17201149
]
Ekaterina Dimitrova commented on CASSANDRA-16121:
-
Thanks [~Bereng], I left some
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200876#comment-17200876
]
Berenguer Blasi commented on CASSANDRA-16121:
-
[~e.dimitrova] squashed and you can see
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199912#comment-17199912
]
Berenguer Blasi commented on CASSANDRA-16121:
-
I added that new executor and updated the
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199735#comment-17199735
]
Ekaterina Dimitrova commented on CASSANDRA-16121:
-
I saw that j8_small_par_executor
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197591#comment-17197591
]
Berenguer Blasi commented on CASSANDRA-16121:
-
Hi [~e.dimitrova] I updated both patch
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196979#comment-17196979
]
Ekaterina Dimitrova commented on CASSANDRA-16121:
-
Hi [~Bereng],
Thanks for the
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196684#comment-17196684
]
Berenguer Blasi commented on CASSANDRA-16121:
-
New CI results in PR available.
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196685#comment-17196685
]
Berenguer Blasi commented on CASSANDRA-16121:
-
New CI results in PR available.
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196673#comment-17196673
]
Berenguer Blasi commented on CASSANDRA-16121:
-
[~e.dimitrova] if I managed to follow the
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196624#comment-17196624
]
Ekaterina Dimitrova commented on CASSANDRA-16121:
-
Actually, I just saw in CircleCI
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196621#comment-17196621
]
Ekaterina Dimitrova commented on CASSANDRA-16121:
-
In CASSANDRA-10190 all cql
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196586#comment-17196586
]
David Capwell commented on CASSANDRA-16121:
---
bq. I am wondering do we know why they were
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196207#comment-17196207
]
Berenguer Blasi commented on CASSANDRA-16121:
-
I don't know tbh. I just found a failure
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196154#comment-17196154
]
Ekaterina Dimitrova commented on CASSANDRA-16121:
-
I am wondering do we know why
[
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195187#comment-17195187
]
Berenguer Blasi commented on CASSANDRA-16121:
-
CI results in PR.
> Circleci should run
36 matches
Mail list logo