[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212494#comment-17212494
]
David Capwell commented on CASSANDRA-16127:
---
Starting commit
CI Results (pending):
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211767#comment-17211767
]
Ekaterina Dimitrova commented on CASSANDRA-16127:
-
CI looks good.
Thank you for
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211454#comment-17211454
]
David Capwell commented on CASSANDRA-16127:
---
Starting commit
CI Results (pending):
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211179#comment-17211179
]
David Capwell commented on CASSANDRA-16127:
---
Doh, I knew about this but forgot to update
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211174#comment-17211174
]
David Capwell commented on CASSANDRA-16127:
---
Yep, will check the test failure; the test
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211054#comment-17211054
]
Ekaterina Dimitrova commented on CASSANDRA-16127:
-
Unfortunately, I found this dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211004#comment-17211004
]
Ekaterina Dimitrova commented on CASSANDRA-16127:
-
Also, while you introduce the new
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210587#comment-17210587
]
Ekaterina Dimitrova commented on CASSANDRA-16127:
-
A couple of nits on the dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210462#comment-17210462
]
David Capwell commented on CASSANDRA-16127:
---
Starting commit
CI Results (pending):
2.2
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210452#comment-17210452
]
David Capwell commented on CASSANDRA-16127:
---
Im going to start the commit process, but
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210440#comment-17210440
]
David Capwell commented on CASSANDRA-16127:
---
all tests passing (after fixing the trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210405#comment-17210405
]
Jordan West commented on CASSANDRA-16127:
-
Updated changes also look good
>
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210311#comment-17210311
]
David Capwell commented on CASSANDRA-16127:
---
all tests are passing for 3.11 now, will
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209918#comment-17209918
]
David Capwell commented on CASSANDRA-16127:
---
[~e.dimitrova] I plan to remove the python
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209860#comment-17209860
]
Jordan West commented on CASSANDRA-16127:
-
LGTM. Changes look good, ran the tests locally,
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209706#comment-17209706
]
David Capwell commented on CASSANDRA-16127:
---
Update, I found out what was failing the test
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209139#comment-17209139
]
David Capwell commented on CASSANDRA-16127:
---
Sorry, neglected this patch for a bit;
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204337#comment-17204337
]
David Capwell commented on CASSANDRA-16127:
---
3.0 and 3.11 bootstrap failed but were
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201264#comment-17201264
]
Yifan Cai commented on CASSANDRA-16127:
---
dtest has [2
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201171#comment-17201171
]
Yifan Cai commented on CASSANDRA-16127:
---
+1 on the 3.11 patch.
(One unit test failure in the
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200457#comment-17200457
]
David Capwell commented on CASSANDRA-16127:
---
[~yifanc] applied to all feedback
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200311#comment-17200311
]
Ekaterina Dimitrova commented on CASSANDRA-16127:
-
Hey [~dcapwell],
Thanks for the
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199603#comment-17199603
]
David Capwell commented on CASSANDRA-16127:
---
the test failure on trunk is caused by
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198618#comment-17198618
]
David Capwell commented on CASSANDRA-16127:
---
Ok trunk is finally stable; patch is ready to
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198442#comment-17198442
]
David Capwell commented on CASSANDRA-16127:
---
Ok I think the code is almost ready to
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197339#comment-17197339
]
David Capwell commented on CASSANDRA-16127:
---
added python dtest which catches the other
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197252#comment-17197252
]
Yifan Cai commented on CASSANDRA-16127:
---
Left some comments inline on GH.
>
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197020#comment-17197020
]
David Capwell commented on CASSANDRA-16127:
---
Thanks for taking a look and trying!
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196933#comment-17196933
]
Tommy Stendahl commented on CASSANDRA-16127:
I took a closer look at the patch and
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196730#comment-17196730
]
Tibor Repasi commented on CASSANDRA-16127:
--
Now start and stop are looking much more tidy.
[
https://issues.apache.org/jira/browse/CASSANDRA-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196712#comment-17196712
]
Tommy Stendahl commented on CASSANDRA-16127:
Looks like this patch will also fix the
31 matches
Mail list logo
