[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278041#comment-17278041
]
Ekaterina Dimitrova commented on CASSANDRA-16283:
-
Patch committed [here|
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277274#comment-17277274
]
Ekaterina Dimitrova commented on CASSANDRA-16283:
-
Patch rebased and squashed
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276736#comment-17276736
]
Brandon Williams commented on CASSANDRA-16283:
--
+1
bq. We need only to move the
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275411#comment-17275411
]
Ekaterina Dimitrova commented on CASSANDRA-16283:
-
Thanks both [~yakir.g] and
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275382#comment-17275382
]
Adam Holmberg commented on CASSANDRA-16283:
---
Thanks for the review. I pushed updates. I
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17274124#comment-17274124
]
Ekaterina Dimitrova commented on CASSANDRA-16283:
-
The patch looks good to me, I
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273231#comment-17273231
]
Ekaterina Dimitrova commented on CASSANDRA-16283:
-
Jenkins run pushed [here |
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272407#comment-17272407
]
Adam Holmberg commented on CASSANDRA-16283:
---
The branch is updated. Full CI run finished
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272146#comment-17272146
]
Ekaterina Dimitrova commented on CASSANDRA-16283:
-
Thank you, [~aholmber]. Please
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271779#comment-17271779
]
Adam Holmberg commented on CASSANDRA-16283:
---
I see that the port is not fixed for unit
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271706#comment-17271706
]
Adam Holmberg commented on CASSANDRA-16283:
---
Updated branch with PR here:
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270370#comment-17270370
]
Adam Holmberg commented on CASSANDRA-16283:
---
Will do. Thanks for getting back on the
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270363#comment-17270363
]
Scott Wolfenhaut commented on CASSANDRA-16283:
--
[~aholmber]
Been a little busy, feel
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269475#comment-17269475
]
Adam Holmberg commented on CASSANDRA-16283:
---
[~wolfenhaut] Just checking to see if you're
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263487#comment-17263487
]
Adam Holmberg commented on CASSANDRA-16283:
---
I personally don't see a reason to split out
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263070#comment-17263070
]
Berenguer Blasi commented on CASSANDRA-16283:
-
Did review it. Mostly aligned to what
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259947#comment-17259947
]
Adam Holmberg commented on CASSANDRA-16283:
---
Thanks for taking a look at this, and for the
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249275#comment-17249275
]
Adam Holmberg commented on CASSANDRA-16283:
---
Thanks [~wolfenhaut]. Would you consider
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248448#comment-17248448
]
Yakir Gibraltar commented on CASSANDRA-16283:
-
Thank you [~wolfenhaut] :)
> Incorrect
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247349#comment-17247349
]
Scott Wolfenhaut commented on CASSANDRA-16283:
--
Fixed via PR
[
https://issues.apache.org/jira/browse/CASSANDRA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237227#comment-17237227
]
Berenguer Blasi commented on CASSANDRA-16283:
-
See {{ToolRunner}} on how to test tooling
21 matches
Mail list logo
