[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529248#comment-17529248 ] Berenguer Blasi commented on CASSANDRA-16310: - Aha! ok yes LGTM +1 :-) > Track top

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529238#comment-17529238 ] Marcus Eriksson commented on CASSANDRA-16310: - I retriggered yesterday as well:

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529191#comment-17529191 ] Berenguer Blasi commented on CASSANDRA-16310: - Seems it failed building. I just

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17528826#comment-17528826 ] Marcus Eriksson commented on CASSANDRA-16310: - seems system schema mutation got > 20kb

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17528713#comment-17528713 ] Marcus Eriksson commented on CASSANDRA-16310: - thanks. will check > Track top

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17528685#comment-17528685 ] Berenguer Blasi commented on CASSANDRA-16310: - Hi All, I noticed some new failures such

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524591#comment-17524591 ] David Capwell commented on CASSANDRA-16310: --- Patch LGTM, I had minor nits for the type

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524130#comment-17524130 ] Marcus Eriksson commented on CASSANDRA-16310: - rebased and a small update (use

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518873#comment-17518873 ] Marcus Eriksson commented on CASSANDRA-16310: - [~smiklosovic] sorry, missed the message,

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507431#comment-17507431 ] Stefan Miklosovic commented on CASSANDRA-16310: --- I think this just needs to rebase and

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452526#comment-17452526 ] Yifan Cai commented on CASSANDRA-16310: --- +1 Some test failures were due to that the branch was

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452391#comment-17452391 ] Marcus Eriksson commented on CASSANDRA-16310: - pushed a commit fixing the most recent

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451618#comment-17451618 ] Marcus Eriksson commented on CASSANDRA-16310: - bq. switching from blob to text to

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451381#comment-17451381 ] Yifan Cai commented on CASSANDRA-16310: --- The new commits update the schema for the

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450763#comment-17450763 ] David Capwell commented on CASSANDRA-16310: --- Overall LGTM; small nit comments only in the

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446590#comment-17446590 ] David Capwell commented on CASSANDRA-16310: --- Marcus pushed a new commit to his branch

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445416#comment-17445416 ] Yifan Cai commented on CASSANDRA-16310: --- +1 Thanks for addressing the prior comment and the

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444220#comment-17444220 ] David Capwell commented on CASSANDRA-16310: --- [~yifanc] [~marcuse] can you review the PR?

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444202#comment-17444202 ] David Capwell commented on CASSANDRA-16310: --- Took [~marcuse] patch and applied [~yifanc]

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444200#comment-17444200 ] David Capwell commented on CASSANDRA-16310: --- bq. They fail with the --validate option. No

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444187#comment-17444187 ] David Capwell commented on CASSANDRA-16310: --- bq. The tests cases pass with the --preview

[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats

[ https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444131#comment-17444131 ] David Capwell commented on CASSANDRA-16310: --- bq. Having setters for