[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-28 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529501#comment-17529501 ] David Capwell commented on CASSANDRA-17379: --- +1, but I would like my comments addressed, I

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-28 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529495#comment-17529495 ] David Capwell commented on CASSANDRA-17379: --- bq. I'm +1 disallowing new + old config

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-20 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525324#comment-17525324 ] Ekaterina Dimitrova commented on CASSANDRA-17379: - Thanks! Overall LGTM, I left

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-19 Thread Marcus Eriksson (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524185#comment-17524185 ] Marcus Eriksson commented on CASSANDRA-17379: - PR updated with the above > Fail

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-19 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524170#comment-17524170 ] Ekaterina Dimitrova commented on CASSANDRA-17379: - Should we add a flag - by default

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-19 Thread Marcus Eriksson (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524133#comment-17524133 ] Marcus Eriksson commented on CASSANDRA-17379: - I'm +1 disallowing new + old config

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-18 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523897#comment-17523897 ] Ekaterina Dimitrova commented on CASSANDRA-17379: - [~blerer] from your experience (I

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-18 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523896#comment-17523896 ] Ekaterina Dimitrova commented on CASSANDRA-17379: - I am on the fence to suggest just

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-18 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523894#comment-17523894 ] Ekaterina Dimitrova commented on CASSANDRA-17379: - I left small comments and overall

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-04-12 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521377#comment-17521377 ] Ekaterina Dimitrova commented on CASSANDRA-17379: - Thank you for the patch! I think

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493472#comment-17493472 ] Ekaterina Dimitrova commented on CASSANDRA-17379: - +1 > Fail starting when the same

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493467#comment-17493467 ] David Capwell commented on CASSANDRA-17379: --- +1 > Fail starting when the same parameter

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread Marcus Eriksson (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493460#comment-17493460 ] Marcus Eriksson commented on CASSANDRA-17379: - {quote}1.) Fail startup if the duplicate

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493372#comment-17493372 ] Caleb Rackliffe commented on CASSANDRA-17379: - Not sure exactly what the consensus is

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493362#comment-17493362 ] Brandon Williams commented on CASSANDRA-17379: -- I like that idea since it will ensure

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493360#comment-17493360 ] Ekaterina Dimitrova commented on CASSANDRA-17379: - We just had some discussion with

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493358#comment-17493358 ] David Capwell commented on CASSANDRA-17379: --- what if we block by default with an escape

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493356#comment-17493356 ] Brandon Williams commented on CASSANDRA-17379: -- I'm fine with a warning, if it says

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493336#comment-17493336 ] Ekaterina Dimitrova commented on CASSANDRA-17379: - I agree with [~brandon.williams] 

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493328#comment-17493328 ] Brandon Williams commented on CASSANDRA-17379: -- +1 to refusing to start. I'm not sure

[jira] [Commented] (CASSANDRA-17379) Fail starting when the same parameter exists more than once with different values in cassandra.yaml

2022-02-16 Thread Marcus Eriksson (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493267#comment-17493267 ] Marcus Eriksson commented on CASSANDRA-17379: - we should at least refuse starting if the