[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-28 Thread Sam Tunnicliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694704#comment-17694704 ] Sam Tunnicliffe commented on CASSANDRA-17561: - +1, lgtm thanks > Diagnostic snapshot

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694195#comment-17694195 ] Stefan Miklosovic commented on CASSANDRA-17561: --- CI still looks solid

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693884#comment-17693884 ] Stefan Miklosovic commented on CASSANDRA-17561: --- Yeah, since this is a "technical

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-26 Thread Paulo Motta (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693679#comment-17693679 ] Paulo Motta commented on CASSANDRA-17561: - {quote}Why do we want to know what ranges that

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-20 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691151#comment-17691151 ] Stefan Miklosovic commented on CASSANDRA-17561: --- btw isnt it true that as soon as

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-17 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690474#comment-17690474 ] Stefan Miklosovic commented on CASSANDRA-17561: --- Why do we want to know what ranges

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-17 Thread Paulo Motta (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690467#comment-17690467 ] Paulo Motta commented on CASSANDRA-17561: - Currently the snapshots semantics is that it will

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-17 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690465#comment-17690465 ] Stefan Miklosovic commented on CASSANDRA-17561: --- Thanks [~samt], suggested changes are

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-17 Thread Sam Tunnicliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690266#comment-17690266 ] Sam Tunnicliffe commented on CASSANDRA-17561: - Mostly LGMT, left a couple of comments on

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-07 Thread Sam Tunnicliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685739#comment-17685739 ] Sam Tunnicliffe commented on CASSANDRA-17561: - Will do my best, sorry I missed last week

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-02-07 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685241#comment-17685241 ] Stefan Miklosovic commented on CASSANDRA-17561: --- [~samt] any chance this week is more

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-01-31 Thread Sam Tunnicliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682464#comment-17682464 ] Sam Tunnicliffe commented on CASSANDRA-17561: - Yep, I'll take a look this week. Thanks!

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-01-30 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682263#comment-17682263 ] Stefan Miklosovic commented on CASSANDRA-17561: --- The build looks good! [~samt] do you

[jira] [Commented] (CASSANDRA-17561) Diagnostic snapshot service should only snapshot mismatching ranges on preview repair mismatch

2023-01-30 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682042#comment-17682042 ] Stefan Miklosovic commented on CASSANDRA-17561: --- I took the patch of [~marcuse] and