[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694704#comment-17694704
]
Sam Tunnicliffe commented on CASSANDRA-17561:
-
+1, lgtm thanks
> Diagnostic snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694195#comment-17694195
]
Stefan Miklosovic commented on CASSANDRA-17561:
---
CI still looks solid
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693884#comment-17693884
]
Stefan Miklosovic commented on CASSANDRA-17561:
---
Yeah, since this is a "technical
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693679#comment-17693679
]
Paulo Motta commented on CASSANDRA-17561:
-
{quote}Why do we want to know what ranges that
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691151#comment-17691151
]
Stefan Miklosovic commented on CASSANDRA-17561:
---
btw isnt it true that as soon as
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690474#comment-17690474
]
Stefan Miklosovic commented on CASSANDRA-17561:
---
Why do we want to know what ranges
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690467#comment-17690467
]
Paulo Motta commented on CASSANDRA-17561:
-
Currently the snapshots semantics is that it will
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690465#comment-17690465
]
Stefan Miklosovic commented on CASSANDRA-17561:
---
Thanks [~samt], suggested changes are
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690266#comment-17690266
]
Sam Tunnicliffe commented on CASSANDRA-17561:
-
Mostly LGMT, left a couple of comments on
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685739#comment-17685739
]
Sam Tunnicliffe commented on CASSANDRA-17561:
-
Will do my best, sorry I missed last week
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685241#comment-17685241
]
Stefan Miklosovic commented on CASSANDRA-17561:
---
[~samt] any chance this week is more
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682464#comment-17682464
]
Sam Tunnicliffe commented on CASSANDRA-17561:
-
Yep, I'll take a look this week. Thanks!
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682263#comment-17682263
]
Stefan Miklosovic commented on CASSANDRA-17561:
---
The build looks good! [~samt] do you
[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682042#comment-17682042
]
Stefan Miklosovic commented on CASSANDRA-17561:
---
I took the patch of [~marcuse] and
14 matches
Mail list logo