[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642452#comment-17642452
]
Andres de la Peña commented on CASSANDRA-18042:
---
Great, I'm glad you find the feedback
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642174#comment-17642174
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
[~adelapena] I will make you
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642155#comment-17642155
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Great. So we do not need to change
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642145#comment-17642145
]
Brandon Williams commented on CASSANDRA-18042:
--
I too am on the "warned" bandwagon now.
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642142#comment-17642142
]
Josh McKenzie commented on CASSANDRA-18042:
---
Ok. Enough bikeshedding; you hit the nail on
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642110#comment-17642110
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Simple "warn" is enough for me. "to
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642089#comment-17642089
]
Andres de la Peña commented on CASSANDRA-18042:
---
Good, good, we'll getting to
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642075#comment-17642075
]
Josh McKenzie commented on CASSANDRA-18042:
---
Had time to sleep on it. I'm almost with you
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641897#comment-17641897
]
Andres de la Peña commented on CASSANDRA-18042:
---
The ordering with {{featue_enabled}}
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641791#comment-17641791
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
{code}
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641585#comment-17641585
]
Josh McKenzie commented on CASSANDRA-18042:
---
I see it being differently vague with the
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641580#comment-17641580
]
Andres de la Peña commented on CASSANDRA-18042:
---
Yep, it's not only redundant but it
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641570#comment-17641570
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
In this case I would go like
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641566#comment-17641566
]
Andres de la Peña commented on CASSANDRA-18042:
---
I understand that feature flags could
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641563#comment-17641563
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Yes it is same relationship, because
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641560#comment-17641560
]
Josh McKenzie commented on CASSANDRA-18042:
---
{quote}Just to understand the mechanics
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641503#comment-17641503
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Just to understand the mechanics
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641490#comment-17641490
]
Brandon Williams commented on CASSANDRA-18042:
--
In feature_warn_if_enabled vs
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641454#comment-17641454
]
Andres de la Peña commented on CASSANDRA-18042:
---
Whatever we choose, I think that it
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641446#comment-17641446
]
Brandon Williams commented on CASSANDRA-18042:
--
I think that works, I wasn't hugely
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641441#comment-17641441
]
Josh McKenzie commented on CASSANDRA-18042:
---
1. I'm terrible at naming things. Grain of
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641427#comment-17641427
]
Brandon Williams commented on CASSANDRA-18042:
--
I think it would be a little more
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641407#comment-17641407
]
Josh McKenzie commented on CASSANDRA-18042:
---
{code}
zero_ttl_on_twcs_warned: true
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641153#comment-17641153
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
[~jmckenzie] [~bschoeni] everybody
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640797#comment-17640797
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Ok, will be done on commit.
Lets
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640728#comment-17640728
]
Andres de la Peña commented on CASSANDRA-18042:
---
Thanks, looks good to me, +1 if CI
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640705#comment-17640705
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
ok done here:
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640700#comment-17640700
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
done here:
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640671#comment-17640671
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Naming looks good to me. So it means
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640654#comment-17640654
]
Andres de la Peña commented on CASSANDRA-18042:
---
I agree that the names of the
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640577#comment-17640577
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Incorporated renaming of properties
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640233#comment-17640233
]
Ekaterina Dimitrova commented on CASSANDRA-18042:
-
I like the suggestions made by
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640231#comment-17640231
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
What about:
{code}
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640210#comment-17640210
]
Josh McKenzie commented on CASSANDRA-18042:
---
{quote}#zero_default_ttl_on_twcs_disallowed:
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639854#comment-17639854
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
OK, we will go with default warning
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638698#comment-17638698
]
Brad Schoening commented on CASSANDRA-18042:
>> It is easy to delete old sstables off
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638619#comment-17638619
]
Michael Semb Wever commented on CASSANDRA-18042:
bq. If you use a zero TTL with Time
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638582#comment-17638582
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
[~mck] could you go through last few
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638580#comment-17638580
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
_They had been depending on row level
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638358#comment-17638358
]
Brad Schoening commented on CASSANDRA-18042:
[~smiklosovic] [~adelapena]
I would prefer
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638277#comment-17638277
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
reviewed branch for the case we are
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637382#comment-17637382
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
I ve just finished this version in a
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637373#comment-17637373
]
Andres de la Peña commented on CASSANDRA-18042:
---
I was thinking on {{_warned}} instead
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637349#comment-17637349
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Thanks [~adelapena] for the review. I
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637316#comment-17637316
]
Andres de la Peña commented on CASSANDRA-18042:
---
By the way, the name of the property
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637312#comment-17637312
]
Andres de la Peña commented on CASSANDRA-18042:
---
The approach looks good to me. As
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637154#comment-17637154
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Thanks [~bschoeni]
_It is not
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636948#comment-17636948
]
Brad Schoening commented on CASSANDRA-18042:
[~smiklosovic]
Looks great, I agree that
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636889#comment-17636889
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
[~adelapena] it would be awesome if
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634055#comment-17634055
]
Brad Schoening commented on CASSANDRA-18042:
+1 on the warn and fail guardrails.
>
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634037#comment-17634037
]
Brandon Williams commented on CASSANDRA-18042:
--
+1 to having warn and fail thresholds
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634032#comment-17634032
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
Emitting just a warning by default
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634016#comment-17634016
]
Michael Semb Wever commented on CASSANDRA-18042:
Heuristically, I see more folk use
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634008#comment-17634008
]
Stefan Miklosovic commented on CASSANDRA-18042:
---
I do not mind to have it like Josh
[
https://issues.apache.org/jira/browse/CASSANDRA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17633975#comment-17633975
]
Josh McKenzie commented on CASSANDRA-18042:
---
+1 to the guardrail.
What do we think about
55 matches
Mail list logo
