[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790104#comment-17790104
]
Maxwell Guo commented on CASSANDRA-18464:
-
Thank you [~jlewandowski].(y)
> Enable Direct
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790064#comment-17790064
]
Jacek Lewandowski commented on CASSANDRA-18464:
---
I think we are ready to merge,
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789231#comment-17789231
]
Jacek Lewandowski commented on CASSANDRA-18464:
---
So we have a PR ready to re-review -
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780415#comment-17780415
]
Amit Pawar commented on CASSANDRA-18464:
Thanks [~maxwellguo] for your continuous feedback
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780414#comment-17780414
]
Amit Pawar commented on CASSANDRA-18464:
Thanks [~brandon.williams] and thought to give some
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778885#comment-17778885
]
Maxwell Guo commented on CASSANDRA-18464:
-
Thanks for your reply [~brandon.williams]， I may
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778668#comment-17778668
]
Brandon Williams commented on CASSANDRA-18464:
--
bq. I found that there is no test for
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778614#comment-17778614
]
Maxwell Guo commented on CASSANDRA-18464:
-
[~amit_pawar]Any update on this ?
If you need, I
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772732#comment-17772732
]
Maxwell Guo commented on CASSANDRA-18464:
-
I found that there is no test for this pr, and I
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772376#comment-17772376
]
Amit Pawar commented on CASSANDRA-18464:
PR is initiated: [Enable Direct-IO feature for
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771870#comment-17771870
]
Amit Pawar commented on CASSANDRA-18464:
Just an update. Creating PR for the patch
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771737#comment-17771737
]
Amit Pawar commented on CASSANDRA-18464:
Sure, will do.
> Enable Direct I/O For CommitLog
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771732#comment-17771732
]
Branimir Lambov commented on CASSANDRA-18464:
-
To make the review easier, could you fork
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771720#comment-17771720
]
Amit Pawar commented on CASSANDRA-18464:
Thank you for considering to 5.0.
I can see
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771432#comment-17771432
]
Branimir Lambov commented on CASSANDRA-18464:
-
There was a typo in my response above, I
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771421#comment-17771421
]
Amit Pawar commented on CASSANDRA-18464:
Thank you for reviewing the patch. Ideally having
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770415#comment-17770415
]
Branimir Lambov commented on CASSANDRA-18464:
-
This patch is very valuable, and I
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748275#comment-17748275
]
Caleb Rackliffe commented on CASSANDRA-18464:
-
I don't think I'll have time to look at
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748253#comment-17748253
]
Amit Pawar commented on CASSANDRA-18464:
Sorry to ping again. I understand that lot of work
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744129#comment-17744129
]
Amit Pawar commented on CASSANDRA-18464:
[~mck], thanks for taking time to check this. The
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744102#comment-17744102
]
Michael Semb Wever commented on CASSANDRA-18464:
[~amit_pawar], I suspect no one
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744065#comment-17744065
]
Amit Pawar commented on CASSANDRA-18464:
Ping...
> Enable Direct I/O For CommitLog Files
>
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741629#comment-17741629
]
Amit Pawar commented on CASSANDRA-18464:
Any suggestion on this test?
This test also
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738268#comment-17738268
]
Amit Pawar commented on CASSANDRA-18464:
Initial table was not looking properly and
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738258#comment-17738258
]
Amit Pawar commented on CASSANDRA-18464:
[~aweisberg] thanks for sharing the initial
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736373#comment-17736373
]
Amit Pawar commented on CASSANDRA-18464:
Thank you [~aweisberg] for reviewing the patch.
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736368#comment-17736368
]
Amit Pawar commented on CASSANDRA-18464:
[AMD Official Use Only - General]
Please check my
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736361#comment-17736361
]
Amit Pawar commented on CASSANDRA-18464:
Thank you for initiating the testing. Direct-IO
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736253#comment-17736253
]
Ariel Weisberg commented on CASSANDRA-18464:
So short patch :-)
I am not married at all
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736247#comment-17736247
]
Ariel Weisberg commented on CASSANDRA-18464:
I am a little confused as to why memory
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735678#comment-17735678
]
Brandon Williams commented on CASSANDRA-18464:
--
{quote}
With CMSGC, JNA version of
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735521#comment-17735521
]
Amit Pawar commented on CASSANDRA-18464:
Any feedback ?
> Enable Direct I/O For CommitLog
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731492#comment-17731492
]
Amit Pawar commented on CASSANDRA-18464:
Please set the flag "use_directio_for_commitlog" to
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731026#comment-17731026
]
Amit Pawar commented on CASSANDRA-18464:
I am able to enable Direct-IO feature on CommitLog
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725826#comment-17725826
]
Brandon Williams commented on CASSANDRA-18464:
--
It seems to me if JNA has superior
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725821#comment-17725821
]
Amit Pawar commented on CASSANDRA-18464:
I will try implementing using native API also and
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723662#comment-17723662
]
Amit Pawar commented on CASSANDRA-18464:
Thank you [~maedhroz] and [~mck] for your
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721039#comment-17721039
]
Michael Semb Wever commented on CASSANDRA-18464:
[~amit_pawar], what Caleb says.
If
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721022#comment-17721022
]
Caleb Rackliffe commented on CASSANDRA-18464:
-
bq. As per the community suggestion, less
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720646#comment-17720646
]
Amit Pawar commented on CASSANDRA-18464:
[~maedhroz] Thank you for your reply. Is there a
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720574#comment-17720574
]
Caleb Rackliffe commented on CASSANDRA-18464:
-
[~amit_pawar] The discussion around JDK11
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719716#comment-17719716
]
Amit Pawar commented on CASSANDRA-18464:
Hello everyone,
Myself Amit and new to this
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715715#comment-17715715
]
Michael Semb Wever commented on CASSANDRA-18464:
I don't understand, if jdk11 is the
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715247#comment-17715247
]
Michael Semb Wever commented on CASSANDRA-18464:
Making fixVersion 5.x, as 6.x is
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714205#comment-17714205
]
Caleb Rackliffe commented on CASSANDRA-18464:
-
bq. it's fine to use if needed
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714197#comment-17714197
]
Brandon Williams commented on CASSANDRA-18464:
--
I think this is all moot since we will
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714196#comment-17714196
]
Caleb Rackliffe commented on CASSANDRA-18464:
-
bq. Java version 8 does not have native
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713938#comment-17713938
]
maxwellguo commented on CASSANDRA-18464:
I feel that this ci must be able to pass（except for
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713925#comment-17713925
]
Michael Semb Wever commented on CASSANDRA-18464:
Java 8 is going to be dropped for
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713893#comment-17713893
]
Caleb Rackliffe commented on CASSANDRA-18464:
-
What are the chances that we just drop
[
https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713775#comment-17713775
]
Brandon Williams commented on CASSANDRA-18464:
--
I applied this to a branch and had
51 matches
Mail list logo
