[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-29 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791001#comment-17791001 ] Stefan Miklosovic commented on CASSANDRA-18935: --- I built the patch for trunk as TCM

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790733#comment-17790733 ] Stefan Miklosovic commented on CASSANDRA-18935: --- Good news is that I have a non-flaky

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-28 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790730#comment-17790730 ] Brandon Williams commented on CASSANDRA-18935: -- That's fine, I'm +1 on that plan. >

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790722#comment-17790722 ] Stefan Miklosovic commented on CASSANDRA-18935: --- Well ... it is flaky every now and

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790581#comment-17790581 ] Stefan Miklosovic commented on CASSANDRA-18935: --- It seems that the byteman script we

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790416#comment-17790416 ] Stefan Miklosovic commented on CASSANDRA-18935: --- Well, I see in trunk that

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790177#comment-17790177 ] Brandon Williams commented on CASSANDRA-18935: -- I see, thanks. NativeProtocolTest will

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-27 Thread Runtian Liu (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790174#comment-17790174 ] Runtian Liu commented on CASSANDRA-18935: - [~brandon.williams] the reason why

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790161#comment-17790161 ] Stefan Miklosovic commented on CASSANDRA-18935: --- I created this for trunk

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790115#comment-17790115 ] Brandon Williams commented on CASSANDRA-18935: -- I am +1 on this. I think we should

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-23 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789182#comment-17789182 ] Stefan Miklosovic commented on CASSANDRA-18935: --- [~mck] we are trying to fix the

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-23 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789177#comment-17789177 ] Stefan Miklosovic commented on CASSANDRA-18935: ---

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-21 Thread Runtian Liu (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788499#comment-17788499 ] Runtian Liu commented on CASSANDRA-18935: - I think the fix looks good. It will work for us.

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-20 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788148#comment-17788148 ] Stefan Miklosovic commented on CASSANDRA-18935: --- RPC_READY is set locally _after_

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-18 Thread Runtian Liu (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787520#comment-17787520 ] Runtian Liu commented on CASSANDRA-18935: - I concur that with CEP 21, the issue should no

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-18 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787497#comment-17787497 ] Stefan Miklosovic commented on CASSANDRA-18935: --- I think we should just remove that

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-18 Thread Runtian Liu (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787463#comment-17787463 ] Runtian Liu commented on CASSANDRA-18935: - It will be easier to understand If you check the

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Runtian Liu (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787427#comment-17787427 ] Runtian Liu commented on CASSANDRA-18935: - The test won't pass if we change to check if the

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787425#comment-17787425 ] Brandon Williams commented on CASSANDRA-18935: -- bq. it will choose replicas which are

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787423#comment-17787423 ] Stefan Miklosovic commented on CASSANDRA-18935: --- btw when I read the code correctly,

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787412#comment-17787412 ] Brandon Williams commented on CASSANDRA-18935: -- We should probably make a new ticket to

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Runtian Liu (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787408#comment-17787408 ] Runtian Liu commented on CASSANDRA-18935: - If that's the case, does it mean if a node's

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787404#comment-17787404 ] Brandon Williams commented on CASSANDRA-18935: -- bq. the gossip may have some delay so

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Runtian Liu (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787400#comment-17787400 ] Runtian Liu commented on CASSANDRA-18935: - [~brandon.williams] , I think the problem of

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787338#comment-17787338 ] Brandon Williams commented on CASSANDRA-18935: -- I think we should probably also add a

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787336#comment-17787336 ] Brandon Williams commented on CASSANDRA-18935: -- We can also switch to checking STATUS

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787332#comment-17787332 ] Stefan Miklosovic commented on CASSANDRA-18935: --- I will remove that one line

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787322#comment-17787322 ] Brandon Williams commented on CASSANDRA-18935: -- We can, but all existing installations

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787314#comment-17787314 ] Stefan Miklosovic commented on CASSANDRA-18935: --- OK so if they just want that flag,

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787305#comment-17787305 ] Brandon Williams commented on CASSANDRA-18935: -- bq. So what is the difference if we set

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787304#comment-17787304 ] Stefan Miklosovic commented on CASSANDRA-18935: --- Before this fix, RPC was set to true

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787292#comment-17787292 ] Brandon Williams commented on CASSANDRA-18935: -- The problem is not coordinator-only

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787289#comment-17787289 ] Stefan Miklosovic commented on CASSANDRA-18935: --- Coordinator nodes, these which will

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-17 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787143#comment-17787143 ] Brandon Williams commented on CASSANDRA-18935: -- We already have a flag to indicate

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-16 Thread Runtian Liu (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787013#comment-17787013 ] Runtian Liu commented on CASSANDRA-18935: - Not sure why we added this RPC_READY flag in the

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-16 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786976#comment-17786976 ] Stefan Miklosovic commented on CASSANDRA-18935: --- This is a tricky ticket! I just keep

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-16 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786968#comment-17786968 ] Stefan Miklosovic commented on CASSANDRA-18935: --- interesting catch about dedicated

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-16 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786922#comment-17786922 ] Brandon Williams commented on CASSANDRA-18935: -- bq. Does this mean after this change,

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-11-16 Thread Runtian Liu (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786894#comment-17786894 ] Runtian Liu commented on CASSANDRA-18935: - [~smiklosovic] Does this mean after this change,

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-10-23 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778746#comment-17778746 ] Stefan Miklosovic commented on CASSANDRA-18935: --- passed

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-10-23 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778662#comment-17778662 ] Brandon Williams commented on CASSANDRA-18935: -- [Upgrade

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-10-19 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1329#comment-1329 ] Brandon Williams commented on CASSANDRA-18935: -- Fair enough, it's a simple patch. The

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-10-19 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1316#comment-1316 ] Stefan Miklosovic commented on CASSANDRA-18935: --- since it is the very same patch just

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-10-19 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1315#comment-1315 ] Stefan Miklosovic commented on CASSANDRA-18935: --- [~brandon.williams]  would you please

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-10-19 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1308#comment-1308 ] Brandon Williams commented on CASSANDRA-18935: -- Missing some JDK runs? > Fix nodetool

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-10-19 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1220#comment-1220 ] Stefan Miklosovic commented on CASSANDRA-18935: --- [trunk

[jira] [Commented] (CASSANDRA-18935) Fix nodetool enable/disablebinary to correctly set rpc

2023-10-18 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776582#comment-17776582 ] Stefan Miklosovic commented on CASSANDRA-18935: --- I just renamed the ticket. > Fix