[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840472#comment-13840472
]
Benedict commented on CASSANDRA-3578:
-
The idea of the % was to give some sense of
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840698#comment-13840698
]
Benedict commented on CASSANDRA-3578:
-
+1
Multithreaded commitlog
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840868#comment-13840868
]
Jonathan Ellis commented on CASSANDRA-3578:
---
committed
Multithreaded
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838087#comment-13838087
]
Benedict commented on CASSANDRA-3578:
-
As discussed on IRC, with Batch CL in
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836370#comment-13836370
]
Benedict commented on CASSANDRA-3578:
-
Sounds good to me :-)
Multithreaded
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836524#comment-13836524
]
Jonathan Ellis commented on CASSANDRA-3578:
---
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836551#comment-13836551
]
Benedict commented on CASSANDRA-3578:
-
I think we've hashed this one out pretty
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836711#comment-13836711
]
Jonathan Ellis commented on CASSANDRA-3578:
---
If I don't commit anything from
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836000#comment-13836000
]
Benedict commented on CASSANDRA-3578:
-
bq. I understand what sync is doing
I just
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836033#comment-13836033
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. It is non-blocking in its
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836083#comment-13836083
]
Benedict commented on CASSANDRA-3578:
-
bq. How is WaitQueue different from using
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836100#comment-13836100
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. for RF=1 smart clients are
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836200#comment-13836200
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. I agree it's difficult to
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835663#comment-13835663
]
Benedict commented on CASSANDRA-3578:
-
Just realised there's a deadlock
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835864#comment-13835864
]
Jonathan Ellis commented on CASSANDRA-3578:
---
Updated my github branch to
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835894#comment-13835894
]
Benedict commented on CASSANDRA-3578:
-
bq. We don't assume that segments we
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835899#comment-13835899
]
Benedict commented on CASSANDRA-3578:
-
Nice catch on the RAF leak - I just copied
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835907#comment-13835907
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. Are you referring to the
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835910#comment-13835910
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. If there's no room, we
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835911#comment-13835911
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. I assumed that bit was to
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835912#comment-13835912
]
Benedict commented on CASSANDRA-3578:
-
Huh, just looked and I see what you mean.
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835914#comment-13835914
]
Benedict commented on CASSANDRA-3578:
-
bq. My point is that the no room case can
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835923#comment-13835923
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. We point next to next,
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835926#comment-13835926
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. we check for this by
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835927#comment-13835927
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. isFullySynced() is
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835265#comment-13835265
]
Benedict commented on CASSANDRA-3578:
-
bq. By the time we request sync in
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834743#comment-13834743
]
Benedict commented on CASSANDRA-3578:
-
bq. Does it still make sense to track
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834803#comment-13834803
]
Benedict commented on CASSANDRA-3578:
-
Thinking a little more on the PCLE
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834948#comment-13834948
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. We provide this guarantee
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834951#comment-13834951
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. if we rename the thread to
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834988#comment-13834988
]
Benedict commented on CASSANDRA-3578:
-
Was browsing your changes and noticed your
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835005#comment-13835005
]
Jonathan Ellis commented on CASSANDRA-3578:
---
+1
Multithreaded commitlog
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835049#comment-13835049
]
Benedict commented on CASSANDRA-3578:
-
bq. I dunno, and I realize my OCD is
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835060#comment-13835060
]
Benedict commented on CASSANDRA-3578:
-
Hmm.. Actually, now that I think about it
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835079#comment-13835079
]
Benedict commented on CASSANDRA-3578:
-
bq. How can we find out?
I just had a
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835179#comment-13835179
]
Jonathan Ellis commented on CASSANDRA-3578:
---
Dropped the Allocation refactor
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834545#comment-13834545
]
Jonathan Ellis commented on CASSANDRA-3578:
---
Working through this still:
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818685#comment-13818685
]
Vijay commented on CASSANDRA-3578:
--
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817147#comment-13817147
]
Benedict commented on CASSANDRA-3578:
-
bq. We don't guarantee that in
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815842#comment-13815842
]
Benedict commented on CASSANDRA-3578:
-
bq.
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815914#comment-13815914
]
Benedict commented on CASSANDRA-3578:
-
Okay, so thinking on this a little further,
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815973#comment-13815973
]
Jonathan Ellis commented on CASSANDRA-3578:
---
I like the chained headers
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815977#comment-13815977
]
Benedict commented on CASSANDRA-3578:
-
If we do neither (2) or my previous
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816113#comment-13816113
]
Jonathan Ellis commented on CASSANDRA-3578:
---
How ugly would it get to either
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816131#comment-13816131
]
Benedict commented on CASSANDRA-3578:
-
Well, one possibility is allocating a new
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816281#comment-13816281
]
Vijay commented on CASSANDRA-3578:
--
{quote}
You only call force when you think there
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816293#comment-13816293
]
Benedict commented on CASSANDRA-3578:
-
bq. when we see a corrupted columns (which
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816341#comment-13816341
]
Benedict commented on CASSANDRA-3578:
-
bq. Or because we haven't flushed because
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816344#comment-13816344
]
Vijay commented on CASSANDRA-3578:
--
{quote}
we could have A allocate, B begin sync, C
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816355#comment-13816355
]
Benedict commented on CASSANDRA-3578:
-
bq. I am talking about count all the
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816363#comment-13816363
]
Benedict commented on CASSANDRA-3578:
-
Please don't stop selling if you think I'm
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816935#comment-13816935
]
Vijay commented on CASSANDRA-3578:
--
:)
{quote}
The current implementation never ACKs
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815069#comment-13815069
]
Benedict commented on CASSANDRA-3578:
-
I liked the basic approach of your patch,
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815159#comment-13815159
]
Jonathan Ellis commented on CASSANDRA-3578:
---
How does your branch deal with
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815229#comment-13815229
]
Benedict commented on CASSANDRA-3578:
-
I left Vijay's solution mostly unchanged
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815240#comment-13815240
]
Jonathan Ellis commented on CASSANDRA-3578:
---
We do have
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815249#comment-13815249
]
Benedict commented on CASSANDRA-3578:
-
Ah, my mistake, it looks like this is the
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815253#comment-13815253
]
Jonathan Ellis commented on CASSANDRA-3578:
---
Yes, the versions correspond w/
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815272#comment-13815272
]
Benedict commented on CASSANDRA-3578:
-
Thanks. Repos updated.
Multithreaded
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815553#comment-13815553
]
Benedict commented on CASSANDRA-3578:
-
I think there are two further improvements
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815618#comment-13815618
]
Vijay commented on CASSANDRA-3578:
--
Hi Benedict,
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806473#comment-13806473
]
Vijay commented on CASSANDRA-3578:
--
Other option is replace recycle with discard, we
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806491#comment-13806491
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. are we talking about
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806193#comment-13806193
]
Vijay commented on CASSANDRA-3578:
--
Hi Jonathan,
{quote}
I must be missing where
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806006#comment-13806006
]
Jonathan Ellis commented on CASSANDRA-3578:
---
bq. The above takes a different
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801534#comment-13801534
]
Alex Liu commented on CASSANDRA-3578:
-
{quote}
The above takes a different
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801536#comment-13801536
]
Vijay commented on CASSANDRA-3578:
--
{quote}
It slows down the mutation thread by
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800570#comment-13800570
]
Jonathan Ellis commented on CASSANDRA-3578:
---
I take it that
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800990#comment-13800990
]
Jonathan Ellis commented on CASSANDRA-3578:
---
Hmm, interesting that the new
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801163#comment-13801163
]
Vijay commented on CASSANDRA-3578:
--
Yeah we do CAS instead of queue.take() in
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801496#comment-13801496
]
Vijay commented on CASSANDRA-3578:
--
Found the bottleneck in the current!
Actually
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799611#comment-13799611
]
Jonathan Ellis commented on CASSANDRA-3578:
---
Maybe it's worth doing a custom
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799612#comment-13799612
]
Vijay commented on CASSANDRA-3578:
--
Ohhh great idea, will give it a shot...
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13798746#comment-13798746
]
Vijay commented on CASSANDRA-3578:
--
Pushed my changes to
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773408#comment-13773408
]
Jonathan Ellis commented on CASSANDRA-3578:
---
I've seen several cases of
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223146#comment-13223146
]
Michaël Figuière commented on CASSANDRA-3578:
-
I've used this public
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196130#comment-13196130
]
Jonathan Ellis commented on CASSANDRA-3578:
---
Interesting that the author of
[
https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195902#comment-13195902
]
Michaël Figuière commented on CASSANDRA-3578:
-
I propose a different
78 matches
Mail list logo
