[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887225#comment-13887225
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Committed!
Remove
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887229#comment-13887229
]
Jonathan Ellis commented on CASSANDRA-5549:
---
(Please submit a pull request
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887295#comment-13887295
]
Benedict commented on CASSANDRA-5549:
-
Awesome! I've fixed the formatting, added a
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886121#comment-13886121
]
Benedict commented on CASSANDRA-5549:
-
I've rebased from trunk and fixed the bugs
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884276#comment-13884276
]
Jonathan Ellis commented on CASSANDRA-5549:
---
I'm seeing tests fail on both
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884285#comment-13884285
]
Benedict commented on CASSANDRA-5549:
-
Right, I'll take a look first thing
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884283#comment-13884283
]
Jonathan Ellis commented on CASSANDRA-5549:
---
(tried to squash only-5549 onto
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882570#comment-13882570
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Okay, went with plan B of
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882591#comment-13882591
]
Benedict commented on CASSANDRA-5549:
-
I'm not totally convinced this is better,
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882598#comment-13882598
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Fair enough.
Remove
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881584#comment-13881584
]
Jonathan Ellis commented on CASSANDRA-5549:
---
I think what I'm having a hard
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881588#comment-13881588
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Aside: we have one (two)
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881589#comment-13881589
]
Jonathan Ellis commented on CASSANDRA-5549:
---
I kind of like the Linked
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881626#comment-13881626
]
Benedict commented on CASSANDRA-5549:
-
bq. I think what I'm having a hard time
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881666#comment-13881666
]
Jonathan Ellis commented on CASSANDRA-5549:
---
bq. I can see your criticism of
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881668#comment-13881668
]
Benedict commented on CASSANDRA-5549:
-
MemoryTracker - PoolLedger
MemoryOwner -
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874786#comment-13874786
]
Benedict commented on CASSANDRA-5549:
-
I realised as I was going to sleep this
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874798#comment-13874798
]
Jonathan Ellis commented on CASSANDRA-5549:
---
With an alternative identified
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874815#comment-13874815
]
Benedict commented on CASSANDRA-5549:
-
bq. and we'll be good to go here.
Awesome.
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874817#comment-13874817
]
Jonathan Ellis commented on CASSANDRA-5549:
---
In the meantime, I've pushed a
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874824#comment-13874824
]
Benedict commented on CASSANDRA-5549:
-
issue() is the normal parlance when talking
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874831#comment-13874831
]
Jonathan Ellis commented on CASSANDRA-5549:
---
bq. issue() is the normal
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874840#comment-13874840
]
Benedict commented on CASSANDRA-5549:
-
bq. The problem is that it's not just a
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874878#comment-13874878
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Pushed seal back to issue and
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875379#comment-13875379
]
Benedict commented on CASSANDRA-5549:
-
Merged your changes, and pushed a version
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873300#comment-13873300
]
Benedict commented on CASSANDRA-5549:
-
bq. Do we rely on accept returning true
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874005#comment-13874005
]
Jonathan Ellis commented on CASSANDRA-5549:
---
WaitQueue has changed enough
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874043#comment-13874043
]
Jonathan Ellis commented on CASSANDRA-5549:
---
We have ANBQ - NBQV - NBQ, with
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874158#comment-13874158
]
Benedict commented on CASSANDRA-5549:
-
bq. We have ANBQ - NBQV - NBQ, with no
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874168#comment-13874168
]
Benedict commented on CASSANDRA-5549:
-
bq. WaitQueue has changed enough that git
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874175#comment-13874175
]
Benedict commented on CASSANDRA-5549:
-
Maybe split :
- WaitQueue, NBQ
- BTree
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874178#comment-13874178
]
Jonathan Ellis commented on CASSANDRA-5549:
---
When does CLQ block? Are you
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874191#comment-13874191
]
Benedict commented on CASSANDRA-5549:
-
bq. When does CLQ block? Are you thinking
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874262#comment-13874262
]
Benedict commented on CASSANDRA-5549:
-
FYI, on an unrelated note I've merged your
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871924#comment-13871924
]
Benedict commented on CASSANDRA-5549:
-
For accepts() to work correctly the Ordered
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873026#comment-13873026
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Do we rely on accept returning
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871641#comment-13871641
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Pushed more refactorage to my
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867933#comment-13867933
]
Benedict commented on CASSANDRA-5549:
-
I've merged your changes and removed all of
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867306#comment-13867306
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Comments so far:
Looks like
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867345#comment-13867345
]
Benedict commented on CASSANDRA-5549:
-
bq. Looks like the memtables.isEmpty path
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867373#comment-13867373
]
Benedict commented on CASSANDRA-5549:
-
As to your change at
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867396#comment-13867396
]
Jonathan Ellis commented on CASSANDRA-5549:
---
bq. I should mention that I
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867399#comment-13867399
]
Benedict commented on CASSANDRA-5549:
-
bq. I get that, but it's good hygiene to
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13864173#comment-13864173
]
Benedict commented on CASSANDRA-5549:
-
I just realised there was a fairly glaring
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863143#comment-13863143
]
Jonathan Ellis commented on CASSANDRA-5549:
---
What happens now when I hit my
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863148#comment-13863148
]
Benedict commented on CASSANDRA-5549:
-
Largely the same as before, the mutation
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861886#comment-13861886
]
Benedict commented on CASSANDRA-5549:
-
I have a patch available for this
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838782#comment-13838782
]
Benedict commented on CASSANDRA-5549:
-
bq. how does the switch RW Lock to a kind
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838796#comment-13838796
]
Vijay commented on CASSANDRA-5549:
--
Well it is not exactly a constant overhead you
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838802#comment-13838802
]
Benedict commented on CASSANDRA-5549:
-
For a given run of the JVM the overhead is
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838627#comment-13838627
]
Vijay commented on CASSANDRA-5549:
--
{quote}
Without switch lock, we won't have
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836818#comment-13836818
]
Benedict commented on CASSANDRA-5549:
-
Without switch lock, we won't have anything
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835123#comment-13835123
]
Benedict commented on CASSANDRA-5549:
-
I suggest the following (somewhat complex
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781214#comment-13781214
]
Vijay commented on CASSANDRA-5549:
--
Hi Ryan, Can you give a shot at
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750184#comment-13750184
]
Ryan McGuire commented on CASSANDRA-5549:
-
[~jbellis] I ran a benchmark
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750203#comment-13750203
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Was this on the 4 core
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750213#comment-13750213
]
Ryan McGuire commented on CASSANDRA-5549:
-
Yes, this is on the quad cores.
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750764#comment-13750764
]
Ryan McGuire commented on CASSANDRA-5549:
-
Looks pretty similar on the eight
[
https://issues.apache.org/jira/browse/CASSANDRA-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651624#comment-13651624
]
Jonathan Ellis commented on CASSANDRA-5549:
---
Rebased my switchLock-removal
59 matches
Mail list logo
