[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815952#comment-15815952
]
Ethan W commented on CASSANDRA-6271:
Hi [~benedict]
yes I mean in Cassandra.
This is my
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15809060#comment-15809060
]
Benedict commented on CASSANDRA-6271:
-
Do you mean in Cassandra, or more generally?
> Replace
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15809056#comment-15809056
]
Ethan W commented on CASSANDRA-6271:
Hi [~benedict],
I'm learning the data structure in SSTable.
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870696#comment-13870696
]
Benedict commented on CASSANDRA-6271:
-
LGTM.
Replace SnapTree in
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870700#comment-13870700
]
Sylvain Lebresne commented on CASSANDRA-6271:
-
As a side note, would have
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861806#comment-13861806
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Merged your branch and pushed
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860551#comment-13860551
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Moving on to Modifier[Level].
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860614#comment-13860614
]
Benedict commented on CASSANDRA-6271:
-
It sort of does, it just does it all in a
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860935#comment-13860935
]
Jonathan Ellis commented on CASSANDRA-6271:
---
bq. Splits the parent if
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860943#comment-13860943
]
Benedict commented on CASSANDRA-6271:
-
Sorry, was going from memory.
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859914#comment-13859914
]
Jonathan Ellis commented on CASSANDRA-6271:
---
What guarantees does ABT give
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859917#comment-13859917
]
Benedict commented on CASSANDRA-6271:
-
bq. If I start iterating from one version
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859921#comment-13859921
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Do we actually win anything by
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859925#comment-13859925
]
Benedict commented on CASSANDRA-6271:
-
bq. Do we actually win anything by making
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859926#comment-13859926
]
Jonathan Ellis commented on CASSANDRA-6271:
---
bq. We might want to optimise
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859930#comment-13859930
]
Benedict commented on CASSANDRA-6271:
-
bq. You mean as a threadlocal?
Probably
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859940#comment-13859940
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Okay, almost done with
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859941#comment-13859941
]
Benedict commented on CASSANDRA-6271:
-
bq. Why would we skip over all the
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859943#comment-13859943
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Can you make that change on
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859946#comment-13859946
]
Benedict commented on CASSANDRA-6271:
-
Updated and commented.
Replace SnapTree
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859956#comment-13859956
]
Jonathan Ellis commented on CASSANDRA-6271:
---
I still don't quite follow.
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859957#comment-13859957
]
Benedict commented on CASSANDRA-6271:
-
That's exactly what will happen. Note that
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859958#comment-13859958
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Ah, right.
How about this then
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859959#comment-13859959
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Actually, that breaks the case
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859960#comment-13859960
]
Benedict commented on CASSANDRA-6271:
-
Sure!
Replace SnapTree in
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859515#comment-13859515
]
Benedict commented on CASSANDRA-6271:
-
I've uploaded an [updated
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859581#comment-13859581
]
Benedict commented on CASSANDRA-6271:
-
Ah, and I just realised I made a major
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859658#comment-13859658
]
Jonathan Ellis commented on CASSANDRA-6271:
---
bq. We can't re-use any
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859679#comment-13859679
]
Benedict commented on CASSANDRA-6271:
-
bq. Not mixing parameter-state with
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858973#comment-13858973
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Why doesn't ML.update need to
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858975#comment-13858975
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Also, what's going on here?
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858987#comment-13858987
]
Jonathan Ellis commented on CASSANDRA-6271:
---
{code}
// true iff this
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858989#comment-13858989
]
Jonathan Ellis commented on CASSANDRA-6271:
---
{code}
// buffer for
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859013#comment-13859013
]
Jonathan Ellis commented on CASSANDRA-6271:
---
{noformat}
$ ant long-test
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859020#comment-13859020
]
Jonathan Ellis commented on CASSANDRA-6271:
---
{code}
int c =
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859026#comment-13859026
]
Benedict commented on CASSANDRA-6271:
-
bq. How do we get into a situation where
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859037#comment-13859037
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Having consumeNextLeaf
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859134#comment-13859134
]
Benedict commented on CASSANDRA-6271:
-
bq. Having consumeNextLeaf sometimes
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859136#comment-13859136
]
Benedict commented on CASSANDRA-6271:
-
bq. [junit] No runnable methods
Sorry,
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859137#comment-13859137
]
Jonathan Ellis commented on CASSANDRA-6271:
---
bq. If it isn't a leaf, a
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859181#comment-13859181
]
Benedict commented on CASSANDRA-6271:
-
bq. I'll refactor into an actual JUnit test
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859191#comment-13859191
]
Jonathan Ellis commented on CASSANDRA-6271:
---
The way Stack abuses succ/prev
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859198#comment-13859198
]
Jonathan Ellis commented on CASSANDRA-6271:
---
bq. The repository has been
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857796#comment-13857796
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Pushed review-in-progress to
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857819#comment-13857819
]
Benedict commented on CASSANDRA-6271:
-
bq. Suspicious that Stack.compareTo ignores
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857829#comment-13857829
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Where do we do node
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857830#comment-13857830
]
Benedict commented on CASSANDRA-6271:
-
We only ever add, so we only ever need to
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833644#comment-13833644
]
Benedict commented on CASSANDRA-6271:
-
bq. Also
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834012#comment-13834012
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Pulled that out to
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833506#comment-13833506
]
Jonathan Ellis commented on CASSANDRA-6271:
---
bq. Note that this patch does
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833512#comment-13833512
]
Aleksey Yeschenko commented on CASSANDRA-6271:
--
Also
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833521#comment-13833521
]
Jonathan Ellis commented on CASSANDRA-6271:
---
Hmm, right.
Probably still
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809185#comment-13809185
]
Jonathan Ellis commented on CASSANDRA-6271:
---
bq. I suggest using a sorted
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809261#comment-13809261
]
Benedict commented on CASSANDRA-6271:
-
bq. Doesn't this fail miserably for large
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809277#comment-13809277
]
Brandon Williams commented on CASSANDRA-6271:
-
We need to take care that
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809278#comment-13809278
]
Jonathan Ellis commented on CASSANDRA-6271:
---
bq. For more than a few
[
https://issues.apache.org/jira/browse/CASSANDRA-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809294#comment-13809294
]
Benedict commented on CASSANDRA-6271:
-
[~brandon.williams] Agreed. It needs to be
57 matches
Mail list logo
