[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153528#comment-16153528
]
Jason Brown commented on CASSANDRA-8457:
[~spo...@gmail.com] ahh! you are correct. ninja-fixed
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152574#comment-16152574
]
Stefan Podkowinski commented on CASSANDRA-8457:
---
[~jasobrown], did you forget to bump
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136520#comment-16136520
]
Sylvain Lebresne commented on CASSANDRA-8457:
-
Yes, I'm +1 on the patch on this specific
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135790#comment-16135790
]
sankalp kohli commented on CASSANDRA-8457:
--
[~slebresne] I know you and Jason chatted on
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102128#comment-16102128
]
Jason Brown commented on CASSANDRA-8457:
dtests running locally, including upgrade and
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062157#comment-16062157
]
Jason Brown commented on CASSANDRA-8457:
bq. Nit: there has been a few Netty minor released
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028159#comment-16028159
]
Sylvain Lebresne commented on CASSANDRA-8457:
-
Had a quick look at the last changes. A few
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996536#comment-15996536
]
Jason Brown commented on CASSANDRA-8457:
latest changes:
- add netty's {{IdleStateHandler}}
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968472#comment-15968472
]
Jason Brown commented on CASSANDRA-8457:
So, [~aweisberg] and I spent some time talking
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967621#comment-15967621
]
Jason Brown commented on CASSANDRA-8457:
bq. doesn't Netty already have a standard way to deal
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967586#comment-15967586
]
Jason Brown commented on CASSANDRA-8457:
bq. doesn't Netty already have a standard way to deal
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967568#comment-15967568
]
Sylvain Lebresne commented on CASSANDRA-8457:
-
bq. I think it's important that a single
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967513#comment-15967513
]
Jason Brown commented on CASSANDRA-8457:
[~aweisberg] and I spoke with Scott Mitchell of the
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966390#comment-15966390
]
Jason Brown commented on CASSANDRA-8457:
[~aweisberg] So, I've kicked this idea around a bit
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966293#comment-15966293
]
Ariel Weisberg commented on CASSANDRA-8457:
---
bq. But was that even a good idea? I'm not
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965767#comment-15965767
]
Jason Brown commented on CASSANDRA-8457:
bq. you seem to have squashed everything ...
Yes,
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963989#comment-15963989
]
Sylvain Lebresne commented on CASSANDRA-8457:
-
bq. One remaining open issue is the current
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956759#comment-15956759
]
Jason Brown commented on CASSANDRA-8457:
belatedly adding support for ssl hostname
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950929#comment-15950929
]
Jason Brown commented on CASSANDRA-8457:
rebased my branch on trunk as of 2017-Mar-28, and
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944223#comment-15944223
]
Jason Brown commented on CASSANDRA-8457:
[~norman] if you want to give it another shot, i'm
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943172#comment-15943172
]
Norman Maurer commented on CASSANDRA-8457:
--
[~jasobrown] let me know if I should review the
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943160#comment-15943160
]
Jason Brown commented on CASSANDRA-8457:
- I really like what you've done with
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925803#comment-15925803
]
Sylvain Lebresne commented on CASSANDRA-8457:
-
Finally got time to look at the new
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868315#comment-15868315
]
Jason Brown commented on CASSANDRA-8457:
[~jjordan] That's a fair assessment. I'll table the
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868140#comment-15868140
]
Jeremiah Jordan commented on CASSANDRA-8457:
Is adding more complexity to this already
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868091#comment-15868091
]
Ariel Weisberg commented on CASSANDRA-8457:
---
{quote}
Thus, I propose to bring back the
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865754#comment-15865754
]
Jason Brown commented on CASSANDRA-8457:
rebased, and pulled in CASSANDRA-13090
> nio
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864943#comment-15864943
]
Jason Brown commented on CASSANDRA-8457:
One other thing [~aweisberg] and I discussed was
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864888#comment-15864888
]
Jason Brown commented on CASSANDRA-8457:
Thanks to [~aweisberg], caught another race condition
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863760#comment-15863760
]
Norman Maurer commented on CASSANDRA-8457:
--
[~jasobrown] whooot :) I will do another review
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863758#comment-15863758
]
Jason Brown commented on CASSANDRA-8457:
OK, so I've been performance load testing the snot of
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735327#comment-15735327
]
Jason Brown commented on CASSANDRA-8457:
Ok, [~slebresne], next round of review is ready :)
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643999#comment-15643999
]
Sylvain Lebresne commented on CASSANDRA-8457:
-
Alright, here's a new round of reviews:
*
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583503#comment-15583503
]
Jason Brown commented on CASSANDRA-8457:
Addressed a few problems due to failing dtests. The
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527775#comment-15527775
]
Jason Brown commented on CASSANDRA-8457:
TL;DR - I've addressed everything except for the
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523138#comment-15523138
]
Sylvain Lebresne commented on CASSANDRA-8457:
-
Here comes more review bits, though it's
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514498#comment-15514498
]
Jason Brown commented on CASSANDRA-8457:
I've pushed a couple commits to the same branch, and
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508103#comment-15508103
]
Jason Brown commented on CASSANDRA-8457:
re: {{LegacyClientHandler}}, and v3 vs v4 (or, "to
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502872#comment-15502872
]
Sylvain Lebresne commented on CASSANDRA-8457:
-
I'm still very much in the process of
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419276#comment-15419276
]
Jason Brown commented on CASSANDRA-8457:
rebased and cleaned up some of the error
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372251#comment-15372251
]
Jason Brown commented on CASSANDRA-8457:
I've pushed a new commit to the same branch after
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370179#comment-15370179
]
Norman Maurer commented on CASSANDRA-8457:
--
[~jasobrown] I did a first review-round and left
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368604#comment-15368604
]
Jason Brown commented on CASSANDRA-8457:
Here's the first pass at switching internode
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141370#comment-15141370
]
Norman Maurer commented on CASSANDRA-8457:
--
[~jasobrown] you know where to find me ;)
> nio
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271701#comment-14271701
]
Ariel Weisberg commented on CASSANDRA-8457:
---
Took a stab at writing an
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268221#comment-14268221
]
Ariel Weisberg commented on CASSANDRA-8457:
---
I wanted to account for the
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266963#comment-14266963
]
Ariel Weisberg commented on CASSANDRA-8457:
---
I ran on GCE. 11 n1-highcpu-16,
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266422#comment-14266422
]
Ariel Weisberg commented on CASSANDRA-8457:
---
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266402#comment-14266402
]
Ariel Weisberg commented on CASSANDRA-8457:
---
I think I stumbled onto what is
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263096#comment-14263096
]
Ariel Weisberg commented on CASSANDRA-8457:
---
i can't get performance
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260565#comment-14260565
]
Ariel Weisberg commented on CASSANDRA-8457:
---
I reran this with placement
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256293#comment-14256293
]
Ariel Weisberg commented on CASSANDRA-8457:
---
Testing on AWS with 6 client
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256326#comment-14256326
]
Ariel Weisberg commented on CASSANDRA-8457:
---
Repeating these benchmarks,
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249678#comment-14249678
]
Benedict commented on CASSANDRA-8457:
-
A couple of comments on the code:
#
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249854#comment-14249854
]
sankalp kohli commented on CASSANDRA-8457:
--
I agree with [~iamaleksey]. We
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249884#comment-14249884
]
T Jake Luciani commented on CASSANDRA-8457:
---
This test doesn't deal with the
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249930#comment-14249930
]
Ariel Weisberg commented on CASSANDRA-8457:
---
#1 The wakeup is protected by a
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249940#comment-14249940
]
Benedict commented on CASSANDRA-8457:
-
bq. The only way to avoid it is to lock
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249943#comment-14249943
]
Ariel Weisberg commented on CASSANDRA-8457:
---
Well there you have it. Thanks
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249085#comment-14249085
]
Ariel Weisberg commented on CASSANDRA-8457:
---
I have some code and results.
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249139#comment-14249139
]
Jonathan Ellis commented on CASSANDRA-8457:
---
TLDR throughput is about the
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249237#comment-14249237
]
Ariel Weisberg commented on CASSANDRA-8457:
---
For me the TLDR is that they
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249242#comment-14249242
]
Aleksey Yeschenko commented on CASSANDRA-8457:
--
Were we expecting any
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243924#comment-14243924
]
Benedict commented on CASSANDRA-8457:
-
bq. cstar doesn't support multiple stress
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244239#comment-14244239
]
Ryan McGuire commented on CASSANDRA-8457:
-
I've just tried to bring up a 25
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244258#comment-14244258
]
Ryan McGuire commented on CASSANDRA-8457:
-
@Benedict modifying cstar_perf to
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244297#comment-14244297
]
Benedict commented on CASSANDRA-8457:
-
[~enigmacurry] if we could fire up EC2
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242859#comment-14242859
]
Benedict commented on CASSANDRA-8457:
-
FTR, I strongly doubt _context switching_
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243008#comment-14243008
]
Ariel Weisberg commented on CASSANDRA-8457:
---
bq. To establish if there's
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243095#comment-14243095
]
T Jake Luciani commented on CASSANDRA-8457:
---
bq. Running a representative
[
https://issues.apache.org/jira/browse/CASSANDRA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243188#comment-14243188
]
Ariel Weisberg commented on CASSANDRA-8457:
---
Thank's Jake that is a good
71 matches
Mail list logo
