[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390630#comment-14390630
]
Benedict commented on CASSANDRA-8670:
-
bq. We should also assert that the buffer w
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390598#comment-14390598
]
Benedict commented on CASSANDRA-8670:
-
bq. Also on trying to understand code cache
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390595#comment-14390595
]
Ariel Weisberg commented on CASSANDRA-8670:
---
On more thinking I don't think
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390570#comment-14390570
]
Ariel Weisberg commented on CASSANDRA-8670:
---
CASSANDRA-8887 would be part of
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390561#comment-14390561
]
Benedict commented on CASSANDRA-8670:
-
bq. In most cases we opt to use the channel
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390541#comment-14390541
]
Ariel Weisberg commented on CASSANDRA-8670:
---
In what scenarios do we end up
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390405#comment-14390405
]
Benedict commented on CASSANDRA-8670:
-
bq. What I don't understand is why
Java_ja
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390400#comment-14390400
]
Robert Stupp commented on CASSANDRA-8670:
-
Your assumption is correct
{{jdk/s
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388757#comment-14388757
]
Ariel Weisberg commented on CASSANDRA-8670:
---
Unit tets pass and I am +1 on y
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388515#comment-14388515
]
Benedict commented on CASSANDRA-8670:
-
I've pushed one more round of changes
[her
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386852#comment-14386852
]
Benedict commented on CASSANDRA-8670:
-
I've just pushed another update, which undo
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386007#comment-14386007
]
Benedict commented on CASSANDRA-8670:
-
I've pushed some suggestions for further re
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384556#comment-14384556
]
Ariel Weisberg commented on CASSANDRA-8670:
---
I think I covered what we talke
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382732#comment-14382732
]
Benedict commented on CASSANDRA-8670:
-
bq. to not have to worry about it ever
I'm
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382709#comment-14382709
]
Ariel Weisberg commented on CASSANDRA-8670:
---
bq. In this scenario it is like
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382646#comment-14382646
]
Benedict commented on CASSANDRA-8670:
-
bq. By assert you mean an assert that compi
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382524#comment-14382524
]
Ariel Weisberg commented on CASSANDRA-8670:
---
NIODataInputStream
bq. readNext
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381722#comment-14381722
]
Benedict commented on CASSANDRA-8670:
-
bq. What tool are you using to review?
I l
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379897#comment-14379897
]
Ariel Weisberg commented on CASSANDRA-8670:
---
What tool are you using to revi
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379647#comment-14379647
]
Benedict commented on CASSANDRA-8670:
-
bq. Do you want to see it commit by commit
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378930#comment-14378930
]
Benedict commented on CASSANDRA-8670:
-
bq. I am in favor of doing whatever doesn't
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378902#comment-14378902
]
Ariel Weisberg commented on CASSANDRA-8670:
---
Do you want to see it commit by
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378807#comment-14378807
]
Benedict commented on CASSANDRA-8670:
-
Could we get the patch rebased so that all
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366114#comment-14366114
]
Ariel Weisberg commented on CASSANDRA-8670:
---
I can confirm that compression
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364086#comment-14364086
]
Ariel Weisberg commented on CASSANDRA-8670:
---
I have a dtest that can reprodu
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358866#comment-14358866
]
Ariel Weisberg commented on CASSANDRA-8670:
---
I am getting to this now. Shoul
[
https://issues.apache.org/jira/browse/CASSANDRA-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351742#comment-14351742
]
Evin Callahan commented on CASSANDRA-8670:
--
What's the path forward on this?
27 matches
Mail list logo