[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360030#comment-14360030 ] Marcus Eriksson commented on CASSANDRA-8833: [~thobbs] do we have any

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360188#comment-14360188 ] Benedict commented on CASSANDRA-8833: - At the risk of sounding like a broken

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352980#comment-14352980 ] Ryan McGuire commented on CASSANDRA-8833: - [~benedict] I think what

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353003#comment-14353003 ] Benedict commented on CASSANDRA-8833: - bq. I think it would be OK to run it

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352991#comment-14352991 ] Benedict commented on CASSANDRA-8833: - bq. run the exact same test that works

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352999#comment-14352999 ] Marcus Eriksson commented on CASSANDRA-8833: [~enigmacurry] sure, that

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352815#comment-14352815 ] Benedict commented on CASSANDRA-8833: - bq. run benchmarks again, this time on ssds

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353097#comment-14353097 ] Tyler Hobbs commented on CASSANDRA-8833: bq. see if we can solve the index

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352719#comment-14352719 ] Marcus Eriksson commented on CASSANDRA-8833: Coming back to this, what I

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329192#comment-14329192 ] Matt Stump commented on CASSANDRA-8833: --- I'm not against refactoring of

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329221#comment-14329221 ] T Jake Luciani commented on CASSANDRA-8833: --- I think the reason pre-opening

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329253#comment-14329253 ] Benedict commented on CASSANDRA-8833: - I'm not sure I follow. Is your comment

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329257#comment-14329257 ] Benedict commented on CASSANDRA-8833: - bq. pre-opening basically makes them

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327970#comment-14327970 ] Benedict commented on CASSANDRA-8833: - bq. I suspect that memory mapping will

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328025#comment-14328025 ] Benedict commented on CASSANDRA-8833: - bq. there may be unintended side-effects to

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328019#comment-14328019 ] Joshua McKenzie commented on CASSANDRA-8833: bq. Make your mind up Touché.

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327612#comment-14327612 ] Jonathan Ellis commented on CASSANDRA-8833: --- /cc [~pmcfadin] [~mstump]

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327961#comment-14327961 ] Joshua McKenzie commented on CASSANDRA-8833: Regarding Windows: early

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328236#comment-14328236 ] Benedict commented on CASSANDRA-8833: - bq. Ah - so the 9%

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327688#comment-14327688 ] Benedict commented on CASSANDRA-8833: - We still have to deal with the complexity

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327685#comment-14327685 ] Marcus Eriksson commented on CASSANDRA-8833: bq. SSTableReader lifecycles

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327699#comment-14327699 ] Benedict commented on CASSANDRA-8833: - The TL;DR of my view is: We've only just

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327678#comment-14327678 ] Benedict commented on CASSANDRA-8833: - Well, it certainly has turned out to be

[jira] [Commented] (CASSANDRA-8833) Stop opening compaction results early

[ https://issues.apache.org/jira/browse/CASSANDRA-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327746#comment-14327746 ] Marcus Eriksson commented on CASSANDRA-8833: I agree that we might almost