Jordan West created CASSANDRA-15798:
---------------------------------------

             Summary: Only calculate 1.0 + dynamicBadnessThreshold once per 
loop in DynamicEndpointSnitch
                 Key: CASSANDRA-15798
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15798
             Project: Cassandra
          Issue Type: Bug
          Components: Messaging/Internode
            Reporter: Jordan West
            Assignee: Jordan West


The change to make dynamicBadnessThreshold volatile and mutable in 
https://issues.apache.org/jira/browse/CASSANDRA-12179 could have minor 
implications for the performance of this code: 
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/locator/DynamicEndpointSnitch.java#L216.
 Its better to calculate this once before the loop starts, which has the added 
benefit that the value is stable throughout the calculation as well. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to