[jira] [Updated] (CASSANDRA-16027) bin/cassandra may fail to execute in certain environments due to unhandled output pipe
[
https://issues.apache.org/jira/browse/CASSANDRA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Bradford updated CASSANDRA-16027:
-
Description:
While developing Docker images for C* 3.11.6 I noticed bin/cassandra failed to
start when executed with nohup in a container based Red Hat Universal Base
Image on Kubernetes. Curiously this issue could not be reproduced when simply
running the container on Docker. Instead it had to be scheduled within a k8s
pod.
Running an strace indicates the following:
{code:java}
[pid 3666026] write(2, "OpenJDK 64-Bit Server VM warning: ", 34) = -1 EPIPE
(Broken pipe) {code}
The issue occurs before the system.log file is created. After further digging
in to the command being run it was determined the bin/cassandra file was not
redirecting all output pipes. In this particular environment this leads to the
process going defunct and no Cassandra running.
The 4 lines starting with
{code:java}
exec $NUMACTL {code}
are not handling one of the outputs (stderr or stdout). As a workaround
suffixing each line with
{code:java}
> /var/log/cassandra/stdout.log 2> /var/log/cassandra/stderr.log
{code}
{{resolves the issue and Cassandra starts without any issues.}}
{{Rather than bake this into our containers the fix should make its way
upstream.}}
was:
While developing Docker images for C* 3.11.6 I noticed bin/cassandra failed to
start when executed with nohup in a container based Red Hat Universal Base
Image on Kubernetes. Curiously this issue could not be reproduced when simply
running the container on Docker. Instead it had to be scheduled within a k8s
pod.
Running an strace indicates the following:
{code:java}
[pid 3666026] write(2, "OpenJDK 64-Bit Server VM warning: ", 34) = -1 EPIPE
(Broken pipe) {code}
The issue occurs before the system.log file is created. After further digging
in to the command being run it was determined the bin/cassandra file was not
redirecting all output pipes. In this particular environment this leads to the
process going defunct and no Cassandra running.
{{The 4 lines starting with }}
{code:java}
exec $NUMACTL {code}
{{are not handling one of the outputs (stderr or stdout). As a workaround
suffixing each line with }}
{code:java}
> /var/log/cassandra/stdout.log 2> /var/log/cassandra/stderr.log
{code}
{{resolves the issue and Cassandra starts without any issues.}}
{{Rather than bake this into our containers the fix should make its way
upstream.}}
> bin/cassandra may fail to execute in certain environments due to unhandled
> output pipe
> --
>
> Key: CASSANDRA-16027
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16027
> Project: Cassandra
> Issue Type: Bug
>Reporter: Christopher Bradford
>Priority: Normal
>
> While developing Docker images for C* 3.11.6 I noticed bin/cassandra failed
> to start when executed with nohup in a container based Red Hat Universal Base
> Image on Kubernetes. Curiously this issue could not be reproduced when simply
> running the container on Docker. Instead it had to be scheduled within a k8s
> pod.
>
> Running an strace indicates the following:
> {code:java}
> [pid 3666026] write(2, "OpenJDK 64-Bit Server VM warning: ", 34) = -1 EPIPE
> (Broken pipe) {code}
>
> The issue occurs before the system.log file is created. After further digging
> in to the command being run it was determined the bin/cassandra file was not
> redirecting all output pipes. In this particular environment this leads to
> the process going defunct and no Cassandra running.
>
> The 4 lines starting with
> {code:java}
> exec $NUMACTL {code}
> are not handling one of the outputs (stderr or stdout). As a workaround
> suffixing each line with
> {code:java}
> > /var/log/cassandra/stdout.log 2> /var/log/cassandra/stderr.log
> {code}
> {{resolves the issue and Cassandra starts without any issues.}}
>
> {{Rather than bake this into our containers the fix should make its way
> upstream.}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16027) bin/cassandra may fail to execute in certain environments due to unhandled output pipe
Christopher Bradford created CASSANDRA-16027:
Summary: bin/cassandra may fail to execute in certain environments
due to unhandled output pipe
Key: CASSANDRA-16027
URL: https://issues.apache.org/jira/browse/CASSANDRA-16027
Project: Cassandra
Issue Type: Bug
Reporter: Christopher Bradford
While developing Docker images for C* 3.11.6 I noticed bin/cassandra failed to
start when executed with nohup in a container based Red Hat Universal Base
Image on Kubernetes. Curiously this issue could not be reproduced when simply
running the container on Docker. Instead it had to be scheduled within a k8s
pod.
Running an strace indicates the following:
{code:java}
[pid 3666026] write(2, "OpenJDK 64-Bit Server VM warning: ", 34) = -1 EPIPE
(Broken pipe) {code}
The issue occurs before the system.log file is created. After further digging
in to the command being run it was determined the bin/cassandra file was not
redirecting all output pipes. In this particular environment this leads to the
process going defunct and no Cassandra running.
{{The 4 lines starting with }}
{code:java}
exec $NUMACTL {code}
{{are not handling one of the outputs (stderr or stdout). As a workaround
suffixing each line with }}
{code:java}
> /var/log/cassandra/stdout.log 2> /var/log/cassandra/stderr.log
{code}
{{resolves the issue and Cassandra starts without any issues.}}
{{Rather than bake this into our containers the fix should make its way
upstream.}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15585) 4.0 quality testing: Test Frameworks, Tooling, Infra / Automation
[ https://issues.apache.org/jira/browse/CASSANDRA-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15585: -- Change Category: Quality Assurance Complexity: Normal Status: Open (was: Triage Needed) > 4.0 quality testing: Test Frameworks, Tooling, Infra / Automation > - > > Key: CASSANDRA-15585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15585 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.0-beta > > > Reference [doc from > NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] > for context. > *Shepherd: Jordan West* > This area refers to contributions to test frameworks/tooling (e.g., dtests, > QuickTheories, CASSANDRA-14821), and automation enabling those tools to be > applied at scale (e.g., replay testing via Spark-based replay of captured FQL > logs). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15585) 4.0 quality testing: Test Frameworks, Tooling, Infra / Automation
[ https://issues.apache.org/jira/browse/CASSANDRA-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-15585: -- Status: Triage Needed (was: Awaiting Feedback) > 4.0 quality testing: Test Frameworks, Tooling, Infra / Automation > - > > Key: CASSANDRA-15585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15585 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Priority: Normal > Fix For: 4.0-beta > > > Reference [doc from > NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] > for context. > *Shepherd: Jordan West* > This area refers to contributions to test frameworks/tooling (e.g., dtests, > QuickTheories, CASSANDRA-14821), and automation enabling those tools to be > applied at scale (e.g., replay testing via Spark-based replay of captured FQL > logs). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13701) Lower default num_tokens
[ https://issues.apache.org/jira/browse/CASSANDRA-13701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-13701: -- Fix Version/s: (was: 4.0-alpha) 4.0-beta > Lower default num_tokens > > > Key: CASSANDRA-13701 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13701 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Chris Lohfink >Assignee: Jeremy Hanna >Priority: Low > Fix For: 4.0-beta > > > For reasons highlighted in CASSANDRA-7032, the high number of vnodes is not > necessary. It is very expensive for operations processes and scanning. Its > come up a lot and its pretty standard and known now to always reduce the > num_tokens within the community. We should just lower the defaults. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15234) Standardise config and JVM parameters
[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-15234:
--
Fix Version/s: (was: 4.0-alpha)
4.0-beta
> Standardise config and JVM parameters
> -
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Benedict Elliott Smith
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15299) CASSANDRA-13304 follow-up: improve checksumming and compression in protocol v5-beta
[
https://issues.apache.org/jira/browse/CASSANDRA-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-15299:
--
Fix Version/s: (was: 4.0-alpha)
4.0-beta
> CASSANDRA-13304 follow-up: improve checksumming and compression in protocol
> v5-beta
> ---
>
> Key: CASSANDRA-15299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15299
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Client
>Reporter: Aleksey Yeschenko
>Assignee: Alex Petrov
>Priority: Normal
> Labels: protocolv5
> Fix For: 4.0-beta
>
>
> CASSANDRA-13304 made an important improvement to our native protocol: it
> introduced checksumming/CRC32 to request and response bodies. It’s an
> important step forward, but it doesn’t cover the entire stream. In
> particular, the message header is not covered by a checksum or a crc, which
> poses a correctness issue if, for example, {{streamId}} gets corrupted.
> Additionally, we aren’t quite using CRC32 correctly, in two ways:
> 1. We are calculating the CRC32 of the *decompressed* value instead of
> computing the CRC32 on the bytes written on the wire - losing the properties
> of the CRC32. In some cases, due to this sequencing, attempting to decompress
> a corrupt stream can cause a segfault by LZ4.
> 2. When using CRC32, the CRC32 value is written in the incorrect byte order,
> also losing some of the protections.
> See https://users.ece.cmu.edu/~koopman/pubs/KoopmanCRCWebinar9May2012.pdf for
> explanation for the two points above.
> Separately, there are some long-standing issues with the protocol - since
> *way* before CASSANDRA-13304. Importantly, both checksumming and compression
> operate on individual message bodies rather than frames of multiple complete
> messages. In reality, this has several important additional downsides. To
> name a couple:
> # For compression, we are getting poor compression ratios for smaller
> messages - when operating on tiny sequences of bytes. In reality, for most
> small requests and responses we are discarding the compressed value as it’d
> be smaller than the uncompressed one - incurring both redundant allocations
> and compressions.
> # For checksumming and CRC32 we pay a high overhead price for small messages.
> 4 bytes extra is *a lot* for an empty write response, for example.
> To address the correctness issue of {{streamId}} not being covered by the
> checksum/CRC32 and the inefficiency in compression and checksumming/CRC32, we
> should switch to a framing protocol with multiple messages in a single frame.
> I suggest we reuse the framing protocol recently implemented for internode
> messaging in CASSANDRA-15066 to the extent that its logic can be borrowed,
> and that we do it before native protocol v5 graduates from beta. See
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/FrameDecoderCrc.java
> and
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/FrameDecoderLZ4.java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14559) Check for endpoint collision with hibernating nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14559: - Fix Version/s: (was: 3.11.x) 3.11.8 3.0.22 Since Version: 1.0.0 Source Control Link: https://github.com/apache/cassandra/commit/c94ececec0fcd87459858370396d6cd586853787 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed. > Check for endpoint collision with hibernating nodes > > > Key: CASSANDRA-14559 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14559 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Bootstrap and Decommission >Reporter: Vincent White >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.22, 3.11.8, 4.0-beta2 > > Time Spent: 20m > Remaining Estimate: 0h > > I ran across an edge case when replacing a node with the same address. This > issue results in the node(and its tokens) being unsafely removed from gossip. > Steps to replicate: > 1. Create 3 node cluster. > 2. Stop a node > 3. Replace the stopped node with a node using the same address using the > replace_address flag > 4. Stop the node before it finishes bootstrapping > 5. Remove the replace_address flag and restart the node to resume > bootstrapping (if the data dir is also cleared at this point the node will > also generate new tokens when it starts) > 6. Stop the node before it finishes bootstrapping again > 7. 30 Seconds later the node will be removed from gossip because it now > matches the check for a FatClient > I think this is only an issue when replacing a node with the same address > because other replacements now use STATUS_BOOTSTRAPPING_REPLACE and leave the > dead node unchanged. > I believe the simplest fix for this is to add a check that prevents a > non-bootstrapped node (without the replaces_address flag) starting if there > is a gossip entry for the same address in the hibernate state. > [3.11 PoC > |https://github.com/apache/cassandra/compare/trunk...vincewhite:check_for_hibernate_on_start] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (0310a7e -> 7976777)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 0310a7e Merge branch 'cassandra-3.0' into cassandra-3.11 new c94ecec Check for endpoint collision with hibernating nodes new 7976777 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + src/java/org/apache/cassandra/gms/Gossiper.java | 19 --- 2 files changed, 17 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (5d968e6 -> f8f0c46)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 5d968e6 computeMaxTTL directly before fetching TTL in TTLTest new c94ecec Check for endpoint collision with hibernating nodes new 7976777 Merge branch 'cassandra-3.0' into cassandra-3.11 new f8f0c46 Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + src/java/org/apache/cassandra/gms/Gossiper.java | 19 --- 2 files changed, 17 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch master updated: Test and supporting classes for CASSANDRA-14559
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/master by this push:
new 31ea621 Test and supporting classes for CASSANDRA-14559
31ea621 is described below
commit 31ea621d583695ccaf10471f561d2ff45ad9df58
Author: Tim Suess
AuthorDate: Fri Jul 27 15:35:46 2018 +1000
Test and supporting classes for CASSANDRA-14559
Patch by Stefan Miklosovic, reviewed by brandonwilliams for
CASSANDRA-14559
---
bootstrap_test.py | 91 ---
tools/intervention.py | 10 ++
2 files changed, 96 insertions(+), 5 deletions(-)
diff --git a/bootstrap_test.py b/bootstrap_test.py
index 927468d..e0decb6 100644
--- a/bootstrap_test.py
+++ b/bootstrap_test.py
@@ -10,8 +10,7 @@ import signal
from cassandra import ConsistencyLevel
from cassandra.concurrent import execute_concurrent_with_args
-from ccmlib.node import NodeError, TimeoutError, ToolError
-from ccmlib.node import TimeoutError
+from ccmlib.node import NodeError, TimeoutError, ToolError, Node
import pytest
@@ -21,9 +20,8 @@ from dtest import Tester, create_ks, create_cf, data_size
from tools.assertions import (assert_almost_equal, assert_bootstrap_state,
assert_not_running,
assert_one, assert_stderr_clean)
from tools.data import query_c1c2
-from tools.intervention import InterruptBootstrap, KillOnBootstrap
-from tools.misc import new_node
-from tools.misc import generate_ssl_stores
+from tools.intervention import InterruptBootstrap, KillOnBootstrap,
KillOnReadyToBootstrap
+from tools.misc import new_node, generate_ssl_stores
since = pytest.mark.since
logger = logging.getLogger(__name__)
@@ -659,6 +657,89 @@ class TestBootstrap(Tester):
node2.start(wait_other_notice=True)
node2.watch_log_for("JOINING:", from_mark=mark)
+@since('3.0')
+def
test_node_cannot_join_as_hibernating_node_without_replace_address(self):
+"""
+@jira_ticket CASSANDRA-14559
+Test that a node cannot bootstrap without replace_address if a
hibernating node exists with that address
+"""
+cluster = self.cluster
+cluster.populate(2)
+# Setting seed node to first node to make sure replaced node is not in
own seed list
+cluster.set_configuration_options({
+'seed_provider': [{'class_name':
'org.apache.cassandra.locator.SimpleSeedProvider',
+ 'parameters': [{'seeds': '127.0.0.1'}]
+ }]
+})
+
+cluster.start(wait_for_binary_proto=True)
+
+node1 = cluster.nodelist()[0]
+node2 = cluster.nodelist()[1]
+
+replacement_address = node2.address()
+node2.stop()
+
+jvm_option = 'replace_address'
+
+logger.debug("Starting replacement node {} with jvm_option
'{}={}'".format(replacement_address, jvm_option,
+
replacement_address))
+replacement_node = Node('replacement', cluster=self.cluster,
auto_bootstrap=True,
+thrift_interface=None,
storage_interface=(replacement_address, 7000),
+jmx_port='7400', remote_debug_port='0',
initial_token=None,
+binary_interface=(replacement_address, 9042))
+cluster.add(replacement_node, False)
+
+extra_jvm_args = []
+extra_jvm_args.extend(["-Dcassandra.{}={}".format(jvm_option,
replacement_address),
+ "-Dcassandra.ring_delay_ms=1",
+ "-Dcassandra.broadcast_interval_ms=1"])
+
+wait_other_notice = False
+wait_for_binary_proto = False
+
+# Killing node earlier in bootstrap to prevent node making it to
'normal' status.
+t = KillOnReadyToBootstrap(replacement_node)
+
+t.start()
+
+replacement_node.start(jvm_args=extra_jvm_args,
+ wait_for_binary_proto=wait_for_binary_proto,
wait_other_notice=wait_other_notice)
+
+t.join()
+
+logger.debug("Asserting that original replacement node is not running")
+assert not replacement_node.is_running()
+
+# Assert node is actually in hibernate for test to be accurate.
+logger.debug("Asserting that node is actually in hibernate status for
test accuracy")
+assert 'hibernate' in node1.nodetool("gossipinfo").stdout
+
+extra_jvm_args = []
+extra_jvm_args.extend(["-Dcassandra.ring_delay_ms=1",
+ "-Dcassandra.broadcast_interval_ms=1"])
+
+logger.debug("Starting blind replacement node
{}".format(replacement_address))
+blind_replacement_node =
[cassandra] branch cassandra-3.0 updated: Check for endpoint collision with hibernating nodes
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new c94ecec Check for endpoint collision with hibernating nodes
c94ecec is described below
commit c94ececec0fcd87459858370396d6cd586853787
Author: Stefan Miklosovic
AuthorDate: Mon Aug 3 08:37:00 2020 +0200
Check for endpoint collision with hibernating nodes
Patch by Stefan Miklosovic, reviewed by brandonwillias for
CASSANDRA-14599
---
CHANGES.txt | 1 +
src/java/org/apache/cassandra/gms/Gossiper.java | 15 +--
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 182dca3..7d4b7a9 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.22:
+ * Check for endpoint collision with hibernating nodes (CASSANDRA-14599)
* Operational improvements and hardening for replica filtering protection
(CASSANDRA-15907)
* stop_paranoid disk failure policy is ignored on CorruptSSTableException
after node is up (CASSANDRA-15191)
* 3.x fails to start if commit log has range tombstones from a column which
is also deleted (CASSANDRA-15970)
diff --git a/src/java/org/apache/cassandra/gms/Gossiper.java
b/src/java/org/apache/cassandra/gms/Gossiper.java
index 7984dd4..7d708c1 100644
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
@@ -33,6 +33,7 @@ import com.google.common.util.concurrent.ListenableFutureTask;
import com.google.common.util.concurrent.Uninterruptibles;
import io.netty.util.concurrent.FastThreadLocal;
+import org.apache.cassandra.db.SystemKeyspace;
import org.apache.cassandra.utils.ExecutorUtils;
import org.apache.cassandra.utils.MBeanWrapper;
import org.apache.cassandra.utils.NoSpamLogger;
@@ -794,12 +795,22 @@ public class Gossiper implements
IFailureDetectionEventListener, GossiperMBean
{
EndpointState epState = epStates.get(endpoint);
-// if there's no previous state, or the node was previously removed
from the cluster, we're good
-if (epState == null || isDeadState(epState))
+// if there's no previous state, we're good
+if (epState == null)
return true;
String status = getGossipStatus(epState);
+if (status.equals(VersionedValue.HIBERNATE)
+&& !SystemKeyspace.bootstrapComplete())
+{
+logger.warn("A node with the same IP in hibernate status was
detected. Was a replacement already attempted?");
+return false;
+}
+
+if (isDeadState(epState))
+return true;
+
// these states are not allowed to join the cluster as it would not be
safe
final List unsafeStatuses = new ArrayList() {{
add(""); // failed bootstrap but we did start gossiping
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit f8f0c46914bc31939ea8674eca4de4d5bd6233cb
Merge: 5d968e6 7976777
Author: Brandon Williams
AuthorDate: Tue Aug 4 17:38:12 2020 -0500
Merge branch 'cassandra-3.11' into trunk
CHANGES.txt | 1 +
src/java/org/apache/cassandra/gms/Gossiper.java | 19 ---
2 files changed, 17 insertions(+), 3 deletions(-)
diff --cc CHANGES.txt
index 05ec961,749aba2..adc97dd
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,15 -1,12 +1,16 @@@
-3.11.8
+4.0-beta2
+ * Throw FSWriteError upon write failures in order to apply DiskFailurePolicy
(CASSANDRA-15928)
+ * Forbid altering UDTs used in partition keys (CASSANDRA-15933)
+ * Fix version parsing logic when upgrading from 3.0 (CASSANDRA-15973)
+ * Optimize NoSpamLogger use in hot paths (CASSANDRA-15766)
+ * Verify sstable components on startup (CASSANDRA-15945)
+Merged from 3.11:
+ * stop_paranoid disk failure policy is ignored on CorruptSSTableException
after node is up (CASSANDRA-15191)
* Frozen RawTuple is not annotated with frozen in the toString method
(CASSANDRA-15857)
Merged from 3.0:
+ * Check for endpoint collision with hibernating nodes (CASSANDRA-14599)
* Operational improvements and hardening for replica filtering protection
(CASSANDRA-15907)
- * stop_paranoid disk failure policy is ignored on CorruptSSTableException
after node is up (CASSANDRA-15191)
- * Forbid altering UDTs used in partition keys (CASSANDRA-15933)
* Fix empty/null json string representation (CASSANDRA-15896)
- * 3.x fails to start if commit log has range tombstones from a column which
is also deleted (CASSANDRA-15970)
Merged from 2.2:
* Fix CQL parsing of collections when the column type is reversed
(CASSANDRA-15814)
diff --cc src/java/org/apache/cassandra/gms/Gossiper.java
index f276fbd,b201763..37ad6bb
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
@@@ -53,18 -45,21 +53,19 @@@ import org.slf4j.LoggerFactory
import org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor;
import org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor;
import org.apache.cassandra.concurrent.Stage;
-import org.apache.cassandra.concurrent.StageManager;
import org.apache.cassandra.config.DatabaseDescriptor;
-import org.apache.cassandra.config.Schema;
+ import org.apache.cassandra.db.SystemKeyspace;
import org.apache.cassandra.dht.Token;
-import org.apache.cassandra.net.IAsyncCallback;
-import org.apache.cassandra.net.MessageIn;
-import org.apache.cassandra.net.MessageOut;
+import org.apache.cassandra.net.RequestCallback;
+import org.apache.cassandra.net.Message;
import org.apache.cassandra.net.MessagingService;
import org.apache.cassandra.service.StorageService;
-import org.apache.cassandra.utils.CassandraVersion;
import org.apache.cassandra.utils.FBUtilities;
import org.apache.cassandra.utils.JVMStabilityInspector;
-import static org.apache.cassandra.utils.ExecutorUtils.awaitTermination;
-import static org.apache.cassandra.utils.ExecutorUtils.shutdown;
+
+import static org.apache.cassandra.net.NoPayload.noPayload;
+import static org.apache.cassandra.net.Verb.ECHO_REQ;
+import static org.apache.cassandra.net.Verb.GOSSIP_DIGEST_SYN;
/**
* This module is responsible for Gossiping information for the local
endpoint. This abstraction
@@@ -879,12 -809,25 +880,25 @@@ public class Gossiper implements IFailu
* @param epStates - endpoint states in the cluster
* @return true if it is safe to start the node, false otherwise
*/
-public boolean isSafeForStartup(InetAddress endpoint, UUID localHostUUID,
boolean isBootstrapping,
-Map epStates)
+public boolean isSafeForStartup(InetAddressAndPort endpoint, UUID
localHostUUID, boolean isBootstrapping,
+Map
epStates)
{
EndpointState epState = epStates.get(endpoint);
- // if there's no previous state, or the node was previously removed
from the cluster, we're good
- if (epState == null || isDeadState(epState))
+ // if there's no previous state, we're good
+ if (epState == null)
+ return true;
+
+ String status = getGossipStatus(epState);
+
+ if (status.equals(VersionedValue.HIBERNATE)
+ && !SystemKeyspace.bootstrapComplete())
+ {
+ logger.warn("A node with the same IP in hibernate status was
detected. Was a replacement already attempted?");
+ return false;
+ }
+
+ //the node was previously removed from the cluster
+ if (isDeadState(epState))
return true;
if (isBootstrapping)
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 7976777bccbe8b90db7d41cb666bcb9060d78bd4
Merge: 0310a7e c94ecec
Author: Brandon Williams
AuthorDate: Tue Aug 4 17:32:45 2020 -0500
Merge branch 'cassandra-3.0' into cassandra-3.11
CHANGES.txt | 1 +
src/java/org/apache/cassandra/gms/Gossiper.java | 19 ---
2 files changed, 17 insertions(+), 3 deletions(-)
diff --cc CHANGES.txt
index 9dbbd1c,7d4b7a9..749aba2
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,11 -1,10 +1,12 @@@
-3.0.22:
+3.11.8
+ * Frozen RawTuple is not annotated with frozen in the toString method
(CASSANDRA-15857)
+Merged from 3.0:
+ * Check for endpoint collision with hibernating nodes (CASSANDRA-14599)
* Operational improvements and hardening for replica filtering protection
(CASSANDRA-15907)
* stop_paranoid disk failure policy is ignored on CorruptSSTableException
after node is up (CASSANDRA-15191)
- * 3.x fails to start if commit log has range tombstones from a column which
is also deleted (CASSANDRA-15970)
* Forbid altering UDTs used in partition keys (CASSANDRA-15933)
* Fix empty/null json string representation (CASSANDRA-15896)
+ * 3.x fails to start if commit log has range tombstones from a column which
is also deleted (CASSANDRA-15970)
Merged from 2.2:
* Fix CQL parsing of collections when the column type is reversed
(CASSANDRA-15814)
diff --cc src/java/org/apache/cassandra/gms/Gossiper.java
index d227200,7d708c1..b201763
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
@@@ -47,7 -46,6 +47,8 @@@ import org.apache.cassandra.concurrent.
import org.apache.cassandra.concurrent.Stage;
import org.apache.cassandra.concurrent.StageManager;
import org.apache.cassandra.config.DatabaseDescriptor;
+import org.apache.cassandra.config.Schema;
++import org.apache.cassandra.db.SystemKeyspace;
import org.apache.cassandra.dht.Token;
import org.apache.cassandra.net.IAsyncCallback;
import org.apache.cassandra.net.MessageIn;
@@@ -794,48 -785,38 +795,60 @@@ public class Gossiper implements IFailu
}
/**
- * Check if this endpoint can safely bootstrap into the cluster.
+ * Check if this node can safely be started and join the ring.
+ * If the node is bootstrapping, examines gossip state for any previous
status to decide whether
+ * it's safe to allow this node to start and bootstrap. If not
bootstrapping, compares the host ID
+ * that the node itself has (obtained by reading from system.local or
generated if not present)
+ * with the host ID obtained from gossip for the endpoint address (if
any). This latter case
+ * prevents a non-bootstrapping, new node from being started with the
same address of a
+ * previously started, but currently down predecessor.
*
* @param endpoint - the endpoint to check
+ * @param localHostUUID - the host id to check
+ * @param isBootstrapping - whether the node intends to bootstrap when
joining
* @param epStates - endpoint states in the cluster
- * @return true if the endpoint can join the cluster
+ * @return true if it is safe to start the node, false otherwise
*/
-public boolean isSafeForBootstrap(InetAddress endpoint, Map epStates)
+public boolean isSafeForStartup(InetAddress endpoint, UUID localHostUUID,
boolean isBootstrapping,
+Map epStates)
{
EndpointState epState = epStates.get(endpoint);
- // if there's no previous state, or the node was previously removed
from the cluster, we're good
- if (epState == null || isDeadState(epState))
-
+ // if there's no previous state, we're good
+ if (epState == null)
+ return true;
+
+ String status = getGossipStatus(epState);
+
+ if (status.equals(VersionedValue.HIBERNATE)
+ && !SystemKeyspace.bootstrapComplete())
+ {
+ logger.warn("A node with the same IP in hibernate status was
detected. Was a replacement already attempted?");
+ return false;
+ }
+
++//the node was previously removed from the cluster
+ if (isDeadState(epState))
return true;
-// these states are not allowed to join the cluster as it would not
be safe
-final List unsafeStatuses = new ArrayList() {{
-add(""); // failed bootstrap but we did start gossiping
-add(VersionedValue.STATUS_NORMAL); // node is legit in the
cluster or it was stopped with kill -9
-add(VersionedValue.SHUTDOWN); }}; // node was shutdown
-return !unsafeStatuses.contains(status);
+if (isBootstrapping)
+{
- String status =
[jira] [Updated] (CASSANDRA-15963) Flaky dtest test_dead_sync_initiator - repair_tests.repair_test.TestRepair
[
https://issues.apache.org/jira/browse/CASSANDRA-15963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15963:
Fix Version/s: 4.0-beta
> Flaky dtest test_dead_sync_initiator - repair_tests.repair_test.TestRepair
> --
>
> Key: CASSANDRA-15963
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15963
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Yifan Cai
>Priority: Normal
> Fix For: 4.0-beta
>
>
> CI test link.
> [https://app.circleci.com/pipelines/github/yifan-c/cassandra/78/workflows/e89b96f1-c468-484f-9764-694b64fad95b/jobs/411]
> {code:java}
> test teardown failure
> Unexpected error found in node logs (see stdout for full details). Errors:
> [ERROR [Stream-Deserializer-127.0.0.1:7000-56da8052] 2020-07-20 19:00:33,545
> CassandraEntireSSTableStreamReader.java:145 - [Stream
> 48a43e80-cabb-11ea-a743-3578c769ed44] Error while reading sstable from stream
> for table = keyspace1.standard1
> org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted:
> /tmp/dtest-4ichr2ha/test/node3/data0/keyspace1/standard1-3b1f65f0cabb11eaa7433578c769ed44/na-1-big-Statistics.db
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.maybeValidateChecksum(MetadataSerializer.java:219)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:198)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:129)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.mutate(MetadataSerializer.java:226)
> at
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:140)
> at
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:84)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:53)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:38)
> at
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:51)
> at
> org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:172)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.io.IOException: Checksums do not match for
> /tmp/dtest-4ichr2ha/test/node3/data0/keyspace1/standard1-3b1f65f0cabb11eaa7433578c769ed44/na-1-big-Statistics.db
> ... 12 common frames omitted, ERROR
> [Stream-Deserializer-127.0.0.1:7000-56da8052] 2020-07-20 19:00:33,545
> CassandraEntireSSTableStreamReader.java:145 - [Stream
> 48a43e80-cabb-11ea-a743-3578c769ed44] Error while reading sstable from stream
> for table = keyspace1.standard1
> org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted:
> /tmp/dtest-4ichr2ha/test/node3/data0/keyspace1/standard1-3b1f65f0cabb11eaa7433578c769ed44/na-1-big-Statistics.db
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.maybeValidateChecksum(MetadataSerializer.java:219)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:198)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:129)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.mutate(MetadataSerializer.java:226)
> at
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:140)
> at
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:84)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:53)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:38)
> at
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:51)
> at
> org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:172)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.io.IOException: Checksums do not match for
> /tmp/dtest-4ichr2ha/test/node3/data0/keyspace1/standard1-3b1f65f0cabb11eaa7433578c769ed44/na-1-big-Statistics.db
> ... 12 common frames omitted]{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail:
[jira] [Updated] (CASSANDRA-15963) Flaky dtest test_dead_sync_initiator - repair_tests.repair_test.TestRepair
[
https://issues.apache.org/jira/browse/CASSANDRA-15963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15963:
Bug Category: Parent values: Correctness(12982)
Complexity: Normal
Component/s: Test/dtest
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Flaky dtest test_dead_sync_initiator - repair_tests.repair_test.TestRepair
> --
>
> Key: CASSANDRA-15963
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15963
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Yifan Cai
>Priority: Normal
>
> CI test link.
> [https://app.circleci.com/pipelines/github/yifan-c/cassandra/78/workflows/e89b96f1-c468-484f-9764-694b64fad95b/jobs/411]
> {code:java}
> test teardown failure
> Unexpected error found in node logs (see stdout for full details). Errors:
> [ERROR [Stream-Deserializer-127.0.0.1:7000-56da8052] 2020-07-20 19:00:33,545
> CassandraEntireSSTableStreamReader.java:145 - [Stream
> 48a43e80-cabb-11ea-a743-3578c769ed44] Error while reading sstable from stream
> for table = keyspace1.standard1
> org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted:
> /tmp/dtest-4ichr2ha/test/node3/data0/keyspace1/standard1-3b1f65f0cabb11eaa7433578c769ed44/na-1-big-Statistics.db
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.maybeValidateChecksum(MetadataSerializer.java:219)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:198)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:129)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.mutate(MetadataSerializer.java:226)
> at
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:140)
> at
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:84)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:53)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:38)
> at
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:51)
> at
> org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:172)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.io.IOException: Checksums do not match for
> /tmp/dtest-4ichr2ha/test/node3/data0/keyspace1/standard1-3b1f65f0cabb11eaa7433578c769ed44/na-1-big-Statistics.db
> ... 12 common frames omitted, ERROR
> [Stream-Deserializer-127.0.0.1:7000-56da8052] 2020-07-20 19:00:33,545
> CassandraEntireSSTableStreamReader.java:145 - [Stream
> 48a43e80-cabb-11ea-a743-3578c769ed44] Error while reading sstable from stream
> for table = keyspace1.standard1
> org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted:
> /tmp/dtest-4ichr2ha/test/node3/data0/keyspace1/standard1-3b1f65f0cabb11eaa7433578c769ed44/na-1-big-Statistics.db
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.maybeValidateChecksum(MetadataSerializer.java:219)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:198)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:129)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.mutate(MetadataSerializer.java:226)
> at
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:140)
> at
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:84)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:53)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:38)
> at
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:51)
> at
> org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:172)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.io.IOException: Checksums do not match for
> /tmp/dtest-4ichr2ha/test/node3/data0/keyspace1/standard1-3b1f65f0cabb11eaa7433578c769ed44/na-1-big-Statistics.db
> ... 12 common frames omitted]{code}
--
This message
[jira] [Updated] (CASSANDRA-14559) Check for endpoint collision with hibernating nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14559: - Status: Ready to Commit (was: Review In Progress) > Check for endpoint collision with hibernating nodes > > > Key: CASSANDRA-14559 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14559 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Bootstrap and Decommission >Reporter: Vincent White >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.11.x, 4.0-beta2 > > Time Spent: 20m > Remaining Estimate: 0h > > I ran across an edge case when replacing a node with the same address. This > issue results in the node(and its tokens) being unsafely removed from gossip. > Steps to replicate: > 1. Create 3 node cluster. > 2. Stop a node > 3. Replace the stopped node with a node using the same address using the > replace_address flag > 4. Stop the node before it finishes bootstrapping > 5. Remove the replace_address flag and restart the node to resume > bootstrapping (if the data dir is also cleared at this point the node will > also generate new tokens when it starts) > 6. Stop the node before it finishes bootstrapping again > 7. 30 Seconds later the node will be removed from gossip because it now > matches the check for a FatClient > I think this is only an issue when replacing a node with the same address > because other replacements now use STATUS_BOOTSTRAPPING_REPLACE and leave the > dead node unchanged. > I believe the simplest fix for this is to add a check that prevents a > non-bootstrapped node (without the replaces_address flag) starting if there > is a gossip entry for the same address in the hibernate state. > [3.11 PoC > |https://github.com/apache/cassandra/compare/trunk...vincewhite:check_for_hibernate_on_start] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15990) Running CQL command with non-ASCII values raises UnicodeDecodeError
[
https://issues.apache.org/jira/browse/CASSANDRA-15990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova reassigned CASSANDRA-15990:
---
Assignee: Ekaterina Dimitrova
> Running CQL command with non-ASCII values raises UnicodeDecodeError
> ---
>
> Key: CASSANDRA-15990
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15990
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Joseph Chu
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There are INSERT statements that contains non-ASCII values that have run fine
> in Cassandra 3.11, but now raises a UnicodeDecodeError when I try executing
> them in 4.0-alpha4 and 4.0-beta1.
> Example input and output:
> {code:java}
> echo $LANG
> en_US.UTF-8
> $ cqlsh --debug
> Using CQL driver: '/usr/share/cassandra/bin/../lib/cassandra-driver-internal-only-3.23.0.post0-1a184b99.zip/cassandra-driver-3.23.0.post0-1a184b99/cassandra/__init__.py'>
> Using connect timeout: 5 seconds
> Using 'utf-8' encoding
> Using ssl: False
> Connected to Cassandra Cluster at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 4.0-beta1 | CQL spec 3.4.5 | Native protocol v4]
> Use HELP for help.
> cqlsh> CREATE KEYSPACE killr_video WITH replication = {'class':
> 'NetworkTopologyStrategy', 'DC-Houston': 1};
> cqlsh> USE killr_video;
> cqlsh:killr_video> CREATE TABLE movies_by_genre ( genre TEXT, title TEXT,
> year INT, duration INT, avg_rating FLOAT, country TEXT, PRIMARY KEY ((genre),
> title, year));
> cqlsh:killr_video> INSERT INTO movies_by_genre (genre, title, year, duration,
> avg_rating, country)
> ... VALUES ('Action', 'The Extraordinary Adventures of Adèle Blanc-Sec',
> 2010, 107, 6.30, 'France');
> Traceback (most recent call last):
> File "/usr/share/cassandra/bin/cqlsh.py", line 937, in onecmd
> self.handle_statement(st, statementtext)
> File "/usr/share/cassandra/bin/cqlsh.py", line 962, in handle_statement
> readline.add_history(new_hist)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe8' in position
> 134: ordinal not in range(128){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15158) Wait for schema agreement rather than in flight schema requests when bootstrapping
[
https://issues.apache.org/jira/browse/CASSANDRA-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171139#comment-17171139
]
Blake Eggleston commented on CASSANDRA-15158:
-
{quote}
I am not completely sure why are we pulling again here. I would rewrite the
whole solution in a such way that this Callable just does one thing on a
successful response (merging of a schema) and the actual "retry" would be
handled from outside. The reader has to make quite a mental exercise to
visualise that this callback might actually call another callback in it until
some "version" is completed etc ... At least for me, it was quite tedious to
track.
{quote}
In the case of a successful pull, we won't pull again. Response and fail both
call pullComplete, but an additional pull is only called if it's called from
fail.
I get that this can be a bit difficult to follow, but I'm not sure there's a
better approach, given the schema pulls are completely event driven during
normal runtime. If we miss a schema change during normal runtime (not
bootstrap), there's nothing waiting on schema convergence that would enable us
to retry from the outside.
There is a periodic task that pulls schema for outstanding versions that don't
have any in flight requests^[1]^, but it only runs once a minute, and we need
to be more proactive about learning about schema updates since we'll be unable
to serve some reads and writes until we're up to date.
{quote}TBH that is quite counterintuitive too
{quote}
Could you expand on what's counterintuitive about it? If the endpoint's schema
version has changed, we need to disassociate it with it's previously reported
version. I have added a comment saying as much.
{quote}The test has failed for me (repeatedly):
{quote}
Thanks, it should be passing now.
[1] This handles the case where all nodes reporting a given version are on a
different version so we can't pull schema from them, and acts as a hedge
against any bugs in this implementation that might cause us to not schedule
schema pulls as intended
> Wait for schema agreement rather than in flight schema requests when
> bootstrapping
> --
>
> Key: CASSANDRA-15158
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15158
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Cluster/Schema
>Reporter: Vincent White
>Assignee: Blake Eggleston
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently when a node is bootstrapping we use a set of latches
> (org.apache.cassandra.service.MigrationTask#inflightTasks) to keep track of
> in-flight schema pull requests, and we don't proceed with
> bootstrapping/stream until all the latches are released (or we timeout
> waiting for each one). One issue with this is that if we have a large schema,
> or the retrieval of the schema from the other nodes was unexpectedly slow
> then we have no explicit check in place to ensure we have actually received a
> schema before we proceed.
> While it's possible to increase "migration_task_wait_in_seconds" to force the
> node to wait on each latche longer, there are cases where this doesn't help
> because the callbacks for the schema pull requests have expired off the
> messaging service's callback map
> (org.apache.cassandra.net.MessagingService#callbacks) after
> request_timeout_in_ms (default 10 seconds) before the other nodes were able
> to respond to the new node.
> This patch checks for schema agreement between the bootstrapping node and the
> rest of the live nodes before proceeding with bootstrapping. It also adds a
> check to prevent the new node from flooding existing nodes with simultaneous
> schema pull requests as can happen in large clusters.
> Removing the latch system should also prevent new nodes in large clusters
> getting stuck for extended amounts of time as they wait
> `migration_task_wait_in_seconds` on each of the latches left orphaned by the
> timed out callbacks.
>
> ||3.11||
> |[PoC|https://github.com/apache/cassandra/compare/cassandra-3.11...vincewhite:check_for_schema]|
> |[dtest|https://github.com/apache/cassandra-dtest/compare/master...vincewhite:wait_for_schema_agreement]|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15873) Update Netty 4.0.44 -> 4.1.50 (fix security/performance issues)
[ https://issues.apache.org/jira/browse/CASSANDRA-15873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171109#comment-17171109 ] Matt Davis commented on CASSANDRA-15873: Bumping this, would be great to fix this security hole and pickup some free performance for everyone. I was able to get up to 27% more throughput with the more recent version. Thanks! > Update Netty 4.0.44 -> 4.1.50 (fix security/performance issues) > --- > > Key: CASSANDRA-15873 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15873 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Matt Davis >Priority: Normal > Fix For: 3.11.x > > Attachments: dependency-check-report.html, unittest_netty.log > > > See https://issues.apache.org/jira/browse/CASSANDRA-15868 for the same issue > on 4.0 / trunk. Attached is an OWASP dependency report for Netty 4.0.44, > which identifies 3 of the same vulnerabilities as above. > > Additionally, 4.1.50 contains aarch64 native libraries which can improve > performance on ARM processors. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15889) Debian package fails to download on Arm-based hosts
[
https://issues.apache.org/jira/browse/CASSANDRA-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171105#comment-17171105
]
Matt Davis commented on CASSANDRA-15889:
Bumping this issue. Worst case, it would be helpful to get the workaround
posted to the Cassandra install instructions.
> Debian package fails to download on Arm-based hosts
> ---
>
> Key: CASSANDRA-15889
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15889
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Matt Davis
>Priority: Normal
> Labels: ARM, debian
>
> Following the first three steps of the [Debian install
> process|https://cassandra.apache.org/download/], after an apt-get update
> you'll see this line:
> {code:bash}
> $ sudo apt-get update
> ...
> N: Skipping acquire of configured file 'main/binary-arm64/Packages' as
> repository 'https://downloads.apache.org/cassandra/debian 311x InRelease'
> doesn't support architecture 'arm64'
> {code}
> Checking the [Debian
> repo|https://dl.bintray.com/apache/cassandra/dists/311x/main/] confirms there
> is no aarch64 variant available.
> Should you then attempt to install Cassandra:
> {code:bash}
> $ sudo apt-get install cassandra
> Reading package lists... Done
> Building dependency tree
> Reading state information... Done
> Package cassandra is not available, but is referred to by another package.
> This may mean that the package is missing, has been obsoleted, or
> is only available from another source
> E: Package 'cassandra' has no installation candidate
> {code}
> The Redhat RPM contains a "noarch" arch type, so it will download on any
> host. (Cassandra does not use separate binaries/releases for different
> architectures, so this seems to be the correct approach, but adding an
> aarch64 variant would also suffice.)
> Note that there is a workaround available: if you specify "amd64" as the arch
> for the source, it downloads and runs on Arm without issue:
> {code:bash}
> deb [arch=amd64] https://downloads.apache.org/cassandra/debian 311x main
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15959) org.apache.cassandra.cql3.validation.operations.TTLTest testCapWarnExpirationOverflowPolicy
[ https://issues.apache.org/jira/browse/CASSANDRA-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15959: - Fix Version/s: (was: 4.0-beta) 4.0-beta2 Since Version: 3.0.0 Source Control Link: https://github.com/apache/cassandra/commit/5d968e6d274f9743a777276d5b5ee09fa4db3254 Resolution: Fixed Status: Resolved (was: Ready to Commit) Verified that works and moved it on commit. Thanks! > org.apache.cassandra.cql3.validation.operations.TTLTest > testCapWarnExpirationOverflowPolicy > --- > > Key: CASSANDRA-15959 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15959 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-beta2 > > Attachments: 0001-computeMaxTTL-directly-before-fetching-TTL.patch > > > Build: > https://ci-cassandra.apache.org/job/Cassandra-trunk-test/194/testReport/junit/org.apache.cassandra.cql3.validation.operations/TTLTest/testCapWarnExpirationOverflowPolicy/ > junit.framework.AssertionFailedError > at > org.apache.cassandra.cql3.validation.operations.TTLTest.checkTTLIsCapped(TTLTest.java:321) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.verifyData(TTLTest.java:303) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapExpirationDateOverflowPolicy(TTLTest.java:248) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapExpirationDateOverflowPolicy(TTLTest.java:199) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapWarnExpirationOverflowPolicy(TTLTest.java:140) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15959) org.apache.cassandra.cql3.validation.operations.TTLTest testCapWarnExpirationOverflowPolicy
[ https://issues.apache.org/jira/browse/CASSANDRA-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15959: - Status: Ready to Commit (was: Review In Progress) > org.apache.cassandra.cql3.validation.operations.TTLTest > testCapWarnExpirationOverflowPolicy > --- > > Key: CASSANDRA-15959 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15959 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-beta > > Attachments: 0001-computeMaxTTL-directly-before-fetching-TTL.patch > > > Build: > https://ci-cassandra.apache.org/job/Cassandra-trunk-test/194/testReport/junit/org.apache.cassandra.cql3.validation.operations/TTLTest/testCapWarnExpirationOverflowPolicy/ > junit.framework.AssertionFailedError > at > org.apache.cassandra.cql3.validation.operations.TTLTest.checkTTLIsCapped(TTLTest.java:321) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.verifyData(TTLTest.java:303) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapExpirationDateOverflowPolicy(TTLTest.java:248) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapExpirationDateOverflowPolicy(TTLTest.java:199) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapWarnExpirationOverflowPolicy(TTLTest.java:140) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15338) Fix flakey testMessagePurging - org.apache.cassandra.net.ConnectionTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171101#comment-17171101
]
Yifan Cai commented on CASSANDRA-15338:
---
Just took another look. The exception is not expected. Pasting the stack trace.
{code:java}
java.util.concurrent.TimeoutException
at org.apache.cassandra.net.AsyncPromise.get(AsyncPromise.java:258)
at org.apache.cassandra.net.FutureDelegate.get(FutureDelegate.java:143)
at
org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:268)
at
org.apache.cassandra.net.ConnectionTest.testManual(ConnectionTest.java:236)
at
org.apache.cassandra.net.ConnectionTest.testMessagePurging(ConnectionTest.java:679)
{code}
In the test, testMessagePurging, it already closed the inbound connection. The
test does not throw at that line, so I would assume that inbound is closed
successfully.
If so, we should not see the Timeout exception from
{{doTestManual(ConnectionTest.java:268)}}. Because the inbound is closed
already.
I suspect that there might be some hidden issue in the {{close()}} method. I
will open a new ticket if it is.
> Fix flakey testMessagePurging - org.apache.cassandra.net.ConnectionTest
> ---
>
> Key: CASSANDRA-15338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15338
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Yifan Cai
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0, 4.0-beta1
>
> Attachments: CASS-15338-Docker.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Example failure:
> [https://circleci.com/gh/dcapwell/cassandra/11#artifacts/containers/1]
>
> {code:java}
> Testcase: testMessagePurging(org.apache.cassandra.net.ConnectionTest): FAILED
> expected:<0> but was:<1>
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at
> org.apache.cassandra.net.ConnectionTest.lambda$testMessagePurging$38(ConnectionTest.java:625)
> at
> org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:258)
> at
> org.apache.cassandra.net.ConnectionTest.testManual(ConnectionTest.java:231)
> at
> org.apache.cassandra.net.ConnectionTest.testMessagePurging(ConnectionTest.java:584){code}
>
> Looking closer at
> org.apache.cassandra.net.OutboundConnection.Delivery#stopAndRun it seems that
> the run method is called before
> org.apache.cassandra.net.OutboundConnection.Delivery#doRun which may lead to
> a test race condition where the CountDownLatch completes before executing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: computeMaxTTL directly before fetching TTL in TTLTest
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5d968e6 computeMaxTTL directly before fetching TTL in TTLTest
5d968e6 is described below
commit 5d968e6d274f9743a777276d5b5ee09fa4db3254
Author: Brandon Williams
AuthorDate: Tue Jul 28 15:52:13 2020 -0500
computeMaxTTL directly before fetching TTL in TTLTest
patch by brandonwilliams, reviewed by dcapwell for CASSANDRA-15959
---
.../unit/org/apache/cassandra/cql3/validation/operations/TTLTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/test/unit/org/apache/cassandra/cql3/validation/operations/TTLTest.java
b/test/unit/org/apache/cassandra/cql3/validation/operations/TTLTest.java
index 99ca7dc..187818a 100644
--- a/test/unit/org/apache/cassandra/cql3/validation/operations/TTLTest.java
+++ b/test/unit/org/apache/cassandra/cql3/validation/operations/TTLTest.java
@@ -313,12 +313,12 @@ public class TTLTest extends CQLTester
// TTL is computed dynamically from row expiration time, so if it is
// equal or higher to the minimum max TTL we compute before the query
// we are fine.
-int minMaxTTL = computeMaxTTL();
UntypedResultSet execute = execute("SELECT ttl(" + field + ") FROM %s
WHERE k = 1");
+int minMaxTTL = computeMaxTTL();
for (UntypedResultSet.Row row : execute)
{
int ttl = row.getInt("ttl(" + field + ")");
-assertTrue(ttl >= minMaxTTL);
+assert (ttl >= minMaxTTL) : "ttl must be greater than or equal to
minMaxTTL, but " + ttl + " is less than " + minMaxTTL;
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14425) cassandra-stress doesn't report correctly when profile file is not found
[ https://issues.apache.org/jira/browse/CASSANDRA-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Holmberg updated CASSANDRA-14425: -- Impacts: None Test and Documentation Plan: Manual verification might be sufficient. No docs are required – it's just better error reporting. Status: Patch Available (was: Open) Moving this to Patch Available after stumbling across the PR. > cassandra-stress doesn't report correctly when profile file is not found > > > Key: CASSANDRA-14425 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14425 > Project: Cassandra > Issue Type: Bug > Components: Tool/stress >Reporter: Alex Ott >Assignee: Alex Ott >Priority: Low > > Right now, when there is an error in the profile file name cassandra-stress > reports very not understandable error "URI is not absolute" instead of > reporting something like "File doesn't exist" or something like. > It would be very helpful to improve user experience by reporting correct > reason for error. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14425) cassandra-stress doesn't report correctly when profile file is not found
[ https://issues.apache.org/jira/browse/CASSANDRA-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Holmberg updated CASSANDRA-14425: -- Fix Version/s: 4.0-beta2 > cassandra-stress doesn't report correctly when profile file is not found > > > Key: CASSANDRA-14425 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14425 > Project: Cassandra > Issue Type: Bug > Components: Tool/stress >Reporter: Alex Ott >Assignee: Alex Ott >Priority: Low > Fix For: 4.0-beta2 > > > Right now, when there is an error in the profile file name cassandra-stress > reports very not understandable error "URI is not absolute" instead of > reporting something like "File doesn't exist" or something like. > It would be very helpful to improve user experience by reporting correct > reason for error. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170976#comment-17170976
]
Caleb Rackliffe edited comment on CASSANDRA-15459 at 8/4/20, 6:30 PM:
--
[~adelapena] What's your opinion on whether the existing Python dtest would be
better as an in-JVM dtest? One thing that might be nice in this case is that we
could leave the trunk/4.0 version of the test in a simpler state, due to not
needing the Byteman injection to avoid blocking read-repair there. Also, I
think in-jvm tests would be able to run considerably faster, given they don't
need to stop and start nodes. (i.e. They can write only to specific nodes w/
{{executeInternal()}}.)
UPDATE: After reviewing, there might be a couple tests to add anyway, so I
suppose that adds to the argument for an in-JVM dtest.
was (Author: maedhroz):
[~adelapena] What's your opinion on whether the existing Python dtest would be
better as an in-JVM dtest? One thing that might be nice in this case is that we
could leave the trunk/4.0 version of the test in a simpler state, due to not
needing the Byteman injection to avoid blocking read-repair there. Also, I
think in-jvm tests would be able to run considerably faster, given they don't
need to stop and start nodes. (i.e. They can write only to specific nodes w/
{{executeInternal()}}.)
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-15459:
Status: Changes Suggested (was: Review In Progress)
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15990) Running CQL command with non-ASCII values raises UnicodeDecodeError
[
https://issues.apache.org/jira/browse/CASSANDRA-15990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova reassigned CASSANDRA-15990:
---
Assignee: Ekaterina Dimitrova
> Running CQL command with non-ASCII values raises UnicodeDecodeError
> ---
>
> Key: CASSANDRA-15990
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15990
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Joseph Chu
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There are INSERT statements that contains non-ASCII values that have run fine
> in Cassandra 3.11, but now raises a UnicodeDecodeError when I try executing
> them in 4.0-alpha4 and 4.0-beta1.
> Example input and output:
> {code:java}
> echo $LANG
> en_US.UTF-8
> $ cqlsh --debug
> Using CQL driver: '/usr/share/cassandra/bin/../lib/cassandra-driver-internal-only-3.23.0.post0-1a184b99.zip/cassandra-driver-3.23.0.post0-1a184b99/cassandra/__init__.py'>
> Using connect timeout: 5 seconds
> Using 'utf-8' encoding
> Using ssl: False
> Connected to Cassandra Cluster at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 4.0-beta1 | CQL spec 3.4.5 | Native protocol v4]
> Use HELP for help.
> cqlsh> CREATE KEYSPACE killr_video WITH replication = {'class':
> 'NetworkTopologyStrategy', 'DC-Houston': 1};
> cqlsh> USE killr_video;
> cqlsh:killr_video> CREATE TABLE movies_by_genre ( genre TEXT, title TEXT,
> year INT, duration INT, avg_rating FLOAT, country TEXT, PRIMARY KEY ((genre),
> title, year));
> cqlsh:killr_video> INSERT INTO movies_by_genre (genre, title, year, duration,
> avg_rating, country)
> ... VALUES ('Action', 'The Extraordinary Adventures of Adèle Blanc-Sec',
> 2010, 107, 6.30, 'France');
> Traceback (most recent call last):
> File "/usr/share/cassandra/bin/cqlsh.py", line 937, in onecmd
> self.handle_statement(st, statementtext)
> File "/usr/share/cassandra/bin/cqlsh.py", line 962, in handle_statement
> readline.add_history(new_hist)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe8' in position
> 134: ordinal not in range(128){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15981) jvm-dtests crash on java 11
[
https://issues.apache.org/jira/browse/CASSANDRA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15981:
--
Reviewers: Alex Petrov, Jon Meredith (was: Alex Petrov, David Capwell, Jon
Meredith)
> jvm-dtests crash on java 11
> ---
>
> Key: CASSANDRA-15981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15981
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There is a race condition bug with CMS and class unloading which cause the
> JVM to crash. Since jvm-dtests rely on class loaders and unloading, this
> causes sporadic JVM crashes that look like the following in CI logs
> {code}
> junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
> Please note the time in the report does not reflect the time until the VM
> exit.
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15981) jvm-dtests crash on java 11
[
https://issues.apache.org/jira/browse/CASSANDRA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15981:
--
Reviewers: Alex Petrov, Jon Meredith, David Capwell (was: Alex Petrov,
David Capwell, Jon Meredith)
Alex Petrov, Jon Meredith, David Capwell
Status: Review In Progress (was: Patch Available)
> jvm-dtests crash on java 11
> ---
>
> Key: CASSANDRA-15981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15981
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There is a race condition bug with CMS and class unloading which cause the
> JVM to crash. Since jvm-dtests rely on class loaders and unloading, this
> causes sporadic JVM crashes that look like the following in CI logs
> {code}
> junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
> Please note the time in the report does not reflect the time until the VM
> exit.
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15981) jvm-dtests crash on java 11
[
https://issues.apache.org/jira/browse/CASSANDRA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171012#comment-17171012
]
David Capwell commented on CASSANDRA-15981:
---
Oh hey, what do you know, I didn't link the results against HIGHER, only LOWER
=D
{code}
$ diff .circleci/config.yml .circleci/config.yml.LOWRES
$
{code}
> jvm-dtests crash on java 11
> ---
>
> Key: CASSANDRA-15981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15981
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There is a race condition bug with CMS and class unloading which cause the
> JVM to crash. Since jvm-dtests rely on class loaders and unloading, this
> causes sporadic JVM crashes that look like the following in CI logs
> {code}
> junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
> Please note the time in the report does not reflect the time until the VM
> exit.
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15981) jvm-dtests crash on java 11
[
https://issues.apache.org/jira/browse/CASSANDRA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171006#comment-17171006
]
David Capwell commented on CASSANDRA-15981:
---
Thanks [~jmeredithco]!
[~ifesdjeen] sure, I will remove. My testing was in another environment that
used a 4gb container, but that env may be different than Circle CI; so valid to
run.
> jvm-dtests crash on java 11
> ---
>
> Key: CASSANDRA-15981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15981
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There is a race condition bug with CMS and class unloading which cause the
> JVM to crash. Since jvm-dtests rely on class loaders and unloading, this
> causes sporadic JVM crashes that look like the following in CI logs
> {code}
> junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
> Please note the time in the report does not reflect the time until the VM
> exit.
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14559) Check for endpoint collision with hibernating nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170987#comment-17170987 ] Brandon Williams commented on CASSANDRA-14559: -- +1 > Check for endpoint collision with hibernating nodes > > > Key: CASSANDRA-14559 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14559 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Bootstrap and Decommission >Reporter: Vincent White >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.11.x, 4.0-beta2 > > Time Spent: 20m > Remaining Estimate: 0h > > I ran across an edge case when replacing a node with the same address. This > issue results in the node(and its tokens) being unsafely removed from gossip. > Steps to replicate: > 1. Create 3 node cluster. > 2. Stop a node > 3. Replace the stopped node with a node using the same address using the > replace_address flag > 4. Stop the node before it finishes bootstrapping > 5. Remove the replace_address flag and restart the node to resume > bootstrapping (if the data dir is also cleared at this point the node will > also generate new tokens when it starts) > 6. Stop the node before it finishes bootstrapping again > 7. 30 Seconds later the node will be removed from gossip because it now > matches the check for a FatClient > I think this is only an issue when replacing a node with the same address > because other replacements now use STATUS_BOOTSTRAPPING_REPLACE and leave the > dead node unchanged. > I believe the simplest fix for this is to add a check that prevents a > non-bootstrapped node (without the replaces_address flag) starting if there > is a gossip entry for the same address in the hibernate state. > [3.11 PoC > |https://github.com/apache/cassandra/compare/trunk...vincewhite:check_for_hibernate_on_start] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170976#comment-17170976
]
Caleb Rackliffe edited comment on CASSANDRA-15459 at 8/4/20, 5:30 PM:
--
[~adelapena] What's your opinion on whether the existing Python dtest would be
better as an in-JVM dtest? One thing that might be nice in this case is that we
could leave the trunk/4.0 version of the test in a simpler state, due to not
needing the Byteman injection to avoid blocking read-repair there. Also, I
think in-jvm tests would be able to run considerably faster, given they don't
need to stop and start nodes. (i.e. They can write only to specific nodes w/
{{executeInternal()}}.)
was (Author: maedhroz):
[~adelapena] What's your opinion on whether the existing Python dtest would be
better as an in-JVM dtest? One thing that might be nice in this case is that we
could leave the trunk/4.0 version of the test in a simpler state, due to not
needing the Byteman injection to avoid blocking read-repair there. Also, I
think in-jvm tests would be able to run considerably faster, given they don't
need to stop and start nodes. (i.e. They can write only to specific nodes w/
`executeInternal()`.)
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16003) ToolRunner added in CASSANDRA-15942 stdErr checks improvements
[
https://issues.apache.org/jira/browse/CASSANDRA-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170979#comment-17170979
]
David Capwell commented on CASSANDRA-16003:
---
left a comment, would be good to address
> ToolRunner added in CASSANDRA-15942 stdErr checks improvements
> --
>
> Key: CASSANDRA-16003
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16003
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The JVM will output to stderr on some environments to show what flags that
> were picked up, when this happens all tests which validate stderr start to
> fail. This was found in the org.apache.cassandra.tools.ClearSnapshotTest as
> it switched to use the ToolRunner; below is a sample failure on my laptop (I
> had to modify the asserts since they don’t include the input)
> {code}
> java.lang.AssertionError:
> Expecting empty but was:<"Picked up _JAVA_OPTIONS:
> -Djava.net.preferIPv4Stack=true
> ">
> at
> org.apache.cassandra.tools.ToolRunner.assertEmptyStdErr(ToolRunner.java:339)
> at
> org.apache.cassandra.tools.ToolRunner.waitAndAssertOnCleanExit(ToolRunner.java:334)
> at
> org.apache.cassandra.tools.ClearSnapshotTest.testClearSnapshot_RemoveMultiple(ClearSnapshotTest.java:91)
> {code}
> Here _JAVA_OPTIONS is used globally on my system so fails the test; there is
> also JAVA_TOOL_RUNNER which is used the same way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15459) Short read protection doesn't work on group-by queries
[
https://issues.apache.org/jira/browse/CASSANDRA-15459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170976#comment-17170976
]
Caleb Rackliffe commented on CASSANDRA-15459:
-
[~adelapena] What's your opinion on whether the existing Python dtest would be
better as an in-JVM dtest? One thing that might be nice in this case is that we
could leave the trunk/4.0 version of the test in a simpler state, due to not
needing the Byteman injection to avoid blocking read-repair there. Also, I
think in-jvm tests would be able to run considerably faster, given they don't
need to stop and start nodes. (i.e. They can write only to specific nodes w/
`executeInternal()`.)
> Short read protection doesn't work on group-by queries
> --
>
> Key: CASSANDRA-15459
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15459
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: ZhaoYang
>Assignee: Andres de la Peña
>Priority: Normal
> Labels: correctness
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [DTest to
> reproduce|https://github.com/apache/cassandra-dtest/compare/master...jasonstack:srp_group_by_trunk?expand=1]:
> it affects all versions..
> {code}
> In a two-node cluster with RF = 2
> Execute only on Node1:
> * Insert pk=1 and ck=1 with timestamp 9
> * Delete pk=0 and ck=0 with timestamp 10
> * Insert pk=2 and ck=2 with timestamp 9
> Execute only on Node2:
> * Delete pk=1 and ck=1 with timestamp 10
> * Insert pk=0 and ck=0 with timestamp 9
> * Delete pk=2 and ck=2 with timestamp 10
> Query: "SELECT pk, c FROM %s GROUP BY pk LIMIT 1"
> * Expect no live data, but got [0, 0]
> {code}
> Note: for group-by queries, SRP should use "group counted" to calculate
> limits used for SRP query, rather than "row counted".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15393) Add byte array backed cells
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15393: Reviewers: Marcus Eriksson, Sam Tunnicliffe (was: Benedict Elliott Smith, Sam Tunnicliffe) > Add byte array backed cells > --- > > Key: CASSANDRA-15393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15393 > Project: Cassandra > Issue Type: Sub-task > Components: Local/Compaction >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 4.0-beta > > > We currently materialize all values as on heap byte buffers. Byte buffers > have a fairly high overhead given how frequently they’re used, and on the > compaction and local read path we don’t do anything that needs them. Use of > byte buffer methods only happens on the coordinator. Using cells that are > backed by byte arrays instead in these situations reduces compaction and read > garbage up to 22% in many cases. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15158) Wait for schema agreement rather than in flight schema requests when bootstrapping
[ https://issues.apache.org/jira/browse/CASSANDRA-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston reassigned CASSANDRA-15158: --- Assignee: Blake Eggleston (was: Ben Bromhead) > Wait for schema agreement rather than in flight schema requests when > bootstrapping > -- > > Key: CASSANDRA-15158 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15158 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip, Cluster/Schema >Reporter: Vincent White >Assignee: Blake Eggleston >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Currently when a node is bootstrapping we use a set of latches > (org.apache.cassandra.service.MigrationTask#inflightTasks) to keep track of > in-flight schema pull requests, and we don't proceed with > bootstrapping/stream until all the latches are released (or we timeout > waiting for each one). One issue with this is that if we have a large schema, > or the retrieval of the schema from the other nodes was unexpectedly slow > then we have no explicit check in place to ensure we have actually received a > schema before we proceed. > While it's possible to increase "migration_task_wait_in_seconds" to force the > node to wait on each latche longer, there are cases where this doesn't help > because the callbacks for the schema pull requests have expired off the > messaging service's callback map > (org.apache.cassandra.net.MessagingService#callbacks) after > request_timeout_in_ms (default 10 seconds) before the other nodes were able > to respond to the new node. > This patch checks for schema agreement between the bootstrapping node and the > rest of the live nodes before proceeding with bootstrapping. It also adds a > check to prevent the new node from flooding existing nodes with simultaneous > schema pull requests as can happen in large clusters. > Removing the latch system should also prevent new nodes in large clusters > getting stuck for extended amounts of time as they wait > `migration_task_wait_in_seconds` on each of the latches left orphaned by the > timed out callbacks. > > ||3.11|| > |[PoC|https://github.com/apache/cassandra/compare/cassandra-3.11...vincewhite:check_for_schema]| > |[dtest|https://github.com/apache/cassandra-dtest/compare/master...vincewhite:wait_for_schema_agreement]| > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15990) Running CQL command with non-ASCII values raises UnicodeDecodeError
[
https://issues.apache.org/jira/browse/CASSANDRA-15990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170919#comment-17170919
]
Ekaterina Dimitrova commented on CASSANDRA-15990:
-
The issue is reproduced with python2.
> Running CQL command with non-ASCII values raises UnicodeDecodeError
> ---
>
> Key: CASSANDRA-15990
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15990
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Joseph Chu
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There are INSERT statements that contains non-ASCII values that have run fine
> in Cassandra 3.11, but now raises a UnicodeDecodeError when I try executing
> them in 4.0-alpha4 and 4.0-beta1.
> Example input and output:
> {code:java}
> echo $LANG
> en_US.UTF-8
> $ cqlsh --debug
> Using CQL driver: '/usr/share/cassandra/bin/../lib/cassandra-driver-internal-only-3.23.0.post0-1a184b99.zip/cassandra-driver-3.23.0.post0-1a184b99/cassandra/__init__.py'>
> Using connect timeout: 5 seconds
> Using 'utf-8' encoding
> Using ssl: False
> Connected to Cassandra Cluster at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 4.0-beta1 | CQL spec 3.4.5 | Native protocol v4]
> Use HELP for help.
> cqlsh> CREATE KEYSPACE killr_video WITH replication = {'class':
> 'NetworkTopologyStrategy', 'DC-Houston': 1};
> cqlsh> USE killr_video;
> cqlsh:killr_video> CREATE TABLE movies_by_genre ( genre TEXT, title TEXT,
> year INT, duration INT, avg_rating FLOAT, country TEXT, PRIMARY KEY ((genre),
> title, year));
> cqlsh:killr_video> INSERT INTO movies_by_genre (genre, title, year, duration,
> avg_rating, country)
> ... VALUES ('Action', 'The Extraordinary Adventures of Adèle Blanc-Sec',
> 2010, 107, 6.30, 'France');
> Traceback (most recent call last):
> File "/usr/share/cassandra/bin/cqlsh.py", line 937, in onecmd
> self.handle_statement(st, statementtext)
> File "/usr/share/cassandra/bin/cqlsh.py", line 962, in handle_statement
> readline.add_history(new_hist)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe8' in position
> 134: ordinal not in range(128){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15990) Running CQL command with non-ASCII values raises UnicodeDecodeError
[
https://issues.apache.org/jira/browse/CASSANDRA-15990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15990:
Bug Category: Parent values: Degradation(12984)
Complexity: Normal
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Running CQL command with non-ASCII values raises UnicodeDecodeError
> ---
>
> Key: CASSANDRA-15990
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15990
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Joseph Chu
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There are INSERT statements that contains non-ASCII values that have run fine
> in Cassandra 3.11, but now raises a UnicodeDecodeError when I try executing
> them in 4.0-alpha4 and 4.0-beta1.
> Example input and output:
> {code:java}
> echo $LANG
> en_US.UTF-8
> $ cqlsh --debug
> Using CQL driver: '/usr/share/cassandra/bin/../lib/cassandra-driver-internal-only-3.23.0.post0-1a184b99.zip/cassandra-driver-3.23.0.post0-1a184b99/cassandra/__init__.py'>
> Using connect timeout: 5 seconds
> Using 'utf-8' encoding
> Using ssl: False
> Connected to Cassandra Cluster at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 4.0-beta1 | CQL spec 3.4.5 | Native protocol v4]
> Use HELP for help.
> cqlsh> CREATE KEYSPACE killr_video WITH replication = {'class':
> 'NetworkTopologyStrategy', 'DC-Houston': 1};
> cqlsh> USE killr_video;
> cqlsh:killr_video> CREATE TABLE movies_by_genre ( genre TEXT, title TEXT,
> year INT, duration INT, avg_rating FLOAT, country TEXT, PRIMARY KEY ((genre),
> title, year));
> cqlsh:killr_video> INSERT INTO movies_by_genre (genre, title, year, duration,
> avg_rating, country)
> ... VALUES ('Action', 'The Extraordinary Adventures of Adèle Blanc-Sec',
> 2010, 107, 6.30, 'France');
> Traceback (most recent call last):
> File "/usr/share/cassandra/bin/cqlsh.py", line 937, in onecmd
> self.handle_statement(st, statementtext)
> File "/usr/share/cassandra/bin/cqlsh.py", line 962, in handle_statement
> readline.add_history(new_hist)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe8' in position
> 134: ordinal not in range(128){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15981) jvm-dtests crash on java 11
[
https://issues.apache.org/jira/browse/CASSANDRA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170823#comment-17170823
]
Alex Petrov commented on CASSANDRA-15981:
-
The only thing I can say is that previously CI was failing without
{{MetaspaceSize}} params. Could you also trigger a "normal" CI pipeline, not
only {{HIGHRES}}. As long as it passes without an OOM killer, I'm +1.
> jvm-dtests crash on java 11
> ---
>
> Key: CASSANDRA-15981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15981
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There is a race condition bug with CMS and class unloading which cause the
> JVM to crash. Since jvm-dtests rely on class loaders and unloading, this
> causes sporadic JVM crashes that look like the following in CI logs
> {code}
> junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
> Please note the time in the report does not reflect the time until the VM
> exit.
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1387)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
[
https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-15583:
Description:
Reference [doc from
NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
for context.
*Shepherd: Sam Tunnicliffe*
Test plans should cover bundled first-party tooling and CLIs such as nodetool,
cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983,
CASSANDRA-12151).
*Progress as of Aug 2020*
{{ToolRunner}} has been added enabling us to test tools in java unit tests.
This includes capturing their stdout/err and stdin i.e. Most tools have a
starting unit test testing their cmd line args happy path. Tickets have been
created to improve coverage of those and flagged LHF. Also for those tools big
enough they can't be addressed in a simple ticket such as nodetool, a
placeholder ticket for future improvements has been created as well. Tickets
and status are:
||Tool||UX test||UT coverage||dtest coverage||Comments||
|Nodetool|(x)|(x) CASSANDRA-16026|(!)|Not all the sub commands are tested.
Dtest also test nodetool as a side effect|
|Cqlsh|(x)|(x) CASSANDRA-16025|(!)| |
|Cassandra-stress|(x)|(x) CASSANDRA-16024|(x)| |
|debug-cql|(x)|(x) CASSANDRA-16023|(x)| |
|fqltool|(x)|(/) CASSANDRA-16022|(!)| |
|auditlogviewer|(/) CASSANDRA-15991|(!) CASSANDRA-16021|(!)| |
|*Sstable utilities*| | | | |
|sstabledump|(/) CASSANDRA-15991|(x) CASSANDRA-16020|(!)| |
|sstableexpiredblockers|(/) CASSANDRA-15991|(x) CASSANDRA-16019|(!)| |
|sstablelevelreset|(/) CASSANDRA-15991|(x) CASSANDRA-16018|(!)| |
|sstableloader|(x)|(x) CASSANDRA-16017|(!)| |
|sstablemetadata|(/) CASSANDRA-15991|(x) CASSANDRA-16016|(x)|Ran in dtests, no
dedicated test|
|sstableofflinerelevel|(/) CASSANDRA-15991|(x) CASSANDRA-16015|(!)| |
|sstablerepairedset|(/) CASSANDRA-15991|(x) CASSANDRA-16014|(x)|Ran in dtests,
no dedicated test|
|sstablescrub|(/) CASSANDRA-15991|(x) CASSANDRA-16013|(!)| |
|sstablesplit|(/) CASSANDRA-15991|(x) CASSANDRA-16012|(!)| |
|sstableupgrade|(/) CASSANDRA-15991|(x) CASSANDRA-16011|(!)| |
|sstableutil|(/) CASSANDRA-15991|(x) CASSANDRA-16010|(!)| |
|sstableverify|(/) CASSANDRA-15991|(x) CASSANDRA-16009|(!)| |
was:
Reference [doc from
NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
for context.
*Shepherd: Sam Tunnicliffe*
Test plans should cover bundled first-party tooling and CLIs such as nodetool,
cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983,
CASSANDRA-12151).
||Tool||UX test||UT coverage||dtest coverage||Comments||
|Nodetool|(x)|(x) CASSANDRA-16026|(!)|Not all the sub commands are tested.
Dtest also test nodetool as a side effect|
|Cqlsh|(x)|(x) CASSANDRA-16025|(!)| |
|Cassandra-stress|(x)|(x) CASSANDRA-16024|(x)| |
|debug-cql|(x)|(x) CASSANDRA-16023|(x)| |
|fqltool|(x)|(/) CASSANDRA-16022|(!)| |
|auditlogviewer|(/) CASSANDRA-15991|(!) CASSANDRA-16021|(!)| |
|*Sstable utilities*| | | | |
|sstabledump|(/) CASSANDRA-15991|(x) CASSANDRA-16020|(!)| |
|sstableexpiredblockers|(/) CASSANDRA-15991|(x) CASSANDRA-16019|(!)| |
|sstablelevelreset|(/) CASSANDRA-15991|(x) CASSANDRA-16018|(!)| |
|sstableloader|(x)|(x) CASSANDRA-16017|(!)| |
|sstablemetadata|(/) CASSANDRA-15991|(x) CASSANDRA-16016|(x)|Ran in dtests, no
dedicated test|
|sstableofflinerelevel|(/) CASSANDRA-15991|(x) CASSANDRA-16015|(!)| |
|sstablerepairedset|(/) CASSANDRA-15991|(x) CASSANDRA-16014|(x)|Ran in dtests,
no dedicated test|
|sstablescrub|(/) CASSANDRA-15991|(x) CASSANDRA-16013|(!)| |
|sstablesplit|(/) CASSANDRA-15991|(x) CASSANDRA-16012|(!)| |
|sstableupgrade|(/) CASSANDRA-15991|(x) CASSANDRA-16011|(!)| |
|sstableutil|(/) CASSANDRA-15991|(x) CASSANDRA-16010|(!)| |
|sstableverify|(/) CASSANDRA-15991|(x) CASSANDRA-16009|(!)| |
> 4.0 quality testing: Tooling, Bundled and First Party
> -
>
> Key: CASSANDRA-15583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15583
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest, Test/unit
>Reporter: Josh McKenzie
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Reference [doc from
> NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#]
> for context.
> *Shepherd: Sam Tunnicliffe*
> Test plans should cover bundled first-party tooling and CLIs such as
> nodetool, cqlsh, and new tools supporting full query and audit logging
> (CASSANDRA-13983, CASSANDRA-12151).
> *Progress as of Aug 2020*
> {{ToolRunner}} has been added enabling us to test tools in java unit tests.
> This includes capturing their stdout/err and stdin i.e. Most tools have a
> starting unit test testing their cmd line args happy path.
[jira] [Updated] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15583: Description: Reference [doc from NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] for context. *Shepherd: Sam Tunnicliffe* Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151). ||Tool||UX test||UT coverage||dtest coverage||Comments|| |Nodetool|(x)|(x) CASSANDRA-16026|(!)|Not all the sub commands are tested. Dtest also test nodetool as a side effect| |Cqlsh|(x)|(x) CASSANDRA-16025|(!)| | |Cassandra-stress|(x)|(x) CASSANDRA-16024|(x)| | |debug-cql|(x)|(x) CASSANDRA-16023|(x)| | |fqltool|(x)|(/) CASSANDRA-16022|(!)| | |auditlogviewer|(/) CASSANDRA-15991|(!) CASSANDRA-16021|(!)| | |*Sstable utilities*| | | | | |sstabledump|(/) CASSANDRA-15991|(x) CASSANDRA-16020|(!)| | |sstableexpiredblockers|(/) CASSANDRA-15991|(x) CASSANDRA-16019|(!)| | |sstablelevelreset|(/) CASSANDRA-15991|(x) CASSANDRA-16018|(!)| | |sstableloader|(x)|(x) CASSANDRA-16017|(!)| | |sstablemetadata|(/) CASSANDRA-15991|(x) CASSANDRA-16016|(x)|Ran in dtests, no dedicated test| |sstableofflinerelevel|(/) CASSANDRA-15991|(x) CASSANDRA-16015|(!)| | |sstablerepairedset|(/) CASSANDRA-15991|(x) CASSANDRA-16014|(x)|Ran in dtests, no dedicated test| |sstablescrub|(/) CASSANDRA-15991|(x) CASSANDRA-16013|(!)| | |sstablesplit|(/) CASSANDRA-15991|(x) CASSANDRA-16012|(!)| | |sstableupgrade|(/) CASSANDRA-15991|(x) CASSANDRA-16011|(!)| | |sstableutil|(/) CASSANDRA-15991|(x) CASSANDRA-16010|(!)| | |sstableverify|(/) CASSANDRA-15991|(x) CASSANDRA-16009|(!)| | was: Reference [doc from NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] for context. *Shepherd: Sam Tunnicliffe* Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151). ||Tool||UX test||UT coverage||dtest coverage||Comments|| |Nodetool|(x)|(x)|(!)|Deserves it's own ticket. Not all the sub commands are tested. Dtest also test nodetool as a side effect| |Cqlsh|(x)|(x)|(!)|Deserves it's own ticket| |Cassandra-stress|(x)|(x)|(x)|Some UT. Deserves it's own ticket| |debug-cql|(x)|(x)|(x)|Deserves it's own ticket | |fqltool|(x)|(/)|(!)|Deserves it's own ticket| |auditlogviewer|(/)|(!)|(!)|UX tests: C-15991. Docs missing option -i| |*Sstable utilities*| | | | | |sstabledump|(/)|(x)|(!)|UX tests: C-15991| |sstableexpiredblockers|(/)|(x)|(!)|UX tests: C-15991| |sstablelevelreset|(/)|(x)|(!)|UX tests: C-15991| |sstableloader|(x)|(x)|(!)|Needs it's own ticket probably| |sstablemetadata|(/)|(x)|(x)|Ran in dtests, no dedicated test, UX tests: C-15991, missing options in docs, brittle args parsing| |sstableofflinerelevel|(/)|(x)|(!)|UX tests: C-15991, brittle args parsing| |sstablerepairedset|(/)|(x)|(x)|Ran in dtests, no dedicated test, UX tests: C-15991, brittle args parsing| |sstablescrub|(/)|(x)|(!)|UX tests: C-15991 but missing options in docs| |sstablesplit|(/)|(x)|(!)|UX tests: C-15991| |sstableupgrade|(/)|(x)|(!)|UX tests: C-15991| |sstableutil|(/)|(x)|(!)|UX tests: C-15991| |sstableverify|(/) CASSANDRA-15991 |(x)|(!)|UX tests: C-15991 but missing options in docs + broken token_range option| > 4.0 quality testing: Tooling, Bundled and First Party > - > > Key: CASSANDRA-15583 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 > Project: Cassandra > Issue Type: Task > Components: Test/dtest, Test/unit >Reporter: Josh McKenzie >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Reference [doc from > NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] > for context. > *Shepherd: Sam Tunnicliffe* > Test plans should cover bundled first-party tooling and CLIs such as > nodetool, cqlsh, and new tools supporting full query and audit logging > (CASSANDRA-13983, CASSANDRA-12151). > ||Tool||UX test||UT coverage||dtest coverage||Comments|| > |Nodetool|(x)|(x) CASSANDRA-16026|(!)|Not all the sub commands are tested. > Dtest also test nodetool as a side effect| > |Cqlsh|(x)|(x) CASSANDRA-16025|(!)| | > |Cassandra-stress|(x)|(x) CASSANDRA-16024|(x)| | > |debug-cql|(x)|(x) CASSANDRA-16023|(x)| | > |fqltool|(x)|(/) CASSANDRA-16022|(!)| | > |auditlogviewer|(/) CASSANDRA-15991|(!) CASSANDRA-16021|(!)| | > |*Sstable utilities*| | | | | > |sstabledump|(/) CASSANDRA-15991|(x) CASSANDRA-16020|(!)| | > |sstableexpiredblockers|(/) CASSANDRA-15991|(x) CASSANDRA-16019|(!)| | > |sstablelevelreset|(/) CASSANDRA-15991|(x) CASSANDRA-16018|(!)| | >
[jira] [Created] (CASSANDRA-16026) Nodetool unit test coverage
Berenguer Blasi created CASSANDRA-16026: --- Summary: Nodetool unit test coverage Key: CASSANDRA-16026 URL: https://issues.apache.org/jira/browse/CASSANDRA-16026 Project: Cassandra Issue Type: Bug Components: Tool/nodetool Reporter: Berenguer Blasi Nowadays the majority of nodetool testing happens outside the main java unit testing effort. A lot is done as separate dtests under python, some commands don't have dedicated tests, some only get tested as a side effect of some other test, etc. The purpose of this ticket is to improve unit test coverage as much as possible now that CASSANDRA-15583 allows us to perform java unit tests for the tool. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16025) Cqlsh unit testing and coverage improvements
Berenguer Blasi created CASSANDRA-16025: --- Summary: Cqlsh unit testing and coverage improvements Key: CASSANDRA-16025 URL: https://issues.apache.org/jira/browse/CASSANDRA-16025 Project: Cassandra Issue Type: Bug Components: Tool/cqlsh Reporter: Berenguer Blasi Nowadays the majority of cqlsh testing happens outside the main java unit testing effort. A lot is done as separate cqlsh tests, dtests, python, etc. The purpose of this ticket is to improve unit test coverage as much as possible now that CASSANDRA-15583 allows us to perform java unit tests for the tool. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16024) cassandra-stress unit test coverage
Berenguer Blasi created CASSANDRA-16024:
---
Summary: cassandra-stress unit test coverage
Key: CASSANDRA-16024
URL: https://issues.apache.org/jira/browse/CASSANDRA-16024
Project: Cassandra
Issue Type: Bug
Components: Tool/stress
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool can be improved a lot. There is a unit test to enhance upon under
{{tools/stress/test/unit}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16023) Add debug-cql unit tests and docs
Berenguer Blasi created CASSANDRA-16023:
---
Summary: Add debug-cql unit tests and docs
Key: CASSANDRA-16023
URL: https://issues.apache.org/jira/browse/CASSANDRA-16023
Project: Cassandra
Issue Type: Bug
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is zero. A unit test should be added under
{{test/unit/org/apache/cassandra/tools}}. Also docs need to be added.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16022) fqltool unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16022:
Description: During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit
test coverage for this tool can be improved. There is a unit test to enhance
upon under {{test/unit/org/apache/cassandra/tools}}. (was: During
CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for this
tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.)
> fqltool unit test hardening
> ---
>
> Key: CASSANDRA-16022
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16022
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/fql
>Reporter: Berenguer Blasi
>Priority: Normal
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool can be improved. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16022) fqltool unit test hardening
Berenguer Blasi created CASSANDRA-16022:
---
Summary: fqltool unit test hardening
Key: CASSANDRA-16022
URL: https://issues.apache.org/jira/browse/CASSANDRA-16022
Project: Cassandra
Issue Type: Bug
Components: Tool/fql
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16021) auditlogviewer unit test hardening and docs update
Berenguer Blasi created CASSANDRA-16021:
---
Summary: auditlogviewer unit test hardening and docs update
Key: CASSANDRA-16021
URL: https://issues.apache.org/jira/browse/CASSANDRA-16021
Project: Cassandra
Issue Type: Bug
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}. Also docs need updating to reflect
all available options
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16020) sstabledump unit test hardening
Berenguer Blasi created CASSANDRA-16020:
---
Summary: sstabledump unit test hardening
Key: CASSANDRA-16020
URL: https://issues.apache.org/jira/browse/CASSANDRA-16020
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16019) sstableexpiredblockers
[
https://issues.apache.org/jira/browse/CASSANDRA-16019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16019:
Labels: low-hanging-fruit (was: )
> sstableexpiredblockers
> --
>
> Key: CASSANDRA-16019
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16019
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16020) sstabledump unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16020:
Labels: low-hanging-fruit (was: )
> sstabledump unit test hardening
> ---
>
> Key: CASSANDRA-16020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16020
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16019) sstableexpiredblockers
Berenguer Blasi created CASSANDRA-16019:
---
Summary: sstableexpiredblockers
Key: CASSANDRA-16019
URL: https://issues.apache.org/jira/browse/CASSANDRA-16019
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16018) sstablelevelreset unti test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16018:
Labels: low-hanging-fruit (was: )
> sstablelevelreset unti test hardening
> -
>
> Key: CASSANDRA-16018
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16018
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16017) sstableloader unit testing, docs and args parsing
Berenguer Blasi created CASSANDRA-16017:
---
Summary: sstableloader unit testing, docs and args parsing
Key: CASSANDRA-16017
URL: https://issues.apache.org/jira/browse/CASSANDRA-16017
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. A unit test under
{{test/unit/org/apache/cassandra/tools}} is needed, docs improvements to
reflect all options making sure cmd args parsing is done through some framework
rather than being a simple brittle custom code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16017) sstableloader unit testing, docs and args parsing
[
https://issues.apache.org/jira/browse/CASSANDRA-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16017:
Labels: low-hanging-fruit (was: )
> sstableloader unit testing, docs and args parsing
> -
>
> Key: CASSANDRA-16017
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16017
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. A unit test under
> {{test/unit/org/apache/cassandra/tools}} is needed, docs improvements to
> reflect all options making sure cmd args parsing is done through some
> framework rather than being a simple brittle custom code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16018) sstablelevelreset unti test hardening
Berenguer Blasi created CASSANDRA-16018:
---
Summary: sstablelevelreset unti test hardening
Key: CASSANDRA-16018
URL: https://issues.apache.org/jira/browse/CASSANDRA-16018
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16016) sstablemetadata unit test, docs and params parsing hardening
Berenguer Blasi created CASSANDRA-16016:
---
Summary: sstablemetadata unit test, docs and params parsing
hardening
Key: CASSANDRA-16016
URL: https://issues.apache.org/jira/browse/CASSANDRA-16016
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}. Also docs are missing some options
and args parsing is brittle, they should be moved to some args parsing
framework.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16015) sstableofflinerelevel unit test hardening
Berenguer Blasi created CASSANDRA-16015:
---
Summary: sstableofflinerelevel unit test hardening
Key: CASSANDRA-16015
URL: https://issues.apache.org/jira/browse/CASSANDRA-16015
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}. Also the tools parsing of args seems
brittle and it would benefit from using some cmd parsing framework.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16015) sstableofflinerelevel unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16015:
Labels: low-hanging-fruit (was: )
> sstableofflinerelevel unit test hardening
> -
>
> Key: CASSANDRA-16015
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16015
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}. Also the tools parsing of args
> seems brittle and it would benefit from using some cmd parsing framework.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16014) sstablerepairedset unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16014:
Description: During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit
test coverage for this tool is minimal. There is a unit test to enhance upon
under {{test/unit/org/apache/cassandra/tools}}. Aso args parsing is brittle and
it would benefit from migrating to some args parsing framework. (was: During
CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for this
tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.)
> sstablerepairedset unit test hardening
> --
>
> Key: CASSANDRA-16014
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16014
> Project: Cassandra
> Issue Type: Bug
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}. Aso args parsing is brittle and it
> would benefit from migrating to some args parsing framework.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15925) Jenkins pipeline can copy wrong test report artefacts from stage builds
[ https://issues.apache.org/jira/browse/CASSANDRA-15925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-15925: --- Fix Version/s: (was: 4.0-rc) (was: 3.11.x) (was: 3.0.x) (was: 2.2.x) 2.2.18 4.0-beta2 3.11.8 3.0.22 Since Version: 4.0-alpha1 Source Control Link: https://github.com/apache/cassandra/commit/bb2562b7774caf0b5037c5cd10f5fe07f75ed92f Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as [bb2562b7774caf0b5037c5cd10f5fe07f75ed92f |https://github.com/apache/cassandra/commit/bb2562b7774caf0b5037c5cd10f5fe07f75ed92f] > Jenkins pipeline can copy wrong test report artefacts from stage builds > --- > > Key: CASSANDRA-15925 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15925 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 3.0.22, 3.11.8, 4.0-beta2, 2.2.18 > > > Spotted in > https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/196/console > Looks like copyArtifact will need to be specific to a build. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16014) sstablerepairedset unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16014:
Labels: low-hanging-fruit (was: )
> sstablerepairedset unit test hardening
> --
>
> Key: CASSANDRA-16014
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16014
> Project: Cassandra
> Issue Type: Bug
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16014) sstablerepairedset unit test hardening
Berenguer Blasi created CASSANDRA-16014:
---
Summary: sstablerepairedset unit test hardening
Key: CASSANDRA-16014
URL: https://issues.apache.org/jira/browse/CASSANDRA-16014
Project: Cassandra
Issue Type: Bug
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16013) sstablescrub unit test hardening an docs improvements
Berenguer Blasi created CASSANDRA-16013:
---
Summary: sstablescrub unit test hardening an docs improvements
Key: CASSANDRA-16013
URL: https://issues.apache.org/jira/browse/CASSANDRA-16013
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}. Also docs need updating to reflect
the latest options available.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16013) sstablescrub unit test hardening an docs improvements
[
https://issues.apache.org/jira/browse/CASSANDRA-16013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16013:
Labels: low-hanging-fruit (was: )
> sstablescrub unit test hardening an docs improvements
> -
>
> Key: CASSANDRA-16013
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16013
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}. Also docs need updating to reflect
> the latest options available.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16012) sstablesplit unit test hardening
Berenguer Blasi created CASSANDRA-16012:
---
Summary: sstablesplit unit test hardening
Key: CASSANDRA-16012
URL: https://issues.apache.org/jira/browse/CASSANDRA-16012
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16012) sstablesplit unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16012:
Labels: low-hanging-fruit (was: )
> sstablesplit unit test hardening
>
>
> Key: CASSANDRA-16012
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16012
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-2.2 updated: Jenkinsfile fixes for wrong test reports being copied, and reports getting clobbered
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch cassandra-2.2
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-2.2 by this push:
new bb2562b Jenkinsfile fixes for wrong test reports being copied, and
reports getting clobbered
bb2562b is described below
commit bb2562b7774caf0b5037c5cd10f5fe07f75ed92f
Author: Mick Semb Wever
AuthorDate: Sat Jul 4 23:19:17 2020 +0200
Jenkinsfile fixes for wrong test reports being copied, and reports getting
clobbered
- copy artifacts from specific build numbers, not lastest stage builds
- presend script to avoid threads in the builds mailing list
- Suffix "cassandra.testtag" value to the testsuite name, so testsuite
elements are separated cleanly
patch by Mick Semb Wever; reviewed by Berenguer Blasi for CASSANDRA-15925
---
.jenkins/Jenkinsfile | 306 +
.../CassandraXMLJUnitResultFormatter.java | 4 +-
2 files changed, 128 insertions(+), 182 deletions(-)
diff --git a/.jenkins/Jenkinsfile b/.jenkins/Jenkinsfile
index 77c111c..dc5982a 100644
--- a/.jenkins/Jenkinsfile
+++ b/.jenkins/Jenkinsfile
@@ -37,236 +37,182 @@ pipeline {
}
}
stage('Test') {
- parallel {
-stage('JVM DTests') {
- steps {
- warnError('Tests unstable') {
-build job: "${env.JOB_NAME}-jvm-dtest"
+parallel {
+ stage('JVM DTests') {
+steps {
+ script {
+jvm_dtest = build job: "${env.JOB_NAME}-jvm-dtest", propagate:
false
+if (jvm_dtest.result != 'SUCCESS') unstable('jvm-dtest
failures')
+ }
+}
+post {
+ always {
+ warnError('missing test xml files') {
+ script {
+ copyTestResults('jvm-dtest', jvm_dtest.getNumber())
+ }
}
}
- post {
-success {
-warnError('missing test xml files') {
-script {
-copyTestResults('jvm-dtest')
-}
-}
-}
-unstable {
-warnError('missing test xml files') {
-script {
-copyTestResults('jvm-dtest')
-}
-}
-}
+}
+ }
+ stage('units') {
+steps {
+ script {
+test = build job: "${env.JOB_NAME}-test", propagate: false
+if (test.result != 'SUCCESS') unstable('unit test failures')
}
}
-stage('units') {
-steps {
- warnError('Tests unstable') {
-build job: "${env.JOB_NAME}-test"
+post {
+ always {
+ warnError('missing test xml files') {
+ script {
+ copyTestResults('test', test.getNumber())
+ }
}
-}
- post {
-success {
-warnError('missing test xml files') {
-script {
-copyTestResults('test')
-}
-}
-}
-unstable {
-warnError('missing test xml files') {
-script {
-copyTestResults('test')
-}
-}
-}
}
}
-stage('long units') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-long-test"
+ }
+ stage('long units') {
+steps {
+ script {
+long_test = build job: "${env.JOB_NAME}-long-test", propagate:
false
+if (long_test.result != 'SUCCESS') unstable('long unit test
failures')
+ }
+}
+post {
+ always {
+ warnError('missing test xml files') {
+ script {
+ copyTestResults('long-test', long_test.getNumber())
+ }
}
}
- post {
-success {
-warnError('missing test xml files') {
-script {
-copyTestResults('long-test')
-}
-}
-}
-unstable {
-warnError('missing test xml files') {
-
[jira] [Updated] (CASSANDRA-16011) sstableupgrade unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16011:
Labels: low-hanging-fruit (was: )
> sstableupgrade unit test hardening
> --
>
> Key: CASSANDRA-16011
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16011
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 0310a7e42e26520cda2777bfb15a7e903c9f743a
Merge: 45ac5c5 2844454
Author: Mick Semb Wever
AuthorDate: Tue Aug 4 10:45:25 2020 +0200
Merge branch 'cassandra-3.0' into cassandra-3.11
.jenkins/Jenkinsfile | 412 +
.../CassandraXMLJUnitResultFormatter.java | 4 +-
2 files changed, 173 insertions(+), 243 deletions(-)
diff --cc .jenkins/Jenkinsfile
index bb828e3,4a640c2..9d94afb
--- a/.jenkins/Jenkinsfile
+++ b/.jenkins/Jenkinsfile
@@@ -26,246 -26,153 +26,187 @@@
pipeline {
agent { label 'cassandra' }
stages {
-- stage('Init') {
++stage('Init') {
steps {
cleanWs()
}
-- }
-- stage('Build') {
++}
++stage('Build') {
steps {
build job: "${env.JOB_NAME}-artifacts"
}
-- }
-- stage('Test') {
- parallel {
- stage('stress') {
- steps {
- build job: "${env.JOB_NAME}-stress-test"
- }
- post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('stress-test')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
- copyTestResults('stress-test')
- }
- }
++}
++stage('Test') {
+ parallel {
++ stage('stress') {
++steps {
++script {
++ stress = build job: "${env.JOB_NAME}-stress-test",
propagate: false
++ if (stress.result != 'SUCCESS') unstable('stress test
failures')
+}
- }
+}
- stage('JVM DTests') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-jvm-dtest"
++post {
++ always {
++ warnError('missing test xml files') {
++ script {
++ copyTestResults('stress-test', stress.getNumber())
++ }
+ }
+ }
- post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('jvm-dtest')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
- copyTestResults('jvm-dtest')
- }
- }
- }
- }
+}
- stage('units') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test"
- }
- }
- post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('test')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
- copyTestResults('test')
- }
- }
- }
++ }
+ stage('JVM DTests') {
+ steps {
+ script {
+ jvm_dtest = build job: "${env.JOB_NAME}-jvm-dtest",
propagate: false
+ if (jvm_dtest.result != 'SUCCESS') unstable('jvm-dtest
failures')
}
}
- stage('long units') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-long-test"
+ post {
+ always {
+ warnError('missing test xml files') {
+ script {
+ copyTestResults('jvm-dtest', jvm_dtest.getNumber())
+ }
}
}
- post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('long-test')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
-
[jira] [Created] (CASSANDRA-16011) sstableupgrade unit test hardening
Berenguer Blasi created CASSANDRA-16011:
---
Summary: sstableupgrade unit test hardening
Key: CASSANDRA-16011
URL: https://issues.apache.org/jira/browse/CASSANDRA-16011
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-2.2' into cassandra-3.0
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 2844454669f41eca8113a97e01b59c3a74a14448
Merge: 8b8ec94 bb2562b
Author: Mick Semb Wever
AuthorDate: Tue Aug 4 10:44:11 2020 +0200
Merge branch 'cassandra-2.2' into cassandra-3.0
.jenkins/Jenkinsfile | 296 +
.../CassandraXMLJUnitResultFormatter.java | 4 +-
2 files changed, 123 insertions(+), 177 deletions(-)
diff --cc .jenkins/Jenkinsfile
index 2b371c0,dc5982a..4a640c2
--- a/.jenkins/Jenkinsfile
+++ b/.jenkins/Jenkinsfile
@@@ -37,191 -37,125 +37,142 @@@ pipeline
}
}
stage('Test') {
- parallel {
- stage('JVM DTests') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-jvm-dtest"
- }
- }
- post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('jvm-dtest')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
- copyTestResults('jvm-dtest')
- }
- }
- }
+ parallel {
+ stage('JVM DTests') {
+ steps {
+ script {
+ jvm_dtest = build job: "${env.JOB_NAME}-jvm-dtest",
propagate: false
+ if (jvm_dtest.result != 'SUCCESS') unstable('jvm-dtest
failures')
}
}
- stage('units') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test"
+ post {
+ always {
+ warnError('missing test xml files') {
+ script {
+ copyTestResults('jvm-dtest', jvm_dtest.getNumber())
+ }
}
- }
- post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('test')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
- copyTestResults('test')
- }
- }
- }
}
}
- stage('long units') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-long-test"
+ }
+ stage('units') {
+ steps {
+ script {
+ test = build job: "${env.JOB_NAME}-test", propagate: false
+ if (test.result != 'SUCCESS') unstable('unit test failures')
+ }
+ }
+ post {
+ always {
+ warnError('missing test xml files') {
+ script {
+ copyTestResults('test', test.getNumber())
+ }
}
}
- post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('long-test')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
- copyTestResults('long-test')
- }
- }
- }
+ }
+ }
+ stage('long units') {
+ steps {
+ script {
+ long_test = build job: "${env.JOB_NAME}-long-test",
propagate: false
+ if (long_test.result != 'SUCCESS') unstable('long unit test
failures')
}
}
- stage('burn') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-burn"
+ post {
+ always {
+ warnError('missing test xml files') {
+ script {
+ copyTestResults('long-test', long_test.getNumber())
+ }
}
}
- post {
- success {
- warnError('missing test xml files') {
-
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 0c9336b4307fd1161680e09efa281122874a465f
Merge: e163855 0310a7e
Author: Mick Semb Wever
AuthorDate: Tue Aug 4 10:48:58 2020 +0200
Merge branch 'cassandra-3.11' into trunk
.jenkins/Jenkinsfile | 294 -
.../CassandraXMLJUnitResultFormatter.java | 4 +-
2 files changed, 112 insertions(+), 186 deletions(-)
diff --cc .jenkins/Jenkinsfile
index 586c048,9d94afb..cf6afee
--- a/.jenkins/Jenkinsfile
+++ b/.jenkins/Jenkinsfile
@@@ -59,45 -55,18 +55,35 @@@ pipeline
}
}
}
+ stage('fqltool') {
+steps {
- build job: "${env.JOB_NAME}-fqltool-test"
++script {
++ fqltool = build job: "${env.JOB_NAME}-fqltool-test",
propagate: false
++ if (fqltool.result != 'SUCCESS') unstable('fqltool test
failures')
++}
+}
+post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('fqltool-test')
- }
- }
- }
- unstable {
++ always {
+ warnError('missing test xml files') {
+ script {
- copyTestResults('fqltool-test')
++ copyTestResults('fqltool-test', fqltool.getNumber())
+ }
+ }
+ }
+}
+ }
stage('JVM DTests') {
steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-jvm-dtest"
- }
+ script {
+ jvm_dtest = build job: "${env.JOB_NAME}-jvm-dtest",
propagate: false
+ if (jvm_dtest.result != 'SUCCESS') unstable('jvm-dtest
failures')
+ }
}
post {
- success {
+ always {
warnError('missing test xml files') {
script {
- copyTestResults('jvm-dtest')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
- copyTestResults('jvm-dtest')
+ copyTestResults('jvm-dtest', jvm_dtest.getNumber())
}
}
}
@@@ -172,75 -140,40 +157,40 @@@
}
}
}
- stage('cdc') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-cdc"
- }
- }
- post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('test-cdc')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
- copyTestResults('test-cdc')
- }
- }
- }
+ stage('compression') {
+ steps {
+ script {
+ compression = build job: "${env.JOB_NAME}-test-compression",
propagate: false
+ if (compression.result != 'SUCCESS') unstable('compression
failures')
}
}
- stage('compression') {
- steps {
- warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-compression"
+ post {
+ always {
+ warnError('missing test xml files') {
+ script {
+ copyTestResults('test-compression',
compression.getNumber())
+ }
}
}
- post {
- success {
- warnError('missing test xml files') {
- script {
- copyTestResults('test-compression')
- }
- }
- }
- unstable {
- warnError('missing test xml files') {
- script {
- copyTestResults('test-compression')
- }
- }
- }
- }
}
- stage('cqlsh') {
- steps {
-
[cassandra] branch cassandra-3.11 updated (45ac5c5 -> 0310a7e)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 45ac5c5 Merge branch 'cassandra-3.0' into cassandra-3.11 new bb2562b Jenkinsfile fixes for wrong test reports being copied, and reports getting clobbered new 2844454 Merge branch 'cassandra-2.2' into cassandra-3.0 new 0310a7e Merge branch 'cassandra-3.0' into cassandra-3.11 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .jenkins/Jenkinsfile | 412 + .../CassandraXMLJUnitResultFormatter.java | 4 +- 2 files changed, 173 insertions(+), 243 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (8b8ec94 -> 2844454)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 8b8ec94 When jvm dtest apis differ Circle CI's dtest_jars_build can fail to detect this and will use the jars from the older version new bb2562b Jenkinsfile fixes for wrong test reports being copied, and reports getting clobbered new 2844454 Merge branch 'cassandra-2.2' into cassandra-3.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .jenkins/Jenkinsfile | 296 + .../CassandraXMLJUnitResultFormatter.java | 4 +- 2 files changed, 123 insertions(+), 177 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (e163855 -> 0c9336b)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from e163855 Merge branch 'cassandra-3.11' into trunk new bb2562b Jenkinsfile fixes for wrong test reports being copied, and reports getting clobbered new 2844454 Merge branch 'cassandra-2.2' into cassandra-3.0 new 0310a7e Merge branch 'cassandra-3.0' into cassandra-3.11 new 0c9336b Merge branch 'cassandra-3.11' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .jenkins/Jenkinsfile | 294 - .../CassandraXMLJUnitResultFormatter.java | 4 +- 2 files changed, 112 insertions(+), 186 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16009) sstableverify unit test hardening and docs improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-16009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16009:
Labels: low-hanging-fruit (was: )
> sstableverify unit test hardening and docs improvement
> --
>
> Key: CASSANDRA-16009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16009
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}. Also docs need to be updated with
> any missing options and the {{token_range}} option needs to be fixed as it
> appears broken.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16010) sstableutil unit test hardening
[
https://issues.apache.org/jira/browse/CASSANDRA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16010:
Labels: low-hanging-fruit (was: )
> sstableutil unit test hardening
> ---
>
> Key: CASSANDRA-16010
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16010
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
> Labels: low-hanging-fruit
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16010) sstableutil unit test hardening
Berenguer Blasi created CASSANDRA-16010:
---
Summary: sstableutil unit test hardening
Key: CASSANDRA-16010
URL: https://issues.apache.org/jira/browse/CASSANDRA-16010
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage for
this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16009) sstableverify unit test hardening and docs improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-16009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16009:
Description: During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit
test coverage for this tool is minimal. There is a unit test to enhance upon
under {{test/unit/org/apache/cassandra/tools}}. Also docs need to be updated
with any missing options and the {{token_range}} option needs to be fixed as it
appears broken. (was: During CASSANDRA-15991 it was detected unit test
coverage for this tool is minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}. Also docs need to be updated with any
missing options and the {{token_range}} option needs to be fixed as it appears
broken.)
> sstableverify unit test hardening and docs improvement
> --
>
> Key: CASSANDRA-16009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16009
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
>Reporter: Berenguer Blasi
>Priority: Normal
>
> During CASSANDRA-15883 / CASSANDRA-15991 it was detected unit test coverage
> for this tool is minimal. There is a unit test to enhance upon under
> {{test/unit/org/apache/cassandra/tools}}. Also docs need to be updated with
> any missing options and the {{token_range}} option needs to be fixed as it
> appears broken.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15583: Description: Reference [doc from NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] for context. *Shepherd: Sam Tunnicliffe* Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151). ||Tool||UX test||UT coverage||dtest coverage||Comments|| |Nodetool|(x)|(x)|(!)|Deserves it's own ticket. Not all the sub commands are tested. Dtest also test nodetool as a side effect| |Cqlsh|(x)|(x)|(!)|Deserves it's own ticket| |Cassandra-stress|(x)|(x)|(x)|Some UT. Deserves it's own ticket| |debug-cql|(x)|(x)|(x)|Deserves it's own ticket | |fqltool|(x)|(/)|(!)|Deserves it's own ticket| |auditlogviewer|(/)|(!)|(!)|UX tests: C-15991. Docs missing option -i| |*Sstable utilities*| | | | | |sstabledump|(/)|(x)|(!)|UX tests: C-15991| |sstableexpiredblockers|(/)|(x)|(!)|UX tests: C-15991| |sstablelevelreset|(/)|(x)|(!)|UX tests: C-15991| |sstableloader|(x)|(x)|(!)|Needs it's own ticket probably| |sstablemetadata|(/)|(x)|(x)|Ran in dtests, no dedicated test, UX tests: C-15991, missing options in docs, brittle args parsing| |sstableofflinerelevel|(/)|(x)|(!)|UX tests: C-15991, brittle args parsing| |sstablerepairedset|(/)|(x)|(x)|Ran in dtests, no dedicated test, UX tests: C-15991, brittle args parsing| |sstablescrub|(/)|(x)|(!)|UX tests: C-15991 but missing options in docs| |sstablesplit|(/)|(x)|(!)|UX tests: C-15991| |sstableupgrade|(/)|(x)|(!)|UX tests: C-15991| |sstableutil|(/)|(x)|(!)|UX tests: C-15991| |sstableverify|(/) CASSANDRA-15991 |(x)|(!)|UX tests: C-15991 but missing options in docs + broken token_range option| was: Reference [doc from NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] for context. *Shepherd: Sam Tunnicliffe* Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151). ||Tool||UX test||UT coverage||dtest coverage||Comments|| |Nodetool|(x)|(x)|(!)|Deserves it's own ticket. Not all the sub commands are tested. Dtest also test nodetool as a side effect| |Cqlsh|(x)|(x)|(!)|Deserves it's own ticket| |Cassandra-stress|(x)|(x)|(x)|Some UT. Deserves it's own ticket| |debug-cql|(x)|(x)|(x)|Deserves it's own ticket | |fqltool|(x)|(/)|(!)|Deserves it's own ticket | |auditlogviewer|(/)|(!)|(!)|UX tests: C-15991. Docs missing option -i| |*Sstable utilities*| | | | | |sstabledump|(/)|(x)|(!)|UX tests: C-15991| |sstableexpiredblockers|(/)|(x)|(!)|UX tests: C-15991| |sstablelevelreset|(/)|(x)|(!)|UX tests: C-15991| |sstableloader|(x)|(x)|(!)|Needs it's own ticket probably| |sstablemetadata|(/)|(x)|(x)|Ran in dtests, no dedicated test, UX tests: C-15991, missing options in docs, brittle args parsing| |sstableofflinerelevel|(/)|(x)|(!)|UX tests: C-15991, brittle args parsing| |sstablerepairedset|(/)|(x)|(x)|Ran in dtests, no dedicated test, UX tests: C-15991, brittle args parsing| |sstablescrub|(/)|(x)|(!)|UX tests: C-15991 but missing options in docs| |sstablesplit|(/)|(x)|(!)|UX tests: C-15991| |sstableupgrade|(/)|(x)|(!)|UX tests: C-15991| |sstableutil|(/)|(x)|(!)|UX tests: C-15991| |sstableverify|(/)|(x)|(!)|UX tests: C-15991 but missing options in docs + broken token_range option| > 4.0 quality testing: Tooling, Bundled and First Party > - > > Key: CASSANDRA-15583 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 > Project: Cassandra > Issue Type: Task > Components: Test/dtest, Test/unit >Reporter: Josh McKenzie >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Reference [doc from > NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] > for context. > *Shepherd: Sam Tunnicliffe* > Test plans should cover bundled first-party tooling and CLIs such as > nodetool, cqlsh, and new tools supporting full query and audit logging > (CASSANDRA-13983, CASSANDRA-12151). > ||Tool||UX test||UT coverage||dtest coverage||Comments|| > |Nodetool|(x)|(x)|(!)|Deserves it's own ticket. Not all the sub commands are > tested. Dtest also test nodetool as a side effect| > |Cqlsh|(x)|(x)|(!)|Deserves it's own ticket| > |Cassandra-stress|(x)|(x)|(x)|Some UT. Deserves it's own ticket| > |debug-cql|(x)|(x)|(x)|Deserves it's own ticket | > |fqltool|(x)|(/)|(!)|Deserves it's own ticket| > |auditlogviewer|(/)|(!)|(!)|UX tests: C-15991. Docs missing option -i| > |*Sstable utilities*| | | | | > |sstabledump|(/)|(x)|(!)|UX tests: C-15991| >
[jira] [Created] (CASSANDRA-16009) sstableverify unit test hardening and docs improvement
Berenguer Blasi created CASSANDRA-16009:
---
Summary: sstableverify unit test hardening and docs improvement
Key: CASSANDRA-16009
URL: https://issues.apache.org/jira/browse/CASSANDRA-16009
Project: Cassandra
Issue Type: Bug
Components: Tool/sstable
Reporter: Berenguer Blasi
During CASSANDRA-15991 it was detected unit test coverage for this tool is
minimal. There is a unit test to enhance upon under
{{test/unit/org/apache/cassandra/tools}}. Also docs need to be updated with any
missing options and the {{token_range}} option needs to be fixed as it appears
broken.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16003) ToolRunner added in CASSANDRA-15942 stdErr checks improvements
[
https://issues.apache.org/jira/browse/CASSANDRA-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170629#comment-17170629
]
Berenguer Blasi commented on CASSANDRA-16003:
-
Thanks [~dcapwell]. I left an explanation for the choice I made. If it sgt you
feel free to commit, otherwise let me know and I'll push a commit.
> ToolRunner added in CASSANDRA-15942 stdErr checks improvements
> --
>
> Key: CASSANDRA-16003
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16003
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The JVM will output to stderr on some environments to show what flags that
> were picked up, when this happens all tests which validate stderr start to
> fail. This was found in the org.apache.cassandra.tools.ClearSnapshotTest as
> it switched to use the ToolRunner; below is a sample failure on my laptop (I
> had to modify the asserts since they don’t include the input)
> {code}
> java.lang.AssertionError:
> Expecting empty but was:<"Picked up _JAVA_OPTIONS:
> -Djava.net.preferIPv4Stack=true
> ">
> at
> org.apache.cassandra.tools.ToolRunner.assertEmptyStdErr(ToolRunner.java:339)
> at
> org.apache.cassandra.tools.ToolRunner.waitAndAssertOnCleanExit(ToolRunner.java:334)
> at
> org.apache.cassandra.tools.ClearSnapshotTest.testClearSnapshot_RemoveMultiple(ClearSnapshotTest.java:91)
> {code}
> Here _JAVA_OPTIONS is used globally on my system so fails the test; there is
> also JAVA_TOOL_RUNNER which is used the same way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
