[jira] [Updated] (CASSANDRA-17129) Classpath can be broken when multiple artifacts are present in build dir
[
https://issues.apache.org/jira/browse/CASSANDRA-17129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-17129:
---
Fix Version/s: 2.2.x
3.0.x
3.11.x
4.0.x
4.x
> Classpath can be broken when multiple artifacts are present in build dir
>
>
> Key: CASSANDRA-17129
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17129
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> {noformat}
> $ ant artifacts
> $ ls -1 build/apache-cassandra-*.jar
> build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> build/apache-cassandra-4.1-SNAPSHOT.jar
> $ bin/cassandra -f
> ...
> Error: Could not find or load main class
> org.apache.cassandra.service.CassandraDaemon
> {noformat}
> Classpath is something like:
> {noformat}
> ...bin/../conf:bin/../build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT.jar:bin/../lib/HdrHistogram-2.1.9.jar:bin/../lib/ST4-4.0.8.jar:bin/../lib/airline-0.8.jar:bin/../lib/antlr-runtime-3.5.2.jar:bin/../lib/asm-7.1.jar:bin/../lib/caffeine-2.9.2.jar:bin...
> {noformat}
> notice that:
> - javadoc and sources jars are on the classpath
> - classpath is broken because javadoc, sources and main jar are separated by
> blankspaces instead of colons
> The problem is in {{cassandra.in.sh}} where the main jar gets added to the
> classpath:
> {noformat}
> cassandra_bin=`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar`
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17129) Classpath can be broken when multiple artifacts are present in build dir
[
https://issues.apache.org/jira/browse/CASSANDRA-17129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-17129:
--
Bug Category: Parent values: Packaging(13660)
Complexity: Low Hanging Fruit
Component/s: Build
Discovered By: User Report
Reviewers: Michael Semb Wever
Severity: Low
Status: Open (was: Triage Needed)
> Classpath can be broken when multiple artifacts are present in build dir
>
>
> Key: CASSANDRA-17129
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17129
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
> {noformat}
> $ ant artifacts
> $ ls -1 build/apache-cassandra-*.jar
> build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> build/apache-cassandra-4.1-SNAPSHOT.jar
> $ bin/cassandra -f
> ...
> Error: Could not find or load main class
> org.apache.cassandra.service.CassandraDaemon
> {noformat}
> Classpath is something like:
> {noformat}
> ...bin/../conf:bin/../build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT.jar:bin/../lib/HdrHistogram-2.1.9.jar:bin/../lib/ST4-4.0.8.jar:bin/../lib/airline-0.8.jar:bin/../lib/antlr-runtime-3.5.2.jar:bin/../lib/asm-7.1.jar:bin/../lib/caffeine-2.9.2.jar:bin...
> {noformat}
> notice that:
> - javadoc and sources jars are on the classpath
> - classpath is broken because javadoc, sources and main jar are separated by
> blankspaces instead of colons
> The problem is in {{cassandra.in.sh}} where the main jar gets added to the
> classpath:
> {noformat}
> cassandra_bin=`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar`
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17129) Classpath can be broken when multiple artifacts are present in build dir
[
https://issues.apache.org/jira/browse/CASSANDRA-17129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski reassigned CASSANDRA-17129:
-
Assignee: Jacek Lewandowski
> Classpath can be broken when multiple artifacts are present in build dir
>
>
> Key: CASSANDRA-17129
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17129
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
> {noformat}
> $ ant artifacts
> $ ls -1 build/apache-cassandra-*.jar
> build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> build/apache-cassandra-4.1-SNAPSHOT.jar
> $ bin/cassandra -f
> ...
> Error: Could not find or load main class
> org.apache.cassandra.service.CassandraDaemon
> {noformat}
> Classpath is something like:
> {noformat}
> ...bin/../conf:bin/../build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT-sources.jar
> bin/../build/apache-cassandra-4.1-SNAPSHOT.jar:bin/../lib/HdrHistogram-2.1.9.jar:bin/../lib/ST4-4.0.8.jar:bin/../lib/airline-0.8.jar:bin/../lib/antlr-runtime-3.5.2.jar:bin/../lib/asm-7.1.jar:bin/../lib/caffeine-2.9.2.jar:bin...
> {noformat}
> notice that:
> - javadoc and sources jars are on the classpath
> - classpath is broken because javadoc, sources and main jar are separated by
> blankspaces instead of colons
> The problem is in {{cassandra.in.sh}} where the main jar gets added to the
> classpath:
> {noformat}
> cassandra_bin=`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar`
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17129) Classpath can be broken when multiple artifacts are present in build dir
Jacek Lewandowski created CASSANDRA-17129:
-
Summary: Classpath can be broken when multiple artifacts are
present in build dir
Key: CASSANDRA-17129
URL: https://issues.apache.org/jira/browse/CASSANDRA-17129
Project: Cassandra
Issue Type: Bug
Reporter: Jacek Lewandowski
{noformat}
$ ant artifacts
$ ls -1 build/apache-cassandra-*.jar
build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
build/apache-cassandra-4.1-SNAPSHOT-sources.jar
build/apache-cassandra-4.1-SNAPSHOT.jar
$ bin/cassandra -f
...
Error: Could not find or load main class
org.apache.cassandra.service.CassandraDaemon
{noformat}
Classpath is something like:
{noformat}
...bin/../conf:bin/../build/apache-cassandra-4.1-SNAPSHOT-javadoc.jar
bin/../build/apache-cassandra-4.1-SNAPSHOT-sources.jar
bin/../build/apache-cassandra-4.1-SNAPSHOT.jar:bin/../lib/HdrHistogram-2.1.9.jar:bin/../lib/ST4-4.0.8.jar:bin/../lib/airline-0.8.jar:bin/../lib/antlr-runtime-3.5.2.jar:bin/../lib/asm-7.1.jar:bin/../lib/caffeine-2.9.2.jar:bin...
{noformat}
notice that:
- javadoc and sources jars are on the classpath
- classpath is broken because javadoc, sources and main jar are separated by
blankspaces instead of colons
The problem is in {{cassandra.in.sh}} where the main jar gets added to the
classpath:
{noformat}
cassandra_bin=`ls -1 $CASSANDRA_HOME/build/apache-cassandra*.jar`
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17122) Add utilities for materialized views to CQLTester
[
https://issues.apache.org/jira/browse/CASSANDRA-17122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17122:
Fix Version/s: 4.x
> Add utilities for materialized views to CQLTester
> -
>
> Key: CASSANDRA-17122
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17122
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.x
>
>
> CASSANDRA-17070 added automatic generation of MV names to all
> {{ViewComplex*Test}} based on an incremented {{AtomicInteger}} to prevent
> conflicts when the cleanup methods leave a dirty environment. However, we
> still have ten MV tests that could benefit from this kind of name generation
> to avoid potential name conflicts.
> Also, the tests for materialized views have multiple code duplications. There
> are three identical implementations of the {{createView(String, String)}}
> method, eight lists of created views and six almost identical
> parameterizations of {{{}ProtocolVersion{}}}.
> I think we should add methods to create and drop MVs to {{{}CQLTester{}}},
> analogous to the methods that it already has for keyspaces, tables, indexes,
> functions and aggregates. That way we would prevent potential conflicts with
> MV names and reduce code duplication. These methods would also be useful for
> any new tests using MVs that we add in the future, such as for example the
> ones that we would probably need for any future guardrail on MVs.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17123: Status: Ready to Commit (was: Review In Progress) > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440942#comment-17440942 ] Berenguer Blasi commented on CASSANDRA-17123: - I can't find any usages of System.currentTimeMillis() except in the dtests repro where there is a legit usage to time stuff in a byteman. CI failures look aligned to current state of things. +1 > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17123: Reviewers: Berenguer Blasi Status: Review In Progress (was: Patch Available) > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17033) MessagingServiceTest listenOptionalSecureConnection and listenRequiredSecureConnection fail sporadically
[ https://issues.apache.org/jira/browse/CASSANDRA-17033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440880#comment-17440880 ] Caleb Rackliffe commented on CASSANDRA-17033: - +1 > MessagingServiceTest listenOptionalSecureConnection and > listenRequiredSecureConnection fail sporadically > > > Key: CASSANDRA-17033 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17033 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Caleb Rackliffe >Assignee: David Capwell >Priority: Normal > Labels: test-failure, test-failures > Fix For: 4.x > > > This popped up in a recent CircleCI run: > https://app.circleci.com/pipelines/github/maedhroz/cassandra/351/workflows/f8dbf599-df72-4982-8a12-a72a5b8ddd3b/jobs/2195 > I was able to reproduce it locally on trunk as well in a single run, although > it happens perhaps once per 3-4 runs of the MessagingServiceTest suite. It > looks like we open the sockets in an InboundSockets container, await on the > future that returns, and then assert that all those sockets are open. It’s > not clear to me yet why this assertion fails sporadically, or what state > changes exactly are racing. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17033) MessagingServiceTest listenOptionalSecureConnection and listenRequiredSecureConnection fail sporadically
[ https://issues.apache.org/jira/browse/CASSANDRA-17033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-17033: Reviewers: Caleb Rackliffe, Caleb Rackliffe (was: Caleb Rackliffe) Caleb Rackliffe, Caleb Rackliffe (was: Caleb Rackliffe) Status: Review In Progress (was: Patch Available) > MessagingServiceTest listenOptionalSecureConnection and > listenRequiredSecureConnection fail sporadically > > > Key: CASSANDRA-17033 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17033 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Caleb Rackliffe >Assignee: David Capwell >Priority: Normal > Labels: test-failure, test-failures > Fix For: 4.x > > > This popped up in a recent CircleCI run: > https://app.circleci.com/pipelines/github/maedhroz/cassandra/351/workflows/f8dbf599-df72-4982-8a12-a72a5b8ddd3b/jobs/2195 > I was able to reproduce it locally on trunk as well in a single run, although > it happens perhaps once per 3-4 runs of the MessagingServiceTest suite. It > looks like we open the sockets in an InboundSockets container, await on the > future that returns, and then assert that all those sockets are open. It’s > not clear to me yet why this assertion fails sporadically, or what state > changes exactly are racing. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17128) JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only
[ https://issues.apache.org/jira/browse/CASSANDRA-17128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17128: -- Fix Version/s: 4.1 (was: 4.x) Source Control Link: https://github.com/apache/cassandra/commit/8b11a22ce7011e98dd385b2cef793e5bd2f75c11 Resolution: Fixed Status: Resolved (was: Ready to Commit) > JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs > rather than only supporting direct only > > > Key: CASSANDRA-17128 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17128 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.1 > > > When an OOM is thrown we do normally want the JVM to halt (assuming JVM flags > state to), but this only happens in very specific cases (see CASSANDRA-15214 > for more details). Rather than relying on an allow list to convert to > heap-oom, we should rely on an deny list; this way we handle every OOM thrown. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new b29e103 JVMStabilityInspector.forceHeapSpaceOomMaybe should handle
all non-heap OOMs rather than only supporting direct only
b29e103 is described below
commit b29e1037e4da75dfd2a30ad10f8008b24941e37f
Author: David Capwell
AuthorDate: Mon Nov 8 16:03:06 2021 -0800
JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap
OOMs rather than only supporting direct only
patch by David Capwell; reviewed by Caleb Rackliffe, Yifan Cai for
CASSANDRA-17128
---
CHANGES.txt| 1 +
checkstyle.xml | 2 +-
src/java/org/apache/cassandra/io/util/Memory.java | 2 +-
.../cassandra/utils/JVMStabilityInspector.java | 33 ++
.../cassandra/utils/JVMStabilityInspectorTest.java | 10 +++
5 files changed, 28 insertions(+), 20 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index a0a1a04..6ca209e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.1
+ * JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap
OOMs rather than only supporting direct only (CASSANDRA-17128)
* Forbid other Future implementations with checkstyle (CASSANDRA-17055)
* commit log was switched from non-daemon to daemon threads, which causes the
JVM to exit in some case as no non-daemon threads are active (CASSANDRA-17085)
* Add a Denylist to block reads and writes on specific partition keys
(CASSANDRA-12106)
diff --git a/checkstyle.xml b/checkstyle.xml
index 0c92167..4bc31dd 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -65,7 +65,7 @@
-
+
diff --git a/src/java/org/apache/cassandra/io/util/Memory.java
b/src/java/org/apache/cassandra/io/util/Memory.java
index c55f047..7fd4225 100644
--- a/src/java/org/apache/cassandra/io/util/Memory.java
+++ b/src/java/org/apache/cassandra/io/util/Memory.java
@@ -68,7 +68,7 @@ public class Memory implements AutoCloseable, ReadableMemory
// we permit a 0 peer iff size is zero, since such an allocation makes
no sense, and an allocator would be
// justified in returning a null pointer (and permitted to do so:
http://www.cplusplus.com/reference/cstdlib/malloc)
if (peer == 0)
-throw new OutOfMemoryError();
+throw new OutOfMemoryError(); // checkstyle: permit this
instantiation
}
// create a memory object that references the exacy same memory location
as the one provided.
diff --git a/src/java/org/apache/cassandra/utils/JVMStabilityInspector.java
b/src/java/org/apache/cassandra/utils/JVMStabilityInspector.java
index 6470f1f..f8acb22 100644
--- a/src/java/org/apache/cassandra/utils/JVMStabilityInspector.java
+++ b/src/java/org/apache/cassandra/utils/JVMStabilityInspector.java
@@ -21,13 +21,14 @@ import java.io.FileNotFoundException;
import java.net.SocketException;
import java.nio.file.FileSystemException;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.List;
+import java.util.Set;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.Consumer;
import com.google.common.annotations.VisibleForTesting;
+import com.google.common.collect.ImmutableSet;
import org.apache.cassandra.exceptions.UnrecoverableIllegalStateException;
import org.apache.cassandra.metrics.StorageMetrics;
@@ -153,31 +154,27 @@ public final class JVMStabilityInspector
inspectThrowable(t.getCause(), fn);
}
+private static final Set FORCE_HEAP_OOM_IGNORE_SET =
ImmutableSet.of("Java heap space", "GC Overhead limit exceeded");
+
/**
- * Intentionally produce a heap space OOM upon seeing a Direct buffer
memory OOM.
+ * Intentionally produce a heap space OOM upon seeing a non heap memory
OOM.
* Direct buffer OOM cannot trigger JVM OOM error related options,
* e.g. OnOutOfMemoryError, HeapDumpOnOutOfMemoryError, etc.
- * See CASSANDRA-15214 for more details
+ * See CASSANDRA-15214 and CASSANDRA-17128 for more details
*/
@Exclude // Exclude from just in time compilation.
private static void forceHeapSpaceOomMaybe(OutOfMemoryError oom)
{
-// See the oom thrown from java.nio.Bits.reserveMemory.
-// In jdk 13 and up, the message is "Cannot reserve XX bytes of direct
buffer memory (...)"
-// In jdk 11 and below, the message is "Direct buffer memory"
-if ((oom.getMessage() != null &&
oom.getMessage().toLowerCase().contains("direct buffer memory")) ||
-Arrays.stream(oom.getStackTrace()).anyMatch(x ->
x.getClassName().equals("java.nio.Bits")
- &&
[jira] [Updated] (CASSANDRA-17066) Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra"
[
https://issues.apache.org/jira/browse/CASSANDRA-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Ramirez updated CASSANDRA-17066:
--
Status: Changes Suggested (was: Review In Progress)
I've posted some feedback on PR #80 including:
* updating the commit to {{blog.adoc}} so only 17 lines are updated instead of
1,572
* update the author to [~ifesdjeen]
* cleanup the link to {{CASSANDRA-16453}}
* update formatting to multiple code sections
For what it's worth, here's how the pages render on the site:
!c17066-01-blog-index.png|width=300!
!c17066-02-blog-post.png|width=300!
> Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra"
>
>
> Key: CASSANDRA-17066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17066
> Project: Cassandra
> Issue Type: Task
> Components: Documentation/Blog
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0.2, 4.1
>
> Attachments: c17066-01-blog-index.png, c17066-02-blog-post.png
>
>
> This ticket is to capture the work associated with publishing the November
> 2021 blog post titled "Harry, an Open Source Fuzz Testing and Verification
> Tool for Apache Cassandra."
> If this blog cannot be published by the November 9 publish date, please be
> sure to *correct the date* before going live.
> This ticket can be closed once the blog post has gone live on the website.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17066) Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra"
[ https://issues.apache.org/jira/browse/CASSANDRA-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17066: -- Attachment: c17066-01-blog-index.png > Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra" > > > Key: CASSANDRA-17066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17066 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.2, 4.1 > > Attachments: c17066-01-blog-index.png, c17066-02-blog-post.png > > > This ticket is to capture the work associated with publishing the November > 2021 blog post titled "Harry, an Open Source Fuzz Testing and Verification > Tool for Apache Cassandra." > If this blog cannot be published by the November 9 publish date, please be > sure to *correct the date* before going live. > This ticket can be closed once the blog post has gone live on the website. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17066) Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra"
[ https://issues.apache.org/jira/browse/CASSANDRA-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17066: -- Attachment: c17066-02-blog-post.png > Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra" > > > Key: CASSANDRA-17066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17066 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.2, 4.1 > > Attachments: c17066-01-blog-index.png, c17066-02-blog-post.png > > > This ticket is to capture the work associated with publishing the November > 2021 blog post titled "Harry, an Open Source Fuzz Testing and Verification > Tool for Apache Cassandra." > If this blog cannot be published by the November 9 publish date, please be > sure to *correct the date* before going live. > This ticket can be closed once the blog post has gone live on the website. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17128) JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only
[ https://issues.apache.org/jira/browse/CASSANDRA-17128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440824#comment-17440824 ] David Capwell commented on CASSANDRA-17128: --- Starting commit CI Results (pending): ||Branch||Source||Circle CI||Jenkins|| |trunk|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-17128-trunk-10695C9A-5B8C-433B-AE90-5BB265E5704C]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-17128-trunk-10695C9A-5B8C-433B-AE90-5BB265E5704C]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1269/]| > JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs > rather than only supporting direct only > > > Key: CASSANDRA-17128 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17128 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > When an OOM is thrown we do normally want the JVM to halt (assuming JVM flags > state to), but this only happens in very specific cases (see CASSANDRA-15214 > for more details). Rather than relying on an allow list to convert to > heap-oom, we should rely on an deny list; this way we handle every OOM thrown. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17128) JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only
[ https://issues.apache.org/jira/browse/CASSANDRA-17128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17128: -- Status: Ready to Commit (was: Review In Progress) > JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs > rather than only supporting direct only > > > Key: CASSANDRA-17128 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17128 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > When an OOM is thrown we do normally want the JVM to halt (assuming JVM flags > state to), but this only happens in very specific cases (see CASSANDRA-15214 > for more details). Rather than relying on an allow list to convert to > heap-oom, we should rely on an deny list; this way we handle every OOM thrown. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17128) JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only
[ https://issues.apache.org/jira/browse/CASSANDRA-17128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440821#comment-17440821 ] David Capwell commented on CASSANDRA-17128: --- [~maedhroz] +1ed in PR > JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs > rather than only supporting direct only > > > Key: CASSANDRA-17128 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17128 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > When an OOM is thrown we do normally want the JVM to halt (assuming JVM flags > state to), but this only happens in very specific cases (see CASSANDRA-15214 > for more details). Rather than relying on an allow list to convert to > heap-oom, we should rely on an deny list; this way we handle every OOM thrown. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17066) Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra"
[ https://issues.apache.org/jira/browse/CASSANDRA-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17066: -- Status: Patch Available (was: In Progress) > Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra" > > > Key: CASSANDRA-17066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17066 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.2, 4.1 > > > This ticket is to capture the work associated with publishing the November > 2021 blog post titled "Harry, an Open Source Fuzz Testing and Verification > Tool for Apache Cassandra." > If this blog cannot be published by the November 9 publish date, please be > sure to *correct the date* before going live. > This ticket can be closed once the blog post has gone live on the website. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17066) Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra"
[ https://issues.apache.org/jira/browse/CASSANDRA-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17066: -- Status: Review In Progress (was: Patch Available) > Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra" > > > Key: CASSANDRA-17066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17066 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.2, 4.1 > > > This ticket is to capture the work associated with publishing the November > 2021 blog post titled "Harry, an Open Source Fuzz Testing and Verification > Tool for Apache Cassandra." > If this blog cannot be published by the November 9 publish date, please be > sure to *correct the date* before going live. > This ticket can be closed once the blog post has gone live on the website. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17033) MessagingServiceTest listenOptionalSecureConnection and listenRequiredSecureConnection fail sporadically
[ https://issues.apache.org/jira/browse/CASSANDRA-17033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440818#comment-17440818 ] David Capwell commented on CASSANDRA-17033: --- the issue was that the future returned from open would return and call a callback async; this callback sets the state that isOpen depends on (causing the flaky behavior). The patch fixes this so that all state is updated before the future open returns gets completed. > MessagingServiceTest listenOptionalSecureConnection and > listenRequiredSecureConnection fail sporadically > > > Key: CASSANDRA-17033 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17033 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Caleb Rackliffe >Assignee: David Capwell >Priority: Normal > Labels: test-failure, test-failures > Fix For: 4.x > > > This popped up in a recent CircleCI run: > https://app.circleci.com/pipelines/github/maedhroz/cassandra/351/workflows/f8dbf599-df72-4982-8a12-a72a5b8ddd3b/jobs/2195 > I was able to reproduce it locally on trunk as well in a single run, although > it happens perhaps once per 3-4 runs of the MessagingServiceTest suite. It > looks like we open the sockets in an InboundSockets container, await on the > future that returns, and then assert that all those sockets are open. It’s > not clear to me yet why this assertion fails sporadically, or what state > changes exactly are racing. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17033) MessagingServiceTest listenOptionalSecureConnection and listenRequiredSecureConnection fail sporadically
[ https://issues.apache.org/jira/browse/CASSANDRA-17033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17033: -- Test and Documentation Plan: tests Status: Patch Available (was: In Progress) > MessagingServiceTest listenOptionalSecureConnection and > listenRequiredSecureConnection fail sporadically > > > Key: CASSANDRA-17033 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17033 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Caleb Rackliffe >Assignee: David Capwell >Priority: Normal > Labels: test-failure, test-failures > Fix For: 4.x > > > This popped up in a recent CircleCI run: > https://app.circleci.com/pipelines/github/maedhroz/cassandra/351/workflows/f8dbf599-df72-4982-8a12-a72a5b8ddd3b/jobs/2195 > I was able to reproduce it locally on trunk as well in a single run, although > it happens perhaps once per 3-4 runs of the MessagingServiceTest suite. It > looks like we open the sockets in an InboundSockets container, await on the > future that returns, and then assert that all those sockets are open. It’s > not clear to me yet why this assertion fails sporadically, or what state > changes exactly are racing. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17128) JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only
[ https://issues.apache.org/jira/browse/CASSANDRA-17128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-17128: -- Reviewers: Caleb Rackliffe, Yifan Cai Status: Review In Progress (was: Patch Available) +1 > JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs > rather than only supporting direct only > > > Key: CASSANDRA-17128 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17128 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > When an OOM is thrown we do normally want the JVM to halt (assuming JVM flags > state to), but this only happens in very specific cases (see CASSANDRA-15214 > for more details). Rather than relying on an allow list to convert to > heap-oom, we should rely on an deny list; this way we handle every OOM thrown. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17066) Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra"
[ https://issues.apache.org/jira/browse/CASSANDRA-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-17066: -- Source Control Link: (was: https://github.com/apache/cassandra-website/pull/80/commits/0258232ad35998be646ab6163ed30e8c3f91b5fe) > Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra" > > > Key: CASSANDRA-17066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17066 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.2, 4.1 > > > This ticket is to capture the work associated with publishing the November > 2021 blog post titled "Harry, an Open Source Fuzz Testing and Verification > Tool for Apache Cassandra." > If this blog cannot be published by the November 9 publish date, please be > sure to *correct the date* before going live. > This ticket can be closed once the blog post has gone live on the website. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17128) JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only
[ https://issues.apache.org/jira/browse/CASSANDRA-17128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17128: -- Test and Documentation Plan: tests Status: Patch Available (was: Open) > JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs > rather than only supporting direct only > > > Key: CASSANDRA-17128 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17128 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > When an OOM is thrown we do normally want the JVM to halt (assuming JVM flags > state to), but this only happens in very specific cases (see CASSANDRA-15214 > for more details). Rather than relying on an allow list to convert to > heap-oom, we should rely on an deny list; this way we handle every OOM thrown. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17128) JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only
[ https://issues.apache.org/jira/browse/CASSANDRA-17128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17128: -- Change Category: Operability Complexity: Low Hanging Fruit Component/s: Local/Other Fix Version/s: 4.x Status: Open (was: Triage Needed) > JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs > rather than only supporting direct only > > > Key: CASSANDRA-17128 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17128 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > When an OOM is thrown we do normally want the JVM to halt (assuming JVM flags > state to), but this only happens in very specific cases (see CASSANDRA-15214 > for more details). Rather than relying on an allow list to convert to > heap-oom, we should rely on an deny list; this way we handle every OOM thrown. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17128) JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only
David Capwell created CASSANDRA-17128: - Summary: JVMStabilityInspector.forceHeapSpaceOomMaybe should handle all non-heap OOMs rather than only supporting direct only Key: CASSANDRA-17128 URL: https://issues.apache.org/jira/browse/CASSANDRA-17128 Project: Cassandra Issue Type: Improvement Reporter: David Capwell Assignee: David Capwell When an OOM is thrown we do normally want the JVM to halt (assuming JVM flags state to), but this only happens in very specific cases (see CASSANDRA-15214 for more details). Rather than relying on an allow list to convert to heap-oom, we should rely on an deny list; this way we handle every OOM thrown. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15215) VIntCoding should read and write more efficiently
[
https://issues.apache.org/jira/browse/CASSANDRA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440803#comment-17440803
]
Benedict Elliott Smith commented on CASSANDRA-15215:
This is great, thanks [~Ge]! Looks like pretty significant improvements for
such common code paths. I'll be very interested to see how the register
approach compares, both for {{ByteBuffer}} and {{DataOutputPlus}}.
> VIntCoding should read and write more efficiently
> -
>
> Key: CASSANDRA-15215
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15215
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction, Local/SSTable
>Reporter: Benedict Elliott Smith
>Assignee: Aleksandr Sorokoumov
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Most vints occupy significantly fewer than 8 bytes, and most buffers have >=
> 8 bytes spare, in which case we can construct the relevant bytes in a
> register and memcpy them to the correct position. Since we read and write a
> lot of vints, this waste is probably measurable, particularly during
> compaction and flush, and can probably be considered a performance bug.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17121) Allow column_index_size_in_kb to be configurable through nodetool
[ https://issues.apache.org/jira/browse/CASSANDRA-17121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRA-17121: --- Status: In Progress (was: Patch Available) > Allow column_index_size_in_kb to be configurable through nodetool > - > > Key: CASSANDRA-17121 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17121 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > > Configuring the column_index_size_in_kb setting requires a cassandra.yaml > change and bouncing the instance. > Allowing column_index_size_in_kb to be configurable through nodetool can help > in the operational landscape. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17124) Enable checkstyle on tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440762#comment-17440762 ] Ekaterina Dimitrova commented on CASSANDRA-17124: - The checkstyle looks good to me but I guess we will commit it when the subtasks are handled too. :) > Enable checkstyle on tests > -- > > Key: CASSANDRA-17124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17124 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.x > > > Currently, checkstyle only runs against the source, leaving the tests with > violations. This ticket is to clean up the test code so checkstyle can be > run against it at build time. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17124) Enable checkstyle on tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440756#comment-17440756 ] Brandon Williams commented on CASSANDRA-17124: -- Here's a branch that enables checkstyle on the test dir. Applying this without failures is how success of this ticket can be measured. > Enable checkstyle on tests > -- > > Key: CASSANDRA-17124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17124 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.x > > > Currently, checkstyle only runs against the source, leaving the tests with > violations. This ticket is to clean up the test code so checkstyle can be > run against it at build time. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440753#comment-17440753 ] Brandon Williams commented on CASSANDRA-17123: -- I don't think merge conflicts should be too bad for the tests, especially if we do it in chunks - I've created CASSANDRA-17124 and its subtasks to that end. > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17127) Remove use of deprecated java.util.concurrent in tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17127:
-
Change Category: Code Clarity
Complexity: Normal
Component/s: Test/unit
Status: Open (was: Triage Needed)
> Remove use of deprecated java.util.concurrent in tests
> --
>
> Key: CASSANDRA-17127
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17127
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/unit
>Reporter: Brandon Williams
>Priority: Normal
>
> {noformat}
> 1 Illegal import - java.util.concurrent.ArrayBlockingQueue.
> [IllegalImport]
> 11 Illegal import - java.util.concurrent.CompletableFuture.
> [IllegalImport]
> 39 Illegal import - java.util.concurrent.CountDownLatch. [IllegalImport]
> 48 Illegal import - java.util.concurrent.Executors. [IllegalImport]
> 3 Illegal import - java.util.concurrent.LinkedBlockingQueue.
> [IllegalImport]
> 5 Illegal import - java.util.concurrent.Semaphore. [IllegalImport]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17126) Remove use of deprecated Files in tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17126:
-
Change Category: Code Clarity
Complexity: Normal
Component/s: Test/unit
Status: Open (was: Triage Needed)
> Remove use of deprecated Files in tests
> ---
>
> Key: CASSANDRA-17126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17126
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/unit
>Reporter: Brandon Williams
>Priority: Normal
>
> From checkstyle:
> {noformat}
> 5 Illegal import - java.io.File. [IllegalImport]
> 3 Illegal import - java.io.FileInputStream. [IllegalImport]
> 2 Illegal import - java.io.FileOutputStream. [IllegalImport]
> 3 Illegal import - java.io.FileWriter. [IllegalImport]
> 16 Illegal import - java.io.RandomAccessFile. [IllegalImport]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17125) Remove use of deprecated Futures in tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17125:
-
Change Category: Code Clarity
Complexity: Normal
Component/s: Test/unit
Status: Open (was: Triage Needed)
> Remove use of deprecated Futures in tests
> -
>
> Key: CASSANDRA-17125
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17125
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/unit
>Reporter: Brandon Williams
>Priority: Normal
>
> To pass checkstyle:
> {noformat}
> Illegal import - com.google.common.util.concurrent.AbstractFuture.
> [IllegalImport]
> Illegal import - com.google.common.util.concurrent.Futures.
> [IllegalImport]
> Illegal import - com.google.common.util.concurrent.ListenableFuture.
> [IllegalImport]
> Illegal import - com.google.common.util.concurrent.ListenableFutureTask.
> [IllegalImport]
> Illegal import - io.netty.util.concurrent.Future. [IllegalImport]
> Illegal import - io.netty.util.concurrent.Promise. [IllegalImport]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17127) Remove use of deprecated java.util.concurrent in tests
Brandon Williams created CASSANDRA-17127:
Summary: Remove use of deprecated java.util.concurrent in tests
Key: CASSANDRA-17127
URL: https://issues.apache.org/jira/browse/CASSANDRA-17127
Project: Cassandra
Issue Type: Sub-task
Reporter: Brandon Williams
{noformat}
1 Illegal import - java.util.concurrent.ArrayBlockingQueue.
[IllegalImport]
11 Illegal import - java.util.concurrent.CompletableFuture.
[IllegalImport]
39 Illegal import - java.util.concurrent.CountDownLatch. [IllegalImport]
48 Illegal import - java.util.concurrent.Executors. [IllegalImport]
3 Illegal import - java.util.concurrent.LinkedBlockingQueue.
[IllegalImport]
5 Illegal import - java.util.concurrent.Semaphore. [IllegalImport]
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17126) Remove use of deprecated Files in tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17126:
-
Parent: CASSANDRA-17124
Issue Type: Sub-task (was: Task)
> Remove use of deprecated Files in tests
> ---
>
> Key: CASSANDRA-17126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17126
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Brandon Williams
>Priority: Normal
>
> From checkstyle:
> {noformat}
> 5 Illegal import - java.io.File. [IllegalImport]
> 3 Illegal import - java.io.FileInputStream. [IllegalImport]
> 2 Illegal import - java.io.FileOutputStream. [IllegalImport]
> 3 Illegal import - java.io.FileWriter. [IllegalImport]
> 16 Illegal import - java.io.RandomAccessFile. [IllegalImport]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17126) Remove use of deprecated Files in tests
Brandon Williams created CASSANDRA-17126:
Summary: Remove use of deprecated Files in tests
Key: CASSANDRA-17126
URL: https://issues.apache.org/jira/browse/CASSANDRA-17126
Project: Cassandra
Issue Type: Task
Reporter: Brandon Williams
>From checkstyle:
{noformat}
5 Illegal import - java.io.File. [IllegalImport]
3 Illegal import - java.io.FileInputStream. [IllegalImport]
2 Illegal import - java.io.FileOutputStream. [IllegalImport]
3 Illegal import - java.io.FileWriter. [IllegalImport]
16 Illegal import - java.io.RandomAccessFile. [IllegalImport]
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17125) Remove use of deprecated Futures in tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17125:
-
Parent: CASSANDRA-17124
Issue Type: Sub-task (was: Task)
> Remove use of deprecated Futures in tests
> -
>
> Key: CASSANDRA-17125
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17125
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Brandon Williams
>Priority: Normal
>
> To pass checkstyle:
> {noformat}
> Illegal import - com.google.common.util.concurrent.AbstractFuture.
> [IllegalImport]
> Illegal import - com.google.common.util.concurrent.Futures.
> [IllegalImport]
> Illegal import - com.google.common.util.concurrent.ListenableFuture.
> [IllegalImport]
> Illegal import - com.google.common.util.concurrent.ListenableFutureTask.
> [IllegalImport]
> Illegal import - io.netty.util.concurrent.Future. [IllegalImport]
> Illegal import - io.netty.util.concurrent.Promise. [IllegalImport]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17125) Remove use of deprecated Futures in tests
Brandon Williams created CASSANDRA-17125:
Summary: Remove use of deprecated Futures in tests
Key: CASSANDRA-17125
URL: https://issues.apache.org/jira/browse/CASSANDRA-17125
Project: Cassandra
Issue Type: Task
Reporter: Brandon Williams
To pass checkstyle:
{noformat}
Illegal import - com.google.common.util.concurrent.AbstractFuture.
[IllegalImport]
Illegal import - com.google.common.util.concurrent.Futures. [IllegalImport]
Illegal import - com.google.common.util.concurrent.ListenableFuture.
[IllegalImport]
Illegal import - com.google.common.util.concurrent.ListenableFutureTask.
[IllegalImport]
Illegal import - io.netty.util.concurrent.Future. [IllegalImport]
Illegal import - io.netty.util.concurrent.Promise. [IllegalImport]
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-6246) EPaxos
[ https://issues.apache.org/jira/browse/CASSANDRA-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-6246: --- Fix Version/s: (was: 4.x) > EPaxos > -- > > Key: CASSANDRA-6246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6246 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Lightweight Transactions, Legacy/Coordination >Reporter: Jonathan Ellis >Assignee: Blake Eggleston >Priority: Normal > Labels: LWT, messaging-service-bump-required > > One reason we haven't optimized our Paxos implementation with Multi-paxos is > that Multi-paxos requires leader election and hence, a period of > unavailability when the leader dies. > EPaxos is a Paxos variant that requires (1) less messages than multi-paxos, > (2) is particularly useful across multiple datacenters, and (3) allows any > node to act as coordinator: > http://sigops.org/sosp/sosp13/papers/p358-moraru.pdf > However, there is substantial additional complexity involved if we choose to > implement it. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-6246) EPaxos
[ https://issues.apache.org/jira/browse/CASSANDRA-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-6246: --- Resolution: Duplicate Status: Resolved (was: Open) Closing as duplicate since this will be superseded by accord (CASSANDRA-17090) > EPaxos > -- > > Key: CASSANDRA-6246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6246 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Lightweight Transactions, Legacy/Coordination >Reporter: Jonathan Ellis >Assignee: Blake Eggleston >Priority: Normal > Labels: LWT, messaging-service-bump-required > Fix For: 4.x > > > One reason we haven't optimized our Paxos implementation with Multi-paxos is > that Multi-paxos requires leader election and hence, a period of > unavailability when the leader dies. > EPaxos is a Paxos variant that requires (1) less messages than multi-paxos, > (2) is particularly useful across multiple datacenters, and (3) allows any > node to act as coordinator: > http://sigops.org/sosp/sosp13/papers/p358-moraru.pdf > However, there is substantial additional complexity involved if we choose to > implement it. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17124) Enable checkstyle on tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17124: - Change Category: Code Clarity Complexity: Normal Component/s: Test/unit Fix Version/s: 4.x Status: Open (was: Triage Needed) > Enable checkstyle on tests > -- > > Key: CASSANDRA-17124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17124 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.x > > > Currently, checkstyle only runs against the source, leaving the tests with > violations. This ticket is to clean up the test code so checkstyle can be > run against it at build time. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17124) Enable checkstyle on tests
Brandon Williams created CASSANDRA-17124: Summary: Enable checkstyle on tests Key: CASSANDRA-17124 URL: https://issues.apache.org/jira/browse/CASSANDRA-17124 Project: Cassandra Issue Type: Task Reporter: Brandon Williams Currently, checkstyle only runs against the source, leaving the tests with violations. This ticket is to clean up the test code so checkstyle can be run against it at build time. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17121) Allow column_index_size_in_kb to be configurable through nodetool
[ https://issues.apache.org/jira/browse/CASSANDRA-17121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRA-17121: --- Test and Documentation Plan: Added tests for the new nodetool commands to support this feature. PR and CI links added in the comments. Status: Patch Available (was: Open) > Allow column_index_size_in_kb to be configurable through nodetool > - > > Key: CASSANDRA-17121 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17121 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > > Configuring the column_index_size_in_kb setting requires a cassandra.yaml > change and bouncing the instance. > Allowing column_index_size_in_kb to be configurable through nodetool can help > in the operational landscape. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17121) Allow column_index_size_in_kb to be configurable through nodetool
[ https://issues.apache.org/jira/browse/CASSANDRA-17121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRA-17121: --- Status: Open (was: Triage Needed) > Allow column_index_size_in_kb to be configurable through nodetool > - > > Key: CASSANDRA-17121 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17121 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > > Configuring the column_index_size_in_kb setting requires a cassandra.yaml > change and bouncing the instance. > Allowing column_index_size_in_kb to be configurable through nodetool can help > in the operational landscape. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440732#comment-17440732 ] Benedict Elliott Smith commented on CASSANDRA-17123: I left out the tests because of how painful they are in general, and how upsetting merge conflicts can be to deal with for others. But if you're willing to be the bad guy there's no reason it can't be set to work on the test dir too... :) > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440644#comment-17440644 ] Brandon Williams commented on CASSANDRA-17123: -- I was going to add a commit that added checkstyle to the test dir, but even after this patch there are 700+ violations so I think we'll need to take a more incremental approach. > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17123: - Test and Documentation Plan: run CI Status: Patch Available (was: Open) > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17065) Introduce separate rate limiting settings for entire SSTable streaming
[ https://issues.apache.org/jira/browse/CASSANDRA-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440627#comment-17440627 ] Francisco Guerrero commented on CASSANDRA-17065: Thanks for looking at it. I am running CI tests now > Introduce separate rate limiting settings for entire SSTable streaming > -- > > Key: CASSANDRA-17065 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17065 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode, Tool/nodetool >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > With the introduction of entire SSTable streaming, it is desirable to > introduce new settings for the rate limit for entire SSTable streaming > operations. > Currently, regular streaming and SSTable streaming are rate limited by the > same setting. However, zero-copy streaming reduces load in the JVM and we can > have a setting specifically for this use case. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440621#comment-17440621 ] Ekaterina Dimitrova commented on CASSANDRA-17123: - I was about to ask... doesn't the checkstyle.xml work also with the tests? I guess we should verify that too. CC [~benedict], [~dcapwell] as I see you were working on the checkstyle.xml lately so I guess you will know better than me. :-) > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440607#comment-17440607
]
Ekaterina Dimitrova commented on CASSANDRA-17120:
-
{quote}I noticed the same, but there are over 300 instances, so I made
CASSANDRA-17123 for that.
{quote}
Thanks!
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-17123: Assignee: Brandon Williams > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17123) Remove use of System.currentTimeMillis
[ https://issues.apache.org/jira/browse/CASSANDRA-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17123: - Change Category: Code Clarity Complexity: Normal Component/s: Test/unit Fix Version/s: 4.x Status: Open (was: Triage Needed) > Remove use of System.currentTimeMillis > -- > > Key: CASSANDRA-17123 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.x > > > CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we > still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17120:
-
Fix Version/s: 4.1
(was: 4.x)
Since Version: NA
Source Control Link:
https://github.com/apache/cassandra/commit/d37e256f2ed0105f65ce1753765d3a712be45032
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed.
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17120:
-
Status: Ready to Commit (was: Review In Progress)
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.x
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Use correct clock source in TimestampSerializerTest
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new d37e256f Use correct clock source in TimestampSerializerTest
d37e256f is described below
commit d37e256f2ed0105f65ce1753765d3a712be45032
Author: Brandon Williams
AuthorDate: Mon Nov 8 09:56:12 2021 -0600
Use correct clock source in TimestampSerializerTest
Patch by brandonwilliams; reviewed by edimitrova for CASSANDRA-17120
---
.../org/apache/cassandra/serializers/TimestampSerializerTest.java | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
a/test/unit/org/apache/cassandra/serializers/TimestampSerializerTest.java
b/test/unit/org/apache/cassandra/serializers/TimestampSerializerTest.java
index e9ae266..64a1b11 100644
--- a/test/unit/org/apache/cassandra/serializers/TimestampSerializerTest.java
+++ b/test/unit/org/apache/cassandra/serializers/TimestampSerializerTest.java
@@ -26,6 +26,8 @@ import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
+import static org.apache.cassandra.utils.Clock.Global.currentTimeMillis;
+
public class TimestampSerializerTest
{
public static final long ONE_SECOND = 1000L;
@@ -196,7 +198,7 @@ public class TimestampSerializerTest
public void testNumeric()
{
// now (positive
-final long now = System.currentTimeMillis();
+final long now = currentTimeMillis();
assertEquals(now,
TimestampSerializer.dateStringToTimestamp(Long.toString(now)));
// negative
@@ -222,7 +224,7 @@ public class TimestampSerializerTest
public void testNow()
{
final long threshold = 5;
-final long now = System.currentTimeMillis();
+final long now = currentTimeMillis();
final long parsed = TimestampSerializer.dateStringToTimestamp("now");
assertTrue("'now' timestamp not within expected tolerance.", now <=
parsed && parsed <= now + threshold);
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440599#comment-17440599
]
Brandon Williams commented on CASSANDRA-17120:
--
bq. Not sure whether we want to address this as part of this ticket or another
one.
I noticed the same, but there are over 300 instances, so I made
CASSANDRA-17123 for that.
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.x
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17123) Remove use of System.currentTimeMillis
Brandon Williams created CASSANDRA-17123: Summary: Remove use of System.currentTimeMillis Key: CASSANDRA-17123 URL: https://issues.apache.org/jira/browse/CASSANDRA-17123 Project: Cassandra Issue Type: Task Reporter: Brandon Williams CASSANDRA-16925 changed this and checkstyle.xml forbids the usage, but we still have over 300 instances of it in the tests. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-17120:
Reviewers: Ekaterina Dimitrova, Ekaterina Dimitrova
Ekaterina Dimitrova, Ekaterina Dimitrova (was: Ekaterina
Dimitrova)
Status: Review In Progress (was: Patch Available)
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.x
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440581#comment-17440581
]
Ekaterina Dimitrova commented on CASSANDRA-17120:
-
+1 on this patch. Just wanted to mention that quick grep showed me we might
have similar issue with other unit tests too. (even if they are not failing)
Not sure whether we want to address this as part of this ticket or another one.
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.x
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17120:
-
Test and Documentation Plan: run CI
Status: Patch Available (was: Open)
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.x
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440579#comment-17440579
]
Brandon Williams commented on CASSANDRA-17120:
--
Linked a branch and 100 repeated runs in Circle.
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.x
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-17120:
Assignee: Brandon Williams
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.x
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17119) Broken test_speculative_data_request
[
https://issues.apache.org/jira/browse/CASSANDRA-17119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440561#comment-17440561
]
Brandon Williams commented on CASSANDRA-17119:
--
Maybe we should go ahead and create a 'post-4.0' or similar directory under
byteman as we do for pre-4.0 and 4.0. Patch and CI lgtm to me though, +1.
> Broken test_speculative_data_request
>
>
> Key: CASSANDRA-17119
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17119
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> This has been failing consistently lately
> {noformat}
> Error Message
> KeyError: '127.0.0.3'
> Stacktrace
> self =
> @since('4.0')
> def test_speculative_data_request(self):
> """ If one node doesn't respond to a full data request, it should
> query the other """
> node1, node2, node3 = self.cluster.nodelist()
> assert isinstance(node1, Node)
> assert isinstance(node2, Node)
> assert isinstance(node3, Node)
> session = self.get_cql_connection(node1, timeout=2)
>
> session.execute(quorum("INSERT INTO ks.tbl (k, c, v) VALUES (1, 0,
> 1)"))
>
> node2.byteman_submit(['./byteman/read_repair/stop_writes.btm'])
> node3.byteman_submit(['./byteman/read_repair/stop_writes.btm'])
>
> session.execute("INSERT INTO ks.tbl (k, c, v) VALUES (1, 1, 2)")
>
> # re-enable writes
> node2.byteman_submit(['-u', './byteman/read_repair/stop_writes.btm'])
>
>
> node1.byteman_submit(['./byteman/read_repair/sorted_live_endpoints.btm'])
> node1.byteman_submit(['./byteman/request_verb_timing.btm'])
>
> with StorageProxy(node1) as storage_proxy:
> assert storage_proxy.blocking_read_repair == 0
> assert storage_proxy.speculated_rr_read == 0
> assert storage_proxy.speculated_rr_write == 0
>
> session = self.get_cql_connection(node1)
>
> node2.byteman_submit(['./byteman/read_repair/stop_data_reads.btm'])
> results = session.execute(quorum("SELECT * FROM ks.tbl WHERE
> k=1"))
>
> timing = request_verb_timing(node1)
> > repair_req_node3 = timing[node3.ip_addr].get('READ_REPAIR_REQ')
> E KeyError: '127.0.0.3'
> read_repair_test.py:621: KeyError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17052) Queries performed with NODE_LOCAL consistency level do not update request metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-17052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-17052:
Status: Ready to Commit (was: Review In Progress)
+1; minor comments on the patch
> Queries performed with NODE_LOCAL consistency level do not update request
> metrics
> -
>
> Key: CASSANDRA-17052
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17052
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Currently, queries performed with {{NODE_LOCAL}} consistency level are not
> reflected in request metrics. The suggested patch addresses that, and also
> allows modification and batch statements to be used with {{NODE_LOCAL}}
> consistency level.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17052) Queries performed with NODE_LOCAL consistency level do not update request metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-17052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-17052:
Reviewers: Alex Petrov, Alex Petrov (was: Alex Petrov)
Alex Petrov, Alex Petrov (was: Alex Petrov)
Status: Review In Progress (was: Patch Available)
> Queries performed with NODE_LOCAL consistency level do not update request
> metrics
> -
>
> Key: CASSANDRA-17052
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17052
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Currently, queries performed with {{NODE_LOCAL}} consistency level are not
> reflected in request metrics. The suggested patch addresses that, and also
> allows modification and batch statements to be used with {{NODE_LOCAL}}
> consistency level.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17044) Refactor schema management to allow for schema source pluggability
[ https://issues.apache.org/jira/browse/CASSANDRA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440533#comment-17440533 ] Alex Petrov commented on CASSANDRA-17044: - [~jlewandowski] thank you for quick turnaround and for being so facilitating and moving issues to their separate patches. Feel free to pick me up as a reviewer on some of them if you wish. I've glanced over the patch and it mostly looks good to me. Would mind to submit a circleci before I give a final +1? > Refactor schema management to allow for schema source pluggability > -- > > Key: CASSANDRA-17044 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17044 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1 > > > The idea is decompose `Schema` into separate entities responsible for > different things. In particular extract what is related to schema storage and > synchronization into a separate class so that it is possible to create an > extension point there and store schema in a different way than > `system_schema` keyspace, for example in etcd. > This would also simplify the logic and reduce the number of special cases, > make all the things more testable and the logic of internal classes > encapsulated. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440510#comment-17440510
]
Benjamin Lerer edited comment on CASSANDRA-17120 at 11/8/21, 2:38 PM:
--
The issue is that the comparison is done between the output of
{{System.currentTimeMillis}} and the output of the {{Clock}} used by the
function. The test need to use the output of the {{Clock}} for computing the
expected value.
was (Author: blerer):
The issue is that the comparison is done between the output of
{{System.currentTimeMillis}} and the output of the {{Clock}} used but the
function. The test need to use the output of the {{Clock}} for computing the
expected value.
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 4.x
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17120) Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-17120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440510#comment-17440510
]
Benjamin Lerer commented on CASSANDRA-17120:
The issue is that the comparison is done between the output of
{{System.currentTimeMillis}} and the output of the {{Clock}} used but the
function. The test need to use the output of the {{Clock}} for computing the
expected value.
> Flaky test - org.apache.cassandra.serializers.TimestampSerializerTest
> -
>
> Key: CASSANDRA-17120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17120
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 4.x
>
>
> As seen here:
> https://app.circleci.com/pipelines/github/blerer/cassandra/239/workflows/32b4bc10-685a-4719-ac6c-950e76cd9533/jobs/2144
> {noformat}
> junit.framework.AssertionFailedError: 'now' timestamp not within expected
> tolerance.
> at
> org.apache.cassandra.serializers.TimestampSerializerTest.testNow(TimestampSerializerTest.java:227)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17069) Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs
[ https://issues.apache.org/jira/browse/CASSANDRA-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17069: Reviewers: Marcus Eriksson > Refactor normal/preview/IR repair to standardize repair cleanup and error > handling of failed RepairJobs > --- > > Key: CASSANDRA-17069 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17069 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > > Right now we have 3 different implementations of repair: normal, preview, and > incremental (IR); all 3 handle RepairJob failures differently and offer > different state cleanup. To make sure that we consistently handle errors the > same way and cleanup, we should move these responsibilities outside of the > repair task itself and move these into common APIs and move some logic into > the repair coordination its self. > This work relates with CASSANDRA-15399 as special handling each task makes > the work more complex. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17122) Add utilities for materialized views to CQLTester
[
https://issues.apache.org/jira/browse/CASSANDRA-17122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17122:
--
Test and Documentation Plan: The modified tests should survive some
repeated runs in the test multiplexer.
Status: Patch Available (was: In Progress)
> Add utilities for materialized views to CQLTester
> -
>
> Key: CASSANDRA-17122
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17122
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> CASSANDRA-17070 added automatic generation of MV names to all
> {{ViewComplex*Test}} based on an incremented {{AtomicInteger}} to prevent
> conflicts when the cleanup methods leave a dirty environment. However, we
> still have ten MV tests that could benefit from this kind of name generation
> to avoid potential name conflicts.
> Also, the tests for materialized views have multiple code duplications. There
> are three identical implementations of the {{createView(String, String)}}
> method, eight lists of created views and six almost identical
> parameterizations of {{{}ProtocolVersion{}}}.
> I think we should add methods to create and drop MVs to {{{}CQLTester{}}},
> analogous to the methods that it already has for keyspaces, tables, indexes,
> functions and aggregates. That way we would prevent potential conflicts with
> MV names and reduce code duplication. These methods would also be useful for
> any new tests using MVs that we add in the future, such as for example the
> ones that we would probably need for any future guardrail on MVs.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17122) Add utilities for materialized views to CQLTester
[
https://issues.apache.org/jira/browse/CASSANDRA-17122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17122:
--
Change Category: Quality Assurance
Complexity: Normal
Component/s: Test/unit
Status: Open (was: Triage Needed)
> Add utilities for materialized views to CQLTester
> -
>
> Key: CASSANDRA-17122
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17122
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> CASSANDRA-17070 added automatic generation of MV names to all
> {{ViewComplex*Test}} based on an incremented {{AtomicInteger}} to prevent
> conflicts when the cleanup methods leave a dirty environment. However, we
> still have ten MV tests that could benefit from this kind of name generation
> to avoid potential name conflicts.
> Also, the tests for materialized views have multiple code duplications. There
> are three identical implementations of the {{createView(String, String)}}
> method, eight lists of created views and six almost identical
> parameterizations of {{{}ProtocolVersion{}}}.
> I think we should add methods to create and drop MVs to {{{}CQLTester{}}},
> analogous to the methods that it already has for keyspaces, tables, indexes,
> functions and aggregates. That way we would prevent potential conflicts with
> MV names and reduce code duplication. These methods would also be useful for
> any new tests using MVs that we add in the future, such as for example the
> ones that we would probably need for any future guardrail on MVs.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17122) Add utilities for materialized views to CQLTester
[
https://issues.apache.org/jira/browse/CASSANDRA-17122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440431#comment-17440431
]
Andres de la Peña commented on CASSANDRA-17122:
---
This PR adds utilities for MVs to {{CQLTester}} and modifies the existing MV
tests to use them, getting rid of some 600 lines while reducing the risk of MV
name collisions:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1306]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1127/workflows/a104895e-8430-4fd7-a613-ea9012702bfd]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1127/workflows/be5ecddb-a987-4536-8803-6f46b2a1b350]|
It's based on a previous patch by [~jasonstack]. CI includes 100 repeated runs
of all {{{}View*Test{}}}.
CC [~bereng]
> Add utilities for materialized views to CQLTester
> -
>
> Key: CASSANDRA-17122
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17122
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> CASSANDRA-17070 added automatic generation of MV names to all
> {{ViewComplex*Test}} based on an incremented {{AtomicInteger}} to prevent
> conflicts when the cleanup methods leave a dirty environment. However, we
> still have ten MV tests that could benefit from this kind of name generation
> to avoid potential name conflicts.
> Also, the tests for materialized views have multiple code duplications. There
> are three identical implementations of the {{createView(String, String)}}
> method, eight lists of created views and six almost identical
> parameterizations of {{{}ProtocolVersion{}}}.
> I think we should add methods to create and drop MVs to {{{}CQLTester{}}},
> analogous to the methods that it already has for keyspaces, tables, indexes,
> functions and aggregates. That way we would prevent potential conflicts with
> MV names and reduce code duplication. These methods would also be useful for
> any new tests using MVs that we add in the future, such as for example the
> ones that we would probably need for any future guardrail on MVs.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17122) Add utilities for materialized views to CQLTester
Andres de la Peña created CASSANDRA-17122:
-
Summary: Add utilities for materialized views to CQLTester
Key: CASSANDRA-17122
URL: https://issues.apache.org/jira/browse/CASSANDRA-17122
Project: Cassandra
Issue Type: Improvement
Reporter: Andres de la Peña
Assignee: Andres de la Peña
CASSANDRA-17070 added automatic generation of MV names to all
{{ViewComplex*Test}} based on an incremented {{AtomicInteger}} to prevent
conflicts when the cleanup methods leave a dirty environment. However, we still
have ten MV tests that could benefit from this kind of name generation to avoid
potential name conflicts.
Also, the tests for materialized views have multiple code duplications. There
are three identical implementations of the {{createView(String, String)}}
method, eight lists of created views and six almost identical parameterizations
of {{{}ProtocolVersion{}}}.
I think we should add methods to create and drop MVs to {{{}CQLTester{}}},
analogous to the methods that it already has for keyspaces, tables, indexes,
functions and aggregates. That way we would prevent potential conflicts with MV
names and reduce code duplication. These methods would also be useful for any
new tests using MVs that we add in the future, such as for example the ones
that we would probably need for any future guardrail on MVs.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16630) Migrate to JUnit5
[
https://issues.apache.org/jira/browse/CASSANDRA-16630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440417#comment-17440417
]
Aleksei Zotov commented on CASSANDRA-16630:
---
Hi [~e.dimitrova],
Quick summary on the current state:
* I agree with Benedict that migrating existing tests makes no much sense (it
is complicated and tiresome process that leads to conflicts). The plan for this
ticket is just to support JUnit5 for tests without any tests migration.
* There were two important concepts missing in ant's Junit5 support: ability
to create own wrapper (I fixed it in
[https://github.com/apache/ant/pull/147|https://github.com/apache/ant/pull/147)])
and fork modes support. In
[junit|https://ant.apache.org/manual/Tasks/junit.html] task there was possible
to configure different fork modes: perTest, perBatch and once whereas
[junitlauncher|https://ant.apache.org/manual/Tasks/junitlauncher.html] supports
once mode only (see
[this|https://stackoverflow.com/questions/63294995/running-junit-tests-and-forking-the-jvm-correctly-ant]).
I was going to implement such a support in ant but it turned out to be
complicated since they do not even have proper test coverage.
* I parked the activity at this stage assuming that the migration would be
easier after having Maven/Gradle in place.
* Anyway, I feel it is still possible (I have an idea on a workaround) to
achieve Junit5 with ant.
As far as I understand it is a blocker for Java 17, so let me give a try with
ant. Is there any particular reason why some tests require "perTest" mode? I
believe it just helps to prevent any issues with shared state (configs,
statics, system properties, etc).
> Migrate to JUnit5
> -
>
> Key: CASSANDRA-16630
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16630
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Aleksei Zotov
>Assignee: Aleksei Zotov
>Priority: Low
>
> h3. Overview
> Currently C* uses JUnit4 (version 4.12) which is obsolete. There is a newer
> version 4.13.2 which we could update to. However, JUnit4 is generally
> considered to be outdated and it is reasonable to migrate to JUnit5.
> Despite of having a syntax sugar in JUnit5 (assertThrow, lamda's support,
> ect), there are no blockers that push us to move from JUnit4. The main
> motivation for this initiative is rule of thumb to use up-to-date versions of
> the dependencies.
> Obviously this change is not backward compatible with the open PRs and
> previous C* versions. Therefore, it will require an additional effort for
> backporting the changes and updating PRs that have tests. However, I believe
> it should not be a blocker for this initiative.
> h3. Scope (preliminary list)
> # change JUnit4 to JUnit5 dependencies and make necessary changes in ant
> tasks (https://ant.apache.org/manual/Tasks/junitlauncher.html)
> # update syntax in all tests (imports, Before/After annotations, etc)
> # update parameterized tests
> # create a new version of {{OrderedJUnit4ClassRunner}} and update
> corresponding tests
> # update tests that use {{BMUnitRunner}} (as per
> https://developer.jboss.org/docs/DOC-52953 it supports JUnit5)
> # update tests with {{@Rule}}
> # update tests with expected exceptions
> # update {{JStackJUnitTask}}
> # update formatters
> # create a separate ticket to migrate to {{ant-junitlauncher-1.10.11}} (once
> it is released) and simplify {{JStackJUnitTask}} after
> https://github.com/apache/ant/pull/147
> h3. Order of operations
> In order to make the transition more smooth we want to use a phased approach:
> # migrate to JUnit5 with [Vintage
> Engine|https://junit.org/junit5/docs/current/user-guide/#dependency-metadata-junit-vintage],
> so all JUnit4 tests work as is
> # update tests in a few bunches (to not have a huge single PR with numerous
> conflicts)
> # disable (remove dependency) Vintage Engine, so only JUnit5 tests work
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17119) Broken test_speculative_data_request
[
https://issues.apache.org/jira/browse/CASSANDRA-17119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17119:
Test and Documentation Plan: See PR
Status: Patch Available (was: In Progress)
> Broken test_speculative_data_request
>
>
> Key: CASSANDRA-17119
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17119
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> This has been failing consistently lately
> {noformat}
> Error Message
> KeyError: '127.0.0.3'
> Stacktrace
> self =
> @since('4.0')
> def test_speculative_data_request(self):
> """ If one node doesn't respond to a full data request, it should
> query the other """
> node1, node2, node3 = self.cluster.nodelist()
> assert isinstance(node1, Node)
> assert isinstance(node2, Node)
> assert isinstance(node3, Node)
> session = self.get_cql_connection(node1, timeout=2)
>
> session.execute(quorum("INSERT INTO ks.tbl (k, c, v) VALUES (1, 0,
> 1)"))
>
> node2.byteman_submit(['./byteman/read_repair/stop_writes.btm'])
> node3.byteman_submit(['./byteman/read_repair/stop_writes.btm'])
>
> session.execute("INSERT INTO ks.tbl (k, c, v) VALUES (1, 1, 2)")
>
> # re-enable writes
> node2.byteman_submit(['-u', './byteman/read_repair/stop_writes.btm'])
>
>
> node1.byteman_submit(['./byteman/read_repair/sorted_live_endpoints.btm'])
> node1.byteman_submit(['./byteman/request_verb_timing.btm'])
>
> with StorageProxy(node1) as storage_proxy:
> assert storage_proxy.blocking_read_repair == 0
> assert storage_proxy.speculated_rr_read == 0
> assert storage_proxy.speculated_rr_write == 0
>
> session = self.get_cql_connection(node1)
>
> node2.byteman_submit(['./byteman/read_repair/stop_data_reads.btm'])
> results = session.execute(quorum("SELECT * FROM ks.tbl WHERE
> k=1"))
>
> timing = request_verb_timing(node1)
> > repair_req_node3 = timing[node3.ip_addr].get('READ_REPAIR_REQ')
> E KeyError: '127.0.0.3'
> read_repair_test.py:621: KeyError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17066) Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra"
[ https://issues.apache.org/jira/browse/CASSANDRA-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-17066: Mentor: (was: Anthony Grasso) > Blog post: "Harry: A Fuzz Testing Tool for Apache Cassandra" > > > Key: CASSANDRA-17066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17066 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.2, 4.1 > > > This ticket is to capture the work associated with publishing the November > 2021 blog post titled "Harry, an Open Source Fuzz Testing and Verification > Tool for Apache Cassandra." > If this blog cannot be published by the November 9 publish date, please be > sure to *correct the date* before going live. > This ticket can be closed once the blog post has gone live on the website. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17065) Introduce separate rate limiting settings for entire SSTable streaming
[ https://issues.apache.org/jira/browse/CASSANDRA-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440268#comment-17440268 ] Marcus Eriksson commented on CASSANDRA-17065: - lgtm, could you just run the cci tests with the latest commit? > Introduce separate rate limiting settings for entire SSTable streaming > -- > > Key: CASSANDRA-17065 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17065 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode, Tool/nodetool >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > With the introduction of entire SSTable streaming, it is desirable to > introduce new settings for the rate limit for entire SSTable streaming > operations. > Currently, regular streaming and SSTable streaming are rate limited by the > same setting. However, zero-copy streaming reduces load in the JVM and we can > have a setting specifically for this use case. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
