[jira] [Commented] (CASSANDRA-3033) [patch] ensure full read of chuck

2011-08-14 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13084791#comment-13084791
 ] 

Hudson commented on CASSANDRA-3033:
---

Integrated in Cassandra #1023 (See 
[https://builds.apache.org/job/Cassandra/1023/])
fix read-readFully bug
patch by Dave Brosius and jbellis for CASSANDRA-3033

jbellis : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1157466
Files : 
* 
/cassandra/trunk/src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java


 [patch] ensure full read of chuck
 -

 Key: CASSANDRA-3033
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3033
 Project: Cassandra
  Issue Type: Improvement
Affects Versions: 1.0
Reporter: Dave Brosius
Assignee: Dave Brosius
Priority: Minor
 Fix For: 1.0

 Attachments: ensure_full_read.diff


 code ignores result of RandomAccessFile.read which could potentially return 
 less bytes than was requested. Code loops to read all bytes desired.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-2991) Add a 'load new sstables' JMX/nodetool command

2011-08-14 Thread Pavel Yaskevich (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Yaskevich updated CASSANDRA-2991:
---

Attachment: (was: CASSANDRA-2991.patch)

 Add a 'load new sstables' JMX/nodetool command
 --

 Key: CASSANDRA-2991
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2991
 Project: Cassandra
  Issue Type: New Feature
  Components: Tools
Reporter: Brandon Williams
Assignee: Pavel Yaskevich
 Fix For: 0.8.5


 Sometimes people have to create a new cluster to get around a problem and 
 need to copy sstables around.  It would be convenient to be able to trigger 
 this from nodetool or JMX instead of doing a restart of the node.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-2991) Add a 'load new sstables' JMX/nodetool command

2011-08-14 Thread Pavel Yaskevich (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Yaskevich updated CASSANDRA-2991:
---

Attachment: CASSANDRA-2991.patch

 Add a 'load new sstables' JMX/nodetool command
 --

 Key: CASSANDRA-2991
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2991
 Project: Cassandra
  Issue Type: New Feature
  Components: Tools
Reporter: Brandon Williams
Assignee: Pavel Yaskevich
 Fix For: 0.8.5

 Attachments: CASSANDRA-2991.patch


 Sometimes people have to create a new cluster to get around a problem and 
 need to copy sstables around.  It would be convenient to be able to trigger 
 this from nodetool or JMX instead of doing a restart of the node.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (CASSANDRA-3034) [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done

2011-08-14 Thread Dave Brosius (JIRA)
[patch] BufferedInputStream.skip only skips bytes that are in the buffer, so 
keep skipping until done
-

 Key: CASSANDRA-3034
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3034
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.8.4
Reporter: Dave Brosius
Priority: Trivial
 Fix For: 0.8.5
 Attachments: skip_fully.diff

code calls skip(remaining) without checking result. Skip isn't guaranteed to 
skip what you requested, especially BufferedInputStream, so keep skipping until 
the remaining bytes is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-3034) [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done

2011-08-14 Thread Dave Brosius (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Brosius updated CASSANDRA-3034:


Attachment: skip_fully.diff

 [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so 
 keep skipping until done
 -

 Key: CASSANDRA-3034
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3034
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.8.4
Reporter: Dave Brosius
Priority: Trivial
 Fix For: 0.8.5

 Attachments: skip_fully.diff


 code calls skip(remaining) without checking result. Skip isn't guaranteed to 
 skip what you requested, especially BufferedInputStream, so keep skipping 
 until the remaining bytes is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (CASSANDRA-3035) [patch] CommitLog.recover creates potentially many CRC32 objects. Just create one and reset it.

2011-08-14 Thread Dave Brosius (JIRA)
[patch] CommitLog.recover creates potentially many CRC32 objects. Just create 
one and reset it.
---

 Key: CASSANDRA-3035
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3035
 Project: Cassandra
  Issue Type: Improvement
Affects Versions: 0.8.4
Reporter: Dave Brosius
Priority: Trivial
 Fix For: 0.8.5
 Attachments: reduce_checksum_creation.diff

code calls new CRC32() potentially a lot in loops, just create once and do 
reset()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-3035) [patch] CommitLog.recover creates potentially many CRC32 objects. Just create one and reset it.

2011-08-14 Thread Dave Brosius (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Brosius updated CASSANDRA-3035:


Attachment: reduce_checksum_creation.diff

 [patch] CommitLog.recover creates potentially many CRC32 objects. Just create 
 one and reset it.
 ---

 Key: CASSANDRA-3035
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3035
 Project: Cassandra
  Issue Type: Improvement
Affects Versions: 0.8.4
Reporter: Dave Brosius
Priority: Trivial
 Fix For: 0.8.5

 Attachments: reduce_checksum_creation.diff


 code calls new CRC32() potentially a lot in loops, just create once and do 
 reset()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-1735) Using MessagePack for reducing data size

2011-08-14 Thread Parlo Mendez (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13084871#comment-13084871
 ] 

Parlo Mendez commented on CASSANDRA-1735:
-

The last post is some time ago. What is the current status of messagepack 
implementation in cassandra? I think it would be very nice.

Parlo

 Using MessagePack for reducing data size
 

 Key: CASSANDRA-1735
 URL: https://issues.apache.org/jira/browse/CASSANDRA-1735
 Project: Cassandra
  Issue Type: New Feature
  Components: API
Affects Versions: 0.7 beta 3
 Environment: Fedora11,  JDK1.6.0_20
Reporter: Muga Nishizawa
 Attachments: 
 0001-implement-a-Cassandra-RPC-part-with-MessagePack.patch, 
 dependency_libs.zip


 For improving Cassandra performance, I implemented a Cassandra RPC part with 
 MessagePack.  The implementation details are attached as a patch.  The patch 
 works on Cassandra 0.7.0-beta3.  Please check it.  
 MessagePack is one of object serialization libraries for cross-languages like 
 Thrift and Protocol Buffers but it is much faster, small, and easy to 
 implement.  MessagePack allows reducing serialization cost and data size in 
 network and disk.  
 MessagePack websites are
 * website: http://msgpack.org/
 This website compares MessagePack, Thrift and JSON.  
 * desing details: 
 http://redmine.msgpack.org/projects/msgpack/wiki/FormatDesign
 * source code: https://github.com/msgpack/msgpack/
 Performance of the data serialization library is one of the most important 
 issues for developing a distributed database in Java.  If the performance is 
 bad, it significantly reduces the overall database performance.  Java's GC 
 also runs many times.  Cassandra has this problem as well.  
 For reducing data size in network between a client and Cassandra, I 
 prototyped the implementation of a Cassandra RPC part with MessagePack and 
 MessagePack-RPC.  The implementation is very simple.  MessagePack-RPC can 
 reuse the existing Thrift based CassandraServer 
 (org.apache.cassandra.thrift.CassandraServer)
 while adapting MessagePack's communication protocol and data serialization.  
 Major features of MessagePack-RPC are 
 * Asynchronous RPC
 * Parallel Pipelining
 * Connection pooling
 * Delayed return
 * Event-driven I/O
 * more details: http://redmine.msgpack.org/projects/msgpack/wiki/RPCDesign
 * source code: https://github.com/msgpack/msgpack-rpc/
 The attached patch includes a ring cache program for MessagePack and its test 
 program.  
 You can check the behavior of the Cassandra RPC with MessagePack.  
 Thanks in advance, 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (CASSANDRA-3036) Vague primary key references in CQL

2011-08-14 Thread Kelley Reynolds (JIRA)
Vague primary key references in CQL
---

 Key: CASSANDRA-3036
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3036
 Project: Cassandra
  Issue Type: Bug
  Components: API
Reporter: Kelley Reynolds
Priority: Minor


create columnfamily wonk (id 'utf8' primary key, id int)
update wonk set id=1 where id='test'
create index wonk_id on wonk (id)

This does what you would expect but then the results are unclear when using 
'id' in a where clause.

select * from wonk where id=1 returns nothing and select * from wonk where 
id='test' works fine.

Perhaps secondary indexes should not be allowed on columns that have the same 
name as the key_alias? At least a warning or something should be thrown to 
indicate you've just made a useless index.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-2335) Windows: Test org.apache.cassandra.streaming.SerializationsTest FAILED

2011-08-14 Thread Vladimir Loncar (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Loncar updated CASSANDRA-2335:
---

Attachment: 2335-windows-serialization-tests.patch

 Windows: Test org.apache.cassandra.streaming.SerializationsTest FAILED
 --

 Key: CASSANDRA-2335
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2335
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.7.0
 Environment: Windows
Reporter: Benjamin Coverston
Assignee: Stephen Connolly
Priority: Minor
 Fix For: 0.7.9

 Attachments: 2335-windows-serialization-tests.patch, 2335.txt




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-2335) Windows: Test org.apache.cassandra.streaming.SerializationsTest FAILED

2011-08-14 Thread Vladimir Loncar (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13084906#comment-13084906
 ] 

Vladimir Loncar commented on CASSANDRA-2335:


These tests fail because of the hard-coded path path/doesn't/matter in 
streaming.PendingFile.bin, streaming.StreamHeader.bin and 
streaming.StreamRequestMessage.bin. Since Descriptor only looks for the 
existence of separator char anywhere in the path (and the path doesn't matter 
:)), changing one / to \ in those files seems to make all platforms happy.

Attached patch builds upon previous and adds corrected streaming.*.bin files.

NOTE: Created on windows with svn diff, let me know if there are any issues 
with d2u when applying this.

 Windows: Test org.apache.cassandra.streaming.SerializationsTest FAILED
 --

 Key: CASSANDRA-2335
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2335
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 0.7.0
 Environment: Windows
Reporter: Benjamin Coverston
Assignee: Stephen Connolly
Priority: Minor
 Fix For: 0.7.9

 Attachments: 2335-windows-serialization-tests.patch, 2335.txt




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-2802) Enable encryption for data across the DC only.

2011-08-14 Thread Vijay (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vijay updated CASSANDRA-2802:
-

Attachment: 0002-2802-Changes-to-Snitch-to-avoid-NPE.patch
0001-2802-Commiting-New-Port-For-SSL.patch

Attached patch to support selective communication SSL DC/RACK/ALL... This patch 
separates the communication port into 2 encrypted and unencrypted ports. 
Assumption: Firewall should block the unencrypted ports to block the 
unauthorized use.

 Enable encryption for data across the DC only.
 --

 Key: CASSANDRA-2802
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2802
 Project: Cassandra
  Issue Type: New Feature
  Components: Core
Affects Versions: 0.7.0
 Environment: JVM
Reporter: Vijay
Assignee: Vijay
Priority: Minor
 Fix For: 0.8.5

 Attachments: 0001-2802-Commiting-New-Port-For-SSL.patch, 
 0002-2802-Changes-to-Snitch-to-avoid-NPE.patch


 Make DC level Encryption option
 1) Modify EncryptionOptions to add inter_dc option.
 2) Modify OutboundTCPConnection.connect() to check if it is in the same DC 
 and if the encryption option is enabled.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-2991) Add a 'load new sstables' JMX/nodetool command

2011-08-14 Thread JIRA

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13084930#comment-13084930
 ] 

Sébastien Giroux commented on CASSANDRA-2991:
-

I wouldn't use underscore in the name as the other command don't have any :)

 Add a 'load new sstables' JMX/nodetool command
 --

 Key: CASSANDRA-2991
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2991
 Project: Cassandra
  Issue Type: New Feature
  Components: Tools
Reporter: Brandon Williams
Assignee: Pavel Yaskevich
 Fix For: 0.8.5

 Attachments: CASSANDRA-2991.patch


 Sometimes people have to create a new cluster to get around a problem and 
 need to copy sstables around.  It would be convenient to be able to trigger 
 this from nodetool or JMX instead of doing a restart of the node.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




svn commit: r1157707 - /cassandra/trunk/src/java/org/apache/cassandra/net/IncomingTcpConnection.java

2011-08-14 Thread jbellis
Author: jbellis
Date: Mon Aug 15 04:03:21 2011
New Revision: 1157707

URL: http://svn.apache.org/viewvc?rev=1157707view=rev
Log:
accomodate short skip results
patch by Dave Brosius; reviewed by jbellis for CASSANDRA-3034

Modified:
cassandra/trunk/src/java/org/apache/cassandra/net/IncomingTcpConnection.java

Modified: 
cassandra/trunk/src/java/org/apache/cassandra/net/IncomingTcpConnection.java
URL: 
http://svn.apache.org/viewvc/cassandra/trunk/src/java/org/apache/cassandra/net/IncomingTcpConnection.java?rev=1157707r1=1157706r2=1157707view=diff
==
--- 
cassandra/trunk/src/java/org/apache/cassandra/net/IncomingTcpConnection.java 
(original)
+++ 
cassandra/trunk/src/java/org/apache/cassandra/net/IncomingTcpConnection.java 
Mon Aug 15 04:03:21 2011
@@ -139,9 +139,9 @@ public class IncomingTcpConnection exten
 input.readFully(body, offset, CHUNK_SIZE);
 input.readFully(body, bodySize - remainder, remainder);
 // earlier versions would send unnecessary bytes left over at the end 
of a buffer, too
-int remaining = totalSize - 
OutboundTcpConnection.messageLength(header, id, body);
-if (remaining  0)
-input.skip(remaining);
+long remaining = totalSize - 
OutboundTcpConnection.messageLength(header, id, body);
+while (remaining  0)
+remaining -= input.skip(remaining);
 
 // for non-streaming connections, continue to read the messages (and 
ignore them) until sender
 // starts sending correct-version messages (which it can do without 
reconnecting -- version is per-Message)




[jira] [Resolved] (CASSANDRA-3034) [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done

2011-08-14 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis resolved CASSANDRA-3034.
---

Resolution: Fixed

committed, thanks!

 [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so 
 keep skipping until done
 -

 Key: CASSANDRA-3034
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3034
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0
Reporter: Dave Brosius
Assignee: Dave Brosius
Priority: Trivial
 Fix For: 1.0

 Attachments: skip_fully.diff


 code calls skip(remaining) without checking result. Skip isn't guaranteed to 
 skip what you requested, especially BufferedInputStream, so keep skipping 
 until the remaining bytes is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-3034) [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so keep skipping until done

2011-08-14 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-3034:
--

 Reviewer: jbellis
Affects Version/s: (was: 0.8.4)
   1.0
Fix Version/s: (was: 0.8.5)
   1.0
 Assignee: Dave Brosius

 [patch] BufferedInputStream.skip only skips bytes that are in the buffer, so 
 keep skipping until done
 -

 Key: CASSANDRA-3034
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3034
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0
Reporter: Dave Brosius
Assignee: Dave Brosius
Priority: Trivial
 Fix For: 1.0

 Attachments: skip_fully.diff


 code calls skip(remaining) without checking result. Skip isn't guaranteed to 
 skip what you requested, especially BufferedInputStream, so keep skipping 
 until the remaining bytes is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




svn commit: r1157708 - /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/commitlog/CommitLog.java

2011-08-14 Thread jbellis
Author: jbellis
Date: Mon Aug 15 04:09:55 2011
New Revision: 1157708

URL: http://svn.apache.org/viewvc?rev=1157708view=rev
Log:
re-use CRC32 object on replay
patch by Dave Brosius; reviewed by jbellis for CASSANDRA-3035

Modified:

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/commitlog/CommitLog.java

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/commitlog/CommitLog.java?rev=1157708r1=1157707r2=1157708view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
 Mon Aug 15 04:09:55 2011
@@ -188,6 +188,7 @@ public class CommitLog
 }
 final ReplayPosition globalPosition = 
Ordering.from(ReplayPosition.comparator).min(cfPositions.values());
 
+Checksum checksum = new CRC32();
 for (final File file : clogs)
 {
 final long segment = 
CommitLogSegment.idFromFilename(file.getName());
@@ -226,7 +227,6 @@ public class CommitLog
 logger.debug(Reading mutation at  + 
reader.getFilePointer());
 
 long claimedCRC32;
-Checksum checksum = new CRC32();
 int serializedSize;
 try
 {
@@ -239,6 +239,7 @@ public class CommitLog
 if (serializedSize  10)
 break;
 long claimedSizeChecksum = reader.readLong();
+checksum.reset();
 checksum.update(serializedSize);
 if (checksum.getValue() != claimedSizeChecksum)
 break; // entry wasn't synced correctly/fully.  
that's ok.




[jira] [Updated] (CASSANDRA-3035) [patch] CommitLog.recover creates potentially many CRC32 objects. Just create one and reset it.

2011-08-14 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-3035:
--

 Reviewer: jbellis
Affects Version/s: (was: 0.8.4)
 Assignee: Dave Brosius

 [patch] CommitLog.recover creates potentially many CRC32 objects. Just create 
 one and reset it.
 ---

 Key: CASSANDRA-3035
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3035
 Project: Cassandra
  Issue Type: Improvement
Reporter: Dave Brosius
Assignee: Dave Brosius
Priority: Trivial
 Fix For: 0.8.5

 Attachments: reduce_checksum_creation.diff


 code calls new CRC32() potentially a lot in loops, just create once and do 
 reset()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Resolved] (CASSANDRA-3035) [patch] CommitLog.recover creates potentially many CRC32 objects. Just create one and reset it.

2011-08-14 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis resolved CASSANDRA-3035.
---

Resolution: Fixed

committed, thanks!

 [patch] CommitLog.recover creates potentially many CRC32 objects. Just create 
 one and reset it.
 ---

 Key: CASSANDRA-3035
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3035
 Project: Cassandra
  Issue Type: Improvement
Reporter: Dave Brosius
Assignee: Dave Brosius
Priority: Trivial
 Fix For: 0.8.5

 Attachments: reduce_checksum_creation.diff


 code calls new CRC32() potentially a lot in loops, just create once and do 
 reset()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-2061) Missing logging for some exceptions

2011-08-14 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13084958#comment-13084958
 ] 

Jonathan Ellis commented on CASSANDRA-2061:
---

Figured out the problem.  Here's the new version of logExceptionsAfterExecute 
that fixes it:

{code}
 public static void logExceptionsAfterExecute(Runnable r, Throwable t)
 {
-// exceptions wrapped by FutureTask
-if (r instanceof FutureTask?)
+// Check for exceptions wrapped by FutureTask.  We do this by calling 
get(), which will
+// cause it to throw any saved exception.
+//
+// Complicating things, calling get() on a ScheduledFutureTask will 
block until the task
+// is cancelled.  Hence, the extra isDone check beforehand.
+if ((r instanceof Future?)  ((Future?) r).isDone())
 {
 try
 {
-((FutureTask?) r).get();
+((Future?) r).get();
 }
{code}

 Missing logging for some exceptions
 ---

 Key: CASSANDRA-2061
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2061
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Reporter: Stu Hood
Assignee: Jonathan Ellis
Priority: Minor
 Fix For: 1.0

 Attachments: 2061-0.7.txt, 2061-v3.txt, 2061.txt

   Original Estimate: 8h
  Remaining Estimate: 8h

 {quote}Since you are using ScheduledThreadPoolExecutor.schedule(), the 
 exception was swallowed by the FutureTask.
 You will have to perform a get() method on the ScheduledFuture, and you will 
 get ExecutionException if there was any exception occured in run().{quote}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (CASSANDRA-2061) Missing logging for some exceptions

2011-08-14 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-2061:
--

Attachment: 2061-v3.txt

 Missing logging for some exceptions
 ---

 Key: CASSANDRA-2061
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2061
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Reporter: Stu Hood
Assignee: Jonathan Ellis
Priority: Minor
 Fix For: 1.0

 Attachments: 2061-0.7.txt, 2061-v3.txt, 2061.txt

   Original Estimate: 8h
  Remaining Estimate: 8h

 {quote}Since you are using ScheduledThreadPoolExecutor.schedule(), the 
 exception was swallowed by the FutureTask.
 You will have to perform a get() method on the ScheduledFuture, and you will 
 get ExecutionException if there was any exception occured in run().{quote}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (CASSANDRA-3035) [patch] CommitLog.recover creates potentially many CRC32 objects. Just create one and reset it.

2011-08-14 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13084965#comment-13084965
 ] 

Hudson commented on CASSANDRA-3035:
---

Integrated in Cassandra-0.8 #279 (See 
[https://builds.apache.org/job/Cassandra-0.8/279/])
re-use CRC32 object on replay
patch by Dave Brosius; reviewed by jbellis for CASSANDRA-3035

jbellis : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1157708
Files : 
* 
/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/commitlog/CommitLog.java


 [patch] CommitLog.recover creates potentially many CRC32 objects. Just create 
 one and reset it.
 ---

 Key: CASSANDRA-3035
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3035
 Project: Cassandra
  Issue Type: Improvement
Reporter: Dave Brosius
Assignee: Dave Brosius
Priority: Trivial
 Fix For: 0.8.5

 Attachments: reduce_checksum_creation.diff


 code calls new CRC32() potentially a lot in loops, just create once and do 
 reset()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira