date:20111209

Author: brandonwilliams
Date: Fri Dec  9 18:14:14 2011
New Revision: 1212556

URL: http://svn.apache.org/viewvc?rev=1212556view=rev
Log:
Add jmx method to forcibly remove endpoints.
Patch by brandonwilliams reviewed by Paul Cannon for CASSANDRA-3337.

Modified:

cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/Gossiper.java

cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/GossiperMBean.java

Modified: 
cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/Gossiper.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/Gossiper.java?rev=1212556r1=1212555r2=1212556view=diff
==
--- 
cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/Gossiper.java
 (original)
+++ 
cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/Gossiper.java
 Fri Dec  9 18:14:14 2011
@@ -432,6 +432,66 @@ public class Gossiper implements IFailur
 }
 }
 
+/**
+ * Do not call this method unless you know what you are doing.
+ * It will try extremely hard to obliterate any endpoint from the ring,
+ * even if it does not know about it.
+ * This should only ever be called by human via JMX.
+ * @param  address
+ * @throws UnknownHostException
+ */
+public void unsafeAssassinateEndpoint(String address) throws 
UnknownHostException
+{
+InetAddress endpoint = InetAddress.getByName(address);
+EndpointState epState = endpointStateMap.get(endpoint);
+Token token = null;
+logger.warn(Assassinating {} via gossip, endpoint);
+if (epState == null)
+{
+epState = new EndpointState(new 
HeartBeatState((int)((System.currentTimeMillis() + 6) / 1000), ));
+}
+else
+{
+try
+{
+token = 
StorageService.instance.getTokenMetadata().getToken(endpoint);
+}
+catch (AssertionError e)
+{
+}
+int generation = epState.getHeartBeatState().getGeneration();
+logger.info(Sleeping for  + StorageService.RING_DELAY + ms to 
ensure  + endpoint +  does not change);
+try
+{
+Thread.sleep(StorageService.RING_DELAY);
+}
+catch (InterruptedException e)
+{
+throw new AssertionError(e);
+}
+// make sure it did not change
+epState = endpointStateMap.get(endpoint);
+if (epState.getHeartBeatState().getGeneration() != generation)
+throw new RuntimeException(Endpoint  + endpoint +  
generation changed while trying to remove it);
+epState.updateTimestamp(); // make sure we don't evict it too soon
+epState.getHeartBeatState().forceNewerGenerationUnsafe();
+}
+if (token == null)
+token = StorageService.instance.getBootstrapToken();
+// do not pass go, do not collect 200 dollars, just gtfo
+epState.addApplicationState(ApplicationState.STATUS, 
StorageService.instance.valueFactory.left(token, computeExpireTime()));
+handleMajorStateChange(endpoint, epState);
+try
+{
+Thread.sleep(intervalInMillis * 4);
+}
+catch (InterruptedException e)
+{
+throw new AssertionError(e);
+}
+logger.warn(Finished killing {}, endpoint);
+}
+
 public boolean isKnownEndpoint(InetAddress endpoint)
 {
 return endpointStateMap.containsKey(endpoint);

Modified: 
cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/GossiperMBean.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/GossiperMBean.java?rev=1212556r1=1212555r2=1212556view=diff
==
--- 
cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/GossiperMBean.java
 (original)
+++ 
cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/GossiperMBean.java
 Fri Dec  9 18:14:14 2011
@@ -28,4 +28,6 @@ public interface GossiperMBean
 
 public int getCurrentGenerationNumber(String address) throws 
UnknownHostException;
 
+public void unsafeAssassinateEndpoint(String address) throws 
UnknownHostException;
+
 }
\ No newline at end of file

[jira] [Commented] (CASSANDRA-3602) Remove test/distributed

2011-12-09 Thread Jonathan Ellis (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166386#comment-13166386
 ] 

Jonathan Ellis commented on CASSANDRA-3602:
---

does the ccm dtest have equivalents to the old Counters, Movement, and Mutation 
tests?

 Remove test/distributed
 ---

 Key: CASSANDRA-3602
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3602
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Brandon Williams
Priority: Trivial
 Fix For: 1.0.6, 1.1


 Now that we've shifted focus to the new ccm-based distributed tests 
 (https://github.com/riptano/cassandra-dtest) I think it's time to remove the 
 now long-neglected distributed test cruft from our tree.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3602) Remove test/distributed

2011-12-09 Thread Brandon Williams (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166389#comment-13166389
 ] 

Brandon Williams commented on CASSANDRA-3602:
-

Yes.

 Remove test/distributed
 ---

 Key: CASSANDRA-3602
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3602
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Brandon Williams
Priority: Trivial
 Fix For: 1.0.6, 1.1


 Now that we've shifted focus to the new ccm-based distributed tests 
 (https://github.com/riptano/cassandra-dtest) I think it's time to remove the 
 now long-neglected distributed test cruft from our tree.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3602) Remove test/distributed

2011-12-09 Thread Sylvain Lebresne (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166390#comment-13166390
 ] 

Sylvain Lebresne commented on CASSANDRA-3602:
-

It does. Well, except that the equivalents are way better :P

 Remove test/distributed
 ---

 Key: CASSANDRA-3602
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3602
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Brandon Williams
Priority: Trivial
 Fix For: 1.0.6, 1.1


 Now that we've shifted focus to the new ccm-based distributed tests 
 (https://github.com/riptano/cassandra-dtest) I think it's time to remove the 
 now long-neglected distributed test cruft from our tree.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3602) Remove test/distributed

2011-12-09 Thread Jonathan Ellis (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166391#comment-13166391
 ] 

Jonathan Ellis commented on CASSANDRA-3602:
---

+1 then

 Remove test/distributed
 ---

 Key: CASSANDRA-3602
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3602
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Brandon Williams
Priority: Trivial
 Fix For: 1.0.6, 1.1


 Now that we've shifted focus to the new ccm-based distributed tests 
 (https://github.com/riptano/cassandra-dtest) I think it's time to remove the 
 now long-neglected distributed test cruft from our tree.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3600) Allow overriding RING_DELAY

2011-12-09 Thread Brandon Williams (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-3600:


Attachment: 0002-tests-override-ring-delay-gossiper-retains-ring-dela.txt
0001-allow-ring-delay-override.txt

 Allow overriding RING_DELAY
 ---

 Key: CASSANDRA-3600
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3600
 Project: Cassandra
  Issue Type: New Feature
  Components: Core
Reporter: Brandon Williams
Assignee: Brandon Williams
 Fix For: 1.0.6

 Attachments: 0001-allow-ring-delay-override.txt, 
 0002-tests-override-ring-delay-gossiper-retains-ring-dela.txt


 RING_DELAY is what is consuming the majority of the time in the dtests.  
 Since these run on localhost, it's safe to reduce this to save lots of time.  
 Also being able to change this may obviate the need for CASSANDRA-3120.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

svn commit: r1212572 - in /cassandra/branches/cassandra-1.0: ./ test/distributed/ test/distributed/org/apache/cassandra/ test/distributed/org/apache/cassandra/utils/

Author: brandonwilliams
Date: Fri Dec  9 18:45:39 2011
New Revision: 1212572

URL: http://svn.apache.org/viewvc?rev=1212572view=rev
Log:
Remove old distributed tests.
Patch by brandonwilliams reviewed by jbellis for CASSANDRA-3602

Removed:
cassandra/branches/cassandra-1.0/test/distributed/README.txt

cassandra/branches/cassandra-1.0/test/distributed/org/apache/cassandra/CassandraServiceController.java

cassandra/branches/cassandra-1.0/test/distributed/org/apache/cassandra/CountersTest.java

cassandra/branches/cassandra-1.0/test/distributed/org/apache/cassandra/MovementTest.java

cassandra/branches/cassandra-1.0/test/distributed/org/apache/cassandra/MutationTest.java

cassandra/branches/cassandra-1.0/test/distributed/org/apache/cassandra/TestBase.java

cassandra/branches/cassandra-1.0/test/distributed/org/apache/cassandra/utils/BlobUtils.java

cassandra/branches/cassandra-1.0/test/distributed/org/apache/cassandra/utils/KeyPair.java
Modified:
cassandra/branches/cassandra-1.0/build.xml

Modified: cassandra/branches/cassandra-1.0/build.xml
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/build.xml?rev=1212572r1=1212571r2=1212572view=diff
==
--- cassandra/branches/cassandra-1.0/build.xml (original)
+++ cassandra/branches/cassandra-1.0/build.xml Fri Dec  9 18:45:39 2011
@@ -60,7 +60,6 @@
 property name=test.name value=*Test/
 property name=test.unit.src value=${test.dir}/unit/
 property name=test.long.src value=${test.dir}/long/
-property name=test.distributed.src value=${test.dir}/distributed/
 property name=dist.dir value=${build.dir}/dist/
 condition property=version value=${base.version}
   isset property=release/
@@ -287,9 +286,6 @@ url=${svn.entry.url}?pathrev=${svn.entry
   artifact:remoteRepository id=central   
url=${artifact.remoteRepository.central}/
   artifact:remoteRepository id=java.net2 
url=${artifact.remoteRepository.java.net2}/
   artifact:remoteRepository id=apache
url=${artifact.remoteRepository.apache}/
-  !-- for distributed tests --
-  artifact:remoteRepository id=jclouds   
url=${artifact.remoteRepository.jclouds}/
-  artifact:remoteRepository id=oauth 
url=${artifact.remoteRepository.oauth}/
 
   macrodef name=install
 attribute name=pomFile/
@@ -972,22 +968,6 @@ url=${svn.entry.url}?pathrev=${svn.entry
 /copy
   /target
 
-  target name=build-distributed-test 
depends=build-test,maven-ant-tasks-retrieve-test description=Compile 
distributed test classes (which have additional deps)
-javac
- debug=true
- debuglevel=${debuglevel}
- destdir=${test.classes}
-  classpath
-  path refid=cassandra.classpath/
-  pathelement location=${test.classes}/
-  fileset dir=${test.lib}
-include name=**/*.jar /
-  /fileset
-  /classpath
-  src path=${test.distributed.src}/
-/javac
-  /target
-
   macrodef name=testmacro
 attribute name=suitename /
 attribute name=inputdir /
@@ -1076,14 +1056,6 @@ url=${svn.entry.url}?pathrev=${svn.entry
timeout=${test.long.timeout} /
   /target
 
-  !-- Depends on artifacts so that we can push a tarball to remote nodes, and 
has its own build target for cloudy deps. --
-  target name=distributed-test depends=build-distributed-test,artifacts 
description=Execute distributed tests: see ${test.distributed.src}/README.txt
-testmacro suitename=distributed inputdir=${test.distributed.src} 
timeout=120 forkmode=once
-  jvmarg value=-Dwhirr.config=${whirr.config}/
-  jvmarg 
value=-Dwhirr.cassandra_tarball=${build.dir}/${final.name}-bin.tar.gz/
-/testmacro
-  /target
-
   !-- instruments the classes to later create code coverage reports --
   target name=cobertura-instrument depends=build,build-test
 taskdef resource=tasks.properties

[jira] [Resolved] (CASSANDRA-3602) Remove test/distributed

2011-12-09 Thread Brandon Williams (Resolved) (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams resolved CASSANDRA-3602.
-

Resolution: Fixed
  Assignee: Brandon Williams

Committed.

 Remove test/distributed
 ---

 Key: CASSANDRA-3602
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3602
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Brandon Williams
Assignee: Brandon Williams
Priority: Trivial
 Fix For: 1.0.6, 1.1


 Now that we've shifted focus to the new ccm-based distributed tests 
 (https://github.com/riptano/cassandra-dtest) I think it's time to remove the 
 now long-neglected distributed test cruft from our tree.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3598) Index Scan's will span across multiple DC's

2011-12-09 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166445#comment-13166445
 ] 

Hudson commented on CASSANDRA-3598:
---

Integrated in Cassandra-0.8 #414 (See 
[https://builds.apache.org/job/Cassandra-0.8/414/])
range and index scans now only send requests to enough replicas to satisfy 
requested CL + RR
patch by Vijay and jbellis for CASSANDRA-3598

jbellis : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1212552
Files : 
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* 
/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageProxy.java


 Index Scan's will span across multiple DC's
 ---

 Key: CASSANDRA-3598
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3598
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.7.0
Reporter: Vijay
Assignee: Vijay
Priority: Minor
 Fix For: 0.7.4, 0.8.9, 1.0.6

 Attachments: 0001-super-simple-patch-3598.patch


 Looks like we send requests to all the nodes provided by 
 StorageService.instance.getLiveNaturalEndpoints(keyspace, range.right);
 We dont filter it based on blockedFor (Consistency levels).
 In a multi DC setup this will cause unnecessary load on the other DC. And 
 even within a DC we might query more nodes than needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3585) Intermittent exceptions seen in cassandra 1.0.5 during Reads.

2011-12-09 Thread Jonathan Ellis (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166449#comment-13166449
 ] 

Jonathan Ellis commented on CASSANDRA-3585:
---

Some interesting things from the trace log:

The request that errors out:
{noformat}
DEBUG [pool-2-thread-39] 2011-12-08 21:07:21,815 StorageProxy.java (line 627) 
Command/ConsistencyLevel is SliceByNamesReadCommand(table='KeyspaceMetadata', 
key=313030303237383033, 
columnParent='QueryPath(columnFamilyName='CF_MailboxSummary', 
superColumnName='null', columnName='null')', 
columns=[666f6c6465725f73756d6d6172795f4c057f31b9ba31138e6c1ff57f552f66,666f6c6465725f73756d6d6172795f5112276526f2330392edfc4b47cf4725,666f6c6465725f73756d6d6172795ff75e02920bc73235abb48ead4be65444,])/QUORUM
{noformat}

The data read, and the digest read that errors out.
{noformat}
DEBUG [pool-2-thread-39] 2011-12-08 21:07:21,836 StorageProxy.java (line 648) 
reading data from /192.168.136.231
TRACE [pool-2-thread-39] 2011-12-08 21:07:21,836 MessagingService.java (line 
412) /192.168.128.229 sending READ version 3 to 3242@/192.168.136.231
DEBUG [pool-2-thread-39] 2011-12-08 21:07:21,869 StorageProxy.java (line 668) 
reading digest from /192.168.128.226
TRACE [pool-2-thread-39] 2011-12-08 21:07:21,870 MessagingService.java (line 
412) /192.168.128.229 sending READ version 3 to 3280@/192.168.128.226
{noformat}

Failing to parse the reply:
{noformat}
DEBUG [Thread-8] 2011-12-08 21:07:21,877 IncomingTcpConnection.java (line 149) 
Message body is 47 bytes
TRACE [Thread-8] 2011-12-08 21:07:21,885 MessagingService.java (line 502) 
/192.168.128.229 received REQUEST_RESPONSE from 3280@/192.168.136.234
DEBUG [RequestResponseStage:18] 2011-12-08 21:07:21,885 
ResponseVerbHandler.java (line 44) Processing response on a callback from 
3280@/192.168.136.234
DEBUG [RequestResponseStage:18] 2011-12-08 21:07:21,891 
AbstractRowResolver.java (line 64) Preprocessing 47 bytes
ERROR [RequestResponseStage:18] 2011-12-08 21:07:21,903 
AbstractCassandraDaemon.java (line 133) Fatal exception in thread 
Thread[RequestResponseStage:18,5,main]
{noformat}

It sure looks like something fishy is going on with the message IDs -- we sent 
3280@ to .226, but here we are processing a response from .234.  It's also 
worth noting that the message size (47 bytes) is neither a digest reply (21 
bytes) or the data for the read here (16460 bytes), BUT we do see other 47 byte 
replies in the log around this time, that are replies to a Mutation sent 
earlier:

{noformat}
DEBUG [Thread-15] 2011-12-08 21:07:21,891 IncomingTcpConnection.java (line 149) 
Message body is 47 bytes
TRACE [Thread-15] 2011-12-08 21:07:21,902 MessagingService.java (line 502) 
/192.168.128.229 received REQUEST_RESPONSE from 3145@/192.168.128.227
{noformat}

I think we have a race in the MessagingService ID/Callback Map somewhere.

 Intermittent exceptions seen in cassandra 1.0.5 during Reads.
 -

 Key: CASSANDRA-3585
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3585
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.5
 Environment: RHEL 2.6.32-71.el6.x86_64.
 RAM - 28GB
 11 CPUs of 2.6GHz
Reporter: Shantanu
 Attachments: 3585-v2.txt, 3585.txt, metap_system.log.zip, 
 metap_system.log.zip


 In my test setup I have cassandra db provisioned with cassandra 0.8.7. The 
 setup is of two data centers. I have upgraded the cassandra to the latest 
 version 1.0.5. I'm seeing following exceptions in cassandra logs -
 ERROR [RequestResponseStage:32] 2011-12-06 14:46:08,150 
 AbstractCassandraDaemon.java (line 133) Fatal exception in thread 
 Thread[RequestResponseStage:32,5,main]
 java.io.IOError: java.io.EOFException
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:71)
 at org.apache.cassandra.service.ReadCallback.response(ReadCallback.java:126)
 at 
 org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:45)
 at 
 org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:59)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.io.EOFException
 at java.io.DataInputStream.readFully(DataInputStream.java:180)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:100)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:81)
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:64)
 ... 6 more
 RF is set to DC1:3,DC2:3 and I/m doing the operations with CL=Local_Quorum.
 I have run nodetool scrub on all the

[jira] [Commented] (CASSANDRA-3585) Intermittent exceptions seen in cassandra 1.0.5 during Reads.

2011-12-09 Thread Jonathan Ellis (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166453#comment-13166453
 ] 

Jonathan Ellis commented on CASSANDRA-3585:
---

Later on, we do get the reply we were expecting from .226, but by then the 
callback mapping has been destroyed:

{noformat}
DEBUG [Thread-17] 2011-12-08 21:07:22,140 IncomingTcpConnection.java (line 149) 
Message body is 21 bytes
TRACE [Thread-17] 2011-12-08 21:07:22,145 MessagingService.java (line 502) 
/192.168.128.229 received REQUEST_RESPONSE from 3280@/192.168.128.226
{noformat}

 Intermittent exceptions seen in cassandra 1.0.5 during Reads.
 -

 Key: CASSANDRA-3585
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3585
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.5
 Environment: RHEL 2.6.32-71.el6.x86_64.
 RAM - 28GB
 11 CPUs of 2.6GHz
Reporter: Shantanu
 Attachments: 3585-v2.txt, 3585.txt, metap_system.log.zip, 
 metap_system.log.zip


 In my test setup I have cassandra db provisioned with cassandra 0.8.7. The 
 setup is of two data centers. I have upgraded the cassandra to the latest 
 version 1.0.5. I'm seeing following exceptions in cassandra logs -
 ERROR [RequestResponseStage:32] 2011-12-06 14:46:08,150 
 AbstractCassandraDaemon.java (line 133) Fatal exception in thread 
 Thread[RequestResponseStage:32,5,main]
 java.io.IOError: java.io.EOFException
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:71)
 at org.apache.cassandra.service.ReadCallback.response(ReadCallback.java:126)
 at 
 org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:45)
 at 
 org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:59)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.io.EOFException
 at java.io.DataInputStream.readFully(DataInputStream.java:180)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:100)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:81)
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:64)
 ... 6 more
 RF is set to DC1:3,DC2:3 and I/m doing the operations with CL=Local_Quorum.
 I have run nodetool scrub on all the nodes in the ring to verify if it solves 
 the issue but it didn't.
 Thanks,
 Shantanu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3585) Intermittent exceptions seen in cassandra 1.0.5 during Reads.

2011-12-09 Thread Jonathan Ellis (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166466#comment-13166466
 ] 

Jonathan Ellis commented on CASSANDRA-3585:
---

There's one more instance of the 3280@ id in the log:

{noformat}
TRACE [Thread-5] 2011-12-08 21:07:28,659 MessagingService.java (line 502) 
/192.168.128.229 received GOSSIP_DIGEST_ACK from 3280@/192.168.128.225
{noformat}

But GOSSIP_DIGEST_ACK is a command, not a response, i.e., that 3280 is an id 
generated on .225, so there's nothing abnormal there.

 Intermittent exceptions seen in cassandra 1.0.5 during Reads.
 -

 Key: CASSANDRA-3585
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3585
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.5
 Environment: RHEL 2.6.32-71.el6.x86_64.
 RAM - 28GB
 11 CPUs of 2.6GHz
Reporter: Shantanu
 Attachments: 3585-v2.txt, 3585.txt, metap_system.log.zip, 
 metap_system.log.zip


 In my test setup I have cassandra db provisioned with cassandra 0.8.7. The 
 setup is of two data centers. I have upgraded the cassandra to the latest 
 version 1.0.5. I'm seeing following exceptions in cassandra logs -
 ERROR [RequestResponseStage:32] 2011-12-06 14:46:08,150 
 AbstractCassandraDaemon.java (line 133) Fatal exception in thread 
 Thread[RequestResponseStage:32,5,main]
 java.io.IOError: java.io.EOFException
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:71)
 at org.apache.cassandra.service.ReadCallback.response(ReadCallback.java:126)
 at 
 org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:45)
 at 
 org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:59)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.io.EOFException
 at java.io.DataInputStream.readFully(DataInputStream.java:180)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:100)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:81)
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:64)
 ... 6 more
 RF is set to DC1:3,DC2:3 and I/m doing the operations with CL=Local_Quorum.
 I have run nodetool scrub on all the nodes in the ring to verify if it solves 
 the issue but it didn't.
 Thanks,
 Shantanu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (CASSANDRA-3603) CounterColumn and CounterContext use a log4j logger instead of using slf4j like the rest of the code base

2011-12-09 Thread Peter Schuller (Created) (JIRA)

CounterColumn and CounterContext use a log4j logger instead of using slf4j like 
the rest of the code base
-

 Key: CASSANDRA-3603
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3603
 Project: Cassandra
  Issue Type: Bug
Reporter: Peter Schuller
Assignee: Peter Schuller
Priority: Minor


(Will submit patch but not now, no time.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3585) Intermittent exceptions seen in cassandra 1.0.5 during Reads.

2011-12-09 Thread Shantanu (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shantanu updated CASSANDRA-3585:


Attachment: CassandraLogs.tar.bz2

Here are the logs for all the cassandra servers in the ring.
These are the logs from the test I did today. We have removed 192.168.128.229 
and 192.168.136.234 since these machines were having some issues. These logs 
are with fresh install of cassandra 1.0.5 with 8 nodes.

 Intermittent exceptions seen in cassandra 1.0.5 during Reads.
 -

 Key: CASSANDRA-3585
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3585
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.5
 Environment: RHEL 2.6.32-71.el6.x86_64.
 RAM - 28GB
 11 CPUs of 2.6GHz
Reporter: Shantanu
 Attachments: 3585-v2.txt, 3585.txt, CassandraLogs.tar.bz2, 
 metap_system.log.zip, metap_system.log.zip


 In my test setup I have cassandra db provisioned with cassandra 0.8.7. The 
 setup is of two data centers. I have upgraded the cassandra to the latest 
 version 1.0.5. I'm seeing following exceptions in cassandra logs -
 ERROR [RequestResponseStage:32] 2011-12-06 14:46:08,150 
 AbstractCassandraDaemon.java (line 133) Fatal exception in thread 
 Thread[RequestResponseStage:32,5,main]
 java.io.IOError: java.io.EOFException
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:71)
 at org.apache.cassandra.service.ReadCallback.response(ReadCallback.java:126)
 at 
 org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:45)
 at 
 org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:59)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.io.EOFException
 at java.io.DataInputStream.readFully(DataInputStream.java:180)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:100)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:81)
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:64)
 ... 6 more
 RF is set to DC1:3,DC2:3 and I/m doing the operations with CL=Local_Quorum.
 I have run nodetool scrub on all the nodes in the ring to verify if it solves 
 the issue but it didn't.
 Thanks,
 Shantanu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

2011-12-09 Thread paul cannon (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166528#comment-13166528
 ] 

paul cannon commented on CASSANDRA-3485:


+1.

 Gossiper.addSavedEndpoint should never add itself
 -

 Key: CASSANDRA-3485
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.7 beta 3
Reporter: Brandon Williams
Assignee: Brandon Williams
 Fix For: 0.8.9

 Attachments: 3485.txt


 Somehow, people are running into a situation where nodes are adding 
 themselves to the persisted ring cache.  Since SS is initialized after the 
 Gossiper and calls addSavedEndpoint on it, which inits the nodes with a 
 generation of zero, this ends up with nodes using a generation of zero and 
 thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

svn commit: r1212624 - in /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra: db/SystemTable.java gms/Gossiper.java service/StorageService.java

Author: brandonwilliams
Date: Fri Dec  9 20:56:08 2011
New Revision: 1212624

URL: http://svn.apache.org/viewvc?rev=1212624view=rev
Log:
Prevent gossiper from adding itself to saved endpoints.
Patch by brandonwilliams reviewed by Paul Cannon for CASSANDRA-3485.

Modified:

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java?rev=1212624r1=1212623r2=1212624view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java
 Fri Dec  9 20:56:08 2011
@@ -100,6 +100,8 @@ public class SystemTable
  */
 public static synchronized void updateToken(InetAddress ep, Token token)
 {
+if (ep == FBUtilities.getBroadcastAddress())
+return;
 IPartitioner p = StorageService.getPartitioner();
 ColumnFamily cf = ColumnFamily.create(Table.SYSTEM_TABLE, STATUS_CF);
 cf.addColumn(new Column(p.getTokenFactory().toByteArray(token), 
ByteBuffer.wrap(ep.getAddress()), System.currentTimeMillis()));

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java?rev=1212624r1=1212623r2=1212624view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java
 Fri Dec  9 20:56:08 2011
@@ -995,6 +995,11 @@ public class Gossiper implements IFailur
  */
 public void addSavedEndpoint(InetAddress ep)
 {
+if (ep == FBUtilities.getBroadcastAddress())
+{
+logger.debug(Attempt to add self as saved endpoint);
+return;
+}
 EndpointState epState = new EndpointState(new HeartBeatState(0));
 epState.markDead();
 epState.setHasToken(true);

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java?rev=1212624r1=1212623r2=1212624view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java
 Fri Dec  9 20:56:08 2011
@@ -387,8 +387,16 @@ public class StorageService implements I
 logger_.info(Loading persisted ring state);
 for (Map.EntryToken, InetAddress entry : 
SystemTable.loadTokens().entrySet())
 {
-tokenMetadata_.updateNormalToken(entry.getKey(), 
entry.getValue());
-Gossiper.instance.addSavedEndpoint(entry.getValue());
+if (entry.getValue() == FBUtilities.getBroadcastAddress())
+{
+// entry has been mistakenly added, delete it
+SystemTable.removeToken(entry.getKey());
+}
+else
+{
+tokenMetadata_.updateNormalToken(entry.getKey(), 
entry.getValue());
+Gossiper.instance.addSavedEndpoint(entry.getValue());
+}
 }
 }

svn commit: r1212626 - /cassandra/branches/cassandra-0.8/CHANGES.txt

Author: brandonwilliams
Date: Fri Dec  9 20:56:17 2011
New Revision: 1212626

URL: http://svn.apache.org/viewvc?rev=1212626view=rev
Log:
Update changes for 3485

Modified:
cassandra/branches/cassandra-0.8/CHANGES.txt

Modified: cassandra/branches/cassandra-0.8/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/CHANGES.txt?rev=1212626r1=1212625r2=1212626view=diff
==
--- cassandra/branches/cassandra-0.8/CHANGES.txt (original)
+++ cassandra/branches/cassandra-0.8/CHANGES.txt Fri Dec  9 20:56:17 2011
@@ -6,6 +6,7 @@
CL.ONE or CL.LOCAL_QUORUM (CASSANDRA-3577)
  * detect misuses of CounterColumnType (CASSANDRA-3422)
  * turn off string interning in json2sstable, take 2 (CASSANDRA-2189)
+ * gossiper will never add itself to saved endpoints (CASSANDRA-3485)
 
 
 0.8.8

buildbot failure in ASF Buildbot on cassandra-0.8

2011-12-09 Thread buildbot

The Buildbot has detected a new failure on builder cassandra-0.8 while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/cassandra-0.8/builds/94

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch cassandra/branches/cassandra-0.8] 1212626
Blamelist: brandonwilliams

BUILD FAILED: failed compile

sincerely,
 -The Buildbot

svn commit: r1212627 - in /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra: db/SystemTable.java gms/Gossiper.java service/StorageService.java

Author: brandonwilliams
Date: Fri Dec  9 21:00:58 2011
New Revision: 1212627

URL: http://svn.apache.org/viewvc?rev=1212627view=rev
Log:
Fix broken 3485 commit

Modified:

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java

cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java?rev=1212627r1=1212626r2=1212627view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java
 Fri Dec  9 21:00:58 2011
@@ -100,7 +100,7 @@ public class SystemTable
  */
 public static synchronized void updateToken(InetAddress ep, Token token)
 {
-if (ep == FBUtilities.getBroadcastAddress())
+if (ep == FBUtilities.getLocalAddress())
 return;
 IPartitioner p = StorageService.getPartitioner();
 ColumnFamily cf = ColumnFamily.create(Table.SYSTEM_TABLE, STATUS_CF);

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java?rev=1212627r1=1212626r2=1212627view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java
 Fri Dec  9 21:00:58 2011
@@ -995,7 +995,7 @@ public class Gossiper implements IFailur
  */
 public void addSavedEndpoint(InetAddress ep)
 {
-if (ep == FBUtilities.getBroadcastAddress())
+if (ep == FBUtilities.getLocalAddress())
 {
 logger.debug(Attempt to add self as saved endpoint);
 return;

Modified: 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java?rev=1212627r1=1212626r2=1212627view=diff
==
--- 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java
 (original)
+++ 
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java
 Fri Dec  9 21:00:58 2011
@@ -387,7 +387,7 @@ public class StorageService implements I
 logger_.info(Loading persisted ring state);
 for (Map.EntryToken, InetAddress entry : 
SystemTable.loadTokens().entrySet())
 {
-if (entry.getValue() == FBUtilities.getBroadcastAddress())
+if (entry.getValue() == FBUtilities.getLocalAddress())
 {
 // entry has been mistakenly added, delete it
 SystemTable.removeToken(entry.getKey());

svn commit: r1212631 - in /cassandra/branches/cassandra-1.0: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/db/ src/java/org/apache/cassandra/gms/ src

2011-12-09 Thread Peter Schuller (Issue Comment Edited) (JIRA)

Author: brandonwilliams
Date: Fri Dec  9 21:02:49 2011
New Revision: 1212631

URL: http://svn.apache.org/viewvc?rev=1212631view=rev
Log:
Merge 3485 from 0.8

Modified:
cassandra/branches/cassandra-1.0/   (props changed)
cassandra/branches/cassandra-1.0/CHANGES.txt
cassandra/branches/cassandra-1.0/contrib/   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java
   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java
   (props changed)

cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java
   (props changed)

cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/db/SystemTable.java

cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/gms/Gossiper.java

cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/service/StorageService.java

Propchange: cassandra/branches/cassandra-1.0/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Dec  9 21:02:49 2011
@@ -1,7 +1,7 @@
 
/cassandra/branches/cassandra-0.6:922689-1052356,1052358-1053452,1053454,1053456-1131291
 /cassandra/branches/cassandra-0.7:1026516-1211709
 /cassandra/branches/cassandra-0.7.0:1053690-1055654
-/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1212552
+/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1212552,1212624
 /cassandra/branches/cassandra-0.8.0:1125021-1130369
 /cassandra/branches/cassandra-0.8.1:1101014-1125018
 /cassandra/branches/cassandra-1.0:1167106,1167185

Modified: cassandra/branches/cassandra-1.0/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/CHANGES.txt?rev=1212631r1=1212630r2=1212631view=diff
==
--- cassandra/branches/cassandra-1.0/CHANGES.txt (original)
+++ cassandra/branches/cassandra-1.0/CHANGES.txt Fri Dec  9 21:02:49 2011
@@ -32,6 +32,7 @@ Merged from 0.8:
(CASSANDRA-3573)
  * Check for 0.0.0.0 is incorrect in CFIF (CASSANDRA-3584)
  * Increase vm.max_map_count in debian packaging (CASSANDRA-3563)
+ * gossiper will never add itself to saved endpoints (CASSANDRA-3485)
 
 
 1.0.5

Propchange: cassandra/branches/cassandra-1.0/contrib/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Dec  9 21:02:49 2011
@@ -1,7 +1,7 @@
 
/cassandra/branches/cassandra-0.6/contrib:922689-1052356,1052358-1053452,1053454,1053456-1068009
 /cassandra/branches/cassandra-0.7/contrib:1026516-1211709
 /cassandra/branches/cassandra-0.7.0/contrib:1053690-1055654
-/cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1212552
+/cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1212552,1212624
 /cassandra/branches/cassandra-0.8.0/contrib:1125021-1130369
 /cassandra/branches/cassandra-0.8.1/contrib:1101014-1125018
 /cassandra/branches/cassandra-1.0/contrib:1167106,1167185

Propchange: 
cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Dec  9 21:02:49 2011
@@ -1,7 +1,7 @@
 
/cassandra/branches/cassandra-0.6/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:922689-1052356,1052358-1053452,1053454,1053456-1131291
 
/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1026516-1211709
 
/cassandra/branches/cassandra-0.7.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1053690-1055654
-/cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1090934-1125013,1125019-1212552
+/cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1090934-1125013,1125019-1212552,1212624
 
/cassandra/branches/cassandra-0.8.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1125021-1130369
 
/cassandra/branches/cassandra-0.8.1/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1101014-1125018
 
/cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167106,1167185

Propchange: 
cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Dec  9 21:02:49 2011

buildbot success in ASF Buildbot on cassandra-0.8

2011-12-09 Thread buildbot

The Buildbot has detected a restored build on builder cassandra-0.8 while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/cassandra-0.8/builds/95

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch cassandra/branches/cassandra-0.8] 1212627
Blamelist: brandonwilliams

Build succeeded!

sincerely,
 -The Buildbot

[jira] [Updated] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

2011-12-09 Thread Brandon Williams (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-3485:


Fix Version/s: 1.0.6

 Gossiper.addSavedEndpoint should never add itself
 -

 Key: CASSANDRA-3485
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.7 beta 3
Reporter: Brandon Williams
Assignee: Brandon Williams
 Fix For: 0.8.9, 1.0.6

 Attachments: 3485.txt


 Somehow, people are running into a situation where nodes are adding 
 themselves to the persisted ring cache.  Since SS is initialized after the 
 Gossiper and calls addSavedEndpoint on it, which inits the nodes with a 
 generation of zero, this ends up with nodes using a generation of zero and 
 thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-3070) counter repair

2011-12-09 Thread Peter Schuller (Updated) (JIRA)

[
https://issues.apache.org/jira/browse/CASSANDRA-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Peter Schuller updated CASSANDRA-3070:
--

Comment: was deleted

(was: This may be relevant, quoting myself from IRC:

{code}
21:20:01 scode pcmanus: Hey, are you there?

21:20:21 scode pcmanus: I am
investigating something which might be
https://issues.apache.org/jira/browse/CASSANDRA-3070
21:20:37 scode pcmanus: And
I could use the help of someone with his brain all over counters, and Stu isn't
here atm. :)
21:21:16 scode pcmanus:
https://gist.github.com/8202cb46c8bd00c8391b

21:21:37 scode pcmanus: I am investigating why with CL.ALL and
CL.QUORUM, I get seemingly random/varying results when I read a counter.
21:21:53 scode
pcmanus: I have the offending sstables on a three-node test setup and am
inserting debug printouts in the code to trace the reconiliation.
21:21:57 scode pcmanus: The gist above shows
what's happening.

21:22:11 scode pcmanus: The latter is the wrong one, and the former is the
correct one.
21:22:28 scode pcmanus: The
interesting bit is that I see shards with the same node_id *AND* clock, but
*DIFFERENT* counts.
21:22:53 scode pcmanus: My understanding of counters is that
there should never (globally across an entire cluster in all sstables) exist
two shards for the same node_id+clock but with different
counts.

21:22:57 scode pcmanus: Is my understanding correct
there?
21:25:10
scode pcmanus: There is one node out of the three that has the offending
card (with a count of 2 instead of 1). Like with 3070, we observed this after
having expanded a cluster (though I'm not sure how that would cause it, and we
don't know if there existed a problem before the expansion).
{code}
)

counter repair
--

Key: CASSANDRA-3070
URL: https://issues.apache.org/jira/browse/CASSANDRA-3070
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.8.4
Reporter: ivan
Assignee: Sylvain Lebresne
Attachments: counter_local_quroum_maybeschedulerepairs.txt,
counter_local_quroum_maybeschedulerepairs_2.txt,
counter_local_quroum_maybeschedulerepairs_3.txt

Hi!
We have some counters out of sync but repair doesn't sync values.
We tried nodetool repair.
We use LOCAL_QUORUM for read. A repair row mutation is sent to other nodes
while reading a bad row but counters wasn't repaired by mutation.
Output of two nodes were uploaded. (Some new debug messages were added.)

[jira] [Commented] (CASSANDRA-3070) counter repair

2011-12-09 Thread Peter Schuller (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/CASSANDRA-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166617#comment-13166617
]

Peter Schuller commented on CASSANDRA-3070:
---

This may be relevant, quoting myself from IRC:

{quote}
21:20:01 scode pcmanus: Hey, are you there?

counter repair
--

[jira] [Issue Comment Edited] (CASSANDRA-3070) counter repair

[
https://issues.apache.org/jira/browse/CASSANDRA-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166617#comment-13166617
]

Peter Schuller edited comment on CASSANDRA-3070 at 12/9/11 10:19 PM:
-

This may be relevant, quoting myself from IRC:

{code}
21:20:01 scode pcmanus: Hey, are you there?

was (Author: scode):
This may be relevant, quoting myself from IRC:

{quote}
21:20:01 scode pcmanus: Hey, are you there?

[jira] [Commented] (CASSANDRA-3101) Should check for errors when calling /bin/ln

2011-12-09 Thread paul cannon (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166657#comment-13166657
 ] 

paul cannon commented on CASSANDRA-3101:


The following imports appear to be unused, and should probably be removed:

{code}
import java.io.BufferedInputStream;
import java.io.DataInputStream;
import java.io.InputStream;
import sun.misc.IOUtils;
{code}

Also, why add the logger.error() call in createHardLink, but not in 
createHardLinkWithExec? seems like if we want to know about the error in the C* 
log in the first case, we'd also want to know about it in the second case.

As a less important point, I wonder if it isn't worth modifying the existing 
hard-linking code a bit: cmd /c mklink /H seems a much more clunky way to 
make a hard link, and I think the logic is backwards: fsutil hardlink create 
is supported in all Windows versions since Windows Server 2000, except XP. 
Maybe the osversion comparison was meant to use cmd /c mklink /H in the 
Windows XP or less case, not Windows Vista or later.

Tested on Windows 7, though, after mounting a USB drive at the snapshots dir 
and trying to snapshot that keyspace. Error showed up correctly with output to 
nodetool, although no errors showed in the c* log.

 Should check for errors when calling /bin/ln
 

 Key: CASSANDRA-3101
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3101
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 0.4
Reporter: paul cannon
Assignee: Vijay
Priority: Minor
  Labels: lhf
 Fix For: 1.0.6

 Attachments: 0001-3101-throw-IOE-while-calling-bin-ln.patch


 It looks like cassandra.utils.CLibrary.createHardLinkWithExec() does not 
 check for any errors in the execution of the hard-link-making utility. This 
 could be bad if, for example, the user has put the snapshot directory on a 
 different filesystem from the data directory. The hard linking would fail and 
 the sstable snapshots would not exist, but no error would be reported.
 It does look like errors with the more direct JNA link() call are handled 
 correctly- an exception is thrown. The WithExec version should probably do 
 the same thing.
 Definitely it would be enough to check the process exit value from /bin/ln 
 for nonzero in the *nix case, but I don't know whether 'fsutil hardlink 
 create' or 'cmd /c mklink /H' return nonzero on failure.
 For bonus points, use any output from the Process's error stream in the text 
 of the exception, to aid in debugging problems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3585) Intermittent exceptions seen in cassandra 1.0.5 during Reads.

2011-12-09 Thread Jonathan Ellis (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166673#comment-13166673
 ] 

Jonathan Ellis commented on CASSANDRA-3585:
---

Brandon wrote a script 
(http://aep.appspot.com/display/PWH-9bzElErPO9ydpC2ay3I5Jys/) to check for the 
counterpart of this broken response -- a request sent to .234 that did NOT get 
a response.  But nothing like that is in the logs, everything else matches up.

 Intermittent exceptions seen in cassandra 1.0.5 during Reads.
 -

 Key: CASSANDRA-3585
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3585
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.5
 Environment: RHEL 2.6.32-71.el6.x86_64.
 RAM - 28GB
 11 CPUs of 2.6GHz
Reporter: Shantanu
 Attachments: 3585-v2.txt, 3585.txt, CassandraLogs.tar.bz2, 
 metap_system.log.zip, metap_system.log.zip


 In my test setup I have cassandra db provisioned with cassandra 0.8.7. The 
 setup is of two data centers. I have upgraded the cassandra to the latest 
 version 1.0.5. I'm seeing following exceptions in cassandra logs -
 ERROR [RequestResponseStage:32] 2011-12-06 14:46:08,150 
 AbstractCassandraDaemon.java (line 133) Fatal exception in thread 
 Thread[RequestResponseStage:32,5,main]
 java.io.IOError: java.io.EOFException
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:71)
 at org.apache.cassandra.service.ReadCallback.response(ReadCallback.java:126)
 at 
 org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:45)
 at 
 org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:59)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.io.EOFException
 at java.io.DataInputStream.readFully(DataInputStream.java:180)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:100)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:81)
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:64)
 ... 6 more
 RF is set to DC1:3,DC2:3 and I/m doing the operations with CL=Local_Quorum.
 I have run nodetool scrub on all the nodes in the ring to verify if it solves 
 the issue but it didn't.
 Thanks,
 Shantanu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3585) Intermittent exceptions seen in cassandra 1.0.5 during Reads.

2011-12-09 Thread Jonathan Ellis (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166674#comment-13166674
 ] 

Jonathan Ellis commented on CASSANDRA-3585:
---

Shantanu, do you have encryption enabled?

 Intermittent exceptions seen in cassandra 1.0.5 during Reads.
 -

 Key: CASSANDRA-3585
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3585
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.5
 Environment: RHEL 2.6.32-71.el6.x86_64.
 RAM - 28GB
 11 CPUs of 2.6GHz
Reporter: Shantanu
 Attachments: 3585-v2.txt, 3585.txt, CassandraLogs.tar.bz2, 
 metap_system.log.zip, metap_system.log.zip


 In my test setup I have cassandra db provisioned with cassandra 0.8.7. The 
 setup is of two data centers. I have upgraded the cassandra to the latest 
 version 1.0.5. I'm seeing following exceptions in cassandra logs -
 ERROR [RequestResponseStage:32] 2011-12-06 14:46:08,150 
 AbstractCassandraDaemon.java (line 133) Fatal exception in thread 
 Thread[RequestResponseStage:32,5,main]
 java.io.IOError: java.io.EOFException
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:71)
 at org.apache.cassandra.service.ReadCallback.response(ReadCallback.java:126)
 at 
 org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:45)
 at 
 org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:59)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.io.EOFException
 at java.io.DataInputStream.readFully(DataInputStream.java:180)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:100)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:81)
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:64)
 ... 6 more
 RF is set to DC1:3,DC2:3 and I/m doing the operations with CL=Local_Quorum.
 I have run nodetool scrub on all the nodes in the ring to verify if it solves 
 the issue but it didn't.
 Thanks,
 Shantanu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3585) Intermittent exceptions seen in cassandra 1.0.5 during Reads.

2011-12-09 Thread Shantanu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166677#comment-13166677
 ] 

Shantanu commented on CASSANDRA-3585:
-

No, the internode encryption is set to none.

 Intermittent exceptions seen in cassandra 1.0.5 during Reads.
 -

 Key: CASSANDRA-3585
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3585
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.5
 Environment: RHEL 2.6.32-71.el6.x86_64.
 RAM - 28GB
 11 CPUs of 2.6GHz
Reporter: Shantanu
 Attachments: 3585-v2.txt, 3585.txt, CassandraLogs.tar.bz2, 
 metap_system.log.zip, metap_system.log.zip


 In my test setup I have cassandra db provisioned with cassandra 0.8.7. The 
 setup is of two data centers. I have upgraded the cassandra to the latest 
 version 1.0.5. I'm seeing following exceptions in cassandra logs -
 ERROR [RequestResponseStage:32] 2011-12-06 14:46:08,150 
 AbstractCassandraDaemon.java (line 133) Fatal exception in thread 
 Thread[RequestResponseStage:32,5,main]
 java.io.IOError: java.io.EOFException
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:71)
 at org.apache.cassandra.service.ReadCallback.response(ReadCallback.java:126)
 at 
 org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:45)
 at 
 org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:59)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.io.EOFException
 at java.io.DataInputStream.readFully(DataInputStream.java:180)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:100)
 at 
 org.apache.cassandra.db.ReadResponseSerializer.deserialize(ReadResponse.java:81)
 at 
 org.apache.cassandra.service.AbstractRowResolver.preprocess(AbstractRowResolver.java:64)
 ... 6 more
 RF is set to DC1:3,DC2:3 and I/m doing the operations with CL=Local_Quorum.
 I have run nodetool scrub on all the nodes in the ring to verify if it solves 
 the issue but it didn't.
 Thanks,
 Shantanu

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3604) Bad code in org.apache.cassandra.cql.QueryProcessor


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166734#comment-13166734
 ] 

Zoltan Farkas commented on CASSANDRA-3604:
--

similar issue also on line:214:
if (rows.get(lastIndex).key.key.equals(finishKey))
rows.remove(lastIndex);

 Bad code in org.apache.cassandra.cql.QueryProcessor
 ---

 Key: CASSANDRA-3604
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3604
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas
   Original Estimate: 5m
  Remaining Estimate: 5m

 line 206:
 if (rows.get(0).key.key.equals(startKey))
 rows.remove(0);
 the equals will always return false because object of different types are 
 compared

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (CASSANDRA-3604) Bad code in org.apache.cassandra.cql.QueryProcessor

2011-12-09 Thread Zoltan Farkas (Created) (JIRA)

Bad code in org.apache.cassandra.cql.QueryProcessor
---

 Key: CASSANDRA-3604
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3604
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas


line 206:
if (rows.get(0).key.key.equals(startKey))
rows.remove(0);

the equals will always return false because object of different types are 
compared

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (CASSANDRA-3605) Exception swallowing in Hex.java

2011-12-09 Thread Zoltan Farkas (Created) (JIRA)

Exception swallowing in Hex.java


 Key: CASSANDRA-3605
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3605
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas
Priority: Minor


org.apache.cassandra.utils.Hex line 94:

try
{
s = stringConstructor.newInstance(0, c.length, c);
}
catch (Exception e)
{
// Swallowing as we'll just use a copying constructor
}

this code does not comply with coding standard, caught exception needs to be 
rethrown as RuntimeException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CASSANDRA-3606) Resource Leaks in code


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis resolved CASSANDRA-3606.
---

Resolution: Invalid

I spot-checked SSLFactory and the Stream in question is indeed closed in a 
finally block.

Most of the rest are in Test code and as such leaking is a non-issue.

 Resource Leaks in code
 --

 Key: CASSANDRA-3606
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3606
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
Reporter: Zoltan Farkas
   Original Estimate: 1h
  Remaining Estimate: 1h

 at the following locations:
 At SSLFactory:[line 87]
 At SSTableExportTest:[line 83]
 At CommitLogTest:[line 191]
 At KeyGenerator:[line 108]
 At Ec2Snitch.java:[line 74]
 At SSTableExportTest.java:[line 83]
 At CassandraServer.java:[line 1164]
 At CommitLogTest.java:[line 191]
 At ByteBufferUtilTest.java:[line 194]
 At LazilyCompactedRowTest.java:[line 108]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CASSANDRA-3604) Bad code in org.apache.cassandra.cql.QueryProcessor


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis resolved CASSANDRA-3604.
---

Resolution: Invalid

All the objects in question are ByteBuffers.

 Bad code in org.apache.cassandra.cql.QueryProcessor
 ---

 Key: CASSANDRA-3604
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3604
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas
   Original Estimate: 5m
  Remaining Estimate: 5m

 line 206:
 if (rows.get(0).key.key.equals(startKey))
 rows.remove(0);
 the equals will always return false because object of different types are 
 compared

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CASSANDRA-3605) Exception swallowing in Hex.java


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis resolved CASSANDRA-3605.
---

Resolution: Invalid

As the comment notes, this exception is handled by the post-try block null 
check.  Throwing a RuntimeException instead would create a bug.

 Exception swallowing in Hex.java
 

 Key: CASSANDRA-3605
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3605
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas
Priority: Minor

 org.apache.cassandra.utils.Hex line 94:
 try
 {
 s = stringConstructor.newInstance(0, c.length, c);
 }
 catch (Exception e)
 {
 // Swallowing as we'll just use a copying constructor
 }
 this code does not comply with coding standard, caught exception needs to be 
 rethrown as RuntimeException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3606) Resource Leaks in code


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166758#comment-13166758
 ] 

Zoltan Farkas commented on CASSANDRA-3606:
--

the code can still leak, see comment:
   
 FileInputStream tsf = new FileInputStream(options.truststore);
 // next line can throw a exception (FileNotFoundException) and then tsf will 
leak
FileInputStream ksf = new FileInputStream(options.keystore);
SSLContext ctx;
try
{
...
}
catch (Exception e)
{
throw new IOException(Error creating the initializing the SSL 
Context, e);
}
finally
{
FileUtils.closeQuietly(tsf);
FileUtils.closeQuietly(ksf);
}

the following is a better implementation:

 FileInputStream tsf = new FileInputStream(options.truststore);
  try {
FileInputStream ksf = new FileInputStream(options.keystore);
SSLContext ctx;
try
{
...
}
catch (Exception e)
{
throw new IOException(Error creating the initializing the SSL 
Context, e);
}
   } finally {
ksf.close();
   }
   } finally
{
tsf.close()
 }

In general I am in favor having the test code at the same quality...


 Resource Leaks in code
 --

 Key: CASSANDRA-3606
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3606
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
Reporter: Zoltan Farkas
   Original Estimate: 1h
  Remaining Estimate: 1h

 at the following locations:
 At SSLFactory:[line 87]
 At SSTableExportTest:[line 83]
 At CommitLogTest:[line 191]
 At KeyGenerator:[line 108]
 At Ec2Snitch.java:[line 74]
 At SSTableExportTest.java:[line 83]
 At CassandraServer.java:[line 1164]
 At CommitLogTest.java:[line 191]
 At ByteBufferUtilTest.java:[line 194]
 At LazilyCompactedRowTest.java:[line 108]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (CASSANDRA-3604) Bad code in org.apache.cassandra.cql.QueryProcessor

2011-12-09 Thread Zoltan Farkas (Reopened) (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoltan Farkas reopened CASSANDRA-3604:
--


see my comment

 Bad code in org.apache.cassandra.cql.QueryProcessor
 ---

 Key: CASSANDRA-3604
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3604
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas
   Original Estimate: 5m
  Remaining Estimate: 5m

 line 206:
 if (rows.get(0).key.key.equals(startKey))
 rows.remove(0);
 the equals will always return false because object of different types are 
 compared

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (CASSANDRA-3606) Resource Leaks in code

2011-12-09 Thread Zoltan Farkas (Reopened) (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoltan Farkas reopened CASSANDRA-3606:
--


See my comment

 Resource Leaks in code
 --

 Key: CASSANDRA-3606
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3606
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
Reporter: Zoltan Farkas
   Original Estimate: 1h
  Remaining Estimate: 1h

 at the following locations:
 At SSLFactory:[line 87]
 At SSTableExportTest:[line 83]
 At CommitLogTest:[line 191]
 At KeyGenerator:[line 108]
 At Ec2Snitch.java:[line 74]
 At SSTableExportTest.java:[line 83]
 At CassandraServer.java:[line 1164]
 At CommitLogTest.java:[line 191]
 At ByteBufferUtilTest.java:[line 194]
 At LazilyCompactedRowTest.java:[line 108]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3604) Bad code in org.apache.cassandra.cql.QueryProcessor


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166762#comment-13166762
 ] 

Zoltan Farkas commented on CASSANDRA-3604:
--

that is not correct:

 if (rows.get(0).key.key.equals(startKey))
rows.remove(0);

rows is of type Listorg.apache.cassandra.db.Row

org.apache.cassandra.db.Row.key is of type DecoratedKey?

DecoratedKey?.key is of type ByteBuffer

startKey is of type RowPosition 

as such

ByteBuffer is compared with a RowPosition

can you please explain how startKey is of type ByteBuffer ?

 Bad code in org.apache.cassandra.cql.QueryProcessor
 ---

 Key: CASSANDRA-3604
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3604
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas
   Original Estimate: 5m
  Remaining Estimate: 5m

 line 206:
 if (rows.get(0).key.key.equals(startKey))
 rows.remove(0);
 the equals will always return false because object of different types are 
 compared

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3605) Exception swallowing in Hex.java


[ 
https://issues.apache.org/jira/browse/CASSANDRA-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166766#comment-13166766
 ] 

Zoltan Farkas commented on CASSANDRA-3605:
--

Hmm, as long as the JDK implementation of String does not change it would not 
be a bug.

I assume this optimization is quite important, the fact the the optimization 
actually is not used is lost...

would it be worth to add a test in a static initialization of this class to 
test the existence and functionality of the private constructor and log a 
warning that optimization is not used?

cheers!

 Exception swallowing in Hex.java
 

 Key: CASSANDRA-3605
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3605
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas
Priority: Minor

 org.apache.cassandra.utils.Hex line 94:
 try
 {
 s = stringConstructor.newInstance(0, c.length, c);
 }
 catch (Exception e)
 {
 // Swallowing as we'll just use a copying constructor
 }
 this code does not comply with coding standard, caught exception needs to be 
 rethrown as RuntimeException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (CASSANDRA-3607) Iterating through HashMap via key set instead of entry set

2011-12-09 Thread Zoltan Farkas (Created) (JIRA)

Iterating through HashMap via key set instead of entry set
--

 Key: CASSANDRA-3607
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3607
 Project: Cassandra
  Issue Type: Improvement
 Environment: all
Reporter: Zoltan Farkas
Priority: Trivial


At StorageService.java:[line 2635]
At StorageService.java:[line 2687]
At SSTableImport.java:[line 286]
At CliClient.java:[line 2138]



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CASSANDRA-3604) Bad code in org.apache.cassandra.cql.QueryProcessor


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis resolved CASSANDRA-3604.
---

Resolution: Invalid

ByteBuffer startKey, line 155

 Bad code in org.apache.cassandra.cql.QueryProcessor
 ---

 Key: CASSANDRA-3604
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3604
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas
   Original Estimate: 5m
  Remaining Estimate: 5m

 line 206:
 if (rows.get(0).key.key.equals(startKey))
 rows.remove(0);
 the equals will always return false because object of different types are 
 compared

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3604) Bad code in org.apache.cassandra.cql.QueryProcessor