[jira] [Updated] (CASSANDRA-5094) Should not reset local schema when there is no other nodes to resync

2012-12-28 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-5094:
--

Reviewer: brandon.williams

Personally I think the current behavior works as designed, and I'm reluctant to 
complicate it further by trying to guess what the user really wants in the 
face of an explicit instruction to drop the schema.

Brandon?

 Should not reset local schema when there is no other nodes to resync
 

 Key: CASSANDRA-5094
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5094
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.1.7
Reporter: Manoj Kanta Mainali
 Attachments: trunk-CASSANDRA-5094.txt


 The nodetool resetlocalschema allows to drop the schema from a node. But, it 
 does not check whether there are other nodes present or not to resync the 
 schema from. That means, if there is only one instance, whether it is a 
 single node or a cluster but other nodes were down, and we reset the local 
 schema the instance will not be able to resync from other nodes. In that 
 case, the node will not be able to serve requests. I haven't confirmed the 
 behavior, i.e. whether the instance will get the schema or not, when other 
 nodes in the cluster come back. However, in a single node cluster it will 
 never be able to resync itself. 
 It is better to check whether there are other nodes or not to resync from, 
 and do not clear the schemas if there are none.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5093) Wrong bloom_filter_fp_chance for newly created CFs with LeveledCompactionStrategy

2012-12-28 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540485#comment-13540485
 ] 

Jonathan Ellis commented on CASSANDRA-5093:
---

+1

 Wrong bloom_filter_fp_chance for newly created CFs with 
 LeveledCompactionStrategy
 -

 Key: CASSANDRA-5093
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5093
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.2.0 rc2
Reporter: Aleksey Yeschenko
Assignee: Aleksey Yeschenko
Priority: Minor
 Fix For: 1.2.0

 Attachments: 5093.txt


 0.1 is supposed to be the default bloom_filter_fp_chance for 
 LeveledCompactionStrategy (and 0.01 for all other strategies).
 However, CFPropDefs#applyToCFMetadata() sets bloom_filter_fp_chance before 
 setting compaction strategy class, so the default bloom_filter_fp_chance is 
 always 0.01 no matter what the compaction strategy is.
 The fix is to move cfm#bloomFilterFpChance() call below 
 cfm#compressionParameters().
 The attached patch also kills dead default consistency level-related code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


git commit: fix default bloom_filter_fp_chance for LeveledCompactionStrategy; patch by Aleksey Yeschenko, reviewed by Jonathan Ellis for CASSANDRA-5093

2012-12-28 Thread aleksey
Updated Branches:
  refs/heads/cassandra-1.2.0 14d62ab11 - 1772b1c2e


fix default bloom_filter_fp_chance for LeveledCompactionStrategy;
patch by Aleksey Yeschenko, reviewed by Jonathan Ellis for
CASSANDRA-5093


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1772b1c2
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1772b1c2
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1772b1c2

Branch: refs/heads/cassandra-1.2.0
Commit: 1772b1c2ecea1f2a167aef2c572d5543cd3ea4a0
Parents: 14d62ab
Author: Aleksey Yeschenko alek...@apache.org
Authored: Fri Dec 28 18:29:19 2012 +0300
Committer: Aleksey Yeschenko alek...@apache.org
Committed: Fri Dec 28 18:29:19 2012 +0300

--
 CHANGES.txt|1 +
 src/java/org/apache/cassandra/cql3/CFPropDefs.java |   22 ++-
 2 files changed, 4 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/1772b1c2/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 31563c6..f83009e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,6 +1,7 @@
 1.2.0
  * Disallow counters in collections (CASSANDRA-5082)
  * cqlsh: add unit tests (CASSANDRA-3920)
+ * fix default bloom_filter_fp_chance for LeveledCompactionStrategy 
(CASSANDRA-5093)
 
 
 1.2.0-rc2

http://git-wip-us.apache.org/repos/asf/cassandra/blob/1772b1c2/src/java/org/apache/cassandra/cql3/CFPropDefs.java
--
diff --git a/src/java/org/apache/cassandra/cql3/CFPropDefs.java 
b/src/java/org/apache/cassandra/cql3/CFPropDefs.java
index de613a3..2cbcfde 100644
--- a/src/java/org/apache/cassandra/cql3/CFPropDefs.java
+++ b/src/java/org/apache/cassandra/cql3/CFPropDefs.java
@@ -23,10 +23,9 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import org.apache.cassandra.config.CFMetaData;
+import org.apache.cassandra.db.compaction.AbstractCompactionStrategy;
 import org.apache.cassandra.exceptions.ConfigurationException;
 import org.apache.cassandra.exceptions.SyntaxException;
-import org.apache.cassandra.db.ConsistencyLevel;
-import org.apache.cassandra.db.compaction.AbstractCompactionStrategy;
 import org.apache.cassandra.io.compress.CompressionParameters;
 
 public class CFPropDefs extends PropertyDefinitions
@@ -117,7 +116,6 @@ public class CFPropDefs extends PropertyDefinitions
 cfm.minCompactionThreshold(toInt(KW_MINCOMPACTIONTHRESHOLD, 
getCompactionOptions().get(KW_MINCOMPACTIONTHRESHOLD), 
cfm.getMinCompactionThreshold()));
 cfm.maxCompactionThreshold(toInt(KW_MAXCOMPACTIONTHRESHOLD, 
getCompactionOptions().get(KW_MAXCOMPACTIONTHRESHOLD), 
cfm.getMaxCompactionThreshold()));
 cfm.caching(CFMetaData.Caching.fromString(getString(KW_CACHING, 
cfm.getCaching().toString(;
-cfm.bloomFilterFpChance(getDouble(KW_BF_FP_CHANCE, 
cfm.getBloomFilterFpChance()));
 
 if (compactionStrategyClass != null)
 {
@@ -125,26 +123,12 @@ public class CFPropDefs extends PropertyDefinitions
 cfm.compactionStrategyOptions(new HashMapString, 
String(getCompactionOptions()));
 }
 
+cfm.bloomFilterFpChance(getDouble(KW_BF_FP_CHANCE, 
cfm.getBloomFilterFpChance()));
+
 if (!getCompressionOptions().isEmpty())
 
cfm.compressionParameters(CompressionParameters.create(getCompressionOptions()));
 }
 
-public ConsistencyLevel getConsistencyLevel(String key) throws 
ConfigurationException, SyntaxException
-{
-String value = getSimple(key);
-if (value == null)
-return null;
-
-try
-{
-return Enum.valueOf(ConsistencyLevel.class, value);
-}
-catch (IllegalArgumentException e)
-{
-throw new ConfigurationException(String.format(Invalid 
consistency level value: %s, value));
-}
-}
-
 @Override
 public String toString()
 {



[1/2] git commit: fix default bloom_filter_fp_chance for LeveledCompactionStrategy; patch by Aleksey Yeschenko, reviewed by Jonathan Ellis for CASSANDRA-5093

2012-12-28 Thread aleksey
fix default bloom_filter_fp_chance for LeveledCompactionStrategy;
patch by Aleksey Yeschenko, reviewed by Jonathan Ellis for
CASSANDRA-5093


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1772b1c2
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1772b1c2
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1772b1c2

Branch: refs/heads/cassandra-1.2
Commit: 1772b1c2ecea1f2a167aef2c572d5543cd3ea4a0
Parents: 14d62ab
Author: Aleksey Yeschenko alek...@apache.org
Authored: Fri Dec 28 18:29:19 2012 +0300
Committer: Aleksey Yeschenko alek...@apache.org
Committed: Fri Dec 28 18:29:19 2012 +0300

--
 CHANGES.txt|1 +
 src/java/org/apache/cassandra/cql3/CFPropDefs.java |   22 ++-
 2 files changed, 4 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/1772b1c2/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 31563c6..f83009e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,6 +1,7 @@
 1.2.0
  * Disallow counters in collections (CASSANDRA-5082)
  * cqlsh: add unit tests (CASSANDRA-3920)
+ * fix default bloom_filter_fp_chance for LeveledCompactionStrategy 
(CASSANDRA-5093)
 
 
 1.2.0-rc2

http://git-wip-us.apache.org/repos/asf/cassandra/blob/1772b1c2/src/java/org/apache/cassandra/cql3/CFPropDefs.java
--
diff --git a/src/java/org/apache/cassandra/cql3/CFPropDefs.java 
b/src/java/org/apache/cassandra/cql3/CFPropDefs.java
index de613a3..2cbcfde 100644
--- a/src/java/org/apache/cassandra/cql3/CFPropDefs.java
+++ b/src/java/org/apache/cassandra/cql3/CFPropDefs.java
@@ -23,10 +23,9 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import org.apache.cassandra.config.CFMetaData;
+import org.apache.cassandra.db.compaction.AbstractCompactionStrategy;
 import org.apache.cassandra.exceptions.ConfigurationException;
 import org.apache.cassandra.exceptions.SyntaxException;
-import org.apache.cassandra.db.ConsistencyLevel;
-import org.apache.cassandra.db.compaction.AbstractCompactionStrategy;
 import org.apache.cassandra.io.compress.CompressionParameters;
 
 public class CFPropDefs extends PropertyDefinitions
@@ -117,7 +116,6 @@ public class CFPropDefs extends PropertyDefinitions
 cfm.minCompactionThreshold(toInt(KW_MINCOMPACTIONTHRESHOLD, 
getCompactionOptions().get(KW_MINCOMPACTIONTHRESHOLD), 
cfm.getMinCompactionThreshold()));
 cfm.maxCompactionThreshold(toInt(KW_MAXCOMPACTIONTHRESHOLD, 
getCompactionOptions().get(KW_MAXCOMPACTIONTHRESHOLD), 
cfm.getMaxCompactionThreshold()));
 cfm.caching(CFMetaData.Caching.fromString(getString(KW_CACHING, 
cfm.getCaching().toString(;
-cfm.bloomFilterFpChance(getDouble(KW_BF_FP_CHANCE, 
cfm.getBloomFilterFpChance()));
 
 if (compactionStrategyClass != null)
 {
@@ -125,26 +123,12 @@ public class CFPropDefs extends PropertyDefinitions
 cfm.compactionStrategyOptions(new HashMapString, 
String(getCompactionOptions()));
 }
 
+cfm.bloomFilterFpChance(getDouble(KW_BF_FP_CHANCE, 
cfm.getBloomFilterFpChance()));
+
 if (!getCompressionOptions().isEmpty())
 
cfm.compressionParameters(CompressionParameters.create(getCompressionOptions()));
 }
 
-public ConsistencyLevel getConsistencyLevel(String key) throws 
ConfigurationException, SyntaxException
-{
-String value = getSimple(key);
-if (value == null)
-return null;
-
-try
-{
-return Enum.valueOf(ConsistencyLevel.class, value);
-}
-catch (IllegalArgumentException e)
-{
-throw new ConfigurationException(String.format(Invalid 
consistency level value: %s, value));
-}
-}
-
 @Override
 public String toString()
 {



[2/2] git commit: Merge branch 'cassandra-1.2.0' into cassandra-1.2

2012-12-28 Thread aleksey
Updated Branches:
  refs/heads/cassandra-1.2 ac9f4786e - d6a3845a2


Merge branch 'cassandra-1.2.0' into cassandra-1.2


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/d6a3845a
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/d6a3845a
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/d6a3845a

Branch: refs/heads/cassandra-1.2
Commit: d6a3845a212422c26192a61fe42a3b7e21d34e10
Parents: ac9f478 1772b1c
Author: Aleksey Yeschenko alek...@apache.org
Authored: Fri Dec 28 18:32:36 2012 +0300
Committer: Aleksey Yeschenko alek...@apache.org
Committed: Fri Dec 28 18:32:36 2012 +0300

--
 CHANGES.txt|1 +
 src/java/org/apache/cassandra/cql3/CFPropDefs.java |   22 ++-
 2 files changed, 4 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/d6a3845a/CHANGES.txt
--



[3/3] git commit: Merge branch 'cassandra-1.2' into trunk

2012-12-28 Thread aleksey
Updated Branches:
  refs/heads/trunk 70e9bed7c - d07735648


Merge branch 'cassandra-1.2' into trunk

Conflicts:
src/java/org/apache/cassandra/cql3/CFPropDefs.java


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/d0773564
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/d0773564
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/d0773564

Branch: refs/heads/trunk
Commit: d07735648a6d72eb04f7c3ae8d8435409a017f80
Parents: 70e9bed d6a3845
Author: Aleksey Yeschenko alek...@apache.org
Authored: Fri Dec 28 18:37:20 2012 +0300
Committer: Aleksey Yeschenko alek...@apache.org
Committed: Fri Dec 28 18:37:20 2012 +0300

--
 CHANGES.txt|1 +
 src/java/org/apache/cassandra/cql3/CFPropDefs.java |   20 +-
 2 files changed, 3 insertions(+), 18 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/d0773564/CHANGES.txt
--

http://git-wip-us.apache.org/repos/asf/cassandra/blob/d0773564/src/java/org/apache/cassandra/cql3/CFPropDefs.java
--
diff --cc src/java/org/apache/cassandra/cql3/CFPropDefs.java
index 095de04,2cbcfde..cbe1561
--- a/src/java/org/apache/cassandra/cql3/CFPropDefs.java
+++ b/src/java/org/apache/cassandra/cql3/CFPropDefs.java
@@@ -132,9 -116,6 +131,8 @@@ public class CFPropDefs extends Propert
  cfm.minCompactionThreshold(toInt(KW_MINCOMPACTIONTHRESHOLD, 
getCompactionOptions().get(KW_MINCOMPACTIONTHRESHOLD), 
cfm.getMinCompactionThreshold()));
  cfm.maxCompactionThreshold(toInt(KW_MAXCOMPACTIONTHRESHOLD, 
getCompactionOptions().get(KW_MAXCOMPACTIONTHRESHOLD), 
cfm.getMaxCompactionThreshold()));
  cfm.caching(CFMetaData.Caching.fromString(getString(KW_CACHING, 
cfm.getCaching().toString(;
 +cfm.defaultTimeToLive(getInt(KW_DEFAULT_TIME_TO_LIVE, 
cfm.getDefaultTimeToLive()));
- cfm.bloomFilterFpChance(getDouble(KW_BF_FP_CHANCE, 
cfm.getBloomFilterFpChance()));
 +cfm.memtableFlushPeriod(getInt(KW_MEMTABLE_FLUSH_PERIOD, 
cfm.getMemtableFlushPeriod()));
  
  if (compactionStrategyClass != null)
  {



[1/3] git commit: fix default bloom_filter_fp_chance for LeveledCompactionStrategy; patch by Aleksey Yeschenko, reviewed by Jonathan Ellis for CASSANDRA-5093

2012-12-28 Thread aleksey
fix default bloom_filter_fp_chance for LeveledCompactionStrategy;
patch by Aleksey Yeschenko, reviewed by Jonathan Ellis for
CASSANDRA-5093


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1772b1c2
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1772b1c2
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1772b1c2

Branch: refs/heads/trunk
Commit: 1772b1c2ecea1f2a167aef2c572d5543cd3ea4a0
Parents: 14d62ab
Author: Aleksey Yeschenko alek...@apache.org
Authored: Fri Dec 28 18:29:19 2012 +0300
Committer: Aleksey Yeschenko alek...@apache.org
Committed: Fri Dec 28 18:29:19 2012 +0300

--
 CHANGES.txt|1 +
 src/java/org/apache/cassandra/cql3/CFPropDefs.java |   22 ++-
 2 files changed, 4 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/1772b1c2/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 31563c6..f83009e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,6 +1,7 @@
 1.2.0
  * Disallow counters in collections (CASSANDRA-5082)
  * cqlsh: add unit tests (CASSANDRA-3920)
+ * fix default bloom_filter_fp_chance for LeveledCompactionStrategy 
(CASSANDRA-5093)
 
 
 1.2.0-rc2

http://git-wip-us.apache.org/repos/asf/cassandra/blob/1772b1c2/src/java/org/apache/cassandra/cql3/CFPropDefs.java
--
diff --git a/src/java/org/apache/cassandra/cql3/CFPropDefs.java 
b/src/java/org/apache/cassandra/cql3/CFPropDefs.java
index de613a3..2cbcfde 100644
--- a/src/java/org/apache/cassandra/cql3/CFPropDefs.java
+++ b/src/java/org/apache/cassandra/cql3/CFPropDefs.java
@@ -23,10 +23,9 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import org.apache.cassandra.config.CFMetaData;
+import org.apache.cassandra.db.compaction.AbstractCompactionStrategy;
 import org.apache.cassandra.exceptions.ConfigurationException;
 import org.apache.cassandra.exceptions.SyntaxException;
-import org.apache.cassandra.db.ConsistencyLevel;
-import org.apache.cassandra.db.compaction.AbstractCompactionStrategy;
 import org.apache.cassandra.io.compress.CompressionParameters;
 
 public class CFPropDefs extends PropertyDefinitions
@@ -117,7 +116,6 @@ public class CFPropDefs extends PropertyDefinitions
 cfm.minCompactionThreshold(toInt(KW_MINCOMPACTIONTHRESHOLD, 
getCompactionOptions().get(KW_MINCOMPACTIONTHRESHOLD), 
cfm.getMinCompactionThreshold()));
 cfm.maxCompactionThreshold(toInt(KW_MAXCOMPACTIONTHRESHOLD, 
getCompactionOptions().get(KW_MAXCOMPACTIONTHRESHOLD), 
cfm.getMaxCompactionThreshold()));
 cfm.caching(CFMetaData.Caching.fromString(getString(KW_CACHING, 
cfm.getCaching().toString(;
-cfm.bloomFilterFpChance(getDouble(KW_BF_FP_CHANCE, 
cfm.getBloomFilterFpChance()));
 
 if (compactionStrategyClass != null)
 {
@@ -125,26 +123,12 @@ public class CFPropDefs extends PropertyDefinitions
 cfm.compactionStrategyOptions(new HashMapString, 
String(getCompactionOptions()));
 }
 
+cfm.bloomFilterFpChance(getDouble(KW_BF_FP_CHANCE, 
cfm.getBloomFilterFpChance()));
+
 if (!getCompressionOptions().isEmpty())
 
cfm.compressionParameters(CompressionParameters.create(getCompressionOptions()));
 }
 
-public ConsistencyLevel getConsistencyLevel(String key) throws 
ConfigurationException, SyntaxException
-{
-String value = getSimple(key);
-if (value == null)
-return null;
-
-try
-{
-return Enum.valueOf(ConsistencyLevel.class, value);
-}
-catch (IllegalArgumentException e)
-{
-throw new ConfigurationException(String.format(Invalid 
consistency level value: %s, value));
-}
-}
-
 @Override
 public String toString()
 {



[2/3] git commit: Merge branch 'cassandra-1.2.0' into cassandra-1.2

2012-12-28 Thread aleksey
Merge branch 'cassandra-1.2.0' into cassandra-1.2


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/d6a3845a
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/d6a3845a
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/d6a3845a

Branch: refs/heads/trunk
Commit: d6a3845a212422c26192a61fe42a3b7e21d34e10
Parents: ac9f478 1772b1c
Author: Aleksey Yeschenko alek...@apache.org
Authored: Fri Dec 28 18:32:36 2012 +0300
Committer: Aleksey Yeschenko alek...@apache.org
Committed: Fri Dec 28 18:32:36 2012 +0300

--
 CHANGES.txt|1 +
 src/java/org/apache/cassandra/cql3/CFPropDefs.java |   22 ++-
 2 files changed, 4 insertions(+), 19 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/d6a3845a/CHANGES.txt
--



[jira] [Commented] (CASSANDRA-5093) Wrong bloom_filter_fp_chance for newly created CFs with LeveledCompactionStrategy

2012-12-28 Thread Aleksey Yeschenko (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540495#comment-13540495
 ] 

Aleksey Yeschenko commented on CASSANDRA-5093:
--

Thanks, committed.

 Wrong bloom_filter_fp_chance for newly created CFs with 
 LeveledCompactionStrategy
 -

 Key: CASSANDRA-5093
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5093
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.2.0 rc2
Reporter: Aleksey Yeschenko
Assignee: Aleksey Yeschenko
Priority: Minor
 Fix For: 1.2.0

 Attachments: 5093.txt


 0.1 is supposed to be the default bloom_filter_fp_chance for 
 LeveledCompactionStrategy (and 0.01 for all other strategies).
 However, CFPropDefs#applyToCFMetadata() sets bloom_filter_fp_chance before 
 setting compaction strategy class, so the default bloom_filter_fp_chance is 
 always 0.01 no matter what the compaction strategy is.
 The fix is to move cfm#bloomFilterFpChance() call below 
 cfm#compressionParameters().
 The attached patch also kills dead default consistency level-related code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (CASSANDRA-5013) disallow bloom filter false positive chance of 0

2012-12-28 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-5013:
--

Reviewer: brandon.williams  (was: jbellis)
Assignee: Jonathan Ellis  (was: Brandon Williams)

 disallow bloom filter false positive chance of 0
 

 Key: CASSANDRA-5013
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5013
 Project: Cassandra
  Issue Type: Bug
  Components: Config
Reporter: Matthew F. Dennis
Assignee: Jonathan Ellis
Priority: Minor
 Fix For: 1.2.1

 Attachments: 5013.txt, 5013-v2.txt


 {pre}
 ERROR [CompactionExecutor:16] 2012-11-30 08:44:32,546 SSTableWriter.java 
 (line 414) Bloom filter FP chance of zero isn't supposed to happen
 {pre}
 when attempting to set it to zero, C* should either disallow the change or 
 should just interpret 0 as make it the default and not continually log the 
 above error message

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5077) Simplify CompactionIterable.getReduced

2012-12-28 Thread Yuki Morishita (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540511#comment-13540511
 ] 

Yuki Morishita commented on CASSANDRA-5077:
---

Patch looks good, +1.

 Simplify CompactionIterable.getReduced
 --

 Key: CASSANDRA-5077
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5077
 Project: Cassandra
  Issue Type: Improvement
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
 Fix For: 1.2.1

 Attachments: 5077-close-writers.txt, 5077.txt, 5077.txt


 CompactionIterable turns empty rows into null, and 
 purge-compacted-rows-from-cache logic is duplicated (and different!) across 
 implementations.  Let's simplify to just return empty rows as-is and let 
 CompactionTask handle the purge logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[3/3] git commit: Merge branch 'cassandra-1.2' into trunk

2012-12-28 Thread jbellis
Updated Branches:
  refs/heads/cassandra-1.2 d6a3845a2 - 1d96e32b8
  refs/heads/trunk d07735648 - 04ade2ffa


Merge branch 'cassandra-1.2' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/04ade2ff
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/04ade2ff
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/04ade2ff

Branch: refs/heads/trunk
Commit: 04ade2ffa8750d53bf4694587ed6b83697f94bda
Parents: d077356 1d96e32
Author: Jonathan Ellis jbel...@apache.org
Authored: Fri Dec 28 12:02:19 2012 -0500
Committer: Jonathan Ellis jbel...@apache.org
Committed: Fri Dec 28 12:02:19 2012 -0500

--
 .../cassandra/db/compaction/CompactionTask.java|   30 ++-
 1 files changed, 20 insertions(+), 10 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/04ade2ff/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
--



[jira] [Commented] (CASSANDRA-5077) Simplify CompactionIterable.getReduced

2012-12-28 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540519#comment-13540519
 ] 

Jonathan Ellis commented on CASSANDRA-5077:
---

committed

 Simplify CompactionIterable.getReduced
 --

 Key: CASSANDRA-5077
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5077
 Project: Cassandra
  Issue Type: Improvement
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
 Fix For: 1.2.1

 Attachments: 5077-close-writers.txt, 5077.txt, 5077.txt


 CompactionIterable turns empty rows into null, and 
 purge-compacted-rows-from-cache logic is duplicated (and different!) across 
 implementations.  Let's simplify to just return empty rows as-is and let 
 CompactionTask handle the purge logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[2/3] git commit: add threadpool size adjustment methods to JMXEnabledThreadPoolExecutor and CompactionManagerMBean patch by Carl Yeksigian; reviewed by jbellis for CASSANDRA-5044

2012-12-28 Thread jbellis
add threadpool size adjustment methods to JMXEnabledThreadPoolExecutor and 
CompactionManagerMBean
patch by Carl Yeksigian; reviewed by jbellis for CASSANDRA-5044


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8219195d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8219195d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8219195d

Branch: refs/heads/trunk
Commit: 8219195d0af457a5343c989496fca2edc4f53ff7
Parents: 1d96e32
Author: Jonathan Ellis jbel...@apache.org
Authored: Fri Dec 28 12:09:11 2012 -0500
Committer: Jonathan Ellis jbel...@apache.org
Committed: Fri Dec 28 12:09:11 2012 -0500

--
 CHANGES.txt|2 +
 .../concurrent/JMXEnabledThreadPoolExecutor.java   |   20 +++
 .../JMXEnabledThreadPoolExecutorMBean.java |   20 +++
 .../cassandra/db/compaction/CompactionManager.java |   40 +
 .../db/compaction/CompactionManagerMBean.java  |   44 +++
 5 files changed, 126 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/8219195d/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 8fee595..ca4780a 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,6 @@
 1.2.1
+ * add threadpool size adjustment methods to JMXEnabledThreadPoolExecutor and 
+   CompactionManagerMBean (CASSANDRA-5044)
  * Improve handling a changing target throttle rate mid-compaction 
(CASSANDRA-5087)
  * fix hinting for dropped local writes (CASSANDRA-4753)
  * off-heap cache doesn't need mutable column container (CASSANDRA-5057)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/8219195d/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java
--
diff --git 
a/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java 
b/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java
index 52f9453..de448b5 100644
--- a/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java
+++ b/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java
@@ -159,6 +159,26 @@ public class JMXEnabledThreadPoolExecutor extends 
DebuggableThreadPoolExecutor i
 return (int) metrics.currentBlocked.count();
 }
 
+public int getCoreThreads()
+{
+return getCorePoolSize();
+}
+
+public void setCoreThreads(int number)
+{
+setCorePoolSize(number);
+}
+
+public int getMaximumThreads()
+{
+return getMaximumPoolSize();
+}
+
+public void setMaximumThreads(int number)
+{
+setMaximumPoolSize(number);
+}
+
 @Override
 protected void onInitialRejection(Runnable task)
 {

http://git-wip-us.apache.org/repos/asf/cassandra/blob/8219195d/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
--
diff --git 
a/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
 
b/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
index 48136bc..ed2a2ac 100644
--- 
a/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
+++ 
b/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
@@ -34,4 +34,24 @@ public interface JMXEnabledThreadPoolExecutorMBean extends 
IExecutorMBean
  * the executor (because all threads are busy and the backing queue is 
full).
  */
 public int getCurrentlyBlockedTasks();
+
+/**
+ * Returns core pool size of thread pool.
+ */
+public int getCoreThreads();
+
+/**
+ * Allows user to resize core pool size of the thread pool.
+ */
+public void setCoreThreads(int number);
+
+/**
+ * Returns maximum pool size of thread pool.
+ */
+public int getMaximumThreads();
+
+/**
+ * Allows user to resize maximum size of the thread pool.
+ */
+public void setMaximumThreads(int number);
 }

http://git-wip-us.apache.org/repos/asf/cassandra/blob/8219195d/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
--
diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java 
b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
index 0a31888..4f0290f 100644
--- a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
@@ -1126,6 +1126,46 @@ public class CompactionManager implements 
CompactionManagerMBean
 }
 }
 
+public int 

[3/3] git commit: Merge branch 'cassandra-1.2' into trunk

2012-12-28 Thread jbellis
Updated Branches:
  refs/heads/cassandra-1.2 1d96e32b8 - 8219195d0
  refs/heads/trunk 04ade2ffa - e0e45a4fe


Merge branch 'cassandra-1.2' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e0e45a4f
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e0e45a4f
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e0e45a4f

Branch: refs/heads/trunk
Commit: e0e45a4fe7ebb71ebd58f9534b0e92825c63f721
Parents: 04ade2f 8219195
Author: Jonathan Ellis jbel...@apache.org
Authored: Fri Dec 28 12:09:18 2012 -0500
Committer: Jonathan Ellis jbel...@apache.org
Committed: Fri Dec 28 12:09:18 2012 -0500

--
 CHANGES.txt|2 +
 .../concurrent/JMXEnabledThreadPoolExecutor.java   |   20 +++
 .../JMXEnabledThreadPoolExecutorMBean.java |   20 +++
 .../cassandra/db/compaction/CompactionManager.java |   40 +
 .../db/compaction/CompactionManagerMBean.java  |   44 +++
 5 files changed, 126 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/e0e45a4f/CHANGES.txt
--
diff --cc CHANGES.txt
index 96b479b,ca4780a..a2e44f4
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,10 -1,6 +1,12 @@@
 +1.3
 + * make index_interval configurable per columnfamily (CASSANDRA-3961)
 + * add default_tim_to_live (CASSANDRA-3974)
 + * add memtable_flush_period_in_ms (CASSANDRA-4237)
 +
 +
  1.2.1
+  * add threadpool size adjustment methods to JMXEnabledThreadPoolExecutor and 
+CompactionManagerMBean (CASSANDRA-5044)
   * Improve handling a changing target throttle rate mid-compaction 
(CASSANDRA-5087)
   * fix hinting for dropped local writes (CASSANDRA-4753)
   * off-heap cache doesn't need mutable column container (CASSANDRA-5057)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/e0e45a4f/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
--



[1/3] git commit: add threadpool size adjustment methods to JMXEnabledThreadPoolExecutor and CompactionManagerMBean patch by Carl Yeksigian; reviewed by jbellis for CASSANDRA-5044

2012-12-28 Thread jbellis
add threadpool size adjustment methods to JMXEnabledThreadPoolExecutor and 
CompactionManagerMBean
patch by Carl Yeksigian; reviewed by jbellis for CASSANDRA-5044


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8219195d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8219195d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8219195d

Branch: refs/heads/cassandra-1.2
Commit: 8219195d0af457a5343c989496fca2edc4f53ff7
Parents: 1d96e32
Author: Jonathan Ellis jbel...@apache.org
Authored: Fri Dec 28 12:09:11 2012 -0500
Committer: Jonathan Ellis jbel...@apache.org
Committed: Fri Dec 28 12:09:11 2012 -0500

--
 CHANGES.txt|2 +
 .../concurrent/JMXEnabledThreadPoolExecutor.java   |   20 +++
 .../JMXEnabledThreadPoolExecutorMBean.java |   20 +++
 .../cassandra/db/compaction/CompactionManager.java |   40 +
 .../db/compaction/CompactionManagerMBean.java  |   44 +++
 5 files changed, 126 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/8219195d/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 8fee595..ca4780a 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,6 @@
 1.2.1
+ * add threadpool size adjustment methods to JMXEnabledThreadPoolExecutor and 
+   CompactionManagerMBean (CASSANDRA-5044)
  * Improve handling a changing target throttle rate mid-compaction 
(CASSANDRA-5087)
  * fix hinting for dropped local writes (CASSANDRA-4753)
  * off-heap cache doesn't need mutable column container (CASSANDRA-5057)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/8219195d/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java
--
diff --git 
a/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java 
b/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java
index 52f9453..de448b5 100644
--- a/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java
+++ b/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java
@@ -159,6 +159,26 @@ public class JMXEnabledThreadPoolExecutor extends 
DebuggableThreadPoolExecutor i
 return (int) metrics.currentBlocked.count();
 }
 
+public int getCoreThreads()
+{
+return getCorePoolSize();
+}
+
+public void setCoreThreads(int number)
+{
+setCorePoolSize(number);
+}
+
+public int getMaximumThreads()
+{
+return getMaximumPoolSize();
+}
+
+public void setMaximumThreads(int number)
+{
+setMaximumPoolSize(number);
+}
+
 @Override
 protected void onInitialRejection(Runnable task)
 {

http://git-wip-us.apache.org/repos/asf/cassandra/blob/8219195d/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
--
diff --git 
a/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
 
b/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
index 48136bc..ed2a2ac 100644
--- 
a/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
+++ 
b/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
@@ -34,4 +34,24 @@ public interface JMXEnabledThreadPoolExecutorMBean extends 
IExecutorMBean
  * the executor (because all threads are busy and the backing queue is 
full).
  */
 public int getCurrentlyBlockedTasks();
+
+/**
+ * Returns core pool size of thread pool.
+ */
+public int getCoreThreads();
+
+/**
+ * Allows user to resize core pool size of the thread pool.
+ */
+public void setCoreThreads(int number);
+
+/**
+ * Returns maximum pool size of thread pool.
+ */
+public int getMaximumThreads();
+
+/**
+ * Allows user to resize maximum size of the thread pool.
+ */
+public void setMaximumThreads(int number);
 }

http://git-wip-us.apache.org/repos/asf/cassandra/blob/8219195d/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
--
diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java 
b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
index 0a31888..4f0290f 100644
--- a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
@@ -1126,6 +1126,46 @@ public class CompactionManager implements 
CompactionManagerMBean
 }
 }
 
+public int 

[jira] [Updated] (CASSANDRA-5044) Allow resizing of threadpools via JMX

2012-12-28 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-5044:
--

   Reviewer: jbellis
Component/s: (was: Core)
 Tools
 Issue Type: New Feature  (was: Improvement)

 Allow resizing of threadpools via JMX
 -

 Key: CASSANDRA-5044
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5044
 Project: Cassandra
  Issue Type: New Feature
  Components: Tools
Reporter: Carl Yeksigian
Assignee: Carl Yeksigian
Priority: Minor
 Fix For: 1.2.1

 Attachments: 5044.txt


 Currently changing the size of threadpools is done using the config files. If 
 resizing a threadpool, the node needs to be taken offline.
 Adding resizing via JMX allows online tweaking. TPEs allow for moving the 
 number of threads up and down; moving down will take effect after a thread in 
 the pool becomes idle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5044) Allow resizing of threadpools via JMX

2012-12-28 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540522#comment-13540522
 ] 

Jonathan Ellis commented on CASSANDRA-5044:
---

LGTM, committed

 Allow resizing of threadpools via JMX
 -

 Key: CASSANDRA-5044
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5044
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Carl Yeksigian
Assignee: Carl Yeksigian
Priority: Minor
 Fix For: 1.2.1

 Attachments: 5044.txt


 Currently changing the size of threadpools is done using the config files. If 
 resizing a threadpool, the node needs to be taken offline.
 Adding resizing via JMX allows online tweaking. TPEs allow for moving the 
 number of threads up and down; moving down will take effect after a thread in 
 the pool becomes idle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (CASSANDRA-5044) Allow resizing of threadpools via JMX

2012-12-28 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-5044:
--

Labels: jmx  (was: )

 Allow resizing of threadpools via JMX
 -

 Key: CASSANDRA-5044
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5044
 Project: Cassandra
  Issue Type: New Feature
  Components: Tools
Reporter: Carl Yeksigian
Assignee: Carl Yeksigian
Priority: Minor
  Labels: jmx
 Fix For: 1.2.1

 Attachments: 5044.txt


 Currently changing the size of threadpools is done using the config files. If 
 resizing a threadpool, the node needs to be taken offline.
 Adding resizing via JMX allows online tweaking. TPEs allow for moving the 
 number of threads up and down; moving down will take effect after a thread in 
 the pool becomes idle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5045) Add Configuration Loader to DatabaseDescriptor

2012-12-28 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540524#comment-13540524
 ] 

Jonathan Ellis commented on CASSANDRA-5045:
---

Should we wontfix CASSANDRA-4998 then?

 Add Configuration Loader to DatabaseDescriptor
 --

 Key: CASSANDRA-5045
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5045
 Project: Cassandra
  Issue Type: New Feature
Reporter: Michael Guymon
Priority: Minor
  Labels: patch
 Attachments: 0001-Add-configuration-loader-to-DatabaseDescriptor.patch


 Based on feed back from CASSANDRA-4998 -
 Added IConfigurationLoader that is used to load an external Config. When the 
 System Property cassandra.config.loader is defined with an implementing 
 class, DatabaseDescriptor with will that Config over loading the 
 cassandra.yaml. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (CASSANDRA-5045) Add Configuration Loader to DatabaseDescriptor

2012-12-28 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-5045:
--

Reviewer: slebresne

 Add Configuration Loader to DatabaseDescriptor
 --

 Key: CASSANDRA-5045
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5045
 Project: Cassandra
  Issue Type: New Feature
Reporter: Michael Guymon
Priority: Minor
  Labels: patch
 Attachments: 0001-Add-configuration-loader-to-DatabaseDescriptor.patch


 Based on feed back from CASSANDRA-4998 -
 Added IConfigurationLoader that is used to load an external Config. When the 
 System Property cassandra.config.loader is defined with an implementing 
 class, DatabaseDescriptor with will that Config over loading the 
 cassandra.yaml. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


buildbot success in ASF Buildbot on cassandra-trunk

2012-12-28 Thread buildbot
The Buildbot has detected a restored build on builder cassandra-trunk while 
building cassandra.
Full details are available at:
 http://ci.apache.org/builders/cassandra-trunk/builds/2214

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: portunus_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch trunk] e0e45a4fe7ebb71ebd58f9534b0e92825c63f721
Blamelist: Jonathan Ellis jbel...@apache.org

Build succeeded!

sincerely,
 -The Buildbot





[Cassandra Wiki] Trivial Update of AugustinaL by AugustinaL

2012-12-28 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Cassandra Wiki for 
change notification.

The AugustinaL page has been changed by AugustinaL:
http://wiki.apache.org/cassandra/AugustinaL

New page:
Not much to write about me at all.BRBRFeel free to surf to my blog 
post; [[http://www.papublishing.com/news/tag/photography/page/2/|linked site]]


[jira] [Comment Edited] (CASSANDRA-4999) CQL2 returns empty results from song_tags

2012-12-28 Thread Aleksey Yeschenko (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540677#comment-13540677
 ] 

Aleksey Yeschenko edited comment on CASSANDRA-4999 at 12/29/12 12:41 AM:
-

Here is what I'm getting:

{quote}
cqlsh:test select * from song_tags;

 id,a3e64f8f-bd44-4f28-b8d9-6938726e34d4 | 1973, | blues,
 id,8a172618-b121-4136-bb10-f665cfc469eb | 2007, | covers,
{quote}

branch: cassandra-1.2. I assume it was somehow fixed in one of the unrelated 
cqlsh patches, although I have no idea which one it was (assuming the problem 
was really in cqlsh that is).

  was (Author: iamaleksey):
Here is what I'm getting:

{{monospaced}}
cqlsh:test select * from song_tags;

 id,a3e64f8f-bd44-4f28-b8d9-6938726e34d4 | 1973, | blues,
 id,8a172618-b121-4136-bb10-f665cfc469eb | 2007, | covers,
{{monospaced}}

branch: cassandra-1.2. I assume it was somehow fixed in one of the unrelated 
cqlsh patches, although I have no idea which one it was (assuming the problem 
was really in cqlsh that is).
  
 CQL2 returns empty results from song_tags
 -

 Key: CASSANDRA-4999
 URL: https://issues.apache.org/jira/browse/CASSANDRA-4999
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.2.0 beta 2
Reporter: Kristine Hahn
Assignee: Aleksey Yeschenko
Priority: Trivial

 To reproduce the problem:
 1. start CQL2 ./cqlsh --cql2
 Connected to Test Cluster at localhost:9160.
 [cqlsh 2.3.0 | Cassandra 0.0.0 | CQL spec 2.0.0 | Thrift protocol 19.35.0]
 2. create a keyspace and use it.
 3. create the tables and insert data:
 CREATE COLUMNFAMILY songs (id uuid PRIMARY KEY, title text, album text, 
 artist text, data blob);
 CREATE COLUMNFAMILY song_tags (id uuid PRIMARY KEY) WITH comparator=text;
 insert into songs (id, title, artist, album) values 
 ('a3e64f8f-bd44-4f28-b8d9-6938726e34d4', 'La Grange', 'ZZ Top', 'Tres 
 Hombres');
 insert into songs (id, title, artist, album) values 
 ('8a172618-b121-4136-bb10-f665cfc469eb', 'Moving in Stereo', 'Fu Manchu', 'We 
 Must Obey');
 insert into songs (id, title, artist, album) values 
 ('62c36092-82a1-3a00-93d1-46196ee77204', 'Outside Woman Blues', 'Back Door 
 Slam', 'Roll Away');
 insert into song_tags ('id', 'blues', '1973') values 
 ('a3e64f8f-bd44-4f28-b8d9-6938726e34d4', '', '');
 insert into song_tags ('id', 'covers', '2007') values 
 ('8a172618-b121-4136-bb10-f665cfc469eb', '', '');
 4. Select * from song_tags;
 Expected result: 
 id,8a172618-b121-4136-bb10-f665cfc469eb | 2007, | covers,
 id,a3e64f8f-bd44-4f28-b8d9-6938726e34d4 | 1973, | blues,
 Actual result:
 none

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (CASSANDRA-4999) CQL2 returns empty results from song_tags

2012-12-28 Thread Aleksey Yeschenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksey Yeschenko resolved CASSANDRA-4999.
--

Resolution: Cannot Reproduce

No longer an issue in cassandra-1.2.0 and upwards.

 CQL2 returns empty results from song_tags
 -

 Key: CASSANDRA-4999
 URL: https://issues.apache.org/jira/browse/CASSANDRA-4999
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.2.0 beta 2
Reporter: Kristine Hahn
Assignee: Aleksey Yeschenko
Priority: Trivial

 To reproduce the problem:
 1. start CQL2 ./cqlsh --cql2
 Connected to Test Cluster at localhost:9160.
 [cqlsh 2.3.0 | Cassandra 0.0.0 | CQL spec 2.0.0 | Thrift protocol 19.35.0]
 2. create a keyspace and use it.
 3. create the tables and insert data:
 CREATE COLUMNFAMILY songs (id uuid PRIMARY KEY, title text, album text, 
 artist text, data blob);
 CREATE COLUMNFAMILY song_tags (id uuid PRIMARY KEY) WITH comparator=text;
 insert into songs (id, title, artist, album) values 
 ('a3e64f8f-bd44-4f28-b8d9-6938726e34d4', 'La Grange', 'ZZ Top', 'Tres 
 Hombres');
 insert into songs (id, title, artist, album) values 
 ('8a172618-b121-4136-bb10-f665cfc469eb', 'Moving in Stereo', 'Fu Manchu', 'We 
 Must Obey');
 insert into songs (id, title, artist, album) values 
 ('62c36092-82a1-3a00-93d1-46196ee77204', 'Outside Woman Blues', 'Back Door 
 Slam', 'Roll Away');
 insert into song_tags ('id', 'blues', '1973') values 
 ('a3e64f8f-bd44-4f28-b8d9-6938726e34d4', '', '');
 insert into song_tags ('id', 'covers', '2007') values 
 ('8a172618-b121-4136-bb10-f665cfc469eb', '', '');
 4. Select * from song_tags;
 Expected result: 
 id,8a172618-b121-4136-bb10-f665cfc469eb | 2007, | covers,
 id,a3e64f8f-bd44-4f28-b8d9-6938726e34d4 | 1973, | blues,
 Actual result:
 none

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (CASSANDRA-4972) Move add a default limit logic to cqlsh

2012-12-28 Thread Aleksey Yeschenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-4972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksey Yeschenko updated CASSANDRA-4972:
-

Reviewer: brandon.williams

 Move add a default limit logic to cqlsh
 -

 Key: CASSANDRA-4972
 URL: https://issues.apache.org/jira/browse/CASSANDRA-4972
 Project: Cassandra
  Issue Type: Improvement
  Components: Tools
Reporter: Jonathan Ellis
Assignee: Aleksey Yeschenko
Priority: Minor
 Fix For: 1.2.1

 Attachments: 4972.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (CASSANDRA-4972) Move add a default limit logic to cqlsh

2012-12-28 Thread Aleksey Yeschenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-4972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksey Yeschenko updated CASSANDRA-4972:
-

Attachment: 4972.txt

 Move add a default limit logic to cqlsh
 -

 Key: CASSANDRA-4972
 URL: https://issues.apache.org/jira/browse/CASSANDRA-4972
 Project: Cassandra
  Issue Type: Improvement
  Components: Tools
Reporter: Jonathan Ellis
Assignee: Aleksey Yeschenko
Priority: Minor
 Fix For: 1.2.1

 Attachments: 4972.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira