[jira] [Resolved] (CASSANDRA-12433) Create schema backup

[Jeremy Hanna (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Hanna resolved CASSANDRA-12433.
--
Resolution: Duplicate

> Create schema backup
> 
>
> Key: CASSANDRA-12433
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12433
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Core
>Reporter: Varun Gupta
>Priority: Minor
> Fix For: 2.2.x
>
>
> Currently cassandra support taking snapshot. Add feature to create a new 
> schema directory per node and dump current schema per keyspace into it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12434) Improve deletion_info in sstabledump to include calculated 'expires_at' based on local_delete_time + gc_grace_seconds

[Andy Tolbert (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416570#comment-15416570
 ] 

Andy Tolbert commented on CASSANDRA-12434:
--

Maybe 'expires_at' isn't the appropriate term since it could be conflated with 
TTLs, can probably think of something better.

> Improve deletion_info in sstabledump to include calculated 'expires_at' based 
> on local_delete_time + gc_grace_seconds
> -
>
> Key: CASSANDRA-12434
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12434
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Andy Tolbert
>Priority: Minor
>
> It would be helpful if sstabledump included tombstone expiration time in 
> {{deletion_info}} output by calculating {{local_delete_time + 
> gc_grace_seconds}}.  To do this it would need access to the table schema to 
> get at {{gc_grace_seconds}} which is currently not possible until 
> [CASSANDRA-9587].
> Example output, assuming gc_grace_seconds is 86400 (10 days):
> {code:javascript}
> { "name" : "data", "deletion_info" : { "marked_deleted" : 
> "2016-07-01T18:00:06.800550Z", "local_delete_time" : "2016-07-01T18:00:06Z", 
> "expires_at": "2016-07-11T18:00:06Z" } }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CASSANDRA-12434) Improve deletion_info in sstabledump to include calculated 'expires_at' based on local_delete_time + gc_grace_seconds

[Andy Tolbert (JIRA)]

Andy Tolbert created CASSANDRA-12434:


 Summary: Improve deletion_info in sstabledump to include 
calculated 'expires_at' based on local_delete_time + gc_grace_seconds
 Key: CASSANDRA-12434
 URL: https://issues.apache.org/jira/browse/CASSANDRA-12434
 Project: Cassandra
  Issue Type: Improvement
Reporter: Andy Tolbert
Priority: Minor


It would be helpful if sstabledump included tombstone expiration time in 
{{deletion_info}} output by calculating {{local_delete_time + 
gc_grace_seconds}}.  To do this it would need access to the table schema to get 
at {{gc_grace_seconds}} which is currently not possible until [CASSANDRA-9587].

Example output, assuming gc_grace_seconds is 86400 (10 days):

{code:javascript}
{ "name" : "data", "deletion_info" : { "marked_deleted" : 
"2016-07-01T18:00:06.800550Z", "local_delete_time" : "2016-07-01T18:00:06Z", 
"expires_at": "2016-07-11T18:00:06Z" } }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11595) Cassandra cannot start because of empty commitlog

[Andy Tolbert (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416539#comment-15416539
 ] 

Andy Tolbert commented on CASSANDRA-11595:
--

Was talking with a user who also encountered this same problem (also on 
windows), however in their case their Commitlog was 32MB, but was completely 
zero'd out.  Their system had been power cycled and upon restart they hit this 
error.

I was looking at the code and saw that when reading commitlogs prior to 2.1 a 
[different code 
path|https://github.com/apache/cassandra/blob/cassandra-3.7/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L358]
 would be taken for reading commitlogs which seemed to [gracefully 
proceed|https://github.com/apache/cassandra/blob/cassandra-3.7/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L464-L468]
 when reading 0.  Although in that case no header would be read from like it is 
for [newer 
commitlogs|https://github.com/apache/cassandra/blob/cassandra-3.7/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L370].

Should it be considered mandatory that the header content is present in the 
commitlog as it currently is?  In this case it seems like there is no risk in 
the user simply deleting the file and moving on since it doesn't contain 
anything anyways.  Although maybe there is still a problem somewhere since the 
file has no header in the first place.

> Cassandra cannot start because of empty commitlog
> -
>
> Key: CASSANDRA-11595
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11595
> Project: Cassandra
>  Issue Type: Bug
>Reporter: n0rad
>Assignee: Benjamin Lerer
>
> After the crash of CASSANDRA-11594.
> Cassandra try to restart and fail because of commit log replay.
> Same on 4 of the crashed nodes out of 6.
> ```
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException: 
> Could not read commit log descriptor in file 
> /data/commitlog/CommitLog-6-1460632496764.log
> at 
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:644)
>  [apache-cassandra-3.0.5.jar:3.0.5]
> ```
> This file is empty and is not the commitlog with the latest date.
> ```
> ...
> -rw-r--r-- 1 root root 32M Apr 16 21:46 CommitLog-6-1460632496761.log
> -rw-r--r-- 1 root root 32M Apr 16 21:47 CommitLog-6-1460632496762.log
> -rw-r--r-- 1 root root 32M Apr 16 21:47 CommitLog-6-1460632496763.log
> -rw-r--r-- 1 root root   0 Apr 16 21:47 CommitLog-6-1460632496764.log
> -rw-r--r-- 1 root root 32M Apr 16 21:50 CommitLog-6-1460843401097.log
> -rw-r--r-- 1 root root 32M Apr 16 21:51 CommitLog-6-1460843513346.log
> -rw-r--r-- 1 root root 32M Apr 16 21:53 CommitLog-6-1460843619271.log
> -rw-r--r-- 1 root root 32M Apr 16 21:55 CommitLog-6-1460843730533.log
> -rw-r--r-- 1 root root 32M Apr 16 21:57 CommitLog-6-1460843834129.log
> -rw-r--r-- 1 root root 32M Apr 16 21:58 CommitLog-6-1460843935094.log
> -rw-r--r-- 1 root root 32M Apr 16 22:00 CommitLog-6-1460844038543.log
> -rw-r--r-- 1 root root 32M Apr 16 22:02 CommitLog-6-1460844141003.log
> ...
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-6381) Refactor nodetool

[sankalp kohli (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416503#comment-15416503
 ] 

sankalp kohli commented on CASSANDRA-6381:
--

This patches changed the way -hosts and -dc is parsed b/w 2.0 and 2.1 
Instead of passing -hosts like repair -hosts IP1,IP2  you need to give 
repair -hosts IP1 -hosts IP2  

Documentation in 
https://docs.datastax.com/en/cassandra/2.1/cassandra/tools/toolsRepair.html
is wrong. Please fix it. 

> Refactor nodetool
> -
>
> Key: CASSANDRA-6381
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6381
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Yuki Morishita
>Assignee: Clément Lardeur
>Priority: Minor
>  Labels: lhf, nodetool
> Fix For: 2.1 beta1
>
> Attachments: trunk-6381-fix-windows-nodetool-script.patch, 
> trunk-6381-v2.patch, trunk-6381-v3.patch, trunk-6381-v4.patch, 
> trunk-6381.patch
>
>
> We have way too many nodetool commands(more than 40) packed in one NodeCmd 
> class. And we are trying to add more commands.
> https://github.com/airlift/airline could be a good fit to take out each 
> command into sub command class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

cassandra git commit: remove dead method

[dbrosius]

Repository: cassandra
Updated Branches:
  refs/heads/trunk eda4b58e1 -> 22a9bf0d4


remove dead method


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/22a9bf0d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/22a9bf0d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/22a9bf0d

Branch: refs/heads/trunk
Commit: 22a9bf0d4e2e2ff45e3db56d87012642ba64a615
Parents: eda4b58
Author: Dave Brosius 
Authored: Wed Aug 10 23:48:30 2016 -0400
Committer: Dave Brosius 
Committed: Wed Aug 10 23:48:52 2016 -0400

--
 src/java/org/apache/cassandra/db/UnfilteredDeserializer.java | 5 -
 1 file changed, 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/22a9bf0d/src/java/org/apache/cassandra/db/UnfilteredDeserializer.java
--
diff --git a/src/java/org/apache/cassandra/db/UnfilteredDeserializer.java 
b/src/java/org/apache/cassandra/db/UnfilteredDeserializer.java
index 1ab96fa..9e39105 100644
--- a/src/java/org/apache/cassandra/db/UnfilteredDeserializer.java
+++ b/src/java/org/apache/cassandra/db/UnfilteredDeserializer.java
@@ -656,11 +656,6 @@ public abstract class UnfilteredDeserializer
 return !openTombstones.isEmpty();
 }
 
-private boolean formBoundary(LegacyLayout.LegacyRangeTombstone 
close, LegacyLayout.LegacyRangeTombstone open)
-{
-return metadata.comparator.compare(close.stop.bound, 
open.start.bound) == 0;
-}
-
 public void clearState()
 {
 openTombstones.clear();

[jira] [Commented] (CASSANDRA-12403) Slow query detecting

[Shogo Hoshii (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416432#comment-15416432
 ] 

Shogo Hoshii commented on CASSANDRA-12403:
--

Hello [~Stefania]-san,

Thank you very much for the review and adding dtest! Very great job.

The default value of query_log_timeout_in_ms is ok for me because most of 
problematic queries take more than 1,000 msec in production environment of my 
company. If my team have clusters in which we have to be very sensitive to slow 
queries, we can just change the configuration. 
I do not have any concern about the logging interval, 5 minutes. In terms of 
log level, monitoring tools can still detect slow query log by grepping its 
message even though it is INFO level.

I am sorry for putting bugs, duplication log and log missing. I should have 
read the code more thoroughly.
But I have learnt a lot from your comments, code and test.
I am looking forward to the patch merged!

Thank you.

> Slow query detecting
> 
>
> Key: CASSANDRA-12403
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12403
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Shogo Hoshii
>Assignee: Shogo Hoshii
> Attachments: sample.log, slow_query.patch, slow_query.patch
>
>
> Hello,
> In cassandra production environment, users sometimes build anti-pattern 
> tables and throw queries in inefficient manners.
> So I would like to suggest a feature that enables to log slow query.
> The feature can help cassandra operators to identify bad query patterns.
> Then operators can give advices about queries and data model to users who 
> don't know cassandra so much.
> This ticket is related to CASSANDRA-6226, and I focus on detecting bad query 
> patterns, not aborting them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11356) EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml

[Jason Brown (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416350#comment-15416350
 ] 

Jason Brown commented on CASSANDRA-11356:
-

I'm +1 on the patch except for two minor issues:

- is 2.2 in critical-fixes only mode now? If so, let's only commit to 3.0 and 
higher
- Can we add a couple of (simple) tests for 
{{FBUtliities#getBroadcastRpcAddress}}? I can easily see that the functionality 
is correct *now*, I'm just worried about the future if/when we move things 
around and we accidentally break things.

> EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml
> --
>
> Key: CASSANDRA-11356
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11356
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Reporter: Thanh
>Assignee: Paulo Motta
> Fix For: 2.2.x, 3.x
>
>
> EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml.  This is 
> problematic for those users who were using EC2MRS with an internal 
> rpc_address before the change introduced in 
> [CASSANDRA-5899|https://issues.apache.org/jira/browse/CASSANDRA-5899], 
> because the change results in EC2MRS always using the public ip regardless of 
> what the user has set for broadcast_rpc_address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12256) Properly respect the request timeouts

[Geoffrey Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416338#comment-15416338
 ] 

Geoffrey Yu commented on CASSANDRA-12256:
-

Thanks for the review! I looked through the test results and it seems like 
there are quite a few failures that are timeouts. I'll take a look and see what 
I can do. 

> Properly respect the request timeouts
> -
>
> Key: CASSANDRA-12256
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12256
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Sylvain Lebresne
>Assignee: Geoffrey Yu
> Fix For: 3.x
>
> Attachments: 12256-trunk.txt
>
>
> We have a number of {{request_timeout_*}} option, that probably every user 
> expect to be an upper bound on how long the coordinator will wait before 
> timeouting a request, but it's actually not always the case, especially for 
> read requests.
> I believe we don't respect those timeout properly in at least the following 
> cases:
> * On a digest mismatch: in that case, we reset the timeout for the data 
> query, which means the overall query might take up to twice the configured 
> timeout before timeouting.
> * On a range query: the timeout is reset for every sub-range that is queried. 
> With many nodes and vnodes, a range query could span tons of sub-range and so 
> a range query could take pretty much arbitrary long before actually 
> timeouting for the user.
> * On short reads: we also reset the timeout for every short reads "retries".
> It's also worth noting that even outside those, the timeouts don't take most 
> of the processing done by the coordinator (query parsing and CQL handling for 
> instance) into account.
> Now, in all fairness, the reason this is this way is that the timeout 
> currently are *not* timeout for the full user request, but rather how long a 
> coordinator should wait on any given replica for any given internal query 
> before giving up. *However*, I'm pretty sure this is not what user 
> intuitively expect and want, *especially* in the context of CASSANDRA-2848 
> where the goal is explicitely to have an upper bound on the query from the 
> user point of view.
> So I'm suggesting we change how those timeouts are handled to really be 
> timeouts on the whole user query.
> And by that I basically just mean that we'd mark the start of each query as 
> soon as possible in the processing, and use that starting time as base in 
> {{ReadCallback.await}} and {{AbstractWriteResponseHandler.get()}}. It won't 
> be perfect in the sense that we'll still only possibly timeout during 
> "blocking" operations, so typically if parsing a query takes more than your 
> timeout, you still won't timeout until that query is sent, but I think that's 
> probably fine in practice because 1) if you timeouts are small enough that 
> this matter, you're probably doing it wrong and 2) we can totally improve on 
> that later if needs be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-8523) Writes should be sent to a replacement node while it is streaming in data

[Richard Low (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416328#comment-15416328
 ] 

Richard Low commented on CASSANDRA-8523:


+1 on the 3.9 version too.

> Writes should be sent to a replacement node while it is streaming in data
> -
>
> Key: CASSANDRA-8523
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8523
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Richard Wagner
>Assignee: Paulo Motta
> Fix For: 2.1.x
>
>
> In our operations, we make heavy use of replace_address (or 
> replace_address_first_boot) in order to replace broken nodes. We now realize 
> that writes are not sent to the replacement nodes while they are in hibernate 
> state and streaming in data. This runs counter to what our expectations were, 
> especially since we know that writes ARE sent to nodes when they are 
> bootstrapped into the ring.
> It seems like cassandra should arrange to send writes to a node that is in 
> the process of replacing another node, just like it does for a nodes that are 
> bootstraping. I hesitate to phrase this as "we should send writes to a node 
> in hibernate" because the concept of hibernate may be useful in other 
> contexts, as per CASSANDRA-8336. Maybe a new state is needed here?
> Among other things, the fact that we don't get writes during this period 
> makes subsequent repairs more expensive, proportional to the number of writes 
> that we miss (and depending on the amount of data that needs to be streamed 
> during replacement and the time it may take to rebuild secondary indexes, we 
> could miss many many hours worth of writes). It also leaves us more exposed 
> to consistency violations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12100) Compactions are stuck after TRUNCATE

[Stefania (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416324#comment-15416324
 ] 

Stefania commented on CASSANDRA-12100:
--

Thank you for the review. Committed to 3.0 as 
05483a962c64c350315fc738c697980b22361cc3 and merged upwards.

[~ostefano], let us know if you still have problems with this in 3.0.9.

> Compactions are stuck after TRUNCATE
> 
>
> Key: CASSANDRA-12100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12100
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
>Reporter: Stefano Ortolani
>Assignee: Stefania
> Fix For: 3.0.9, 3.9
>
> Attachments: node3_jstack.log
>
>
> Hi,
> since the upgrade to C* 3.0.7 I see compaction tasks getting stuck when 
> truncating the column family. I verified this on all nodes of the cluster.
> Pending compactions seem to disappear after restarting the node.
> {noformat}
> root@node10:~# nodetool -h localhost compactionstats
> pending tasks: 6
>  id   compaction type  
> keyspacetable   completed  totalunit   progress
>24e1ad30-3cac-11e6-870d-5de740693258Compaction  
> schema  table_1   0   57558382   bytes  0.00%
>2be2e3b0-3cac-11e6-870d-5de740693258Compaction  
> schema  table_2   0   65063705   bytes  0.00%
>54de38f0-3cac-11e6-870d-5de740693258Compaction  
> schema  table_3   0 187031   bytes  0.00%
>31926ce0-3cac-11e6-870d-5de740693258Compaction  
> schema  table_4   0   42951119   bytes  0.00%
>3911ad00-3cac-11e6-870d-5de740693258Compaction  
> schema  table_5   0   25918949   bytes  0.00%
>3e6a8ab0-3cac-11e6-870d-5de740693258Compaction  
> schema  table_6   0   65466210   bytes  0.00%
> Active compaction remaining time :   0h00m15s
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12100) Compactions are stuck after TRUNCATE

[Stefania (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefania updated CASSANDRA-12100:
-
   Resolution: Fixed
Fix Version/s: (was: 3.0.x)
   3.9
   3.0.9
   Status: Resolved  (was: Ready to Commit)

> Compactions are stuck after TRUNCATE
> 
>
> Key: CASSANDRA-12100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12100
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
>Reporter: Stefano Ortolani
>Assignee: Stefania
> Fix For: 3.0.9, 3.9
>
> Attachments: node3_jstack.log
>
>
> Hi,
> since the upgrade to C* 3.0.7 I see compaction tasks getting stuck when 
> truncating the column family. I verified this on all nodes of the cluster.
> Pending compactions seem to disappear after restarting the node.
> {noformat}
> root@node10:~# nodetool -h localhost compactionstats
> pending tasks: 6
>  id   compaction type  
> keyspacetable   completed  totalunit   progress
>24e1ad30-3cac-11e6-870d-5de740693258Compaction  
> schema  table_1   0   57558382   bytes  0.00%
>2be2e3b0-3cac-11e6-870d-5de740693258Compaction  
> schema  table_2   0   65063705   bytes  0.00%
>54de38f0-3cac-11e6-870d-5de740693258Compaction  
> schema  table_3   0 187031   bytes  0.00%
>31926ce0-3cac-11e6-870d-5de740693258Compaction  
> schema  table_4   0   42951119   bytes  0.00%
>3911ad00-3cac-11e6-870d-5de740693258Compaction  
> schema  table_5   0   25918949   bytes  0.00%
>3e6a8ab0-3cac-11e6-870d-5de740693258Compaction  
> schema  table_6   0   65466210   bytes  0.00%
> Active compaction remaining time :   0h00m15s
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[4/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.9

[stefania]

Merge branch 'cassandra-3.0' into cassandra-3.9


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/15fd71f9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/15fd71f9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/15fd71f9

Branch: refs/heads/trunk
Commit: 15fd71f9a3b07bbac7a1182f2e6bffd32e79b955
Parents: 1fff069 05483a9
Author: Stefania Alborghetti 
Authored: Thu Aug 11 09:11:11 2016 +0800
Committer: Stefania Alborghetti 
Committed: Thu Aug 11 09:11:11 2016 +0800

--
 CHANGES.txt | 1 +
 src/java/org/apache/cassandra/db/compaction/CompactionTask.java | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/15fd71f9/CHANGES.txt
--
diff --cc CHANGES.txt
index 498868c,bd3bb75..bca8879
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,11 -1,7 +1,12 @@@
 -3.0.9
 +3.9
 + * Fix value skipping with counter columns (CASSANDRA-11726)
 + * Fix nodetool tablestats miss SSTable count (CASSANDRA-12205)
 + * Fixed flacky SSTablesIteratedTest (CASSANDRA-12282)
 + * Fixed flacky SSTableRewriterTest: check file counts before calling 
validateCFS (CASSANDRA-12348)
 + * cqlsh: Fix handling of $$-escaped strings (CASSANDRA-12189)
 + * Fix SSL JMX requiring truststore containing server cert (CASSANDRA-12109)
 +Merged from 3.0:
+  * Make sure compaction stats are updated when compaction is interrupted 
(CASSANDRA-12100)
 - * Fix potential bad messaging service message for paged range reads
 -   within mixed-version 3.x clusters (CASSANDRA-12249)
   * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)
   * NullPointerException during compaction on table with static columns 
(CASSANDRA-12336)
   * Fixed ConcurrentModificationException when reading metrics in 
GraphiteReporter (CASSANDRA-11823)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/15fd71f9/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
--
diff --cc src/java/org/apache/cassandra/db/compaction/CompactionTask.java
index 86c8a8f,7e4ed41..2913dc9
--- a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
@@@ -170,13 -164,14 +170,14 @@@ public class CompactionTask extends Abs
   AbstractCompactionStrategy.ScannerList scanners = 
strategy.getScanners(actuallyCompact);
   CompactionIterator ci = new 
CompactionIterator(compactionType, scanners.scanners, controller, nowInSec, 
taskId))
  {
- if (collector != null)
- collector.beginCompaction(ci);
  long lastCheckObsoletion = start;
  
 -if (!controller.cfs.getCompactionStrategyManager().isActive)
 +if (!controller.cfs.getCompactionStrategyManager().isActive())
  throw new 
CompactionInterruptedException(ci.getCompactionInfo());
  
+ if (collector != null)
+ collector.beginCompaction(ci);
+ 
  try (CompactionAwareWriter writer = 
getCompactionAwareWriter(cfs, getDirectories(), transaction, actuallyCompact))
  {
  estimatedKeys = writer.estimatedKeys();

[1/6] cassandra git commit: Make sure compaction stats are updated when compaction is interrupted

[stefania]

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-3.0 2691c9e4e -> 05483a962
  refs/heads/cassandra-3.9 1fff069ad -> 15fd71f9a
  refs/heads/trunk f467c8523 -> eda4b58e1


Make sure compaction stats are updated when compaction is interrupted

patch by Stefania Alborghetti; reviewed by Marcus Eriksson for CASSANDRA-12100


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/05483a96
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/05483a96
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/05483a96

Branch: refs/heads/cassandra-3.0
Commit: 05483a962c64c350315fc738c697980b22361cc3
Parents: 2691c9e
Author: Stefania Alborghetti 
Authored: Thu Aug 4 14:20:38 2016 +0800
Committer: Stefania Alborghetti 
Committed: Thu Aug 11 09:09:57 2016 +0800

--
 CHANGES.txt | 1 +
 src/java/org/apache/cassandra/db/compaction/CompactionTask.java | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/05483a96/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index e1bc9f3..bd3bb75 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.9
+ * Make sure compaction stats are updated when compaction is interrupted 
(CASSANDRA-12100)
  * Fix potential bad messaging service message for paged range reads
within mixed-version 3.x clusters (CASSANDRA-12249)
  * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/05483a96/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
--
diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java 
b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
index 9a7aa98..7e4ed41 100644
--- a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
@@ -164,13 +164,14 @@ public class CompactionTask extends AbstractCompactionTask
  AbstractCompactionStrategy.ScannerList scanners = 
strategy.getScanners(actuallyCompact);
  CompactionIterator ci = new 
CompactionIterator(compactionType, scanners.scanners, controller, nowInSec, 
taskId))
 {
-if (collector != null)
-collector.beginCompaction(ci);
 long lastCheckObsoletion = start;
 
 if (!controller.cfs.getCompactionStrategyManager().isActive)
 throw new 
CompactionInterruptedException(ci.getCompactionInfo());
 
+if (collector != null)
+collector.beginCompaction(ci);
+
 try (CompactionAwareWriter writer = 
getCompactionAwareWriter(cfs, getDirectories(), transaction, actuallyCompact))
 {
 estimatedKeys = writer.estimatedKeys();

[3/6] cassandra git commit: Make sure compaction stats are updated when compaction is interrupted

[stefania]

Make sure compaction stats are updated when compaction is interrupted

patch by Stefania Alborghetti; reviewed by Marcus Eriksson for CASSANDRA-12100


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/05483a96
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/05483a96
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/05483a96

Branch: refs/heads/trunk
Commit: 05483a962c64c350315fc738c697980b22361cc3
Parents: 2691c9e
Author: Stefania Alborghetti 
Authored: Thu Aug 4 14:20:38 2016 +0800
Committer: Stefania Alborghetti 
Committed: Thu Aug 11 09:09:57 2016 +0800

--
 CHANGES.txt | 1 +
 src/java/org/apache/cassandra/db/compaction/CompactionTask.java | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/05483a96/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index e1bc9f3..bd3bb75 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.9
+ * Make sure compaction stats are updated when compaction is interrupted 
(CASSANDRA-12100)
  * Fix potential bad messaging service message for paged range reads
within mixed-version 3.x clusters (CASSANDRA-12249)
  * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/05483a96/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
--
diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java 
b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
index 9a7aa98..7e4ed41 100644
--- a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
@@ -164,13 +164,14 @@ public class CompactionTask extends AbstractCompactionTask
  AbstractCompactionStrategy.ScannerList scanners = 
strategy.getScanners(actuallyCompact);
  CompactionIterator ci = new 
CompactionIterator(compactionType, scanners.scanners, controller, nowInSec, 
taskId))
 {
-if (collector != null)
-collector.beginCompaction(ci);
 long lastCheckObsoletion = start;
 
 if (!controller.cfs.getCompactionStrategyManager().isActive)
 throw new 
CompactionInterruptedException(ci.getCompactionInfo());
 
+if (collector != null)
+collector.beginCompaction(ci);
+
 try (CompactionAwareWriter writer = 
getCompactionAwareWriter(cfs, getDirectories(), transaction, actuallyCompact))
 {
 estimatedKeys = writer.estimatedKeys();

[6/6] cassandra git commit: Merge branch 'cassandra-3.9' into trunk

[stefania]

Merge branch 'cassandra-3.9' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/eda4b58e
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/eda4b58e
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/eda4b58e

Branch: refs/heads/trunk
Commit: eda4b58e1d891e0ad42320c7251af8e6626f36e9
Parents: f467c85 15fd71f
Author: Stefania Alborghetti 
Authored: Thu Aug 11 09:11:32 2016 +0800
Committer: Stefania Alborghetti 
Committed: Thu Aug 11 09:11:32 2016 +0800

--
 CHANGES.txt | 1 +
 src/java/org/apache/cassandra/db/compaction/CompactionTask.java | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/eda4b58e/CHANGES.txt
--

http://git-wip-us.apache.org/repos/asf/cassandra/blob/eda4b58e/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
--
diff --cc src/java/org/apache/cassandra/db/compaction/CompactionTask.java
index 43a726b,2913dc9..036d522
--- a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
@@@ -174,15 -170,7 +174,13 @@@ public class CompactionTask extends Abs
   AbstractCompactionStrategy.ScannerList scanners = 
strategy.getScanners(actuallyCompact);
   CompactionIterator ci = new 
CompactionIterator(compactionType, scanners.scanners, controller, nowInSec, 
taskId))
  {
- if (collector != null)
- collector.beginCompaction(ci);
  long lastCheckObsoletion = start;
 +inputSizeBytes = scanners.getTotalCompressedSize();
 +double compressionRatio = scanners.getCompressionRatio();
 +if (compressionRatio == 
MetadataCollector.NO_COMPRESSION_RATIO)
 +compressionRatio = 1.0;
 +
 +long lastBytesScanned = 0;
  
  if (!controller.cfs.getCompactionStrategyManager().isActive())
  throw new 
CompactionInterruptedException(ci.getCompactionInfo());

[2/6] cassandra git commit: Make sure compaction stats are updated when compaction is interrupted

[stefania]

Make sure compaction stats are updated when compaction is interrupted

patch by Stefania Alborghetti; reviewed by Marcus Eriksson for CASSANDRA-12100


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/05483a96
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/05483a96
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/05483a96

Branch: refs/heads/cassandra-3.9
Commit: 05483a962c64c350315fc738c697980b22361cc3
Parents: 2691c9e
Author: Stefania Alborghetti 
Authored: Thu Aug 4 14:20:38 2016 +0800
Committer: Stefania Alborghetti 
Committed: Thu Aug 11 09:09:57 2016 +0800

--
 CHANGES.txt | 1 +
 src/java/org/apache/cassandra/db/compaction/CompactionTask.java | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/05483a96/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index e1bc9f3..bd3bb75 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.9
+ * Make sure compaction stats are updated when compaction is interrupted 
(CASSANDRA-12100)
  * Fix potential bad messaging service message for paged range reads
within mixed-version 3.x clusters (CASSANDRA-12249)
  * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/05483a96/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
--
diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java 
b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
index 9a7aa98..7e4ed41 100644
--- a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
@@ -164,13 +164,14 @@ public class CompactionTask extends AbstractCompactionTask
  AbstractCompactionStrategy.ScannerList scanners = 
strategy.getScanners(actuallyCompact);
  CompactionIterator ci = new 
CompactionIterator(compactionType, scanners.scanners, controller, nowInSec, 
taskId))
 {
-if (collector != null)
-collector.beginCompaction(ci);
 long lastCheckObsoletion = start;
 
 if (!controller.cfs.getCompactionStrategyManager().isActive)
 throw new 
CompactionInterruptedException(ci.getCompactionInfo());
 
+if (collector != null)
+collector.beginCompaction(ci);
+
 try (CompactionAwareWriter writer = 
getCompactionAwareWriter(cfs, getDirectories(), transaction, actuallyCompact))
 {
 estimatedKeys = writer.estimatedKeys();

[5/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.9

[stefania]

Merge branch 'cassandra-3.0' into cassandra-3.9


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/15fd71f9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/15fd71f9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/15fd71f9

Branch: refs/heads/cassandra-3.9
Commit: 15fd71f9a3b07bbac7a1182f2e6bffd32e79b955
Parents: 1fff069 05483a9
Author: Stefania Alborghetti 
Authored: Thu Aug 11 09:11:11 2016 +0800
Committer: Stefania Alborghetti 
Committed: Thu Aug 11 09:11:11 2016 +0800

--
 CHANGES.txt | 1 +
 src/java/org/apache/cassandra/db/compaction/CompactionTask.java | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/15fd71f9/CHANGES.txt
--
diff --cc CHANGES.txt
index 498868c,bd3bb75..bca8879
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,11 -1,7 +1,12 @@@
 -3.0.9
 +3.9
 + * Fix value skipping with counter columns (CASSANDRA-11726)
 + * Fix nodetool tablestats miss SSTable count (CASSANDRA-12205)
 + * Fixed flacky SSTablesIteratedTest (CASSANDRA-12282)
 + * Fixed flacky SSTableRewriterTest: check file counts before calling 
validateCFS (CASSANDRA-12348)
 + * cqlsh: Fix handling of $$-escaped strings (CASSANDRA-12189)
 + * Fix SSL JMX requiring truststore containing server cert (CASSANDRA-12109)
 +Merged from 3.0:
+  * Make sure compaction stats are updated when compaction is interrupted 
(CASSANDRA-12100)
 - * Fix potential bad messaging service message for paged range reads
 -   within mixed-version 3.x clusters (CASSANDRA-12249)
   * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)
   * NullPointerException during compaction on table with static columns 
(CASSANDRA-12336)
   * Fixed ConcurrentModificationException when reading metrics in 
GraphiteReporter (CASSANDRA-11823)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/15fd71f9/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
--
diff --cc src/java/org/apache/cassandra/db/compaction/CompactionTask.java
index 86c8a8f,7e4ed41..2913dc9
--- a/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
+++ b/src/java/org/apache/cassandra/db/compaction/CompactionTask.java
@@@ -170,13 -164,14 +170,14 @@@ public class CompactionTask extends Abs
   AbstractCompactionStrategy.ScannerList scanners = 
strategy.getScanners(actuallyCompact);
   CompactionIterator ci = new 
CompactionIterator(compactionType, scanners.scanners, controller, nowInSec, 
taskId))
  {
- if (collector != null)
- collector.beginCompaction(ci);
  long lastCheckObsoletion = start;
  
 -if (!controller.cfs.getCompactionStrategyManager().isActive)
 +if (!controller.cfs.getCompactionStrategyManager().isActive())
  throw new 
CompactionInterruptedException(ci.getCompactionInfo());
  
+ if (collector != null)
+ collector.beginCompaction(ci);
+ 
  try (CompactionAwareWriter writer = 
getCompactionAwareWriter(cfs, getDirectories(), transaction, actuallyCompact))
  {
  estimatedKeys = writer.estimatedKeys();

[jira] [Updated] (CASSANDRA-12433) Create schema backup

[Varun Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Gupta updated CASSANDRA-12433:

Description: Currently cassandra support taking snapshot. Add feature to 
create a new schema directory per node and dump current schema per keyspace 
into it.  (was: Currently cassandra support taking snapshot. Add feature to 
create a new schema directory per node and take dump current schema per 
keyspace into it.)

> Create schema backup
> 
>
> Key: CASSANDRA-12433
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12433
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Core
>Reporter: Varun Gupta
>Priority: Minor
> Fix For: 2.2.x
>
>
> Currently cassandra support taking snapshot. Add feature to create a new 
> schema directory per node and dump current schema per keyspace into it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12433) Create schema backup

[Varun Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Gupta updated CASSANDRA-12433:

Description: Currently cassandra support taking snapshot. Add feature to 
create a new schema directory per node and take dump current schema per 
keyspace into it.  (was: Currently cassandra support taking snapshot. A feature 
to create a new schema directory per node and take dump current schema per 
keyspace into it.)

> Create schema backup
> 
>
> Key: CASSANDRA-12433
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12433
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Core
>Reporter: Varun Gupta
>Priority: Minor
> Fix For: 2.2.x
>
>
> Currently cassandra support taking snapshot. Add feature to create a new 
> schema directory per node and take dump current schema per keyspace into it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CASSANDRA-12433) Create schema backup

[Varun Gupta (JIRA)]

Varun Gupta created CASSANDRA-12433:
---

 Summary: Create schema backup
 Key: CASSANDRA-12433
 URL: https://issues.apache.org/jira/browse/CASSANDRA-12433
 Project: Cassandra
  Issue Type: New Feature
  Components: Core
Reporter: Varun Gupta
Priority: Minor
 Fix For: 2.2.x


Currently cassandra support taking snapshot. A feature to create a new schema 
directory per node and take dump current schema per keyspace into it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Cassandra Wiki] Update of "ContributorsGroup" by DaveBrosius

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Cassandra Wiki" for 
change notification.

The "ContributorsGroup" page has been changed by DaveBrosius:
https://wiki.apache.org/cassandra/ContributorsGroup?action=diff=59=60

   * ChrisBroome
   * ChrisBurroughs
   * daniels
+  * Danielle Blake
   * EricEvans
   * ErnieHershey
   * FlipKromer

[jira] [Updated] (CASSANDRA-12432) Set ulimit for nproc in debian init script

[Jared Biel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Biel updated CASSANDRA-12432:
---
Description: 
While using Cassandra 2.2.7 (installed from official package) on Ubuntu 14.04 I 
noticed a warning on startup:

{noformat}
WARN  [main] 2016-08-10 21:53:53,219 SigarLibrary.java:174 - Cassandra server 
running in degraded mode. Is swap disabled? : true,  Address space adequate? : 
true,  nofile limit adequate? : true, nproc limit adequate? : false
{noformat}

I set about researching how that value is set and how to increase it. I found 
the [Datastax documentation on recommended 
settings|http://docs.datastax.com/en/landing_page/doc/landing_page/recommendedSettingsLinux.html]
 and tried to increase the nproc limits according to that doc to no avail. I 
eventually found a [stackoverflow 
post|http://superuser.com/questions/454465/make-ulimits-work-with-start-stop-daemon]
 that states that start-stop-daemon (which the C* init script uses) 
doesn't/can't use the values specified in the limits.conf files.

I solved this by adding a {{ulimit -p 32768}} entry to the init script below 
the other two ulimit commands. Note that the flag is "-p" for dash (default 
/bin/sh on Ubuntu), but the flag is "-u" on bash. As Debian has had [dash as 
default|https://wiki.debian.org/Shell] since squeeze (2011-02-06), this should 
be safe on most Debian based distros.

  was:
While using Cassandra 2.2.7 (installed from official package) on Ubuntu 14.04 I 
noticed a warning on startup:

{noformat}
WARN  [main] 2016-08-10 21:53:53,219 SigarLibrary.java:174 - Cassandra server 
running in degraded mode. Is swap disabled? : true,  Address space adequate? : 
true,  nofile limit adequate? : true, nproc limit adequate? : false
{noformat}

I set about researching how that value is set and how to increase it. I found 
the [Datastax documentation on recommended 
settings|http://docs.datastax.com/en/landing_page/doc/landing_page/recommendedSettingsLinux.html]
 and tried to increase the nproc limits according to that doc to no avail. I 
eventually found a [stackoverflow 
post|http://superuser.com/questions/454465/make-ulimits-work-with-start-stop-daemon]
 that states that start-stop-daemon (which the C* init script uses) 
doesn't/can't use the values specified in the limits.conf files.

I solved this by adding a {{ulimit -p 32768}} entry to the init script below 
the other two ulimit commands. Note the the flag is "-p" for dash (default 
/bin/sh on Ubuntu), but the flag is "-u" on bash. As Debian has had [dash as 
default|https://wiki.debian.org/Shell] since squeeze (2011-02-06), this should 
be safe on most Debian based distros.


> Set ulimit for nproc in debian init script
> --
>
> Key: CASSANDRA-12432
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12432
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Jared Biel
>Priority: Minor
>
> While using Cassandra 2.2.7 (installed from official package) on Ubuntu 14.04 
> I noticed a warning on startup:
> {noformat}
> WARN  [main] 2016-08-10 21:53:53,219 SigarLibrary.java:174 - Cassandra server 
> running in degraded mode. Is swap disabled? : true,  Address space adequate? 
> : true,  nofile limit adequate? : true, nproc limit adequate? : false
> {noformat}
> I set about researching how that value is set and how to increase it. I found 
> the [Datastax documentation on recommended 
> settings|http://docs.datastax.com/en/landing_page/doc/landing_page/recommendedSettingsLinux.html]
>  and tried to increase the nproc limits according to that doc to no avail. I 
> eventually found a [stackoverflow 
> post|http://superuser.com/questions/454465/make-ulimits-work-with-start-stop-daemon]
>  that states that start-stop-daemon (which the C* init script uses) 
> doesn't/can't use the values specified in the limits.conf files.
> I solved this by adding a {{ulimit -p 32768}} entry to the init script below 
> the other two ulimit commands. Note that the flag is "-p" for dash (default 
> /bin/sh on Ubuntu), but the flag is "-u" on bash. As Debian has had [dash as 
> default|https://wiki.debian.org/Shell] since squeeze (2011-02-06), this 
> should be safe on most Debian based distros.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Cassandra Wiki] Update of "GettingStarted" by JonathanEllis

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Cassandra Wiki" for 
change notification.

The "GettingStarted" page has been changed by JonathanEllis:
https://wiki.apache.org/cassandra/GettingStarted?action=diff=111=112

Comment:
Apparently refresh directive is not supported, use a normal link.

- #refresh 0 http://cassandra.apache.org/doc/latest/getting_started/index.html
+ [[http://cassandra.apache.org/doc/latest/getting_started/index.html|See 
"Getting Started" in the documentation here]].
  

[Cassandra Wiki] Update of "GettingStarted" by JonathanEllis

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Cassandra Wiki" for 
change notification.

The "GettingStarted" page has been changed by JonathanEllis:
https://wiki.apache.org/cassandra/GettingStarted?action=diff=110=111

Comment:
Redirect to in-tree documentation

- == Trying Cassandra in a VM ==
+ #refresh 0 http://cassandra.apache.org/doc/latest/getting_started/index.html
  
- Try Cassandra with [[http://www.planetcassandra.org/try-cassandra|these ten 
minute developer and admin walkthroughs]].
- 
- == Installing Cassandra Locally ==
- This document aims to provide a few easy to follow steps to take the 
first-time user from installation, to running single node Cassandra, and 
overview to configure multinode cluster. Cassandra is meant to run on a cluster 
of nodes, but will run equally well on a single machine. This is a handy way of 
getting familiar with the software while avoiding the complexities of a larger 
system.
- 
- == Step 0: Prerequisites and Connecting to the Community ==
- Cassandra 3.0+ requires the most stable version of Java 8 you can deploy, 
preferably the 
[[http://www.oracle.com/technetwork/java/javase/downloads/index.html|Oracle/Sun 
JVM]].  Cassandra also runs on OpenJDK, Zing, and the IBM JVM.  (It will NOT 
run on JRockit, which is only compatible with Java 6.)
- 
- The best way to ensure you always have up to date information on the project, 
releases, stability, bugs, and features is to subscribe to the users mailing 
list ([[mailto:user-subscr...@cassandra.apache.org|subscription required]]) and 
participate in the #cassandra channel on 
[[http://webchat.freenode.net/?channels=#cassandra|IRC]].
- 
- <> <>
- 
- == Step 1: Download Cassandra ==
-  * Download links for the latest stable release can always be found on the 
[[http://cassandra.apache.org/download|website]].
-  * Users of Debian or Debian-based derivatives can install the latest stable 
release in package form, see DebianPackaging for details.
-  * Users of RPM-based distributions can get packages from 
[[www.datastax.com/documentation/latest-dsc-InsRhel|Datastax]].
-  * If you are interested in building Cassandra from source, please refer to 
[[HowToBuild|How to Build]] page.
- 
- For more details about misc builds, please refer to 
[[VersionsAndBuilds|Cassandra versions and builds]] page.
- 
- <>
- 
- == Step 2: Basic Configuration ==
- The Cassandra configuration files can be found in the `conf` directory of 
binary and source distributions. If you have installed Cassandra from a deb or 
rpm package, the configuration files will be located in `/etc/cassandra`.
- 
- === Step 2.1: Directories Used by Cassandra ===
- If you've installed Cassandra with a deb or rpm package, the directories that 
Cassandra will use should already be created an have the correct permissions. 
Otherwise, you will want to check the following config settings from 
`conf/cassandra.yaml`: `data_file_directories` (`/var/lib/cassandra/data`), 
`commitlog_directory` (`/var/lib/cassandra/commitlog`), and 
`saved_caches_directory` (`/var/lib/cassandra/saved_caches`).  Make sure these 
directories exist and can be written to.
- 
- By default, Cassandra will write its logs in `/var/log/cassandra/`.  Make 
sure this directory exists and is writeable, or change this line in 
`conf/log4j-server.properies`:
- 
- {{{
- log4j.appender.R.File=/var/log/cassandra/system.log
- }}}
- 
- Note that in Cassandra 2.1+, the logger in use is logback, so change this 
logging directory in your conf/logback.xml file such as:
- 
- {{{
- /var/log/cassandra/system.log
- }}}
- 
- JVM-level settings such as heap size can be set in `conf/cassandra-env.sh`.
- 
- == Step 3: Start Cassandra ==
- And now for the moment of truth, start up Cassandra by invoking 
'`bin/cassandra -f`' from the command line<>. The 
service should start in the foreground and log gratuitously to the console. 
Assuming you don't see messages with scary words like "error", or "fatal", or 
anything that looks like a Java stack trace, then everything should be working.
- 
- Press "Control-C" to stop Cassandra.
- 
- If you start up Cassandra without the "-f" option, it will run in the 
background. You can stop the process by killing it, using '`pkill -f 
CassandraDaemon`', for example.
- 
-  . Cassandra Users of recent Linux distributions and Mac OS X Snow Leopard 
should be able to start up Cassandra simply by untarring and invoking 
`bin/cassandra -f`.  Since Cassandra 2.1, the tar.gz download has shipped with 
the log and data directories defaulting to the Cassandra directory.  Versions 
prior defaulted to `/var/log/cassandra` and `/var/lib/cassandra/`.  Due to this 
it is necessary to either start Cassandra with root privileges or change the 
`conf/cassandra.yaml` to use a directory owned by the 

[jira] [Created] (CASSANDRA-12432) Set ulimit for nproc in debian init script

[Jared Biel (JIRA)]

Jared Biel created CASSANDRA-12432:
--

 Summary: Set ulimit for nproc in debian init script
 Key: CASSANDRA-12432
 URL: https://issues.apache.org/jira/browse/CASSANDRA-12432
 Project: Cassandra
  Issue Type: Improvement
Reporter: Jared Biel
Priority: Minor


While using Cassandra 2.2.7 (installed from official package) on Ubuntu 14.04 I 
noticed a warning on startup:

{noformat}
WARN  [main] 2016-08-10 21:53:53,219 SigarLibrary.java:174 - Cassandra server 
running in degraded mode. Is swap disabled? : true,  Address space adequate? : 
true,  nofile limit adequate? : true, nproc limit adequate? : false
{noformat}

I set about researching how that value is set and how to increase it. I found 
the [Datastax documentation on recommended 
settings|http://docs.datastax.com/en/landing_page/doc/landing_page/recommendedSettingsLinux.html]
 and tried to increase the nproc limits according to that doc to no avail. I 
eventually found a [stackoverflow 
post|http://superuser.com/questions/454465/make-ulimits-work-with-start-stop-daemon]
 that states that start-stop-daemon (which the C* init script uses) 
doesn't/can't use the values specified in the limits.conf files.

I solved this by adding a {{ulimit -p 32768}} entry to the init script below 
the other two ulimit commands. Note the the flag is "-p" for dash (default 
/bin/sh on Ubuntu), but the flag is "-u" on bash. As Debian has had [dash as 
default|https://wiki.debian.org/Shell] since squeeze (2011-02-06), this should 
be safe on most Debian based distros.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11356) EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml

[Tyler Hobbs (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415980#comment-15415980
 ] 

Tyler Hobbs commented on CASSANDRA-11356:
-

Cool, that would be just fine.

> EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml
> --
>
> Key: CASSANDRA-11356
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11356
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Reporter: Thanh
>Assignee: Paulo Motta
> Fix For: 2.2.x, 3.x
>
>
> EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml.  This is 
> problematic for those users who were using EC2MRS with an internal 
> rpc_address before the change introduced in 
> [CASSANDRA-5899|https://issues.apache.org/jira/browse/CASSANDRA-5899], 
> because the change results in EC2MRS always using the public ip regardless of 
> what the user has set for broadcast_rpc_address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-9608) Support Java 9

[Paul Sandoz (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415962#comment-15415962
 ] 

Paul Sandoz commented on CASSANDRA-9608:


-Xloggc is deprecated, as a workaround use -Xlog:gc instead, that should not 
result in a SEGV, but it will not create the file and you may observe:

$java -Xlog:gc:a/log.txt A
[0.004s][error][logging] Error opening log file 'a/log.txt': No such file or 
directory
...

> Support Java 9
> --
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
>  Issue Type: Task
>Reporter: Robert Stupp
>Priority: Minor
>
> This ticket is intended to group all issues found to support Java 9 in the 
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved. 
> It can be easily solved using this patch:
> {code}
> - artifactId="cobertura"/>
> + artifactId="cobertura">
> +  
> +
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods 
> {{monitorEnter}} + {{monitorExit}}. These methods are used by 
> {{o.a.c.utils.concurrent.Locks}} which is only used by 
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early 
> development phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (CASSANDRA-9876) One way targeted repair

[Geoffrey Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415774#comment-15415774
 ] 

Geoffrey Yu edited comment on CASSANDRA-9876 at 8/10/16 8:37 PM:
-

I've attached a v3 patch that makes some changes to {{RepairOptionTest}} to 
address the new behavior of {{RepairOption.parse()}}. The patch has four 
commits. The first is the v2 patch, the second and third are your ninja 
commits, and the fourth are the test changes. Please take a look and let me 
know what you think!

I've also updated the dtest PR to address the failures in 
{{deprecated_repair_test.py}}. It looks like the failures are related to the 
changes in {{RepairOption.toString()}}.


was (Author: geoffxy):
I've attached a v3 patch that makes some changes to {{RepairOptionTest}} to 
address the new behavior of {{RepairOption.parse()}}. The patch has four 
commits. The first is the v2 patch, the second and third are your ninja 
commits, and the fourth are the test changes. Please take a look and let me 
know what you think!

> One way targeted repair
> ---
>
> Key: CASSANDRA-9876
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9876
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: sankalp kohli
>Assignee: Geoffrey Yu
>Priority: Minor
> Fix For: 3.x
>
> Attachments: 9876-dtest-master.txt, 9876-trunk-v2.txt, 
> 9876-trunk-v3.txt, 9876-trunk.txt
>
>
> Many applications use C* by writing to one local DC. The other DC is used 
> when the local DC is unavailable. When the local DC becomes available, we 
> want to run a targeted repair b/w one endpoint from each DC to minimize the 
> data transfer over WAN.  In this case, it will be helpful to do a one way 
> repair in which data will only be streamed from other DC to local DC instead 
> of streaming the data both ways. This will further minimize the traffic over 
> WAN. This feature should only be supported if a targeted repair is run 
> involving 2 hosts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11356) EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml

[Jason Brown (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415946#comment-15415946
 ] 

Jason Brown commented on CASSANDRA-11356:
-

[~thobbs] Sorry, missed the batcall as I was out for the last several days. 
Will try to get to it in the next 24-48 hours if that's ok.

> EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml
> --
>
> Key: CASSANDRA-11356
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11356
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Reporter: Thanh
>Assignee: Paulo Motta
> Fix For: 2.2.x, 3.x
>
>
> EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml.  This is 
> problematic for those users who were using EC2MRS with an internal 
> rpc_address before the change introduced in 
> [CASSANDRA-5899|https://issues.apache.org/jira/browse/CASSANDRA-5899], 
> because the change results in EC2MRS always using the public ip regardless of 
> what the user has set for broadcast_rpc_address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-11932) Range tombstones generated instead of regular ones between 2.1 and 3.0 nodes (in 3.0 -> 2.1 direction) for some tables

[Tyler Hobbs (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tyler Hobbs updated CASSANDRA-11932:

Summary: Range tombstones generated instead of regular ones between 2.1 and 
3.0 nodes (in 3.0 -> 2.1 direction) for some tables  (was: Range tombstones 
generated instead of regular once between 2.1 and 3.0 nodes (in 3.0 -> 2.1 
direction) for some tables)

> Range tombstones generated instead of regular ones between 2.1 and 3.0 nodes 
> (in 3.0 -> 2.1 direction) for some tables
> --
>
> Key: CASSANDRA-11932
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11932
> Project: Cassandra
>  Issue Type: Bug
>  Components: Coordination
>Reporter: Aleksey Yeschenko
>Assignee: Tyler Hobbs
> Fix For: 3.0.x, 3.x
>
>
> Mixed and dynamic Thrift CFs deletions of the dynamic component are being 
> translated into range tombstones in 3.0 -> 2.1 direction. On 3.0 side they 
> are whole row deletions, and {{LegacyLayout::fromRow(CFMetaData, Row)}} turns 
> them into range tombstones even for non-composite, dynamic and mixed Thrift 
> CFs. They should be converted into single-cell deletions instead.
> This is not a correctness problem, strictly speaking, and on its own 'only' 
> causes digest mismatches on reads (and thus a lot of extra traffic w/ CL > 
> ONE) and less efficient representation on wire, though breaks some upgrades 
> in combination with CASSANDRA-11930.
> To reproduce, create a mixed CF while both nodes are on 2.1, upgrade one node 
> to 3.0, and with cqlsh connected to 3.0 remove some rows. Then do a {{SELECT 
> *}} query in cqlsh when connected to 2.1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11356) EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml

[Tyler Hobbs (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415931#comment-15415931
 ] 

Tyler Hobbs commented on CASSANDRA-11356:
-

It looks like some of the test runs were problematic, so I've restarted them to 
get some clearer results.

[~jasobrown] last call on adding a second review on this :)

> EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml
> --
>
> Key: CASSANDRA-11356
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11356
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Reporter: Thanh
>Assignee: Paulo Motta
> Fix For: 2.2.x, 3.x
>
>
> EC2MRS ignores broadcast_rpc_address setting in cassandra.yaml.  This is 
> problematic for those users who were using EC2MRS with an internal 
> rpc_address before the change introduced in 
> [CASSANDRA-5899|https://issues.apache.org/jira/browse/CASSANDRA-5899], 
> because the change results in EC2MRS always using the public ip regardless of 
> what the user has set for broadcast_rpc_address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12216) TTL Reading And Writing is Asymmetric

[Benjamin Lerer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415914#comment-15415914
 ] 

Benjamin Lerer commented on CASSANDRA-12216:


I did not have time to review the patch yet. I try to do it before the end of 
the week. Sorry, for the delay. 

> TTL Reading And Writing is Asymmetric 
> --
>
> Key: CASSANDRA-12216
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12216
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL
>Reporter: Russell Spitzer
>Assignee: Russell Spitzer
>Priority: Minor
> Fix For: 3.x
>
> Attachments: 12216-3.7-2.txt, 12216-3.7.txt, 12216-trunk.patch
>
>
> There is an inherent asymmetry in the way TTL's are read and Written. 
> An `TTL` of 0 when written becomes a `null` in C*
> When read, this `TTL` becomes a `null` 
> The `null` cannot be written back to C* as `TTL`
> This means that end users attempting to copy tables with TTL have to do 
> manual mapping of the null TTL values to 0 to avoid NPE. This is a bit 
> onerous when C* seems to have an internal logic that 0 == NULL. I don't think 
> C* should return values which are not directly insertable back to C*. 
> Even with the advent CASSANDRA-7304 this still remains a problem that the 
> User needs to be aware of and take care of.
> The following prepared statement
> {code}
> INSERT INTO test.table2 (k,v) (?,?) USING TTL: ? 
> {code}
> Will throw NPEs unless we specifically check that the value to be bound to 
> TTL is not null.
> I think we should discuss whether `null` should be treated as 0 in TTL for 
> prepared statements. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (CASSANDRA-12216) TTL Reading And Writing is Asymmetric

[Benjamin Lerer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415914#comment-15415914
 ] 

Benjamin Lerer edited comment on CASSANDRA-12216 at 8/10/16 8:02 PM:
-

I did not have time to review the patch yet. I will try to do it before the end 
of the week. Sorry, for the delay. 


was (Author: blerer):
I did not have time to review the patch yet. I try to do it before the end of 
the week. Sorry, for the delay. 

> TTL Reading And Writing is Asymmetric 
> --
>
> Key: CASSANDRA-12216
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12216
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL
>Reporter: Russell Spitzer
>Assignee: Russell Spitzer
>Priority: Minor
> Fix For: 3.x
>
> Attachments: 12216-3.7-2.txt, 12216-3.7.txt, 12216-trunk.patch
>
>
> There is an inherent asymmetry in the way TTL's are read and Written. 
> An `TTL` of 0 when written becomes a `null` in C*
> When read, this `TTL` becomes a `null` 
> The `null` cannot be written back to C* as `TTL`
> This means that end users attempting to copy tables with TTL have to do 
> manual mapping of the null TTL values to 0 to avoid NPE. This is a bit 
> onerous when C* seems to have an internal logic that 0 == NULL. I don't think 
> C* should return values which are not directly insertable back to C*. 
> Even with the advent CASSANDRA-7304 this still remains a problem that the 
> User needs to be aware of and take care of.
> The following prepared statement
> {code}
> INSERT INTO test.table2 (k,v) (?,?) USING TTL: ? 
> {code}
> Will throw NPEs unless we specifically check that the value to be bound to 
> TTL is not null.
> I think we should discuss whether `null` should be treated as 0 in TTL for 
> prepared statements. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11363) High Blocked NTR When Connecting

[T Jake Luciani (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415890#comment-15415890
 ] 

T Jake Luciani commented on CASSANDRA-11363:


Ok thanks,  I think we are best off using the System.property with a larger 
default like 4096.  I'll wait for [~zznate] to confirm this fixes his issue as 
well...

> High Blocked NTR When Connecting
> 
>
> Key: CASSANDRA-11363
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11363
> Project: Cassandra
>  Issue Type: Bug
>  Components: Coordination
>Reporter: Russell Bradberry
>Assignee: T Jake Luciani
> Attachments: cassandra-102-cms.stack, cassandra-102-g1gc.stack, 
> max_queued_ntr_property.txt, thread-queue-2.1.txt
>
>
> When upgrading from 2.1.9 to 2.1.13, we are witnessing an issue where the 
> machine load increases to very high levels (> 120 on an 8 core machine) and 
> native transport requests get blocked in tpstats.
> I was able to reproduce this in both CMS and G1GC as well as on JVM 7 and 8.
> The issue does not seem to affect the nodes running 2.1.9.
> The issue seems to coincide with the number of connections OR the number of 
> total requests being processed at a given time (as the latter increases with 
> the former in our system)
> Currently there is between 600 and 800 client connections on each machine and 
> each machine is handling roughly 2000-3000 client requests per second.
> Disabling the binary protocol fixes the issue for this node but isn't a 
> viable option cluster-wide.
> Here is the output from tpstats:
> {code}
> Pool NameActive   Pending  Completed   Blocked  All 
> time blocked
> MutationStage 0 88387821 0
>  0
> ReadStage 0 0 355860 0
>  0
> RequestResponseStage  0 72532457 0
>  0
> ReadRepairStage   0 0150 0
>  0
> CounterMutationStage 32   104 897560 0
>  0
> MiscStage 0 0  0 0
>  0
> HintedHandoff 0 0 65 0
>  0
> GossipStage   0 0   2338 0
>  0
> CacheCleanupExecutor  0 0  0 0
>  0
> InternalResponseStage 0 0  0 0
>  0
> CommitLogArchiver 0 0  0 0
>  0
> CompactionExecutor2   190474 0
>  0
> ValidationExecutor0 0  0 0
>  0
> MigrationStage0 0 10 0
>  0
> AntiEntropyStage  0 0  0 0
>  0
> PendingRangeCalculator0 0310 0
>  0
> Sampler   0 0  0 0
>  0
> MemtableFlushWriter   110 94 0
>  0
> MemtablePostFlush 134257 0
>  0
> MemtableReclaimMemory 0 0 94 0
>  0
> Native-Transport-Requests   128   156 38795716
> 278451
> Message type   Dropped
> READ 0
> RANGE_SLICE  0
> _TRACE   0
> MUTATION 0
> COUNTER_MUTATION 0
> BINARY   0
> REQUEST_RESPONSE 0
> PAGED_RANGE  0
> READ_REPAIR  0
> {code}
> Attached is the jstack output for both CMS and G1GC.
> Flight recordings are here:
> https://s3.amazonaws.com/simple-logs/cassandra-102-cms.jfr
> https://s3.amazonaws.com/simple-logs/cassandra-102-g1gc.jfr
> It is interesting to note that while the flight recording was taking place, 
> the load on the machine went back to healthy, and when the flight recording 
> finished the load went back to > 100.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12431) Getting null value for the field that has value when query result has many rows

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12431:

Fix Version/s: 2.2.x

> Getting null value for the field that has value when query result has many 
> rows
> ---
>
> Key: CASSANDRA-12431
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12431
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Fei Fang
> Fix For: 2.2.x
>
>
> Hi,
> We get null value (not an older value, but null) for a float column (score) 
> from a 20k result row query. However, when we fetch data for that specific 
> row, the column actually has value.
> The table schema is like this:
> CREATE TABLE IF NOT EXISTS email_histogram (
> id text,
> email text,
> score float,
> PRIMARY KEY (id, email)
> ) WITH bloom_filter_fp_chance = 0.01
> AND caching = 'KEYS_ONLY'
> AND comment = ''
> AND compaction =
> {'tombstone_threshold': '0.1', 'tombstone_compaction_interval': '300', 
> 'class': 'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'}
> AND compression =
> {'sstable_compression': 'org.apache.cassandra.io.compress.SnappyCompressor'}
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 864000
> AND gc_grace_seconds = 86400
> AND memtable_flush_period_in_ms = 0
> AND read_repair_chance = 0.0
> AND speculative_retry = '99.0PERCENTILE';
> This is my read query: SELECT * FROM " + TABLE_NAME + " WHERE guid = ?
> I'm using consistency One when querying it and Quorum when updating it. If I 
> insert data, I insert for all the columns, never only part of the column. I 
> understand that I might get out of date value since I'm using One to read, 
> but again here I'm not getting out of date value, but just "null". 
> This is happening on our staging server which servers 20k users, and we see 
> this error happening 10+ times everyday. I don't have an exact number of how 
> many times we do the query, but nodetool cfstats shows local read count of 
> 85314 for this table for the last 18 hours and we have 6 cassandra nodes in 
> this cluster so about 500k querying for 18 hours.
> We update the table every 3 weeks. The table has 20k rows for each key (guid) 
> I'm querying for. Out of the 20k rows, only a couple at most are null and 
> they are not the same every time we query the same key.
> We are using C# driver version 3.0.1 and Cassandra version 2.2.6.44.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12225) dtest failure in materialized_views_test.TestMaterializedViews.clustering_column_test

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12225:

Assignee: Carl Yeksigian  (was: Philip Thompson)

> dtest failure in 
> materialized_views_test.TestMaterializedViews.clustering_column_test
> -
>
> Key: CASSANDRA-12225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12225
> Project: Cassandra
>  Issue Type: Test
>Reporter: Sean McCarthy
>Assignee: Carl Yeksigian
>  Labels: dtest
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_offheap_dtest/336/testReport/materialized_views_test/TestMaterializedViews/clustering_column_test
> Failed on CassCI build trunk_offheap_dtest #336
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/materialized_views_test.py", line 
> 321, in clustering_column_test
> self.assertEqual(len(result), 2, "Expecting {} users, got {}".format(2, 
> len(result)))
>   File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
> raise self.failureException(msg)
> "Expecting 2 users, got 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12225) dtest failure in materialized_views_test.TestMaterializedViews.clustering_column_test

[Philip Thompson (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415852#comment-15415852
 ] 

Philip Thompson commented on CASSANDRA-12225:
-

Assigning this to you while you actively work on it

> dtest failure in 
> materialized_views_test.TestMaterializedViews.clustering_column_test
> -
>
> Key: CASSANDRA-12225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12225
> Project: Cassandra
>  Issue Type: Test
>Reporter: Sean McCarthy
>Assignee: Carl Yeksigian
>  Labels: dtest
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_offheap_dtest/336/testReport/materialized_views_test/TestMaterializedViews/clustering_column_test
> Failed on CassCI build trunk_offheap_dtest #336
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/materialized_views_test.py", line 
> 321, in clustering_column_test
> self.assertEqual(len(result), 2, "Expecting {} users, got {}".format(2, 
> len(result)))
>   File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
> raise self.failureException(msg)
> "Expecting 2 users, got 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12256) Properly respect the request timeouts

[Tyler Hobbs (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415830#comment-15415830
 ] 

Tyler Hobbs commented on CASSANDRA-12256:
-

The patch looks good.  Nice job, [~geoffxy].

I've started CI test runs here:
||branch||testall||dtest||
|[CASSANDRA-12256-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-12256-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12256-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12256-trunk-dtest]|

Additionally, I added a {{NEWS.txt}} entry to make upgrading users aware of 
this change.

> Properly respect the request timeouts
> -
>
> Key: CASSANDRA-12256
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12256
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Sylvain Lebresne
>Assignee: Geoffrey Yu
> Fix For: 3.x
>
> Attachments: 12256-trunk.txt
>
>
> We have a number of {{request_timeout_*}} option, that probably every user 
> expect to be an upper bound on how long the coordinator will wait before 
> timeouting a request, but it's actually not always the case, especially for 
> read requests.
> I believe we don't respect those timeout properly in at least the following 
> cases:
> * On a digest mismatch: in that case, we reset the timeout for the data 
> query, which means the overall query might take up to twice the configured 
> timeout before timeouting.
> * On a range query: the timeout is reset for every sub-range that is queried. 
> With many nodes and vnodes, a range query could span tons of sub-range and so 
> a range query could take pretty much arbitrary long before actually 
> timeouting for the user.
> * On short reads: we also reset the timeout for every short reads "retries".
> It's also worth noting that even outside those, the timeouts don't take most 
> of the processing done by the coordinator (query parsing and CQL handling for 
> instance) into account.
> Now, in all fairness, the reason this is this way is that the timeout 
> currently are *not* timeout for the full user request, but rather how long a 
> coordinator should wait on any given replica for any given internal query 
> before giving up. *However*, I'm pretty sure this is not what user 
> intuitively expect and want, *especially* in the context of CASSANDRA-2848 
> where the goal is explicitely to have an upper bound on the query from the 
> user point of view.
> So I'm suggesting we change how those timeouts are handled to really be 
> timeouts on the whole user query.
> And by that I basically just mean that we'd mark the start of each query as 
> soon as possible in the processing, and use that starting time as base in 
> {{ReadCallback.await}} and {{AbstractWriteResponseHandler.get()}}. It won't 
> be perfect in the sense that we'll still only possibly timeout during 
> "blocking" operations, so typically if parsing a query takes more than your 
> timeout, you still won't timeout until that query is sent, but I think that's 
> probably fine in practice because 1) if you timeouts are small enough that 
> this matter, you're probably doing it wrong and 2) we can totally improve on 
> that later if needs be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12225) dtest failure in materialized_views_test.TestMaterializedViews.clustering_column_test

[Carl Yeksigian (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415818#comment-15415818
 ] 

Carl Yeksigian commented on CASSANDRA-12225:


I was finally able to reproduce this locally.

Since it is so uncommon, I am hoping this is down to a timing issue between the 
base and the view updates. We return from the base mutation being applied 
before the view is applied. In the case where it failed for me, node3 was 
marked down by the other nodes, so it is possible there was an inconsistent 
read here.

I've pushed [a dtest 
branch|https://github.com/carlyeks/cassandra-dtest/tree/fix-12225] which 
replays the batchlogs after inserting data; hopefully that will help this test. 
I'm currently running this locally to see whether it can still be reproduced.

> dtest failure in 
> materialized_views_test.TestMaterializedViews.clustering_column_test
> -
>
> Key: CASSANDRA-12225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12225
> Project: Cassandra
>  Issue Type: Test
>Reporter: Sean McCarthy
>Assignee: Philip Thompson
>  Labels: dtest
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_offheap_dtest/336/testReport/materialized_views_test/TestMaterializedViews/clustering_column_test
> Failed on CassCI build trunk_offheap_dtest #336
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/materialized_views_test.py", line 
> 321, in clustering_column_test
> self.assertEqual(len(result), 2, "Expecting {} users, got {}".format(2, 
> len(result)))
>   File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
> raise self.failureException(msg)
> "Expecting 2 users, got 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-11752) histograms/metrics in 2.2 do not appear recency biased

[T Jake Luciani (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

T Jake Luciani updated CASSANDRA-11752:
---
   Resolution: Fixed
Fix Version/s: 3.9
   3.0.9
   Status: Resolved  (was: Patch Available)

Committed thanks Per!

> histograms/metrics in 2.2 do not appear recency biased
> --
>
> Key: CASSANDRA-11752
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11752
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Reporter: Chris Burroughs
>Assignee: Per Otterström
>  Labels: metrics
> Fix For: 2.2.8, 3.0.9, 3.9
>
> Attachments: 11752-2.2-v2.txt, 11752-2.2.txt, boost-metrics.png, 
> c-jconsole-comparison.png, c-metrics.png, default-histogram.png, 
> server-patch-v2.png
>
>
> In addition to upgrading to metrics3, CASSANDRA-5657 switched to using  a 
> custom histogram implementation.  After upgrading to Cassandra 2.2 
> histograms/timer metrics are not suspiciously flat.  To be useful for 
> graphing and alerting metrics need to be biased towards recent events.
> I have attached images that I think illustrate this.
>  * The first two are a comparison between latency observed by a C* 2.2 (us) 
> cluster shoring very flat lines and a client (using metrics 2.2.0, ms) 
> showing server performance problems.  We can't rule out with total certainty 
> that something else isn't the cause (that's why we measure from both the 
> client & server) but they very rarely disagree.
>  * The 3rd image compares jconsole viewing of metrics on a 2.2 and 2.1 
> cluster over several minutes.  Not a single digit changed on the 2.2 cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12268) Make MV Index creation robust for wide referent rows

[T Jake Luciani (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415777#comment-15415777
 ] 

T Jake Luciani commented on CASSANDRA-12268:


I think you need to restart those tests since they didn't run for 3.0 but the 
trunk version has [View test 
failures|https://cassci.datastax.com/view/Dev/view/carlyeks/job/carlyeks-ticket-12268-testall/lastCompletedBuild/testReport/]

> Make MV Index creation robust for wide referent rows
> 
>
> Key: CASSANDRA-12268
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12268
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Jonathan Shook
>Assignee: Carl Yeksigian
> Fix For: 3.0.x, 3.x
>
> Attachments: 12268.py
>
>
> When creating an index for a materialized view for extant data, heap pressure 
> is very dependent on the cardinality of of rows associated with each index 
> value. With the way that per-index value rows are created within the index, 
> this can cause unbounded heap pressure, which can cause OOM. This appears to 
> be a side-effect of how each index row is applied atomically as with batches.
> The commit logs can accumulate enough during the process to prevent the node 
> from being restarted. Given that this occurs during global index creation, 
> this can happen on multiple nodes, making stable recovery of a node set 
> difficult, as co-replicas become unavailable to assist in back-filling data 
> from commitlogs.
> While it is understandable that you want to avoid having relatively wide rows 
>  even in materialized views, this represents a particularly difficult 
> scenario for triage.
> The basic recommendation for improving this is to sub-group the index 
> creation into smaller chunks internally, providing a maximal bound against 
> the heap pressure when it is needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-9876) One way targeted repair

[Geoffrey Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-9876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Geoffrey Yu updated CASSANDRA-9876:
---
Attachment: 9876-trunk-v3.txt

I've attached a v3 patch that makes some changes to {{RepairOptionTest}} to 
address the new behavior of {{RepairOption.parse()}}. The patch has four 
commits. The first is the v2 patch, the second and third are your ninja 
commits, and the fourth are the test changes. Please take a look and let me 
know what you think!

> One way targeted repair
> ---
>
> Key: CASSANDRA-9876
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9876
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: sankalp kohli
>Assignee: Geoffrey Yu
>Priority: Minor
> Fix For: 3.x
>
> Attachments: 9876-dtest-master.txt, 9876-trunk-v2.txt, 
> 9876-trunk-v3.txt, 9876-trunk.txt
>
>
> Many applications use C* by writing to one local DC. The other DC is used 
> when the local DC is unavailable. When the local DC becomes available, we 
> want to run a targeted repair b/w one endpoint from each DC to minimize the 
> data transfer over WAN.  In this case, it will be helpful to do a one way 
> repair in which data will only be streamed from other DC to local DC instead 
> of streaming the data both ways. This will further minimize the traffic over 
> WAN. This feature should only be supported if a targeted repair is run 
> involving 2 hosts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[03/10] cassandra git commit: Add decay to histograms and timers used for metrics

[jake]

Add decay to histograms and timers used for metrics

Patch by Per Otterstrom; reviewed by tjake for CASSANDRA-11752


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2e902596
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2e902596
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2e902596

Branch: refs/heads/cassandra-3.9
Commit: 2e90259669bddf04b6c1dba38b604aa6a33dcd47
Parents: 76e3100
Author: Per Otterstrom 
Authored: Thu Jun 23 01:01:39 2016 +0200
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:37:45 2016 -0400

--
 CHANGES.txt |   1 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 936 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 232203e..05059cc 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.2.8
+ * Add decay to histograms and timers used for metrics (CASSANDRA-11752)
  * Fix hanging stream session (CASSANDRA-10992)
  * Add byteman support for testing (CASSANDRA-12377)
  * Fix INSERT JSON, fromJson() support of smallint, tinyint types 
(CASSANDRA-12371)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
--
diff --git 
a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java 
b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
index 6fdb2ff..8e5671b 100644
--- a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
+++ b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
@@ -60,7 +60,7 @@ public class CassandraMetricsRegistry extends MetricRegistry
 
 public Histogram histogram(MetricName name, boolean considerZeroes)
 {
-Histogram histogram = register(name, new ClearableHistogram(new 
EstimatedHistogramReservoir(considerZeroes)));
+Histogram histogram = register(name, new ClearableHistogram(new 
DecayingEstimatedHistogramReservoir(considerZeroes)));
 registerMBean(histogram, name.getMBeanName());
 
 return histogram;
@@ -68,7 +68,7 @@ public class CassandraMetricsRegistry extends MetricRegistry
 
 public Timer timer(MetricName name)
 {
-Timer timer = register(name, new Timer(new 
EstimatedHistogramReservoir(false)));
+Timer timer = register(name, new Timer(new 
DecayingEstimatedHistogramReservoir()));
 registerMBean(timer, name.getMBeanName());
 
 return timer;

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
--
diff --git a/src/java/org/apache/cassandra/metrics/ClearableHistogram.java 
b/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
index 85f2fa9..4a081d8 100644
--- a/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
+++ b/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
@@ -26,14 +26,14 @@ import com.codahale.metrics.Histogram;
  */
 public class ClearableHistogram extends Histogram
 {
-private final EstimatedHistogramReservoir reservoirRef;
+private final DecayingEstimatedHistogramReservoir reservoirRef;
 
 /**
  * Creates a new {@link com.codahale.metrics.Histogram} with the given 
reservoir.
  *
  * @param reservoir the reservoir to create a histogram from
  */
-public ClearableHistogram(EstimatedHistogramReservoir reservoir)
+public ClearableHistogram(DecayingEstimatedHistogramReservoir reservoir)
 {
 super(reservoir);
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
--
diff --git 
a/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
 
b/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
new file mode 100644
index 000..14a4366
--- /dev/null
+++ 
b/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
@@ -0,0 +1,549 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under 

[08/10] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.9

[jake]

Merge branch 'cassandra-3.0' into cassandra-3.9


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1fff069a
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1fff069a
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1fff069a

Branch: refs/heads/cassandra-3.9
Commit: 1fff069ad90b33dcda6d231ca5e327758f844388
Parents: c3e636c 2691c9e
Author: T Jake Luciani 
Authored: Wed Aug 10 14:43:13 2016 -0400
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:43:13 2016 -0400

--
 CHANGES.txt |   3 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 938 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/1fff069a/CHANGES.txt
--

http://git-wip-us.apache.org/repos/asf/cassandra/blob/1fff069a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
--

[07/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

[jake]

Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2691c9e4
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2691c9e4
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2691c9e4

Branch: refs/heads/trunk
Commit: 2691c9e4e12a72f143bb2f00d076ecbfad59f4e4
Parents: 465def8 2e90259
Author: T Jake Luciani 
Authored: Wed Aug 10 14:39:52 2016 -0400
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:39:52 2016 -0400

--
 CHANGES.txt |   1 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 936 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2691c9e4/CHANGES.txt
--
diff --cc CHANGES.txt
index 86746ad,05059cc..e1bc9f3
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,37 -1,7 +1,38 @@@
 -2.2.8
 +3.0.9
 + * Fix potential bad messaging service message for paged range reads
 +   within mixed-version 3.x clusters (CASSANDRA-12249)
 + * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)
 + * NullPointerException during compaction on table with static columns 
(CASSANDRA-12336)
 + * Fixed ConcurrentModificationException when reading metrics in 
GraphiteReporter (CASSANDRA-11823)
 + * Fix upgrade of super columns on thrift (CASSANDRA-12335)
 + * Fixed flacky BlacklistingCompactionsTest, switched to fixed size types and 
increased corruption size (CASSANDRA-12359)
 + * Rerun ReplicationAwareTokenAllocatorTest on failure to avoid flakiness 
(CASSANDRA-12277)
 + * Exception when computing read-repair for range tombstones (CASSANDRA-12263)
 + * Lost counter writes in compact table and static columns (CASSANDRA-12219)
 + * AssertionError with MVs on updating a row that isn't indexed due to a null 
value (CASSANDRA-12247)
 + * Disable RR and speculative retry with EACH_QUORUM reads (CASSANDRA-11980)
 + * Add option to override compaction space check (CASSANDRA-12180)
 + * Faster startup by only scanning each directory for temporary files once 
(CASSANDRA-12114)
 + * Respond with v1/v2 protocol header when responding to driver that attempts
 +   to connect with too low of a protocol version (CASSANDRA-11464)
 + * NullPointerExpception when reading/compacting table (CASSANDRA-11988)
 + * Fix problem with undeleteable rows on upgrade to new sstable format 
(CASSANDRA-12144)
 + * Fix paging logic for deleted partitions with static columns 
(CASSANDRA-12107)
 + * Wait until the message is being send to decide which serializer must be 
used (CASSANDRA-11393)
 + * Fix migration of static thrift column names with non-text comparators 
(CASSANDRA-12147)
 + * Fix upgrading sparse tables that are incorrectly marked as dense 
(CASSANDRA-11315)
 + * Fix reverse queries ignoring range tombstones (CASSANDRA-11733)
 + * Avoid potential race when rebuilding CFMetaData (CASSANDRA-12098)
 + * Avoid missing sstables when getting the canonical sstables 
(CASSANDRA-11996)
 + * Always select the live sstables when getting sstables in bounds 
(CASSANDRA-11944)
 + * Fix column ordering of results with static columns for Thrift requests in
 +   a mixed 2.x/3.x cluster, also fix potential non-resolved duplication of
 +   those static columns in query results (CASSANDRA-12123)
 + * Avoid digest mismatch with empty but static rows (CASSANDRA-12090)
 + * Fix EOF exception when altering column type (CASSANDRA-11820)
 +Merged from 2.2:
+  * Add decay to histograms and timers used for metrics (CASSANDRA-11752)
   * Fix hanging stream session (CASSANDRA-10992)
 - * Add byteman support for testing (CASSANDRA-12377)
   * Fix INSERT JSON, fromJson() support of smallint, tinyint types 
(CASSANDRA-12371)
   * Restore JVM metric export for metric reporters (CASSANDRA-12312)
   * Release sstables of failed stream sessions only when outgoing transfers 
are finished (CASSANDRA-11345)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2691c9e4/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
--
diff --cc src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
index 1cd3b6c,8e5671b..2d4cbf9
--- a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
+++ b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
@@@ -65,31 -58,17 

[06/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

[jake]

Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2691c9e4
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2691c9e4
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2691c9e4

Branch: refs/heads/cassandra-3.0
Commit: 2691c9e4e12a72f143bb2f00d076ecbfad59f4e4
Parents: 465def8 2e90259
Author: T Jake Luciani 
Authored: Wed Aug 10 14:39:52 2016 -0400
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:39:52 2016 -0400

--
 CHANGES.txt |   1 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 936 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2691c9e4/CHANGES.txt
--
diff --cc CHANGES.txt
index 86746ad,05059cc..e1bc9f3
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,37 -1,7 +1,38 @@@
 -2.2.8
 +3.0.9
 + * Fix potential bad messaging service message for paged range reads
 +   within mixed-version 3.x clusters (CASSANDRA-12249)
 + * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)
 + * NullPointerException during compaction on table with static columns 
(CASSANDRA-12336)
 + * Fixed ConcurrentModificationException when reading metrics in 
GraphiteReporter (CASSANDRA-11823)
 + * Fix upgrade of super columns on thrift (CASSANDRA-12335)
 + * Fixed flacky BlacklistingCompactionsTest, switched to fixed size types and 
increased corruption size (CASSANDRA-12359)
 + * Rerun ReplicationAwareTokenAllocatorTest on failure to avoid flakiness 
(CASSANDRA-12277)
 + * Exception when computing read-repair for range tombstones (CASSANDRA-12263)
 + * Lost counter writes in compact table and static columns (CASSANDRA-12219)
 + * AssertionError with MVs on updating a row that isn't indexed due to a null 
value (CASSANDRA-12247)
 + * Disable RR and speculative retry with EACH_QUORUM reads (CASSANDRA-11980)
 + * Add option to override compaction space check (CASSANDRA-12180)
 + * Faster startup by only scanning each directory for temporary files once 
(CASSANDRA-12114)
 + * Respond with v1/v2 protocol header when responding to driver that attempts
 +   to connect with too low of a protocol version (CASSANDRA-11464)
 + * NullPointerExpception when reading/compacting table (CASSANDRA-11988)
 + * Fix problem with undeleteable rows on upgrade to new sstable format 
(CASSANDRA-12144)
 + * Fix paging logic for deleted partitions with static columns 
(CASSANDRA-12107)
 + * Wait until the message is being send to decide which serializer must be 
used (CASSANDRA-11393)
 + * Fix migration of static thrift column names with non-text comparators 
(CASSANDRA-12147)
 + * Fix upgrading sparse tables that are incorrectly marked as dense 
(CASSANDRA-11315)
 + * Fix reverse queries ignoring range tombstones (CASSANDRA-11733)
 + * Avoid potential race when rebuilding CFMetaData (CASSANDRA-12098)
 + * Avoid missing sstables when getting the canonical sstables 
(CASSANDRA-11996)
 + * Always select the live sstables when getting sstables in bounds 
(CASSANDRA-11944)
 + * Fix column ordering of results with static columns for Thrift requests in
 +   a mixed 2.x/3.x cluster, also fix potential non-resolved duplication of
 +   those static columns in query results (CASSANDRA-12123)
 + * Avoid digest mismatch with empty but static rows (CASSANDRA-12090)
 + * Fix EOF exception when altering column type (CASSANDRA-11820)
 +Merged from 2.2:
+  * Add decay to histograms and timers used for metrics (CASSANDRA-11752)
   * Fix hanging stream session (CASSANDRA-10992)
 - * Add byteman support for testing (CASSANDRA-12377)
   * Fix INSERT JSON, fromJson() support of smallint, tinyint types 
(CASSANDRA-12371)
   * Restore JVM metric export for metric reporters (CASSANDRA-12312)
   * Release sstables of failed stream sessions only when outgoing transfers 
are finished (CASSANDRA-11345)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2691c9e4/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
--
diff --cc src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
index 1cd3b6c,8e5671b..2d4cbf9
--- a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
+++ b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
@@@ 

[05/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

[jake]

Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2691c9e4
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2691c9e4
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2691c9e4

Branch: refs/heads/cassandra-3.9
Commit: 2691c9e4e12a72f143bb2f00d076ecbfad59f4e4
Parents: 465def8 2e90259
Author: T Jake Luciani 
Authored: Wed Aug 10 14:39:52 2016 -0400
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:39:52 2016 -0400

--
 CHANGES.txt |   1 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 936 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2691c9e4/CHANGES.txt
--
diff --cc CHANGES.txt
index 86746ad,05059cc..e1bc9f3
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,37 -1,7 +1,38 @@@
 -2.2.8
 +3.0.9
 + * Fix potential bad messaging service message for paged range reads
 +   within mixed-version 3.x clusters (CASSANDRA-12249)
 + * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)
 + * NullPointerException during compaction on table with static columns 
(CASSANDRA-12336)
 + * Fixed ConcurrentModificationException when reading metrics in 
GraphiteReporter (CASSANDRA-11823)
 + * Fix upgrade of super columns on thrift (CASSANDRA-12335)
 + * Fixed flacky BlacklistingCompactionsTest, switched to fixed size types and 
increased corruption size (CASSANDRA-12359)
 + * Rerun ReplicationAwareTokenAllocatorTest on failure to avoid flakiness 
(CASSANDRA-12277)
 + * Exception when computing read-repair for range tombstones (CASSANDRA-12263)
 + * Lost counter writes in compact table and static columns (CASSANDRA-12219)
 + * AssertionError with MVs on updating a row that isn't indexed due to a null 
value (CASSANDRA-12247)
 + * Disable RR and speculative retry with EACH_QUORUM reads (CASSANDRA-11980)
 + * Add option to override compaction space check (CASSANDRA-12180)
 + * Faster startup by only scanning each directory for temporary files once 
(CASSANDRA-12114)
 + * Respond with v1/v2 protocol header when responding to driver that attempts
 +   to connect with too low of a protocol version (CASSANDRA-11464)
 + * NullPointerExpception when reading/compacting table (CASSANDRA-11988)
 + * Fix problem with undeleteable rows on upgrade to new sstable format 
(CASSANDRA-12144)
 + * Fix paging logic for deleted partitions with static columns 
(CASSANDRA-12107)
 + * Wait until the message is being send to decide which serializer must be 
used (CASSANDRA-11393)
 + * Fix migration of static thrift column names with non-text comparators 
(CASSANDRA-12147)
 + * Fix upgrading sparse tables that are incorrectly marked as dense 
(CASSANDRA-11315)
 + * Fix reverse queries ignoring range tombstones (CASSANDRA-11733)
 + * Avoid potential race when rebuilding CFMetaData (CASSANDRA-12098)
 + * Avoid missing sstables when getting the canonical sstables 
(CASSANDRA-11996)
 + * Always select the live sstables when getting sstables in bounds 
(CASSANDRA-11944)
 + * Fix column ordering of results with static columns for Thrift requests in
 +   a mixed 2.x/3.x cluster, also fix potential non-resolved duplication of
 +   those static columns in query results (CASSANDRA-12123)
 + * Avoid digest mismatch with empty but static rows (CASSANDRA-12090)
 + * Fix EOF exception when altering column type (CASSANDRA-11820)
 +Merged from 2.2:
+  * Add decay to histograms and timers used for metrics (CASSANDRA-11752)
   * Fix hanging stream session (CASSANDRA-10992)
 - * Add byteman support for testing (CASSANDRA-12377)
   * Fix INSERT JSON, fromJson() support of smallint, tinyint types 
(CASSANDRA-12371)
   * Restore JVM metric export for metric reporters (CASSANDRA-12312)
   * Release sstables of failed stream sessions only when outgoing transfers 
are finished (CASSANDRA-11345)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2691c9e4/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
--
diff --cc src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
index 1cd3b6c,8e5671b..2d4cbf9
--- a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
+++ b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
@@@ 

[02/10] cassandra git commit: Add decay to histograms and timers used for metrics

[jake]

Add decay to histograms and timers used for metrics

Patch by Per Otterstrom; reviewed by tjake for CASSANDRA-11752


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2e902596
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2e902596
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2e902596

Branch: refs/heads/cassandra-3.0
Commit: 2e90259669bddf04b6c1dba38b604aa6a33dcd47
Parents: 76e3100
Author: Per Otterstrom 
Authored: Thu Jun 23 01:01:39 2016 +0200
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:37:45 2016 -0400

--
 CHANGES.txt |   1 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 936 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 232203e..05059cc 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.2.8
+ * Add decay to histograms and timers used for metrics (CASSANDRA-11752)
  * Fix hanging stream session (CASSANDRA-10992)
  * Add byteman support for testing (CASSANDRA-12377)
  * Fix INSERT JSON, fromJson() support of smallint, tinyint types 
(CASSANDRA-12371)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
--
diff --git 
a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java 
b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
index 6fdb2ff..8e5671b 100644
--- a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
+++ b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
@@ -60,7 +60,7 @@ public class CassandraMetricsRegistry extends MetricRegistry
 
 public Histogram histogram(MetricName name, boolean considerZeroes)
 {
-Histogram histogram = register(name, new ClearableHistogram(new 
EstimatedHistogramReservoir(considerZeroes)));
+Histogram histogram = register(name, new ClearableHistogram(new 
DecayingEstimatedHistogramReservoir(considerZeroes)));
 registerMBean(histogram, name.getMBeanName());
 
 return histogram;
@@ -68,7 +68,7 @@ public class CassandraMetricsRegistry extends MetricRegistry
 
 public Timer timer(MetricName name)
 {
-Timer timer = register(name, new Timer(new 
EstimatedHistogramReservoir(false)));
+Timer timer = register(name, new Timer(new 
DecayingEstimatedHistogramReservoir()));
 registerMBean(timer, name.getMBeanName());
 
 return timer;

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
--
diff --git a/src/java/org/apache/cassandra/metrics/ClearableHistogram.java 
b/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
index 85f2fa9..4a081d8 100644
--- a/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
+++ b/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
@@ -26,14 +26,14 @@ import com.codahale.metrics.Histogram;
  */
 public class ClearableHistogram extends Histogram
 {
-private final EstimatedHistogramReservoir reservoirRef;
+private final DecayingEstimatedHistogramReservoir reservoirRef;
 
 /**
  * Creates a new {@link com.codahale.metrics.Histogram} with the given 
reservoir.
  *
  * @param reservoir the reservoir to create a histogram from
  */
-public ClearableHistogram(EstimatedHistogramReservoir reservoir)
+public ClearableHistogram(DecayingEstimatedHistogramReservoir reservoir)
 {
 super(reservoir);
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
--
diff --git 
a/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
 
b/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
new file mode 100644
index 000..14a4366
--- /dev/null
+++ 
b/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
@@ -0,0 +1,549 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under 

[09/10] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.9

[jake]

Merge branch 'cassandra-3.0' into cassandra-3.9


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1fff069a
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1fff069a
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1fff069a

Branch: refs/heads/trunk
Commit: 1fff069ad90b33dcda6d231ca5e327758f844388
Parents: c3e636c 2691c9e
Author: T Jake Luciani 
Authored: Wed Aug 10 14:43:13 2016 -0400
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:43:13 2016 -0400

--
 CHANGES.txt |   3 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 938 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/1fff069a/CHANGES.txt
--

http://git-wip-us.apache.org/repos/asf/cassandra/blob/1fff069a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
--

[04/10] cassandra git commit: Add decay to histograms and timers used for metrics

[jake]

Add decay to histograms and timers used for metrics

Patch by Per Otterstrom; reviewed by tjake for CASSANDRA-11752


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2e902596
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2e902596
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2e902596

Branch: refs/heads/trunk
Commit: 2e90259669bddf04b6c1dba38b604aa6a33dcd47
Parents: 76e3100
Author: Per Otterstrom 
Authored: Thu Jun 23 01:01:39 2016 +0200
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:37:45 2016 -0400

--
 CHANGES.txt |   1 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 936 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 232203e..05059cc 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.2.8
+ * Add decay to histograms and timers used for metrics (CASSANDRA-11752)
  * Fix hanging stream session (CASSANDRA-10992)
  * Add byteman support for testing (CASSANDRA-12377)
  * Fix INSERT JSON, fromJson() support of smallint, tinyint types 
(CASSANDRA-12371)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
--
diff --git 
a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java 
b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
index 6fdb2ff..8e5671b 100644
--- a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
+++ b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
@@ -60,7 +60,7 @@ public class CassandraMetricsRegistry extends MetricRegistry
 
 public Histogram histogram(MetricName name, boolean considerZeroes)
 {
-Histogram histogram = register(name, new ClearableHistogram(new 
EstimatedHistogramReservoir(considerZeroes)));
+Histogram histogram = register(name, new ClearableHistogram(new 
DecayingEstimatedHistogramReservoir(considerZeroes)));
 registerMBean(histogram, name.getMBeanName());
 
 return histogram;
@@ -68,7 +68,7 @@ public class CassandraMetricsRegistry extends MetricRegistry
 
 public Timer timer(MetricName name)
 {
-Timer timer = register(name, new Timer(new 
EstimatedHistogramReservoir(false)));
+Timer timer = register(name, new Timer(new 
DecayingEstimatedHistogramReservoir()));
 registerMBean(timer, name.getMBeanName());
 
 return timer;

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
--
diff --git a/src/java/org/apache/cassandra/metrics/ClearableHistogram.java 
b/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
index 85f2fa9..4a081d8 100644
--- a/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
+++ b/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
@@ -26,14 +26,14 @@ import com.codahale.metrics.Histogram;
  */
 public class ClearableHistogram extends Histogram
 {
-private final EstimatedHistogramReservoir reservoirRef;
+private final DecayingEstimatedHistogramReservoir reservoirRef;
 
 /**
  * Creates a new {@link com.codahale.metrics.Histogram} with the given 
reservoir.
  *
  * @param reservoir the reservoir to create a histogram from
  */
-public ClearableHistogram(EstimatedHistogramReservoir reservoir)
+public ClearableHistogram(DecayingEstimatedHistogramReservoir reservoir)
 {
 super(reservoir);
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
--
diff --git 
a/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
 
b/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
new file mode 100644
index 000..14a4366
--- /dev/null
+++ 
b/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
@@ -0,0 +1,549 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or 

[10/10] cassandra git commit: Merge branch 'cassandra-3.9' into trunk

[jake]

Merge branch 'cassandra-3.9' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f467c852
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f467c852
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f467c852

Branch: refs/heads/trunk
Commit: f467c8523d7dfc315d246689eec82abaef81d070
Parents: 10649b1 1fff069
Author: T Jake Luciani 
Authored: Wed Aug 10 14:43:37 2016 -0400
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:43:37 2016 -0400

--
 CHANGES.txt |   3 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 938 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/f467c852/CHANGES.txt
--

[01/10] cassandra git commit: Add decay to histograms and timers used for metrics

[jake]

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-2.2 76e3100ff -> 2e9025966
  refs/heads/cassandra-3.0 465def8e2 -> 2691c9e4e
  refs/heads/cassandra-3.9 c3e636c52 -> 1fff069ad
  refs/heads/trunk 10649b1ce -> f467c8523


Add decay to histograms and timers used for metrics

Patch by Per Otterstrom; reviewed by tjake for CASSANDRA-11752


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2e902596
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2e902596
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2e902596

Branch: refs/heads/cassandra-2.2
Commit: 2e90259669bddf04b6c1dba38b604aa6a33dcd47
Parents: 76e3100
Author: Per Otterstrom 
Authored: Thu Jun 23 01:01:39 2016 +0200
Committer: T Jake Luciani 
Committed: Wed Aug 10 14:37:45 2016 -0400

--
 CHANGES.txt |   1 +
 .../metrics/CassandraMetricsRegistry.java   |   4 +-
 .../cassandra/metrics/ClearableHistogram.java   |   4 +-
 .../DecayingEstimatedHistogramReservoir.java| 549 +++
 .../metrics/EstimatedHistogramReservoir.java| 111 
 .../cassandra/utils/EstimatedHistogram.java |   2 +-
 ...DecayingEstimatedHistogramReservoirTest.java | 381 +
 7 files changed, 936 insertions(+), 116 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 232203e..05059cc 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.2.8
+ * Add decay to histograms and timers used for metrics (CASSANDRA-11752)
  * Fix hanging stream session (CASSANDRA-10992)
  * Add byteman support for testing (CASSANDRA-12377)
  * Fix INSERT JSON, fromJson() support of smallint, tinyint types 
(CASSANDRA-12371)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
--
diff --git 
a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java 
b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
index 6fdb2ff..8e5671b 100644
--- a/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
+++ b/src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
@@ -60,7 +60,7 @@ public class CassandraMetricsRegistry extends MetricRegistry
 
 public Histogram histogram(MetricName name, boolean considerZeroes)
 {
-Histogram histogram = register(name, new ClearableHistogram(new 
EstimatedHistogramReservoir(considerZeroes)));
+Histogram histogram = register(name, new ClearableHistogram(new 
DecayingEstimatedHistogramReservoir(considerZeroes)));
 registerMBean(histogram, name.getMBeanName());
 
 return histogram;
@@ -68,7 +68,7 @@ public class CassandraMetricsRegistry extends MetricRegistry
 
 public Timer timer(MetricName name)
 {
-Timer timer = register(name, new Timer(new 
EstimatedHistogramReservoir(false)));
+Timer timer = register(name, new Timer(new 
DecayingEstimatedHistogramReservoir()));
 registerMBean(timer, name.getMBeanName());
 
 return timer;

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
--
diff --git a/src/java/org/apache/cassandra/metrics/ClearableHistogram.java 
b/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
index 85f2fa9..4a081d8 100644
--- a/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
+++ b/src/java/org/apache/cassandra/metrics/ClearableHistogram.java
@@ -26,14 +26,14 @@ import com.codahale.metrics.Histogram;
  */
 public class ClearableHistogram extends Histogram
 {
-private final EstimatedHistogramReservoir reservoirRef;
+private final DecayingEstimatedHistogramReservoir reservoirRef;
 
 /**
  * Creates a new {@link com.codahale.metrics.Histogram} with the given 
reservoir.
  *
  * @param reservoir the reservoir to create a histogram from
  */
-public ClearableHistogram(EstimatedHistogramReservoir reservoir)
+public ClearableHistogram(DecayingEstimatedHistogramReservoir reservoir)
 {
 super(reservoir);
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2e902596/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
--
diff --git 
a/src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
 

[jira] [Commented] (CASSANDRA-12216) TTL Reading And Writing is Asymmetric

[Russell Spitzer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415740#comment-15415740
 ] 

Russell Spitzer commented on CASSANDRA-12216:
-

Just checking in to see if anything more is needed from me

> TTL Reading And Writing is Asymmetric 
> --
>
> Key: CASSANDRA-12216
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12216
> Project: Cassandra
>  Issue Type: Improvement
>  Components: CQL
>Reporter: Russell Spitzer
>Assignee: Russell Spitzer
>Priority: Minor
> Fix For: 3.x
>
> Attachments: 12216-3.7-2.txt, 12216-3.7.txt, 12216-trunk.patch
>
>
> There is an inherent asymmetry in the way TTL's are read and Written. 
> An `TTL` of 0 when written becomes a `null` in C*
> When read, this `TTL` becomes a `null` 
> The `null` cannot be written back to C* as `TTL`
> This means that end users attempting to copy tables with TTL have to do 
> manual mapping of the null TTL values to 0 to avoid NPE. This is a bit 
> onerous when C* seems to have an internal logic that 0 == NULL. I don't think 
> C* should return values which are not directly insertable back to C*. 
> Even with the advent CASSANDRA-7304 this still remains a problem that the 
> User needs to be aware of and take care of.
> The following prepared statement
> {code}
> INSERT INTO test.table2 (k,v) (?,?) USING TTL: ? 
> {code}
> Will throw NPEs unless we specifically check that the value to be bound to 
> TTL is not null.
> I think we should discuss whether `null` should be treated as 0 in TTL for 
> prepared statements. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11635) test-clientutil-jar unit test fails

[Russell Spitzer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415737#comment-15415737
 ] 

Russell Spitzer commented on CASSANDRA-11635:
-

+1, We will remove that dep officially with 
https://datastax-oss.atlassian.net/browse/SPARKC-414

> test-clientutil-jar unit test fails
> ---
>
> Key: CASSANDRA-11635
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11635
> Project: Cassandra
>  Issue Type: Test
>  Components: Testing
>Reporter: Michael Shuler
>Assignee: Sylvain Lebresne
>  Labels: unittest
> Fix For: 2.2.x, 3.0.x, 3.x
>
>
> {noformat}
> test-clientutil-jar:
> [junit] Testsuite: org.apache.cassandra.serializers.ClientUtilsTest
> [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 0.314 sec
> [junit] 
> [junit] Testcase: test(org.apache.cassandra.serializers.ClientUtilsTest): 
>   Caused an ERROR
> [junit] org/apache/cassandra/utils/SigarLibrary
> [junit] java.lang.NoClassDefFoundError: 
> org/apache/cassandra/utils/SigarLibrary
> [junit] at org.apache.cassandra.utils.UUIDGen.hash(UUIDGen.java:328)
> [junit] at 
> org.apache.cassandra.utils.UUIDGen.makeNode(UUIDGen.java:307)
> [junit] at 
> org.apache.cassandra.utils.UUIDGen.makeClockSeqAndNode(UUIDGen.java:256)
> [junit] at 
> org.apache.cassandra.utils.UUIDGen.(UUIDGen.java:39)
> [junit] at 
> org.apache.cassandra.serializers.ClientUtilsTest.test(ClientUtilsTest.java:56)
> [junit] Caused by: java.lang.ClassNotFoundException: 
> org.apache.cassandra.utils.SigarLibrary
> [junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> [junit] at 
> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> [junit] 
> [junit] 
> [junit] Test org.apache.cassandra.serializers.ClientUtilsTest FAILED
> BUILD FAILED
> {noformat}
> I'll see if I can find a spot where this passes, but it appears to have been 
> failing for a long time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11635) test-clientutil-jar unit test fails

[Jason Brown (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415726#comment-15415726
 ] 

Jason Brown commented on CASSANDRA-11635:
-

+1, as well. The clientutil jar might have been useful back in the thrift days, 
but those days are gone.

> test-clientutil-jar unit test fails
> ---
>
> Key: CASSANDRA-11635
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11635
> Project: Cassandra
>  Issue Type: Test
>  Components: Testing
>Reporter: Michael Shuler
>Assignee: Sylvain Lebresne
>  Labels: unittest
> Fix For: 2.2.x, 3.0.x, 3.x
>
>
> {noformat}
> test-clientutil-jar:
> [junit] Testsuite: org.apache.cassandra.serializers.ClientUtilsTest
> [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 0.314 sec
> [junit] 
> [junit] Testcase: test(org.apache.cassandra.serializers.ClientUtilsTest): 
>   Caused an ERROR
> [junit] org/apache/cassandra/utils/SigarLibrary
> [junit] java.lang.NoClassDefFoundError: 
> org/apache/cassandra/utils/SigarLibrary
> [junit] at org.apache.cassandra.utils.UUIDGen.hash(UUIDGen.java:328)
> [junit] at 
> org.apache.cassandra.utils.UUIDGen.makeNode(UUIDGen.java:307)
> [junit] at 
> org.apache.cassandra.utils.UUIDGen.makeClockSeqAndNode(UUIDGen.java:256)
> [junit] at 
> org.apache.cassandra.utils.UUIDGen.(UUIDGen.java:39)
> [junit] at 
> org.apache.cassandra.serializers.ClientUtilsTest.test(ClientUtilsTest.java:56)
> [junit] Caused by: java.lang.ClassNotFoundException: 
> org.apache.cassandra.utils.SigarLibrary
> [junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> [junit] at 
> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> [junit] 
> [junit] 
> [junit] Test org.apache.cassandra.serializers.ClientUtilsTest FAILED
> BUILD FAILED
> {noformat}
> I'll see if I can find a spot where this passes, but it appears to have been 
> failing for a long time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-9876) One way targeted repair

[Geoffrey Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415711#comment-15415711
 ] 

Geoffrey Yu commented on CASSANDRA-9876:


It looks like the new check for ensuring both {{--dc}} and {{--hosts}} are not 
specified together is causing the {{RepairOptionTest.testParseOptions}} test to 
fail. I'll take a look at fixing it and I'll add some new ones for the pull 
repair option parsing.

> One way targeted repair
> ---
>
> Key: CASSANDRA-9876
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9876
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: sankalp kohli
>Assignee: Geoffrey Yu
>Priority: Minor
> Fix For: 3.x
>
> Attachments: 9876-dtest-master.txt, 9876-trunk-v2.txt, 9876-trunk.txt
>
>
> Many applications use C* by writing to one local DC. The other DC is used 
> when the local DC is unavailable. When the local DC becomes available, we 
> want to run a targeted repair b/w one endpoint from each DC to minimize the 
> data transfer over WAN.  In this case, it will be helpful to do a one way 
> repair in which data will only be streamed from other DC to local DC instead 
> of streaming the data both ways. This will further minimize the traffic over 
> WAN. This feature should only be supported if a targeted repair is run 
> involving 2 hosts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-9608) Support Java 9

[Carlos Abad (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415694#comment-15415694
 ] 

Carlos Abad commented on CASSANDRA-9608:


Found another issue (Segmentation Fault) when trying to start the Cassandra 
Daemon. The error was caused by the JVM option 
"-Xloggc:${CASSANDRA_HOME}/logs/gc.log". in JDK9 the "logs" directory needs to 
to exist or the JVM will produce a Segmentation Fault.



> Support Java 9
> --
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
>  Issue Type: Task
>Reporter: Robert Stupp
>Priority: Minor
>
> This ticket is intended to group all issues found to support Java 9 in the 
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved. 
> It can be easily solved using this patch:
> {code}
> - artifactId="cobertura"/>
> + artifactId="cobertura">
> +  
> +
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods 
> {{monitorEnter}} + {{monitorExit}}. These methods are used by 
> {{o.a.c.utils.concurrent.Locks}} which is only used by 
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early 
> development phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12414) dtest failure in ttl_test.TestDistributedTTL.ttl_is_respected_on_delayed_replication_test

[Philip Thompson (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415693#comment-15415693
 ] 

Philip Thompson commented on CASSANDRA-12414:
-

Multiplexing this here: 
http://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/236/

> dtest failure in 
> ttl_test.TestDistributedTTL.ttl_is_respected_on_delayed_replication_test
> -
>
> Key: CASSANDRA-12414
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12414
> Project: Cassandra
>  Issue Type: Test
>Reporter: Philip Thompson
>Assignee: Philip Thompson
>  Labels: dtest
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.9_dtest/31/testReport/ttl_test/TestDistributedTTL/ttl_is_respected_on_delayed_replication_test
> {code}
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/ttl_test.py", line 439, in 
> ttl_is_respected_on_delayed_replication_test
> self.assertLessEqual(abs(ttl_session1[0][0] - ttl_session2[0][0]), 1)
> "unsupported operand type(s) for -: 'NoneType' and 'int'
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CASSANDRA-12431) Getting null value for the field that has value when query result has many rows

[Fei Fang (JIRA)]

Fei Fang created CASSANDRA-12431:


 Summary: Getting null value for the field that has value when 
query result has many rows
 Key: CASSANDRA-12431
 URL: https://issues.apache.org/jira/browse/CASSANDRA-12431
 Project: Cassandra
  Issue Type: Bug
Reporter: Fei Fang


Hi,
We get null value (not an older value, but null) for a float column (score) 
from a 20k result row query. However, when we fetch data for that specific row, 
the column actually has value.
The table schema is like this:
CREATE TABLE IF NOT EXISTS email_histogram (
id text,
email text,
score float,
PRIMARY KEY (id, email)
) WITH bloom_filter_fp_chance = 0.01
AND caching = 'KEYS_ONLY'
AND comment = ''
AND compaction =
{'tombstone_threshold': '0.1', 'tombstone_compaction_interval': '300', 'class': 
'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'}
AND compression =
{'sstable_compression': 'org.apache.cassandra.io.compress.SnappyCompressor'}
AND dclocal_read_repair_chance = 0.1
AND default_time_to_live = 864000
AND gc_grace_seconds = 86400
AND memtable_flush_period_in_ms = 0
AND read_repair_chance = 0.0
AND speculative_retry = '99.0PERCENTILE';

This is my read query: SELECT * FROM " + TABLE_NAME + " WHERE guid = ?

I'm using consistency One when querying it and Quorum when updating it. If I 
insert data, I insert for all the columns, never only part of the column. I 
understand that I might get out of date value since I'm using One to read, but 
again here I'm not getting out of date value, but just "null". 

This is happening on our staging server which servers 20k users, and we see 
this error happening 10+ times everyday. I don't have an exact number of how 
many times we do the query, but nodetool cfstats shows local read count of 
85314 for this table for the last 18 hours and we have 6 cassandra nodes in 
this cluster so about 500k querying for 18 hours.

We update the table every 3 weeks. The table has 20k rows for each key (guid) 
I'm querying for. Out of the 20k rows, only a couple at most are null and they 
are not the same every time we query the same key.

We are using C# driver version 3.0.1 and Cassandra version 2.2.6.44.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12366) Fix compaction throttle

[T Jake Luciani (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

T Jake Luciani updated CASSANDRA-12366:
---
   Resolution: Fixed
Fix Version/s: (was: 3.x)
   3.10
   Status: Resolved  (was: Ready to Commit)

Committed {{10649b1ce5aba1683e024c0f9cf23bd9c42704b7}}

> Fix compaction throttle
> ---
>
> Key: CASSANDRA-12366
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12366
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
>Reporter: T Jake Luciani
>Assignee: T Jake Luciani
> Fix For: 3.10
>
>
> Compaction throttling is broken in the following ways:
>   * It throttles bytes read after being decompressed
>   * Compaction creates multiple scanners which share the rate limiter causing 
> too much throttling
>   * It bears no resemblance to the reported compaction time remaining 
> calculation (Bytes of source sstables processed since start of compaction)
> To fix this we need to simplify the throttling to be only at the 
> CompactionIterator level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

cassandra git commit: Fix compaction throttle

[jake]

Repository: cassandra
Updated Branches:
  refs/heads/trunk d32a745b2 -> 10649b1ce


Fix compaction throttle

Patch by tjake reviewed by Marcus Eriksson for CASSANDRA-12366


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/10649b1c
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/10649b1c
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/10649b1c

Branch: refs/heads/trunk
Commit: 10649b1ce5aba1683e024c0f9cf23bd9c42704b7
Parents: d32a745
Author: T Jake Luciani 
Authored: Tue Aug 2 12:50:03 2016 -0400
Committer: T Jake Luciani 
Committed: Wed Aug 10 13:57:18 2016 -0400

--
 CHANGES.txt |  1 +
 .../compaction/AbstractCompactionStrategy.java  | 39 ++--
 .../db/compaction/CompactionController.java |  3 +-
 .../db/compaction/CompactionManager.java| 19 +-
 .../cassandra/db/compaction/CompactionTask.java | 23 +++-
 .../compaction/LeveledCompactionStrategy.java   | 27 --
 .../cassandra/io/sstable/ISSTableScanner.java   |  2 +
 .../io/sstable/format/big/BigTableScanner.java  | 35 ++
 .../apache/cassandra/metrics/TableMetrics.java  |  3 +-
 .../db/compaction/CompactionIteratorTest.java   | 13 +++
 10 files changed, 152 insertions(+), 13 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/10649b1c/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 5738c30..5c1d286 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.10
+ * Fix compaction throughput throttle (CASSANDRA-12366)
  * Delay releasing Memtable memory on flush until PostFlush has finished 
running (CASSANDRA-12358)
  * Cassandra stress should dump all setting on startup (CASSANDRA-11914)
  * Make it possible to compact a given token range (CASSANDRA-10643)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/10649b1c/src/java/org/apache/cassandra/db/compaction/AbstractCompactionStrategy.java
--
diff --git 
a/src/java/org/apache/cassandra/db/compaction/AbstractCompactionStrategy.java 
b/src/java/org/apache/cassandra/db/compaction/AbstractCompactionStrategy.java
index 48d5eb5..8454147 100644
--- 
a/src/java/org/apache/cassandra/db/compaction/AbstractCompactionStrategy.java
+++ 
b/src/java/org/apache/cassandra/db/compaction/AbstractCompactionStrategy.java
@@ -23,7 +23,6 @@ import com.google.common.base.Throwables;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.base.Predicate;
 import com.google.common.collect.Iterables;
-import com.google.common.util.concurrent.RateLimiter;
 
 import org.apache.cassandra.db.Directories;
 import org.apache.cassandra.db.SerializationHeader;
@@ -283,12 +282,11 @@ public abstract class AbstractCompactionStrategy
 @SuppressWarnings("resource")
 public ScannerList getScanners(Collection sstables, 
Collection ranges)
 {
-RateLimiter limiter = CompactionManager.instance.getRateLimiter();
 ArrayList scanners = new ArrayList();
 try
 {
 for (SSTableReader sstable : sstables)
-scanners.add(sstable.getScanner(ranges, limiter));
+scanners.add(sstable.getScanner(ranges, null));
 }
 catch (Throwable t)
 {
@@ -341,6 +339,41 @@ public abstract class AbstractCompactionStrategy
 this.scanners = scanners;
 }
 
+public long getTotalBytesScanned()
+{
+long bytesScanned = 0L;
+for (ISSTableScanner scanner : scanners)
+bytesScanned += scanner.getBytesScanned();
+
+return bytesScanned;
+}
+
+public long getTotalCompressedSize()
+{
+long compressedSize = 0;
+for (ISSTableScanner scanner : scanners)
+compressedSize += scanner.getCompressedLengthInBytes();
+
+return compressedSize;
+}
+
+public double getCompressionRatio()
+{
+double compressed = 0.0;
+double uncompressed = 0.0;
+
+for (ISSTableScanner scanner : scanners)
+{
+compressed += scanner.getCompressedLengthInBytes();
+uncompressed += scanner.getLengthInBytes();
+}
+
+if (compressed == uncompressed || uncompressed == 0)
+return MetadataCollector.NO_COMPRESSION_RATIO;
+
+return compressed / uncompressed;
+}
+
 public void close()
 {
 Throwable t = null;

[jira] [Commented] (CASSANDRA-9876) One way targeted repair

[Geoffrey Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415629#comment-15415629
 ] 

Geoffrey Yu commented on CASSANDRA-9876:


Thanks for the quick follow up and review! Your changes look good to me. I've 
opened a PR for the dtest here: 
https://github.com/riptano/cassandra-dtest/pull/1209

> One way targeted repair
> ---
>
> Key: CASSANDRA-9876
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9876
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: sankalp kohli
>Assignee: Geoffrey Yu
>Priority: Minor
> Fix For: 3.x
>
> Attachments: 9876-dtest-master.txt, 9876-trunk-v2.txt, 9876-trunk.txt
>
>
> Many applications use C* by writing to one local DC. The other DC is used 
> when the local DC is unavailable. When the local DC becomes available, we 
> want to run a targeted repair b/w one endpoint from each DC to minimize the 
> data transfer over WAN.  In this case, it will be helpful to do a one way 
> repair in which data will only be streamed from other DC to local DC instead 
> of streaming the data both ways. This will further minimize the traffic over 
> WAN. This feature should only be supported if a targeted repair is run 
> involving 2 hosts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11635) test-clientutil-jar unit test fails

[Tyler Hobbs (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415597#comment-15415597
 ] 

Tyler Hobbs commented on CASSANDRA-11635:
-

To be safe, I checked for [maven usages of 
clienutil.jar|https://mvnrepository.com/artifact/org.apache.cassandra/cassandra-clientutil],
 and the only user seems to be the {{spark-cassandra-connector}}.  According to 
[~rspitzer], maintainer of that project, it's not actually used anymore and can 
be removed as a dependency.  So, I'm +1 on the idea of removing it.

It looks like utest and dtest runs didn't actually get started, so I've kicked 
those off.  If they look good, I'll commit this.

> test-clientutil-jar unit test fails
> ---
>
> Key: CASSANDRA-11635
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11635
> Project: Cassandra
>  Issue Type: Test
>  Components: Testing
>Reporter: Michael Shuler
>Assignee: Sylvain Lebresne
>  Labels: unittest
> Fix For: 2.2.x, 3.0.x, 3.x
>
>
> {noformat}
> test-clientutil-jar:
> [junit] Testsuite: org.apache.cassandra.serializers.ClientUtilsTest
> [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 0.314 sec
> [junit] 
> [junit] Testcase: test(org.apache.cassandra.serializers.ClientUtilsTest): 
>   Caused an ERROR
> [junit] org/apache/cassandra/utils/SigarLibrary
> [junit] java.lang.NoClassDefFoundError: 
> org/apache/cassandra/utils/SigarLibrary
> [junit] at org.apache.cassandra.utils.UUIDGen.hash(UUIDGen.java:328)
> [junit] at 
> org.apache.cassandra.utils.UUIDGen.makeNode(UUIDGen.java:307)
> [junit] at 
> org.apache.cassandra.utils.UUIDGen.makeClockSeqAndNode(UUIDGen.java:256)
> [junit] at 
> org.apache.cassandra.utils.UUIDGen.(UUIDGen.java:39)
> [junit] at 
> org.apache.cassandra.serializers.ClientUtilsTest.test(ClientUtilsTest.java:56)
> [junit] Caused by: java.lang.ClassNotFoundException: 
> org.apache.cassandra.utils.SigarLibrary
> [junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> [junit] at 
> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> [junit] 
> [junit] 
> [junit] Test org.apache.cassandra.serializers.ClientUtilsTest FAILED
> BUILD FAILED
> {noformat}
> I'll see if I can find a spot where this passes, but it appears to have been 
> failing for a long time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12251) dtest failure in upgrade_tests.cql_tests.TestCQLNodes3RF3_Upgrade_current_3_x_To_indev_3_x.whole_list_conditional_test

[Joel Knighton (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415570#comment-15415570
 ] 

Joel Knighton commented on CASSANDRA-12251:
---

Patch and CI look good to me. Is there a reason you only ran CI on trunk 
[~ifesdjeen]? I think this should go into 2.2+.

> dtest failure in 
> upgrade_tests.cql_tests.TestCQLNodes3RF3_Upgrade_current_3_x_To_indev_3_x.whole_list_conditional_test
> --
>
> Key: CASSANDRA-12251
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12251
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Philip Thompson
>Assignee: Alex Petrov
>  Labels: dtest
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.8_dtest_upgrade/1/testReport/upgrade_tests.cql_tests/TestCQLNodes3RF3_Upgrade_current_3_x_To_indev_3_x/whole_list_conditional_test
> Failed on CassCI build cassandra-3.8_dtest_upgrade #1
> Relevant error in logs is
> {code}
> Unexpected error in node1 log, error: 
> ERROR [InternalResponseStage:2] 2016-07-20 04:58:45,876 
> CassandraDaemon.java:217 - Exception in thread 
> Thread[InternalResponseStage:2,5,main]
> java.util.concurrent.RejectedExecutionException: ThreadPoolExecutor has shut 
> down
>   at 
> org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor$1.rejectedExecution(DebuggableThreadPoolExecutor.java:61)
>  ~[apache-cassandra-3.7.jar:3.7]
>   at 
> java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823) 
> ~[na:1.8.0_51]
>   at 
> java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1369) 
> ~[na:1.8.0_51]
>   at 
> org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor.execute(DebuggableThreadPoolExecutor.java:165)
>  ~[apache-cassandra-3.7.jar:3.7]
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:112)
>  ~[na:1.8.0_51]
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtable(ColumnFamilyStore.java:842)
>  ~[apache-cassandra-3.7.jar:3.7]
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableIfCurrent(ColumnFamilyStore.java:822)
>  ~[apache-cassandra-3.7.jar:3.7]
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.forceFlush(ColumnFamilyStore.java:891)
>  ~[apache-cassandra-3.7.jar:3.7]
>   at 
> org.apache.cassandra.schema.SchemaKeyspace.lambda$flush$1(SchemaKeyspace.java:279)
>  ~[apache-cassandra-3.7.jar:3.7]
>   at 
> org.apache.cassandra.schema.SchemaKeyspace$$Lambda$200/1129213153.accept(Unknown
>  Source) ~[na:na]
>   at java.lang.Iterable.forEach(Iterable.java:75) ~[na:1.8.0_51]
>   at 
> org.apache.cassandra.schema.SchemaKeyspace.flush(SchemaKeyspace.java:279) 
> ~[apache-cassandra-3.7.jar:3.7]
>   at 
> org.apache.cassandra.schema.SchemaKeyspace.mergeSchema(SchemaKeyspace.java:1271)
>  ~[apache-cassandra-3.7.jar:3.7]
>   at 
> org.apache.cassandra.schema.SchemaKeyspace.mergeSchemaAndAnnounceVersion(SchemaKeyspace.java:1253)
>  ~[apache-cassandra-3.7.jar:3.7]
>   at 
> org.apache.cassandra.service.MigrationTask$1.response(MigrationTask.java:92) 
> ~[apache-cassandra-3.7.jar:3.7]
>   at 
> org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:53)
>  ~[apache-cassandra-3.7.jar:3.7]
>   at 
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:64) 
> ~[apache-cassandra-3.7.jar:3.7]
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_51]
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_51]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_51]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_51]
>   at java.lang.Thread.run(Thread.java:745) [na:1.8.0_51]
> {code}
> This is on a mixed 3.0.8, 3.8-tentative cluster



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-11611) dtest failure in topology_test.TestTopology.crash_during_decommission_test

[Paulo Motta (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415544#comment-15415544
 ] 

Paulo Motta commented on CASSANDRA-11611:
-

Submitted [PR|https://github.com/riptano/cassandra-dtest/pull/1207] and 
[multiplexer 
run|https://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/235/]
 with fixes suggested above. Will update ticket status after multiplexer 
results look good and PR review is done.

> dtest failure in topology_test.TestTopology.crash_during_decommission_test
> --
>
> Key: CASSANDRA-11611
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11611
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Paulo Motta
>  Labels: dtest
> Fix For: 3.x
>
>
> Looks like some kind of streaming error. Example failure:
> http://cassci.datastax.com/job/trunk_dtest_win32/382/testReport/topology_test/TestTopology/crash_during_decommission_test
> Failed on CassCI build trunk_dtest_win32 #382
> {code}
> Error Message
> Unexpected error in log, see stdout
>  >> begin captured logging << 
> dtest: DEBUG: cluster ccm directory: d:\temp\dtest-ce_wos
> dtest: DEBUG: Custom init_config not found. Setting defaults.
> dtest: DEBUG: Done setting configuration options:
> {   'initial_token': None,
> 'num_tokens': '32',
> 'phi_convict_threshold': 5,
> 'range_request_timeout_in_ms': 1,
> 'read_request_timeout_in_ms': 1,
> 'request_timeout_in_ms': 1,
> 'truncate_request_timeout_in_ms': 1,
> 'write_request_timeout_in_ms': 1}
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UN  127.0.0.1  98.73 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  162.38 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  98.71 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  98.73 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  222.26 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  98.71 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  174.2 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  336.69 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  116.7 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  174.2 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  360.82 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  116.7 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  174.2 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  240.54 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  116.7 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1

[jira] [Updated] (CASSANDRA-12428) dtest failure in topology_test.TestTopology.simple_decommission_test

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12428:

Assignee: (was: DS Test Eng)

> dtest failure in topology_test.TestTopology.simple_decommission_test
> 
>
> Key: CASSANDRA-12428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12428
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Sean McCarthy
>  Labels: dtest
> Attachments: node1.log, node2.log, node3.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-2.1_dtest/499/testReport/topology_test/TestTopology/simple_decommission_test
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 358, in run
> self.tearDown()
>   File "/home/automaton/cassandra-dtest/dtest.py", line 666, in tearDown
> raise AssertionError('Unexpected error in log, see stdout')
> "Unexpected error in log, see stdout
> {code}
> {code}
> Standard Output
> Unexpected error in node2 log, error: 
> ERROR [OptionalTasks:1] 2016-08-09 22:19:17,578 CassandraDaemon.java:231 - 
> Exception in thread Thread[OptionalTasks:1,5,main]
> java.lang.AssertionError: -1798176113661253264 not found in 
> -9176030984652505006, -871714249145979, -8567082690920363685, 
> -7728355195270516929, -7671560790707332672, -6815296744215479977, 
> -6611548514765694876, -6137228431100324821, -5871381962314776798, 
> -5709026171638534111, -5696874364498510312, -4663855838820854356, 
> -3304329091857535864, -3251864206536309230, -3188788124715894197, 
> -2549476409976316844, -2423479156112489442, -2389574204458609132, 
> -2160965082438649456, -2046105283339446875, -1622678693166245335, 
> -1421783322562475411, -503110248141412377, -256005860529123222, 
> -229477804731423425, -144610334523764289, -64851179421923626, 
> 127314057436704028, 313816817127566322, 376139846959091135, 
> 561504311435506912, 858207556605072954, 1261151151588160011, 
> 1454126256475083217, 1618377671275204279, 2317929712453820894, 
> 2560612758275508783, 2587728682790085050, 2848178890309615427, 
> 2885660694771463522, 3140716395155672330, 3178980457497133951, 
> 3591038406660159757, 3766734787881223437, 3769457468208792646, 
> 3824534990286253644, 5183723622628782738, 5314317607985127226, 
> 584580052753930, 6235156095343170404, 6242029497543352525, 
> 6281404742986921776, 6589819833145109726, 6821551756387826137, 
> 6889949766088620327, 7754073703959464783, 7756209389182352710, 
> 7952201212324370303, 8053856175511744133, 8081402847785658462, 
> 8227459864244671435, 8350507973899452057, 8826283221671184683, 
> 912045907067355
>   at 
> org.apache.cassandra.locator.TokenMetadata.getPredecessor(TokenMetadata.java:717)
>  ~[main/:na]
>   at 
> org.apache.cassandra.locator.TokenMetadata.getPrimaryRangesFor(TokenMetadata.java:661)
>  ~[main/:na]
>   at 
> org.apache.cassandra.db.SizeEstimatesRecorder.run(SizeEstimatesRecorder.java:69)
>  ~[main/:na]
>   at 
> org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor$UncomplainingRunnable.run(DebuggableScheduledThreadPoolExecutor.java:118)
>  ~[main/:na]
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) 
> [na:1.7.0_80]
>   at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304) 
> [na:1.7.0_80]
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
>  [na:1.7.0_80]
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>  [na:1.7.0_80]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>  [na:1.7.0_80]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>  [na:1.7.0_80]
>   at java.lang.Thread.run(Thread.java:745) [na:1.7.0_80]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12428) dtest failure in topology_test.TestTopology.simple_decommission_test

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12428:

Issue Type: Bug  (was: Test)

> dtest failure in topology_test.TestTopology.simple_decommission_test
> 
>
> Key: CASSANDRA-12428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12428
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Sean McCarthy
>Assignee: DS Test Eng
>  Labels: dtest
> Attachments: node1.log, node2.log, node3.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-2.1_dtest/499/testReport/topology_test/TestTopology/simple_decommission_test
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 358, in run
> self.tearDown()
>   File "/home/automaton/cassandra-dtest/dtest.py", line 666, in tearDown
> raise AssertionError('Unexpected error in log, see stdout')
> "Unexpected error in log, see stdout
> {code}
> {code}
> Standard Output
> Unexpected error in node2 log, error: 
> ERROR [OptionalTasks:1] 2016-08-09 22:19:17,578 CassandraDaemon.java:231 - 
> Exception in thread Thread[OptionalTasks:1,5,main]
> java.lang.AssertionError: -1798176113661253264 not found in 
> -9176030984652505006, -871714249145979, -8567082690920363685, 
> -7728355195270516929, -7671560790707332672, -6815296744215479977, 
> -6611548514765694876, -6137228431100324821, -5871381962314776798, 
> -5709026171638534111, -5696874364498510312, -4663855838820854356, 
> -3304329091857535864, -3251864206536309230, -3188788124715894197, 
> -2549476409976316844, -2423479156112489442, -2389574204458609132, 
> -2160965082438649456, -2046105283339446875, -1622678693166245335, 
> -1421783322562475411, -503110248141412377, -256005860529123222, 
> -229477804731423425, -144610334523764289, -64851179421923626, 
> 127314057436704028, 313816817127566322, 376139846959091135, 
> 561504311435506912, 858207556605072954, 1261151151588160011, 
> 1454126256475083217, 1618377671275204279, 2317929712453820894, 
> 2560612758275508783, 2587728682790085050, 2848178890309615427, 
> 2885660694771463522, 3140716395155672330, 3178980457497133951, 
> 3591038406660159757, 3766734787881223437, 3769457468208792646, 
> 3824534990286253644, 5183723622628782738, 5314317607985127226, 
> 584580052753930, 6235156095343170404, 6242029497543352525, 
> 6281404742986921776, 6589819833145109726, 6821551756387826137, 
> 6889949766088620327, 7754073703959464783, 7756209389182352710, 
> 7952201212324370303, 8053856175511744133, 8081402847785658462, 
> 8227459864244671435, 8350507973899452057, 8826283221671184683, 
> 912045907067355
>   at 
> org.apache.cassandra.locator.TokenMetadata.getPredecessor(TokenMetadata.java:717)
>  ~[main/:na]
>   at 
> org.apache.cassandra.locator.TokenMetadata.getPrimaryRangesFor(TokenMetadata.java:661)
>  ~[main/:na]
>   at 
> org.apache.cassandra.db.SizeEstimatesRecorder.run(SizeEstimatesRecorder.java:69)
>  ~[main/:na]
>   at 
> org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor$UncomplainingRunnable.run(DebuggableScheduledThreadPoolExecutor.java:118)
>  ~[main/:na]
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) 
> [na:1.7.0_80]
>   at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304) 
> [na:1.7.0_80]
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
>  [na:1.7.0_80]
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>  [na:1.7.0_80]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>  [na:1.7.0_80]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>  [na:1.7.0_80]
>   at java.lang.Thread.run(Thread.java:745) [na:1.7.0_80]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (CASSANDRA-12414) dtest failure in ttl_test.TestDistributedTTL.ttl_is_respected_on_delayed_replication_test

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson reassigned CASSANDRA-12414:
---

Assignee: Philip Thompson  (was: DS Test Eng)

> dtest failure in 
> ttl_test.TestDistributedTTL.ttl_is_respected_on_delayed_replication_test
> -
>
> Key: CASSANDRA-12414
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12414
> Project: Cassandra
>  Issue Type: Test
>Reporter: Philip Thompson
>Assignee: Philip Thompson
>  Labels: dtest
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.9_dtest/31/testReport/ttl_test/TestDistributedTTL/ttl_is_respected_on_delayed_replication_test
> {code}
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/ttl_test.py", line 439, in 
> ttl_is_respected_on_delayed_replication_test
> self.assertLessEqual(abs(ttl_session1[0][0] - ttl_session2[0][0]), 1)
> "unsupported operand type(s) for -: 'NoneType' and 'int'
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-11611) dtest failure in topology_test.TestTopology.crash_during_decommission_test

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-11611:

Fix Version/s: (was: 3.x)
   Status: Patch Available  (was: Open)

> dtest failure in topology_test.TestTopology.crash_during_decommission_test
> --
>
> Key: CASSANDRA-11611
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11611
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Paulo Motta
>  Labels: dtest
>
> Looks like some kind of streaming error. Example failure:
> http://cassci.datastax.com/job/trunk_dtest_win32/382/testReport/topology_test/TestTopology/crash_during_decommission_test
> Failed on CassCI build trunk_dtest_win32 #382
> {code}
> Error Message
> Unexpected error in log, see stdout
>  >> begin captured logging << 
> dtest: DEBUG: cluster ccm directory: d:\temp\dtest-ce_wos
> dtest: DEBUG: Custom init_config not found. Setting defaults.
> dtest: DEBUG: Done setting configuration options:
> {   'initial_token': None,
> 'num_tokens': '32',
> 'phi_convict_threshold': 5,
> 'range_request_timeout_in_ms': 1,
> 'read_request_timeout_in_ms': 1,
> 'request_timeout_in_ms': 1,
> 'truncate_request_timeout_in_ms': 1,
> 'write_request_timeout_in_ms': 1}
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UN  127.0.0.1  98.73 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  162.38 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  98.71 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  98.73 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  222.26 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  98.71 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  174.2 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  336.69 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  116.7 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  174.2 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  360.82 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  116.7 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  174.2 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  240.54 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  116.7 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Decommission failed with exception: Nodetool command 
> 'D:\jenkins\workspace\trunk_dtest_win32\cassandra\bin\nodetool.bat -h 
> localhost -p 7100 decommission' failed; exit status: 2; stderr: error: Stream 
> failed
> -- 

[jira] [Updated] (CASSANDRA-11611) dtest failure in topology_test.TestTopology.crash_during_decommission_test

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-11611:

Reviewer: Philip Thompson

> dtest failure in topology_test.TestTopology.crash_during_decommission_test
> --
>
> Key: CASSANDRA-11611
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11611
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Paulo Motta
>  Labels: dtest
>
> Looks like some kind of streaming error. Example failure:
> http://cassci.datastax.com/job/trunk_dtest_win32/382/testReport/topology_test/TestTopology/crash_during_decommission_test
> Failed on CassCI build trunk_dtest_win32 #382
> {code}
> Error Message
> Unexpected error in log, see stdout
>  >> begin captured logging << 
> dtest: DEBUG: cluster ccm directory: d:\temp\dtest-ce_wos
> dtest: DEBUG: Custom init_config not found. Setting defaults.
> dtest: DEBUG: Done setting configuration options:
> {   'initial_token': None,
> 'num_tokens': '32',
> 'phi_convict_threshold': 5,
> 'range_request_timeout_in_ms': 1,
> 'read_request_timeout_in_ms': 1,
> 'request_timeout_in_ms': 1,
> 'truncate_request_timeout_in_ms': 1,
> 'write_request_timeout_in_ms': 1}
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UN  127.0.0.1  98.73 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  162.38 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  98.71 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  98.73 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  222.26 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  98.71 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  174.2 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  336.69 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  116.7 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  174.2 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  360.82 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  116.7 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Status as reported by node 127.0.0.2
> dtest: DEBUG: Datacenter: datacenter1
> 
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens   Owns (effective)  Host ID  
>  Rack
> UL  127.0.0.1  174.2 KiB  32   78.4% 
> b8c55c71-bf3d-462b-8c17-3c88d7ac2284  rack1
> UN  127.0.0.2  240.54 KiB  32   65.9% 
> 71aacf1d-8e2f-44cf-b354-f10c71313ec6  rack1
> UN  127.0.0.3  116.7 KiB  32   55.7% 
> 3a4529a3-dc7f-445c-aec3-94417c920fdf  rack1
> dtest: DEBUG: Restarting node2
> dtest: DEBUG: Decommission failed with exception: Nodetool command 
> 'D:\jenkins\workspace\trunk_dtest_win32\cassandra\bin\nodetool.bat -h 
> localhost -p 7100 decommission' failed; exit status: 2; stderr: error: Stream 
> failed
> -- StackTrace --
> 

[jira] [Commented] (CASSANDRA-12429) dtest failure in compaction_test.TestCompaction_with_DateTieredCompactionStrategy.bloomfilter_size_test

[Philip Thompson (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415553#comment-15415553
 ] 

Philip Thompson commented on CASSANDRA-12429:
-

[~krummas], I've filed this followup fix for CASSANDRA-12323: 
https://github.com/riptano/cassandra-dtest/pull/1208
However, this test is still failing with 
{code}
self.assertLessEqual(bfSize, size_factor * max_bf_size)
AssertionError: 125456 not less than or equal to 5.0
{code}
Perhaps we should not divide by data directory count on all C* versions?

> dtest failure in 
> compaction_test.TestCompaction_with_DateTieredCompactionStrategy.bloomfilter_size_test
> ---
>
> Key: CASSANDRA-12429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12429
> Project: Cassandra
>  Issue Type: Test
>Reporter: Craig Kodman
>Assignee: Philip Thompson
>  Labels: dtest
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-2.2_dtest/669/testReport/compaction_test/TestCompaction_with_DateTieredCompactionStrategy/bloomfilter_size_test
> Failed on CassCI build cassandra-2.2_dtest build #669
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/compaction_test.py", line 147, in 
> bloomfilter_size_test
> self.assertLessEqual(bfSize, size_factor * max_bf_size)
>   File "/usr/lib/python2.7/unittest/case.py", line 936, in assertLessEqual
> self.fail(self._formatMessage(msg, standardMsg))
>   File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> "125456 not less than or equal to 0\n >> begin captured 
> logging << \ndtest: DEBUG: cluster ccm directory: 
> /tmp/dtest-XJ96MC\ndtest: DEBUG: Done setting configuration options:\n{   
> 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': 
> 5,\n'start_rpc': 'true'}\ndtest: DEBUG: bloom filter size is: 
> 125456\ndtest: DEBUG: size factor = 0\n- >> end captured 
> logging << -"
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CASSANDRA-12426) Writing a null value into a dense table results into a no-op

[Alex Petrov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Petrov resolved CASSANDRA-12426.
-
Resolution: Won't Fix

Thanks for the explanation [~iamaleksey] [~jjordan]! 

> Writing a null value into a dense table results into a no-op 
> -
>
> Key: CASSANDRA-12426
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12426
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Alex Petrov
>
> Making an insert into the dense table doesn't seem to create a live partition:
> {code}
> cqlsh> CREATE KEYSPACE test WITH replication = {'class': 
> 'NetworkTopologyStrategy', 'datacenter1': '1' };
> cqlsh> use test ;
> cqlsh:test> CREATE TABLE a (partition text, key text, owner text, PRIMARY KEY 
> (partition, key) ) WITH COMPACT STORAGE;
> cqlsh:test> INSERT INTO a (partition, key, owner) VALUES ('a', 'b', null);
> cqlsh:test> select * from a;
>  partition | key | owner
> ---+-+
> {code}
> (same behaviour on 2.2)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12426) Writing a null value into a dense table results into a no-op (COMPACT STORAGE)

[Alex Petrov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Petrov updated CASSANDRA-12426:

Summary: Writing a null value into a dense table results into a no-op 
(COMPACT STORAGE)  (was: Writing a null value into a dense table results into a 
no-op )

> Writing a null value into a dense table results into a no-op (COMPACT STORAGE)
> --
>
> Key: CASSANDRA-12426
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12426
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Alex Petrov
>
> Making an insert into the dense table doesn't seem to create a live partition:
> {code}
> cqlsh> CREATE KEYSPACE test WITH replication = {'class': 
> 'NetworkTopologyStrategy', 'datacenter1': '1' };
> cqlsh> use test ;
> cqlsh:test> CREATE TABLE a (partition text, key text, owner text, PRIMARY KEY 
> (partition, key) ) WITH COMPACT STORAGE;
> cqlsh:test> INSERT INTO a (partition, key, owner) VALUES ('a', 'b', null);
> cqlsh:test> select * from a;
>  partition | key | owner
> ---+-+
> {code}
> (same behaviour on 2.2)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (CASSANDRA-12429) dtest failure in compaction_test.TestCompaction_with_DateTieredCompactionStrategy.bloomfilter_size_test

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson reassigned CASSANDRA-12429:
---

Assignee: Philip Thompson  (was: DS Test Eng)

> dtest failure in 
> compaction_test.TestCompaction_with_DateTieredCompactionStrategy.bloomfilter_size_test
> ---
>
> Key: CASSANDRA-12429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12429
> Project: Cassandra
>  Issue Type: Test
>Reporter: Craig Kodman
>Assignee: Philip Thompson
>  Labels: dtest
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-2.2_dtest/669/testReport/compaction_test/TestCompaction_with_DateTieredCompactionStrategy/bloomfilter_size_test
> Failed on CassCI build cassandra-2.2_dtest build #669
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/compaction_test.py", line 147, in 
> bloomfilter_size_test
> self.assertLessEqual(bfSize, size_factor * max_bf_size)
>   File "/usr/lib/python2.7/unittest/case.py", line 936, in assertLessEqual
> self.fail(self._formatMessage(msg, standardMsg))
>   File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> "125456 not less than or equal to 0\n >> begin captured 
> logging << \ndtest: DEBUG: cluster ccm directory: 
> /tmp/dtest-XJ96MC\ndtest: DEBUG: Done setting configuration options:\n{   
> 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': 
> 5,\n'start_rpc': 'true'}\ndtest: DEBUG: bloom filter size is: 
> 125456\ndtest: DEBUG: size factor = 0\n- >> end captured 
> logging << -"
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12253) Fix exceptions when enabling gossip on proxy nodes.

[Joel Knighton (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415520#comment-15415520
 ] 

Joel Knighton commented on CASSANDRA-12253:
---

Fair - I also considered that. Makes sense to me.

> Fix exceptions when enabling gossip on proxy nodes.
> ---
>
> Key: CASSANDRA-12253
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12253
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Dikang Gu
>Assignee: Dikang Gu
>Priority: Minor
> Fix For: 2.2.x
>
> Attachments: 0001-for-proxy-node-not-set-gossip-tokens.patch, 
> 0002-for-proxy-node-not-set-gossip-tokens.patch
>
>
> We have a tier of Cassandra nodes running with join_ring=false flag, which we 
> call proxy nodes, and they will never join the ring.
> The problem is that sometimes we need to disable and enable the gossip on 
> those nodes, and `nodetool enablegossip` throws exceptions when we do that:
> {code}
> java.lang.AssertionError
> at 
> org.apache.cassandra.service.StorageService.getLocalTokens(StorageService.java:2213)
> at 
> org.apache.cassandra.service.StorageService.startGossiping(StorageService.java:371)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:75)
> at sun.reflect.GeneratedMethodAccessor8.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:279)
> at 
> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
> at 
> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
> at 
> com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
> at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
> at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
> at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
> at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1487)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:97)
> at 
> javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1328)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1420)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:848)
> at sun.reflect.GeneratedMethodAccessor52.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:322)
> at sun.rmi.transport.Transport$1.run(Transport.java:177)
> at sun.rmi.transport.Transport$1.run(Transport.java:174)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:173)
> at 
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:556)
> at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:811)
> at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:670)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12430) dtest failure in cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_writing_with_token_boundaries

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12430:

Fix Version/s: 3.0.x

> dtest failure in 
> cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_writing_with_token_boundaries
> --
>
> Key: CASSANDRA-12430
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12430
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Craig Kodman
>  Labels: dtest
> Fix For: 3.0.x
>
> Attachments: node1.log, node1_debug.log, node1_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.0_dtest/787/testReport/cqlsh_tests.cqlsh_copy_tests/CqlshCopyTest/test_writing_with_token_boundaries
> Failed on CassCI build cassandra-3.0_dtest build #787
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/cqlsh_tests/cqlsh_copy_tests.py", 
> line 1022, in test_writing_with_token_boundaries
> self._test_writing_with_token_boundaries(1, None, 200)
>   File "/home/automaton/cassandra-dtest/cqlsh_tests/cqlsh_copy_tests.py", 
> line 1059, in _test_writing_with_token_boundaries
> self.assertItemsEqual(csv_values, result)
>   File "/usr/lib/python2.7/unittest/case.py", line 901, in assertItemsEqual
> self.fail(msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> "Element counts were not equal:\nFirst has 0, Second has 1:  ('130', 
> -4364617663693876050L)\nFirst has 0, Second has 1:  ('1504', 
> -4313346088993828066L)\nFirst has 0, Second has 1:  ('1657', 
> -4298243044528711865L)\nFirst has 0, Second has 1:  ('1908', 
> -4357762565998238890L)\nFirst has 0, Second has 1:  ('196', 
> -4311842292754600676L)\nFirst has 0, Second has 1:  ('2069', 
> -4364398944370882217L)\nFirst has 0, Second has 1:  ('2840', 
> -4341639477649832153L)\nFirst has 0, Second has 1:  ('2887', 
> -4318016824479819783L)\nFirst has 0, Second has 1:  ('2899', 
> -4302748366908469185L)\nFirst has 0, Second has 1:  ('2928', 
> -4320094196758787736L)\nFirst has 0, Second has 1:  ('2985', 
> -4314356124534988584L)\nFirst has 0, Second has 1:  ('3684', 
> -4338074463992249966L)\nFirst has 0, Second has 1:  ('371', 
> -4314424123257001171L)\nFirst has 0, Second has 1:  ('3726', 
> -4327342039280507889L)\nFirst has 0, Second has 1:  ('3767', 
> -4314615789624913427L)\nFirst has 0, Second has 1:  ('3837', 
> -4345782419910891107L)\nFirst has 0, Second has 1:  ('3917', 
> -4288469607605675346L)\nFirst has 0, Second has 1:  ('4023', 
> -4327319429102869913L)\nFirst has 0, Second has 1:  ('4340', 
> -4364719196309290555L)\nFirst has 0, Second has 1:  ('4775', 
> -4334399295585005795L)\nFirst has 0, Second has 1:  ('480', 
> -4297721626756162038L)\nFirst has 0, Second has 1:  ('4927', 
> -4363012199808638126L)\nFirst has 0, Second has 1:  ('5227', 
> -4322405738833807588L)\nFirst has 0, Second has 1:  ('564', 
> -4294201317243228473L)\nFirst has 0, Second has 1:  ('585', 
> -435900129350319L)\nFirst has 0, Second has 1:  ('5869', 
> -4350305245827564608L)\nFirst has 0, Second has 1:  ('6907', 
> -4350623491924194304L)\nFirst has 0, Second has 1:  ('709', 
> -4304008865600291097L)\nFirst has 0, Second has 1:  ('7415', 
> -4315752378065264743L)\nFirst has 0, Second has 1:  ('7476', 
> -4300546270541034340L)\nFirst has 0, Second has 1:  ('7805', 
> -4344641724309508742L)\nFirst has 0, Second has 1:  ('7922', 
> -4363605089028496367L)\nFirst has 0, Second has 1:  ('8026', 
> -4319008002233878821L)\nFirst has 0, Second has 1:  ('8180', 
> -4361912691055780971L)\nFirst has 0, Second has 1:  ('8371', 
> -4309172311179179912L)\nFirst has 0, Second has 1:  ('8988', 
> -432609343783541L)\nFirst has 0, Second has 1:  ('9492', 
> -4347264403260361686L)\nFirst has 0, Second has 1:  ('9783', 
> -4329297319597600121L)\nFirst has 0, Second has 1:  ('9911', 
> -4320490295580904236L)\n >> begin captured logging << 
> \ndtest: DEBUG: cluster ccm directory: 
> /tmp/dtest-2v8O54\ndtest: DEBUG: Done setting configuration options:\n{   
> 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': 
> 5,\n'range_request_timeout_in_ms': 1,\n
> 'read_request_timeout_in_ms': 1,\n'request_timeout_in_ms': 1,\n   
>  'truncate_request_timeout_in_ms': 1,\n'write_request_timeout_in_ms': 
> 1}\ndtest: DEBUG: Exporting to csv file: /tmp/tmpDS47Vq\ndtest: DEBUG: 
> Exporting to csv file: /tmp/tmpQvnl6e\ndtest: DEBUG: Exporting to csv file: 
> /tmp/tmpfEEiAz\ndtest: DEBUG: Exporting to csv file: /tmp/tmpc7T8av\ndtest: 
> DEBUG: Exporting to csv file: /tmp/tmplxBTNa\ndtest: 

[jira] [Updated] (CASSANDRA-12430) dtest failure in cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_writing_with_token_boundaries

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12430:

Assignee: (was: DS Test Eng)

> dtest failure in 
> cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_writing_with_token_boundaries
> --
>
> Key: CASSANDRA-12430
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12430
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Craig Kodman
>  Labels: dtest
> Fix For: 3.0.x
>
> Attachments: node1.log, node1_debug.log, node1_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.0_dtest/787/testReport/cqlsh_tests.cqlsh_copy_tests/CqlshCopyTest/test_writing_with_token_boundaries
> Failed on CassCI build cassandra-3.0_dtest build #787
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/cqlsh_tests/cqlsh_copy_tests.py", 
> line 1022, in test_writing_with_token_boundaries
> self._test_writing_with_token_boundaries(1, None, 200)
>   File "/home/automaton/cassandra-dtest/cqlsh_tests/cqlsh_copy_tests.py", 
> line 1059, in _test_writing_with_token_boundaries
> self.assertItemsEqual(csv_values, result)
>   File "/usr/lib/python2.7/unittest/case.py", line 901, in assertItemsEqual
> self.fail(msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> "Element counts were not equal:\nFirst has 0, Second has 1:  ('130', 
> -4364617663693876050L)\nFirst has 0, Second has 1:  ('1504', 
> -4313346088993828066L)\nFirst has 0, Second has 1:  ('1657', 
> -4298243044528711865L)\nFirst has 0, Second has 1:  ('1908', 
> -4357762565998238890L)\nFirst has 0, Second has 1:  ('196', 
> -4311842292754600676L)\nFirst has 0, Second has 1:  ('2069', 
> -4364398944370882217L)\nFirst has 0, Second has 1:  ('2840', 
> -4341639477649832153L)\nFirst has 0, Second has 1:  ('2887', 
> -4318016824479819783L)\nFirst has 0, Second has 1:  ('2899', 
> -4302748366908469185L)\nFirst has 0, Second has 1:  ('2928', 
> -4320094196758787736L)\nFirst has 0, Second has 1:  ('2985', 
> -4314356124534988584L)\nFirst has 0, Second has 1:  ('3684', 
> -4338074463992249966L)\nFirst has 0, Second has 1:  ('371', 
> -4314424123257001171L)\nFirst has 0, Second has 1:  ('3726', 
> -4327342039280507889L)\nFirst has 0, Second has 1:  ('3767', 
> -4314615789624913427L)\nFirst has 0, Second has 1:  ('3837', 
> -4345782419910891107L)\nFirst has 0, Second has 1:  ('3917', 
> -4288469607605675346L)\nFirst has 0, Second has 1:  ('4023', 
> -4327319429102869913L)\nFirst has 0, Second has 1:  ('4340', 
> -4364719196309290555L)\nFirst has 0, Second has 1:  ('4775', 
> -4334399295585005795L)\nFirst has 0, Second has 1:  ('480', 
> -4297721626756162038L)\nFirst has 0, Second has 1:  ('4927', 
> -4363012199808638126L)\nFirst has 0, Second has 1:  ('5227', 
> -4322405738833807588L)\nFirst has 0, Second has 1:  ('564', 
> -4294201317243228473L)\nFirst has 0, Second has 1:  ('585', 
> -435900129350319L)\nFirst has 0, Second has 1:  ('5869', 
> -4350305245827564608L)\nFirst has 0, Second has 1:  ('6907', 
> -4350623491924194304L)\nFirst has 0, Second has 1:  ('709', 
> -4304008865600291097L)\nFirst has 0, Second has 1:  ('7415', 
> -4315752378065264743L)\nFirst has 0, Second has 1:  ('7476', 
> -4300546270541034340L)\nFirst has 0, Second has 1:  ('7805', 
> -4344641724309508742L)\nFirst has 0, Second has 1:  ('7922', 
> -4363605089028496367L)\nFirst has 0, Second has 1:  ('8026', 
> -4319008002233878821L)\nFirst has 0, Second has 1:  ('8180', 
> -4361912691055780971L)\nFirst has 0, Second has 1:  ('8371', 
> -4309172311179179912L)\nFirst has 0, Second has 1:  ('8988', 
> -432609343783541L)\nFirst has 0, Second has 1:  ('9492', 
> -4347264403260361686L)\nFirst has 0, Second has 1:  ('9783', 
> -4329297319597600121L)\nFirst has 0, Second has 1:  ('9911', 
> -4320490295580904236L)\n >> begin captured logging << 
> \ndtest: DEBUG: cluster ccm directory: 
> /tmp/dtest-2v8O54\ndtest: DEBUG: Done setting configuration options:\n{   
> 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': 
> 5,\n'range_request_timeout_in_ms': 1,\n
> 'read_request_timeout_in_ms': 1,\n'request_timeout_in_ms': 1,\n   
>  'truncate_request_timeout_in_ms': 1,\n'write_request_timeout_in_ms': 
> 1}\ndtest: DEBUG: Exporting to csv file: /tmp/tmpDS47Vq\ndtest: DEBUG: 
> Exporting to csv file: /tmp/tmpQvnl6e\ndtest: DEBUG: Exporting to csv file: 
> /tmp/tmpfEEiAz\ndtest: DEBUG: Exporting to csv file: /tmp/tmpc7T8av\ndtest: 
> DEBUG: Exporting to csv file: 

[jira] [Updated] (CASSANDRA-12430) dtest failure in cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_writing_with_token_boundaries

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12430:

Issue Type: Bug  (was: Test)

> dtest failure in 
> cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_writing_with_token_boundaries
> --
>
> Key: CASSANDRA-12430
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12430
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Craig Kodman
>Assignee: DS Test Eng
>  Labels: dtest
> Fix For: 3.0.x
>
> Attachments: node1.log, node1_debug.log, node1_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.0_dtest/787/testReport/cqlsh_tests.cqlsh_copy_tests/CqlshCopyTest/test_writing_with_token_boundaries
> Failed on CassCI build cassandra-3.0_dtest build #787
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/cqlsh_tests/cqlsh_copy_tests.py", 
> line 1022, in test_writing_with_token_boundaries
> self._test_writing_with_token_boundaries(1, None, 200)
>   File "/home/automaton/cassandra-dtest/cqlsh_tests/cqlsh_copy_tests.py", 
> line 1059, in _test_writing_with_token_boundaries
> self.assertItemsEqual(csv_values, result)
>   File "/usr/lib/python2.7/unittest/case.py", line 901, in assertItemsEqual
> self.fail(msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> "Element counts were not equal:\nFirst has 0, Second has 1:  ('130', 
> -4364617663693876050L)\nFirst has 0, Second has 1:  ('1504', 
> -4313346088993828066L)\nFirst has 0, Second has 1:  ('1657', 
> -4298243044528711865L)\nFirst has 0, Second has 1:  ('1908', 
> -4357762565998238890L)\nFirst has 0, Second has 1:  ('196', 
> -4311842292754600676L)\nFirst has 0, Second has 1:  ('2069', 
> -4364398944370882217L)\nFirst has 0, Second has 1:  ('2840', 
> -4341639477649832153L)\nFirst has 0, Second has 1:  ('2887', 
> -4318016824479819783L)\nFirst has 0, Second has 1:  ('2899', 
> -4302748366908469185L)\nFirst has 0, Second has 1:  ('2928', 
> -4320094196758787736L)\nFirst has 0, Second has 1:  ('2985', 
> -4314356124534988584L)\nFirst has 0, Second has 1:  ('3684', 
> -4338074463992249966L)\nFirst has 0, Second has 1:  ('371', 
> -4314424123257001171L)\nFirst has 0, Second has 1:  ('3726', 
> -4327342039280507889L)\nFirst has 0, Second has 1:  ('3767', 
> -4314615789624913427L)\nFirst has 0, Second has 1:  ('3837', 
> -4345782419910891107L)\nFirst has 0, Second has 1:  ('3917', 
> -4288469607605675346L)\nFirst has 0, Second has 1:  ('4023', 
> -4327319429102869913L)\nFirst has 0, Second has 1:  ('4340', 
> -4364719196309290555L)\nFirst has 0, Second has 1:  ('4775', 
> -4334399295585005795L)\nFirst has 0, Second has 1:  ('480', 
> -4297721626756162038L)\nFirst has 0, Second has 1:  ('4927', 
> -4363012199808638126L)\nFirst has 0, Second has 1:  ('5227', 
> -4322405738833807588L)\nFirst has 0, Second has 1:  ('564', 
> -4294201317243228473L)\nFirst has 0, Second has 1:  ('585', 
> -435900129350319L)\nFirst has 0, Second has 1:  ('5869', 
> -4350305245827564608L)\nFirst has 0, Second has 1:  ('6907', 
> -4350623491924194304L)\nFirst has 0, Second has 1:  ('709', 
> -4304008865600291097L)\nFirst has 0, Second has 1:  ('7415', 
> -4315752378065264743L)\nFirst has 0, Second has 1:  ('7476', 
> -4300546270541034340L)\nFirst has 0, Second has 1:  ('7805', 
> -4344641724309508742L)\nFirst has 0, Second has 1:  ('7922', 
> -4363605089028496367L)\nFirst has 0, Second has 1:  ('8026', 
> -4319008002233878821L)\nFirst has 0, Second has 1:  ('8180', 
> -4361912691055780971L)\nFirst has 0, Second has 1:  ('8371', 
> -4309172311179179912L)\nFirst has 0, Second has 1:  ('8988', 
> -432609343783541L)\nFirst has 0, Second has 1:  ('9492', 
> -4347264403260361686L)\nFirst has 0, Second has 1:  ('9783', 
> -4329297319597600121L)\nFirst has 0, Second has 1:  ('9911', 
> -4320490295580904236L)\n >> begin captured logging << 
> \ndtest: DEBUG: cluster ccm directory: 
> /tmp/dtest-2v8O54\ndtest: DEBUG: Done setting configuration options:\n{   
> 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': 
> 5,\n'range_request_timeout_in_ms': 1,\n
> 'read_request_timeout_in_ms': 1,\n'request_timeout_in_ms': 1,\n   
>  'truncate_request_timeout_in_ms': 1,\n'write_request_timeout_in_ms': 
> 1}\ndtest: DEBUG: Exporting to csv file: /tmp/tmpDS47Vq\ndtest: DEBUG: 
> Exporting to csv file: /tmp/tmpQvnl6e\ndtest: DEBUG: Exporting to csv file: 
> /tmp/tmpfEEiAz\ndtest: DEBUG: Exporting to csv file: /tmp/tmpc7T8av\ndtest: 
> DEBUG: 

[jira] [Updated] (CASSANDRA-12420) Duplicated Key in IN clause with a small fetch size will run forever

[Tyler Hobbs (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tyler Hobbs updated CASSANDRA-12420:

Fix Version/s: (was: 2.1.16)

> Duplicated Key in IN clause with a small fetch size will run forever
> 
>
> Key: CASSANDRA-12420
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12420
> Project: Cassandra
>  Issue Type: Bug
> Environment: cassandra 2.1.14, driver 2.1.7.1
>Reporter: ZhaoYang
>Assignee: ZhaoYang
> Attachments: CASSANDRA-12420.patch
>
>
> This can be easily reproduced and fetch size is smaller than the correct 
> number of rows.
> A table has 2 partition key, 1 clustering key, 1 column.
> >Select select = QueryBuilder.select().from("ks", "cf");
> >select.where().and(QueryBuilder.eq("a", 1));
> >select.where().and(QueryBuilder.in("b", Arrays.asList(1, 1, 1)));
> >select.setFetchSize(5);
> Now we put a distinct method in client side to eliminate the duplicated key, 
> but it's better to fix inside Cassandra.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12249) dtest failure in upgrade_tests.paging_test.TestPagingDataNodes3RF3_Upgrade_current_3_0_x_To_indev_3_x.basic_paging_test

[Tyler Hobbs (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tyler Hobbs updated CASSANDRA-12249:

   Resolution: Fixed
Fix Version/s: (was: 3.9)
   3.0.9
   Status: Resolved  (was: Ready to Commit)

Thanks, committed as {{465def8e295b453dc22430dc4bb7039f6921151e}} to 3.0 and 
merged up.

> dtest failure in 
> upgrade_tests.paging_test.TestPagingDataNodes3RF3_Upgrade_current_3_0_x_To_indev_3_x.basic_paging_test
> ---
>
> Key: CASSANDRA-12249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12249
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Philip Thompson
>Assignee: Tyler Hobbs
>  Labels: dtest
> Fix For: 3.0.9, 3.8
>
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.8_dtest_upgrade/1/testReport/upgrade_tests.paging_test/TestPagingDataNodes3RF3_Upgrade_current_3_0_x_To_indev_3_x/basic_paging_test
> Failed on CassCI build cassandra-3.8_dtest_upgrade #1
> This is on a mixed version cluster, one node is 3.0.8 and the other is 
> 3.8-tentative.
> Stack trace looks like:
> {code}
> ERROR [MessagingService-Incoming-/127.0.0.1] 2016-07-20 04:51:02,836 
> CassandraDaemon.java:201 - Exception in thread 
> Thread[MessagingService-Incoming-/127.0.0.1,5,main]
> java.lang.AssertionError: null
>   at 
> org.apache.cassandra.db.ReadCommand$LegacyPagedRangeCommandSerializer.deserialize(ReadCommand.java:1042)
>  ~[apache-cassandra-3.0.8.jar:3.0.8]
>   at 
> org.apache.cassandra.db.ReadCommand$LegacyPagedRangeCommandSerializer.deserialize(ReadCommand.java:964)
>  ~[apache-cassandra-3.0.8.jar:3.0.8]
>   at org.apache.cassandra.net.MessageIn.read(MessageIn.java:98) 
> ~[apache-cassandra-3.0.8.jar:3.0.8]
>   at 
> org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:201)
>  ~[apache-cassandra-3.0.8.jar:3.0.8]
>   at 
> org.apache.cassandra.net.IncomingTcpConnection.receiveMessages(IncomingTcpConnection.java:178)
>  ~[apache-cassandra-3.0.8.jar:3.0.8]
>   at 
> org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:92)
>  ~[apache-cassandra-3.0.8.jar:3.0.8]
> {code}
> This trace is from the 3.0.8 node.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[3/5] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.9

[tylerhobbs]

Merge branch 'cassandra-3.0' into cassandra-3.9


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2d769f0c
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2d769f0c
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2d769f0c

Branch: refs/heads/trunk
Commit: 2d769f0c5721be06a7401c69f45cfddf4d8fc736
Parents: 8458e4e 465def8
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:12:18 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:12:18 2016 -0500

--
 CHANGES.txt |  2 ++
 src/java/org/apache/cassandra/net/MessageOut.java   |  2 +-
 src/java/org/apache/cassandra/net/MessagingService.java | 10 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2d769f0c/CHANGES.txt
--
diff --cc CHANGES.txt
index 8fbd774,86746ad..9f7631d
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -22,48 -17,6 +22,50 @@@ Merged from 3.0
 to connect with too low of a protocol version (CASSANDRA-11464)
   * NullPointerExpception when reading/compacting table (CASSANDRA-11988)
   * Fix problem with undeleteable rows on upgrade to new sstable format 
(CASSANDRA-12144)
 +Merged from 2.2:
 + * Fix hanging stream session (CASSANDRA-10992)
 + * Fix INSERT JSON, fromJson() support of smallint, tinyint types 
(CASSANDRA-12371)
 + * Release sstables of failed stream sessions only when outgoing transfers 
are finished (CASSANDRA-11345)
 + * Wait for tracing events before returning response and query at same 
consistency level client side (CASSANDRA-11465)
 + * cqlsh copyutil should get host metadata by connected address 
(CASSANDRA-11979)
 + * Fixed cqlshlib.test.remove_test_db (CASSANDRA-12214)
 +Merged from 2.1:
 + * cannot use cql since upgrading python to 2.7.11+ (CASSANDRA-11850)
 + * Allow STCS-in-L0 compactions to reduce scope with LCS (CASSANDRA-12040)
 +
 +
 +3.8
 + * RTE from new CDC column breaks in flight queries (CASSANDRA-12236)
 + * Fix hdr logging for single operation workloads (CASSANDRA-12145)
 + * Fix SASI PREFIX search in CONTAINS mode with partial terms 
(CASSANDRA-12073)
 + * Increase size of flushExecutor thread pool (CASSANDRA-12071)
 + * Partial revert of CASSANDRA-11971, cannot recycle buffer in 
SP.sendMessagesToNonlocalDC (CASSANDRA-11950)
 + * Upgrade netty to 4.0.39 (CASSANDRA-12032, CASSANDRA-12034)
 + * Improve details in compaction log message (CASSANDRA-12080)
 + * Allow unset values in CQLSSTableWriter (CASSANDRA-11911)
 + * Chunk cache to request compressor-compatible buffers if pool space is 
exhausted (CASSANDRA-11993)
 + * Remove DatabaseDescriptor dependencies from SequentialWriter 
(CASSANDRA-11579)
 + * Move skip_stop_words filter before stemming (CASSANDRA-12078)
 + * Support seek() in EncryptedFileSegmentInputStream (CASSANDRA-11957)
 + * SSTable tools mishandling LocalPartitioner (CASSANDRA-12002)
 + * When SEPWorker assigned work, set thread name to match pool 
(CASSANDRA-11966)
 + * Add cross-DC latency metrics (CASSANDRA-11596)
 + * Allow terms in selection clause (CASSANDRA-10783)
 + * Add bind variables to trace (CASSANDRA-11719)
 + * Switch counter shards' clock to timestamps (CASSANDRA-9811)
 + * Introduce HdrHistogram and response/service/wait separation to stress tool 
(CASSANDRA-11853)
 + * entry-weighers in QueryProcessor should respect partitionKeyBindIndexes 
field (CASSANDRA-11718)
 + * Support older ant versions (CASSANDRA-11807)
 + * Estimate compressed on disk size when deciding if sstable size limit 
reached (CASSANDRA-11623)
 + * cassandra-stress profiles should support case sensitive schemas 
(CASSANDRA-11546)
 + * Remove DatabaseDescriptor dependency from FileUtils (CASSANDRA-11578)
 + * Faster streaming (CASSANDRA-9766)
 + * Add prepared query parameter to trace for "Execute CQL3 prepared query" 
session (CASSANDRA-11425)
 + * Add repaired percentage metric (CASSANDRA-11503)
 + * Add Change-Data-Capture (CASSANDRA-8844)
 +Merged from 3.0:
++ * Fix potential bad messaging service message for paged range reads
++   within mixed-version 3.x clusters (CASSANDRA-12249)
   * Fix paging logic for deleted partitions with static columns 
(CASSANDRA-12107)
   * Wait until the message is being send to decide which serializer must be 
used (CASSANDRA-11393)
   * Fix migration of static thrift column names with non-text comparators 
(CASSANDRA-12147)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2d769f0c/src/java/org/apache/cassandra/net/MessageOut.java
--

[4/5] cassandra git commit: Merge branch 'cassandra-3.8' into cassandra-3.9

[tylerhobbs]

Merge branch 'cassandra-3.8' into cassandra-3.9


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c3e636c5
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c3e636c5
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c3e636c5

Branch: refs/heads/trunk
Commit: c3e636c528a09371255d460ad6a91eb0c1d47875
Parents: 2d769f0 b188e08
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:12:33 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:12:33 2016 -0500

--

--

[1/5] cassandra git commit: Always use RANGE_SLICE verb for 3.x messages

[tylerhobbs]

Repository: cassandra
Updated Branches:
  refs/heads/trunk 89a927978 -> d32a745b2


Always use RANGE_SLICE verb for 3.x messages

Patch by Tyler Hobbs; reviewed by Benjamin Lerer for CASSANDRA-12249


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/465def8e
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/465def8e
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/465def8e

Branch: refs/heads/trunk
Commit: 465def8e295b453dc22430dc4bb7039f6921151e
Parents: 62ef861
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:09:38 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:09:38 2016 -0500

--
 CHANGES.txt |  2 ++
 src/java/org/apache/cassandra/net/MessageOut.java   |  2 +-
 src/java/org/apache/cassandra/net/MessagingService.java | 10 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/465def8e/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index f613c5f..86746ad 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,6 @@
 3.0.9
+ * Fix potential bad messaging service message for paged range reads
+   within mixed-version 3.x clusters (CASSANDRA-12249)
  * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)
  * NullPointerException during compaction on table with static columns 
(CASSANDRA-12336)
  * Fixed ConcurrentModificationException when reading metrics in 
GraphiteReporter (CASSANDRA-11823)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/465def8e/src/java/org/apache/cassandra/net/MessageOut.java
--
diff --git a/src/java/org/apache/cassandra/net/MessageOut.java 
b/src/java/org/apache/cassandra/net/MessageOut.java
index a524e7a..ce190cb 100644
--- a/src/java/org/apache/cassandra/net/MessageOut.java
+++ b/src/java/org/apache/cassandra/net/MessageOut.java
@@ -109,7 +109,7 @@ public class MessageOut
 {
 CompactEndpointSerializationHelper.serialize(from, out);
 
-out.writeInt(verb.ordinal());
+
out.writeInt(MessagingService.Verb.convertForMessagingServiceVersion(verb, 
version).ordinal());
 out.writeInt(parameters.size());
 for (Map.Entry entry : parameters.entrySet())
 {

http://git-wip-us.apache.org/repos/asf/cassandra/blob/465def8e/src/java/org/apache/cassandra/net/MessagingService.java
--
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java 
b/src/java/org/apache/cassandra/net/MessagingService.java
index d01419f..45cfb8a 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -148,6 +148,16 @@ public final class MessagingService implements 
MessagingServiceMBean
 UNUSED_4,
 UNUSED_5,
 ;
+
+// This is to support a "late" choice of the verb based on the 
messaging service version.
+// See CASSANDRA-12249 for more details.
+public static Verb convertForMessagingServiceVersion(Verb verb, int 
version)
+{
+if (verb == PAGED_RANGE && version >= VERSION_30)
+return RANGE_SLICE;
+
+return verb;
+}
 }
 
 public static final EnumMap verbStages = new 
EnumMap(MessagingService.Verb.class)

[2/5] cassandra git commit: Always use RANGE_SLICE verb for 3.x messages

[tylerhobbs]

Always use RANGE_SLICE verb for 3.x messages

Patch by Tyler Hobbs; reviewed by Benjamin Lerer for CASSANDRA-12249


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b188e082
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b188e082
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b188e082

Branch: refs/heads/trunk
Commit: b188e0826e6b9a14d137b9497bb63dec875f6c83
Parents: 18c357b
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:09:38 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:11:30 2016 -0500

--
 CHANGES.txt |  2 ++
 src/java/org/apache/cassandra/net/MessageOut.java   |  2 +-
 src/java/org/apache/cassandra/net/MessagingService.java | 10 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/b188e082/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 388a290..10c5d40 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -28,6 +28,8 @@
  * Add repaired percentage metric (CASSANDRA-11503)
  * Add Change-Data-Capture (CASSANDRA-8844)
 Merged from 3.0:
+ * Fix potential bad messaging service message for paged range reads
+   within mixed-version 3.x clusters (CASSANDRA-12249)
  * Fix paging logic for deleted partitions with static columns 
(CASSANDRA-12107)
  * Wait until the message is being send to decide which serializer must be 
used (CASSANDRA-11393)
  * Fix migration of static thrift column names with non-text comparators 
(CASSANDRA-12147)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b188e082/src/java/org/apache/cassandra/net/MessageOut.java
--
diff --git a/src/java/org/apache/cassandra/net/MessageOut.java 
b/src/java/org/apache/cassandra/net/MessageOut.java
index bc5c41b..34694a6 100644
--- a/src/java/org/apache/cassandra/net/MessageOut.java
+++ b/src/java/org/apache/cassandra/net/MessageOut.java
@@ -104,7 +104,7 @@ public class MessageOut
 {
 CompactEndpointSerializationHelper.serialize(from, out);
 
-out.writeInt(verb.ordinal());
+
out.writeInt(MessagingService.Verb.convertForMessagingServiceVersion(verb, 
version).ordinal());
 out.writeInt(parameters.size());
 for (Map.Entry entry : parameters.entrySet())
 {

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b188e082/src/java/org/apache/cassandra/net/MessagingService.java
--
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java 
b/src/java/org/apache/cassandra/net/MessagingService.java
index 220fc66..3302357 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -151,6 +151,16 @@ public final class MessagingService implements 
MessagingServiceMBean
 UNUSED_4,
 UNUSED_5,
 ;
+
+// This is to support a "late" choice of the verb based on the 
messaging service version.
+// See CASSANDRA-12249 for more details.
+public static Verb convertForMessagingServiceVersion(Verb verb, int 
version)
+{
+if (verb == PAGED_RANGE && version >= VERSION_30)
+return RANGE_SLICE;
+
+return verb;
+}
 }
 
 public static final EnumMap verbStages = new 
EnumMap(MessagingService.Verb.class)

[5/5] cassandra git commit: Merge branch 'cassandra-3.9' into trunk

[tylerhobbs]

Merge branch 'cassandra-3.9' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/d32a745b
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/d32a745b
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/d32a745b

Branch: refs/heads/trunk
Commit: d32a745b278b7e190ab7f4bc486c578f9ae33bc5
Parents: 89a9279 c3e636c
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:12:45 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:12:45 2016 -0500

--
 CHANGES.txt |  2 ++
 src/java/org/apache/cassandra/net/MessageOut.java   |  2 +-
 src/java/org/apache/cassandra/net/MessagingService.java | 10 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/d32a745b/CHANGES.txt
--

http://git-wip-us.apache.org/repos/asf/cassandra/blob/d32a745b/src/java/org/apache/cassandra/net/MessageOut.java
--

http://git-wip-us.apache.org/repos/asf/cassandra/blob/d32a745b/src/java/org/apache/cassandra/net/MessagingService.java
--
diff --cc src/java/org/apache/cassandra/net/MessagingService.java
index b1f88ee,3302357..243bf0c
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@@ -151,10 -151,18 +151,20 @@@ public final class MessagingService imp
  UNUSED_4,
  UNUSED_5,
  ;
+ 
+ // This is to support a "late" choice of the verb based on the 
messaging service version.
+ // See CASSANDRA-12249 for more details.
+ public static Verb convertForMessagingServiceVersion(Verb verb, int 
version)
+ {
+ if (verb == PAGED_RANGE && version >= VERSION_30)
+ return RANGE_SLICE;
+ 
+ return verb;
+ }
  }
  
 +public static final Verb[] verbValues = Verb.values();
 +
  public static final EnumMap verbStages = 
new EnumMap(MessagingService.Verb.class)
  {{
  put(Verb.MUTATION, Stage.MUTATION);

[1/4] cassandra git commit: Always use RANGE_SLICE verb for 3.x messages

[tylerhobbs]

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-3.9 8458e4e30 -> c3e636c52


Always use RANGE_SLICE verb for 3.x messages

Patch by Tyler Hobbs; reviewed by Benjamin Lerer for CASSANDRA-12249


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/465def8e
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/465def8e
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/465def8e

Branch: refs/heads/cassandra-3.9
Commit: 465def8e295b453dc22430dc4bb7039f6921151e
Parents: 62ef861
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:09:38 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:09:38 2016 -0500

--
 CHANGES.txt |  2 ++
 src/java/org/apache/cassandra/net/MessageOut.java   |  2 +-
 src/java/org/apache/cassandra/net/MessagingService.java | 10 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/465def8e/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index f613c5f..86746ad 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,6 @@
 3.0.9
+ * Fix potential bad messaging service message for paged range reads
+   within mixed-version 3.x clusters (CASSANDRA-12249)
  * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)
  * NullPointerException during compaction on table with static columns 
(CASSANDRA-12336)
  * Fixed ConcurrentModificationException when reading metrics in 
GraphiteReporter (CASSANDRA-11823)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/465def8e/src/java/org/apache/cassandra/net/MessageOut.java
--
diff --git a/src/java/org/apache/cassandra/net/MessageOut.java 
b/src/java/org/apache/cassandra/net/MessageOut.java
index a524e7a..ce190cb 100644
--- a/src/java/org/apache/cassandra/net/MessageOut.java
+++ b/src/java/org/apache/cassandra/net/MessageOut.java
@@ -109,7 +109,7 @@ public class MessageOut
 {
 CompactEndpointSerializationHelper.serialize(from, out);
 
-out.writeInt(verb.ordinal());
+
out.writeInt(MessagingService.Verb.convertForMessagingServiceVersion(verb, 
version).ordinal());
 out.writeInt(parameters.size());
 for (Map.Entry entry : parameters.entrySet())
 {

http://git-wip-us.apache.org/repos/asf/cassandra/blob/465def8e/src/java/org/apache/cassandra/net/MessagingService.java
--
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java 
b/src/java/org/apache/cassandra/net/MessagingService.java
index d01419f..45cfb8a 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -148,6 +148,16 @@ public final class MessagingService implements 
MessagingServiceMBean
 UNUSED_4,
 UNUSED_5,
 ;
+
+// This is to support a "late" choice of the verb based on the 
messaging service version.
+// See CASSANDRA-12249 for more details.
+public static Verb convertForMessagingServiceVersion(Verb verb, int 
version)
+{
+if (verb == PAGED_RANGE && version >= VERSION_30)
+return RANGE_SLICE;
+
+return verb;
+}
 }
 
 public static final EnumMap verbStages = new 
EnumMap(MessagingService.Verb.class)

[4/4] cassandra git commit: Merge branch 'cassandra-3.8' into cassandra-3.9

[tylerhobbs]

Merge branch 'cassandra-3.8' into cassandra-3.9


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c3e636c5
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c3e636c5
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c3e636c5

Branch: refs/heads/cassandra-3.9
Commit: c3e636c528a09371255d460ad6a91eb0c1d47875
Parents: 2d769f0 b188e08
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:12:33 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:12:33 2016 -0500

--

--

[2/4] cassandra git commit: Always use RANGE_SLICE verb for 3.x messages

[tylerhobbs]

Always use RANGE_SLICE verb for 3.x messages

Patch by Tyler Hobbs; reviewed by Benjamin Lerer for CASSANDRA-12249


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b188e082
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b188e082
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b188e082

Branch: refs/heads/cassandra-3.9
Commit: b188e0826e6b9a14d137b9497bb63dec875f6c83
Parents: 18c357b
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:09:38 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:11:30 2016 -0500

--
 CHANGES.txt |  2 ++
 src/java/org/apache/cassandra/net/MessageOut.java   |  2 +-
 src/java/org/apache/cassandra/net/MessagingService.java | 10 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/b188e082/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 388a290..10c5d40 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -28,6 +28,8 @@
  * Add repaired percentage metric (CASSANDRA-11503)
  * Add Change-Data-Capture (CASSANDRA-8844)
 Merged from 3.0:
+ * Fix potential bad messaging service message for paged range reads
+   within mixed-version 3.x clusters (CASSANDRA-12249)
  * Fix paging logic for deleted partitions with static columns 
(CASSANDRA-12107)
  * Wait until the message is being send to decide which serializer must be 
used (CASSANDRA-11393)
  * Fix migration of static thrift column names with non-text comparators 
(CASSANDRA-12147)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b188e082/src/java/org/apache/cassandra/net/MessageOut.java
--
diff --git a/src/java/org/apache/cassandra/net/MessageOut.java 
b/src/java/org/apache/cassandra/net/MessageOut.java
index bc5c41b..34694a6 100644
--- a/src/java/org/apache/cassandra/net/MessageOut.java
+++ b/src/java/org/apache/cassandra/net/MessageOut.java
@@ -104,7 +104,7 @@ public class MessageOut
 {
 CompactEndpointSerializationHelper.serialize(from, out);
 
-out.writeInt(verb.ordinal());
+
out.writeInt(MessagingService.Verb.convertForMessagingServiceVersion(verb, 
version).ordinal());
 out.writeInt(parameters.size());
 for (Map.Entry entry : parameters.entrySet())
 {

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b188e082/src/java/org/apache/cassandra/net/MessagingService.java
--
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java 
b/src/java/org/apache/cassandra/net/MessagingService.java
index 220fc66..3302357 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -151,6 +151,16 @@ public final class MessagingService implements 
MessagingServiceMBean
 UNUSED_4,
 UNUSED_5,
 ;
+
+// This is to support a "late" choice of the verb based on the 
messaging service version.
+// See CASSANDRA-12249 for more details.
+public static Verb convertForMessagingServiceVersion(Verb verb, int 
version)
+{
+if (verb == PAGED_RANGE && version >= VERSION_30)
+return RANGE_SLICE;
+
+return verb;
+}
 }
 
 public static final EnumMap verbStages = new 
EnumMap(MessagingService.Verb.class)

[3/4] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.9

[tylerhobbs]

Merge branch 'cassandra-3.0' into cassandra-3.9


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2d769f0c
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2d769f0c
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2d769f0c

Branch: refs/heads/cassandra-3.9
Commit: 2d769f0c5721be06a7401c69f45cfddf4d8fc736
Parents: 8458e4e 465def8
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:12:18 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:12:18 2016 -0500

--
 CHANGES.txt |  2 ++
 src/java/org/apache/cassandra/net/MessageOut.java   |  2 +-
 src/java/org/apache/cassandra/net/MessagingService.java | 10 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2d769f0c/CHANGES.txt
--
diff --cc CHANGES.txt
index 8fbd774,86746ad..9f7631d
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -22,48 -17,6 +22,50 @@@ Merged from 3.0
 to connect with too low of a protocol version (CASSANDRA-11464)
   * NullPointerExpception when reading/compacting table (CASSANDRA-11988)
   * Fix problem with undeleteable rows on upgrade to new sstable format 
(CASSANDRA-12144)
 +Merged from 2.2:
 + * Fix hanging stream session (CASSANDRA-10992)
 + * Fix INSERT JSON, fromJson() support of smallint, tinyint types 
(CASSANDRA-12371)
 + * Release sstables of failed stream sessions only when outgoing transfers 
are finished (CASSANDRA-11345)
 + * Wait for tracing events before returning response and query at same 
consistency level client side (CASSANDRA-11465)
 + * cqlsh copyutil should get host metadata by connected address 
(CASSANDRA-11979)
 + * Fixed cqlshlib.test.remove_test_db (CASSANDRA-12214)
 +Merged from 2.1:
 + * cannot use cql since upgrading python to 2.7.11+ (CASSANDRA-11850)
 + * Allow STCS-in-L0 compactions to reduce scope with LCS (CASSANDRA-12040)
 +
 +
 +3.8
 + * RTE from new CDC column breaks in flight queries (CASSANDRA-12236)
 + * Fix hdr logging for single operation workloads (CASSANDRA-12145)
 + * Fix SASI PREFIX search in CONTAINS mode with partial terms 
(CASSANDRA-12073)
 + * Increase size of flushExecutor thread pool (CASSANDRA-12071)
 + * Partial revert of CASSANDRA-11971, cannot recycle buffer in 
SP.sendMessagesToNonlocalDC (CASSANDRA-11950)
 + * Upgrade netty to 4.0.39 (CASSANDRA-12032, CASSANDRA-12034)
 + * Improve details in compaction log message (CASSANDRA-12080)
 + * Allow unset values in CQLSSTableWriter (CASSANDRA-11911)
 + * Chunk cache to request compressor-compatible buffers if pool space is 
exhausted (CASSANDRA-11993)
 + * Remove DatabaseDescriptor dependencies from SequentialWriter 
(CASSANDRA-11579)
 + * Move skip_stop_words filter before stemming (CASSANDRA-12078)
 + * Support seek() in EncryptedFileSegmentInputStream (CASSANDRA-11957)
 + * SSTable tools mishandling LocalPartitioner (CASSANDRA-12002)
 + * When SEPWorker assigned work, set thread name to match pool 
(CASSANDRA-11966)
 + * Add cross-DC latency metrics (CASSANDRA-11596)
 + * Allow terms in selection clause (CASSANDRA-10783)
 + * Add bind variables to trace (CASSANDRA-11719)
 + * Switch counter shards' clock to timestamps (CASSANDRA-9811)
 + * Introduce HdrHistogram and response/service/wait separation to stress tool 
(CASSANDRA-11853)
 + * entry-weighers in QueryProcessor should respect partitionKeyBindIndexes 
field (CASSANDRA-11718)
 + * Support older ant versions (CASSANDRA-11807)
 + * Estimate compressed on disk size when deciding if sstable size limit 
reached (CASSANDRA-11623)
 + * cassandra-stress profiles should support case sensitive schemas 
(CASSANDRA-11546)
 + * Remove DatabaseDescriptor dependency from FileUtils (CASSANDRA-11578)
 + * Faster streaming (CASSANDRA-9766)
 + * Add prepared query parameter to trace for "Execute CQL3 prepared query" 
session (CASSANDRA-11425)
 + * Add repaired percentage metric (CASSANDRA-11503)
 + * Add Change-Data-Capture (CASSANDRA-8844)
 +Merged from 3.0:
++ * Fix potential bad messaging service message for paged range reads
++   within mixed-version 3.x clusters (CASSANDRA-12249)
   * Fix paging logic for deleted partitions with static columns 
(CASSANDRA-12107)
   * Wait until the message is being send to decide which serializer must be 
used (CASSANDRA-11393)
   * Fix migration of static thrift column names with non-text comparators 
(CASSANDRA-12147)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2d769f0c/src/java/org/apache/cassandra/net/MessageOut.java
--

cassandra git commit: Always use RANGE_SLICE verb for 3.x messages

[tylerhobbs]

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-3.0 62ef8617c -> 465def8e2


Always use RANGE_SLICE verb for 3.x messages

Patch by Tyler Hobbs; reviewed by Benjamin Lerer for CASSANDRA-12249


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/465def8e
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/465def8e
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/465def8e

Branch: refs/heads/cassandra-3.0
Commit: 465def8e295b453dc22430dc4bb7039f6921151e
Parents: 62ef861
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:09:38 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:09:38 2016 -0500

--
 CHANGES.txt |  2 ++
 src/java/org/apache/cassandra/net/MessageOut.java   |  2 +-
 src/java/org/apache/cassandra/net/MessagingService.java | 10 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/465def8e/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index f613c5f..86746ad 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,6 @@
 3.0.9
+ * Fix potential bad messaging service message for paged range reads
+   within mixed-version 3.x clusters (CASSANDRA-12249)
  * Change commitlog and sstables to track dirty and clean intervals 
(CASSANDRA-11828)
  * NullPointerException during compaction on table with static columns 
(CASSANDRA-12336)
  * Fixed ConcurrentModificationException when reading metrics in 
GraphiteReporter (CASSANDRA-11823)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/465def8e/src/java/org/apache/cassandra/net/MessageOut.java
--
diff --git a/src/java/org/apache/cassandra/net/MessageOut.java 
b/src/java/org/apache/cassandra/net/MessageOut.java
index a524e7a..ce190cb 100644
--- a/src/java/org/apache/cassandra/net/MessageOut.java
+++ b/src/java/org/apache/cassandra/net/MessageOut.java
@@ -109,7 +109,7 @@ public class MessageOut
 {
 CompactEndpointSerializationHelper.serialize(from, out);
 
-out.writeInt(verb.ordinal());
+
out.writeInt(MessagingService.Verb.convertForMessagingServiceVersion(verb, 
version).ordinal());
 out.writeInt(parameters.size());
 for (Map.Entry entry : parameters.entrySet())
 {

http://git-wip-us.apache.org/repos/asf/cassandra/blob/465def8e/src/java/org/apache/cassandra/net/MessagingService.java
--
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java 
b/src/java/org/apache/cassandra/net/MessagingService.java
index d01419f..45cfb8a 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -148,6 +148,16 @@ public final class MessagingService implements 
MessagingServiceMBean
 UNUSED_4,
 UNUSED_5,
 ;
+
+// This is to support a "late" choice of the verb based on the 
messaging service version.
+// See CASSANDRA-12249 for more details.
+public static Verb convertForMessagingServiceVersion(Verb verb, int 
version)
+{
+if (verb == PAGED_RANGE && version >= VERSION_30)
+return RANGE_SLICE;
+
+return verb;
+}
 }
 
 public static final EnumMap verbStages = new 
EnumMap(MessagingService.Verb.class)

cassandra git commit: Always use RANGE_SLICE verb for 3.x messages

[tylerhobbs]

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-3.8 18c357b86 -> b188e0826


Always use RANGE_SLICE verb for 3.x messages

Patch by Tyler Hobbs; reviewed by Benjamin Lerer for CASSANDRA-12249


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b188e082
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b188e082
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b188e082

Branch: refs/heads/cassandra-3.8
Commit: b188e0826e6b9a14d137b9497bb63dec875f6c83
Parents: 18c357b
Author: Tyler Hobbs 
Authored: Wed Aug 10 11:09:38 2016 -0500
Committer: Tyler Hobbs 
Committed: Wed Aug 10 11:11:30 2016 -0500

--
 CHANGES.txt |  2 ++
 src/java/org/apache/cassandra/net/MessageOut.java   |  2 +-
 src/java/org/apache/cassandra/net/MessagingService.java | 10 ++
 3 files changed, 13 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/b188e082/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 388a290..10c5d40 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -28,6 +28,8 @@
  * Add repaired percentage metric (CASSANDRA-11503)
  * Add Change-Data-Capture (CASSANDRA-8844)
 Merged from 3.0:
+ * Fix potential bad messaging service message for paged range reads
+   within mixed-version 3.x clusters (CASSANDRA-12249)
  * Fix paging logic for deleted partitions with static columns 
(CASSANDRA-12107)
  * Wait until the message is being send to decide which serializer must be 
used (CASSANDRA-11393)
  * Fix migration of static thrift column names with non-text comparators 
(CASSANDRA-12147)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b188e082/src/java/org/apache/cassandra/net/MessageOut.java
--
diff --git a/src/java/org/apache/cassandra/net/MessageOut.java 
b/src/java/org/apache/cassandra/net/MessageOut.java
index bc5c41b..34694a6 100644
--- a/src/java/org/apache/cassandra/net/MessageOut.java
+++ b/src/java/org/apache/cassandra/net/MessageOut.java
@@ -104,7 +104,7 @@ public class MessageOut
 {
 CompactEndpointSerializationHelper.serialize(from, out);
 
-out.writeInt(verb.ordinal());
+
out.writeInt(MessagingService.Verb.convertForMessagingServiceVersion(verb, 
version).ordinal());
 out.writeInt(parameters.size());
 for (Map.Entry entry : parameters.entrySet())
 {

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b188e082/src/java/org/apache/cassandra/net/MessagingService.java
--
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java 
b/src/java/org/apache/cassandra/net/MessagingService.java
index 220fc66..3302357 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -151,6 +151,16 @@ public final class MessagingService implements 
MessagingServiceMBean
 UNUSED_4,
 UNUSED_5,
 ;
+
+// This is to support a "late" choice of the verb based on the 
messaging service version.
+// See CASSANDRA-12249 for more details.
+public static Verb convertForMessagingServiceVersion(Verb verb, int 
version)
+{
+if (verb == PAGED_RANGE && version >= VERSION_30)
+return RANGE_SLICE;
+
+return verb;
+}
 }
 
 public static final EnumMap verbStages = new 
EnumMap(MessagingService.Verb.class)

[jira] [Comment Edited] (CASSANDRA-9876) One way targeted repair

[Paulo Motta (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415478#comment-15415478
 ] 

Paulo Motta edited comment on CASSANDRA-9876 at 8/10/16 3:54 PM:
-

Thanks for the follow-up. Updated patch and dtests LGTM.

bq. The reason why I added in the check for a token range was that the repair 
code as it is now doesn’t actually add only the common ranges between the 
specified hosts. I wasn’t sure if this is was the intended behavior or a bug.

You're right, thanks for pointing this out. I was having {{-pr}} option in 
mind, but it seems like it's not possible to combine {{-pr}} and {{-hosts}} 
since CASSANDRA-7317. As a matter of fact this limitation was discussed on 
parent ticket CASSANDRA-6440, and it seems like it's expected behavior.

bq. If this is intended behavior, then forcing the user to specify a token 
range that is common between the nodes prevents that exception from being 
thrown. Otherwise the error message, “Repair requires at least two endpoints 
that are neighbours before it can continue” can be confusing to the operator 
since the two specified nodes may actually share a common range.

Agreed, in any case I updated the error message to the following to make it 
clearer when {{--pull}} is not specified:
{noformat}
Specified hosts [127.0.0.2, 127.0.0.1] do not share range 
(-3074457345618258503,3074457345618258602] needed for repair. Either restrict 
repair ranges with -st/-et options, or specify one of the neighbors that share 
this range with this node: [/127.0.0.3, /127.0.0.4, /127.0.0.6].
{noformat}

When trying to reproduce this, I noticed two minor problems with the repair 
command so I included 2 ninja commits to fix those (could you have a look?):

1. When there is an exception while running repair, the 
[RepairRunner|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/RepairRunner.java#L108]
 prints a {{\[2016-08-10 09:16:41,291\] null}} message after the actual error 
message due to {{RepairRunnable}} not including any message in the {{COMPLETE}} 
event on 
[fireErrorAndComplete|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L106],
 so I added a {{Repair command #x finished with error}} message to avoid null 
being print when there is an error during repair.
2. Currently {{\-\-dc}} and {{\-\-hosts}} option are mutually exclusive on 
[ActiveRepairService.getNeighbors|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/ActiveRepairService.java#L226],
 but if you specify them together the {{--hosts}} option is silently ignored, 
so I added a minor check on 
[RepairOption|https://github.com/apache/cassandra/blob/b7b3d881d38cfbac0616dabd17ae303c40d8b003/src/java/org/apache/cassandra/repair/messages/RepairOption.java#L222]
 to avoid combining these two options.

Update branch and CI submissions links are below:

||trunk||
|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-9876]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-9876-testall/lastCompletedBuild/testReport/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-9876-dtest/lastCompletedBuild/testReport/]|

After CI results look good and you verified the additional changes I will mark 
this as ready to commit. Can you open a dtest pull request to 
https://github.com/riptano/cassandra-dtest ?


was (Author: pauloricardomg):
Thanks for the follow-up. Updated patch and dtests LGTM.

bq. The reason why I added in the check for a token range was that the repair 
code as it is now doesn’t actually add only the common ranges between the 
specified hosts. I wasn’t sure if this is was the intended behavior or a bug.

You're right, thanks for pointing this out. I was having {{-pr}} option in 
mind, but it seems like it's not possible to combine {{-pr}} and {{-hosts}} 
since CASSANDRA-7317. As a matter of fact this limitation was discussed on 
parent ticket CASSANDRA-6440, and it seems like it's expected behavior.

bq. If this is intended behavior, then forcing the user to specify a token 
range that is common between the nodes prevents that exception from being 
thrown. Otherwise the error message, “Repair requires at least two endpoints 
that are neighbours before it can continue” can be confusing to the operator 
since the two specified nodes may actually share a common range.

Agreed, in any case I updated the error message to the following to make it 
clearer when {{--pull}} is not specified:
{noformat}
Specified hosts [127.0.0.2, 127.0.0.1] do not share range 
(-3074457345618258503,3074457345618258602] needed for repair. Either restrict 
repair ranges with -st/-et options, or specify one of the neighbors that share 
this range with this node: [/127.0.0.3, /127.0.0.4, 

[jira] [Commented] (CASSANDRA-12253) Fix exceptions when enabling gossip on proxy nodes.

[Brandon Williams (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415480#comment-15415480
 ] 

Brandon Williams commented on CASSANDRA-12253:
--

Well, we're not a member, so announcing shutdown isn't really necessary and 
doesn't provide much value, so maybe add a check on that, then just skip the 
shutdown state and let the FD handle it?

> Fix exceptions when enabling gossip on proxy nodes.
> ---
>
> Key: CASSANDRA-12253
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12253
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Dikang Gu
>Assignee: Dikang Gu
>Priority: Minor
> Fix For: 2.2.x
>
> Attachments: 0001-for-proxy-node-not-set-gossip-tokens.patch, 
> 0002-for-proxy-node-not-set-gossip-tokens.patch
>
>
> We have a tier of Cassandra nodes running with join_ring=false flag, which we 
> call proxy nodes, and they will never join the ring.
> The problem is that sometimes we need to disable and enable the gossip on 
> those nodes, and `nodetool enablegossip` throws exceptions when we do that:
> {code}
> java.lang.AssertionError
> at 
> org.apache.cassandra.service.StorageService.getLocalTokens(StorageService.java:2213)
> at 
> org.apache.cassandra.service.StorageService.startGossiping(StorageService.java:371)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:75)
> at sun.reflect.GeneratedMethodAccessor8.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:279)
> at 
> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
> at 
> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
> at 
> com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
> at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
> at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
> at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
> at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1487)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:97)
> at 
> javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1328)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1420)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:848)
> at sun.reflect.GeneratedMethodAccessor52.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:322)
> at sun.rmi.transport.Transport$1.run(Transport.java:177)
> at sun.rmi.transport.Transport$1.run(Transport.java:174)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:173)
> at 
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:556)
> at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:811)
> at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:670)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-9876) One way targeted repair

[Paulo Motta (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-9876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415478#comment-15415478
 ] 

Paulo Motta commented on CASSANDRA-9876:


Thanks for the follow-up. Updated patch and dtests LGTM.

bq. The reason why I added in the check for a token range was that the repair 
code as it is now doesn’t actually add only the common ranges between the 
specified hosts. I wasn’t sure if this is was the intended behavior or a bug.

You're right, thanks for pointing this out. I was having {{-pr}} option in 
mind, but it seems like it's not possible to combine {{-pr}} and {{-hosts}} 
since CASSANDRA-7317. As a matter of fact this limitation was discussed on 
parent ticket CASSANDRA-6440, and it seems like it's expected behavior.

bq. If this is intended behavior, then forcing the user to specify a token 
range that is common between the nodes prevents that exception from being 
thrown. Otherwise the error message, “Repair requires at least two endpoints 
that are neighbours before it can continue” can be confusing to the operator 
since the two specified nodes may actually share a common range.

Agreed, in any case I updated the error message to the following to make it 
clearer when {{--pull}} is not specified:
{noformat}
Specified hosts [127.0.0.2, 127.0.0.1] do not share range 
(-3074457345618258503,3074457345618258602] needed for repair. Either restrict 
repair ranges with -st/-et options, or specify one of the neighbors that share 
this range with this node: [/127.0.0.3, /127.0.0.4, /127.0.0.6].
{noformat}

When trying to reproduce this, I noticed two minor problems with the repair 
command so I included 2 ninja commits to fix those (could you have a look?):

1. When there is an exception while running repair, the 
[RepairRunner|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/RepairRunner.java#L108]
 prints a {{\[2016-08-10 09:16:41,291\] null}} message after the actual error 
message due to {{RepairRunnable}} not including any message in the {{COMPLETE}} 
event on 
[fireErrorAndComplete|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairRunnable.java#L106],
 so I added a {{Repair command #x finished with error}} message to avoid null 
being print when there is an error during repair.
2. Currently {{\-\-dc}} and {{\-\-hosts}} option are mutually exclusive on 
[ActiveRepairService.getNeighbors|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/ActiveRepairService.java#L226],
 but if you specify them together the {{--hosts}} option is silently ignored, 
so I added a minor check to avoid combining this two options.

Update branch and CI submissions links are below:

||trunk||
|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-9876]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-9876-testall/lastCompletedBuild/testReport/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-9876-dtest/lastCompletedBuild/testReport/]|

After CI results look good and you verified the additional changes I will mark 
this as ready to commit. Can you open a dtest pull request to 
https://github.com/riptano/cassandra-dtest ?

> One way targeted repair
> ---
>
> Key: CASSANDRA-9876
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9876
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: sankalp kohli
>Assignee: Geoffrey Yu
>Priority: Minor
> Fix For: 3.x
>
> Attachments: 9876-dtest-master.txt, 9876-trunk-v2.txt, 9876-trunk.txt
>
>
> Many applications use C* by writing to one local DC. The other DC is used 
> when the local DC is unavailable. When the local DC becomes available, we 
> want to run a targeted repair b/w one endpoint from each DC to minimize the 
> data transfer over WAN.  In this case, it will be helpful to do a one way 
> repair in which data will only be streamed from other DC to local DC instead 
> of streaming the data both ways. This will further minimize the traffic over 
> WAN. This feature should only be supported if a targeted repair is run 
> involving 2 hosts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12415) dtest failure in replace_address_test.TestReplaceAddress.replace_stopped_node_test

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12415:

Assignee: Jim Witschey  (was: DS Test Eng)

> dtest failure in 
> replace_address_test.TestReplaceAddress.replace_stopped_node_test
> --
>
> Key: CASSANDRA-12415
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12415
> Project: Cassandra
>  Issue Type: Test
>Reporter: Philip Thompson
>Assignee: Jim Witschey
>  Labels: dtest
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.9_dtest/31/testReport/replace_address_test/TestReplaceAddress/replace_stopped_node_test
> Node4 just doesn't start up in time. Maybe bump up the timeout, or move to 
> large test?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12427) dtest failure in consistency_test.TestAvailability.test_network_topology_strategy

[Philip Thompson (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415450#comment-15415450
 ] 

Philip Thompson commented on CASSANDRA-12427:
-

I believe I resolved the hiccup by reverting all the config changes, but let's 
wait for some successful builds to confirm

> dtest failure in 
> consistency_test.TestAvailability.test_network_topology_strategy
> -
>
> Key: CASSANDRA-12427
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12427
> Project: Cassandra
>  Issue Type: Test
>Reporter: Craig Kodman
>Assignee: Sean McCarthy
>  Labels: dtest
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-2.2_dtest/669/testReport/consistency_test/TestAvailability/test_network_topology_strategy
> Failed on CassCI build cassandra-2.2_dtest build #669
> {code}
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/consistency_test.py", line 319, in 
> test_network_topology_strategy
> self._start_cluster()
>   File "/home/automaton/cassandra-dtest/consistency_test.py", line 96, in 
> _start_cluster
> cluster.start(wait_for_binary_proto=True, wait_other_notice=True)
>   File "/home/automaton/ccm/ccmlib/cluster.py", line 414, in start
> raise NodeError("Error starting {0}.".format(node.name), p)
> "Error starting node9.\n >> begin captured logging << 
> \ndtest: DEBUG: cluster ccm directory: 
> /tmp/dtest-an_vc5\ndtest: DEBUG: Done setting configuration options:\n{   
> 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': 
> 5,\n'range_request_timeout_in_ms': 1,\n
> 'read_request_timeout_in_ms': 1,\n'request_timeout_in_ms': 1,\n   
>  'truncate_request_timeout_in_ms': 1,\n'write_request_timeout_in_ms': 
> 1}\n- >> end captured logging << 
> -"
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12426) Writing a null value into a dense table results into a no-op

[Jeremiah Jordan (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415445#comment-15415445
 ] 

Jeremiah Jordan commented on CASSANDRA-12426:
-

+1 on "Won't Fix" this is the correct behavior for COMPACT STORAGE

> Writing a null value into a dense table results into a no-op 
> -
>
> Key: CASSANDRA-12426
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12426
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Alex Petrov
>
> Making an insert into the dense table doesn't seem to create a live partition:
> {code}
> cqlsh> CREATE KEYSPACE test WITH replication = {'class': 
> 'NetworkTopologyStrategy', 'datacenter1': '1' };
> cqlsh> use test ;
> cqlsh:test> CREATE TABLE a (partition text, key text, owner text, PRIMARY KEY 
> (partition, key) ) WITH COMPACT STORAGE;
> cqlsh:test> INSERT INTO a (partition, key, owner) VALUES ('a', 'b', null);
> cqlsh:test> select * from a;
>  partition | key | owner
> ---+-+
> {code}
> (same behaviour on 2.2)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (CASSANDRA-12415) dtest failure in replace_address_test.TestReplaceAddress.replace_stopped_node_test

[Jim Witschey (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415434#comment-15415434
 ] 

Jim Witschey edited comment on CASSANDRA-12415 at 8/10/16 3:17 PM:
---

+1 to moving to larger instances. Filed 
https://github.com/riptano/cassandra-dtest/pull/1204


was (Author: mambocab):
+1 to moving to larger instances. 

> dtest failure in 
> replace_address_test.TestReplaceAddress.replace_stopped_node_test
> --
>
> Key: CASSANDRA-12415
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12415
> Project: Cassandra
>  Issue Type: Test
>Reporter: Philip Thompson
>Assignee: DS Test Eng
>  Labels: dtest
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.9_dtest/31/testReport/replace_address_test/TestReplaceAddress/replace_stopped_node_test
> Node4 just doesn't start up in time. Maybe bump up the timeout, or move to 
> large test?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12415) dtest failure in replace_address_test.TestReplaceAddress.replace_stopped_node_test

[Jim Witschey (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415434#comment-15415434
 ] 

Jim Witschey commented on CASSANDRA-12415:
--

+1 to moving to larger instances. 

> dtest failure in 
> replace_address_test.TestReplaceAddress.replace_stopped_node_test
> --
>
> Key: CASSANDRA-12415
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12415
> Project: Cassandra
>  Issue Type: Test
>Reporter: Philip Thompson
>Assignee: DS Test Eng
>  Labels: dtest
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.9_dtest/31/testReport/replace_address_test/TestReplaceAddress/replace_stopped_node_test
> Node4 just doesn't start up in time. Maybe bump up the timeout, or move to 
> large test?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)