[jira] [Commented] (CASSANDRA-12450) CQLSSTableWriter does not allow Update statement
[ https://issues.apache.org/jira/browse/CASSANDRA-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482991#comment-15482991 ] Alex Petrov commented on CASSANDRA-12450: - Looks like after [CASSANDRA-11844], there's a call to {{Keyspace.openWithoutSSTables(keyspace);}}, which calls {{Keyspace.open}} internally, which requires some initialisation. I'll be working on this. > CQLSSTableWriter does not allow Update statement > > > Key: CASSANDRA-12450 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12450 > Project: Cassandra > Issue Type: Bug > Components: Streaming and Messaging >Reporter: Kuku1 >Assignee: Alex Petrov > > CQLSSTableWriter throws Exception when trying to use Update statement. > Has been working fine in previous versions for me. > Code: > {code} > public static void main(String[] args) throws IOException { > final String KS = "test"; > final String TABLE = "data"; > final String schema = "CREATE TABLE " + KS + "." + TABLE > + "(k text, c1 text, c2 text, c3 text, v text, > primary key(k, c1,c2,c3))"; > final String query = "UPDATE " + KS + "." + TABLE + " SET v = ? > WHERE k = ? and c1 = ? and c2 = ? and c3 = ?"; > File dataDir = new File(...); > CQLSSTableWriter writer = > CQLSSTableWriter.builder().inDirectory(dataDir).forTable(schema).using(query).build(); > //Exception here (see below) > HashMaprow = new HashMap<>(); > row.put("k", "a"); > row.put("c1", "a"); > row.put("c2", "a"); > row.put("c3", "a"); > row.put("v", "v"); > writer.addRow(row); > writer.close(); > } > {code} > Exception: > {code} > 14:51:00.461 [main] INFO o.a.cassandra.cql3.QueryProcessor - Initialized > prepar > ed statement caches with 0 MB (native) and 0 MB (Thrift) > Exception in thread "main" java.lang.IllegalArgumentException: Invalid query, > mu > st be a INSERT statement but was: class > org.apache.cassandra.cql3.statements.Upd > ateStatement$ParsedUpdate > at > org.apache.cassandra.io.sstable.CQLSSTableWriter.parseStatement(CQLSS > TableWriter.java:589) > at > org.apache.cassandra.io.sstable.CQLSSTableWriter.access$000(CQLSSTabl > eWriter.java:102) > at > org.apache.cassandra.io.sstable.CQLSSTableWriter$Builder.using(CQLSST > ableWriter.java:445) > at CassandraJsonImporter.main(Cassand > raJsonImporter.java:66) > {code} > I'm currently testing it with 3.7 version, my POM looks like this: > {code} > > org.apache.cassandra > cassandra-all > 3.7 > > > org.apache.cassandra > cassandra-clientutil > 3.7 > > > com.datastax.cassandra > cassandra-driver-core > 3.0.0 > > {code} > It has been working with 3.0.8 versions in the POM, but that version is > somehow not including the UDT support? > I want to use UPDATE instead of INSERT because I need to append data to lists > and do not want to overwrite existing data in the lists. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12516) Interned column identifiers can be overridden incorrectly
[ https://issues.apache.org/jira/browse/CASSANDRA-12516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-12516: -- Reviewer: Aleksey Yeschenko > Interned column identifiers can be overridden incorrectly > - > > Key: CASSANDRA-12516 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12516 > Project: Cassandra > Issue Type: Bug >Reporter: Aleksey Yeschenko >Assignee: Stefania > Fix For: 3.0.x, 3.x > > > As discovered by [~Stefania] in CASSANDRA-12423, our use of > {{ColumnIdentifier.internedInstances}} to map byte buffer column names to > column identifiers is incorrect. It's possible for two non-equal > {{ColumnIdentifier}} instances to have the same {{ByteBuffer}} as raw name, > and yet different text representations, due to different column name types, > leading to hard to debug correctness issues. > Should either amend the map to have the type as part of the key, or limit the > use of that map. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12516) Interned column identifiers can be overridden incorrectly
[ https://issues.apache.org/jira/browse/CASSANDRA-12516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482775#comment-15482775 ] Stefania commented on CASSANDRA-12516: -- Patch here, CI still pending: ||3.0||trunk|| |[patch|https://github.com/stef1927/cassandra/commits/12516-3.0]|[patch|https://github.com/stef1927/cassandra/commits/12516]| |[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-testall/]| |[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-dtest/]| > Interned column identifiers can be overridden incorrectly > - > > Key: CASSANDRA-12516 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12516 > Project: Cassandra > Issue Type: Bug >Reporter: Aleksey Yeschenko >Assignee: Stefania > Fix For: 3.0.x, 3.x > > > As discovered by [~Stefania] in CASSANDRA-12423, our use of > {{ColumnIdentifier.internedInstances}} to map byte buffer column names to > column identifiers is incorrect. It's possible for two non-equal > {{ColumnIdentifier}} instances to have the same {{ByteBuffer}} as raw name, > and yet different text representations, due to different column name types, > leading to hard to debug correctness issues. > Should either amend the map to have the type as part of the key, or limit the > use of that map. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12516) Interned column identifiers can be overridden incorrectly
[ https://issues.apache.org/jira/browse/CASSANDRA-12516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefania updated CASSANDRA-12516: - Status: Patch Available (was: In Progress) > Interned column identifiers can be overridden incorrectly > - > > Key: CASSANDRA-12516 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12516 > Project: Cassandra > Issue Type: Bug >Reporter: Aleksey Yeschenko >Assignee: Stefania > Fix For: 3.0.x, 3.x > > > As discovered by [~Stefania] in CASSANDRA-12423, our use of > {{ColumnIdentifier.internedInstances}} to map byte buffer column names to > column identifiers is incorrect. It's possible for two non-equal > {{ColumnIdentifier}} instances to have the same {{ByteBuffer}} as raw name, > and yet different text representations, due to different column name types, > leading to hard to debug correctness issues. > Should either amend the map to have the type as part of the key, or limit the > use of that map. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12457) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_2_2_x.bug_5732_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefania updated CASSANDRA-12457: - Component/s: Lifecycle > dtest failure in > upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_2_2_x.bug_5732_test > > > Key: CASSANDRA-12457 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12457 > Project: Cassandra > Issue Type: Bug > Components: Lifecycle >Reporter: Craig Kodman >Assignee: Stefania > Labels: dtest > Fix For: 2.2.x, 3.0.x, 3.x > > Attachments: 12457_2.1_logs_with_allocation_stacks.tar.gz, > 12457_2.2_logs_with_allocation_stacks_1.tar.gz, > 12457_2.2_logs_with_allocation_stacks_2.tar.gz, > 12457_2.2_logs_with_allocation_stacks_3.tar.gz, > 12457_2.2_logs_with_allocation_stacks_4.tar.gz, node1.log, node1_debug.log, > node1_gc.log, node2.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.2_dtest_upgrade/16/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_2_2_x/bug_5732_test > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 358, in run > self.tearDown() > File "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_base.py", line > 216, in tearDown > super(UpgradeTester, self).tearDown() > File "/home/automaton/cassandra-dtest/dtest.py", line 666, in tearDown > raise AssertionError('Unexpected error in log, see stdout') > "Unexpected error in log, see stdout\n >> begin captured > logging << \ndtest: DEBUG: Upgrade test beginning, > setting CASSANDRA_VERSION to 2.1.15, and jdk to 8. (Prior values will be > restored after test).\ndtest: DEBUG: cluster ccm directory: > /mnt/tmp/dtest-D8UF3i\ndtest: DEBUG: Done setting configuration options:\n{ > 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': > 5,\n'range_request_timeout_in_ms': 1,\n > 'read_request_timeout_in_ms': 1,\n'request_timeout_in_ms': 1,\n > 'truncate_request_timeout_in_ms': 1,\n'write_request_timeout_in_ms': > 1}\ndtest: DEBUG: [[Row(table_name=u'ks', index_name=u'test.testindex')], > [Row(table_name=u'ks', index_name=u'test.testindex')]]\ndtest: DEBUG: > upgrading node1 to git:91f7387e1f785b18321777311a5c3416af0663c2\nccm: INFO: > Fetching Cassandra updates...\ndtest: DEBUG: Querying upgraded node\ndtest: > DEBUG: Querying old node\ndtest: DEBUG: removing ccm cluster test at: > /mnt/tmp/dtest-D8UF3i\ndtest: DEBUG: clearing ssl stores from > [/mnt/tmp/dtest-D8UF3i] directory\n- >> end captured > logging << -" > {code} > {code} > Standard Output > http://git-wip-us.apache.org/repos/asf/cassandra.git > git:91f7387e1f785b18321777311a5c3416af0663c2 > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,581 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@73deb57f) to class > org.apache.cassandra.io.sstable.SSTableReader$DescriptorTypeTidy@2098812276:/mnt/tmp/dtest-D8UF3i/test/node1/data1/system/schema_columns-296e9c049bec3085827dc17d3df2122a/system-schema_columns-ka-4 > was not released before the reference was garbage collected > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,581 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@7926de0f) to class > org.apache.cassandra.utils.concurrent.WrappedSharedCloseable$1@1009016655:[[OffHeapBitSet]] > was not released before the reference was garbage collected > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,581 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@3a5760f9) to class > org.apache.cassandra.io.util.MmappedSegmentedFile$Cleanup@223486002:/mnt/tmp/dtest-D8UF3i/test/node1/data0/system/schema_columns-296e9c049bec3085827dc17d3df2122a/system-schema_columns-ka-3-Index.db > was not released before the reference was garbage collected > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,582 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@42cb4131) to class > org.apache.cassandra.utils.concurrent.WrappedSharedCloseable$1@1544265728:[Memory@[0..4), > Memory@[0..a)] was not released before the reference was garbage collected > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,582 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@5dda43d0) to class >
[jira] [Updated] (CASSANDRA-12457) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_2_2_x.bug_5732_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefania updated CASSANDRA-12457: - Fix Version/s: 3.x 3.0.x Status: Patch Available (was: In Progress) > dtest failure in > upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_2_2_x.bug_5732_test > > > Key: CASSANDRA-12457 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12457 > Project: Cassandra > Issue Type: Bug > Components: Lifecycle >Reporter: Craig Kodman >Assignee: Stefania > Labels: dtest > Fix For: 2.2.x, 3.0.x, 3.x > > Attachments: 12457_2.1_logs_with_allocation_stacks.tar.gz, > 12457_2.2_logs_with_allocation_stacks_1.tar.gz, > 12457_2.2_logs_with_allocation_stacks_2.tar.gz, > 12457_2.2_logs_with_allocation_stacks_3.tar.gz, > 12457_2.2_logs_with_allocation_stacks_4.tar.gz, node1.log, node1_debug.log, > node1_gc.log, node2.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.2_dtest_upgrade/16/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_2_2_x/bug_5732_test > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 358, in run > self.tearDown() > File "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_base.py", line > 216, in tearDown > super(UpgradeTester, self).tearDown() > File "/home/automaton/cassandra-dtest/dtest.py", line 666, in tearDown > raise AssertionError('Unexpected error in log, see stdout') > "Unexpected error in log, see stdout\n >> begin captured > logging << \ndtest: DEBUG: Upgrade test beginning, > setting CASSANDRA_VERSION to 2.1.15, and jdk to 8. (Prior values will be > restored after test).\ndtest: DEBUG: cluster ccm directory: > /mnt/tmp/dtest-D8UF3i\ndtest: DEBUG: Done setting configuration options:\n{ > 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': > 5,\n'range_request_timeout_in_ms': 1,\n > 'read_request_timeout_in_ms': 1,\n'request_timeout_in_ms': 1,\n > 'truncate_request_timeout_in_ms': 1,\n'write_request_timeout_in_ms': > 1}\ndtest: DEBUG: [[Row(table_name=u'ks', index_name=u'test.testindex')], > [Row(table_name=u'ks', index_name=u'test.testindex')]]\ndtest: DEBUG: > upgrading node1 to git:91f7387e1f785b18321777311a5c3416af0663c2\nccm: INFO: > Fetching Cassandra updates...\ndtest: DEBUG: Querying upgraded node\ndtest: > DEBUG: Querying old node\ndtest: DEBUG: removing ccm cluster test at: > /mnt/tmp/dtest-D8UF3i\ndtest: DEBUG: clearing ssl stores from > [/mnt/tmp/dtest-D8UF3i] directory\n- >> end captured > logging << -" > {code} > {code} > Standard Output > http://git-wip-us.apache.org/repos/asf/cassandra.git > git:91f7387e1f785b18321777311a5c3416af0663c2 > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,581 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@73deb57f) to class > org.apache.cassandra.io.sstable.SSTableReader$DescriptorTypeTidy@2098812276:/mnt/tmp/dtest-D8UF3i/test/node1/data1/system/schema_columns-296e9c049bec3085827dc17d3df2122a/system-schema_columns-ka-4 > was not released before the reference was garbage collected > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,581 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@7926de0f) to class > org.apache.cassandra.utils.concurrent.WrappedSharedCloseable$1@1009016655:[[OffHeapBitSet]] > was not released before the reference was garbage collected > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,581 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@3a5760f9) to class > org.apache.cassandra.io.util.MmappedSegmentedFile$Cleanup@223486002:/mnt/tmp/dtest-D8UF3i/test/node1/data0/system/schema_columns-296e9c049bec3085827dc17d3df2122a/system-schema_columns-ka-3-Index.db > was not released before the reference was garbage collected > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,582 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@42cb4131) to class > org.apache.cassandra.utils.concurrent.WrappedSharedCloseable$1@1544265728:[Memory@[0..4), > Memory@[0..a)] was not released before the reference was garbage collected > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,582 Ref.java:199 - LEAK > DETECTED: a reference
[jira] [Commented] (CASSANDRA-12457) dtest failure in upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_2_2_x.bug_5732_test
[ https://issues.apache.org/jira/browse/CASSANDRA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482752#comment-15482752 ] Stefania commented on CASSANDRA-12457: -- Multiplex run was fine, ticket is ready for review. ||2.2||3.0||trunk|| |[patch|https://github.com/stef1927/cassandra/commits/12457-2.2]|[patch|https://github.com/stef1927/cassandra/commits/12457-3.0]|[patch|https://github.com/stef1927/cassandra/commits/12457]| |[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12457-2.2-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12457-3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12457-testall/]| |[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12457-2.2-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12457-3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12457-dtest/]| For 2.1 we can try a scaled down version of the patch where we just remove {{nonPeriodicTasks.setExecuteExistingDelayedTasksAfterShutdownPolicy}} or we can change the upgrade tests to ignore leaks in the 2.1 logs, I would rather not apply the full patch to 2.1. > dtest failure in > upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_2_2_x.bug_5732_test > > > Key: CASSANDRA-12457 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12457 > Project: Cassandra > Issue Type: Bug >Reporter: Craig Kodman >Assignee: Stefania > Labels: dtest > Fix For: 2.2.x > > Attachments: 12457_2.1_logs_with_allocation_stacks.tar.gz, > 12457_2.2_logs_with_allocation_stacks_1.tar.gz, > 12457_2.2_logs_with_allocation_stacks_2.tar.gz, > 12457_2.2_logs_with_allocation_stacks_3.tar.gz, > 12457_2.2_logs_with_allocation_stacks_4.tar.gz, node1.log, node1_debug.log, > node1_gc.log, node2.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.2_dtest_upgrade/16/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_current_2_1_x_To_indev_2_2_x/bug_5732_test > {code} > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 358, in run > self.tearDown() > File "/home/automaton/cassandra-dtest/upgrade_tests/upgrade_base.py", line > 216, in tearDown > super(UpgradeTester, self).tearDown() > File "/home/automaton/cassandra-dtest/dtest.py", line 666, in tearDown > raise AssertionError('Unexpected error in log, see stdout') > "Unexpected error in log, see stdout\n >> begin captured > logging << \ndtest: DEBUG: Upgrade test beginning, > setting CASSANDRA_VERSION to 2.1.15, and jdk to 8. (Prior values will be > restored after test).\ndtest: DEBUG: cluster ccm directory: > /mnt/tmp/dtest-D8UF3i\ndtest: DEBUG: Done setting configuration options:\n{ > 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': > 5,\n'range_request_timeout_in_ms': 1,\n > 'read_request_timeout_in_ms': 1,\n'request_timeout_in_ms': 1,\n > 'truncate_request_timeout_in_ms': 1,\n'write_request_timeout_in_ms': > 1}\ndtest: DEBUG: [[Row(table_name=u'ks', index_name=u'test.testindex')], > [Row(table_name=u'ks', index_name=u'test.testindex')]]\ndtest: DEBUG: > upgrading node1 to git:91f7387e1f785b18321777311a5c3416af0663c2\nccm: INFO: > Fetching Cassandra updates...\ndtest: DEBUG: Querying upgraded node\ndtest: > DEBUG: Querying old node\ndtest: DEBUG: removing ccm cluster test at: > /mnt/tmp/dtest-D8UF3i\ndtest: DEBUG: clearing ssl stores from > [/mnt/tmp/dtest-D8UF3i] directory\n- >> end captured > logging << -" > {code} > {code} > Standard Output > http://git-wip-us.apache.org/repos/asf/cassandra.git > git:91f7387e1f785b18321777311a5c3416af0663c2 > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,581 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@73deb57f) to class > org.apache.cassandra.io.sstable.SSTableReader$DescriptorTypeTidy@2098812276:/mnt/tmp/dtest-D8UF3i/test/node1/data1/system/schema_columns-296e9c049bec3085827dc17d3df2122a/system-schema_columns-ka-4 > was not released before the reference was garbage collected > Unexpected error in node1 log, error: > ERROR [Reference-Reaper:1] 2016-08-13 01:34:34,581 Ref.java:199 - LEAK > DETECTED: a reference > (org.apache.cassandra.utils.concurrent.Ref$State@7926de0f) to class > org.apache.cassandra.utils.concurrent.WrappedSharedCloseable$1@1009016655:[[OffHeapBitSet]] > was not released before the reference was garbage collected > Unexpected error in node1 log,
[jira] [Commented] (CASSANDRA-12423) Cells missing from compact storage table after upgrading from 2.1.9 to 3.7
[ https://issues.apache.org/jira/browse/CASSANDRA-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482685#comment-15482685 ] Stefania commented on CASSANDRA-12423: -- utests for 3.0 are OK now: 1 timeout and 1 known failure. dtest for 3.0 completed without failures but on trunk the build is still timing out on {{tar czvf jenkins-stef1927-12423-b-dtest-7_logs.tar.gz \-\-ignore-failed-read logs/ /mnt/tmp/dtest-*/*/node*/logs}}. I've recreated the branch to pick up the latest fixes for the CI build and relaunched. > Cells missing from compact storage table after upgrading from 2.1.9 to 3.7 > -- > > Key: CASSANDRA-12423 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12423 > Project: Cassandra > Issue Type: Bug >Reporter: Tomasz Grabiec >Assignee: Stefania > Attachments: 12423.tar.gz > > > Schema: > {code} > create table ks1.test ( id int, c1 text, c2 text, v int, primary key (id, c1, > c2)) with compact storage and compression = {'sstable_compression': ''}; > {code} > sstable2json before upgrading: > {code} > [ > {"key": "1", > "cells": [["","0",1470761440040513], >["a","asd",2470761440040513,"t",1470764842], >["asd:","0",1470761451368658], >["asd:asd","0",1470761449416613]]} > ] > {code} > Query result with 2.1.9: > {code} > cqlsh> select * from ks1.test; > id | c1 | c2 | v > +-+--+--- > 1 | | null | 0 > 1 | asd | | 0 > 1 | asd | asd | 0 > (3 rows) > {code} > Query result with 3.7: > {code} > cqlsh> select * from ks1.test; > id | 6331 | 6332 | v > +--+--+--- > 1 | | null | 0 > (1 rows) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12628) sstabledump should use AbstractType.toJSONString() instead of getString()
[ https://issues.apache.org/jira/browse/CASSANDRA-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482396#comment-15482396 ] Andy Tolbert commented on CASSANDRA-12628: -- [wip branch|https://github.com/tolbertam/cassandra/tree/CASSANDRA-12628], needs a bit of testing so will hold off on attaching a patch until comfortable. Also noticed that unfrozen UDTs don't work either, added support for that as well. > sstabledump should use AbstractType.toJSONString() instead of getString() > - > > Key: CASSANDRA-12628 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12628 > Project: Cassandra > Issue Type: Bug >Reporter: Andy Tolbert >Assignee: Andy Tolbert >Priority: Minor > > Since sstabledump outputs json, it makes sense for it to use > {{AbstractType.toJSONString()}} instead of {{getString()}} as discussed in > [CASSANDRA-12594]: > {quote} > sstabledump returns JSON and we now have a proper toJSONString() method in > AbstractType that handles that properly so it would make sense to simply use > that for everything in sstabledump in my opinion. > {quote} > Doing this should also fix [CASSANDRA-12594]. There may be a few small > differences in the output format, which I will attempt to document here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12594) sstabledump fails on frozen collection cells
[ https://issues.apache.org/jira/browse/CASSANDRA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Tolbert updated CASSANDRA-12594: - Fix Version/s: (was: 3.0.9) (was: 3.9) > sstabledump fails on frozen collection cells > > > Key: CASSANDRA-12594 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12594 > Project: Cassandra > Issue Type: Bug >Reporter: Andy Tolbert >Assignee: Andy Tolbert >Priority: Minor > Attachments: CASSANDRA-12594-3.0.txt, CASSANDRA-12594-3.0_2.txt > > > sstabledump throws an exception when attempting to parse a cell that is a > frozen collection, i.e.: > {noformat} > [ > { > "partition" : { > "key" : [ "0" ], > "position" : 0 > }, > "rows" : [ > { > "type" : "row", > "position" : 18, > "liveness_info" : { "tstamp" : "2016-09-01T22:06:45.670810Z" }, > "cells" : [ > { "name" : "m", "value" } > ] } > ] } > ]Exception in thread "main" java.lang.IllegalArgumentException > at java.nio.Buffer.limit(Buffer.java:275) > at > org.apache.cassandra.utils.ByteBufferUtil.readBytes(ByteBufferUtil.java:613) > at > org.apache.cassandra.db.marshal.TupleType.getString(TupleType.java:211) > at > org.apache.cassandra.tools.JsonTransformer.serializeCell(JsonTransformer.java:441) > at > org.apache.cassandra.tools.JsonTransformer.serializeColumnData(JsonTransformer.java:375) > at > org.apache.cassandra.tools.JsonTransformer.serializeRow(JsonTransformer.java:279) > at > org.apache.cassandra.tools.JsonTransformer.serializePartition(JsonTransformer.java:214) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) > at > java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) > at java.util.Iterator.forEachRemaining(Iterator.java:116) > at > java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) > at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481) > at > java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) > at > java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) > at > java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) > at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at > java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) > at > org.apache.cassandra.tools.JsonTransformer.toJson(JsonTransformer.java:102) > at org.apache.cassandra.tools.SSTableExport.main(SSTableExport.java:242) > {noformat} > This is because the code doesn't consider that the cell may be a frozen > collection, and attempts to get the string representation using the value > type which doesn't work. > Example data: > {noformat} > CREATE KEYSPACE simple WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'}; > CREATE TABLE simple.unfrozen_map ( > k int PRIMARY KEY, > m map>> > ); > CREATE TABLE simple.frozen_map ( > k int PRIMARY KEY, > m frozen
[jira] [Created] (CASSANDRA-12628) sstabledump should use AbstractType.toJSONString() instead of getString()
Andy Tolbert created CASSANDRA-12628: Summary: sstabledump should use AbstractType.toJSONString() instead of getString() Key: CASSANDRA-12628 URL: https://issues.apache.org/jira/browse/CASSANDRA-12628 Project: Cassandra Issue Type: Bug Reporter: Andy Tolbert Assignee: Andy Tolbert Priority: Minor Since sstabledump outputs json, it makes sense for it to use {{AbstractType.toJSONString()}} instead of {{getString()}} as discussed in [CASSANDRA-12594]: {quote} sstabledump returns JSON and we now have a proper toJSONString() method in AbstractType that handles that properly so it would make sense to simply use that for everything in sstabledump in my opinion. {quote} Doing this should also fix [CASSANDRA-12594]. There may be a few small differences in the output format, which I will attempt to document here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11465) dtest failure in cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test
[ https://issues.apache.org/jira/browse/CASSANDRA-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481241#comment-15481241 ] Stefania commented on CASSANDRA-11465: -- Will do, thanks! :) > dtest failure in cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test > -- > > Key: CASSANDRA-11465 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11465 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: Philip Thompson >Assignee: Stefania > Labels: dtest > Fix For: 2.2.8, 3.0.9, 3.8 > > > Failing on the following assert, on trunk only: > {{self.assertEqual(len(errs[0]), 1)}} > Is not failing consistently. > example failure: > http://cassci.datastax.com/job/trunk_dtest/1087/testReport/cql_tracing_test/TestCqlTracing/tracing_unknown_impl_test > Failed on CassCI build trunk_dtest #1087 -- This message was sent by Atlassian JIRA (v6.3.4#6332)