[jira] [Updated] (CASSANDRA-14133) Log file names of files streamed in to a node
[ https://issues.apache.org/jira/browse/CASSANDRA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-14133: Resolution: Fixed Fix Version/s: (was: 3.11.x) (was: 4.x) (was: 3.0.x) 4.0 3.11.2 3.0.16 Status: Resolved (was: Patch Available) committed as {{8b0fe8900288bcb5718530e04ce3f4b453ce1b50}}, thanks! > Log file names of files streamed in to a node > - > > Key: CASSANDRA-14133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14133 > Project: Cassandra > Issue Type: Improvement >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson > Fix For: 3.0.16, 3.11.2, 4.0 > > > We should log the file names of sstables streamed in to a node -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[6/6] cassandra git commit: Merge branch 'cassandra-3.11' into trunk
Merge branch 'cassandra-3.11' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/d52326af Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/d52326af Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/d52326af Branch: refs/heads/trunk Commit: d52326af623f371f820c20269bc1113db443cf38 Parents: 882c282 b28fc1b Author: Marcus ErikssonAuthored: Fri Dec 22 08:53:03 2017 +0100 Committer: Marcus Eriksson Committed: Fri Dec 22 08:53:03 2017 +0100 -- src/java/org/apache/cassandra/streaming/StreamReceiveTask.java | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/d52326af/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java -- diff --cc src/java/org/apache/cassandra/streaming/StreamReceiveTask.java index 988bc9e,f3966a7..b823311 --- a/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java +++ b/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java @@@ -233,11 -210,13 +233,12 @@@ public class StreamReceiveTask extends { task.finishTransaction(); +// add sstables (this will build secondary indexes too, see CASSANDRA-10130) + logger.debug("[Stream #{}] Received {} sstables from {} ({})", task.session.planId(), readers.size(), task.session.peer, readers); -// add sstables and build secondary indexes cfs.addSSTables(readers); -cfs.indexManager.buildAllIndexesBlocking(readers); //invalidate row and counter cache -if (cfs.isRowCacheEnabled() || cfs.metadata.isCounter()) +if (cfs.isRowCacheEnabled() || cfs.metadata().isCounter()) { List boundsToInvalidate = new ArrayList<>(readers.size()); readers.forEach(sstable -> boundsToInvalidate.add(new Bounds(sstable.first.getToken(), sstable.last.getToken(; - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[4/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11
Merge branch 'cassandra-3.0' into cassandra-3.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b28fc1bf Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b28fc1bf Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b28fc1bf Branch: refs/heads/trunk Commit: b28fc1bff35800450c03343b85b8bc38b645f20d Parents: adc32ac 5b4485b Author: Marcus ErikssonAuthored: Fri Dec 22 07:55:59 2017 +0100 Committer: Marcus Eriksson Committed: Fri Dec 22 07:55:59 2017 +0100 -- src/java/org/apache/cassandra/streaming/StreamReceiveTask.java | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/b28fc1bf/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[3/6] cassandra git commit: Log file names of sstables streamed in to a node
Log file names of sstables streamed in to a node Patch by marcuse; reviewed by Jeff Jirsa for CASSANDRA-14133 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/5b4485b2 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/5b4485b2 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/5b4485b2 Branch: refs/heads/trunk Commit: 5b4485b29ecf36b750a75435580d82e749a825e8 Parents: 0521f8d Author: Marcus ErikssonAuthored: Thu Dec 21 09:19:02 2017 +0100 Committer: Marcus Eriksson Committed: Fri Dec 22 07:55:12 2017 +0100 -- src/java/org/apache/cassandra/streaming/StreamReceiveTask.java | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/5b4485b2/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java -- diff --git a/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java b/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java index b6b8387..9e65d34 100644 --- a/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java +++ b/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java @@ -196,6 +196,7 @@ public class StreamReceiveTask extends StreamTask { task.finishTransaction(); +logger.debug("[Stream #{}] Received {} sstables from {} ({})", task.session.planId(), readers.size(), task.session.peer, readers); // add sstables and build secondary indexes cfs.addSSTables(readers); cfs.indexManager.buildAllIndexesBlocking(readers); - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[5/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11
Merge branch 'cassandra-3.0' into cassandra-3.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b28fc1bf Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b28fc1bf Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b28fc1bf Branch: refs/heads/cassandra-3.11 Commit: b28fc1bff35800450c03343b85b8bc38b645f20d Parents: adc32ac 5b4485b Author: Marcus ErikssonAuthored: Fri Dec 22 07:55:59 2017 +0100 Committer: Marcus Eriksson Committed: Fri Dec 22 07:55:59 2017 +0100 -- src/java/org/apache/cassandra/streaming/StreamReceiveTask.java | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/b28fc1bf/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[2/6] cassandra git commit: Log file names of sstables streamed in to a node
Log file names of sstables streamed in to a node Patch by marcuse; reviewed by Jeff Jirsa for CASSANDRA-14133 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/5b4485b2 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/5b4485b2 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/5b4485b2 Branch: refs/heads/cassandra-3.11 Commit: 5b4485b29ecf36b750a75435580d82e749a825e8 Parents: 0521f8d Author: Marcus ErikssonAuthored: Thu Dec 21 09:19:02 2017 +0100 Committer: Marcus Eriksson Committed: Fri Dec 22 07:55:12 2017 +0100 -- src/java/org/apache/cassandra/streaming/StreamReceiveTask.java | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/5b4485b2/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java -- diff --git a/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java b/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java index b6b8387..9e65d34 100644 --- a/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java +++ b/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java @@ -196,6 +196,7 @@ public class StreamReceiveTask extends StreamTask { task.finishTransaction(); +logger.debug("[Stream #{}] Received {} sstables from {} ({})", task.session.planId(), readers.size(), task.session.peer, readers); // add sstables and build secondary indexes cfs.addSSTables(readers); cfs.indexManager.buildAllIndexesBlocking(readers); - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[1/6] cassandra git commit: Log file names of sstables streamed in to a node
Repository: cassandra Updated Branches: refs/heads/cassandra-3.0 0521f8dc5 -> 5b4485b29 refs/heads/cassandra-3.11 adc32ac83 -> b28fc1bff refs/heads/trunk 882c28230 -> d52326af6 Log file names of sstables streamed in to a node Patch by marcuse; reviewed by Jeff Jirsa for CASSANDRA-14133 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/5b4485b2 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/5b4485b2 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/5b4485b2 Branch: refs/heads/cassandra-3.0 Commit: 5b4485b29ecf36b750a75435580d82e749a825e8 Parents: 0521f8d Author: Marcus ErikssonAuthored: Thu Dec 21 09:19:02 2017 +0100 Committer: Marcus Eriksson Committed: Fri Dec 22 07:55:12 2017 +0100 -- src/java/org/apache/cassandra/streaming/StreamReceiveTask.java | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/5b4485b2/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java -- diff --git a/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java b/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java index b6b8387..9e65d34 100644 --- a/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java +++ b/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java @@ -196,6 +196,7 @@ public class StreamReceiveTask extends StreamTask { task.finishTransaction(); +logger.debug("[Stream #{}] Received {} sstables from {} ({})", task.session.planId(), readers.size(), task.session.peer, readers); // add sstables and build secondary indexes cfs.addSSTables(readers); cfs.indexManager.buildAllIndexesBlocking(readers); - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14099) LCS ordering of sstables by timestamp is inverted
[ https://issues.apache.org/jira/browse/CASSANDRA-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa reassigned CASSANDRA-14099: -- Assignee: Vincent White > LCS ordering of sstables by timestamp is inverted > - > > Key: CASSANDRA-14099 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14099 > Project: Cassandra > Issue Type: Bug > Components: Compaction >Reporter: Jeff Jirsa >Assignee: Vincent White >Priority: Minor > Fix For: 3.0.x, 3.11.x, 4.x > > > In CASSANDRA-14010 we discovered that CASSANDRA-13776 broke sstable ordering > by timestamp (inverted it accidentally). Investigating that revealed that the > comparator was expecting newest-to-oldest for read command, but LCS expects > oldest-to-newest. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14056) Many dtests fail with ConfigurationException: offheap_objects are not available in 3.0 when OFFHEAP_MEMTABLES="true"
[ https://issues.apache.org/jira/browse/CASSANDRA-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Lourie updated CASSANDRA-14056: Reproduced In: 3.11.1 Status: Patch Available (was: In Progress) > Many dtests fail with ConfigurationException: offheap_objects are not > available in 3.0 when OFFHEAP_MEMTABLES="true" > > > Key: CASSANDRA-14056 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14056 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Michael Kjellman >Assignee: Alex Lourie > > Tons of dtests are running when they shouldn't as it looks like the path is > no longer supported.. we need to add a bunch of logic that's missing to fully > support running dtests with off-heap memtables enabled (via the > OFFHEAP_MEMTABLES="true" environment variable) > {code}[node2 ERROR] java.lang.ExceptionInInitializerError > at > org.apache.cassandra.db.ColumnFamilyStore.(ColumnFamilyStore.java:394) > at > org.apache.cassandra.db.ColumnFamilyStore.(ColumnFamilyStore.java:361) > at > org.apache.cassandra.db.ColumnFamilyStore.createColumnFamilyStore(ColumnFamilyStore.java:577) > at > org.apache.cassandra.db.ColumnFamilyStore.createColumnFamilyStore(ColumnFamilyStore.java:554) > at org.apache.cassandra.db.Keyspace.initCf(Keyspace.java:368) > at org.apache.cassandra.db.Keyspace.(Keyspace.java:305) > at org.apache.cassandra.db.Keyspace.open(Keyspace.java:129) > at org.apache.cassandra.db.Keyspace.open(Keyspace.java:106) > at > org.apache.cassandra.db.SystemKeyspace.checkHealth(SystemKeyspace.java:887) > at > org.apache.cassandra.service.StartupChecks$9.execute(StartupChecks.java:354) > at > org.apache.cassandra.service.StartupChecks.verify(StartupChecks.java:110) > at > org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:179) > at > org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569) > at > org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:697) > Caused by: org.apache.cassandra.exceptions.ConfigurationException: > offheap_objects are not available in 3.0. They will be re-introduced in a > future release, see https://issues.apache.org/jira/browse/CASSANDRA-9472 for > details > at > org.apache.cassandra.config.DatabaseDescriptor.getMemtableAllocatorPool(DatabaseDescriptor.java:1907) > at org.apache.cassandra.db.Memtable.(Memtable.java:65) > ... 14 more > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14126) don't work udf javascripts
[ https://issues.apache.org/jira/browse/CASSANDRA-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Lourie updated CASSANDRA-14126: Status: Patch Available (was: In Progress) > don't work udf javascripts > -- > > Key: CASSANDRA-14126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14126 > Project: Cassandra > Issue Type: Bug > Components: CQL >Reporter: Denis Pershin >Assignee: Alex Lourie >Priority: Minor > Labels: security > Fix For: 3.11.x > > Attachments: cassandra-01.yaml, cassandra-02.yaml, cassandra-03.yaml > > > * config: > {code} > enable_user_defined_functions: true > enable_scripted_user_defined_functions: true > {code} > * create keyspace: > {code} > CREATE KEYSPACE testkeyspace WITH REPLICATION = { 'class' : 'SimpleStrategy', > 'replication_factor' : 1 }; > {code} > * in testkeyspace create function: > {code} > CREATE OR REPLACE FUNCTION first_int(input set) RETURNS NULL ON NULL > INPUT RETURNS int LANGUAGE javascript AS '(function(){var result = 2;return > result;})();'; > {code} > * create table and insert: > {code} > create table A (id int primary key, val set); > insert into A (id, val) values (1, {3,5,7,1}); > {code} > * select: > {code} > select first_int(val) from A where id = 1; > Traceback (most recent call last): > File "/usr/bin/cqlsh.py", line 1044, in perform_simple_statement > result = future.result() > File > "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/cluster.py", > line 3826, in result > raise self._final_exception > FunctionFailure: Error from server: code=1400 [User Defined Function failure] > message="execution of 'testkeyspace.first_int[set]' failed: > java.security.AccessControlException: access denied: > ("java.lang.RuntimePermission" "accessClassInPackage.java.io")" > {code} > raw log: > {code} > root@001b19bd3cc6:/# cqlsh > Connected to Test Cluster at 127.0.0.1:9042. > [cqlsh 5.0.1 | Cassandra 3.11.1 | CQL spec 3.4.4 | Native protocol v4] > Use HELP for help. > cqlsh> CREATE KEYSPACE testkeyspace WITH REPLICATION = { 'class' : > 'SimpleStrategy', 'replication_factor' : 1 }; > cqlsh> USE testkeyspace ; > cqlsh:testkeyspace> CREATE OR REPLACE FUNCTION first_int(input set) > RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE javascript AS > '(function(){var result = 2;return result;})();'; > cqlsh:testkeyspace> create table A (id int primary key, val set); > cqlsh:testkeyspace> insert into A (id, val) values (1, {3,5,7,1}); > cqlsh:testkeyspace> select first_int(val) from A where id = 1; > Traceback (most recent call last): > File "/usr/bin/cqlsh.py", line 1044, in perform_simple_statement > result = future.result() > File > "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/cluster.py", > line 3826, in result > raise self._final_exception > FunctionFailure: Error from server: code=1400 [User Defined Function failure] > message="execution of 'testkeyspace.first_int[set]' failed: > java.security.AccessControlException: access denied: > ("java.lang.RuntimePermission" "accessClassInPackage.java.io")" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14126) don't work udf javascripts
[ https://issues.apache.org/jira/browse/CASSANDRA-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300902#comment-16300902 ] Alex Lourie commented on CASSANDRA-14126: - The reason it doesn't work is that creating _functions_ in JS requires a couple more packages to be added to "allowed" list in the sandbox. I've created a patch here https://github.com/apache/cassandra/compare/trunk...alourie:CASSANDRA-14126 for the trunk. It fixes the issue, but the question is whether the functions should be allowed at all. If the functions are not allowed in the javascript UFDs, then it should be clearly stated in the documentation. > don't work udf javascripts > -- > > Key: CASSANDRA-14126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14126 > Project: Cassandra > Issue Type: Bug > Components: CQL >Reporter: Denis Pershin >Assignee: Alex Lourie >Priority: Minor > Labels: security > Fix For: 3.11.x > > Attachments: cassandra-01.yaml, cassandra-02.yaml, cassandra-03.yaml > > > * config: > {code} > enable_user_defined_functions: true > enable_scripted_user_defined_functions: true > {code} > * create keyspace: > {code} > CREATE KEYSPACE testkeyspace WITH REPLICATION = { 'class' : 'SimpleStrategy', > 'replication_factor' : 1 }; > {code} > * in testkeyspace create function: > {code} > CREATE OR REPLACE FUNCTION first_int(input set) RETURNS NULL ON NULL > INPUT RETURNS int LANGUAGE javascript AS '(function(){var result = 2;return > result;})();'; > {code} > * create table and insert: > {code} > create table A (id int primary key, val set); > insert into A (id, val) values (1, {3,5,7,1}); > {code} > * select: > {code} > select first_int(val) from A where id = 1; > Traceback (most recent call last): > File "/usr/bin/cqlsh.py", line 1044, in perform_simple_statement > result = future.result() > File > "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/cluster.py", > line 3826, in result > raise self._final_exception > FunctionFailure: Error from server: code=1400 [User Defined Function failure] > message="execution of 'testkeyspace.first_int[set]' failed: > java.security.AccessControlException: access denied: > ("java.lang.RuntimePermission" "accessClassInPackage.java.io")" > {code} > raw log: > {code} > root@001b19bd3cc6:/# cqlsh > Connected to Test Cluster at 127.0.0.1:9042. > [cqlsh 5.0.1 | Cassandra 3.11.1 | CQL spec 3.4.4 | Native protocol v4] > Use HELP for help. > cqlsh> CREATE KEYSPACE testkeyspace WITH REPLICATION = { 'class' : > 'SimpleStrategy', 'replication_factor' : 1 }; > cqlsh> USE testkeyspace ; > cqlsh:testkeyspace> CREATE OR REPLACE FUNCTION first_int(input set) > RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE javascript AS > '(function(){var result = 2;return result;})();'; > cqlsh:testkeyspace> create table A (id int primary key, val set); > cqlsh:testkeyspace> insert into A (id, val) values (1, {3,5,7,1}); > cqlsh:testkeyspace> select first_int(val) from A where id = 1; > Traceback (most recent call last): > File "/usr/bin/cqlsh.py", line 1044, in perform_simple_statement > result = future.result() > File > "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/cluster.py", > line 3826, in result > raise self._final_exception > FunctionFailure: Error from server: code=1400 [User Defined Function failure] > message="execution of 'testkeyspace.first_int[set]' failed: > java.security.AccessControlException: access denied: > ("java.lang.RuntimePermission" "accessClassInPackage.java.io")" > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14133) Log file names of files streamed in to a node
[ https://issues.apache.org/jira/browse/CASSANDRA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300353#comment-16300353 ] Jeff Jirsa commented on CASSANDRA-14133: +1 > Log file names of files streamed in to a node > - > > Key: CASSANDRA-14133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14133 > Project: Cassandra > Issue Type: Improvement >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson > Fix For: 3.0.x, 3.11.x, 4.x > > > We should log the file names of sstables streamed in to a node -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13391) nodetool clearsnapshot should require --all to clear all snapshots
[ https://issues.apache.org/jira/browse/CASSANDRA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300164#comment-16300164 ] ASF GitHub Bot commented on CASSANDRA-13391: GitHub user barakm opened a pull request: https://github.com/apache/cassandra/pull/181 CASSANDRA-13391 Added --all to ClearSnapshot command Added --all to ClearSnapshot command, so entering the command without a parameter will now throw an exception instead of deleting all the snapshots. You can merge this pull request into a Git repository by running: $ git pull https://github.com/barakm/cassandra CASSANDRA-13391-clear-all-snapshots Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cassandra/pull/181.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #181 commit 1e7c4b9c0584b5f63d121a5c37e0fc1e352e6108 Author: dr3sDate: 2017-06-20T17:23:17Z Upgrade metrics to fix reconnect when reporting metrics. Closes #123 Patch by dr3s and Jeff Jirsa; Reviewed by Stefan Podkowinski for CASSANDRA-13648 commit a5dff2f79621d7527a3837c0028d2e8b61d16e42 Author: ameya Date: 2017-07-19T03:37:10Z Refactoring to specialised primitive functional interfaces in AuthCache.java Closes #131 Patch by Ameya Ketkar; Reviewed by Jeff Jirsa for CASSANDRA-13732 commit 0a9e9db99c56eb2a8779dadf1926861436ca5f6e Author: Andrés de la Peña Date: 2017-07-28T10:22:13Z Merge branch '12952-3.11' into 12952-trunk commit 0f6aeb6a59185e8ee022a5570ee8f585ec2ba21b Author: Andrés de la Peña Date: 2017-07-28T10:25:06Z Merge branch '12952-trunk' into trunk commit 9b828275288b135812a247c3f2e9da2f20547111 Author: Paulo Motta Date: 2017-07-28T20:27:18Z Merge branch 'cassandra-3.11' into trunk commit 284271670c389f2b9fd11271c33eca5bb2a228fd Author: Simon Zhou Date: 2017-03-31T03:45:03Z Introduce error metrics for repair patch by Simon Zhou; reviewed by Stefan Podkowinski for CASSANDRA-13387 commit de60cf0759e9721ddd1aab725c511a8f910cf415 Author: Jeff Jirsa Date: 2017-07-31T22:30:10Z Merge branch 'cassandra-3.11' into trunk commit fbcec0cc465dddc81134a15c42b292c35d3316b2 Author: Aleksey Yeschenko Date: 2017-08-01T14:40:23Z Merge branch 'cassandra-3.11' into trunk commit 8174fa510cd9007bba1f3726203fabf15b608d61 Author: Stefania Alborghetti Date: 2017-08-02T02:18:43Z Merge branch 'cassandra-3.11' into trunk commit 457733bd54c4a6c0ffd75aa6774c634b7623f116 Author: Stefan Podkowinski Date: 2017-08-03T10:52:41Z Merge branch 'cassandra-3.11' into trunk commit 32de990b7abf1ae54f31ba728a9860031d0f435c Author: Aleksey Yeschenko Date: 2017-08-03T13:28:52Z Merge branch 'cassandra-3.11' into trunk commit cb32807f654cc8b11868cb1ed8e17657137d7ea2 Author: Andrés de la Peña Date: 2017-08-07T19:32:18Z Merge branch 'cassandra-3.11' into trunk commit 6b302b600f327cc8d1781776423d9548658e6591 Author: Roman Pogribnyi Date: 2017-07-22T20:06:01Z Update DTest GitHub URLs - Use ASF DTest location Patch by Roman Pogribnyi; Reviewed by Jeff Jirsa for CASSANDRA-13689 commit 9e3483f844d9db6fe2a6210550622fc2cd8aef72 Author: Chris Lohfink Date: 2017-07-10T15:46:34Z Switch to client init for sstabledump Closes #130 Patch by Chris Lohfink; Reviewed by Jeremiah Jordan for CASSANDRA-13683 commit 6dfd11c30a9c85581b77c93cfcdbef37a5d497c6 Author: Chris Lohfink Date: 2017-07-22T03:04:37Z Improve sstablemetadata output Patch by Chris Lohfink; reviewed by marcuse for CASSANDRA-11483 commit cad941653b59c4609ba2900cda86dc366d3ccd38 Author: Andrés de la Peña Date: 2017-08-08T14:27:15Z Merge branch 'cassandra-3.11' into trunk commit c00206297be451077034daf318eb8912825e135a Author: Benjamin Lerer Date: 2017-08-08T15:13:18Z Merge branch cassandra-3.11 into trunk commit bcdbee5cdce6e22e6c97c5cab23fb2cf3265aa0d Author: Michael Shuler Date: 2017-08-09T20:42:01Z Enable ppc64le runtime as unsupported architecture patch by Amitkumar Ghatwal and Michael Shuler; reviewed by Jeff Jirsa for CASSANDRA-13615 commit ba87ab4e954ad2e537f6690953bd7ebaa069f5cd Author: Zhao Yang Date: 2017-07-24T10:13:14Z Explicitly use e.getMessage() for log message formatting patch by Zhao Yang; reviewed by Stefan Podkowinski for CASSANDRA-13723 commit 9c3354e3211c6a3f3982e87477e156c29cd9b7ea Author: Blake Eggleston Date:
[jira] [Created] (CASSANDRA-14134) Migrate dtests to use pytest and python3
Michael Kjellman created CASSANDRA-14134: Summary: Migrate dtests to use pytest and python3 Key: CASSANDRA-14134 URL: https://issues.apache.org/jira/browse/CASSANDRA-14134 Project: Cassandra Issue Type: Improvement Components: Testing Reporter: Michael Kjellman Assignee: Michael Kjellman h4. Get the C* dtests running on the pytest framework. C* DTests currently run using the python test framework nosetest. This framework has been largely abandoned with no releases since 2015 and a general strong consensus in the python community that pytest is the future. h4. Why should we do this. Currently (and historically) dtests have always been difficult to run, flaky and unpredictable in CI environments, and almost impossible to debug. On November 28th, 2017, I proposed on the dev@ list that we move the dtests from nosetests to pytests. I got replies from Jon Haddad, Philip Thompson, and kurt greaves with really only "+1" like replies to the proposal. Since then I've been working pretty much non stop to complete the large refactor of dtests to pytests. As part of this effort (and due to the migration tools that exist require it) I also ported the code to python3 (from the current python 2.7 based code-base). h4. High-level summary of key changes, improvements, and new features. * Migrate dtests from executing using the nosetest framework to pytest * Port the entire code base from Python 2.7 to Python 3.6 * Update run_dtests.py to work with pytest * Add --dtest-print-tests-only option to run_dtests.py to get easily parsable list of all available collected tests * Update README.md for executing the dtests with pytest * Add new debugging tips section to README.md to help with some basics of debugging python3 and pytest * Migrate all existing Enviornment Variable usage as a means to control dtest operation modes to argparse command line options with documented help on each toggles intended usage * Migration of old unitTest and nose based test structure to modern pytest fixture approach * Automatic detection of physical system resources to automatically determine if @pytest.mark.resource_intensive annotated tests should be collected and run on the system where they are being executed * new pytest fixture replacements for @since and @pytest.mark.upgrade_test annotations * Migration to python logging framework * Upgrade thrift bindings to latest version with full python3 compatibility * Remove deprecated cql and pycassa dependencies and migrate any remaining tests to fully remove those dependencies * Fixed dozens of tests that would hang the pytest framework forever when run in CI enviornments * Ran code nearly 300 times in CircleCI during the migration and to find, identify, and fix any tests capable of hanging CI * Upgrade Tests do not yet run in CI and still need additional migration work (although all upgrade test classes compile successfully) I started with the *nose2pytest* [https://github.com/pytest-dev/nose2pytest] migration tool. As this required python 3 language support I found myself down the 2to3 python migration path. While painful to do this, the benefits of python3 over python2.7 are numerous and moving to python3 for the additional debugging tools now available to use when fixing dtests makes the effort worth it for that reason alone! After the automated tools did their thing I began what was a much longer and tedious manual process than I ever could have expected due to the custom many ways we did things in dtests (frequently to work around nosetest limitations of missing features that thankfully are now all included with the pytest framework). I've done nearly 300 test runs of my migration branch with circleci. The latest CircleCI runs can be found at: (dtests without vnodes) [https://circleci.com/gh/mkjellman/cassandra/277] (dtests with vnodes) [https://circleci.com/gh/mkjellman/cassandra/278] With vnodes, there are currently only 6 remaining dtest test failures. Without vnodes, there are 12 remaining dtest failures. It turns out that after the dtests were moved to ASF Jenkins from cassci, the jobs were misconfigured and we actually haven't been running the dtests in the non-vnodes configuration. The current most recent trunk dtest job to complete on ASF Jenkins (with vnodes) was [https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/387/]. That test run had 36 test failures. There are great performance improvements so far with pytests. With a parallism factor of 90x in CircleCI the dtests-no-vnodes job completed all tests in 16 minutes and 24 seconds and the dtests-with-vnodes job completed all tests in 14 minutes and 22 seconds.. (Compare that to the 8+ hours ASF Jenkins currently takes!). A dtest on pytest compatible CircleCI configuration is available at
[jira] [Updated] (CASSANDRA-14133) Log file names of files streamed in to a node
[ https://issues.apache.org/jira/browse/CASSANDRA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-14133: Reviewer: Jeff Jirsa > Log file names of files streamed in to a node > - > > Key: CASSANDRA-14133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14133 > Project: Cassandra > Issue Type: Improvement >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson > Fix For: 3.0.x, 3.11.x, 4.x > > > We should log the file names of sstables streamed in to a node -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14133) Log file names of files streamed in to a node
[ https://issues.apache.org/jira/browse/CASSANDRA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-14133: Fix Version/s: 4.x 3.11.x 3.0.x Status: Patch Available (was: Open) https://github.com/krummas/cassandra/commits/marcuse/14133 > Log file names of files streamed in to a node > - > > Key: CASSANDRA-14133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14133 > Project: Cassandra > Issue Type: Improvement >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson > Fix For: 3.0.x, 3.11.x, 4.x > > > We should log the file names of sstables streamed in to a node -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-14133) Log file names of files streamed in to a node
Marcus Eriksson created CASSANDRA-14133: --- Summary: Log file names of files streamed in to a node Key: CASSANDRA-14133 URL: https://issues.apache.org/jira/browse/CASSANDRA-14133 Project: Cassandra Issue Type: Improvement Reporter: Marcus Eriksson We should log the file names of sstables streamed in to a node -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14133) Log file names of files streamed in to a node
[ https://issues.apache.org/jira/browse/CASSANDRA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson reassigned CASSANDRA-14133: --- Assignee: Marcus Eriksson > Log file names of files streamed in to a node > - > > Key: CASSANDRA-14133 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14133 > Project: Cassandra > Issue Type: Improvement >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson > > We should log the file names of sstables streamed in to a node -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org