[jira] [Updated] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread Marcus Eriksson (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson updated CASSANDRA-14583:

Resolution: Fixed
Status: Resolved  (was: Ready to Commit)

and committed as {{194ad8a22315f0410155ab5eb2283d006a4fdd37}} to 
cassandra-dtest, thanks!

> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> INTERNALERROR> self.runner.pytest_runtest_protocol(item, nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 64, in pytest_runtest_protocol
> INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 79, in runtestprotocol
> INTERNALERROR> reports.append(call_and_report(item, "call", log))
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 120, in call_and_report
> INTERNALERROR> report = hook.pytest_runtest_makereport(item=item, 
> call=call)
> 

[jira] [Commented] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555171#comment-16555171
 ] 

ASF GitHub Bot commented on CASSANDRA-14583:


Github user krummas closed the pull request at:

https://github.com/apache/cassandra-dtest/pull/32


> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> INTERNALERROR> self.runner.pytest_runtest_protocol(item, nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 64, in pytest_runtest_protocol
> INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 79, in runtestprotocol
> INTERNALERROR> reports.append(call_and_report(item, "call", log))
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 120, in call_and_report
> INTERNALERROR> report = hook.pytest_runtest_makereport(item=item, 
> call=call)
> INTERNALERROR>   File 

cassandra-dtest git commit: compact storage when testing thrift

2018-07-24 Thread marcuse
Repository: cassandra-dtest
Updated Branches:
  refs/heads/master 0c46c4015 -> 194ad8a22


compact storage when testing thrift

Patch by marcuse; reviewed by Jason Brown for CASSANDRA-14583


Project: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/commit/194ad8a2
Tree: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/tree/194ad8a2
Diff: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/diff/194ad8a2

Branch: refs/heads/master
Commit: 194ad8a22315f0410155ab5eb2283d006a4fdd37
Parents: 0c46c40
Author: Marcus Eriksson 
Authored: Mon Jul 23 10:03:17 2018 +0200
Committer: Marcus Eriksson 
Committed: Wed Jul 25 07:52:00 2018 +0200

--
 write_failures_test.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra-dtest/blob/194ad8a2/write_failures_test.py
--
diff --git a/write_failures_test.py b/write_failures_test.py
index ece6245..bb2deb8 100644
--- a/write_failures_test.py
+++ b/write_failures_test.py
@@ -42,7 +42,7 @@ class TestWriteFailures(Tester):
 self.consistency_level = ConsistencyLevel.ALL
 self.failing_nodes = [1, 2]
 
-def _prepare_cluster(self, start_rpc=False):
+def _prepare_cluster(self, start_rpc=False, compact_storage=False):
 self.cluster.populate(3)
 
 if start_rpc:
@@ -59,7 +59,7 @@ class TestWriteFailures(Tester):
 """ % (KEYSPACE, self.replication_factor))
 session.set_keyspace(KEYSPACE)
 
-session.execute("CREATE TABLE IF NOT EXISTS mytable (key text PRIMARY 
KEY, value text)")
+session.execute("CREATE TABLE IF NOT EXISTS mytable (key text PRIMARY 
KEY, value text) %s"%("WITH COMPACT STORAGE" if compact_storage else ''))
 session.execute("CREATE TABLE IF NOT EXISTS countertable (key uuid 
PRIMARY KEY, value counter)")
 
 for idx in self.failing_nodes:
@@ -214,7 +214,7 @@ class TestWriteFailures(Tester):
 """
 A thrift client receives a TimedOutException
 """
-self._prepare_cluster(start_rpc=True)
+self._prepare_cluster(start_rpc=True, compact_storage=True)
 self.expected_expt = thrift_types.TimedOutException
 
 client = get_thrift_client()


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555170#comment-16555170
 ] 

ASF GitHub Bot commented on CASSANDRA-14583:


GitHub user krummas opened a pull request:

https://github.com/apache/cassandra-dtest/pull/32

compact storage when testing thrift

Patch by marcuse; reviewed by Jason Brown for CASSANDRA-14583

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/krummas/cassandra-dtest marcuse/14583

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cassandra-dtest/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit 194ad8a22315f0410155ab5eb2283d006a4fdd37
Author: Marcus Eriksson 
Date:   2018-07-23T08:03:17Z

compact storage when testing thrift

Patch by marcuse; reviewed by Jason Brown for CASSANDRA-14583




> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> 

[cassandra] Git Push Summary

2018-07-24 Thread mshuler
Repository: cassandra
Updated Tags:  refs/tags/3.11.3-tentative [created] 31d5d870f

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554978#comment-16554978
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user dineshjoshi commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204955316
  
--- Diff: 
src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java ---
@@ -114,13 +155,51 @@ public void write(StreamSession session, 
DataOutputStreamPlus out, int version)
 CassandraStreamHeader.serializer.serialize(header, out, version);
 out.flush();
 
-CassandraStreamWriter writer = header.compressionInfo == null ?
-   new CassandraStreamWriter(sstable, 
header.sections, session) :
-   new 
CompressedCassandraStreamWriter(sstable, header.sections,
-   
header.compressionInfo, session);
+IStreamWriter writer;
+if (shouldStreamFullSSTable())
+{
+writer = new CassandraBlockStreamWriter(sstable, session, 
components);
+}
+else
+{
+writer = (header.compressionInfo == null) ?
+ new CassandraStreamWriter(sstable, header.sections, 
session) :
+ new CompressedCassandraStreamWriter(sstable, 
header.sections,
+ 
header.compressionInfo, session);
+}
 writer.write(out);
 }
 
+@VisibleForTesting
+public boolean shouldStreamFullSSTable()
+{
+return isFullSSTableTransfersEnabled && isFullyContained;
+}
+
+@VisibleForTesting
+public boolean fullyContainedIn(List> normalizedRanges, 
SSTableReader sstable)
+{
+if (normalizedRanges == null)
+return false;
+
+RangeOwnHelper rangeOwnHelper = new 
RangeOwnHelper(normalizedRanges);
+try (KeyIterator iter = new KeyIterator(sstable.descriptor, 
sstable.metadata()))
+{
+while (iter.hasNext())
+{
+DecoratedKey key = iter.next();
+try
+{
+rangeOwnHelper.check(key);
+} catch(RuntimeException e)
--- End diff --

I will disable Zero Copy streaming for STCS and I've created 
[CASSANDRA-14586](https://issues.apache.org/jira/browse/CASSANDRA-14586) to 
further discuss fixes.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554976#comment-16554976
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user dineshjoshi commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204955090
  
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentInfo.java ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.db.streaming;
+
+import java.io.IOException;
+
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.cassandra.db.TypeSizes;
+import org.apache.cassandra.io.IVersionedSerializer;
+import org.apache.cassandra.io.sstable.Component;
+import org.apache.cassandra.io.util.DataInputPlus;
+import org.apache.cassandra.io.util.DataOutputPlus;
+
+public class ComponentInfo
--- End diff --

I have refactored this to `ComponentManifest`


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554975#comment-16554975
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user dineshjoshi commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204955043
  
--- Diff: src/java/org/apache/cassandra/db/lifecycle/LogFile.java ---
@@ -66,7 +66,7 @@
 private final LogReplicaSet replicas = new LogReplicaSet();
 
 // The transaction records, this set must be ORDER PRESERVING
-private final LinkedHashSet records = new LinkedHashSet<>();
+private final Set records = Collections.synchronizedSet(new 
LinkedHashSet<>()); // TODO: Hack until we fix CASSANDRA-14554
--- End diff --

I should've worded the comment differently but it is a hack to avoid a 
`ConcurrentModificationException` 
([CASSANDRA-14554](https://issues.apache.org/jira/browse/CASSANDRA-14554)). 
This currently exists in trunk and was not introduced as part of this PR hence 
the separate ticket.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554973#comment-16554973
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user dineshjoshi commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204954749
  
--- Diff: src/java/org/apache/cassandra/config/DatabaseDescriptor.java ---
@@ -2260,6 +2260,20 @@ public static int getStreamingConnectionsPerHost()
 return conf.streaming_connections_per_host;
 }
 
+public static boolean isFullSSTableTransfersEnabled()
+{
+if (conf.server_encryption_options.enabled || 
conf.server_encryption_options.optional)
+{
+logger.debug("Internode encryption enabled. Disabling zero 
copy SSTable transfers for streaming.");
--- End diff --

Done


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554974#comment-16554974
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user dineshjoshi commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204954805
  
--- Diff: 
src/java/org/apache/cassandra/db/streaming/CassandraBlockStreamReader.java ---
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.db.streaming;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.List;
+import java.util.Set;
+
+import com.google.common.base.Throwables;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.DecoratedKey;
+import org.apache.cassandra.db.Directories;
+import org.apache.cassandra.db.SerializationHeader;
+import org.apache.cassandra.db.lifecycle.LifecycleTransaction;
+import org.apache.cassandra.io.sstable.Component;
+import org.apache.cassandra.io.sstable.Descriptor;
+import org.apache.cassandra.io.sstable.SSTableMultiWriter;
+import org.apache.cassandra.io.sstable.format.SSTableFormat;
+import org.apache.cassandra.io.sstable.format.Version;
+import org.apache.cassandra.io.sstable.format.big.BigTableBlockWriter;
+import org.apache.cassandra.io.util.DataInputPlus;
+import org.apache.cassandra.schema.TableId;
+import org.apache.cassandra.streaming.ProgressInfo;
+import org.apache.cassandra.streaming.StreamReceiver;
+import org.apache.cassandra.streaming.StreamSession;
+import org.apache.cassandra.streaming.messages.StreamMessageHeader;
+import org.apache.cassandra.utils.Collectors3;
+import org.apache.cassandra.utils.FBUtilities;
+
+/**
+ * CassandraBlockStreamReader reads SSTable off the wire and writes it to 
disk.
+ */
+public class CassandraBlockStreamReader implements IStreamReader
+{
+private static final Logger logger = 
LoggerFactory.getLogger(CassandraBlockStreamReader.class);
+protected final TableId tableId;
+protected final StreamSession session;
+protected final int sstableLevel;
--- End diff --

Cleaned up the protected fields. I still need to reset the level.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554971#comment-16554971
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user dineshjoshi commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204954729
  
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentInfo.java ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.db.streaming;
+
+import java.io.IOException;
+
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.cassandra.db.TypeSizes;
+import org.apache.cassandra.io.IVersionedSerializer;
+import org.apache.cassandra.io.sstable.Component;
+import org.apache.cassandra.io.util.DataInputPlus;
+import org.apache.cassandra.io.util.DataOutputPlus;
+
+public class ComponentInfo
+{
+final Component.Type type;
+final long length;
+
+public ComponentInfo(Component.Type type, long length)
+{
+assert length >= 0 : "Component length cannot be negative";
+this.type = type;
+this.length = length;
+}
+
+@Override
+public String toString()
+{
+return "ComponentInfo{" +
+   "type=" + type +
+   ", length=" + length +
+   '}';
+}
+
+public boolean equals(Object o)
--- End diff --

`CassandraStreamHeader`'s `equals()` and `hashCode()` method are not dead 
code. They're used in `CassandraStreamHeaderTest::serializerTest` which 
eventually ends up in 
[`SerializationUtils::assertSerializationCycle`](https://github.com/apache/cassandra/blob/9714a7c817b64a3358f69e536535c756c5c6df48/test/unit/org/apache/cassandra/serializers/SerializationUtils.java#L60).
 This is what originally forced me to implement those methods. The only other 
choice was to test the equality for `ComponentInfo` in 
`CassandraStreamHeader::equal()` which would have been a bad choice.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554962#comment-16554962
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user dineshjoshi commented on the issue:

https://github.com/apache/cassandra/pull/239
  
@iamaleksey I have resolved most of your comments. I still have a couple to 
go. I will update this PR when I am done with those and get a clean dtest run.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14468) "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16

2018-07-24 Thread Jordan West (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554718#comment-16554718
 ] 

Jordan West commented on CASSANDRA-14468:
-

[~iamaleksey] ugh indeed. I'll lend an extra pair of eyes to whether or not 
that assertion is needed. 

> "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16
> -
>
> Key: CASSANDRA-14468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14468
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Wade Simmons
>Priority: Major
> Attachments: data.tar.gz
>
>
> I am attempting to upgrade from Cassandra 2.2.10 to 3.0.16. I am getting this 
> error:
> {code}
> org.apache.cassandra.exceptions.ConfigurationException: Unable to parse 
> targets for index idx_foo ("666f6f")
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.parseTarget(CassandraIndex.java:800)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.indexCfsMetadata(CassandraIndex.java:747)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.scrubDataDirectories(ColumnFamilyStore.java:645)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:251) 
> [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
>  [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:697) 
> [apache-cassandra-3.0.16.jar:3.0.16]
> {code}
> It looks like this might be related to CASSANDRA-14104 that was just added to 
> 3.0.16 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread Jason Brown (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554711#comment-16554711
 ] 

Jason Brown commented on CASSANDRA-14583:
-

+1

> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> INTERNALERROR> self.runner.pytest_runtest_protocol(item, nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 64, in pytest_runtest_protocol
> INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 79, in runtestprotocol
> INTERNALERROR> reports.append(call_and_report(item, "call", log))
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 120, in call_and_report
> INTERNALERROR> report = hook.pytest_runtest_makereport(item=item, 
> call=call)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__

[jira] [Updated] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14583:

Status: Ready to Commit  (was: Patch Available)

> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> INTERNALERROR> self.runner.pytest_runtest_protocol(item, nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 64, in pytest_runtest_protocol
> INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 79, in runtestprotocol
> INTERNALERROR> reports.append(call_and_report(item, "call", log))
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 120, in call_and_report
> INTERNALERROR> report = hook.pytest_runtest_makereport(item=item, 
> call=call)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in 

[jira] [Commented] (CASSANDRA-14468) "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16

2018-07-24 Thread Aleksey Yeschenko (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554694#comment-16554694
 ] 

Aleksey Yeschenko commented on CASSANDRA-14468:
---

[~jrwest] Right. I'm trying to find out why it asserts that, but can't. Even 
equals impl. doesn't have a == shortcut. I *think* it should be safe to drop 
that assertion altogether (maybe with some more research first).

The alternative is not pretty at all, and won't work in 4.0 - the alternative 
being replicating {{CFMetaData.getColumnDefinitionNameComparator()}} method but 
without having all of the data yet. Ugh.

> "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16
> -
>
> Key: CASSANDRA-14468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14468
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Wade Simmons
>Priority: Major
> Attachments: data.tar.gz
>
>
> I am attempting to upgrade from Cassandra 2.2.10 to 3.0.16. I am getting this 
> error:
> {code}
> org.apache.cassandra.exceptions.ConfigurationException: Unable to parse 
> targets for index idx_foo ("666f6f")
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.parseTarget(CassandraIndex.java:800)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.indexCfsMetadata(CassandraIndex.java:747)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.scrubDataDirectories(ColumnFamilyStore.java:645)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:251) 
> [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
>  [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:697) 
> [apache-cassandra-3.0.16.jar:3.0.16]
> {code}
> It looks like this might be related to CASSANDRA-14104 that was just added to 
> 3.0.16 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-14587) TrueDiskSpaceUsed overcounts snapshots

2018-07-24 Thread Elliott Sims (JIRA)
Elliott Sims created CASSANDRA-14587:


 Summary: TrueDiskSpaceUsed overcounts snapshots
 Key: CASSANDRA-14587
 URL: https://issues.apache.org/jira/browse/CASSANDRA-14587
 Project: Cassandra
  Issue Type: Bug
  Components: Tools
 Environment: Debian 8

Cassandra 3.11.2
Reporter: Elliott Sims


Running 'nodetool listsnapshots' seems to overcount "TrueDiskSpaceUsed" under 
some circumstances.  Specifically when there's a large number of snapshots.  I 
suspect that it's not deduplicating space used when multiple snapshots share 
sstables that are not part of the current table.

Results of "nodetool listsnapshots":
Total TrueDiskSpaceUsed: 396.11 MiB
Results of "du -hcs" on the table's directory:
18M    total

This is 50+ snapshots (every minute) run with "-t  -sf 
--column-family  "
The results of a "du -hcs -L 

[jira] [Commented] (CASSANDRA-14468) "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16

2018-07-24 Thread Jordan West (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554686#comment-16554686
 ] 

Jordan West commented on CASSANDRA-14468:
-

[~iamaleksey] tried that locally. It looks like {{ColumnDefinition}} requires 
{{ColumnIdentifier}} to be interned: 
[https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/config/ColumnDefinition.java#L156.]
 

> "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16
> -
>
> Key: CASSANDRA-14468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14468
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Wade Simmons
>Priority: Major
> Attachments: data.tar.gz
>
>
> I am attempting to upgrade from Cassandra 2.2.10 to 3.0.16. I am getting this 
> error:
> {code}
> org.apache.cassandra.exceptions.ConfigurationException: Unable to parse 
> targets for index idx_foo ("666f6f")
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.parseTarget(CassandraIndex.java:800)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.indexCfsMetadata(CassandraIndex.java:747)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.scrubDataDirectories(ColumnFamilyStore.java:645)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:251) 
> [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
>  [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:697) 
> [apache-cassandra-3.0.16.jar:3.0.16]
> {code}
> It looks like this might be related to CASSANDRA-14104 that was just added to 
> 3.0.16 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554684#comment-16554684
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user iamaleksey commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204875677
  
--- Diff: src/java/org/apache/cassandra/db/streaming/ComponentInfo.java ---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.db.streaming;
+
+import java.io.IOException;
+
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.cassandra.db.TypeSizes;
+import org.apache.cassandra.io.IVersionedSerializer;
+import org.apache.cassandra.io.sstable.Component;
+import org.apache.cassandra.io.util.DataInputPlus;
+import org.apache.cassandra.io.util.DataOutputPlus;
+
+public class ComponentInfo
+{
+final Component.Type type;
+final long length;
+
+public ComponentInfo(Component.Type type, long length)
+{
+assert length >= 0 : "Component length cannot be negative";
+this.type = type;
+this.length = length;
+}
+
+@Override
+public String toString()
+{
+return "ComponentInfo{" +
+   "type=" + type +
+   ", length=" + length +
+   '}';
+}
+
+public boolean equals(Object o)
--- End diff --

I shouldn't have said "it's generally considered" here, as apparently it's 
not quite, as @aweisberg pointed out. It's a subjective preference, and what 
I'd do, but feel free to disregard this particular comment.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-9608) Support Java 11

2018-07-24 Thread Robert Stupp (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554679#comment-16554679
 ] 

Robert Stupp commented on CASSANDRA-9608:
-

There are still "a few" dtests failing. Most due to the same reason, but this 
time in the dtest code itself. 
[dtest-PR|https://github.com/apache/cassandra-dtest/pull/31] to fix that

> Support Java 11
> ---
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
>  Issue Type: Task
>Reporter: Robert Stupp
>Assignee: Robert Stupp
>Priority: Minor
> Fix For: 4.x
>
> Attachments: jdk_9_10.patch
>
>
> This ticket is intended to group all issues found to support Java 9 in the 
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved. 
> It can be easily solved using this patch:
> {code}
> - artifactId="cobertura"/>
> + artifactId="cobertura">
> +  
> +
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods 
> {{monitorEnter}} + {{monitorExit}}. These methods are used by 
> {{o.a.c.utils.concurrent.Locks}} which is only used by 
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early 
> development phase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-9608) Support Java 11

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554677#comment-16554677
 ] 

ASF GitHub Bot commented on CASSANDRA-9608:
---

GitHub user snazy opened a pull request:

https://github.com/apache/cassandra-dtest/pull/31

CASSANDRA-9608 fix jmxutils.py



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/snazy/cassandra-dtest 9608-fix-jmxutils

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cassandra-dtest/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit 9c248272b85c95b4b347e1c8277dfd0b8c94aa94
Author: Robert Stupp 
Date:   2018-07-24T18:51:44Z

fix jmxutils.py




> Support Java 11
> ---
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
>  Issue Type: Task
>Reporter: Robert Stupp
>Assignee: Robert Stupp
>Priority: Minor
> Fix For: 4.x
>
> Attachments: jdk_9_10.patch
>
>
> This ticket is intended to group all issues found to support Java 9 in the 
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved. 
> It can be easily solved using this patch:
> {code}
> - artifactId="cobertura"/>
> + artifactId="cobertura">
> +  
> +
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods 
> {{monitorEnter}} + {{monitorExit}}. These methods are used by 
> {{o.a.c.utils.concurrent.Locks}} which is only used by 
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early 
> development phase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554675#comment-16554675
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user iamaleksey commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204874237
  
--- Diff: 
src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java ---
@@ -114,13 +155,51 @@ public void write(StreamSession session, 
DataOutputStreamPlus out, int version)
 CassandraStreamHeader.serializer.serialize(header, out, version);
 out.flush();
 
-CassandraStreamWriter writer = header.compressionInfo == null ?
-   new CassandraStreamWriter(sstable, 
header.sections, session) :
-   new 
CompressedCassandraStreamWriter(sstable, header.sections,
-   
header.compressionInfo, session);
+IStreamWriter writer;
+if (shouldStreamFullSSTable())
+{
+writer = new CassandraBlockStreamWriter(sstable, session, 
components);
+}
+else
+{
+writer = (header.compressionInfo == null) ?
+ new CassandraStreamWriter(sstable, header.sections, 
session) :
+ new CompressedCassandraStreamWriter(sstable, 
header.sections,
+ 
header.compressionInfo, session);
+}
 writer.write(out);
 }
 
+@VisibleForTesting
+public boolean shouldStreamFullSSTable()
+{
+return isFullSSTableTransfersEnabled && isFullyContained;
+}
+
+@VisibleForTesting
+public boolean fullyContainedIn(List> normalizedRanges, 
SSTableReader sstable)
+{
+if (normalizedRanges == null)
+return false;
+
+RangeOwnHelper rangeOwnHelper = new 
RangeOwnHelper(normalizedRanges);
+try (KeyIterator iter = new KeyIterator(sstable.descriptor, 
sstable.metadata()))
+{
+while (iter.hasNext())
+{
+DecoratedKey key = iter.next();
+try
+{
+rangeOwnHelper.check(key);
+} catch(RuntimeException e)
--- End diff --

@dineshjoshi Duplicating a reply here: I think it's fine to not block this 
PR on the improvements, but disable zero copy for STCS for now, and commit that 
way. Once we optimise the containment check - ideally before 4.0 - enable for 
STCS as well.

Encoding information about the effective contained ranges is one way. 
Alternative way would be to invert the ranges we are checking for, and look for 
presence of keys in the gaps - but relying on summary and index to efficiently 
search rather than linearly scan. But again - let's temporarily disable zero 
copy for STCS for now, to not delay the ticket beyond necessary.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554669#comment-16554669
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user iamaleksey commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204872490
  
--- Diff: src/java/org/apache/cassandra/db/lifecycle/LogFile.java ---
@@ -66,7 +66,7 @@
 private final LogReplicaSet replicas = new LogReplicaSet();
 
 // The transaction records, this set must be ORDER PRESERVING
-private final LinkedHashSet records = new LinkedHashSet<>();
+private final Set records = Collections.synchronizedSet(new 
LinkedHashSet<>()); // TODO: Hack until we fix CASSANDRA-14554
--- End diff --

@dineshjoshi Ah. I see, that makes sense. The comment made it seem like 
this was supposed to be the fix for the issue, but this is just for the tests 
to pass? I'm good with that, given the extra context.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14573) Expose settings in virtual table

2018-07-24 Thread Jeremy Hanna (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554590#comment-16554590
 ] 

Jeremy Hanna commented on CASSANDRA-14573:
--

Would we want to include a column indicating whether the value was explicitly 
set (as opposed to a default)?

> Expose settings in virtual table
> 
>
> Key: CASSANDRA-14573
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14573
> Project: Cassandra
>  Issue Type: New Feature
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
>  Labels: virtual-tables
>
> Allow both viewing what the settings are (currently impossible for some) and 
> allow changing some settings.
> Example:
> {code:java}
> UPDATE system_info.settings SET value = 'false' WHERE setting = 
> 'hinted_handoff_enabled';
> SELECT * FROM system_info.settings WHERE writable = True;
>  setting  | value  | writable
> --++--
>   batch_size_fail_threshold_in_kb | 50 | True
>   batch_size_warn_threshold_in_kb |  5 | True
>  cas_contention_timeout_in_ms |   1000 | True
>  compaction_throughput_mb_per_sec | 16 | True
> concurrent_compactors |  2 | True
>concurrent_validations | 2147483647 | True
>   counter_write_request_timeout_in_ms |   5000 | True
>hinted_handoff_enabled |  false | True
> hinted_handoff_throttle_in_kb |   1024 | True
>   incremental_backups |  false | True
>  inter_dc_stream_throughput_outbound_megabits_per_sec |200 | True
> phi_convict_threshold |8.0 | True
>   range_request_timeout_in_ms |  1 | True
>read_request_timeout_in_ms |   5000 | True
> request_timeout_in_ms |  1 | True
>   stream_throughput_outbound_megabits_per_sec |200 | True
>   tombstone_failure_threshold | 10 | True
>  tombstone_warn_threshold |   1000 | True
>truncate_request_timeout_in_ms |  6 | True
>   write_request_timeout_in_ms |   2000 | 
> True{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-13010) nodetool compactionstats should say which disk a compaction is writing to

2018-07-24 Thread Jon Haddad (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jon Haddad updated CASSANDRA-13010:
---
Reviewer:   (was: Jon Haddad)

> nodetool compactionstats should say which disk a compaction is writing to
> -
>
> Key: CASSANDRA-13010
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13010
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Compaction, Tools
>Reporter: Jon Haddad
>Assignee: Alex Lourie
>Priority: Major
>  Labels: 4.0-feature-freeze-review-requested, lhf
> Attachments: cleanup.png, multiple operations.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-13010) nodetool compactionstats should say which disk a compaction is writing to

2018-07-24 Thread Jon Haddad (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554584#comment-16554584
 ] 

Jon Haddad commented on CASSANDRA-13010:


I'm going to remove myself as the reviewer, I'm not sure if I'll have time to 
get another review in anytime soon.

> nodetool compactionstats should say which disk a compaction is writing to
> -
>
> Key: CASSANDRA-13010
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13010
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Compaction, Tools
>Reporter: Jon Haddad
>Assignee: Alex Lourie
>Priority: Major
>  Labels: 4.0-feature-freeze-review-requested, lhf
> Attachments: cleanup.png, multiple operations.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-13010) nodetool compactionstats should say which disk a compaction is writing to

2018-07-24 Thread Jon Haddad (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554581#comment-16554581
 ] 

Jon Haddad edited comment on CASSANDRA-13010 at 7/24/18 5:49 PM:
-

Hey [~alourie], I took a look at the patch. I'm a little confused by the output 
though. Is this what you're expecting?:
{noformat}
$ bin/nodetool compactionstats -v   
pending tasks: 1
- tlp_stress.sensor_data: 1

idcompaction type keyspace   table  
 completed total unit  progress
/home/jhaddad/dev/cassandra/bin/../data/data/   
   
8d542480-8f69-11e8-b6a9-4905c6229fa6  Compaction  tlp_stress 
sensor_data 397746242 691456147 bytes 57.52%  
Active compaction remaining time :   0h00m17s
{noformat}


was (Author: rustyrazorblade):
Hey [~alourie], I took a look at the patch.  I'm a little confused by the 
output though.  Is this what you're expecting:


{noformat}
$ bin/nodetool compactionstats -v   
pending tasks: 1
- tlp_stress.sensor_data: 1

idcompaction type keyspace   table  
 completed total unit  progress
/home/jhaddad/dev/cassandra/bin/../data/data/   
   
8d542480-8f69-11e8-b6a9-4905c6229fa6  Compaction  tlp_stress 
sensor_data 397746242 691456147 bytes 57.52%  
Active compaction remaining time :   0h00m17s
{noformat}


> nodetool compactionstats should say which disk a compaction is writing to
> -
>
> Key: CASSANDRA-13010
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13010
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Compaction, Tools
>Reporter: Jon Haddad
>Assignee: Alex Lourie
>Priority: Major
>  Labels: 4.0-feature-freeze-review-requested, lhf
> Attachments: cleanup.png, multiple operations.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-13010) nodetool compactionstats should say which disk a compaction is writing to

2018-07-24 Thread Jon Haddad (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554581#comment-16554581
 ] 

Jon Haddad commented on CASSANDRA-13010:


Hey [~alourie], I took a look at the patch.  I'm a little confused by the 
output though.  Is this what you're expecting:


{noformat}
$ bin/nodetool compactionstats -v   
pending tasks: 1
- tlp_stress.sensor_data: 1

idcompaction type keyspace   table  
 completed total unit  progress
/home/jhaddad/dev/cassandra/bin/../data/data/   
   
8d542480-8f69-11e8-b6a9-4905c6229fa6  Compaction  tlp_stress 
sensor_data 397746242 691456147 bytes 57.52%  
Active compaction remaining time :   0h00m17s
{noformat}


> nodetool compactionstats should say which disk a compaction is writing to
> -
>
> Key: CASSANDRA-13010
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13010
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Compaction, Tools
>Reporter: Jon Haddad
>Assignee: Alex Lourie
>Priority: Major
>  Labels: 4.0-feature-freeze-review-requested, lhf
> Attachments: cleanup.png, multiple operations.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread Marcus Eriksson (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson updated CASSANDRA-14583:

Reviewer: Jason Brown
  Status: Patch Available  (was: Open)

"clean" test run: 
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/594/
dtest patch: https://github.com/krummas/cassandra-dtest/commits/marcuse/14583

> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> INTERNALERROR> self.runner.pytest_runtest_protocol(item, nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 64, in pytest_runtest_protocol
> INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 79, in runtestprotocol
> INTERNALERROR> reports.append(call_and_report(item, "call", log))
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 120, in call_and_report
> 

[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554560#comment-16554560
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user dineshjoshi commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204842484
  
--- Diff: src/java/org/apache/cassandra/db/lifecycle/LogFile.java ---
@@ -66,7 +66,7 @@
 private final LogReplicaSet replicas = new LogReplicaSet();
 
 // The transaction records, this set must be ORDER PRESERVING
-private final LinkedHashSet records = new LinkedHashSet<>();
+private final Set records = Collections.synchronizedSet(new 
LinkedHashSet<>()); // TODO: Hack until we fix CASSANDRA-14554
--- End diff --

@iamaleksey I don't think it is sufficient but we have to address this 
conclusively as part of 14554. I've already spoken to @belliottsmith regarding 
it and have a plan to fix this.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14586) Performant range containment check for SSTables

2018-07-24 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554550#comment-16554550
 ] 

Dinesh Joshi commented on CASSANDRA-14586:
--

cc: [~krummas] [~benedict] [~jasobrown] [~aweisberg]

> Performant range containment check for SSTables
> ---
>
> Key: CASSANDRA-14586
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14586
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
>
> Related to 14556, we would like to make the range containment check 
> performant. Right now we iterate over all partition keys in the SSTables and 
> determine the eligibility for Zero Copy streaming. This ticket is to explore 
> ways to make it performant by storing information in the SSTable's Metadata.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-14586) Performant range containment check for SSTables

2018-07-24 Thread Dinesh Joshi (JIRA)
Dinesh Joshi created CASSANDRA-14586:


 Summary: Performant range containment check for SSTables
 Key: CASSANDRA-14586
 URL: https://issues.apache.org/jira/browse/CASSANDRA-14586
 Project: Cassandra
  Issue Type: Improvement
  Components: Streaming and Messaging
Reporter: Dinesh Joshi
Assignee: Dinesh Joshi


Related to 14556, we would like to make the range containment check performant. 
Right now we iterate over all partition keys in the SSTables and determine the 
eligibility for Zero Copy streaming. This ticket is to explore ways to make it 
performant by storing information in the SSTable's Metadata.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14584) insert if not exists, with replication factor of 2 doesn't work

2018-07-24 Thread arik (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554544#comment-16554544
 ] 

arik commented on CASSANDRA-14584:
--

My keyspace has RF = 2.

I'm running it on different cassandra clusters (dev, test, prod etc)

Some of the clusters are single node clusters.

All other commands (insert/delete/update etc) works fine with any of the 
deployments

I have a single command that fails, the "insert if not exists" command.

Is there a limitation saying RF > 1 must be on multiple nodes clusters?

Or any limitation on the insert if not exists command?

> insert if not exists, with replication factor of 2 doesn't work
> ---
>
> Key: CASSANDRA-14584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14584
> Project: Cassandra
>  Issue Type: Bug
>Reporter: arik
>Priority: Major
>
> Running with a single node cluster.
> My keyspace has a replication factor of 2.
> Insert if not exists doesn't work on that setup.
> Produce the following error:
> org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:720)
>  Caused by: com.datastax.driver.core.exceptions.NoHostAvailableException: All 
> host(s) tried for query failed (tried: cassandra-service/10.23.251.29:9042 
> (com.datastax.driver.core.exceptions.UnavailableException: Not enough 
> replicas available for query at consistency QUORUM (2 required but only 1 
> alive))) at 
> com.datastax.driver.core.RequestHandler.reportNoMoreHosts(RequestHandler.java:223)
>  at 
> com.datastax.driver.core.RequestHandler.access$1200(RequestHandler.java:41) 
> at 
> com.datastax.driver.core.RequestHandler$SpeculativeExecution.findNextHostAndQuery(RequestHandler.java:309)
>  at 
> com.datastax.driver.core.RequestHandler$SpeculativeExecution.retry(RequestHandler.java:477)
>  at 
> com.datastax.driver.core.RequestHandler$SpeculativeExecution.processRetryDecision(RequestHandler.java:455)
>  at 
> com.datastax.driver.core.RequestHandler$SpeculativeExecution.onSet(RequestHandler.java:686)
>  at 
> com.datastax.driver.core.Connection$Dispatcher.channelRead0(Connection.java:1091)
>  at 
> com.datastax.driver.core.Connection$Dispatcher.channelRead0(Connection.java:1008)
>  at 
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at 
> io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:287)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at 
> io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at 
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310)
>  at 
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at 
> io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:86)
>  at 
> com.datastax.driver.core.InboundTrafficMeter.channelRead(InboundTrafficMeter.java:29)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1273) at 
> io.netty.handler.ssl.SslHandler.decode(SslHandler.java:1084) at 
> 

[jira] [Updated] (CASSANDRA-14571) Fix race condition in MV build/propagate when there is existing data in the base table

2018-07-24 Thread Jeremy Hanna (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Hanna updated CASSANDRA-14571:
-
Component/s: Materialized Views

> Fix race condition in MV build/propagate when there is existing data in the 
> base table
> --
>
> Key: CASSANDRA-14571
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14571
> Project: Cassandra
>  Issue Type: Bug
>  Components: Materialized Views
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Major
> Fix For: 4.0
>
>
> CASSANDRA-13426 exposed a race in MV initialisation and building, which now 
> breaks, consistently, 
> {{materialized_views_test.py::TestMaterializedViews::test_populate_mv_after_insert_wide_rows}}.
> CASSANDRA-14168 is also directly related.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14572) Expose all table metrics in virtual table

2018-07-24 Thread Jeremy Hanna (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Hanna updated CASSANDRA-14572:
-
Labels: virtual-tables  (was: )

> Expose all table metrics in virtual table
> -
>
> Key: CASSANDRA-14572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14572
> Project: Cassandra
>  Issue Type: New Feature
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
>  Labels: virtual-tables
>
> While we want a number of virtual tables to display data in a way thats great 
> and intuitive like in nodetool. There is also much for being able to expose 
> the metrics we have for tooling via CQL instead of JMX. This is more for the 
> tooling and adhoc advanced users who know exactly what they are looking for.
> *Schema:*
> Initial idea is to expose data via {{((keyspace, table), metric)}} with a 
> column for each metric value. Could also use a Map or UDT instead of the 
> column based that can be a bit more specific to each metric type. To that end 
> there can be a {{metric_type}} column and then a UDT for each metric type 
> filled in, or a single value with more of a Map style. I am 
> purposing the column type though as with {{ALLOW FILTERING}} it does allow 
> more extensive query capabilities.
> *Implementations:*
> * Use reflection to grab all the metrics from TableMetrics (see: 
> CASSANDRA-7622 impl). This is easiest and least abrasive towards new metric 
> implementors... but its reflection and a kinda a bad idea.
> * Add a hook in TableMetrics to register with this virtual table when 
> registering
> * Pull from the CassandraMetrics registery (either reporter or iterate 
> through metrics query on read of virtual table)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14289) Document sstable tools

2018-07-24 Thread Valerie Parham-Thompson (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554523#comment-16554523
 ] 

Valerie Parham-Thompson commented on CASSANDRA-14289:
-

I agree [~hkroger]. Let me see if there's a good compromise solution to combine 
the generated help files and some directly editable files.

> Document sstable tools
> --
>
> Key: CASSANDRA-14289
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14289
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: Hannu Kröger
>Priority: Major
> Attachments: gen-sstable-docs.py, sstabledocs.tar.gz
>
>
> Following tools are missing in the documentation of cassandra tools on the 
> documentation site (http://cassandra.apache.org/doc/latest/tools/index.html):
>  * sstabledump
>  * sstableexpiredblockers
>  * sstablelevelreset
>  * sstableloader
>  * sstablemetadata
>  * sstableofflinerelevel
>  * sstablerepairedset
>  * sstablescrub
>  * sstablesplit
>  * sstableupgrade
>  * sstableutil
>  * sstableverify



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14573) Expose settings in virtual table

2018-07-24 Thread Jeremy Hanna (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Hanna updated CASSANDRA-14573:
-
Labels: virtual-tables  (was: )

> Expose settings in virtual table
> 
>
> Key: CASSANDRA-14573
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14573
> Project: Cassandra
>  Issue Type: New Feature
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
>  Labels: virtual-tables
>
> Allow both viewing what the settings are (currently impossible for some) and 
> allow changing some settings.
> Example:
> {code:java}
> UPDATE system_info.settings SET value = 'false' WHERE setting = 
> 'hinted_handoff_enabled';
> SELECT * FROM system_info.settings WHERE writable = True;
>  setting  | value  | writable
> --++--
>   batch_size_fail_threshold_in_kb | 50 | True
>   batch_size_warn_threshold_in_kb |  5 | True
>  cas_contention_timeout_in_ms |   1000 | True
>  compaction_throughput_mb_per_sec | 16 | True
> concurrent_compactors |  2 | True
>concurrent_validations | 2147483647 | True
>   counter_write_request_timeout_in_ms |   5000 | True
>hinted_handoff_enabled |  false | True
> hinted_handoff_throttle_in_kb |   1024 | True
>   incremental_backups |  false | True
>  inter_dc_stream_throughput_outbound_megabits_per_sec |200 | True
> phi_convict_threshold |8.0 | True
>   range_request_timeout_in_ms |  1 | True
>read_request_timeout_in_ms |   5000 | True
> request_timeout_in_ms |  1 | True
>   stream_throughput_outbound_megabits_per_sec |200 | True
>   tombstone_failure_threshold | 10 | True
>  tombstone_warn_threshold |   1000 | True
>truncate_request_timeout_in_ms |  6 | True
>   write_request_timeout_in_ms |   2000 | 
> True{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14584) insert if not exists, with replication factor of 2 doesn't work

2018-07-24 Thread Jeremy Hanna (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554518#comment-16554518
 ] 

Jeremy Hanna commented on CASSANDRA-14584:
--

How would you have RF=2 with a single node cluster?

> insert if not exists, with replication factor of 2 doesn't work
> ---
>
> Key: CASSANDRA-14584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14584
> Project: Cassandra
>  Issue Type: Bug
>Reporter: arik
>Priority: Major
>
> Running with a single node cluster.
> My keyspace has a replication factor of 2.
> Insert if not exists doesn't work on that setup.
> Produce the following error:
> org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:720)
>  Caused by: com.datastax.driver.core.exceptions.NoHostAvailableException: All 
> host(s) tried for query failed (tried: cassandra-service/10.23.251.29:9042 
> (com.datastax.driver.core.exceptions.UnavailableException: Not enough 
> replicas available for query at consistency QUORUM (2 required but only 1 
> alive))) at 
> com.datastax.driver.core.RequestHandler.reportNoMoreHosts(RequestHandler.java:223)
>  at 
> com.datastax.driver.core.RequestHandler.access$1200(RequestHandler.java:41) 
> at 
> com.datastax.driver.core.RequestHandler$SpeculativeExecution.findNextHostAndQuery(RequestHandler.java:309)
>  at 
> com.datastax.driver.core.RequestHandler$SpeculativeExecution.retry(RequestHandler.java:477)
>  at 
> com.datastax.driver.core.RequestHandler$SpeculativeExecution.processRetryDecision(RequestHandler.java:455)
>  at 
> com.datastax.driver.core.RequestHandler$SpeculativeExecution.onSet(RequestHandler.java:686)
>  at 
> com.datastax.driver.core.Connection$Dispatcher.channelRead0(Connection.java:1091)
>  at 
> com.datastax.driver.core.Connection$Dispatcher.channelRead0(Connection.java:1008)
>  at 
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at 
> io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:287)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at 
> io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at 
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310)
>  at 
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at 
> io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:86)
>  at 
> com.datastax.driver.core.InboundTrafficMeter.channelRead(InboundTrafficMeter.java:29)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1273) at 
> io.netty.handler.ssl.SslHandler.decode(SslHandler.java:1084) at 
> io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:489)
>  at 
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:428)
>  at 
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:265)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> 

[jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra

2018-07-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554515#comment-16554515
 ] 

ASF GitHub Bot commented on CASSANDRA-14556:


Github user iamaleksey commented on a diff in the pull request:

https://github.com/apache/cassandra/pull/239#discussion_r204831709
  
--- Diff: src/java/org/apache/cassandra/db/lifecycle/LogFile.java ---
@@ -66,7 +66,7 @@
 private final LogReplicaSet replicas = new LogReplicaSet();
 
 // The transaction records, this set must be ORDER PRESERVING
-private final LinkedHashSet records = new LinkedHashSet<>();
+private final Set records = Collections.synchronizedSet(new 
LinkedHashSet<>()); // TODO: Hack until we fix CASSANDRA-14554
--- End diff --

I'm not very well familiar with `LifeCycleTransaction` code, but I'm not 
sure this is sufficient as a workaround. @belliottsmith Could you please 
confirm that this - or isn't - sufficient? Here and the equivalent change to 
`LogReplicaSet`.


> Optimize streaming path in Cassandra
> 
>
> Key: CASSANDRA-14556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Streaming and Messaging
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Major
>  Labels: Performance
> Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates 
> unnecessary garbage and slows down the whole streaming process as some 
> sstables can be transferred as a whole file rather than individual 
> partitions. The objective of the ticket is to detect when a whole sstable can 
> be transferred and skip the object reification. We can also use a zero-copy 
> path to avoid bringing data into user-space on both sending and receiving 
> side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Resolved] (CASSANDRA-12400) dtest failure in upgrade_tests.paging_test.TestPagingDatasetChangesNodes3RF3_Upgrade_current_3_0_x_To_indev_3_x.test_row_TTL_expiry_during_paging

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown resolved CASSANDRA-12400.
-
Resolution: Later

closing in favor of CASSANDRA-14421

> dtest failure in 
> upgrade_tests.paging_test.TestPagingDatasetChangesNodes3RF3_Upgrade_current_3_0_x_To_indev_3_x.test_row_TTL_expiry_during_paging
> -
>
> Key: CASSANDRA-12400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12400
> Project: Cassandra
>  Issue Type: Test
>Reporter: Sean McCarthy
>Priority: Major
>
> example failure:
> http://cassci.datastax.com/job/trunk_dtest_upgrade/17/testReport/upgrade_tests.paging_test/TestPagingDatasetChangesNodes3RF3_Upgrade_current_3_0_x_To_indev_3_x/test_row_TTL_expiry_during_paging/
> {code}
> Error Message
> Lists differ: [300, 300, 131] != [300, 300, 200]
> First differing element 2:
> 131
> 200
> - [300, 300, 131]
> ?^^^
> + [300, 300, 200]
> ?  
> {code}
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/upgrade_tests/paging_test.py", line 
> 1221, in test_row_TTL_expiry_during_paging
> self.assertEqual(pf.num_results_all(), [300, 300, 200])
>   File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 742, in assertListEqual
> self.assertSequenceEqual(list1, list2, msg, seq_type=list)
>   File "/usr/lib/python2.7/unittest/case.py", line 724, in assertSequenceEqual
> self.fail(msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Resolved] (CASSANDRA-11811) dtest failure in snapshot_test.TestArchiveCommitlog.test_archive_commitlog

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown resolved CASSANDRA-11811.
-
Resolution: Fixed

looks like this committed a while back (in Oct 2016). Closing

> dtest failure in snapshot_test.TestArchiveCommitlog.test_archive_commitlog
> --
>
> Key: CASSANDRA-11811
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11811
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Philip Thompson
>Assignee: Jim Witschey
>Priority: Major
>  Labels: dtest
> Fix For: 3.11.x
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_dtest_win32/416/testReport/snapshot_test/TestArchiveCommitlog/test_archive_commitlog
> Failed on CassCI build trunk_dtest_win32 #416
> Relevant error is pasted. This is clearly a test problem. No idea why it only 
> happens on windows, as of yet. Affecting most tests in the 
> TestArchiveCommitlog suite
> {code}
> WARN: Failed to flush node: node1 on shutdown.
> Unexpected error in node1 log, error: 
> ERROR [main] 2016-05-13 21:15:02,701 CassandraDaemon.java:729 - Fatal 
> configuration error
> org.apache.cassandra.exceptions.ConfigurationException: Cannot change the 
> number of tokens from 64 to 32
>   at 
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:1043)
>  ~[main/:na]
>   at 
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:740)
>  ~[main/:na]
>   at 
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:625)
>  ~[main/:na]
>   at 
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:368) 
> [main/:na]
>   at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:583)
>  [main/:na]
>   at 
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:712) 
> [main/:na]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Resolved] (CASSANDRA-14026) Dtest fails ContextSuite context=LWTTester>:setup - net address 127.0.0.3:9042 is not available: [Errno 98] Address already in use;

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown resolved CASSANDRA-14026.
-
Resolution: Won't Fix

closing as this is was an environmen thing under the nosetest system.

> Dtest fails ContextSuite context=LWTTester>:setup - net address 
> 127.0.0.3:9042 is not available: [Errno 98] Address already in use;
> ---
>
> Key: CASSANDRA-14026
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14026
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Michael Kjellman
>Priority: Major
>
> ContextSuite context=LWTTester>:setup -  Inet address 127.0.0.3:9042 is not available: [Errno 98] Address already in 
> use; a cluster may already be running or you may need to add the loopback 
> alias
>  >> begin captured logging << 
> dtest: DEBUG: cluster ccm directory: /tmp/dtest-IxAadk
> dtest: DEBUG: Done setting configuration options:
> {   'initial_token': None,
> 'num_tokens': '32',
> 'phi_convict_threshold': 5,
> 'range_request_timeout_in_ms': 1,
> 'read_request_timeout_in_ms': 1,
> 'request_timeout_in_ms': 1,
> 'truncate_request_timeout_in_ms': 1,
> 'write_request_timeout_in_ms': 1}
> dtest: DEBUG: Done setting configuration options:
> {   'initial_token': None,
> 'num_tokens': '32',
> 'phi_convict_threshold': 5,
> 'range_request_timeout_in_ms': 1,
> 'read_request_timeout_in_ms': 1,
> 'request_timeout_in_ms': 1,
> 'truncate_request_timeout_in_ms': 1,
> 'write_request_timeout_in_ms': 1}
> - >> end captured logging << -
>   File "/home/cassandra/env/local/lib/python2.7/site-packages/nose/suite.py", 
> line 209, in run
> self.setUp()
>   File "/home/cassandra/env/local/lib/python2.7/site-packages/nose/suite.py", 
> line 292, in setUp
> self.setupContext(ancestor)
>   File "/home/cassandra/env/local/lib/python2.7/site-packages/nose/suite.py", 
> line 315, in setupContext
> try_run(context, names)
>   File "/home/cassandra/env/local/lib/python2.7/site-packages/nose/util.py", 
> line 471, in try_run
> return func()
>   File "/home/cassandra/cassandra-dtest/dtest.py", line 1002, in setUpClass
> cls.initialize_cluster()
>   File "/home/cassandra/cassandra-dtest/dtest.py", line 1060, in 
> initialize_cluster
> cls.post_initialize_cluster()
>   File "/home/cassandra/cassandra-dtest/cql_tests.py", line 1232, in 
> post_initialize_cluster
> cluster.start(wait_for_binary_proto=True)
>   File 
> "/home/cassandra/env/local/lib/python2.7/site-packages/ccmlib/cluster.py", 
> line 389, in start
> common.assert_socket_available(itf)
>   File 
> "/home/cassandra/env/local/lib/python2.7/site-packages/ccmlib/common.py", 
> line 519, in assert_socket_available
> raise UnavailableSocketError("Inet address %s:%s is not available: %s; a 
> cluster may already be running or you may need to add the loopback alias" % 
> (addr, port, msg))
> "Inet address 127.0.0.3:9042 is not available: [Errno 98] Address already in 
> use; a cluster may already be running or you may need to add the loopback 
> alias\n >> begin captured logging << 
> \ndtest: DEBUG: cluster ccm directory: 
> /tmp/dtest-IxAadk\ndtest: DEBUG: Done setting configuration options:\n{   
> 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': 
> 5,\n'range_request_timeout_in_ms': 1,\n
> 'read_request_timeout_in_ms': 1,\n'request_timeout_in_ms': 1,\n   
>  'truncate_request_timeout_in_ms': 1,\n'write_request_timeout_in_ms': 
> 1}\ndtest: DEBUG: Done setting configuration options:\n{   
> 'initial_token': None,\n'num_tokens': '32',\n'phi_convict_threshold': 
> 5,\n'range_request_timeout_in_ms': 1,\n
> 'read_request_timeout_in_ms': 1,\n'request_timeout_in_ms': 1,\n   
>  'truncate_request_timeout_in_ms': 1,\n'write_request_timeout_in_ms': 
> 1}\n- >> end captured logging << 
> -"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14049) All auth upgrade dtests are busted

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14049:

Labels: dtest  (was: )

> All auth upgrade dtests are busted
> --
>
> Key: CASSANDRA-14049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14049
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Michael Kjellman
>Priority: Major
>  Labels: dtest
> Attachments: dtest.log.txt
>
>
> All of the upgrade tests that use authentication are busted
> upgrade_to_22_test - upgrade_internal_auth_test.TestAuthUpgrade
> upgrade_to_30_test - upgrade_internal_auth_test.TestAuthUpgrade



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14155) [TRUNK] Gossiper somewhat frequently hitting an NPE on node startup with dtests at org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14155:

Labels: dtest  (was: )

> [TRUNK] Gossiper somewhat frequently hitting an NPE on node startup with 
> dtests at 
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
> 
>
> Key: CASSANDRA-14155
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14155
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Michael Kjellman
>Assignee: Jason Brown
>Priority: Major
>  Labels: dtest
>
> Gossiper is somewhat frequently hitting an NPE on node startup with dtests at 
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769)
> {code}
> test teardown failure
> Unexpected error found in node logs (see stdout for full details). Errors: 
> [ERROR [main] 2018-01-08 21:41:01,832 CassandraDaemon.java:675 - Exception 
> encountered during startup
> java.lang.NullPointerException: null
> at 
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769) 
> ~[main/:na]
> at 
> org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:511)
>  ~[main/:na]
> at 
> org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:761)
>  ~[main/:na]
> at 
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:621)
>  ~[main/:na]
> at 
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:568)
>  ~[main/:na]
> at 
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:360) 
> [main/:na]
> at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
>  [main/:na]
> at 
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:658) 
> [main/:na], ERROR [main] 2018-01-08 21:41:01,832 CassandraDaemon.java:675 - 
> Exception encountered during startup
> java.lang.NullPointerException: null
> at 
> org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:769) 
> ~[main/:na]
> at 
> org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:511)
>  ~[main/:na]
> at 
> org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:761)
>  ~[main/:na]
> at 
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:621)
>  ~[main/:na]
> at 
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:568)
>  ~[main/:na]
> at 
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:360) 
> [main/:na]
> at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
>  [main/:na]
> at 
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:658) 
> [main/:na]]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14157) [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation - cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14157:

Labels: dtest  (was: )

> [DTEST] [TRUNK] test_tracing_does_not_interfere_with_digest_calculation - 
> cql_tracing_test.TestCqlTracing failed once : AssertionError: assert 0 == 1
> -
>
> Key: CASSANDRA-14157
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14157
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Michael Kjellman
>Assignee: Sam Tunnicliffe
>Priority: Major
>  Labels: dtest
>
> test_tracing_does_not_interfere_with_digest_calculation - 
> cql_tracing_test.TestCqlTracing failed it's assertion once today in a 
> circleci run. the dtests were running against trunk.
> Although it has failed once so far, a quick read of the comments in the test 
> seems to indicate that the assertion failing this way might mean that 
> CASSANDRA-13964 didn't fully fix the issue.
> {code:python}
> if jmx.has_mbean(rr_count):
> # expect 0 digest mismatches
> >   assert 0 == jmx.read_attribute(rr_count, 'Count')
> E   AssertionError: assert 0 == 1
> E+  where 1 =   0x7f62d4156898>>('org.apache.cassandra.metrics:type=ReadRepair,name=RepairedBlocking',
>  'Count')
> E+where  > = 
> .read_attribute
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14526) dtest to validate Cassandra state post failed/successful bootstrap

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14526:

Labels: dtest  (was: )

> dtest to validate Cassandra state post failed/successful bootstrap
> --
>
> Key: CASSANDRA-14526
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14526
> Project: Cassandra
>  Issue Type: Sub-task
>Reporter: Jaydeepkumar Chovatia
>Assignee: Jaydeepkumar Chovatia
>Priority: Major
>  Labels: dtest
>
> Please find dtest here:
> || dtest ||
> | [patch 
> |https://github.com/apache/cassandra-dtest/compare/master...jaydeepkumar1984:14526-trunk]|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-13195) Add dtest commit id to the CI builds

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-13195:

Labels: dtest  (was: )

> Add dtest commit id to the CI builds
> 
>
> Key: CASSANDRA-13195
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13195
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Aleksandr Sorokoumov
>Assignee: Michael Shuler
>Priority: Minor
>  Labels: dtest
>
> When investigating on the dtest-related issues, it might be useful to see 
> dtest commit id in the Jenkins logs. AFAIK Jenkins clones dtest master right 
> now.
> For example, it would be a bit easier to tackle some issues like 
> CASSANDRA-13140 because one can immediately reproduce it with the same 
> version of the dtest as used in the build and after that reason about the 
> changes between this revision and the master using git history for the 
> particular test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Resolved] (CASSANDRA-13310) dtest failure in upgrade_tests.regression_test.TestForRegressionsUpgrade_current_2_1_x_To_indev_3_x.test13294

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown resolved CASSANDRA-13310.
-
Resolution: Later

closing in favor of CASSANDRA-14421

> dtest failure in 
> upgrade_tests.regression_test.TestForRegressionsUpgrade_current_2_1_x_To_indev_3_x.test13294
> -
>
> Key: CASSANDRA-13310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13310
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Sean McCarthy
>Priority: Major
>  Labels: dtest, test-failure
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.11_dtest_upgrade/29/testReport/upgrade_tests.regression_test/TestForRegressionsUpgrade_current_2_1_x_To_indev_3_x/test13294
> {code}
> Error Message
> Command '('/usr/lib/jvm/jdk1.8.0_121/bin/java', '-cp', 
> '/usr/lib/jvm/jdk1.8.0_121/lib/tools.jar:lib/jolokia-jvm-1.2.3-agent.jar', 
> 'org.jolokia.jvmagent.client.AgentLauncher', '--host', '127.0.0.1', 'start', 
> '1823')' returned non-zero exit status 1
> {code}{code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/upgrade_tests/regression_test.py", 
> line 110, in test13294
> self.compact_sstable(node1, first_sstable)
>   File "/home/automaton/cassandra-dtest/upgrade_tests/regression_test.py", 
> line 121, in compact_sstable
> with JolokiaAgent(node) as jmx:
>   File "/home/automaton/cassandra-dtest/tools/jmxutils.py", line 314, in 
> __enter__
> self.start()
>   File "/home/automaton/cassandra-dtest/tools/jmxutils.py", line 205, in start
> subprocess.check_output(args, stderr=subprocess.STDOUT)
>   File "/usr/lib/python2.7/subprocess.py", line 574, in check_output
> raise CalledProcessError(retcode, cmd, output=output)
> {code}{code}
> Standard Output
> g...@github.com:apache/cassandra.git 
> github:apache/2b62cb997ed163c85b0cb50e3198935b38aa2fb6
> Failed to start jolokia agent (command was: 
> /usr/lib/jvm/jdk1.8.0_121/bin/java -cp 
> /usr/lib/jvm/jdk1.8.0_121/lib/tools.jar:lib/jolokia-jvm-1.2.3-agent.jar 
> org.jolokia.jvmagent.client.AgentLauncher --host 127.0.0.1 start 1823): 
> Command '('/usr/lib/jvm/jdk1.8.0_121/bin/java', '-cp', 
> '/usr/lib/jvm/jdk1.8.0_121/lib/tools.jar:lib/jolokia-jvm-1.2.3-agent.jar', 
> 'org.jolokia.jvmagent.client.AgentLauncher', '--host', '127.0.0.1', 'start', 
> '1823')' returned non-zero exit status 1
> Exit status was: 1
> Output was: Illegal Argument (command: start) : Cannot attach to process-ID 
> 1823.
> See --help for possible reasons.
> {code}
> Related failures:
> http://cassci.datastax.com/job/cassandra-3.11_dtest_upgrade/29/testReport/upgrade_tests.regression_test/TestForRegressionsUpgrade_current_2_2_x_To_indev_3_x/test13294/
> http://cassci.datastax.com/job/cassandra-3.11_dtest_upgrade/29/testReport/upgrade_tests.regression_test/TestForRegressionsUpgrade_current_3_0_x_To_indev_3_x/test13294/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Resolved] (CASSANDRA-13401) dtest failure in upgrade_tests.regression_test.TestForRegressionsUpgrade_current_3_0_x_To_indev_trunk.test13294

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown resolved CASSANDRA-13401.
-
Resolution: Later

Closing in favor of CASSANDRA-14421

> dtest failure in 
> upgrade_tests.regression_test.TestForRegressionsUpgrade_current_3_0_x_To_indev_trunk.test13294
> ---
>
> Key: CASSANDRA-13401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13401
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Sean McCarthy
>Priority: Major
>  Labels: dtest, test-failure
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_dtest_upgrade/102/testReport/upgrade_tests.regression_test/TestForRegressionsUpgrade_current_3_0_x_To_indev_trunk/test13294
> {code}
> Error Message
> Command '('/usr/lib/jvm/jdk1.8.0_121/bin/java', '-cp', 
> '/usr/lib/jvm/jdk1.8.0_121/lib/tools.jar:lib/jolokia-jvm-1.2.3-agent.jar', 
> 'org.jolokia.jvmagent.client.AgentLauncher', '--host', '127.0.0.1', 'start', 
> '6348')' returned non-zero exit status 1
> {code}{code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/upgrade_tests/regression_test.py", 
> line 110, in test13294
> self.compact_sstable(node1, first_sstable)
>   File "/home/automaton/cassandra-dtest/upgrade_tests/regression_test.py", 
> line 121, in compact_sstable
> with JolokiaAgent(node) as jmx:
>   File "/home/automaton/cassandra-dtest/tools/jmxutils.py", line 314, in 
> __enter__
> self.start()
>   File "/home/automaton/cassandra-dtest/tools/jmxutils.py", line 205, in start
> subprocess.check_output(args, stderr=subprocess.STDOUT)
>   File "/usr/lib/python2.7/subprocess.py", line 574, in check_output
> raise CalledProcessError(retcode, cmd, output=output)
> {code}{code}
> Standard Output
> /home/automaton/cassandra/ 
> local:/home/automaton/cassandra/:add855ae177d28d02f1172fb0070ef487237ead5
> Failed to start jolokia agent (command was: 
> /usr/lib/jvm/jdk1.8.0_121/bin/java -cp 
> /usr/lib/jvm/jdk1.8.0_121/lib/tools.jar:lib/jolokia-jvm-1.2.3-agent.jar 
> org.jolokia.jvmagent.client.AgentLauncher --host 127.0.0.1 start 6348): 
> Command '('/usr/lib/jvm/jdk1.8.0_121/bin/java', '-cp', 
> '/usr/lib/jvm/jdk1.8.0_121/lib/tools.jar:lib/jolokia-jvm-1.2.3-agent.jar', 
> 'org.jolokia.jvmagent.client.AgentLauncher', '--host', '127.0.0.1', 'start', 
> '6348')' returned non-zero exit status 1
> Exit status was: 1
> Output was: Illegal Argument (command: start) : Cannot attach to process-ID 
> 6348.
> See --help for possible reasons.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Resolved] (CASSANDRA-13461) Update circle.yml to run dtests and utests in parallel across containers

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown resolved CASSANDRA-13461.
-
Resolution: Implemented

we've been running circleci test in parallel for quite a while now, so just 
going to close this ticket. Reopen if I've missed something

> Update circle.yml to run dtests and utests in parallel across containers
> 
>
> Key: CASSANDRA-13461
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13461
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Ariel Weisberg
>Assignee: Ariel Weisberg
>Priority: Major
>
> I have a circle.yml that parallelizes the dtests and utests over the 4 free 
> available containers. It can be tweaked to support however many containers 
> are available.
> The unit tests pass normally. The dtests run mostly normally. There are 10 or 
> so tests that fail on trunk, but 30 that fail when run in CircleCI. It's 
> still better than not running the dtests IMO. I am currently working on 
> figuring out why the test failures don't match.
> {noformat}
> version: 2
> jobs:
>   build:
> resource_class: xlarge
> working_directory: ~/
> parallelism: 4
> docker:
>   - image: ubuntu:xenial-20170410
> steps:
>   - run:
>   name: apt-get install packages
>   command: |
> echo "deb http://ppa.launchpad.net/webupd8team/java/ubuntu xenial 
> main" | tee /etc/apt/sources.list.d/webupd8team-java.list
> echo "deb-src http://ppa.launchpad.net/webupd8team/java/ubuntu 
> xenial main" | tee -a /etc/apt/sources.list.d/webupd8team-java.list
> apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 
> EEA14886
> echo oracle-java8-installer shared/accepted-oracle-license-v1-1 
> select true | /usr/bin/debconf-set-selections
> apt-get update
> apt-get install -y git-core npm python python-pip python-dev ant 
> ant-optional oracle-java8-installer net-tools
> ln -s /usr/bin/nodejs /usr/bin/node || true
>   - run:
>   name: Log environment information
>   command: |
>   echo '*** id ***'
>   id
>   echo '*** cat /proc/cpuinfo ***'
>   cat /proc/cpuinfo
>   echo '*** free -m ***'
>   free -m
>   echo '*** df -m ***'
>   df -m
>   echo '*** ifconfig -a ***'
>   ifconfig -a
>   echo '*** uname -a ***'
>   uname -a
>   echo '*** mount ***'
>   mount
>   echo '*** env ***'
>   env
>   - run:
>   name: Clone git repos
>   command: |
> git clone --single-branch --depth 1 
> https://github.com/riptano/cassandra-dtest ~/cassandra-dtest
> git clone --single-branch --depth 1 --branch $CIRCLE_BRANCH 
> git://github.com/$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME.git 
> ~/cassandra
>   - run:
>   name: Install junit-merge
>   command: npm install -g junit-merge
>   - run:
>   name: Install virtualenv
>   command: pip install virtualenv 
>   - run:
>   name: Configure virtualenv and python dependencies
>   command: |
> virtualenv --python=python2 --no-site-packages venv
> source venv/bin/activate
> export CASS_DRIVER_NO_EXTENSIONS=true
> export CASS_DRIVER_NO_CYTHON=true
> pip install -r ~/cassandra-dtest/requirements.txt
> pip freeze
>   - run:
>   name: Build Cassandra
>   command: |
> cd ~/cassandra
> # Loop to prevent failure due to maven-ant-tasks not downloading 
> a jar..
> for x in $(seq 1 3); do
> ant clean jar
> RETURN="$?"
> if [ "${RETURN}" -eq "0" ]; then
> break
> fi
> done
> # Exit, if we didn't build successfully
> if [ "${RETURN}" -ne "0" ]; then
> echo "Build failed with exit code: ${RETURN}"
> exit ${RETURN}
> fi
>   no_output_timeout: 20m
>   - run:
>   name: Determine tests to run
>   no_output_timeout: 10m
>   command: |
> #"$HOME/cassandra-dtest/**/*.py"
> echo `circleci tests glob "$HOME/cassandra/test/unit/**" 
> "$HOME/cassandra-dtest/**/*.py" | grep -v upgrade_tests | grep -v 
> "cassandra-thrift" | grep -v "thrift_bindings" | grep -v "tools" | grep -v 
> "dtest.py" | grep -v "$HOME/cassandra-dtest/bin" | grep -v "plugins" | 
> circleci tests split --split-by=timings --timings-type=filename` > 
> 

[jira] [Updated] (CASSANDRA-13768) auth_test.py dtest fails intermittently due to thread race condition

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-13768:

Labels: dtest  (was: )

> auth_test.py dtest fails intermittently due to thread race condition
> 
>
> Key: CASSANDRA-13768
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13768
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Jaydeepkumar Chovatia
>Assignee: Jaydeepkumar Chovatia
>Priority: Minor
>  Labels: dtest
>
> *Root cause:* dtest {{auth_test.TestAuth.system_auth_ks_is_alterable_test}} 
> is failing intermittently and it is due to race condition between Python 
> driver continuously sending cql query (by thread t1) to know status of 
> cluster, and {{ccm}} is stopping the nodes (by thread t2)
> *Failure details:* 
> http://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_dtest/lastCompletedBuild/testReport/auth_test/TestAuth/system_auth_ks_is_alterable_test/
> *Solution:* Ignore {{UnavailableException}} for this particular test as it is 
> not going to harm test case in anyway.
> Please find snippet of C* log when test fails:
> {{INFO [InternalResponseStage:8] 2017-08-15 10:44:13,213 
> RepairRunnable.java:337 - Repair command #2 finished in 0 seconds INFO 
> [GossipStage:1] 2017-08-15 10:44:13,601 Gossiper.java:1019 - InetAddress 
> /127.0.0.1 is now DOWN INFO [HANDSHAKE-/127.0.0.1] 2017-08-15 10:44:13,715 
> OutboundTcpConnection.java:564 - Handshaking version with /127.0.0.1 INFO 
> [SharedPool-Worker-2] 2017-08-15 10:44:16,712 Message.java:512 - Received: 
> OPTIONS, v=4 INFO [SharedPool-Worker-2] 2017-08-15 10:44:16,713 
> Message.java:512 - Received: STARTUP {CQL_VERSION=3.4.0, COMPRESSION=snappy}, 
> v=4 INFO [SharedPool-Worker-2] 2017-08-15 10:44:16,719 Message.java:512 - 
> Received: org.apache.cassandra.transport.messages.AuthResponse@4474c719, v=4 
> INFO [GossipStage:1] 2017-08-15 10:44:16,723 Gossiper.java:1019 - InetAddress 
> /127.0.0.3 is now DOWN ERROR [SharedPool-Worker-2] 2017-08-15 10:44:16,822 
> Message.java:621 - Unexpected exception during request; channel = [id: 
> 0xffc2fc9a, L:/127.0.0.2:9042 - R:/127.0.0.2:51369] 
> java.lang.RuntimeException: 
> org.apache.cassandra.exceptions.UnavailableException: Cannot achieve 
> consistency level QUORUM at 
> org.apache.cassandra.auth.CassandraRoleManager.getRole(CassandraRoleManager.java:516)
>  ~[main/:na] at 
> org.apache.cassandra.auth.CassandraRoleManager.canLogin(CassandraRoleManager.java:310)
>  ~[main/:na] at 
> org.apache.cassandra.service.ClientState.login(ClientState.java:270) 
> ~[main/:na] at 
> org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:79)
>  ~[main/:na] at 
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:513)
>  [main/:na] at 
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:407)
>  [main/:na] at 
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
>  [netty-all-4.0.44.Final.jar:4.0.44.Final] at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:357)
>  [netty-all-4.0.44.Final.jar:4.0.44.Final] at 
> io.netty.channel.AbstractChannelHandlerContext.access$600(AbstractChannelHandlerContext.java:35)
>  [netty-all-4.0.44.Final.jar:4.0.44.Final] at 
> io.netty.channel.AbstractChannelHandlerContext$7.run(AbstractChannelHandlerContext.java:348)
>  [netty-all-4.0.44.Final.jar:4.0.44.Final] at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_144] at 
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:164)
>  [main/:na] at 
> org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) [main/:na] 
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_144] Caused by: 
> org.apache.cassandra.exceptions.UnavailableException: Cannot achieve 
> consistency level QUORUM at 
> org.apache.cassandra.db.ConsistencyLevel.assureSufficientLiveNodes(ConsistencyLevel.java:334)
>  ~[main/:na] at 
> org.apache.cassandra.service.AbstractReadExecutor.getReadExecutor(AbstractReadExecutor.java:162)
>  ~[main/:na] at 
> org.apache.cassandra.service.StorageProxy$SinglePartitionReadLifecycle.(StorageProxy.java:1733)
>  ~[main/:na] at 
> org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:1696) 
> ~[main/:na] at 
> org.apache.cassandra.service.StorageProxy.readRegular(StorageProxy.java:1640) 
> ~[main/:na] at 
> org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:1544) 
> ~[main/:na] at 
> org.apache.cassandra.db.SinglePartitionReadCommand$Group.execute(SinglePartitionReadCommand.java:965)
>  

[jira] [Resolved] (CASSANDRA-13978) dtest failure in cqlsh_tests/cqlsh_tests.py:TestCqlsh.test_pep8_compliance due to deprecation warning

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown resolved CASSANDRA-13978.
-
Resolution: Implemented

looks like pycodestyle was added in CASSANDRA-14134

> dtest failure in cqlsh_tests/cqlsh_tests.py:TestCqlsh.test_pep8_compliance 
> due to deprecation warning
> -
>
> Key: CASSANDRA-13978
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13978
> Project: Cassandra
>  Issue Type: Test
>  Components: Testing
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadinasab
>Priority: Trivial
>  Labels: dtest, lhf, low-hanging-fruit
>
> The dtest {{cqlsh_tests/cqlsh_tests.py:TestCqlsh.test_pep8_compliance}} fails 
> on all branches with pep8 package version 1.7.1. The pep8 package has been 
> deprecated and renamed pycodestyle.
> {code}
> ==
> FAIL: test_pep8_compliance (cqlsh_tests.cqlsh_tests.TestCqlsh)
> --
> Traceback (most recent call last):
>   File "/home/jkni/projects/cassandra-dtest/tools/decorators.py", line 48, in 
> wrapped
> f(obj)
>   File "/home/jkni/projects/cassandra-dtest/cqlsh_tests/cqlsh_tests.py", line 
> 68, in test_pep8_compliance
> self.assertEqual(len(stderr), 0, stderr)
> AssertionError: 
> /home/jkni/projects/cassandra-dtest/venv/lib/python2.7/site-packages/pep8.py:2124:
>  UserWarning: 
> pep8 has been renamed to pycodestyle (GitHub issue #466)
> Use of the pep8 tool will be removed in a future release.
> Please install and use `pycodestyle` instead.
> $ pip install pycodestyle
> $ pycodestyle ...
>   '\n\n'
> {code}
> We should update this dependency from pep8 to pycodestyle. With this change, 
> several new errors are thrown. I don't know if these are new checks that we 
> should choose to ignore, false positives due to new behaviors, or false 
> negatives that are now successfully caught. If they were previously false 
> negatives, we'll need to fix these in cqlsh on some branches.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14018) All dtests in bootstrap_test that call _base_bootstrap_test will cause nose to deadlock

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14018:

Labels: dtest  (was: )

> All dtests in bootstrap_test that call _base_bootstrap_test will cause nose 
> to deadlock
> ---
>
> Key: CASSANDRA-14018
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14018
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Michael Kjellman
>Priority: Major
>  Labels: dtest
>
> Any of the dtests that eventually call BaseBootstrapTest#_base_bootstrap_test 
> will hang forever
> this includes:
> bootstrap_test: simple_bootstrap_test_with_ssl
> bootstrap_test: simple_bootstrap_test
> bootstrap_test: bootstrap_on_write_survey_test
> I've added debug logging after the tests finish their last assert and that 
> reliably is logged.. debugging with gdb has been futile so far. The hang is 
> on a futext inside nose during test teardown. I believe it might have 
> something to do with the threads we spin up for the cleanup (compaction 
> cleanup) that prevents the test cleanup from finishing because we hang 
> waiting for the threads to exit and they never do.
> Until we get these tests fixed we should disable them as they will always 
> fail and cause dtest runs to be very long and painful to run.
> simple_bootstrap_test_with_ssl-novnodes (bootstrap_test.TestBootstrap) ... 
> cluster ccm directory: /tmp/dtest-ors2iY
> Done setting configuration options:
> {   'num_tokens': None,
> 'phi_convict_threshold': 5,
> 'range_request_timeout_in_ms': 1,
> 'read_request_timeout_in_ms': 1,
> 'request_timeout_in_ms': 1,
> 'truncate_request_timeout_in_ms': 1,
> 'write_request_timeout_in_ms': 1}
> ***using internode ssl***
> generating keystore.jks in [/tmp/dtest-ors2iY]
> exporting cert from keystore.jks in [/tmp/dtest-ors2iY]
> Certificate stored in file 
> importing cert into truststore.jks in [/tmp/dtest-ors2iY]
> Certificate was added to keystore
> [node1, node2] tokens: [-9223372036854775808, 0]
> node1 empty size : 130.73
> node1 size before bootstrapping node2: 747.61
> node1 size after cleanup: 473.43
> node1 size after compacting: 447.91
> node2 size after compacting: 434.44



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-13978) dtest failure in cqlsh_tests/cqlsh_tests.py:TestCqlsh.test_pep8_compliance due to deprecation warning

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-13978:

Labels: dtest lhf low-hanging-fruit  (was: lhf low-hanging-fruit)

> dtest failure in cqlsh_tests/cqlsh_tests.py:TestCqlsh.test_pep8_compliance 
> due to deprecation warning
> -
>
> Key: CASSANDRA-13978
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13978
> Project: Cassandra
>  Issue Type: Test
>  Components: Testing
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadinasab
>Priority: Trivial
>  Labels: dtest, lhf, low-hanging-fruit
>
> The dtest {{cqlsh_tests/cqlsh_tests.py:TestCqlsh.test_pep8_compliance}} fails 
> on all branches with pep8 package version 1.7.1. The pep8 package has been 
> deprecated and renamed pycodestyle.
> {code}
> ==
> FAIL: test_pep8_compliance (cqlsh_tests.cqlsh_tests.TestCqlsh)
> --
> Traceback (most recent call last):
>   File "/home/jkni/projects/cassandra-dtest/tools/decorators.py", line 48, in 
> wrapped
> f(obj)
>   File "/home/jkni/projects/cassandra-dtest/cqlsh_tests/cqlsh_tests.py", line 
> 68, in test_pep8_compliance
> self.assertEqual(len(stderr), 0, stderr)
> AssertionError: 
> /home/jkni/projects/cassandra-dtest/venv/lib/python2.7/site-packages/pep8.py:2124:
>  UserWarning: 
> pep8 has been renamed to pycodestyle (GitHub issue #466)
> Use of the pep8 tool will be removed in a future release.
> Please install and use `pycodestyle` instead.
> $ pip install pycodestyle
> $ pycodestyle ...
>   '\n\n'
> {code}
> We should update this dependency from pep8 to pycodestyle. With this change, 
> several new errors are thrown. I don't know if these are new checks that we 
> should choose to ignore, false positives due to new behaviors, or false 
> negatives that are now successfully caught. If they were previously false 
> negatives, we'll need to fix these in cqlsh on some branches.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14468) "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16

2018-07-24 Thread Aleksey Yeschenko (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554361#comment-16554361
 ] 

Aleksey Yeschenko commented on CASSANDRA-14468:
---

[~wadey] [~jrwest] You are right with your analysis. I'm sorry I missed this 
one during CASSANDRA-12516 review. The good news is that it should be trivial 
to fix (unless I'm missing something).

All we need to do is skip interning in {{SchemaKeyspace.createColumnFromRow()}}.

> "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16
> -
>
> Key: CASSANDRA-14468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14468
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Wade Simmons
>Priority: Major
> Attachments: data.tar.gz
>
>
> I am attempting to upgrade from Cassandra 2.2.10 to 3.0.16. I am getting this 
> error:
> {code}
> org.apache.cassandra.exceptions.ConfigurationException: Unable to parse 
> targets for index idx_foo ("666f6f")
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.parseTarget(CassandraIndex.java:800)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.indexCfsMetadata(CassandraIndex.java:747)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.scrubDataDirectories(ColumnFamilyStore.java:645)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:251) 
> [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
>  [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:697) 
> [apache-cassandra-3.0.16.jar:3.0.16]
> {code}
> It looks like this might be related to CASSANDRA-14104 that was just added to 
> 3.0.16 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14078) Fix dTest test_bulk_round_trip_blogposts_with_max_connections

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14078:

Labels: dtest  (was: )

> Fix dTest test_bulk_round_trip_blogposts_with_max_connections
> -
>
> Key: CASSANDRA-14078
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14078
> Project: Cassandra
>  Issue Type: Test
>  Components: Testing
>Reporter: Jaydeepkumar Chovatia
>Assignee: Jaydeepkumar Chovatia
>Priority: Minor
>  Labels: dtest
>
> This ticket is regarding following dTest 
> {{cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_bulk_round_trip_blogposts_with_max_connections}}
> This test is trying to limit number of client connections and assumes that 
> once connection count has reached then client will fail-over to other node 
> and do the request. The reason is, it is not deterministic test case as it 
> totally depends on what hardware you run, timing, etc.
> For example
> If we look at 
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/353/testReport/cqlsh_tests.cqlsh_copy_tests/CqlshCopyTest/test_bulk_round_trip_blogposts_with_max_connections/
> {quote}
> ...
> Processed: 5000 rows; Rate:2551 rows/s; Avg. rate:2551 rows/s
> All replicas busy, sleeping for 4 second(s)...
> Processed: 1 rows; Rate:2328 rows/s; Avg. rate:2307 rows/s
> All replicas busy, sleeping for 1 second(s)...
> Processed: 15000 rows; Rate:2137 rows/s; Avg. rate:2173 rows/s
> All replicas busy, sleeping for 11 second(s)...
> Processed: 2 rows; Rate:2138 rows/s; Avg. rate:2164 rows/s
> Processed: 25000 rows; Rate:2403 rows/s; Avg. rate:2249 rows/s
> Processed: 3 rows; Rate:2582 rows/s; Avg. rate:2321 rows/s
> Processed: 35000 rows; Rate:2835 rows/s; Avg. rate:2406 rows/s
> Processed: 4 rows; Rate:2867 rows/s; Avg. rate:2458 rows/s
> Processed: 45000 rows; Rate:3163 rows/s; Avg. rate:2540 rows/s
> Processed: 5 rows; Rate:3200 rows/s; Avg. rate:2596 rows/s
> Processed: 50234 rows; Rate:2032 rows/s; Avg. rate:2572 rows/s
> All replicas busy, sleeping for 23 second(s)...
> Replicas too busy, given up
> ...
> {quote}
> Here we can see request is timing out, sometimes it resumes after 1 second, 
> next time 11 seconds and some times it doesn't work at all. 
> In my opinion this test is not a good fit for dTest as dTest(s) should be 
> deterministic.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14156) [DTEST] [TRUNK] TestTopology.movement_test is flaky; fails assert "values not within 16.00% of the max: (851.41, 713.26)"

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14156:

Labels: dtest  (was: )

> [DTEST] [TRUNK] TestTopology.movement_test is flaky; fails assert "values not 
> within 16.00% of the max: (851.41, 713.26)"
> -
>
> Key: CASSANDRA-14156
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14156
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Michael Kjellman
>Assignee: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> DTest* TestTopology.test_movement* is flaky. All of the testing so far (and 
> thus all of the current known observed failures) have been when running 
> against trunk. When the test fails, it always due to the assert_almost_equal 
> assert.
> {code}
> AssertionError: values not within 16.00% of the max: (851.41, 713.26) ()
> {code}
> The following CircleCI runs are 2 examples with dtests runs that failed due 
> to this test failing it's assert:
> [https://circleci.com/gh/mkjellman/cassandra/487]
> [https://circleci.com/gh/mkjellman/cassandra/526]
> *p.s.* assert_almost_equal has a comment "@params error Optional margin of 
> error. Default 0.16". I don't see any obvious notes for why the default is 
> this magical 16% number. It looks like it was committed as part of a big bulk 
> commit by Sean McCarthy (who I can't find on JIRA). If anyone has any history 
> on the magic 16% allowed delta please share!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14187) [DTEST] repair_tests/repair_test.py:TestRepair.simple_sequential_repair_test

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14187:

Labels: dtest  (was: )

> [DTEST] repair_tests/repair_test.py:TestRepair.simple_sequential_repair_test
> 
>
> Key: CASSANDRA-14187
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14187
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> Getting all rows from a node times out.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14371) dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14371:

Labels: dtest  (was: )

> dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
> 
>
> Key: CASSANDRA-14371
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14371
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Patrick Bannister
>Priority: Major
>  Labels: dtest
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/489/testReport/sstablesplit_test/TestSSTableSplit/test_single_file_split/
> {code}
> for (stdout, stderr, rc) in result:
> logger.debug(stderr)
> >   failure = stderr.find("java.lang.AssertionError: Data component 
> > is missing")
> E   TypeError: a bytes-like object is required, not 'str'
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14420) dtests not determining C* version correctly

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14420:

Labels: dtest  (was: )

> dtests not determining C* version correctly
> ---
>
> Key: CASSANDRA-14420
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14420
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Major
>  Labels: dtest
>
> In the course of CASSANDRA-14134, the means of extracting the C* version 
> under test before starting a cluster became broken. This is necessary in 
> cases where we want to gate values in cassandra.yaml based on version, so a 
> couple of tests are affected. The specifics are that the global 
> {{CASSANDRA_VERSION_FROM_BUILD}} was hardcoded to '4.0' and the ways in which 
> the various tests use it have meant that it was undetected until now.
> Also, the {{fixture_since}} which we use to implement the {{@since}} 
> annotation is broken when a {{--cassandra-version}} is supplied, rather than 
> {{--cassandra-dir}}, meaning testing against released versions from git isn't 
> working right now.
> Tests directly affected:
>  * {{auth_test.py}} - CASSANDRA-13985 added some gating of yaml props and 
> additional checks on CQL results based on the build version. These failed on 
> 3.11, which is how this issue was uncovered, but they're also broken on 2.2 
> on builds.apache.org
>  * {{user_functions_test.py}} - gates setting a yaml property when version < 
> 3.0. Failing on 2.2.
>  * {{upgrade_tests}} - a number of these use the variable, but I don't think 
> they're actually being run at the moment.
>  * {{repair_tests/repair_test.py}}, {{replace_address_test.py}} & 
> {{thrift_test}} all use the global, but only to verify that the version is 
> not 3.9. As we're not running CI for that version, no-one noticed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14429) Flaky dTest: bootstrap_test.TestBootstrap.test_local_quorum_bootstrap

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14429:

Labels: Testing dtest  (was: Testing)

> Flaky dTest: bootstrap_test.TestBootstrap.test_local_quorum_bootstrap
> -
>
> Key: CASSANDRA-14429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14429
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Jay Zhuang
>Priority: Major
>  Labels: Testing, dtest
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/lastCompletedBuild/testReport/bootstrap_test/TestBootstrap/test_local_quorum_bootstrap/
> {noformat}
> Failed 13 times in the last 30 runs. Flakiness: 41%, Stability: 56%
> Error Message
> Failed: Timeout >900.0s
> Stacktrace
> self = 
> def test_local_quorum_bootstrap(self):
> """
> Test that CL local_quorum works while a node is bootstrapping.
> @jira_ticket CASSANDRA-8058
> """
> cluster = self.cluster
> cluster.populate([1, 1])
> cluster.start()
> 
> node1 = cluster.nodes['node1']
> yaml_config = """
> # Create the keyspace and table
> keyspace: keyspace1
> keyspace_definition: |
>   CREATE KEYSPACE keyspace1 WITH replication = {'class': 
> 'NetworkTopologyStrategy', 'dc1': 1, 'dc2': 1};
> table: users
> table_definition:
>   CREATE TABLE users (
> username text,
> first_name text,
> last_name text,
> email text,
> PRIMARY KEY(username)
>   ) WITH compaction = {'class':'SizeTieredCompactionStrategy'};
> insert:
>   partitions: fixed(1)
>   batchtype: UNLOGGED
> queries:
>   read:
> cql: select * from users where username = ?
> fields: samerow
> """
> with tempfile.NamedTemporaryFile(mode='w+') as stress_config:
> stress_config.write(yaml_config)
> stress_config.flush()
> node1.stress(['user', 'profile=' + stress_config.name, 'n=2M', 
> 'no-warmup',
> > 'ops(insert=1)', '-rate', 'threads=50'])
> bootstrap_test.py:439: 
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> _ 
> ../venv/src/ccm/ccmlib/node.py:1339: in stress
> return handle_external_tool_process(p, ['stress'] + stress_options)
> ../venv/src/ccm/ccmlib/node.py:2101: in handle_external_tool_process
> out, err = process.communicate()
> /usr/lib/python3.6/subprocess.py:843: in communicate
> stdout, stderr = self._communicate(input, endtime, timeout)
> /usr/lib/python3.6/subprocess.py:1514: in _communicate
> ready = selector.select(timeout)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> _ 
> self = , timeout = None
> def select(self, timeout=None):
> if timeout is None:
> timeout = None
> elif timeout <= 0:
> timeout = 0
> else:
> # poll() has a resolution of 1 millisecond, round away from
> # zero to wait *at least* timeout seconds.
> timeout = math.ceil(timeout * 1e3)
> ready = []
> try:
> >   fd_event_list = self._poll.poll(timeout)
> E   Failed: Timeout >900.0s
> /usr/lib/python3.6/selectors.py:376: Failed
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14430) Flaky dTest: repair_tests.repair_test.TestRepair.test_simple_sequential_repair

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14430:

Labels: dtest  (was: )

> Flaky dTest:  
> repair_tests.repair_test.TestRepair.test_simple_sequential_repair
> ---
>
> Key: CASSANDRA-14430
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14430
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Jay Zhuang
>Priority: Major
>  Labels: dtest
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/lastCompletedBuild/testReport/repair_tests.repair_test/TestRepair/test_simple_sequential_repair/
>  
> {noformat}
> Failed 5 times in the last 30 runs. Flakiness: 24%, Stability: 83%
> Error Message
> cassandra.cluster.NoHostAvailable: ('Unable to complete the operation against 
> any hosts', {: ConnectionException('Host has 
> been marked down or removed',), : 
> ConnectionException('Pool is shutdown',)})
> Stacktrace
> self = 
> def test_simple_sequential_repair(self):
> """
> Calls simple repair test with a sequential repair
> """
> >   self._simple_repair(sequential=True)
> repair_tests/repair_test.py:350: 
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> _ 
> repair_tests/repair_test.py:440: in _simple_repair
> self._populate_cluster()
> repair_tests/repair_test.py:115: in _populate_cluster
> insert_c1c2(session, keys=list(range(1001, 2001)), 
> consistency=ConsistencyLevel.ALL)
> tools/data.py:29: in insert_c1c2
> execute_concurrent_with_args(session, statement, [['k{}'.format(k)] for k 
> in keys])
> ../venv/src/cassandra-driver/cassandra/concurrent.py:239: in 
> execute_concurrent_with_args
> return execute_concurrent(session, zip(cycle((statement,)), parameters), 
> *args, **kwargs)
> ../venv/src/cassandra-driver/cassandra/concurrent.py:95: in execute_concurrent
> return executor.execute(concurrency, raise_on_first_error)
> ../venv/src/cassandra-driver/cassandra/concurrent.py:202: in execute
> return super(ConcurrentExecutorListResults, self).execute(concurrency, 
> fail_fast)
> ../venv/src/cassandra-driver/cassandra/concurrent.py:121: in execute
> return self._results()
> ../venv/src/cassandra-driver/cassandra/concurrent.py:220: in _results
> self._raise(self._exception)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> _ 
> exc = NoHostAvailable('Unable to complete the operation against any hosts', 
> {: ConnectionException('Host has been marked 
> down or removed',), : ConnectionException('Pool 
> is shutdown',)})
> @staticmethod
> def _raise(exc):
> if six.PY2 and isinstance(exc, tuple):
> (exc_type, value, traceback) = exc
> six.reraise(exc_type, value, traceback)
> else:
> >   raise exc
> E   cassandra.cluster.NoHostAvailable: ('Unable to complete the 
> operation against any hosts', {: 
> ConnectionException('Host has been marked down or removed',),  127.0.0.3 datacenter1>: ConnectionException('Pool is shutdown',)})
> ../venv/src/cassandra-driver/cassandra/concurrent.py:168: NoHostAvailable
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14484) Flaky dtest: nodetool_test.TestNodetool.test_describecluster_more_information_three_datacenters

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14484:

Labels: dtest  (was: )

> Flaky dtest: 
> nodetool_test.TestNodetool.test_describecluster_more_information_three_datacenters
> ---
>
> Key: CASSANDRA-14484
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14484
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/541/testReport/junit/nodetool_test/TestNodetool/test_describecluster_more_information_three_datacenters/
> {code}
> AssertionError: assert 'Cluster Info...1=3, dc3=1}\n' == 'Cluster 
> Infor...1=3, dc3=1}\n' Cluster Information:  Name: test  Snitch: 
> org.apache.cassandra.locator.PropertyFileSnitch  DynamicEndPointSnitch: 
> enabled  Partitioner: org.apache.cassandra.dht.Murmur3Partitioner  
> Schema versions:   37963ad1-c76f-3155-b164-88e3a1b7a86b: [127.0.0.6, 
> 127.0.0.5, 127.0.0.4, 127.0.0.3, 127.0.0.2, 127.0.0.1]  Stats for all 
> nodes:  Live: 6  Joining: 0  Moving: 0  Leaving: 0  
> Unreachable: 0  Data Centers:   dc1 #Nodes: 2 #Down: 0  dc2 
> #Nodes: 3 #Down: 0  dc3 #Nodes: 1 #Down: 0  Database versions:
>   4.0.0: [127.0.0.6:7000, 127.0.0.5:7000, 127.0.0.4:7000, 127.0.0.3:7000, 
> 127.0.0.2:7000, 127.0.0.1:7000]  Keyspaces:  system_schema -> 
> Replication class: LocalStrategy {}  system -> Replication class: 
> LocalStrategy {}  system_traces -> Replication class: SimpleStrategy 
> {replication_factor=2}   +  system_auth -> Replication class: SimpleStrategy 
> {replication_factor=1}  system_distributed -> Replication class: 
> SimpleStrategy {replication_factor=3}   -  system_auth -> Replication class: 
> SimpleStrategy {replication_factor=1}  ks1 -> Replication class: 
> NetworkTopologyStrategy {dc2=5, dc1=3, dc3=1}  ks2 -> Replication class: 
> NetworkTopologyStrategy {dc2=5, dc1=3, dc3=1}
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14535) dtest for checking orphan hint files post node removal

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14535:

Labels: dtest  (was: )

> dtest for checking orphan hint files post node removal
> --
>
> Key: CASSANDRA-14535
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14535
> Project: Cassandra
>  Issue Type: Sub-task
>  Components: Testing
>Reporter: Jaydeepkumar Chovatia
>Assignee: Jaydeepkumar Chovatia
>Priority: Minor
>  Labels: dtest
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14558) dtest: log-watching thread leak and thread starvation

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14558:

Labels: dtest  (was: )

> dtest: log-watching thread leak and thread starvation
> -
>
> Key: CASSANDRA-14558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14558
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
>Priority: Major
>  Labels: dtest
>
> We get occasional build timeouts on b.a.o after pytest becomes unresponsive 
> for over 20 minutes. This will result in a thread dump like this one:
> [https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-2.2-dtest/117/consoleFull]
> If you look for "Log-watching thread starting" messages and the dump, it 
> becomes quite obvious whats the issue here.
> I had a quick look at the python3 / pytest related changes in CASSANDRA-14134 
> and it seems that some of the handling around dtest_setup's 
> {{log_watch_thread}} var has been changed in a way that would prevent 
> eventually yielding the allocated thread.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14583:

Labels: dtest  (was: )

> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>  Labels: dtest
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> INTERNALERROR> self.runner.pytest_runtest_protocol(item, nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 64, in pytest_runtest_protocol
> INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 79, in runtestprotocol
> INTERNALERROR> reports.append(call_and_report(item, "call", log))
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 120, in call_and_report
> INTERNALERROR> report = hook.pytest_runtest_makereport(item=item, 
> call=call)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> 

[jira] [Updated] (CASSANDRA-14542) Deselect no_offheap_memtables dtests

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14542:

Labels: dtest  (was: )

> Deselect no_offheap_memtables dtests
> 
>
> Key: CASSANDRA-14542
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14542
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Minor
>  Labels: dtest
>
> After the large rework of dtests in CASSANDRA-14134, one task left undone was 
> to enable running dtests with offheap memtables. That was resolved in 
> CASSANDRA-14056. However, there are a few tests explicitly marked as 
> "no_offheap_memtables", and we should respect that marking when running the 
> dtests with offheap memtables enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14545) dtests: fix pytest.raises argument names

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14545:

Labels: dtest  (was: )

> dtests: fix pytest.raises argument names
> 
>
> Key: CASSANDRA-14545
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14545
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
>Priority: Major
>  Labels: dtest
> Attachments: CASSANDRA-14545.patch
>
>
> I've been through a couple of [dtest 
> results|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/580/#showFailuresLink]
>  lately and notices some interpreter errors regarding how we call 
> pytest.raises. The 
> [reference|https://docs.pytest.org/en/latest/assert.html#assertions-about-expected-exceptions]
>  is pretty clear on what would be the correct arguments, but still want to 
> make sure we're not working on different pytest versions. 
> [~mkjellman] can you quickly check the following inconsistencies and look at 
> my patch (msg->message, matches->match)?
> {noformat}
> git show 49b2dda4 |egrep 'raises.*, m' {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14552) Website: Add Static Blogging / Article Publishing to cassandra.apache.org

2018-07-24 Thread C. Scott Andreas (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554307#comment-16554307
 ] 

C. Scott Andreas commented on CASSANDRA-14552:
--

Thanks Nate!

> Website: Add Static Blogging / Article Publishing to cassandra.apache.org
> -
>
> Key: CASSANDRA-14552
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14552
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: C. Scott Andreas
>Assignee: C. Scott Andreas
>Priority: Minor
> Attachments: blog-post-listing.png, blog-post.png, blog.diff
>
>
> To make it easier for members of the community to share what's happening in 
> Apache Cassandra, advertise meetups, and publish other article-style content, 
> this patch enables simple blogging functionality via the static 
> cassandra.apache.org site.
>  
> *How does it work?*
> The patch uses Jekyll's built-in static blog functionality to add 
> article-style publishing. It adds no dynamic content, and does not include 
> commenting or a mechanism for accepting any user-generated content. It makes 
> the following changes:
> – Adds a new layout file for a blog post listing and single-post detail view 
> (+ supporting CSS).
>  – Enables pagination of posts via `jekyll-paginate-v2`
>  – Adds documentation on how to contribute.
>  – And fixes a minor documentation issue specifying a Ruby version that 
> conflicts with earlier guidance in the documentation.
>  
> *How do I write a post?*
> The patch includes a /_templates folder with an example post to begin. Blog 
> posts are written using Markdown. To write a new post, copy the template into 
> /_posts, rename the file in keeping with the 
> `MM-DD--blog-post-slug.markdown` convention, add the title/date, and 
> begin writing.
> These pages are generated via the existing build process documented in the 
> README – `make serve` to preview, `make` to publish.
>  
> *What else should I know?*
> The aim of this patch is to make it easy to write and publish. The "/blog" 
> link is currently hidden from the top nav and no posts are included in this 
> patch, but this can be enabled once the first article is ready.
>  
> *What's it look like?*
> Screenshots of the generated post list view and single-post view attached.
> !blog-post-listing.png|width=592,height=619!
>  
> !blog-post.png|width=592,height=619!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Assigned] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread Marcus Eriksson (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson reassigned CASSANDRA-14583:
---

Assignee: Marcus Eriksson

> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Major
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> INTERNALERROR> self.runner.pytest_runtest_protocol(item, nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 64, in pytest_runtest_protocol
> INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 79, in runtestprotocol
> INTERNALERROR> reports.append(call_and_report(item, "call", log))
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 120, in call_and_report
> INTERNALERROR> report = hook.pytest_runtest_makereport(item=item, 
> call=call)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return 

[jira] [Updated] (CASSANDRA-14545) dtests: fix pytest.raises argument names

2018-07-24 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14545:

Status: Ready to Commit  (was: Patch Available)

> dtests: fix pytest.raises argument names
> 
>
> Key: CASSANDRA-14545
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14545
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
>Priority: Major
> Attachments: CASSANDRA-14545.patch
>
>
> I've been through a couple of [dtest 
> results|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/580/#showFailuresLink]
>  lately and notices some interpreter errors regarding how we call 
> pytest.raises. The 
> [reference|https://docs.pytest.org/en/latest/assert.html#assertions-about-expected-exceptions]
>  is pretty clear on what would be the correct arguments, but still want to 
> make sure we're not working on different pytest versions. 
> [~mkjellman] can you quickly check the following inconsistencies and look at 
> my patch (msg->message, matches->match)?
> {noformat}
> git show 49b2dda4 |egrep 'raises.*, m' {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14545) dtests: fix pytest.raises argument names

2018-07-24 Thread Jason Brown (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554170#comment-16554170
 ] 

Jason Brown commented on CASSANDRA-14545:
-

[~mkjellman] isn't around these days, so I've taken a look. Double checked 
{{master}} for other {{msg}}/{{matches}} and this patch got them all. I also 
checked the pytest source to make sure {{match}}/{{message}} are the correct 
param names (they are).

+1

> dtests: fix pytest.raises argument names
> 
>
> Key: CASSANDRA-14545
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14545
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
>Priority: Major
> Attachments: CASSANDRA-14545.patch
>
>
> I've been through a couple of [dtest 
> results|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/580/#showFailuresLink]
>  lately and notices some interpreter errors regarding how we call 
> pytest.raises. The 
> [reference|https://docs.pytest.org/en/latest/assert.html#assertions-about-expected-exceptions]
>  is pretty clear on what would be the correct arguments, but still want to 
> make sure we're not working on different pytest versions. 
> [~mkjellman] can you quickly check the following inconsistencies and look at 
> my patch (msg->message, matches->match)?
> {noformat}
> git show 49b2dda4 |egrep 'raises.*, m' {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread Marcus Eriksson (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554169#comment-16554169
 ] 

Marcus Eriksson commented on CASSANDRA-14583:
-

[~jasobrown] 3.0, but looks similar on 2.2 and 3.11: 
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-2.2-dtest/120/console
 
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-3.11-dtest/346/console

> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Priority: Major
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> INTERNALERROR> self.runner.pytest_runtest_protocol(item, nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 64, in pytest_runtest_protocol
> INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 79, in runtestprotocol
> INTERNALERROR> reports.append(call_and_report(item, "call", log))
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 120, in call_and_report
> INTERNALERROR> report = 

[jira] [Commented] (CASSANDRA-14583) [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift

2018-07-24 Thread Jason Brown (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554164#comment-16554164
 ] 

Jason Brown commented on CASSANDRA-14583:
-

[~krummas] What version of c* was this against?

> [DTEST] fix write_failures_test.py::TestWriteFailures::test_thrift
> --
>
> Key: CASSANDRA-14583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14583
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Marcus Eriksson
>Priority: Major
>
> seems it needs a {{WITH COMPACT STORAGE}} to avoid failing like this:
> {code}
> write_failures_test.py::TestWriteFailures::test_thrift swapoff: Not superuser.
> 01:23:57,245 ccm DEBUG Log-watching thread starting.
> INTERNALERROR> Traceback (most recent call last):
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 178, in wrap_session
> INTERNALERROR> session.exitstatus = doit(config, session) or 0
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 215, in _main
> INTERNALERROR> config.hook.pytest_runtestloop(session=session)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/main.py", 
> line 236, in pytest_runtestloop
> INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, 
> nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> return self._hookexec(self, self._nonwrappers + 
> self._wrappers, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 222, in _hookexec
> INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 216, in 
> INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'),
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 201, in _multicall
> INTERNALERROR> return outcome.get_result()
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 76, in get_result
> INTERNALERROR> raise ex[1].with_traceback(ex[2])
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/callers.py",
>  line 180, in _multicall
> INTERNALERROR> res = hook_impl.function(*args)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 81, in pytest_runtest_protocol
> INTERNALERROR> self.runner.pytest_runtest_protocol(item, nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 64, in pytest_runtest_protocol
> INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/_pytest/runner.py",
>  line 79, in runtestprotocol
> INTERNALERROR> reports.append(call_and_report(item, "call", log))
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py",
>  line 120, in call_and_report
> INTERNALERROR> report = hook.pytest_runtest_makereport(item=item, 
> call=call)
> INTERNALERROR>   File 
> "/home/cassandra/cassandra/venv/lib/python3.6/site-packages/pluggy/__init__.py",
>  line 617, in __call__
> INTERNALERROR> 

[jira] [Commented] (CASSANDRA-9608) Support Java 11

2018-07-24 Thread Robert Stupp (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554159#comment-16554159
 ] 

Robert Stupp commented on CASSANDRA-9608:
-

[~jasobrown] the ccm fix is in ccm's master and cassandra-test branches (thanks 
to [~philipthompson]). Can you trigger the dtests again?

> Support Java 11
> ---
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
>  Issue Type: Task
>Reporter: Robert Stupp
>Assignee: Robert Stupp
>Priority: Minor
> Fix For: 4.x
>
> Attachments: jdk_9_10.patch
>
>
> This ticket is intended to group all issues found to support Java 9 in the 
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved. 
> It can be easily solved using this patch:
> {code}
> - artifactId="cobertura"/>
> + artifactId="cobertura">
> +  
> +
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods 
> {{monitorEnter}} + {{monitorExit}}. These methods are used by 
> {{o.a.c.utils.concurrent.Locks}} which is only used by 
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early 
> development phase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14468) "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16

2018-07-24 Thread Aleksey Yeschenko (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554107#comment-16554107
 ] 

Aleksey Yeschenko commented on CASSANDRA-14468:
---

Ugh. This is both unfortunate and tricky. Let me think how we can mitigate this.

> "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16
> -
>
> Key: CASSANDRA-14468
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14468
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Wade Simmons
>Priority: Major
> Attachments: data.tar.gz
>
>
> I am attempting to upgrade from Cassandra 2.2.10 to 3.0.16. I am getting this 
> error:
> {code}
> org.apache.cassandra.exceptions.ConfigurationException: Unable to parse 
> targets for index idx_foo ("666f6f")
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.parseTarget(CassandraIndex.java:800)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.index.internal.CassandraIndex.indexCfsMetadata(CassandraIndex.java:747)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.scrubDataDirectories(ColumnFamilyStore.java:645)
>  ~[apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:251) 
> [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:569)
>  [apache-cassandra-3.0.16.jar:3.0.16]
>   at 
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:697) 
> [apache-cassandra-3.0.16.jar:3.0.16]
> {code}
> It looks like this might be related to CASSANDRA-14104 that was just added to 
> 3.0.16 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Resolved] (CASSANDRA-14552) Website: Add Static Blogging / Article Publishing to cassandra.apache.org

2018-07-24 Thread Nate McCall (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nate McCall resolved CASSANDRA-14552.
-
Resolution: Fixed

> Website: Add Static Blogging / Article Publishing to cassandra.apache.org
> -
>
> Key: CASSANDRA-14552
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14552
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: C. Scott Andreas
>Assignee: C. Scott Andreas
>Priority: Minor
> Attachments: blog-post-listing.png, blog-post.png, blog.diff
>
>
> To make it easier for members of the community to share what's happening in 
> Apache Cassandra, advertise meetups, and publish other article-style content, 
> this patch enables simple blogging functionality via the static 
> cassandra.apache.org site.
>  
> *How does it work?*
> The patch uses Jekyll's built-in static blog functionality to add 
> article-style publishing. It adds no dynamic content, and does not include 
> commenting or a mechanism for accepting any user-generated content. It makes 
> the following changes:
> – Adds a new layout file for a blog post listing and single-post detail view 
> (+ supporting CSS).
>  – Enables pagination of posts via `jekyll-paginate-v2`
>  – Adds documentation on how to contribute.
>  – And fixes a minor documentation issue specifying a Ruby version that 
> conflicts with earlier guidance in the documentation.
>  
> *How do I write a post?*
> The patch includes a /_templates folder with an example post to begin. Blog 
> posts are written using Markdown. To write a new post, copy the template into 
> /_posts, rename the file in keeping with the 
> `MM-DD--blog-post-slug.markdown` convention, add the title/date, and 
> begin writing.
> These pages are generated via the existing build process documented in the 
> README – `make serve` to preview, `make` to publish.
>  
> *What else should I know?*
> The aim of this patch is to make it easy to write and publish. The "/blog" 
> link is currently hidden from the top nav and no posts are included in this 
> patch, but this can be enabled once the first article is ready.
>  
> *What's it look like?*
> Screenshots of the generated post list view and single-post view attached.
> !blog-post-listing.png|width=592,height=619!
>  
> !blog-post.png|width=592,height=619!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14552) Website: Add Static Blogging / Article Publishing to cassandra.apache.org

2018-07-24 Thread Nate McCall (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553949#comment-16553949
 ] 

Nate McCall commented on CASSANDRA-14552:
-

Can confirm jekyll publishing steps work and README looks good. Committed to 
svn repo as revision 1836533.

> Website: Add Static Blogging / Article Publishing to cassandra.apache.org
> -
>
> Key: CASSANDRA-14552
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14552
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: C. Scott Andreas
>Assignee: C. Scott Andreas
>Priority: Minor
> Attachments: blog-post-listing.png, blog-post.png, blog.diff
>
>
> To make it easier for members of the community to share what's happening in 
> Apache Cassandra, advertise meetups, and publish other article-style content, 
> this patch enables simple blogging functionality via the static 
> cassandra.apache.org site.
>  
> *How does it work?*
> The patch uses Jekyll's built-in static blog functionality to add 
> article-style publishing. It adds no dynamic content, and does not include 
> commenting or a mechanism for accepting any user-generated content. It makes 
> the following changes:
> – Adds a new layout file for a blog post listing and single-post detail view 
> (+ supporting CSS).
>  – Enables pagination of posts via `jekyll-paginate-v2`
>  – Adds documentation on how to contribute.
>  – And fixes a minor documentation issue specifying a Ruby version that 
> conflicts with earlier guidance in the documentation.
>  
> *How do I write a post?*
> The patch includes a /_templates folder with an example post to begin. Blog 
> posts are written using Markdown. To write a new post, copy the template into 
> /_posts, rename the file in keeping with the 
> `MM-DD--blog-post-slug.markdown` convention, add the title/date, and 
> begin writing.
> These pages are generated via the existing build process documented in the 
> README – `make serve` to preview, `make` to publish.
>  
> *What else should I know?*
> The aim of this patch is to make it easy to write and publish. The "/blog" 
> link is currently hidden from the top nav and no posts are included in this 
> patch, but this can be enabled once the first article is ready.
>  
> *What's it look like?*
> Screenshots of the generated post list view and single-post view attached.
> !blog-post-listing.png|width=592,height=619!
>  
> !blog-post.png|width=592,height=619!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



svn commit: r1836533 - in /cassandra/site/src: README _config.yml _includes/footer.html _includes/nav.html _layouts/blog.html _layouts/post.html _templates/ _templates/2018-06-22-blog_post_template.ma

2018-07-24 Thread zznate
Author: zznate
Date: Tue Jul 24 08:18:17 2018
New Revision: 1836533

URL: http://svn.apache.org/viewvc?rev=1836533=rev
Log:
CASSANDRA-14552 - Adding blog support patch from cscotta

Added:
cassandra/site/src/_layouts/blog.html
cassandra/site/src/_layouts/post.html
cassandra/site/src/_templates/
cassandra/site/src/_templates/2018-06-22-blog_post_template.markdown
cassandra/site/src/blog/
cassandra/site/src/blog/index.html
Modified:
cassandra/site/src/README
cassandra/site/src/_config.yml
cassandra/site/src/_includes/footer.html
cassandra/site/src/_includes/nav.html
cassandra/site/src/css/style.scss

Modified: cassandra/site/src/README
URL: 
http://svn.apache.org/viewvc/cassandra/site/src/README?rev=1836533=1836532=1836533=diff
==
--- cassandra/site/src/README (original)
+++ cassandra/site/src/README Tue Jul 24 08:18:17 2018
@@ -24,12 +24,12 @@ rbenv install 2.4.2
 
 # Associate with Cassandra svn directory
 cd ~/svn/cassandra-site # change as needed
-rbenv local 2.4.1
+rbenv local 2.4.2
 which rbenv # should point to shim
 ruby --version
 
 # Install jekyll with local rbenv version
-gem install jekyll -v 3.4.3
+gem install jekyll:3.4.3 jekyll-paginate-v2
 jekyll --version
 
 
@@ -117,3 +117,13 @@ And that's mostly what there is to it. I
any such directory when generated its result. In practice, this means we 
have to force manually force the inclusion
of those sphinx directories we want to include so Jekyll doesn't skip them, 
which is done in the _config.yml Jekyll
configuration file (the only sphinx dir we care about so far is _images).
+
+Contributing a Blog Post
+
+To contribute a new blog post, create a new Markdown file in /_posts, using
+_templates/2018-06-22-blog_post_template.markdown as a template. Follow the 
-MM-DD-blog-post-slug.markdown filename
+convention, and annotate your post using the yaml frontmatter of the Markdown 
file (this functionality is provided by
+Jekyll).
+
+Follow the instructions above during development -- `make serve` for local 
development, and `make` to generate the final
+product.
\ No newline at end of file

Modified: cassandra/site/src/_config.yml
URL: 
http://svn.apache.org/viewvc/cassandra/site/src/_config.yml?rev=1836533=1836532=1836533=diff
==
--- cassandra/site/src/_config.yml (original)
+++ cassandra/site/src/_config.yml Tue Jul 24 08:18:17 2018
@@ -19,6 +19,8 @@ exclude: [ Makefile, README ]
 include:
   - _images
 
+gems:
+  - jekyll-paginate-v2
 
 # Build settings
 markdown: kramdown
@@ -27,3 +29,12 @@ kramdown:
   input: GFM
   syntax_highlighter: rouge
   hard_wrap: false
+
+# Pagination threshold for blog post listings
+pagination:
+  enabled: true
+  per_page: 5
+  title: ' - page :num'
+  limit: 0
+  sort_field: 'date'
+  sort_reverse: true

Modified: cassandra/site/src/_includes/footer.html
URL: 
http://svn.apache.org/viewvc/cassandra/site/src/_includes/footer.html?rev=1836533=1836532=1836533=diff
==
--- cassandra/site/src/_includes/footer.html (original)
+++ cassandra/site/src/_includes/footer.html Tue Jul 24 08:18:17 2018
@@ -1,3 +1,5 @@
+
+
 
   
 

Modified: cassandra/site/src/_includes/nav.html
URL: 
http://svn.apache.org/viewvc/cassandra/site/src/_includes/nav.html?rev=1836533=1836532=1836533=diff
==
--- cassandra/site/src/_includes/nav.html (original)
+++ cassandra/site/src/_includes/nav.html Tue Jul 24 08:18:17 2018
@@ -59,6 +59,7 @@
   Download
   Documentation
   Community
+  
 
   
 

Added: cassandra/site/src/_layouts/blog.html
URL: 
http://svn.apache.org/viewvc/cassandra/site/src/_layouts/blog.html?rev=1836533=auto
==
--- cassandra/site/src/_layouts/blog.html (added)
+++ cassandra/site/src/_layouts/blog.html Tue Jul 24 08:18:17 2018
@@ -0,0 +1,33 @@
+---
+layout: default
+---
+
+  
+{{ content }}
+
+  {% for post in paginator.posts %}
+
+  {{ post.title }}
+  Posted on {{ post.date | date: '%B %d, %Y' }} by {{ post.author 
}}
+  {{ post.excerpt }}
+  Read more 
+
+  {% endfor %}
+
+
+  {% if paginator.total_pages > 1 %}
+  
+{% if paginator.previous_page %}
+
+   Newer Posts
+
+{% endif %}
+{% if paginator.next_page %}
+
+  Older Posts 
+
+{% endif %}
+  
+  {% endif %}
+  
+

Added: cassandra/site/src/_layouts/post.html
URL: 
http://svn.apache.org/viewvc/cassandra/site/src/_layouts/post.html?rev=1836533=auto
==
--- 

[jira] [Created] (CASSANDRA-14585) For compactions to progress when pending is greater than 10K cassandra must be continuously restarted and compactions_in_progress purged

2018-07-24 Thread Zachary Schneider (JIRA)
Zachary Schneider created CASSANDRA-14585:
-

 Summary: For compactions to progress when pending is greater than 
10K cassandra must be continuously restarted and compactions_in_progress purged
 Key: CASSANDRA-14585
 URL: https://issues.apache.org/jira/browse/CASSANDRA-14585
 Project: Cassandra
  Issue Type: Bug
  Components: Compaction
 Environment: Apache Cassandra 2.2.12
Reporter: Zachary Schneider


We are experiencing the following behavior when utilizing DTCS on nodes that 
join the ring and subsequently have many pending compactions.

The symptoms are the following:

nodetool compactionstats reports compactions progressing, however pending count 
is never significantly reduced.

When investigating we notice the following:

compactions_in_progress is never compacted
{code:java}
find 
/mnt/data/cassandra/data/system/compactions_in_progress-55080ab05d9c388690a4acb25fe1f77b/
 | wc -l
560730
{code}
Eventually we will end up running into to many open files.

In order for compaction to progress we must:
 * truncate compactions_in_progress
 * restart Cassandra

This compactions will progress rapidly 2K or so and eventually the process will 
hang again.

In the debug log we see constant flushes to compactions_in_progress.
{code:java}
DEBUG [CompactionExecutor:10] 2018-07-24 07:39:29,552 
ColumnFamilyStore.java:956 - Enqueuing flush of compactions_in_progress: 428 
(0%) on-heap, 354 (0%) off-heap INFO [MemtableFlushWriter:9] 2018-07-24 
07:39:29,552 Memtable.java:352 - Writing 
Memtable-compactions_in_progress@1407915569(0.263KiB serialized bytes, 12 ops, 
0%/0% of on/off-heap limit) DEBUG [MemtableFlushWriter:9] 2018-07-24 
07:39:29,553 Memtable.java:386 - Completed flushing 
/mnt/data/cassandra/data/system/compactions_in_progress-55080ab05d9c388690a4acb25fe1f77b/tmp-lb-8140-big-Data.db
 (0.000KiB) for commitlog position ReplayPosition(segmentId=1532415927699, 
position=28982298) DEBUG [CompactionExecutor:16] 2018-07-24 07:39:29,595 
ColumnFamilyStore.java:956 - Enqueuing flush of compactions_in_progress: 460 
(0%) on-heap, 397 (0%) off-heap INFO [MemtableFlushWriter:13] 2018-07-24 
07:39:29,595 Memtable.java:352 - Writing 
Memtable-compactions_in_progress@535072625(0.298KiB serialized bytes, 13 ops, 
0%/0% of on/off-heap limit) DEBUG [MemtableFlushWriter:13] 2018-07-24 
07:39:29,595 Memtable.java:386 - Completed flushing 
/mnt/data/cassandra/data/system/compactions_in_progress-55080ab05d9c388690a4acb25fe1f77b/tmp-lb-8141-big-Data.db
 (0.000KiB) for commitlog position ReplayPosition(segmentId=1532415927699, 
position=29708684) DEBUG [CompactionExecutor:15] 2018-07-24 07:39:29,619 
ColumnFamilyStore.java:956 - Enqueuing flush of compactions_in_progress: 428 
(0%) on-heap, 356 (0%) off-heap INFO [MemtableFlushWriter:12] 2018-07-24 
07:39:29,619 Memtable.java:352 - Writing 
Memtable-compactions_in_progress@319301851(0.265KiB serialized bytes, 12 ops, 
0%/0% of on/off-heap limit) DEBUG [MemtableFlushWriter:12] 2018-07-24 
07:39:29,620 Memtable.java:386 - Completed flushing 
/mnt/data/cassandra/data/system/compactions_in_progress-55080ab05d9c388690a4acb25fe1f77b/tmp-lb-8142-big-Data.db
 (0.000KiB) for commitlog position ReplayPosition(segmentId=1532415927699, 
position=30591989) DEBUG [CompactionExecutor:9] 2018-07-24 07:39:29,660 
ColumnFamilyStore.java:956 - Enqueuing flush of compactions_in_progress: 460 
(0%) on-heap, 396 (0%) off-heap INFO [MemtableFlushWriter:15] 2018-07-24 
07:39:29,660 Memtable.java:352 - Writing 
Memtable-compactions_in_progress@1000370375(0.297KiB serialized bytes, 13 ops, 
0%/0% of on/off-heap limit) DEBUG [MemtableFlushWriter:15] 2018-07-24 
07:39:29,660 Memtable.java:386 - Completed flushing 
/mnt/data/cassandra/data/system/compactions_in_progress-55080ab05d9c388690a4acb25fe1f77b/tmp-lb-8143-big-Data.db
 (0.000KiB) for commitlog position ReplayPosition(segmentId=1532415927699, 
position=31558471) DEBUG [CompactionExecutor:14] 2018-07-24 07:39:29,688 
ColumnFamilyStore.java:956 - Enqueuing flush of compactions_in_progress: 460 
(0%) on-heap, 389 (0%) off-heap INFO [MemtableFlushWriter:10] 2018-07-24 
07:39:29,689 Memtable.java:352 - Writing 
Memtable-compactions_in_progress@204811984(0.290KiB serialized bytes, 13 ops, 
0%/0% of on/off-heap limit) DEBUG [MemtableFlushWriter:10] 2018-07-24 
07:39:29,689 Memtable.java:386 - Completed flushing 
/mnt/data/cassandra/data/system/compactions_in_progress-55080ab05d9c388690a4acb25fe1f77b/tmp-lb-8144-big-Data.db
 (0.000KiB) for commitlog position ReplayPosition(segmentId=1532415927699, 
position=32153206)
{code}
 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org