[jira] [Commented] (CASSANDRA-14466) Enable Direct I/O

2019-04-10 Thread Mulugeta Mammo (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814944#comment-16814944
 ] 

Mulugeta Mammo commented on CASSANDRA-14466:


[~snazy] I have created a new pull request for this: 
https://github.com/apache/cassandra/pull/309. Your comments are welcome!

> Enable Direct I/O 
> --
>
> Key: CASSANDRA-14466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14466
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Legacy/Local Write-Read Paths
>Reporter: Mulugeta Mammo
>Priority: Normal
>
> Hi,
> JDK 10 introduced a new API for Direct IO that enables applications to bypass 
> the file system cache and potentially improve performance. Details of this 
> feature can be found at [https://bugs.openjdk.java.net/browse/JDK-8164900].
> This patch uses the JDK 10 API to enable Direct IO for the Cassandra read 
> path. By default, we have disabled this feature; but it can be enabled using 
> a  new configuration parameter, enable_direct_io_for_read_path. We have 
> conducted a Cassandra read-only stress test and measured a throughput gain of 
> up to 60% on flash drives.
> The patch requires JDK 10 Cassandra Support - 
> https://issues.apache.org/jira/browse/CASSANDRA-9608 
> Please review the patch and let us know your feedback.
> Thanks,
> [^direct_io.patch]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14466) Enable Direct I/O

2019-04-10 Thread Mulugeta Mammo (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mulugeta Mammo updated CASSANDRA-14466:
---
Attachment: (was: direct_io.patch)

> Enable Direct I/O 
> --
>
> Key: CASSANDRA-14466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14466
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Legacy/Local Write-Read Paths
>Reporter: Mulugeta Mammo
>Priority: Normal
>
> Hi,
> JDK 10 introduced a new API for Direct IO that enables applications to bypass 
> the file system cache and potentially improve performance. Details of this 
> feature can be found at [https://bugs.openjdk.java.net/browse/JDK-8164900].
> This patch uses the JDK 10 API to enable Direct IO for the Cassandra read 
> path. By default, we have disabled this feature; but it can be enabled using 
> a  new configuration parameter, enable_direct_io_for_read_path. We have 
> conducted a Cassandra read-only stress test and measured a throughput gain of 
> up to 60% on flash drives.
> The patch requires JDK 10 Cassandra Support - 
> https://issues.apache.org/jira/browse/CASSANDRA-9608 
> Please review the patch and let us know your feedback.
> Thanks,
> [^direct_io.patch]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread mck (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814931#comment-16814931
 ] 

mck edited comment on CASSANDRA-15073 at 4/10/19 11:11 PM:
---

bq. After setting it, it at least builds but I still see errors in the IDE. 

How did you set the {{`JAVA8_HOME`}} variable? And did you do a {{right click 
-> Build}} on the project after the variable was set?
What files exist in {{ide/nbproject/private}} ?

bq. Reimporting did not help. 

FTR… netbeans doesn't "import" or setup a project. Everything is just about 
getting the classpath correct (netbeans just re-uses the classpath locations 
that the ant build script creates/uses). The Cassandra codebase relies on jar 
files in {{build/lib/jars/}}, as well as antlr generated classes, so it has to 
be built first. And getting the classpath to a specific JDK version in a 
cross-OS friendly way is a bit awkward, hence the hack against the 
{{`JAVA8_HOME`}} variable. Running the "Build" from inside Netbeans still 
builds Cassandra using ant on the command line in the same way, but in addition 
it picks up the java8 jdk classes it needs in the cassandra classpath.


was (Author: michaelsembwever):
bq. After setting it, it at least builds but I still see errors in the IDE. 

How did you set the {{`JAVA8_HOME`}} variable? And did you do a {{right click 
-> Build}} on the project after the variable was set?
What files exist in {{ide/nbproject/private}} ?

bq. Reimporting did not help. 

FTR… netbeans doesn't "import" or setup a project. Everything is just about 
getting the classpath correct (netbeans just re-uses the classpath locations 
that the ant build script creates/uses). The Cassandra codebase relies on jar 
files in {{build/lib/jars/}}. And getting the classpath to a specific JDK 
version in a cross-OS friendly way is a bit awkward, hence the hack against the 
{{`JAVA8_HOME`}} variable. Running the "Build" from inside Netbeans still 
builds Cassandra using ant on the command line in the same way, but in addition 
it picks up the java8 jdk classes it needs in the cassandra classpath.

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread mck (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814931#comment-16814931
 ] 

mck commented on CASSANDRA-15073:
-

bq. After setting it, it at least builds but I still see errors in the IDE. 

How did you set the {{`JAVA8_HOME`}} variable? And did you do a {{right click 
-> Build}} on the project after the variable was set?
What files exist in {{ide/nbproject/private}} ?

bq. Reimporting did not help. 

FTR… netbeans doesn't "import" or setup a project. Everything is just about 
getting the classpath correct (netbeans just re-uses the classpath locations 
that the ant build script creates/uses). The Cassandra codebase relies on jar 
files in {{build/lib/jars/}}. And getting the classpath to a specific JDK 
version in a cross-OS friendly way is a bit awkward, hence the hack against the 
{{`JAVA8_HOME`}} variable. Running the "Build" from inside Netbeans still 
builds Cassandra using ant on the command line in the same way, but in addition 
it picks up the java8 jdk classes it needs in the cassandra classpath.

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15052) Dtests: Add acceptable warnings to offline tool tests in order to pass them

2019-04-10 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814927#comment-16814927
 ] 

Dinesh Joshi commented on CASSANDRA-15052:
--

[~stefan.miklosovic], I don't see the failure in my test run. It doesn't appear 
on CircleCI. Perhaps we should jump on a call to discuss this further? I'll 
send you an email offline.

> Dtests: Add acceptable warnings to offline tool tests in order to pass them
> ---
>
> Key: CASSANDRA-15052
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15052
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Test/dtest
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
>  Labels: pull-request-available
> Attachments: SPICE-15052.txt
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> I run all dtest suite and test 
> offline_tools_test.py::TestOfflineTools::test_sstablelevelreset has failed 
> because of additional warning logs which were not added into acceptable ones.
> After adding them, test passed fine. I believe added warning messages have 
> nothing to do with test itself, it was reproduced on c5.9xlarge as well as no 
> "regular" notebook.
>  
> https://github.com/apache/cassandra-dtest/pull/47



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814889#comment-16814889
 ] 

Dinesh Joshi commented on CASSANDRA-15073:
--

I did set the {{JAVA8_HOME}}. See my original comment. The build succeeded but 
the project still shows "parsing errors".

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14765) Evaluate Recovery Time on Single Token Cluster Test

2019-04-10 Thread Dinesh Joshi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-14765:
-
Resolution: Done
Status: Resolved  (was: Open)

> Evaluate Recovery Time on Single Token Cluster Test
> ---
>
> Key: CASSANDRA-14765
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14765
> Project: Cassandra
>  Issue Type: Sub-task
>  Components: Legacy/Streaming and Messaging
>Reporter: Joseph Lynch
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Attachments: 3.0.17-4.0.x-Streaming.png, cassandra_streaming.png, 
> image-2018-11-06-13-34-33-108.png, streaming_benchmarking.patch
>
>
> *Setup:*
>  * Cassandra: 6 (2*3 rack) node i3.8xlarge AWS instance (32 cpu cores, 240GB 
> ram) running cassandra trunk with Jason's 14503 changes vs the same footprint 
> running 3.0.17
>  * One datacenter, single tokens
>  * No compression, encryption, or coalescing turned on
> *Test #1:*
> ndbench loaded ~150GB of data per node into a LCS table. Then we killed a 
> node and let a new node stream. With a single token this should be a worst 
> case recovery scenario (only  a few peers to stream from).
> *Result:*
> As the table used LCS and we didn't not have encryption on, the zero copy 
> transfer was used via CASSANDRA-14556. We recovered *150GB in 5 minutes,* 
> going at a consistent rate of about 3 gigabit per second. Theoretically we 
> should be able to get 10 gigabit, but this is still something like an 
> estimated 16x improvement over 3.0.x. We're still running the 3.0.x test for 
> a hard comparison.
> *Follow Ups:*
> We need to get more rigorous measurements (over more terminations), as well 
> as finishing the 3.0.x test. [~sumanth.pasupuleti] and [~djoshi3] are driving 
> this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread mck (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck updated CASSANDRA-15073:

Status: In Progress  (was: Patch Available)

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread mck (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814865#comment-16814865
 ] 

mck commented on CASSANDRA-15073:
-

It is a requirement that the {{`JAVA8_HOME`}} system variable is set, eg in 
your {{~/.bashrc}}
I re-used this to simplify the {{jdk.xml}}, as it's also required to build 
Cassandra on the command line.

Let me go back to the drawing board on this one. Might need to do the jdk 
classpath the normal netbeans way for freeform projects…

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814562#comment-16814562
 ] 

Dinesh Joshi edited comment on CASSANDRA-15073 at 4/10/19 5:47 PM:
---

See the attached screenshot. I get that with a fresh checkout. Looks like 
{{JAVA8_PATH}} is required. After setting it, it at least builds but I still 
see errors in the IDE. Reimporting did not help. See the updated screenshot.

 !netbeans-errors-2.png! 


was (Author: djoshi3):
See the attached screenshot. I get that with a fresh checkout. Looks like 
{{JAVA8_PATH}} is required. After setting it, it at least builds but I still 
see errors in the IDE. Reimporting did not help. See the updated screenshot.

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread Dinesh Joshi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-15073:
-
Attachment: (was: image-2019-04-10-10-46-04-324.png)

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread Dinesh Joshi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-15073:
-
Attachment: (was: netbeans-errors-2.png)

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread Dinesh Joshi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-15073:
-
Attachment: (was: image-2019-04-10-10-46-02-072.png)

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814562#comment-16814562
 ] 

Dinesh Joshi edited comment on CASSANDRA-15073 at 4/10/19 5:46 PM:
---

See the attached screenshot. I get that with a fresh checkout. Looks like 
{{JAVA8_PATH}} is required. After setting it, it at least builds but I still 
see errors in the IDE. Reimporting did not help. See the updated screenshot.


was (Author: djoshi3):
See the attached screenshot. I get that with a fresh checkout. Looks like 
{{JAVA8_PATH}} is required.

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors-2.png, netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814562#comment-16814562
 ] 

Dinesh Joshi edited comment on CASSANDRA-15073 at 4/10/19 5:19 PM:
---

See the attached screenshot. I get that with a fresh checkout. Looks like 
{{JAVA8_PATH}} is required.


was (Author: djoshi3):
See the attached screenshot. I get that with a fresh checkout.

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-13403) nodetool repair breaks SASI index

2019-04-10 Thread ZhaoYang (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-13403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794673#comment-16794673
 ] 

ZhaoYang edited comment on CASSANDRA-13403 at 4/10/19 4:09 PM:
---

[~ifesdjeen] [~benedict] there seems to be a transaction visibility issue. When 
{{repair-rewriter}} prepares to commit, repaired sstables will replace original 
sstable in data tracker and visible for reads while unrepaired sstables are not 
visible for reads.

update: the lifecycle visibility issue is fixed in CASSANDRA-15004


was (Author: jasonstack):
[~ifesdjeen] [~benedict] there seems to be a transaction visibility issue. When 
{{repair-rewriter}} prepares to commit, repaired sstables will replace original 
sstable in data tracker and visible for reads while unrepaired sstables are not 
visible for reads.

> nodetool repair breaks SASI index
> -
>
> Key: CASSANDRA-13403
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13403
> Project: Cassandra
>  Issue Type: Bug
>  Components: Feature/SASI
> Environment: 3.10
>Reporter: Igor Novgorodov
>Assignee: Alex Petrov
>Priority: Normal
>  Labels: patch
> Attachments: 3_nodes_compaction.log, 4_nodes_compaction.log, 
> CASSANDRA-13403.patch, testSASIRepair.patch
>
>
> I've got table:
> {code}
> CREATE TABLE cservice.bulks_recipients (
> recipient text,
> bulk_id uuid,
> datetime_final timestamp,
> datetime_sent timestamp,
> request_id uuid,
> status int,
> PRIMARY KEY (recipient, bulk_id)
> ) WITH CLUSTERING ORDER BY (bulk_id ASC)
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'ALL'}
> AND comment = ''
> AND compaction = {'class': 
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', 
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class': 
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = '99PERCENTILE';
> CREATE CUSTOM INDEX bulk_recipients_bulk_id ON cservice.bulks_recipients 
> (bulk_id) USING 'org.apache.cassandra.index.sasi.SASIIndex';
> {code}
> There are 11 rows in it:
> {code}
> > select * from bulks_recipients;
> ...
> (11 rows)
> {code}
> Let's query by index (all rows have the same *bulk_id*):
> {code}
> > select * from bulks_recipients where bulk_id = 
> > baa94815-e276-4ca4-adda-5b9734e6c4a5;   
> >   
> ...
> (11 rows)
> {code}
> Ok, everything is fine.
> Now i'm doing *nodetool repair --partitioner-range --job-threads 4 --full* on 
> each node in cluster sequentially.
> After it finished:
> {code}
> > select * from bulks_recipients where bulk_id = 
> > baa94815-e276-4ca4-adda-5b9734e6c4a5;
> ...
> (2 rows)
> {code}
> Only two rows.
> While the rows are actually there:
> {code}
> > select * from bulks_recipients;
> ...
> (11 rows)
> {code}
> If i issue an incremental repair on a random node, i can get like 7 rows 
> after index query.
> Dropping index and recreating it fixes the issue. Is it a bug or am i doing 
> the repair the wrong way?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814562#comment-16814562
 ] 

Dinesh Joshi commented on CASSANDRA-15073:
--

See the attached screenshot. I get that with a fresh checkout.

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15073) Apache NetBeans project files

2019-04-10 Thread Dinesh Joshi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-15073:
-
Attachment: netbeans-errors.png

> Apache NetBeans project files
> -
>
> Key: CASSANDRA-15073
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15073
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: mck
>Assignee: mck
>Priority: Low
> Attachments: netbeans-errors.png
>
>
> Provide necessary project files so to be able to open the Cassandra project 
> in Apache NetBeans.
> No additional project functionality is required beyond being able to edit the 
> project's source files. Building the project is still expected to be done via 
> `ant` on the command-line.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14765) Evaluate Recovery Time on Single Token Cluster Test

2019-04-10 Thread Sumanth Pasupuleti (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814528#comment-16814528
 ] 

Sumanth Pasupuleti commented on CASSANDRA-14765:


I agree with [~djoshi3]. We may go ahead and close this.

> Evaluate Recovery Time on Single Token Cluster Test
> ---
>
> Key: CASSANDRA-14765
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14765
> Project: Cassandra
>  Issue Type: Sub-task
>  Components: Legacy/Streaming and Messaging
>Reporter: Joseph Lynch
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Attachments: 3.0.17-4.0.x-Streaming.png, cassandra_streaming.png, 
> image-2018-11-06-13-34-33-108.png, streaming_benchmarking.patch
>
>
> *Setup:*
>  * Cassandra: 6 (2*3 rack) node i3.8xlarge AWS instance (32 cpu cores, 240GB 
> ram) running cassandra trunk with Jason's 14503 changes vs the same footprint 
> running 3.0.17
>  * One datacenter, single tokens
>  * No compression, encryption, or coalescing turned on
> *Test #1:*
> ndbench loaded ~150GB of data per node into a LCS table. Then we killed a 
> node and let a new node stream. With a single token this should be a worst 
> case recovery scenario (only  a few peers to stream from).
> *Result:*
> As the table used LCS and we didn't not have encryption on, the zero copy 
> transfer was used via CASSANDRA-14556. We recovered *150GB in 5 minutes,* 
> going at a consistent rate of about 3 gigabit per second. Theoretically we 
> should be able to get 10 gigabit, but this is still something like an 
> estimated 16x improvement over 3.0.x. We're still running the 3.0.x test for 
> a hard comparison.
> *Follow Ups:*
> We need to get more rigorous measurements (over more terminations), as well 
> as finishing the 3.0.x test. [~sumanth.pasupuleti] and [~djoshi3] are driving 
> this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14412) Restore automatic snapshot of system keyspace during upgrade

2019-04-10 Thread Tommy Stendahl (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814452#comment-16814452
 ] 

Tommy Stendahl commented on CASSANDRA-14412:


It would be nice to have this feature enabled again, it definitely looks like 
it was removed by mistake. Extending this with snapshots of the 
{{system_schema}} is a good thing.

I have looked at the patch and it LGTM with one comment:
 * I think the test case 
{{SystemKeyspaceTest.snapshotSystemKeyspaceIfUpgrading()}} should be extended 
so it also check the snapshot for {{system_schema}}.

otherwise I'm +1 for this.

> Restore automatic snapshot of system keyspace during upgrade
> 
>
> Key: CASSANDRA-14412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14412
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Startup and Shutdown
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Fix For: 4.0
>
>
> Since 2.2, the installed version is compared with the version persisted in 
> system.local (if any) at startup. If these versions differ, the system 
> keyspace is snapshotted before proceeding in order to enable a rollback if 
> any other issue prevents startup from completing. Although the method to 
> perform this check & snapshot is still present in {{SystemKeyspace}}, its 
> only callsite was mistakenly removed from {{CassandraDaemon}} in 
> CASSANDRA-12716.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14904) SSTableloader doesn't understand listening for CQL connections on multiple ports

2019-04-10 Thread Jan Karlsson (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814423#comment-16814423
 ] 

Jan Karlsson commented on CASSANDRA-14904:
--

I scraped together some time to have a look. LGTM for the most part, but I have 
some thoughts.

I have been thinking of the use case where both native_transport_port and the 
native_transport_port_ssl are set.

1. With this patch, the behavior will be that we will always use the 
native_transport_port_ssl if both are set unless overridden by command line. I 
don't necessarily see a problem with that but it might not be very transparent 
behavior. 
2. No matter what we choose to do about this behavior, a test case that tests 
the case of both being set would be good to add.

> SSTableloader doesn't understand listening for CQL connections on multiple 
> ports
> 
>
> Key: CASSANDRA-14904
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14904
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Kurt Greaves
>Assignee: Ian Cleasby
>Priority: Low
> Fix For: 4.0, 3.11.x
>
>
> sstableloader only searches the yaml for native_transport_port, so if 
> native_transport_port_ssl is set and encryption is enabled sstableloader will 
> fail to connect as it will use the non-SSL port for the connection.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14439) ClassCastException with mixed 1.2.18 + 2.0.17 environment

2019-04-10 Thread mck (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck updated CASSANDRA-14439:

Reviewers: mck
   Status: Review In Progress  (was: Patch Available)

> ClassCastException with mixed 1.2.18  + 2.0.17 environment
> --
>
> Key: CASSANDRA-14439
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14439
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Core
> Environment: Mixed 1.2.18  + 2.0.17 environment, used temporarily 
> during incremental migration process.
>Reporter: Dariusz Cieslak
>Assignee: Dariusz Cieslak
>Priority: Low
>  Labels: easyfix
> Attachments: cassandra-class-cast-exception-fix.patch
>
>
> During mixed versions tests I've discovered that mixed 1.2.18  + 2.0.17 
> environment gives the following exception on 2.0.17 node:
> {code}
> java.lang.ClassCastException: org.apache.cassandra.db.SliceByNamesReadCommand 
> cannot be cast to org.apache.cassandra.db.SliceFromReadCommand
> at 
> org.apache.cassandra.db.SliceFromReadCommandSerializer.serializedSize(SliceFromReadCommand.java:242)
> at 
> org.apache.cassandra.db.ReadCommandSerializer.serializedSize(ReadCommand.java:204)
> at 
> org.apache.cassandra.db.ReadCommandSerializer.serializedSize(ReadCommand.java:134)
> at org.apache.cassandra.net.MessageOut.serialize(MessageOut.java:116)
> at 
> org.apache.cassandra.net.OutboundTcpConnection.writeInternal(OutboundTcpConnection.java:251)
> at 
> org.apache.cassandra.net.OutboundTcpConnection.writeConnected(OutboundTcpConnection.java:203)
> at 
> org.apache.cassandra.net.OutboundTcpConnection.run(OutboundTcpConnection.java:151)
> {code}
> The exception is caused by inconsistent commandType handling in 
> ReadCommandSerializer(), 
> {code}
> out.writeByte(newCommand.commandType.serializedValue);
> switch (command.commandType) /// <--- WHY NOT 
> newCommand.commandType -- DCI ???
> {
> case GET_BY_NAMES:
> SliceByNamesReadCommand.serializer.serialize(newCommand, 
> superColumn, out, version);
> break;
> case GET_SLICES:
> SliceFromReadCommand.serializer.serialize(newCommand, 
> superColumn, out, version);
> break;
> default:
> throw new AssertionError();
> }
> {code}
> Proposed fix (also attached as a patch):
> {code}
> diff --git a/src/java/org/apache/cassandra/db/ReadCommand.java 
> b/src/java/org/apache/cassandra/db/ReadCommand.java
> index cadcd7d..f2153e8 100644
> --- a/src/java/org/apache/cassandra/db/ReadCommand.java
> +++ b/src/java/org/apache/cassandra/db/ReadCommand.java
> @@ -153,7 +153,7 @@ class ReadCommandSerializer implements 
> IVersionedSerializer
>  }
>  
>  out.writeByte(newCommand.commandType.serializedValue);
> -switch (command.commandType)
> +switch (newCommand.commandType)
>  {
>  case GET_BY_NAMES:
>  SliceByNamesReadCommand.serializer.serialize(newCommand, 
> superColumn, out, version);
> @@ -196,7 +196,7 @@ class ReadCommandSerializer implements 
> IVersionedSerializer
>  }
>  }
>  
> -switch (command.commandType)
> +switch (newCommand.commandType)
>  {
>  case GET_BY_NAMES:
>  return 1 + 
> SliceByNamesReadCommand.serializer.serializedSize(newCommand, superColumn, 
> version);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14907) cassandra-stress does not work with frozen collections: list, set

2019-04-10 Thread mck (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck updated CASSANDRA-14907:

Fix Version/s: (was: 4.0.x)
   (was: 3.11.x)
   (was: 3.0.x)
   4.0
   3.11.5
   3.0.19
Since Version: 2.1 rc3
   Status: Resolved  (was: Ready to Commit)
   Resolution: Fixed

> cassandra-stress does not work with frozen collections: list, set
> -
>
> Key: CASSANDRA-14907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14907
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/stress
>Reporter: ZhaoYang
>Assignee: ZhaoYang
>Priority: Low
> Fix For: 3.0.19, 3.11.5, 4.0
>
> Attachments: stress_14907.cql, stress_14907.yaml
>
>
> {code}
> com.datastax.driver.core.exceptions.InvalidQueryException: Invalid operation 
> (f_list = f_list + ?) for frozen collection column f_list
> {code}
> | patch | utest |
> | 
> [3.0|https://github.com/jasonstack/cassandra/commits/stress_frozen_collection_3.0]
>  | [circle|https://circleci.com/gh/jasonstack/cassandra/745] |
> This patch should apply cleanly.. {{Map}} is not supported yet..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14907) cassandra-stress does not work with frozen collections: list, set

2019-04-10 Thread mck (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814384#comment-16814384
 ] 

mck commented on CASSANDRA-14907:
-

Committed as 4a70a9a982f8b34b4ccc7744c074863aa1c5b63b

> cassandra-stress does not work with frozen collections: list, set
> -
>
> Key: CASSANDRA-14907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14907
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/stress
>Reporter: ZhaoYang
>Assignee: ZhaoYang
>Priority: Low
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Attachments: stress_14907.cql, stress_14907.yaml
>
>
> {code}
> com.datastax.driver.core.exceptions.InvalidQueryException: Invalid operation 
> (f_list = f_list + ?) for frozen collection column f_list
> {code}
> | patch | utest |
> | 
> [3.0|https://github.com/jasonstack/cassandra/commits/stress_frozen_collection_3.0]
>  | [circle|https://circleci.com/gh/jasonstack/cassandra/745] |
> This patch should apply cleanly.. {{Map}} is not supported yet..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14907) cassandra-stress does not work with frozen collections: list, set

2019-04-10 Thread mck (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck updated CASSANDRA-14907:

Status: Ready to Commit  (was: Review In Progress)

> cassandra-stress does not work with frozen collections: list, set
> -
>
> Key: CASSANDRA-14907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14907
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/stress
>Reporter: ZhaoYang
>Assignee: ZhaoYang
>Priority: Low
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Attachments: stress_14907.cql, stress_14907.yaml
>
>
> {code}
> com.datastax.driver.core.exceptions.InvalidQueryException: Invalid operation 
> (f_list = f_list + ?) for frozen collection column f_list
> {code}
> | patch | utest |
> | 
> [3.0|https://github.com/jasonstack/cassandra/commits/stress_frozen_collection_3.0]
>  | [circle|https://circleci.com/gh/jasonstack/cassandra/745] |
> This patch should apply cleanly.. {{Map}} is not supported yet..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk

2019-04-10 Thread mck
This is an automated email from the ASF dual-hosted git repository.

mck pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git

commit 7d6c3cd2bd6a399069e68a23a93c583bd4aee127
Merge: 2d622e0 8c38b20
Author: Mick Semb Wever 
AuthorDate: Wed Apr 10 21:39:02 2019 +1000

Merge branch 'cassandra-3.11' into trunk

 CHANGES.txt | 1 +
 tools/stress/src/org/apache/cassandra/stress/StressProfile.java | 5 +
 2 files changed, 6 insertions(+)



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11

2019-04-10 Thread mck
This is an automated email from the ASF dual-hosted git repository.

mck pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git

commit 8c38b203437d554df58bad0efb00527d9a58cce2
Merge: a82603a 4a70a9a
Author: Mick Semb Wever 
AuthorDate: Wed Apr 10 21:13:24 2019 +1000

Merge branch 'cassandra-3.0' into cassandra-3.11

 CHANGES.txt | 1 +
 tools/stress/src/org/apache/cassandra/stress/StressProfile.java | 5 +
 2 files changed, 6 insertions(+)

diff --cc CHANGES.txt
index 1d3ff85,8ee7e06..9fecc40
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,6 -1,6 +1,7 @@@
 -3.0.19
 +3.11.5
 + * Add flag to disable SASI indexes, and warnings on creation 
(CASSANDRA-14866)
 +Merged from 3.0:
+  * cassandra-stress works with frozen collections: list and set 
(CASSANDRA-14907)
 - * For nodetool listsnapshots output, put spaces between columns, and 
increase snapshot padding (CASSANDRA-14876)
   * Fix handling FS errors on writing and reading flat files - LogTransaction 
and hints (CASSANDRA-15053)
   * Avoid double closing the iterator to avoid overcounting the number of 
requests (CASSANDRA-15058)
   * Improve `nodetool status -r` speed (CASSANDRA-14847)
diff --cc tools/stress/src/org/apache/cassandra/stress/StressProfile.java
index 9c0be4e,0b0d4e9..ad10499
--- a/tools/stress/src/org/apache/cassandra/stress/StressProfile.java
+++ b/tools/stress/src/org/apache/cassandra/stress/StressProfile.java
@@@ -506,54 -374,50 +506,59 @@@ public class StressProfile implements S
  maybeLoadSchemaInfo(settings);
  
  Set keyColumns = 
com.google.common.collect.Sets.newHashSet(tableMetaData.getPrimaryKey());
 -
 -//Non PK Columns
 -StringBuilder sb = new StringBuilder();
 -
 -sb.append("UPDATE \"").append(tableName).append("\" SET 
");
 -
 -//PK Columns
 -StringBuilder pred = new StringBuilder();
 -pred.append(" WHERE ");
 -
 -boolean firstCol = true;
 -boolean firstPred = true;
 -for (ColumnMetadata c : tableMetaData.getColumns())
 +Set allColumns = 
com.google.common.collect.Sets.newHashSet(tableMetaData.getColumns());
 +boolean isKeyOnlyTable = (keyColumns.size() == 
allColumns.size());
 +//With compact storage
 +if (!isKeyOnlyTable && (keyColumns.size() == 
(allColumns.size() - 1)))
  {
 -
 -if (keyColumns.contains(c))
 +com.google.common.collect.Sets.SetView diff = 
com.google.common.collect.Sets.difference(allColumns, keyColumns);
 +for (Object obj : diff)
  {
 -if (firstPred)
 -firstPred = false;
 -else
 -pred.append(" AND ");
 -
 -pred.append(c.getName()).append(" = ?");
 +ColumnMetadata col = (ColumnMetadata)obj;
 +isKeyOnlyTable = col.getName().isEmpty();
 +break;
  }
 -else
 -{
 -if (firstCol)
 -firstCol = false;
 -else
 -sb.append(",");
 -
 -sb.append(c.getName()).append(" = ");
 +}
  
 -switch (c.getType().getName())
 -{
 +//Non PK Columns
 +StringBuilder sb = new StringBuilder();
 +if (!isKeyOnlyTable)
 +{
 +sb.append("UPDATE 
").append(quoteIdentifier(tableName)).append(" SET ");
 +//PK Columns
 +StringBuilder pred = new StringBuilder();
 +pred.append(" WHERE ");
 +
 +boolean firstCol = true;
 +boolean firstPred = true;
 +for (ColumnMetadata c : tableMetaData.getColumns()) {
 +
 +if (keyColumns.contains(c)) {
 +if (firstPred)
 +firstPred = false;
 +else
 +pred.append(" AND ");
 +
 +
pred.append(quoteIdentifier(c.getName())).append(" = ?");
 +} else {
 +if (firstCol)
 +firstCol = false;
 +else
 +

[cassandra] branch cassandra-3.0 updated: support frozen collections: list, set in cassandra-stress

2019-04-10 Thread mck
This is an automated email from the ASF dual-hosted git repository.

mck pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
 new 4a70a9a  support frozen collections: list, set in cassandra-stress
4a70a9a is described below

commit 4a70a9a982f8b34b4ccc7744c074863aa1c5b63b
Author: Zhao Yang 
AuthorDate: Wed Nov 21 19:44:53 2018 +0800

support frozen collections: list, set in cassandra-stress

patch by ZhaoYang ; reviewed by Mick Semb Wever for CASSANDRA-14907
---
 CHANGES.txt | 1 +
 tools/stress/src/org/apache/cassandra/stress/StressProfile.java | 5 +
 2 files changed, 6 insertions(+)

diff --git a/CHANGES.txt b/CHANGES.txt
index 492bc1c..8ee7e06 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.19
+ * cassandra-stress works with frozen collections: list and set 
(CASSANDRA-14907)
  * For nodetool listsnapshots output, put spaces between columns, and increase 
snapshot padding (CASSANDRA-14876)
  * Fix handling FS errors on writing and reading flat files - LogTransaction 
and hints (CASSANDRA-15053)
  * Avoid double closing the iterator to avoid overcounting the number of 
requests (CASSANDRA-15058)
diff --git a/tools/stress/src/org/apache/cassandra/stress/StressProfile.java 
b/tools/stress/src/org/apache/cassandra/stress/StressProfile.java
index c19e0cd..0b0d4e9 100644
--- a/tools/stress/src/org/apache/cassandra/stress/StressProfile.java
+++ b/tools/stress/src/org/apache/cassandra/stress/StressProfile.java
@@ -411,6 +411,11 @@ public class StressProfile implements Serializable
 {
 case SET:
 case LIST:
+if (c.getType().isFrozen())
+{
+sb.append("?");
+break;
+}
 case COUNTER:
 sb.append(c.getName()).append(" + ?");
 break;


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch trunk updated (2d622e0 -> 7d6c3cd)

2019-04-10 Thread mck
This is an automated email from the ASF dual-hosted git repository.

mck pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git.


from 2d622e0  Merge branch 'cassandra-3.11' into trunk
 new 4a70a9a  support frozen collections: list, set in cassandra-stress
 new 8c38b20  Merge branch 'cassandra-3.0' into cassandra-3.11
 new 7d6c3cd  Merge branch 'cassandra-3.11' into trunk

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 CHANGES.txt | 1 +
 tools/stress/src/org/apache/cassandra/stress/StressProfile.java | 5 +
 2 files changed, 6 insertions(+)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch cassandra-3.11 updated (a82603a -> 8c38b20)

2019-04-10 Thread mck
This is an automated email from the ASF dual-hosted git repository.

mck pushed a change to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git.


from a82603a  Merge branch 'cassandra-3.0' into cassandra-3.11
 new 4a70a9a  support frozen collections: list, set in cassandra-stress
 new 8c38b20  Merge branch 'cassandra-3.0' into cassandra-3.11

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 CHANGES.txt | 1 +
 tools/stress/src/org/apache/cassandra/stress/StressProfile.java | 5 +
 2 files changed, 6 insertions(+)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14907) cassandra-stress does not work with frozen collections: list, set

2019-04-10 Thread mck (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck updated CASSANDRA-14907:

Attachment: stress_14907.yaml
stress_14907.cql

> cassandra-stress does not work with frozen collections: list, set
> -
>
> Key: CASSANDRA-14907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14907
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/stress
>Reporter: ZhaoYang
>Assignee: ZhaoYang
>Priority: Low
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Attachments: stress_14907.cql, stress_14907.yaml
>
>
> {code}
> com.datastax.driver.core.exceptions.InvalidQueryException: Invalid operation 
> (f_list = f_list + ?) for frozen collection column f_list
> {code}
> | patch | utest |
> | 
> [3.0|https://github.com/jasonstack/cassandra/commits/stress_frozen_collection_3.0]
>  | [circle|https://circleci.com/gh/jasonstack/cassandra/745] |
> This patch should apply cleanly.. {{Map}} is not supported yet..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14907) cassandra-stress does not work with frozen collections: list, set

2019-04-10 Thread mck (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814329#comment-16814329
 ] 

mck commented on CASSANDRA-14907:
-

To test:
{code}
cassandra
cqlsh -f stress_14907.cql
cassandra-stress user profile=stress_14907.yaml ops\(insert=1\) no-warmup 
duration=1m
{code}
Fails with the exception from the description without the patch.

It would be awesome with a unit test for this, but the stress classes arn't so 
friendly to that atm.

> cassandra-stress does not work with frozen collections: list, set
> -
>
> Key: CASSANDRA-14907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14907
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/stress
>Reporter: ZhaoYang
>Assignee: ZhaoYang
>Priority: Low
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Attachments: stress_14907.cql, stress_14907.yaml
>
>
> {code}
> com.datastax.driver.core.exceptions.InvalidQueryException: Invalid operation 
> (f_list = f_list + ?) for frozen collection column f_list
> {code}
> | patch | utest |
> | 
> [3.0|https://github.com/jasonstack/cassandra/commits/stress_frozen_collection_3.0]
>  | [circle|https://circleci.com/gh/jasonstack/cassandra/745] |
> This patch should apply cleanly.. {{Map}} is not supported yet..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-14765) Evaluate Recovery Time on Single Token Cluster Test

2019-04-10 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814258#comment-16814258
 ] 

Dinesh Joshi edited comment on CASSANDRA-14765 at 4/10/19 9:35 AM:
---

I think this is done and we can close it. We may need to re-run this when other 
changes land but that could be a different ticket. Thoughts?


was (Author: djoshi3):
I think this is done and we can close it. We may need to re-run this when other 
changes land but that could be a different ticket.

> Evaluate Recovery Time on Single Token Cluster Test
> ---
>
> Key: CASSANDRA-14765
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14765
> Project: Cassandra
>  Issue Type: Sub-task
>  Components: Legacy/Streaming and Messaging
>Reporter: Joseph Lynch
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Attachments: 3.0.17-4.0.x-Streaming.png, cassandra_streaming.png, 
> image-2018-11-06-13-34-33-108.png, streaming_benchmarking.patch
>
>
> *Setup:*
>  * Cassandra: 6 (2*3 rack) node i3.8xlarge AWS instance (32 cpu cores, 240GB 
> ram) running cassandra trunk with Jason's 14503 changes vs the same footprint 
> running 3.0.17
>  * One datacenter, single tokens
>  * No compression, encryption, or coalescing turned on
> *Test #1:*
> ndbench loaded ~150GB of data per node into a LCS table. Then we killed a 
> node and let a new node stream. With a single token this should be a worst 
> case recovery scenario (only  a few peers to stream from).
> *Result:*
> As the table used LCS and we didn't not have encryption on, the zero copy 
> transfer was used via CASSANDRA-14556. We recovered *150GB in 5 minutes,* 
> going at a consistent rate of about 3 gigabit per second. Theoretically we 
> should be able to get 10 gigabit, but this is still something like an 
> estimated 16x improvement over 3.0.x. We're still running the 3.0.x test for 
> a hard comparison.
> *Follow Ups:*
> We need to get more rigorous measurements (over more terminations), as well 
> as finishing the 3.0.x test. [~sumanth.pasupuleti] and [~djoshi3] are driving 
> this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-14765) Evaluate Recovery Time on Single Token Cluster Test

2019-04-10 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814258#comment-16814258
 ] 

Dinesh Joshi commented on CASSANDRA-14765:
--

I think this is done and we can close it. We may need to re-run this when other 
changes land but that could be a different ticket.

> Evaluate Recovery Time on Single Token Cluster Test
> ---
>
> Key: CASSANDRA-14765
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14765
> Project: Cassandra
>  Issue Type: Sub-task
>  Components: Legacy/Streaming and Messaging
>Reporter: Joseph Lynch
>Assignee: Sumanth Pasupuleti
>Priority: Normal
> Attachments: 3.0.17-4.0.x-Streaming.png, cassandra_streaming.png, 
> image-2018-11-06-13-34-33-108.png, streaming_benchmarking.patch
>
>
> *Setup:*
>  * Cassandra: 6 (2*3 rack) node i3.8xlarge AWS instance (32 cpu cores, 240GB 
> ram) running cassandra trunk with Jason's 14503 changes vs the same footprint 
> running 3.0.17
>  * One datacenter, single tokens
>  * No compression, encryption, or coalescing turned on
> *Test #1:*
> ndbench loaded ~150GB of data per node into a LCS table. Then we killed a 
> node and let a new node stream. With a single token this should be a worst 
> case recovery scenario (only  a few peers to stream from).
> *Result:*
> As the table used LCS and we didn't not have encryption on, the zero copy 
> transfer was used via CASSANDRA-14556. We recovered *150GB in 5 minutes,* 
> going at a consistent rate of about 3 gigabit per second. Theoretically we 
> should be able to get 10 gigabit, but this is still something like an 
> estimated 16x improvement over 3.0.x. We're still running the 3.0.x test for 
> a hard comparison.
> *Follow Ups:*
> We need to get more rigorous measurements (over more terminations), as well 
> as finishing the 3.0.x test. [~sumanth.pasupuleti] and [~djoshi3] are driving 
> this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-7544) Allow storage port to be configurable per node

2019-04-10 Thread Keshav Varma (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814151#comment-16814151
 ] 

Keshav Varma commented on CASSANDRA-7544:
-

Ah, yes, I was testing with the upstream PyPI releases of the driver. With the 
custom egg from the repo, things seem to work as expected. Thanks for the 
pointer!

> Allow storage port to be configurable per node
> --
>
> Key: CASSANDRA-7544
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7544
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Sam Overton
>Assignee: Ariel Weisberg
>Priority: Normal
> Fix For: 4.0
>
>
> Currently storage_port must be configured identically on all nodes in a 
> cluster and it is assumed that this is the case when connecting to a remote 
> node.
> This prevents running in any environment that requires multiple nodes to be 
> able to bind to the same network interface, such as with many automatic 
> provisioning/deployment frameworks.
> The current solutions seems to be
> * use a separate network interface for each node deployed to the same box. 
> This puts a big requirement on IP allocation at large scale.
> * allow multiple clusters to be provisioned from the same resource pool, but 
> restrict allocation to a maximum of one node per host from each cluster, 
> assuming each cluster is running on a different storage port.
> It would make operations much simpler in these kind of environments if the 
> environment provisioning the resources could assign the ports to be used when 
> bringing up a new node on shared hardware.
> The changes required would be at least the following:
> 1. configure seeds as IP:port instead of just IP
> 2. gossip the storage port as part of a node's ApplicationState
> 3. refer internally to nodes by hostID instead of IP, since there will be 
> multiple nodes with the same IP
> (1) & (2) are mostly trivial and I already have a patch for these. The bulk 
> of the work to enable this is (3), and I would structure this as a separate 
> pre-requisite patch. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org