[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895682#comment-16895682
]
Patrick Bannister commented on CASSANDRA-10190:
---
[~djoshi3] the behavior of the {{make_range}} function was different under
Python 2.7 and Python 3.6. For a quick demonstration of the reason, try running
this in a Python 2 interpreter, and then again in a Python 3 interpreter:
{code:python}
assert 0 > None
{code}
Under Python 2 this is fine, but under Python 3, attempting to compare
{{NoneType}} to anything else will throw a {{TypeError}}.
This problem was exposed by failures in the dtest
{{test_writing_with_token_boundaries}} (from cqlsh_tests/test_cqlsh_copy.py).
When the test ran the COPY command with the WITH BEGINTOKEN and WITH ENDTOKEN
options, cqlsh crashed because of the {{TypeError}}.
I like the idea of adding some unit tests around this, I'll do it next time I
get a solid hour to work on this.
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15222) BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
[ https://issues.apache.org/jira/browse/CASSANDRA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-15222: - Reviewers: Benedict > BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy() > - > > Key: CASSANDRA-15222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15222 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction, Local/SSTable, Messaging/Internode >Reporter: Benedict >Assignee: Boris Tsirkin >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15249) Add documentation on release lifecycle
[ https://issues.apache.org/jira/browse/CASSANDRA-15249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895560#comment-16895560 ] Nate McCall commented on CASSANDRA-15249: - For folks who have not been following this, please check out the comment history, suggested changes, etc. on the google doc (the little talk bubble on the upper right hand corner of the UI next to the share link) . > Add documentation on release lifecycle > -- > > Key: CASSANDRA-15249 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15249 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 4.0 > > Attachments: release_lifecycle.patch > > > Relevant dev list mail thread: > https://lists.apache.org/thread.html/1a768d057d1af5a0f373c4c399a23e65cb04c61bbfff612634b9437c@%3Cdev.cassandra.apache.org%3E > Google doc with community collaboration on documenting release lifecycle > https://docs.google.com/document/d/1bS6sr-HSrHFjZb0welife6Qx7u3ZDgRiAoENMLYlfz8/edit -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15222) BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
[ https://issues.apache.org/jira/browse/CASSANDRA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Tsirkin updated CASSANDRA-15222: -- Test and Documentation Plan: Nothing in partucular as I just changed the method, used to copy. Status: Patch Available (was: In Progress) See https://github.com/apache/cassandra/pull/335 > BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy() > - > > Key: CASSANDRA-15222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15222 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction, Local/SSTable, Messaging/Internode >Reporter: Benedict >Assignee: Boris Tsirkin >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15222) BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
[ https://issues.apache.org/jira/browse/CASSANDRA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15222: --- Labels: pull-request-available (was: ) > BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy() > - > > Key: CASSANDRA-15222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15222 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction, Local/SSTable, Messaging/Internode >Reporter: Benedict >Assignee: Boris Tsirkin >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15222) BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
[ https://issues.apache.org/jira/browse/CASSANDRA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Tsirkin reassigned CASSANDRA-15222: - Assignee: Boris Tsirkin > BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy() > - > > Key: CASSANDRA-15222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15222 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction, Local/SSTable, Messaging/Internode >Reporter: Benedict >Assignee: Boris Tsirkin >Priority: Normal > Fix For: 4.0.x > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15248) Upgrade Guava to latest on master branch
[ https://issues.apache.org/jira/browse/CASSANDRA-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895307#comment-16895307 ] Andy Tolbert commented on CASSANDRA-15248: -- 4.0 isn’t too far away so we should be carefully considering any changes at this point. Since guava is used in a number of places it makes sense to be deliberate about whether or not to upgrade it. > Upgrade Guava to latest on master branch > > > Key: CASSANDRA-15248 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15248 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Packaging >Reporter: Abhijit Sarkar >Priority: Normal > > Upgrade Guava to latest on master branch. See > https://issues.apache.org/jira/browse/CASSANDRA-15245. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15202) Deserialize merkle trees off-heap
[
https://issues.apache.org/jira/browse/CASSANDRA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895071#comment-16895071
]
Marcus Eriksson commented on CASSANDRA-15202:
-
* I think we need a null check
[here|https://github.com/iamaleksey/cassandra/compare/51a29f21cf3f12dde0a33f4ff6d5e9ca547d6c18..15202-4.0#diff-e657fd15ed537a2bf54a672b6b84afecR210]
now that {{find(..)}} can return {{null}} (like in
[trunk|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/MerkleTree.java#L247])
nit:
* we don't use SHA-256 for hashes anymore (we use 2 instances of murmur3_128
with different seeds to get the same size), the comments on {{HASH_SIZE}} and
{{byteArray}} in {{MerkleTree.java}} should be updated
> Deserialize merkle trees off-heap
> -
>
> Key: CASSANDRA-15202
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15202
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Jeff Jirsa
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 4.0
>
> Attachments: offheap-mts-gc.png
>
>
> CASSANDRA-14096 made the first step to address the heavy on-heap footprint of
> merkle trees on repair coordinators - by reducing the time frame over which
> they are referenced, and by more intelligently limiting depth of the trees
> based on available heap size.
> That alone improves GC profile and prevents OOMs, but doesn’t address the
> issue entirely. The coordinator still must hold all the trees on heap at once
> until it’s done diffing them with each other, which has a negative effect,
> and, by reducing depth, we lose precision and thus cause more overstreaming
> than before.
> One way to improve the situation further is to build on CASSANDRA-14096 and
> move the trees entirely off-heap. This is a trivial endeavor, given that we
> are dealing with what should be full binary trees (though in practice aren’t
> quite, yet). This JIRA makes the first step towards there - by moving just
> deserialisation off-heap, leaving construction on the replicas on-heap still.
> Additionally, the proposed patch fixes the issue of replica coordinators
> sending merkle trees to itself over loopback, costing us a ser/deser loop per
> tree.
> Please note that there is more room for improvement here, and depending on
> 4.0 timeline those improvements may or may not land in time. To name a few:
> - with some minor modifications to init(), we can make sure that no matter
> the range, the tree is *always* perfectly full; this would allow us to get
> rid of child pointers in inner nodes, as child node addresses will be
> trivially calculatable given fixed size of nodes
> - the trees can be easily constructed off-heap so long as you run init() to
> pre-size the tree to find out how large a buffer you need
> - on-wire format doesn’t need to stream inner nodes, only leaves, and,
> really, only the hashes of the leaves
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15249) Add documentation on release lifecycle
[ https://issues.apache.org/jira/browse/CASSANDRA-15249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894970#comment-16894970 ] Dinesh Joshi commented on CASSANDRA-15249: -- Thanks for driving this [~sumanth.pasupuleti]. I see there are open questions at the bottom of the document. I think it would be a good idea to resolve them. Additionally, since this will be up on the official Apache Cassandra website and has to do with the release process, I think we should run it by the PMC. > Add documentation on release lifecycle > -- > > Key: CASSANDRA-15249 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15249 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 4.0 > > Attachments: release_lifecycle.patch > > > Relevant dev list mail thread: > https://lists.apache.org/thread.html/1a768d057d1af5a0f373c4c399a23e65cb04c61bbfff612634b9437c@%3Cdev.cassandra.apache.org%3E > Google doc with community collaboration on documenting release lifecycle > https://docs.google.com/document/d/1bS6sr-HSrHFjZb0welife6Qx7u3ZDgRiAoENMLYlfz8/edit -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
