[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-23 Thread Jeff Jirsa (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-15287:
---
  Fix Version/s: 4.0
  Since Version: 2.1.5
Source Control Link: 
https://github.com/apache/cassandra/commit/a145a485206f6a32b07979dfb1b983addf49dd10
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

Thanks for the patch. I've taken the liberty of rewording it SLIGHTLY to make 
it more clear. Hope you don't object. Committed as 
[a145a485206f6a32b07979dfb1b983addf49dd10|https://github.com/apache/cassandra/commit/a145a485206f6a32b07979dfb1b983addf49dd10]

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Fix For: 4.0
>
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch trunk updated: Fixed exception message in nodetool snapshot when specifying kt-list and keyspace

2019-08-23 Thread jjirsa
This is an automated email from the ASF dual-hosted git repository.

jjirsa pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/trunk by this push:
 new a145a48  Fixed exception message in nodetool snapshot when specifying 
kt-list and keyspace
a145a48 is described below

commit a145a485206f6a32b07979dfb1b983addf49dd10
Author: Josh Turner 
AuthorDate: Thu Aug 22 08:24:38 2019 -0700

Fixed exception message in nodetool snapshot when specifying kt-list and 
keyspace

Patch by Josh Turner; Reviewed by Jeff Jirsa for CASSANDRA-15287
---
 CHANGES.txt| 1 +
 src/java/org/apache/cassandra/tools/nodetool/Snapshot.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGES.txt b/CHANGES.txt
index 0ff429f..d6bb701 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 4.0
+ * Inaccurate exception message with nodetool snapshot (CASSANDRA-15287)
  * Fix InternodeOutboundMetrics overloaded bytes/count mixup (CASSANDRA-15186)
  * Enhance & reenable RepairTest with compression=off and compression=on 
(CASSANDRA-15272)
  * Improve readability of Table metrics Virtual tables units (CASSANDRA-15194)
diff --git a/src/java/org/apache/cassandra/tools/nodetool/Snapshot.java 
b/src/java/org/apache/cassandra/tools/nodetool/Snapshot.java
index 8d01d3a..495ee9d 100644
--- a/src/java/org/apache/cassandra/tools/nodetool/Snapshot.java
+++ b/src/java/org/apache/cassandra/tools/nodetool/Snapshot.java
@@ -71,7 +71,7 @@ public class Snapshot extends NodeToolCmd
 else
 {
 throw new IOException(
-"When specifying the Keyspace columfamily list for 
a snapshot, you should not specify columnfamily");
+"When specifying the Keyspace table list (using 
-kt,--kt-list,-kc,--kc.list), you must not also specify keyspaces to snapshot");
 }
 if (!snapshotName.isEmpty())
 sb.append(" with snapshot name 
[").append(snapshotName).append("]");


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-23 Thread Jeff Jirsa (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-15287:
---
Reviewers: Jeff Jirsa, Jeff Jirsa  (was: Jeff Jirsa)
   Jeff Jirsa, Jeff Jirsa
   Status: Review In Progress  (was: Patch Available)

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-23 Thread Jeff Jirsa (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-15287:
---
Status: Ready to Commit  (was: Review In Progress)

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-15186) InternodeOutboundMetrics overloaded bytes/count mixup

2019-08-23 Thread Jeff Jirsa (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914804#comment-16914804
 ] 

Jeff Jirsa edited comment on CASSANDRA-15186 at 8/24/19 4:16 AM:
-

Thanks! Committed as 
[0622288c9b2252e31bba0da73a8608ba2aa13ff3|https://github.com/apache/cassandra/commit/0622288c9b2252e31bba0da73a8608ba2aa13ff3]


was (Author: jjirsa):
Thanks! Committed as 
[0622288c9b2252e31bba0da73a8608ba2aa13ff3|[https://github.com/apache/cassandra/commit/0622288c9b2252e31bba0da73a8608ba2aa13ff3]]

> InternodeOutboundMetrics overloaded bytes/count mixup
> -
>
> Key: CASSANDRA-15186
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15186
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/Metrics
>Reporter: Marcus Olsson
>Assignee: Josh Turner
>Priority: Normal
> Fix For: 4.0
>
> Attachments: 15186-trunk.txt
>
>
> In 
> [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java]
>  there is a small mixup between overloaded count and bytes, in 
> [LargeMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L129]
>  and 
> [UrgentMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L151].



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15186) InternodeOutboundMetrics overloaded bytes/count mixup

2019-08-23 Thread Jeff Jirsa (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-15186:
---
  Fix Version/s: 4.0
  Since Version: 4.0
Source Control Link: 
https://github.com/apache/cassandra/commit/0622288c9b2252e31bba0da73a8608ba2aa13ff3
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

Thanks! Committed as 
{{[0622288c9b2252e31bba0da73a8608ba2aa13ff3|[https://github.com/apache/cassandra/commit/0622288c9b2252e31bba0da73a8608ba2aa13ff3]]}}

> InternodeOutboundMetrics overloaded bytes/count mixup
> -
>
> Key: CASSANDRA-15186
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15186
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/Metrics
>Reporter: Marcus Olsson
>Assignee: Josh Turner
>Priority: Normal
> Fix For: 4.0
>
> Attachments: 15186-trunk.txt
>
>
> In 
> [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java]
>  there is a small mixup between overloaded count and bytes, in 
> [LargeMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L129]
>  and 
> [UrgentMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L151].



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-15186) InternodeOutboundMetrics overloaded bytes/count mixup

2019-08-23 Thread Jeff Jirsa (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914804#comment-16914804
 ] 

Jeff Jirsa edited comment on CASSANDRA-15186 at 8/24/19 4:15 AM:
-

Thanks! Committed as 
[0622288c9b2252e31bba0da73a8608ba2aa13ff3|[https://github.com/apache/cassandra/commit/0622288c9b2252e31bba0da73a8608ba2aa13ff3]]


was (Author: jjirsa):
Thanks! Committed as 
{{[0622288c9b2252e31bba0da73a8608ba2aa13ff3|[https://github.com/apache/cassandra/commit/0622288c9b2252e31bba0da73a8608ba2aa13ff3]]}}

> InternodeOutboundMetrics overloaded bytes/count mixup
> -
>
> Key: CASSANDRA-15186
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15186
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/Metrics
>Reporter: Marcus Olsson
>Assignee: Josh Turner
>Priority: Normal
> Fix For: 4.0
>
> Attachments: 15186-trunk.txt
>
>
> In 
> [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java]
>  there is a small mixup between overloaded count and bytes, in 
> [LargeMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L129]
>  and 
> [UrgentMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L151].



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15186) InternodeOutboundMetrics overloaded bytes/count mixup

2019-08-23 Thread Jeff Jirsa (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-15186:
---
Status: Ready to Commit  (was: Review In Progress)

> InternodeOutboundMetrics overloaded bytes/count mixup
> -
>
> Key: CASSANDRA-15186
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15186
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/Metrics
>Reporter: Marcus Olsson
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15186-trunk.txt
>
>
> In 
> [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java]
>  there is a small mixup between overloaded count and bytes, in 
> [LargeMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L129]
>  and 
> [UrgentMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L151].



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch trunk updated: Fix InternodeOutboundMetrics overloaded bytes/count mixup

2019-08-23 Thread jjirsa
This is an automated email from the ASF dual-hosted git repository.

jjirsa pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/trunk by this push:
 new 0622288  Fix InternodeOutboundMetrics overloaded bytes/count mixup
0622288 is described below

commit 0622288c9b2252e31bba0da73a8608ba2aa13ff3
Author: Josh Turner 
AuthorDate: Wed Aug 21 13:40:03 2019 -0700

Fix InternodeOutboundMetrics overloaded bytes/count mixup

Patch by Josh Turner; Reviewed by Jeff Jirsa for CASSANDRA-15186
---
 CHANGES.txt   | 1 +
 .../org/apache/cassandra/metrics/InternodeOutboundMetrics.java| 8 
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/CHANGES.txt b/CHANGES.txt
index 25f52c0..0ff429f 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 4.0
+ * Fix InternodeOutboundMetrics overloaded bytes/count mixup (CASSANDRA-15186)
  * Enhance & reenable RepairTest with compression=off and compression=on 
(CASSANDRA-15272)
  * Improve readability of Table metrics Virtual tables units (CASSANDRA-15194)
  * Fix error with non-existent table for nodetool tablehistograms 
(CASSANDRA-14410)
diff --git 
a/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java 
b/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java
index 4e64f66..f04b428 100644
--- a/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java
+++ b/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java
@@ -126,8 +126,8 @@ public class InternodeOutboundMetrics
 largeMessageCompletedTasks = 
Metrics.register(factory.createMetricName("LargeMessageCompletedTasks"),messagingPool.large::sentCount);
 largeMessageCompletedBytes = 
Metrics.register(factory.createMetricName("LargeMessageCompletedBytes"),messagingPool.large::sentBytes);
 largeMessageDropped = 
Metrics.register(factory.createMetricName("LargeMessageDroppedTasks"), 
messagingPool.large::dropped);
-largeMessageDroppedTasksDueToOverload = 
Metrics.register(factory.createMetricName("LargeMessageDroppedTasksDueToOverload"),
 messagingPool.large::overloadedBytes);
-largeMessageDroppedBytesDueToOverload = 
Metrics.register(factory.createMetricName("LargeMessageDroppedBytesDueToOverload"),
 messagingPool.large::overloadedCount);
+largeMessageDroppedTasksDueToOverload = 
Metrics.register(factory.createMetricName("LargeMessageDroppedTasksDueToOverload"),
 messagingPool.large::overloadedCount);
+largeMessageDroppedBytesDueToOverload = 
Metrics.register(factory.createMetricName("LargeMessageDroppedBytesDueToOverload"),
 messagingPool.large::overloadedBytes);
 largeMessageDroppedTasksDueToTimeout = 
Metrics.register(factory.createMetricName("LargeMessageDroppedTasksDueToTimeout"),
 messagingPool.large::expiredCount);
 largeMessageDroppedBytesDueToTimeout = 
Metrics.register(factory.createMetricName("LargeMessageDroppedBytesDueToTimeout"),
 messagingPool.large::expiredBytes);
 largeMessageDroppedTasksDueToError = 
Metrics.register(factory.createMetricName("LargeMessageDroppedTasksDueToError"),
 messagingPool.large::errorCount);
@@ -148,8 +148,8 @@ public class InternodeOutboundMetrics
 urgentMessageCompletedTasks = 
Metrics.register(factory.createMetricName("UrgentMessageCompletedTasks"), 
messagingPool.urgent::sentCount);
 urgentMessageCompletedBytes = 
Metrics.register(factory.createMetricName("UrgentMessageCompletedBytes"),messagingPool.urgent::sentBytes);
 urgentMessageDroppedTasks = 
Metrics.register(factory.createMetricName("UrgentMessageDroppedTasks"), 
messagingPool.urgent::dropped);
-urgentMessageDroppedTasksDueToOverload = 
Metrics.register(factory.createMetricName("UrgentMessageDroppedTasksDueToOverload"),
 messagingPool.urgent::overloadedBytes);
-urgentMessageDroppedBytesDueToOverload = 
Metrics.register(factory.createMetricName("UrgentMessageDroppedBytesDueToOverload"),
 messagingPool.urgent::overloadedCount);
+urgentMessageDroppedTasksDueToOverload = 
Metrics.register(factory.createMetricName("UrgentMessageDroppedTasksDueToOverload"),
 messagingPool.urgent::overloadedCount);
+urgentMessageDroppedBytesDueToOverload = 
Metrics.register(factory.createMetricName("UrgentMessageDroppedBytesDueToOverload"),
 messagingPool.urgent::overloadedBytes);
 urgentMessageDroppedTasksDueToTimeout = 
Metrics.register(factory.createMetricName("UrgentMessageDroppedTasksDueToTimeout"),
 messagingPool.urgent::expiredCount);
 urgentMessageDroppedBytesDueToTimeout = 
Metrics.register(factory.createMetricName("UrgentMessageDroppedBytesDueToTimeout"),
 messagingPool.urgent::expiredBytes);
 urgentMessageDroppedTasksDueToError = 
Metrics.register(factory.createMetricName("UrgentMessageDroppedTasksDueToError"),
 messagingPool.urgent::errorCount);



[jira] [Updated] (CASSANDRA-15186) InternodeOutboundMetrics overloaded bytes/count mixup

2019-08-23 Thread Jeff Jirsa (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-15186:
---
Reviewers: Jeff Jirsa, Jeff Jirsa  (was: Jeff Jirsa)
   Jeff Jirsa, Jeff Jirsa
   Status: Review In Progress  (was: Patch Available)

> InternodeOutboundMetrics overloaded bytes/count mixup
> -
>
> Key: CASSANDRA-15186
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15186
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/Metrics
>Reporter: Marcus Olsson
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15186-trunk.txt
>
>
> In 
> [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java]
>  there is a small mixup between overloaded count and bytes, in 
> [LargeMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L129]
>  and 
> [UrgentMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L151].



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15284) AssertionError while scrubbing sstable

2019-08-23 Thread Gianluigi Tiesi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914787#comment-16914787
 ] 

Gianluigi Tiesi commented on CASSANDRA-15284:
-

I would try the attached patch [^assert-comp-meta.diff] , do you think it is 
safe?

> AssertionError while scrubbing sstable
> --
>
> Key: CASSANDRA-15284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15284
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Gianluigi Tiesi
>Priority: Normal
> Attachments: assert-comp-meta.diff
>
>
> I've ad damaged data file but while trying to run scrub (online or offline) I 
> always get this
> error:
>  
> {code:java}
> -- StackTrace --
> java.lang.AssertionError
> at 
> org.apache.cassandra.io.compress.CompressionMetadata$Chunk.(CompressionMetadata.java:474)
> at 
> org.apache.cassandra.io.compress.CompressionMetadata.chunkFor(CompressionMetadata.java:239)
> at 
> org.apache.cassandra.io.util.MmappedRegions.updateState(MmappedRegions.java:163)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:73)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:61)
> at 
> org.apache.cassandra.io.util.MmappedRegions.map(MmappedRegions.java:104)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:362)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:331)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinal(BigTableWriter.java:336)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinalEarly(BigTableWriter.java:318)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.switchWriter(SSTableRewriter.java:322)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.doPrepare(SSTableRewriter.java:370)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.finish(Transactional.java:184)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.finish(SSTableRewriter.java:357)
> at 
> org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:291)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.scrubOne(CompactionManager.java:1010)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.access$200(CompactionManager.java:83)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$3.execute(CompactionManager.java:391)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:312)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> At the moment I've moved away the corrupted file, If you need more info fell 
> free to ask
>  
> According to the source 
> https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/io/compress/CompressionMetadata.java#L474
> looks like the requested chung length is <= 0



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15284) AssertionError while scrubbing sstable

2019-08-23 Thread Gianluigi Tiesi (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gianluigi Tiesi updated CASSANDRA-15284:

Attachment: assert-comp-meta.diff

> AssertionError while scrubbing sstable
> --
>
> Key: CASSANDRA-15284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15284
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Gianluigi Tiesi
>Priority: Normal
> Attachments: assert-comp-meta.diff
>
>
> I've ad damaged data file but while trying to run scrub (online or offline) I 
> always get this
> error:
>  
> {code:java}
> -- StackTrace --
> java.lang.AssertionError
> at 
> org.apache.cassandra.io.compress.CompressionMetadata$Chunk.(CompressionMetadata.java:474)
> at 
> org.apache.cassandra.io.compress.CompressionMetadata.chunkFor(CompressionMetadata.java:239)
> at 
> org.apache.cassandra.io.util.MmappedRegions.updateState(MmappedRegions.java:163)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:73)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:61)
> at 
> org.apache.cassandra.io.util.MmappedRegions.map(MmappedRegions.java:104)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:362)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:331)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinal(BigTableWriter.java:336)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinalEarly(BigTableWriter.java:318)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.switchWriter(SSTableRewriter.java:322)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.doPrepare(SSTableRewriter.java:370)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.finish(Transactional.java:184)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.finish(SSTableRewriter.java:357)
> at 
> org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:291)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.scrubOne(CompactionManager.java:1010)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.access$200(CompactionManager.java:83)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$3.execute(CompactionManager.java:391)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:312)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> At the moment I've moved away the corrupted file, If you need more info fell 
> free to ask
>  
> According to the source 
> https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/io/compress/CompressionMetadata.java#L474
> looks like the requested chung length is <= 0



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15284) AssertionError while scrubbing sstable

2019-08-23 Thread Gianluigi Tiesi (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gianluigi Tiesi updated CASSANDRA-15284:

Platform: OpenJDK,Linux  (was: All,OpenJDK)

> AssertionError while scrubbing sstable
> --
>
> Key: CASSANDRA-15284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15284
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Gianluigi Tiesi
>Priority: Normal
>
> I've ad damaged data file but while trying to run scrub (online or offline) I 
> always get this
> error:
>  
> {code:java}
> -- StackTrace --
> java.lang.AssertionError
> at 
> org.apache.cassandra.io.compress.CompressionMetadata$Chunk.(CompressionMetadata.java:474)
> at 
> org.apache.cassandra.io.compress.CompressionMetadata.chunkFor(CompressionMetadata.java:239)
> at 
> org.apache.cassandra.io.util.MmappedRegions.updateState(MmappedRegions.java:163)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:73)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:61)
> at 
> org.apache.cassandra.io.util.MmappedRegions.map(MmappedRegions.java:104)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:362)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:331)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinal(BigTableWriter.java:336)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinalEarly(BigTableWriter.java:318)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.switchWriter(SSTableRewriter.java:322)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.doPrepare(SSTableRewriter.java:370)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.finish(Transactional.java:184)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.finish(SSTableRewriter.java:357)
> at 
> org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:291)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.scrubOne(CompactionManager.java:1010)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.access$200(CompactionManager.java:83)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$3.execute(CompactionManager.java:391)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:312)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> At the moment I've moved away the corrupted file, If you need more info fell 
> free to ask
>  
> According to the source 
> https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/io/compress/CompressionMetadata.java#L474
> looks like the requested chung length is <= 0



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15284) AssertionError while scrubbing sstable

2019-08-23 Thread Gianluigi Tiesi (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gianluigi Tiesi updated CASSANDRA-15284:

Since Version: 3.11.4

> AssertionError while scrubbing sstable
> --
>
> Key: CASSANDRA-15284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15284
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Gianluigi Tiesi
>Priority: Normal
>
> I've ad damaged data file but while trying to run scrub (online or offline) I 
> always get this
> error:
>  
> {code:java}
> -- StackTrace --
> java.lang.AssertionError
> at 
> org.apache.cassandra.io.compress.CompressionMetadata$Chunk.(CompressionMetadata.java:474)
> at 
> org.apache.cassandra.io.compress.CompressionMetadata.chunkFor(CompressionMetadata.java:239)
> at 
> org.apache.cassandra.io.util.MmappedRegions.updateState(MmappedRegions.java:163)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:73)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:61)
> at 
> org.apache.cassandra.io.util.MmappedRegions.map(MmappedRegions.java:104)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:362)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:331)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinal(BigTableWriter.java:336)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinalEarly(BigTableWriter.java:318)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.switchWriter(SSTableRewriter.java:322)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.doPrepare(SSTableRewriter.java:370)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.finish(Transactional.java:184)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.finish(SSTableRewriter.java:357)
> at 
> org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:291)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.scrubOne(CompactionManager.java:1010)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.access$200(CompactionManager.java:83)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$3.execute(CompactionManager.java:391)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:312)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> At the moment I've moved away the corrupted file, If you need more info fell 
> free to ask
>  
> According to the source 
> https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/io/compress/CompressionMetadata.java#L474
> looks like the requested chung length is <= 0



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15284) AssertionError while scrubbing sstable

2019-08-23 Thread Gianluigi Tiesi (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gianluigi Tiesi updated CASSANDRA-15284:

 Bug Category: Parent values: Correctness(12982)Level 1 values: 
Unrecoverable Corruption / Loss(13161)
Discovered By: User Report
 Platform: All,OpenJDK  (was: All)

> AssertionError while scrubbing sstable
> --
>
> Key: CASSANDRA-15284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15284
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Gianluigi Tiesi
>Priority: Normal
>
> I've ad damaged data file but while trying to run scrub (online or offline) I 
> always get this
> error:
>  
> {code:java}
> -- StackTrace --
> java.lang.AssertionError
> at 
> org.apache.cassandra.io.compress.CompressionMetadata$Chunk.(CompressionMetadata.java:474)
> at 
> org.apache.cassandra.io.compress.CompressionMetadata.chunkFor(CompressionMetadata.java:239)
> at 
> org.apache.cassandra.io.util.MmappedRegions.updateState(MmappedRegions.java:163)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:73)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:61)
> at 
> org.apache.cassandra.io.util.MmappedRegions.map(MmappedRegions.java:104)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:362)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:331)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinal(BigTableWriter.java:336)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinalEarly(BigTableWriter.java:318)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.switchWriter(SSTableRewriter.java:322)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.doPrepare(SSTableRewriter.java:370)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.finish(Transactional.java:184)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.finish(SSTableRewriter.java:357)
> at 
> org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:291)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.scrubOne(CompactionManager.java:1010)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.access$200(CompactionManager.java:83)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$3.execute(CompactionManager.java:391)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:312)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> At the moment I've moved away the corrupted file, If you need more info fell 
> free to ask
>  
> According to the source 
> https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/io/compress/CompressionMetadata.java#L474
> looks like the requested chung length is <= 0



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15284) AssertionError while scrubbing sstable

2019-08-23 Thread Gianluigi Tiesi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914778#comment-16914778
 ] 

Gianluigi Tiesi commented on CASSANDRA-15284:
-

No clue? I still have problem repairing my cluster, repair says the file is 
corrupted and scrub fails with java.lang.AssertionError

> AssertionError while scrubbing sstable
> --
>
> Key: CASSANDRA-15284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15284
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Gianluigi Tiesi
>Priority: Normal
>
> I've ad damaged data file but while trying to run scrub (online or offline) I 
> always get this
> error:
>  
> {code:java}
> -- StackTrace --
> java.lang.AssertionError
> at 
> org.apache.cassandra.io.compress.CompressionMetadata$Chunk.(CompressionMetadata.java:474)
> at 
> org.apache.cassandra.io.compress.CompressionMetadata.chunkFor(CompressionMetadata.java:239)
> at 
> org.apache.cassandra.io.util.MmappedRegions.updateState(MmappedRegions.java:163)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:73)
> at 
> org.apache.cassandra.io.util.MmappedRegions.(MmappedRegions.java:61)
> at 
> org.apache.cassandra.io.util.MmappedRegions.map(MmappedRegions.java:104)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:362)
> at 
> org.apache.cassandra.io.util.FileHandle$Builder.complete(FileHandle.java:331)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinal(BigTableWriter.java:336)
> at 
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.openFinalEarly(BigTableWriter.java:318)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.switchWriter(SSTableRewriter.java:322)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.doPrepare(SSTableRewriter.java:370)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
> at 
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.finish(Transactional.java:184)
> at 
> org.apache.cassandra.io.sstable.SSTableRewriter.finish(SSTableRewriter.java:357)
> at 
> org.apache.cassandra.db.compaction.Scrubber.scrub(Scrubber.java:291)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.scrubOne(CompactionManager.java:1010)
> at 
> org.apache.cassandra.db.compaction.CompactionManager.access$200(CompactionManager.java:83)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$3.execute(CompactionManager.java:391)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:312)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> At the moment I've moved away the corrupted file, If you need more info fell 
> free to ask
>  
> According to the source 
> https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/io/compress/CompressionMetadata.java#L474
> looks like the requested chung length is <= 0



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15288) Read sidecar.yaml from sidecar.config System Property instead of classpath

2019-08-23 Thread Dinesh Joshi (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-15288:
-
  Fix Version/s: 4.x
Source Control Link: 
https://github.com/apache/cassandra-sidecar/commit/14485bd7ad649d9417b4320eab34631251545d0b
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

Committed. Thanks for the patch [~andrew.tolbert]. Thanks [~vinaykumarcse] for 
the review.

> Read sidecar.yaml from sidecar.config System Property instead of classpath
> --
>
> Key: CASSANDRA-15288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15288
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Sidecar
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
>  Labels: pull-request-available
> Fix For: 4.x
>
>
> I was experimenting earlier with running multiple sidecar instances against 
> multiple local C* nodes (using a ccm cluster) and noticed that the 
> distribution of sidecar did not include the conf directory and instead was 
> loading sidecar.yaml from the classpath. I noticed the lines in build.gradle:
> {code:java}
> // Config file location should be in file:/// format for local files,
> // when we have the fix for adding /conf directory to classpaht, we can get 
> away with below default JvmArg
> {code}
> From this statement I assume the expectation was that eventually the 
> sidecar.config system property would be used to locate the sidecar.yaml file.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra-sidecar] branch master updated (2f9e393 -> 14485bd)

2019-08-23 Thread djoshi
This is an automated email from the ASF dual-hosted git repository.

djoshi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git.


from 2f9e393  update CHANGES.txt with missing jiras
 add 14485bd  Read config from sidecar.config System Property instead of 
classpath

No new revisions were added by this update.

Summary of changes:
 .gitignore |  9 +
 CHANGES.txt|  1 +
 build.gradle   | 35 ++--
 {conf => src/main/dist/conf}/logback.xml   |  0
 {conf => src/main/dist/conf}/sidecar.yaml  |  0
 .../cassandra/sidecar/CassandraSidecarDaemon.java  |  2 +-
 .../org/apache/cassandra/sidecar/MainModule.java   | 47 ++
 src/test/resources/logback-test.xml| 37 +
 8 files changed, 90 insertions(+), 41 deletions(-)
 rename {conf => src/main/dist/conf}/logback.xml (100%)
 rename {conf => src/main/dist/conf}/sidecar.yaml (100%)
 create mode 100644 src/test/resources/logback-test.xml


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15272) Enhance & reenable RepairTest

2019-08-23 Thread Dinesh Joshi (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-15272:
-
  Fix Version/s: 4.0
Source Control Link: 
https://github.com/apache/cassandra/commit/3a4e00615b14275e5dac535a304add9e1cf4e4eb
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

> Enhance & reenable RepairTest
> -
>
> Key: CASSANDRA-15272
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15272
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Consistency/Repair
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0
>
>
> Currently the In-JVM RepairTest is not enabled on trunk (See for more info: 
> CASSANDRA-13938). This patch enables the In JVM RepairTest. It adds a new 
> test that tests the compression=off path for SSTables. It will help catch any 
> regressions in repair on this path. This does not fix the issue with the 
> compressed sstable streaming (CASSANDRA-13938). That should be addressed in 
> the original ticket.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15272) Enhance & reenable RepairTest

2019-08-23 Thread Dinesh Joshi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914700#comment-16914700
 ] 

Dinesh Joshi commented on CASSANDRA-15272:
--

[~jmeredithco], committed. Thanks for the review.

> Enhance & reenable RepairTest
> -
>
> Key: CASSANDRA-15272
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15272
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Consistency/Repair
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0
>
>
> Currently the In-JVM RepairTest is not enabled on trunk (See for more info: 
> CASSANDRA-13938). This patch enables the In JVM RepairTest. It adds a new 
> test that tests the compression=off path for SSTables. It will help catch any 
> regressions in repair on this path. This does not fix the issue with the 
> compressed sstable streaming (CASSANDRA-13938). That should be addressed in 
> the original ticket.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch trunk updated: Enhance & reenable RepairTest with compression=off and compression=on

2019-08-23 Thread djoshi
This is an automated email from the ASF dual-hosted git repository.

djoshi pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/trunk by this push:
 new 3a4e006  Enhance & reenable RepairTest with compression=off and 
compression=on
3a4e006 is described below

commit 3a4e00615b14275e5dac535a304add9e1cf4e4eb
Author: Dinesh A. Joshi 
AuthorDate: Thu Aug 8 17:08:02 2019 -0700

Enhance & reenable RepairTest with compression=off and compression=on

patch by Dinesh Joshi; reviewed by Jon Meredith for CASSANDRA-15272
---
 CHANGES.txt|  1 +
 .../cassandra/distributed/test/RepairTest.java | 71 ++
 2 files changed, 45 insertions(+), 27 deletions(-)

diff --git a/CHANGES.txt b/CHANGES.txt
index 8ac7fbf..25f52c0 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 4.0
+ * Enhance & reenable RepairTest with compression=off and compression=on 
(CASSANDRA-15272)
  * Improve readability of Table metrics Virtual tables units (CASSANDRA-15194)
  * Fix error with non-existent table for nodetool tablehistograms 
(CASSANDRA-14410)
  * Avoid result truncation in decimal operations (CASSANDRA-15232)
diff --git 
a/test/distributed/org/apache/cassandra/distributed/test/RepairTest.java 
b/test/distributed/org/apache/cassandra/distributed/test/RepairTest.java
index 143b5cd..1c488aa 100644
--- a/test/distributed/org/apache/cassandra/distributed/test/RepairTest.java
+++ b/test/distributed/org/apache/cassandra/distributed/test/RepairTest.java
@@ -25,6 +25,7 @@ import java.util.function.Consumer;
 
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
+import org.junit.BeforeClass;
 import org.junit.Ignore;
 import org.junit.Test;
 
@@ -38,11 +39,13 @@ import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.apache.cassandra.distributed.impl.ExecUtil.rethrow;
 import static org.apache.cassandra.distributed.api.Feature.GOSSIP;
 import static org.apache.cassandra.distributed.api.Feature.NETWORK;
-@Ignore
+
 public class RepairTest extends DistributedTestBase
 {
 private static final String insert = withKeyspace("INSERT INTO %s.test (k, 
c1, c2) VALUES (?, 'value1', 'value2');");
 private static final String query = withKeyspace("SELECT k, c1, c2 FROM 
%s.test WHERE k = ?;");
+private static Cluster cluster;
+
 private static void insert(Cluster cluster, int start, int end, int ... 
nodes)
 {
 for (int i = start ; i < end ; ++i)
@@ -71,19 +74,38 @@ public class RepairTest extends DistributedTestBase
 cluster.get(node).runOnInstance(rethrow(() -> 
StorageService.instance.forceKeyspaceFlush(KEYSPACE)));
 }
 
-private Cluster create(Consumer configModifier) throws 
IOException
+private static Cluster create(Consumer configModifier) 
throws IOException
 {
 configModifier = configModifier.andThen(
-config -> config.set("hinted_handoff_enabled", false)
-.set("commitlog_sync_batch_window_in_ms", 5)
-.with(NETWORK)
-.with(GOSSIP)
+config -> config.set("hinted_handoff_enabled", false)
+.set("commitlog_sync_batch_window_in_ms", 5)
+.with(NETWORK)
+.with(GOSSIP)
 );
 
 Cluster cluster = 
init(Cluster.build(3).withConfig(configModifier).start());
+return cluster;
+}
+
+private void repair(Cluster cluster, Map options)
+{
+cluster.get(1).runOnInstance(rethrow(() -> {
+SimpleCondition await = new SimpleCondition();
+StorageService.instance.repair(KEYSPACE, options, 
ImmutableList.of((tag, event) -> {
+if (event.getType() == ProgressEventType.COMPLETE)
+await.signalAll();
+})).right.get();
+await.await(1L, MINUTES);
+}));
+}
+
+void populate(Cluster cluster, boolean compression)
+{
 try
 {
-cluster.schemaChange(withKeyspace("CREATE TABLE %s.test (k text, 
c1 text, c2 text, PRIMARY KEY (k));"));
+cluster.schemaChange(withKeyspace("DROP TABLE IF EXISTS 
%s.test;"));
+cluster.schemaChange(withKeyspace("CREATE TABLE %s.test (k text, 
c1 text, c2 text, PRIMARY KEY (k))") +
+ (compression == false ? " WITH compression = 
{'enabled' : false};" : ";"));
 
 insert(cluster,0, 1000, 1, 2, 3);
 flush(cluster, 1);
@@ -94,42 +116,37 @@ public class RepairTest extends DistributedTestBase
 verify(cluster,0, 1000, 1, 2, 3);
 verify(cluster, 1000, 1001, 1, 2);
 verify(cluster, 1001, 2001, 1, 2, 3);
-return cluster;
 }
 catch (Throwable t)
 {
 cluster.close();

[jira] [Updated] (CASSANDRA-15288) Read sidecar.yaml from sidecar.config System Property instead of classpath

2019-08-23 Thread Dinesh Joshi (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-15288:
-
Status: Ready to Commit  (was: Review In Progress)

+1

> Read sidecar.yaml from sidecar.config System Property instead of classpath
> --
>
> Key: CASSANDRA-15288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15288
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Sidecar
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
>  Labels: pull-request-available
>
> I was experimenting earlier with running multiple sidecar instances against 
> multiple local C* nodes (using a ccm cluster) and noticed that the 
> distribution of sidecar did not include the conf directory and instead was 
> loading sidecar.yaml from the classpath. I noticed the lines in build.gradle:
> {code:java}
> // Config file location should be in file:/// format for local files,
> // when we have the fix for adding /conf directory to classpaht, we can get 
> away with below default JvmArg
> {code}
> From this statement I assume the expectation was that eventually the 
> sidecar.config system property would be used to locate the sidecar.yaml file.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15289) bad merge reverted CASSANDRA-14993

2019-08-23 Thread Blake Eggleston (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Eggleston updated CASSANDRA-15289:

Test and Documentation Plan: circle
 Status: Patch Available  (was: In Progress)

|[3.0|https://github.com/bdeggleston/cassandra/tree/15289-3.0]|[circle|https://circleci.com/gh/bdeggleston/workflows/cassandra/tree/15289-3.0]|
|[3.11|https://github.com/bdeggleston/cassandra/tree/15289-3.11]|[circle|https://circleci.com/gh/bdeggleston/workflows/cassandra/tree/15289-3.11]|
|[trunk|https://github.com/bdeggleston/cassandra/tree/15289-trunk]|[circle|https://circleci.com/gh/bdeggleston/workflows/cassandra/tree/15289-trunk]|

> bad merge reverted CASSANDRA-14993
> --
>
> Key: CASSANDRA-15289
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15289
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/SSTable
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15289) bad merge reverted CASSANDRA-14993

2019-08-23 Thread Blake Eggleston (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Eggleston updated CASSANDRA-15289:

 Bug Category: Parent values: Degradation(12984)Level 1 values: Other 
Exception(12998)
   Complexity: Low Hanging Fruit
  Component/s: Local/SSTable
Discovered By: User Report
Reviewers: Stefan Podkowinski
 Severity: Normal
 Assignee: Blake Eggleston
   Status: Open  (was: Triage Needed)

> bad merge reverted CASSANDRA-14993
> --
>
> Key: CASSANDRA-15289
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15289
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/SSTable
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-15289) bad merge reverted CASSANDRA-14993

2019-08-23 Thread Blake Eggleston (Jira)
Blake Eggleston created CASSANDRA-15289:
---

 Summary: bad merge reverted CASSANDRA-14993
 Key: CASSANDRA-15289
 URL: https://issues.apache.org/jira/browse/CASSANDRA-15289
 Project: Cassandra
  Issue Type: Bug
Reporter: Blake Eggleston






--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk

2019-08-23 Thread snazy
This is an automated email from the ASF dual-hosted git repository.

snazy pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git

commit c79422d7f50472daea75c9e8a246f6d76b13d4f2
Merge: cf55294 eb2c549
Author: Robert Stupp 
AuthorDate: Fri Aug 23 14:15:26 2019 +0200

Merge branch 'cassandra-3.11' into trunk



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch trunk updated (cf55294 -> c79422d)

2019-08-23 Thread snazy
This is an automated email from the ASF dual-hosted git repository.

snazy pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git.


from cf55294  Merge branch 'cassandra-3.11' into trunk
 new eb2c549  ninja: fix build error on LegacyLayoutTest
 new c79422d  Merge branch 'cassandra-3.11' into trunk

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch cassandra-3.11 updated: ninja: fix build error on LegacyLayoutTest

2019-08-23 Thread snazy
This is an automated email from the ASF dual-hosted git repository.

snazy pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/cassandra-3.11 by this push:
 new eb2c549  ninja: fix build error on LegacyLayoutTest
eb2c549 is described below

commit eb2c549940baf0e30a8c07ea51fe4a1d828ca3ac
Author: Paulo Motta 
AuthorDate: Fri Aug 23 09:06:45 2019 -0300

ninja: fix build error on LegacyLayoutTest
---
 test/unit/org/apache/cassandra/db/LegacyLayoutTest.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java 
b/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java
index 4058b03..5a08e3e 100644
--- a/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java
+++ b/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java
@@ -374,8 +374,8 @@ public class LegacyLayoutTest
 ByteBuffer one = Int32Type.instance.decompose(1);
 ByteBuffer two = Int32Type.instance.decompose(2);
 PartitionUpdate p = new PartitionUpdate(table, table.decorateKey(one), 
table.partitionColumns(), 0);
-p.add(new RangeTombstone(Slice.make(new 
Slice.Bound(ClusteringPrefix.Kind.EXCL_START_BOUND, new ByteBuffer[] { one, one 
}),
-new 
Slice.Bound(ClusteringPrefix.Kind.INCL_END_BOUND, new ByteBuffer[] { two })),
+p.add(new RangeTombstone(Slice.make(new 
ClusteringBound(ClusteringPrefix.Kind.EXCL_START_BOUND, new ByteBuffer[] { one, 
one }),
+new 
ClusteringBound(ClusteringPrefix.Kind.INCL_END_BOUND, new ByteBuffer[] { two 
})),
  new DeletionTime(1, 1)
 ));
 


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15274) Multiple Corrupt datafiles across entire environment

2019-08-23 Thread Phil O Conduin (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914135#comment-16914135
 ] 

Phil O Conduin commented on CASSANDRA-15274:


Hi [~benedict]

We are having trouble building the code to bypass the setCrcCheckChance. 

On the new build when we run sstable2json it still hits the chunk exception.

Any chance you could help us on our version of the code - 2.2.13?

> Multiple Corrupt datafiles across entire environment 
> -
>
> Key: CASSANDRA-15274
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15274
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Compaction
>Reporter: Phil O Conduin
>Priority: Normal
>
> Cassandra Version: 2.2.13
> PRE-PROD environment.
>  * 2 datacenters.
>  * 9 physical servers in each datacenter - (_Cisco UCS C220 M4 SFF_)
>  * 4 Cassandra instances on each server (cass_a, cass_b, cass_c, cass_d)
>  * 72 Cassandra instances across the 2 data centres, 36 in site A, 36 in site 
> B.
> We also have 2 Reaper Nodes we use for repair.  One reaper node in each 
> datacenter each running with its own Cassandra back end in a cluster together.
> OS Details [Red Hat Linux]
> cass_a@x 0 10:53:01 ~ $ uname -a
> Linux x 3.10.0-957.5.1.el7.x86_64 #1 SMP Wed Dec 19 10:46:58 EST 2018 x86_64 
> x86_64 x86_64 GNU/Linux
> cass_a@x 0 10:57:31 ~ $ cat /etc/*release
> NAME="Red Hat Enterprise Linux Server"
> VERSION="7.6 (Maipo)"
> ID="rhel"
> Storage Layout 
> cass_a@xx 0 10:46:28 ~ $ df -h
> Filesystem                         Size  Used Avail Use% Mounted on
> /dev/mapper/vg01-lv_root            20G  2.2G   18G  11% /
> devtmpfs                            63G     0   63G   0% /dev
> tmpfs                               63G     0   63G   0% /dev/shm
> tmpfs                               63G  4.1G   59G   7% /run
> tmpfs                               63G     0   63G   0% /sys/fs/cgroup
> >> 4 cassandra instances
> /dev/sdd                           1.5T  802G  688G  54% /data/ssd4
> /dev/sda                           1.5T  798G  692G  54% /data/ssd1
> /dev/sdb                           1.5T  681G  810G  46% /data/ssd2
> /dev/sdc                           1.5T  558G  932G  38% /data/ssd3
> Cassandra load is about 200GB and the rest of the space is snapshots
> CPU
> cass_a@x 127 10:58:47 ~ $ lscpu | grep -E '^Thread|^Core|^Socket|^CPU\('
> CPU(s):                64
> Thread(s) per core:    2
> Core(s) per socket:    16
> Socket(s):             2
> *Description of problem:*
> During repair of the cluster, we are seeing multiple corruptions in the log 
> files on a lot of instances.  There seems to be no pattern to the corruption. 
>  It seems that the repair job is finding all the corrupted files for us.  The 
> repair will hang on the node where the corrupted file is found.  To fix this 
> we remove/rename the datafile and bounce the Cassandra instance.  Our 
> hardware/OS team have stated there is no problem on their side.  I do not 
> believe it the repair causing the corruption. 
>  
> So let me give you an example of a corrupted file and maybe someone might be 
> able to work through it with me?
> When this corrupted file was reported in the log it looks like it was the 
> repair that found it.
> $ journalctl -u cassmeta-cass_b.service --since "2019-08-07 22:25:00" --until 
> "2019-08-07 22:45:00"
> Aug 07 22:30:33 cassandra[34611]: INFO  21:30:33 Writing 
> Memtable-compactions_in_progress@830377457(0.008KiB serialized bytes, 1 ops, 
> 0%/0% of on/off-heap limit)
> Aug 07 22:30:33 cassandra[34611]: ERROR 21:30:33 Failed creating a merkle 
> tree for [repair #9587a200-b95a-11e9-8920-9f72868b8375 on KeyspaceMetadata/x, 
> (-1476350953672479093,-1474461
> Aug 07 22:30:33 cassandra[34611]: ERROR 21:30:33 Exception in thread 
> Thread[ValidationExecutor:825,1,main]
> Aug 07 22:30:33 cassandra[34611]: org.apache.cassandra.io.FSReadError: 
> org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted: 
> /x/ssd2/data/KeyspaceMetadata/x-1e453cb0
> Aug 07 22:30:33 cassandra[34611]: at 
> org.apache.cassandra.io.util.RandomAccessReader.readBytes(RandomAccessReader.java:365)
>  ~[apache-cassandra-2.2.13.jar:2.2.13]
> Aug 07 22:30:33 cassandra[34611]: at 
> org.apache.cassandra.utils.ByteBufferUtil.read(ByteBufferUtil.java:361) 
> ~[apache-cassandra-2.2.13.jar:2.2.13]
> Aug 07 22:30:33 cassandra[34611]: at 
> org.apache.cassandra.utils.ByteBufferUtil.readWithShortLength(ByteBufferUtil.java:340)
>  ~[apache-cassandra-2.2.13.jar:2.2.13]
> Aug 07 22:30:33 cassandra[34611]: at 
> org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:382)
>  ~[apache-cassandra-2.2.13.jar:2.2.13]
> Aug 07 22:30:33 cassandra[34611]: at 
>