[jira] [Commented] (CASSANDRA-15344) "tablestats" should be used instead of "cfstats"
[ https://issues.apache.org/jira/browse/CASSANDRA-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946251#comment-16946251 ] DeepakVohra commented on CASSANDRA-15344: - _cfstats_ is not listed in documentation http://cassandra.apache.org/doc/latest/tools/nodetool/nodetool.html But, it is fine if the code supports _cfstats_. > "tablestats" should be used instead of "cfstats" > > > Key: CASSANDRA-15344 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15344 > Project: Cassandra > Issue Type: Bug >Reporter: DeepakVohra >Priority: Normal > > As _nodetool cfstats_ has been renamed/aliased to _nodetool tablestats_ > should CASSANDRA-13889 be referring to _cfstats_? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946196#comment-16946196
]
Andy Tolbert commented on CASSANDRA-10190:
--
Hi [~djoshi],interesting! The 2 new failures seem to be related to copy code,
so it's probably a regression from my commit. Nothing sticks out as obvious to
me as well at the moment, I'll take a look tonight and will get to the bottom
of it. Will also see if I can wrap my head around the {{test_describe}} test.
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Fix For: 4.0, 4.0-alpha
>
> Attachments: 0001-Update-six-to-1.12.0.patch,
> 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch,
> coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946188#comment-16946188 ] Dinesh Joshi commented on CASSANDRA-10190: -- [~andrew.tolbert], looks like there are a few [test failures|https://circleci.com/gh/dineshjoshi/cassandra/1229#tests/containers/31]. I could not spot anything obvious. Do you mind looking into them? > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Fix For: 4.0, 4.0-alpha > > Attachments: 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15248) Upgrade Guava to latest on master branch
[ https://issues.apache.org/jira/browse/CASSANDRA-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946169#comment-16946169 ] Sumanth Pasupuleti edited comment on CASSANDRA-15248 at 10/7/19 7:44 PM: - [~sarkara1] fyi, Guava upgrade is now committed (along with java-driver upgrade) - CASSANDRA-14655 was (Author: sumanth.pasupuleti): [~sarkara1] fyi, Guava upgrade is now committed (along with java-driver upgrade) - https://issues.apache.org/jira/browse/CASSANDRA-14655 > Upgrade Guava to latest on master branch > > > Key: CASSANDRA-15248 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15248 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Packaging >Reporter: Abhijit Sarkar >Priority: Normal > > Upgrade Guava to latest on master branch. See > https://issues.apache.org/jira/browse/CASSANDRA-15245. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15248) Upgrade Guava to latest on master branch
[ https://issues.apache.org/jira/browse/CASSANDRA-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946169#comment-16946169 ] Sumanth Pasupuleti commented on CASSANDRA-15248: [~sarkara1] fyi, Guava upgrade is now committed (along with java-driver upgrade) - https://issues.apache.org/jira/browse/CASSANDRA-14655 > Upgrade Guava to latest on master branch > > > Key: CASSANDRA-15248 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15248 > Project: Cassandra > Issue Type: Task > Components: Build, Dependencies, Packaging >Reporter: Abhijit Sarkar >Priority: Normal > > Upgrade Guava to latest on master branch. See > https://issues.apache.org/jira/browse/CASSANDRA-15245. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)
[ https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946168#comment-16946168 ] Sumanth Pasupuleti commented on CASSANDRA-14655: Thanks [~mck] for the review and commit! > Upgrade C* to use latest guava (27.0) > - > > Key: CASSANDRA-14655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14655 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Low > Labels: 4.0-feature-freeze-review-requested > Fix For: 4.0-alpha > > Attachments: 14655-4.0.txt > > > C* currently uses guava 23.3. This JIRA is about changing C* to use latest > guava (26.0). Originated from a discussion in the mailing list. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)
[ https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946159#comment-16946159 ] Michael Semb Wever edited comment on CASSANDRA-14655 at 10/7/19 7:24 PM: - Committed as 38b49904dd1c71fcb16abfbc205edfd6ce008b76 (moved the CHANGES line entry to the top, they are in reverse chronological order) was (Author: michaelsembwever): Committed as 38b49904dd1c71fcb16abfbc205edfd6ce008b76 > Upgrade C* to use latest guava (27.0) > - > > Key: CASSANDRA-14655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14655 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Low > Labels: 4.0-feature-freeze-review-requested > Fix For: 4.0-alpha > > Attachments: 14655-4.0.txt > > > C* currently uses guava 23.3. This JIRA is about changing C* to use latest > guava (26.0). Originated from a discussion in the mailing list. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)
[ https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-14655: --- Status: Ready to Commit (was: Review In Progress) > Upgrade C* to use latest guava (27.0) > - > > Key: CASSANDRA-14655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14655 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Low > Labels: 4.0-feature-freeze-review-requested > Fix For: 4.x > > Attachments: 14655-4.0.txt > > > C* currently uses guava 23.3. This JIRA is about changing C* to use latest > guava (26.0). Originated from a discussion in the mailing list. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14655) Upgrade C* to use latest guava (27.0)
[ https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-14655: --- Fix Version/s: (was: 4.x) 4.0-alpha Source Control Link: https://github.com/apache/cassandra/commit/38b49904dd1c71fcb16abfbc205edfd6ce008b76 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as 38b49904dd1c71fcb16abfbc205edfd6ce008b76 > Upgrade C* to use latest guava (27.0) > - > > Key: CASSANDRA-14655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14655 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Low > Labels: 4.0-feature-freeze-review-requested > Fix For: 4.0-alpha > > Attachments: 14655-4.0.txt > > > C* currently uses guava 23.3. This JIRA is about changing C* to use latest > guava (26.0). Originated from a discussion in the mailing list. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Upgrading Guava to 27, and to java-driver 3.6.0 (from 3.4.0-SNAPSHOT), plus refactoring to remove nativePort argument for NativeSSTableLoaderClient constructor
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 38b4990 Upgrading Guava to 27, and to java-driver 3.6.0 (from
3.4.0-SNAPSHOT), plus refactoring to remove nativePort argument for
NativeSSTableLoaderClient constructor
38b4990 is described below
commit 38b49904dd1c71fcb16abfbc205edfd6ce008b76
Author: Sumanth Pasupuleti
AuthorDate: Tue Apr 10 15:01:48 2018 -0700
Upgrading Guava to 27, and to java-driver 3.6.0 (from 3.4.0-SNAPSHOT), plus
refactoring to remove nativePort argument for NativeSSTableLoaderClient
constructor
Patch by Sumanth Pasupuleti; reviewed by Michael Semb Wever for
CASSANDRA-14655
---
CHANGES.txt| 1 +
build.xml | 12 +---
...cassandra-driver-core-3.4.0-SNAPSHOT-shaded.jar | Bin 2624086 -> 0 bytes
lib/cassandra-driver-core-3.6.0-shaded.jar | Bin 0 -> 2725381 bytes
lib/guava-23.3-jre.jar | Bin 2655564 -> 0 bytes
lib/guava-27.0-jre.jar | Bin 0 -> 2747878 bytes
.../apache/cassandra/audit/AuditLogManager.java| 1 -
.../cassandra/hadoop/cql3/CqlBulkRecordWriter.java | 4 +-
.../cassandra/hadoop/cql3/CqlConfigHelper.java | 12
.../cassandra/index/SecondaryIndexManager.java | 6 +-
.../cassandra/io/sstable/format/SSTableFormat.java | 2 +-
.../org/apache/cassandra/repair/RepairJob.java | 4 +-
.../apache/cassandra/repair/RepairRunnable.java| 6 +-
.../org/apache/cassandra/repair/RepairSession.java | 2 +-
.../repair/consistent/CoordinatorSession.java | 2 +-
.../cassandra/repair/consistent/LocalSessions.java | 3 +-
.../apache/cassandra/service/StorageService.java | 6 +-
.../cassandra/streaming/StreamResultFuture.java| 3 +-
.../org/apache/cassandra/tools/BulkLoader.java | 10 +--
.../org/apache/cassandra/tools/LoaderOptions.java | 72 +
.../cassandra/utils/NativeSSTableLoaderClient.java | 29 ++---
test/unit/org/apache/cassandra/cql3/CQLTester.java | 4 ++
.../db/repair/PendingAntiCompactionTest.java | 2 +-
.../apache/cassandra/hints/HintsServiceTest.java | 3 +-
.../org/apache/cassandra/net/MockMessagingSpy.java | 7 +-
.../cassandra/streaming/StreamingTransferTest.java | 4 +-
.../org/apache/cassandra/tools/BulkLoaderTest.java | 72 +
.../cassandra/stress/settings/SettingsNode.java| 6 +-
.../cassandra/stress/util/JavaDriverClient.java| 4 --
29 files changed, 150 insertions(+), 127 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 1ecda8b..a72386a 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0-alpha2
+ * Upgrade Guava to 27, and to java-driver 3.6.0 (from 3.4.0-SNAPSHOT)
(CASSANDRA-14655)
* Extract an AbstractCompactionController to allow for custom implementations
(CASSANDRA-15286)
* Move chronicle-core version from snapshot to stable, and include
carrotsearch in generated pom.xml (CASSANDRA-15321)
* Untangle RepairMessage sub-hierarchy of messages, use new messaging (more)
correctly (CASSANDRA-15163)
diff --git a/build.xml b/build.xml
index 3eb074f..73539df 100644
--- a/build.xml
+++ b/build.xml
@@ -487,7 +487,7 @@
-
+
@@ -557,15 +557,13 @@
-
@@ -647,9 +645,7 @@
-
@@ -666,9 +662,7 @@
artifactId="cassandra-parent"
version="${version}"/>
-
@@ -743,14 +737,12 @@
-
diff --git a/lib/cassandra-driver-core-3.4.0-SNAPSHOT-shaded.jar
b/lib/cassandra-driver-core-3.4.0-SNAPSHOT-shaded.jar
deleted file mode 100644
index 1290dc3..000
Binary files a/lib/cassandra-driver-core-3.4.0-SNAPSHOT-shaded.jar and
/dev/null differ
diff --git a/lib/cassandra-driver-core-3.6.0-shaded.jar
b/lib/cassandra-driver-core-3.6.0-shaded.jar
new file mode 100644
index 000..ea06b02
Binary files /dev/null and b/lib/cassandra-driver-core-3.6.0-shaded.jar differ
diff --git a/lib/guava-23.3-jre.jar b/lib/guava-23.3-jre.jar
deleted file mode 100644
index b13e275..000
Binary files a/lib/guava-23.3-jre.jar and /dev/null differ
diff --git a/lib/guava-27.0-jre.jar b/lib/guava-27.0-jre.jar
new file mode 100644
index 000..1bdd007
Binary files /dev/null and b/lib/guava-27.0-jre.jar differ
diff --git a/src/java/org/apache/cassandra/audit/AuditLogManager.java
b/src/java/org/apache/cassandra/audit/AuditLogManager.java
index d11eaa0..bc2126c 100644
--- a/src/java/org/apache/cassandra/audit/AuditLogManager.java
+++
[jira] [Commented] (CASSANDRA-15329) in-JVM dtest fails on java 11 since system ClassLoader is not a URLClassLoader
[ https://issues.apache.org/jira/browse/CASSANDRA-15329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946157#comment-16946157 ] David Capwell commented on CASSANDRA-15329: --- "would you mind if I switched from stream API to regular array allocation?" I don't mind. If you want I can do that later today. > in-JVM dtest fails on java 11 since system ClassLoader is not a URLClassLoader > -- > > Key: CASSANDRA-15329 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15329 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Attachments: CASSANDRA-15329.patch > > > When running the in-JVM dtests on on java 11 they fail while trying to cast > the Versions.class.getClassLoader to URLClassLoader, which is no longer the > default ClassLoader on java 11. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15335) Node can corrupt gossip state and become unreplaceable
[
https://issues.apache.org/jira/browse/CASSANDRA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Eggleston updated CASSANDRA-15335:
Since Version: 3.0.0
Source Control Link:
https://github.com/apache/cassandra/commit/39a431d9d821cf6bcb54da7198b6a64e09b0f120
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
committed to 3.0 as [39a431d9d821cf6bcb54da7198b6a64e09b0f120
|https://github.com/apache/cassandra/commit/39a431d9d821cf6bcb54da7198b6a64e09b0f120]
and merged up, thanks!
> Node can corrupt gossip state and become unreplaceable
> --
>
> Key: CASSANDRA-15335
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15335
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> In {{StorageService#prepareToJoin}}, a starting node first sends out an
> endpoint state without any tokens. Later, in
> {{StorageService#finishJoiningRing}} it sends out an endpoint state _with_
> it’s tokens. If that node dies between these 2 events and cannot be restarted
> due to some unrecoverable error, the ring’s gossip state will be missing
> tokens for that node. This won’t cause any immediate data loss since TMD is
> populated from system.peers, but it will prevent a replacement node from
> associating that address with it’s tokens and replacing it. It could also
> cause data loss if other nodes are added to the ring and don’t see an owned
> token where there should be one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-10190: - Status: Changes Suggested (was: Review In Progress) > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Fix For: 4.0, 4.0-alpha > > Attachments: 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946136#comment-16946136 ] Dinesh Joshi commented on CASSANDRA-10190: -- Hi [~andrew.tolbert], thanks for the review comments. I have pulled your changes to my branch [here|https://github.com/dineshjoshi/cassandra/tree/10190-rebase-20190609]. The circleci tests are running [here|https://circleci.com/workflow-run/4806c5fa-537d-4964-894a-bc4b05958679]. If everything looks good, I'll do a final review, squash and merge so folks can start testing out Python 3 compatibility. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Fix For: 4.0, 4.0-alpha > > Attachments: 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-10190: - Reviewers: Andy Tolbert, Dinesh Joshi, Dinesh Joshi (was: Andy Tolbert, Dinesh Joshi) Andy Tolbert, Dinesh Joshi, Dinesh Joshi (was: Dinesh Joshi) Status: Review In Progress (was: Patch Available) > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Fix For: 4.0, 4.0-alpha > > Attachments: 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit e8ff2f2b8ebb3990b99c81f839f6463bbff381f4 Merge: 4a831de a63df4d Author: Blake Eggleston AuthorDate: Mon Oct 7 11:35:28 2019 -0700 Merge branch 'cassandra-3.11' into trunk CHANGES.txt | 1 + src/java/org/apache/cassandra/service/StorageService.java | 9 + 2 files changed, 10 insertions(+) diff --cc CHANGES.txt index 22a83fa,3544594..1ecda8b --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,391 -1,3 +1,392 @@@ +4.0-alpha2 + * Extract an AbstractCompactionController to allow for custom implementations (CASSANDRA-15286) + * Move chronicle-core version from snapshot to stable, and include carrotsearch in generated pom.xml (CASSANDRA-15321) + * Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly (CASSANDRA-15163) + * Add `allocate_tokens_for_local_replication_factor` option for token allocation (CASSANDRA-15260) + * Add Alibaba Cloud Platform snitch (CASSANDRA-15092) +Merged from 3.0: ++ * Gossip tokens on startup if available (CASSANDRA-15335) + * Fix resource leak in CompressedSequentialWriter (CASSANDRA-15340) + * Fix bad merge that reverted CASSANDRA-14993 (CASSANDRA-15289) + + +4.0-alpha1 + * Inaccurate exception message with nodetool snapshot (CASSANDRA-15287) + * Fix InternodeOutboundMetrics overloaded bytes/count mixup (CASSANDRA-15186) + * Enhance & reenable RepairTest with compression=off and compression=on (CASSANDRA-15272) + * Improve readability of Table metrics Virtual tables units (CASSANDRA-15194) + * Fix error with non-existent table for nodetool tablehistograms (CASSANDRA-14410) + * Avoid result truncation in decimal operations (CASSANDRA-15232) + * Catch non-IOException in FileUtils.close to make sure that all resources are closed (CASSANDRA-15225) + * Align load column in nodetool status output (CASSANDRA-14787) + * CassandraNetworkAuthorizer uses cached roles info (CASSANDRA-15089) + * Introduce optional timeouts for idle client sessions (CASSANDRA-11097) + * Fix AlterTableStatement dropped type validation order (CASSANDRA-15203) + * Update Netty dependencies to latest, clean up SocketFactory (CASSANDRA-15195) + * Native Transport - Apply noSpamLogger to ConnectionLimitHandler (CASSANDRA-15167) + * Reduce heap pressure during compactions (CASSANDRA-14654) + * Support building Cassandra with JDK 11 (CASSANDRA-15108) + * Use quilt to patch cassandra.in.sh in Debian packaging (CASSANDRA-14710) + * Take sstable references before calculating approximate key count (CASSANDRA-14647) + * Restore snapshotting of system keyspaces on version change (CASSANDRA-14412) + * Fix AbstractBTreePartition locking in java 11 (CASSANDRA-14607) + * SimpleClient should pass connection properties as options (CASSANDRA-15056) + * Set repaired data tracking flag on range reads if enabled (CASSANDRA-15019) + * Calculate pending ranges for BOOTSTRAP_REPLACE correctly (CASSANDRA-14802) + * Make TableCQLHelper reuse the single quote pattern (CASSANDRA-15033) + * Add Zstd compressor (CASSANDRA-14482) + * Fix IR prepare anti-compaction race (CASSANDRA-15027) + * Fix SimpleStrategy option validation (CASSANDRA-15007) + * Don't try to cancel 2i compactions when starting anticompaction (CASSANDRA-15024) + * Avoid NPE in RepairRunnable.recordFailure (CASSANDRA-15025) + * SSL Cert Hot Reloading should check for sanity of the new keystore/truststore before loading it (CASSANDRA-14991) + * Avoid leaking threads when failing anticompactions and rate limit anticompactions (CASSANDRA-15002) + * Validate token() arguments early instead of throwing NPE at execution (CASSANDRA-14989) + * Add a new tool to dump audit logs (CASSANDRA-14885) + * Fix generating javadoc with Java11 (CASSANDRA-14988) + * Only cancel conflicting compactions when starting anticompactions and sub range compactions (CASSANDRA-14935) + * Use a stub IndexRegistry for non-daemon use cases (CASSANDRA-14938) + * Don't enable client transports when bootstrap is pending (CASSANDRA-14525) + * Make antiCompactGroup throw exception on error and anticompaction non cancellable + again (CASSANDRA-14936) + * Catch empty/invalid bounds in SelectStatement (CASSANDRA-14849) + * Auto-expand replication_factor for NetworkTopologyStrategy (CASSANDRA-14303) + * Transient Replication: support EACH_QUORUM (CASSANDRA-14727) + * BufferPool: allocating thread for new chunks should acquire directly (CASSANDRA-14832) + * Send correct messaging version in internode messaging handshake's third message (CASSANDRA-14896) + * Make Read and Write Latency columns consistent for proxyhistograms and tablehistograms (CASSANDRA-11939) + * Make protocol checksum type option case insensitive (CASSANDRA-14716) + * Forbid re-adding static columns as
[cassandra] branch cassandra-3.0 updated: Gossip tokens on startup if available
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new 39a431d Gossip tokens on startup if available
39a431d is described below
commit 39a431d9d821cf6bcb54da7198b6a64e09b0f120
Author: Blake Eggleston
AuthorDate: Tue Sep 24 14:27:18 2019 -0700
Gossip tokens on startup if available
Patch by Blake Eggleston; Reviewed by Marcus Eriksson and Sam Tunnicliffe
for CASSANDRA-15335
---
CHANGES.txt | 1 +
src/java/org/apache/cassandra/service/StorageService.java | 11 +++
2 files changed, 12 insertions(+)
diff --git a/CHANGES.txt b/CHANGES.txt
index 6bf3ee1..ca6ea2e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.19
+ * Gossip tokens on startup if available (CASSANDRA-15335)
* Fix resource leak in CompressedSequentialWriter (CASSANDRA-15340)
* Fix merge which reverted CASSANDRA-14993 (CASSANDRA-15289)
* Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when
upgrading and RangeTombstone bounds are asymmetric (CASSANDRA-15172)
diff --git a/src/java/org/apache/cassandra/service/StorageService.java
b/src/java/org/apache/cassandra/service/StorageService.java
index d349b4b..2af7fb7 100644
--- a/src/java/org/apache/cassandra/service/StorageService.java
+++ b/src/java/org/apache/cassandra/service/StorageService.java
@@ -34,6 +34,7 @@ import javax.management.openmbean.TabularData;
import javax.management.openmbean.TabularDataSupport;
import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Preconditions;
import com.google.common.base.Predicate;
import com.google.common.collect.*;
import com.google.common.util.concurrent.*;
@@ -56,6 +57,7 @@ import org.apache.cassandra.concurrent.ScheduledExecutors;
import org.apache.cassandra.concurrent.Stage;
import org.apache.cassandra.concurrent.StageManager;
import org.apache.cassandra.config.CFMetaData;
+import org.apache.cassandra.config.Config;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.config.Schema;
import org.apache.cassandra.config.ViewDefinition;
@@ -767,6 +769,15 @@ public class StorageService extends
NotificationBroadcasterSupport implements IE
{
checkForEndpointCollision();
}
+else if (SystemKeyspace.bootstrapComplete())
+{
+Preconditions.checkState(!Config.isClientMode());
+// tokens are only ever saved to system.local after bootstrap
has completed and we're joining the ring,
+// or when token update operations (move, decom) are completed
+Collection savedTokens =
SystemKeyspace.getSavedTokens();
+if (!savedTokens.isEmpty())
+appStates.put(ApplicationState.TOKENS,
valueFactory.tokens(savedTokens));
+}
// have to start the gossip service before we can see any info on
other nodes. this is necessary
// for bootstrap to get the load info it needs.
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (d0e0e02 -> a63df4d)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from d0e0e02 Merge branch 'cassandra-3.0' into cassandra-3.11 new 39a431d Gossip tokens on startup if available new a63df4d Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + src/java/org/apache/cassandra/service/StorageService.java | 11 +++ 2 files changed, 12 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit a63df4de3e64c5aeaafa1cf147e512051c060764
Merge: d0e0e02 39a431d
Author: Blake Eggleston
AuthorDate: Mon Oct 7 11:33:17 2019 -0700
Merge branch 'cassandra-3.0' into cassandra-3.11
CHANGES.txt | 1 +
src/java/org/apache/cassandra/service/StorageService.java | 11 +++
2 files changed, 12 insertions(+)
diff --cc CHANGES.txt
index 11a7234,ca6ea2e..3544594
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,11 -1,7 +1,12 @@@
-3.0.19
+3.11.5
+ * Make sure user defined compaction transactions are always closed
(CASSANDRA-15123)
+ * Fix cassandra-env.sh to use $CASSANDRA_CONF to find cassandra-jaas.config
(CASSANDRA-14305)
+ * Fixed nodetool cfstats printing index name twice (CASSANDRA-14903)
+ * Add flag to disable SASI indexes, and warnings on creation
(CASSANDRA-14866)
+Merged from 3.0:
+ * Gossip tokens on startup if available (CASSANDRA-15335)
* Fix resource leak in CompressedSequentialWriter (CASSANDRA-15340)
- * Fix merge which reverted CASSANDRA-14993 (CASSANDRA-15289)
+ * Fix bad merge that reverted CASSANDRA-14993 (CASSANDRA-15289)
* Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when
upgrading and RangeTombstone bounds are asymmetric (CASSANDRA-15172)
* Fix NPE when using allocate_tokens_for_keyspace on new DC/rack
(CASSANDRA-14952)
* Filter sstables earlier when running cleanup (CASSANDRA-15100)
diff --cc src/java/org/apache/cassandra/service/StorageService.java
index 000c2fb,2af7fb7..346f9a4
--- a/src/java/org/apache/cassandra/service/StorageService.java
+++ b/src/java/org/apache/cassandra/service/StorageService.java
@@@ -55,9 -57,9 +56,10 @@@ import org.apache.cassandra.concurrent.
import org.apache.cassandra.concurrent.Stage;
import org.apache.cassandra.concurrent.StageManager;
import org.apache.cassandra.config.CFMetaData;
+ import org.apache.cassandra.config.Config;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.config.Schema;
+import org.apache.cassandra.config.SchemaConstants;
import org.apache.cassandra.config.ViewDefinition;
import org.apache.cassandra.db.*;
import org.apache.cassandra.db.commitlog.CommitLog;
@@@ -819,9 -764,19 +821,18 @@@ public class StorageService extends Not
appStates.put(ApplicationState.STATUS,
valueFactory.hibernate(true));
}
}
-else if (shouldBootstrap())
-{
-checkForEndpointCollision();
-}
-else if (SystemKeyspace.bootstrapComplete())
+else
{
-Preconditions.checkState(!Config.isClientMode());
-// tokens are only ever saved to system.local after bootstrap
has completed and we're joining the ring,
-// or when token update operations (move, decom) are completed
-Collection savedTokens =
SystemKeyspace.getSavedTokens();
-if (!savedTokens.isEmpty())
-appStates.put(ApplicationState.TOKENS,
valueFactory.tokens(savedTokens));
+checkForEndpointCollision(localHostId,
SystemKeyspace.loadHostIds().keySet());
++if (SystemKeyspace.bootstrapComplete())
++{
++Preconditions.checkState(!Config.isClientMode());
++// tokens are only ever saved to system.local after
bootstrap has completed and we're joining the ring,
++// or when token update operations (move, decom) are
completed
++Collection savedTokens =
SystemKeyspace.getSavedTokens();
++if (!savedTokens.isEmpty())
++appStates.put(ApplicationState.TOKENS,
valueFactory.tokens(savedTokens));
++}
}
// have to start the gossip service before we can see any info on
other nodes. this is necessary
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (4a831de -> e8ff2f2)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 4a831de Merge branch 'cassandra-3.11' into trunk new 39a431d Gossip tokens on startup if available new a63df4d Merge branch 'cassandra-3.0' into cassandra-3.11 new e8ff2f2 Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + src/java/org/apache/cassandra/service/StorageService.java | 9 + 2 files changed, 10 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15340) Resource leak in CompressedSequentialWriter
[
https://issues.apache.org/jira/browse/CASSANDRA-15340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Eggleston updated CASSANDRA-15340:
Since Version: 3.0.0
Source Control Link:
https://github.com/apache/cassandra/commit/cbecd5f2834f233f1c7c912407343cc3a9b517bb
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
committed to 3.0 as [cbecd5f2834f233f1c7c912407343cc3a9b517bb
|https://github.com/apache/cassandra/commit/cbecd5f2834f233f1c7c912407343cc3a9b517bb]
and merged up
> Resource leak in CompressedSequentialWriter
> ---
>
> Key: CASSANDRA-15340
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15340
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> In CompressedSequentialWriter, we reallocate the {{compressed}} buffer if the
> existing buffer is not large enough. These buffers are usually direct byte
> buffers, and we don't explicitly release their memory here, which delays
> release until the buffer is gc'd
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit d0e0e021d6a281f848bdda454aad2c19b40622fe Merge: 5e5a107 cbecd5f Author: Blake Eggleston AuthorDate: Mon Oct 7 11:17:02 2019 -0700 Merge branch 'cassandra-3.0' into cassandra-3.11 CHANGES.txt| 1 + .../org/apache/cassandra/io/compress/CompressedSequentialWriter.java | 3 +++ 2 files changed, 4 insertions(+) diff --cc CHANGES.txt index 5837a3d,6bf3ee1..11a7234 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,10 -1,6 +1,11 @@@ -3.0.19 +3.11.5 + * Make sure user defined compaction transactions are always closed (CASSANDRA-15123) + * Fix cassandra-env.sh to use $CASSANDRA_CONF to find cassandra-jaas.config (CASSANDRA-14305) + * Fixed nodetool cfstats printing index name twice (CASSANDRA-14903) + * Add flag to disable SASI indexes, and warnings on creation (CASSANDRA-14866) +Merged from 3.0: + * Fix resource leak in CompressedSequentialWriter (CASSANDRA-15340) - * Fix merge which reverted CASSANDRA-14993 (CASSANDRA-15289) + * Fix bad merge that reverted CASSANDRA-14993 (CASSANDRA-15289) * Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when upgrading and RangeTombstone bounds are asymmetric (CASSANDRA-15172) * Fix NPE when using allocate_tokens_for_keyspace on new DC/rack (CASSANDRA-14952) * Filter sstables earlier when running cleanup (CASSANDRA-15100) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (eee1772 -> 4a831de)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from eee1772 Merge branch 'cassandra-3.11' into trunk new cbecd5f Fix resource leak in CompressedSequentialWriter new d0e0e02 Merge branch 'cassandra-3.0' into cassandra-3.11 new 4a831de Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/io/compress/CompressedSequentialWriter.java | 3 +++ 2 files changed, 4 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 4a831def0a6b566c0560854b5fe1cb82dc86dd34 Merge: eee1772 d0e0e02 Author: Blake Eggleston AuthorDate: Mon Oct 7 11:19:39 2019 -0700 Merge branch 'cassandra-3.11' into trunk CHANGES.txt| 1 + .../org/apache/cassandra/io/compress/CompressedSequentialWriter.java | 3 +++ 2 files changed, 4 insertions(+) diff --cc CHANGES.txt index d3724e7,11a7234..22a83fa --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,390 -1,3 +1,391 @@@ +4.0-alpha2 + * Extract an AbstractCompactionController to allow for custom implementations (CASSANDRA-15286) + * Move chronicle-core version from snapshot to stable, and include carrotsearch in generated pom.xml (CASSANDRA-15321) + * Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly (CASSANDRA-15163) + * Add `allocate_tokens_for_local_replication_factor` option for token allocation (CASSANDRA-15260) + * Add Alibaba Cloud Platform snitch (CASSANDRA-15092) +Merged from 3.0: ++ * Fix resource leak in CompressedSequentialWriter (CASSANDRA-15340) + * Fix bad merge that reverted CASSANDRA-14993 (CASSANDRA-15289) + + +4.0-alpha1 + * Inaccurate exception message with nodetool snapshot (CASSANDRA-15287) + * Fix InternodeOutboundMetrics overloaded bytes/count mixup (CASSANDRA-15186) + * Enhance & reenable RepairTest with compression=off and compression=on (CASSANDRA-15272) + * Improve readability of Table metrics Virtual tables units (CASSANDRA-15194) + * Fix error with non-existent table for nodetool tablehistograms (CASSANDRA-14410) + * Avoid result truncation in decimal operations (CASSANDRA-15232) + * Catch non-IOException in FileUtils.close to make sure that all resources are closed (CASSANDRA-15225) + * Align load column in nodetool status output (CASSANDRA-14787) + * CassandraNetworkAuthorizer uses cached roles info (CASSANDRA-15089) + * Introduce optional timeouts for idle client sessions (CASSANDRA-11097) + * Fix AlterTableStatement dropped type validation order (CASSANDRA-15203) + * Update Netty dependencies to latest, clean up SocketFactory (CASSANDRA-15195) + * Native Transport - Apply noSpamLogger to ConnectionLimitHandler (CASSANDRA-15167) + * Reduce heap pressure during compactions (CASSANDRA-14654) + * Support building Cassandra with JDK 11 (CASSANDRA-15108) + * Use quilt to patch cassandra.in.sh in Debian packaging (CASSANDRA-14710) + * Take sstable references before calculating approximate key count (CASSANDRA-14647) + * Restore snapshotting of system keyspaces on version change (CASSANDRA-14412) + * Fix AbstractBTreePartition locking in java 11 (CASSANDRA-14607) + * SimpleClient should pass connection properties as options (CASSANDRA-15056) + * Set repaired data tracking flag on range reads if enabled (CASSANDRA-15019) + * Calculate pending ranges for BOOTSTRAP_REPLACE correctly (CASSANDRA-14802) + * Make TableCQLHelper reuse the single quote pattern (CASSANDRA-15033) + * Add Zstd compressor (CASSANDRA-14482) + * Fix IR prepare anti-compaction race (CASSANDRA-15027) + * Fix SimpleStrategy option validation (CASSANDRA-15007) + * Don't try to cancel 2i compactions when starting anticompaction (CASSANDRA-15024) + * Avoid NPE in RepairRunnable.recordFailure (CASSANDRA-15025) + * SSL Cert Hot Reloading should check for sanity of the new keystore/truststore before loading it (CASSANDRA-14991) + * Avoid leaking threads when failing anticompactions and rate limit anticompactions (CASSANDRA-15002) + * Validate token() arguments early instead of throwing NPE at execution (CASSANDRA-14989) + * Add a new tool to dump audit logs (CASSANDRA-14885) + * Fix generating javadoc with Java11 (CASSANDRA-14988) + * Only cancel conflicting compactions when starting anticompactions and sub range compactions (CASSANDRA-14935) + * Use a stub IndexRegistry for non-daemon use cases (CASSANDRA-14938) + * Don't enable client transports when bootstrap is pending (CASSANDRA-14525) + * Make antiCompactGroup throw exception on error and anticompaction non cancellable + again (CASSANDRA-14936) + * Catch empty/invalid bounds in SelectStatement (CASSANDRA-14849) + * Auto-expand replication_factor for NetworkTopologyStrategy (CASSANDRA-14303) + * Transient Replication: support EACH_QUORUM (CASSANDRA-14727) + * BufferPool: allocating thread for new chunks should acquire directly (CASSANDRA-14832) + * Send correct messaging version in internode messaging handshake's third message (CASSANDRA-14896) + * Make Read and Write Latency columns consistent for proxyhistograms and tablehistograms (CASSANDRA-11939) + * Make protocol checksum type option case insensitive (CASSANDRA-14716) + * Forbid re-adding static columns as regular and vice versa (CASSANDRA-14913) + *
[cassandra] branch cassandra-3.11 updated (5e5a107 -> d0e0e02)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 5e5a107 Merge branch 'cassandra-3.0' into cassandra-3.11 new cbecd5f Fix resource leak in CompressedSequentialWriter new d0e0e02 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/io/compress/CompressedSequentialWriter.java | 3 +++ 2 files changed, 4 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Fix resource leak in CompressedSequentialWriter
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new cbecd5f Fix resource leak in CompressedSequentialWriter
cbecd5f is described below
commit cbecd5f2834f233f1c7c912407343cc3a9b517bb
Author: Blake Eggleston
AuthorDate: Mon Sep 30 12:53:03 2019 -0700
Fix resource leak in CompressedSequentialWriter
Patch by Blake Eggleston; Reviewed by Marcus Eriksson for CASSANDRA-15340
---
CHANGES.txt| 1 +
.../org/apache/cassandra/io/compress/CompressedSequentialWriter.java | 3 +++
2 files changed, 4 insertions(+)
diff --git a/CHANGES.txt b/CHANGES.txt
index dd7025e..6bf3ee1 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.19
+ * Fix resource leak in CompressedSequentialWriter (CASSANDRA-15340)
* Fix merge which reverted CASSANDRA-14993 (CASSANDRA-15289)
* Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when
upgrading and RangeTombstone bounds are asymmetric (CASSANDRA-15172)
* Fix NPE when using allocate_tokens_for_keyspace on new DC/rack
(CASSANDRA-14952)
diff --git
a/src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java
b/src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java
index 43f1fd0..9c47513 100644
--- a/src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java
+++ b/src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java
@@ -185,7 +185,10 @@ public class CompressedSequentialWriter extends
SequentialWriter
// compressed chunk size (- 4 bytes reserved for checksum)
int chunkSize = (int)
(metadataWriter.chunkOffsetBy(realMark.nextChunkIndex) - chunkOffset - 4);
if (compressed.capacity() < chunkSize)
+{
+FileUtils.clean(compressed);
compressed = compressor.preferredBufferType().allocate(chunkSize);
+}
try
{
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15289) bad merge reverted CASSANDRA-14993
[ https://issues.apache.org/jira/browse/CASSANDRA-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15289: Fix Version/s: 4.0 3.11.5 3.0.19 Since Version: 3.0.18 Source Control Link: https://github.com/apache/cassandra/commit/a4af4aa60ad0aa6fbb134b44e162970c7a1a20da Resolution: Fixed Status: Resolved (was: Ready to Commit) committed to 3.0 as [a4af4aa60ad0aa6fbb134b44e162970c7a1a20da |https://github.com/apache/cassandra/commit/a4af4aa60ad0aa6fbb134b44e162970c7a1a20da]and merged up > bad merge reverted CASSANDRA-14993 > -- > > Key: CASSANDRA-15289 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15289 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 3.0.19, 3.11.5, 4.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Fix bad merge that reverted CASSANDRA-14993
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new a4af4aa Fix bad merge that reverted CASSANDRA-14993
a4af4aa is described below
commit a4af4aa60ad0aa6fbb134b44e162970c7a1a20da
Author: Blake Eggleston
AuthorDate: Fri Aug 23 10:39:37 2019 -0700
Fix bad merge that reverted CASSANDRA-14993
Patch by Blake Eggleston; Reviewed by Stefan Podkowinski for CASSANDRA-15289
---
CHANGES.txt| 1 +
.../concurrent/AbstractLocalAwareExecutorService.java | 14 ++
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 3f2b4d0..dd7025e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.19
+ * Fix merge which reverted CASSANDRA-14993 (CASSANDRA-15289)
* Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when
upgrading and RangeTombstone bounds are asymmetric (CASSANDRA-15172)
* Fix NPE when using allocate_tokens_for_keyspace on new DC/rack
(CASSANDRA-14952)
* Filter sstables earlier when running cleanup (CASSANDRA-15100)
diff --git
a/src/java/org/apache/cassandra/concurrent/AbstractLocalAwareExecutorService.java
b/src/java/org/apache/cassandra/concurrent/AbstractLocalAwareExecutorService.java
index 6ef12d7..4b1fe05 100644
---
a/src/java/org/apache/cassandra/concurrent/AbstractLocalAwareExecutorService.java
+++
b/src/java/org/apache/cassandra/concurrent/AbstractLocalAwareExecutorService.java
@@ -29,8 +29,9 @@ import java.util.concurrent.TimeoutException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import org.apache.cassandra.tracing.TraceState;
-import org.apache.cassandra.tracing.Tracing;
+import org.apache.cassandra.io.FSError;
+import org.apache.cassandra.io.sstable.CorruptSSTableException;
+import org.apache.cassandra.io.util.FileUtils;
import org.apache.cassandra.utils.concurrent.SimpleCondition;
import org.apache.cassandra.utils.JVMStabilityInspector;
@@ -165,10 +166,15 @@ public abstract class AbstractLocalAwareExecutorService
implements LocalAwareExe
}
catch (Throwable t)
{
-JVMStabilityInspector.inspectThrowable(t);
-logger.warn("Uncaught exception on thread {}",
Thread.currentThread(), t);
+logger.error("Uncaught exception on thread {}",
Thread.currentThread(), t);
result = t;
failure = true;
+if (t instanceof CorruptSSTableException)
+FileUtils.handleCorruptSSTable((CorruptSSTableException)
t);
+else if (t instanceof FSError)
+FileUtils.handleFSError((FSError) t);
+else
+JVMStabilityInspector.inspectThrowable(t);
}
finally
{
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit eee1772a3734d370e0857a3edfbbe8657451c4be Merge: aaa4a60 5e5a107 Author: Blake Eggleston AuthorDate: Mon Oct 7 10:58:11 2019 -0700 Merge branch 'cassandra-3.11' into trunk CHANGES.txt| 2 ++ .../concurrent/AbstractLocalAwareExecutorService.java | 10 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index a901441,5837a3d..d3724e7 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,388 -1,3 +1,390 @@@ +4.0-alpha2 + * Extract an AbstractCompactionController to allow for custom implementations (CASSANDRA-15286) + * Move chronicle-core version from snapshot to stable, and include carrotsearch in generated pom.xml (CASSANDRA-15321) + * Untangle RepairMessage sub-hierarchy of messages, use new messaging (more) correctly (CASSANDRA-15163) + * Add `allocate_tokens_for_local_replication_factor` option for token allocation (CASSANDRA-15260) + * Add Alibaba Cloud Platform snitch (CASSANDRA-15092) ++Merged from 3.0: ++ * Fix bad merge that reverted CASSANDRA-14993 (CASSANDRA-15289) + + +4.0-alpha1 + * Inaccurate exception message with nodetool snapshot (CASSANDRA-15287) + * Fix InternodeOutboundMetrics overloaded bytes/count mixup (CASSANDRA-15186) + * Enhance & reenable RepairTest with compression=off and compression=on (CASSANDRA-15272) + * Improve readability of Table metrics Virtual tables units (CASSANDRA-15194) + * Fix error with non-existent table for nodetool tablehistograms (CASSANDRA-14410) + * Avoid result truncation in decimal operations (CASSANDRA-15232) + * Catch non-IOException in FileUtils.close to make sure that all resources are closed (CASSANDRA-15225) + * Align load column in nodetool status output (CASSANDRA-14787) + * CassandraNetworkAuthorizer uses cached roles info (CASSANDRA-15089) + * Introduce optional timeouts for idle client sessions (CASSANDRA-11097) + * Fix AlterTableStatement dropped type validation order (CASSANDRA-15203) + * Update Netty dependencies to latest, clean up SocketFactory (CASSANDRA-15195) + * Native Transport - Apply noSpamLogger to ConnectionLimitHandler (CASSANDRA-15167) + * Reduce heap pressure during compactions (CASSANDRA-14654) + * Support building Cassandra with JDK 11 (CASSANDRA-15108) + * Use quilt to patch cassandra.in.sh in Debian packaging (CASSANDRA-14710) + * Take sstable references before calculating approximate key count (CASSANDRA-14647) + * Restore snapshotting of system keyspaces on version change (CASSANDRA-14412) + * Fix AbstractBTreePartition locking in java 11 (CASSANDRA-14607) + * SimpleClient should pass connection properties as options (CASSANDRA-15056) + * Set repaired data tracking flag on range reads if enabled (CASSANDRA-15019) + * Calculate pending ranges for BOOTSTRAP_REPLACE correctly (CASSANDRA-14802) + * Make TableCQLHelper reuse the single quote pattern (CASSANDRA-15033) + * Add Zstd compressor (CASSANDRA-14482) + * Fix IR prepare anti-compaction race (CASSANDRA-15027) + * Fix SimpleStrategy option validation (CASSANDRA-15007) + * Don't try to cancel 2i compactions when starting anticompaction (CASSANDRA-15024) + * Avoid NPE in RepairRunnable.recordFailure (CASSANDRA-15025) + * SSL Cert Hot Reloading should check for sanity of the new keystore/truststore before loading it (CASSANDRA-14991) + * Avoid leaking threads when failing anticompactions and rate limit anticompactions (CASSANDRA-15002) + * Validate token() arguments early instead of throwing NPE at execution (CASSANDRA-14989) + * Add a new tool to dump audit logs (CASSANDRA-14885) + * Fix generating javadoc with Java11 (CASSANDRA-14988) + * Only cancel conflicting compactions when starting anticompactions and sub range compactions (CASSANDRA-14935) + * Use a stub IndexRegistry for non-daemon use cases (CASSANDRA-14938) + * Don't enable client transports when bootstrap is pending (CASSANDRA-14525) + * Make antiCompactGroup throw exception on error and anticompaction non cancellable + again (CASSANDRA-14936) + * Catch empty/invalid bounds in SelectStatement (CASSANDRA-14849) + * Auto-expand replication_factor for NetworkTopologyStrategy (CASSANDRA-14303) + * Transient Replication: support EACH_QUORUM (CASSANDRA-14727) + * BufferPool: allocating thread for new chunks should acquire directly (CASSANDRA-14832) + * Send correct messaging version in internode messaging handshake's third message (CASSANDRA-14896) + * Make Read and Write Latency columns consistent for proxyhistograms and tablehistograms (CASSANDRA-11939) + * Make protocol checksum type option case insensitive (CASSANDRA-14716) + * Forbid re-adding static columns as regular and vice versa (CASSANDRA-14913) + * Audit log allows system keyspaces to be audited via
[cassandra] branch cassandra-3.11 updated (eb2c549 -> 5e5a107)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from eb2c549 ninja: fix build error on LegacyLayoutTest new a4af4aa Fix bad merge that reverted CASSANDRA-14993 new 5e5a107 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + .../concurrent/AbstractLocalAwareExecutorService.java| 12 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 5e5a1071cf18266912df884d5cbd8f3397449093 Merge: eb2c549 a4af4aa Author: Blake Eggleston AuthorDate: Mon Oct 7 10:56:33 2019 -0700 Merge branch 'cassandra-3.0' into cassandra-3.11 CHANGES.txt | 1 + .../concurrent/AbstractLocalAwareExecutorService.java| 12 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --cc CHANGES.txt index 2a56985,dd7025e..5837a3d --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,9 -1,5 +1,10 @@@ -3.0.19 - * Fix merge which reverted CASSANDRA-14993 (CASSANDRA-15289) +3.11.5 + * Make sure user defined compaction transactions are always closed (CASSANDRA-15123) + * Fix cassandra-env.sh to use $CASSANDRA_CONF to find cassandra-jaas.config (CASSANDRA-14305) + * Fixed nodetool cfstats printing index name twice (CASSANDRA-14903) + * Add flag to disable SASI indexes, and warnings on creation (CASSANDRA-14866) +Merged from 3.0: ++ * Fix bad merge that reverted CASSANDRA-14993 (CASSANDRA-15289) * Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when upgrading and RangeTombstone bounds are asymmetric (CASSANDRA-15172) * Fix NPE when using allocate_tokens_for_keyspace on new DC/rack (CASSANDRA-14952) * Filter sstables earlier when running cleanup (CASSANDRA-15100) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (aaa4a60 -> eee1772)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from aaa4a60 Extract an AbstractCompactionController to allow for custom implementations new a4af4aa Fix bad merge that reverted CASSANDRA-14993 new 5e5a107 Merge branch 'cassandra-3.0' into cassandra-3.11 new eee1772 Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 2 ++ .../concurrent/AbstractLocalAwareExecutorService.java | 10 +- 2 files changed, 11 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14629) Abstract Virtual Table for very large result sets
[
https://issues.apache.org/jira/browse/CASSANDRA-14629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945993#comment-16945993
]
Marcus Olsson commented on CASSANDRA-14629:
---
I tried out the provided pull request (with a few modifications as mentioned in
the review). It was quite trivial to add simple tables based on the
AbstractIteratingTable which is good.
I used a structure as:
{code:sql}
CREATE TABLE system_views.testtable (
c1 bigint,
c2 bigint,
c3 bigint,
c4 bigint,
id int,
key text,
PRIMARY KEY (key, id)
) WITH CLUSTERING ORDER BY (id ASC)
AND compaction = {'class': 'None'}
AND compression = {};
{code}
and created a few different implementations of it.
Functionally it seems to be working as intended. Both
DataRange/ClusteringIndexFilter are working as expected as far as I can tell.
To verify the paging functionality I added some extra logging and had a table
setup with id values between 0 -> 11.
For a request with 100 rows per page it should return all rows from pk 0 -> 7
(96 rows) and then an additional 4 rows (0 -> 3) from pk 8. The logs showed the
following when executing "SELECT * FROM system_views.testtableother":
{noformat}
AbstractIteratingTable.java:150 - select range=(min(), min())
pfilter=slice(slices=ALL, reversed=false) - *
TestTableOther.java:74 - getPartitionKeys range=(min(), min())
pfilter=slice(slices=ALL, reversed=false)
TestTableOther.java:96 - getRows slice(slices=ALL, reversed=false) -
DecoratedKey(mykey000, 6d796b657930303030303030) - *
...
TestTableOther.java:96 - getRows slice(slices=ALL, reversed=false) -
DecoratedKey(mykey008, 6d796b657930303030303038) - *
# Next page request
AbstractIteratingTable.java:150 - select range=[mykey008, min()) (paging)
pfilter=slice(slices=ALL, reversed=false) lastReturned=id=3 (excluded) - *
TestTableOther.java:74 - getPartitionKeys range=[mykey008, min()) (paging)
pfilter=slice(slices=ALL, reversed=false) lastReturned=id=3 (excluded)
TestTableOther.java:96 - getRows slice(slices={(3, ]}, reversed=false) -
DecoratedKey(mykey008, 6d796b657930303030303038) - *
TestTableOther.java:96 - getRows slice(slices=ALL, reversed=false) -
DecoratedKey(mykey009, 6d796b657930303030303039) - *
{noformat}
The first request finished on pk8 row 3 and as expected the next continued with
row 4->11 on pk 8 and then everything from key 9 etc.
I ran some performance tests on it to check what happens when this is scaled to
millions of rows. This is also the main reason for the proposed changes to the
#getRows() method.
*Test case 1*
The first test case was executed with a single partition key and millions of
rows based on the provided table format at the top.
The id column was simply incremented for each new row.
There were three types of implementations tested:
# Iterate and create rows for everything (filter in AbstractIteratingTable)
(possible with current solution)
# Iterate and create Clustering for everything (filter in sub-class before
adding columns/building the row)
# Only generate rows that are read (based on the slice)
||Implementation||100,000||200,000||400,000||600,000||800,000||1,000,000||2,000,000||3,000,000||4,000,000|
||#1|1063|3658|13757|30214|53144|82827|-|-|-|
||#2|287|654|1705|3267|5189|7598|26574|55436|95842|
||#3|217|424|835|1319|1676|2250|4207|6307|8589|
The table shows the amount of time (ms) it took to iterate through the amount
of rows specified in column header (always starting from the first row). Both
this and the next test case used a page size of 5000.
Depending on how much data we are expecting to display in a table we should
make careful considerations on how we generate it in the iterators.
I guess the downside here is that #3 is probably not trivial to implement for
all virtual tables..
*Test case 2*
The second test case was executed with a million single-row partitions (same
schema) with two implementations:
# Generate all partitions (filter in AbstractIteratingTable)
# Generate only partitions falling in the data range
||Implementation||100,000||200,000||400,000||600,000||800,000||1,000,000|
||#1|1308|3934|14280|30587|53233|82813|
||#2|405|794|1554|2318|3122|3805|
Same as the previous table this shows the time (ms) to iterate through the rows.
There is a comment on the #getPartitionKeys() method already that it's ok to
generate all partitions for small data sets and I'd say that seems true.
Some comments/questions:
* Do we have a target for how many rows/partitions we should be able to
support? Or should it be "unlimited"?
* In order to make table paging efficient I believe we need to include
ClusteringIndexFilter (and optionally ColumnFilter) to #getRows().
** Clustering also needs to be exposed to the sub-class, either through
RowBuilder#getClustering() or by making the sub-class create the Clustering
object.
* Although this is quite
[jira] [Commented] (CASSANDRA-15329) in-JVM dtest fails on java 11 since system ClassLoader is not a URLClassLoader
[ https://issues.apache.org/jira/browse/CASSANDRA-15329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945956#comment-16945956 ] Alex Petrov commented on CASSANDRA-15329: - Thank you for the patch, +1! I have only one small remark [~dcapwell], would you mind if I switched from stream API to regular array allocation? I think there's a lot of value in streams when we're using them for multi-step operations I'd still stick to array allocation. However, I do not have a strong opinion about it, just let me know and I'll commit as-is or with a proposed change. Thanks! > in-JVM dtest fails on java 11 since system ClassLoader is not a URLClassLoader > -- > > Key: CASSANDRA-15329 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15329 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Attachments: CASSANDRA-15329.patch > > > When running the in-JVM dtests on on java 11 they fail while trying to cast > the Versions.class.getClassLoader to URLClassLoader, which is no longer the > default ClassLoader on java 11. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15344) "tablestats" should be used instead of "cfstats"
[ https://issues.apache.org/jira/browse/CASSANDRA-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945919#comment-16945919 ] Chris Lohfink edited comment on CASSANDRA-15344 at 10/7/19 2:16 PM: cfstats is an [alias of tablestats|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/CfStats.java] so it does. Or are you referring to the title of the jira? was (Author: cnlwsu): cfstats is an [alias of tablestats|[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/CfStats.java] so it does. Or are you referring to the title of the jira? > "tablestats" should be used instead of "cfstats" > > > Key: CASSANDRA-15344 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15344 > Project: Cassandra > Issue Type: Bug >Reporter: DeepakVohra >Priority: Normal > > As _nodetool cfstats_ has been renamed/aliased to _nodetool tablestats_ > should CASSANDRA-13889 be referring to _cfstats_? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15344) "tablestats" should be used instead of "cfstats"
[ https://issues.apache.org/jira/browse/CASSANDRA-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945919#comment-16945919 ] Chris Lohfink edited comment on CASSANDRA-15344 at 10/7/19 2:16 PM: cfstats is an [alias of tablestats|[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/CfStats.java] so it does. Or are you referring to the title of the jira? was (Author: cnlwsu): cfstats is an [alias of tablestats|[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/CfStats.java]] so it does. Or are you referring to the title of the jira? > "tablestats" should be used instead of "cfstats" > > > Key: CASSANDRA-15344 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15344 > Project: Cassandra > Issue Type: Bug >Reporter: DeepakVohra >Priority: Normal > > As _nodetool cfstats_ has been renamed/aliased to _nodetool tablestats_ > should CASSANDRA-13889 be referring to _cfstats_? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15344) "tablestats" should be used instead of "cfstats"
[ https://issues.apache.org/jira/browse/CASSANDRA-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945919#comment-16945919 ] Chris Lohfink commented on CASSANDRA-15344: --- cfstats is an [alias of tablestats|[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/CfStats.java]] so it does. Or are you referring to the title of the jira? > "tablestats" should be used instead of "cfstats" > > > Key: CASSANDRA-15344 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15344 > Project: Cassandra > Issue Type: Bug >Reporter: DeepakVohra >Priority: Normal > > As _nodetool cfstats_ has been renamed/aliased to _nodetool tablestats_ > should CASSANDRA-13889 be referring to _cfstats_? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15193) Add ability to cap max negotiable protocol version
[
https://issues.apache.org/jira/browse/CASSANDRA-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945877#comment-16945877
]
Aleksey Yeschenko commented on CASSANDRA-15193:
---
The changes look good to me. I figure we don't really need to have
{{SystemKeyspace::loadPeerVersions}} be a map, and it could just be a set, but
it doesn't really matter or affect anything.
+1
> Add ability to cap max negotiable protocol version
> --
>
> Key: CASSANDRA-15193
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15193
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> 3.0 and native protocol V4 introduced a change to how PagingState is
> serialized. Unfortunately that can break requests during upgrades: since
> paging states are opaque, it's possible for a client to receive a paging
> state encoded as V3 on a 2.1 node, and then send it to a 3.0 node on a V4
> session. The version of the current session will be used to deserialize the
> paging state, instead of the actual version used to serialize it, and the
> request will fail.
> CASSANDRA-15176 solves half of this problem by enabling 3.0 nodes to
> serialize mis-versioned PagingStates. To address the other side of the issue,
> 2.1 nodes receiving V4 PagingStates, we can introduce a property to cap the
> max native protocol version that the 3.0 nodes will negotiate with clients.
> If we cap this to V3 during upgrades, no V4 connections will be established
> and so no incompatible PagingStates will be sent to clients.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15193) Add ability to cap max negotiable protocol version
[ https://issues.apache.org/jira/browse/CASSANDRA-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-15193: -- Status: Ready to Commit (was: Review In Progress) > Add ability to cap max negotiable protocol version > -- > > Key: CASSANDRA-15193 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15193 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Client >Reporter: Sam Tunnicliffe >Assignee: Sam Tunnicliffe >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > 3.0 and native protocol V4 introduced a change to how PagingState is > serialized. Unfortunately that can break requests during upgrades: since > paging states are opaque, it's possible for a client to receive a paging > state encoded as V3 on a 2.1 node, and then send it to a 3.0 node on a V4 > session. The version of the current session will be used to deserialize the > paging state, instead of the actual version used to serialize it, and the > request will fail. > CASSANDRA-15176 solves half of this problem by enabling 3.0 nodes to > serialize mis-versioned PagingStates. To address the other side of the issue, > 2.1 nodes receiving V4 PagingStates, we can introduce a property to cap the > max native protocol version that the 3.0 nodes will negotiate with clients. > If we cap this to V3 during upgrades, no V4 connections will be established > and so no incompatible PagingStates will be sent to clients. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15193) Add ability to cap max negotiable protocol version
[ https://issues.apache.org/jira/browse/CASSANDRA-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-15193: -- Reviewers: Aleksey Yeschenko, Alex Petrov, Aleksey Yeschenko (was: Aleksey Yeschenko, Alex Petrov) Aleksey Yeschenko, Alex Petrov, Aleksey Yeschenko (was: Aleksey Yeschenko, Alex Petrov) Status: Review In Progress (was: Patch Available) > Add ability to cap max negotiable protocol version > -- > > Key: CASSANDRA-15193 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15193 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Client >Reporter: Sam Tunnicliffe >Assignee: Sam Tunnicliffe >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > 3.0 and native protocol V4 introduced a change to how PagingState is > serialized. Unfortunately that can break requests during upgrades: since > paging states are opaque, it's possible for a client to receive a paging > state encoded as V3 on a 2.1 node, and then send it to a 3.0 node on a V4 > session. The version of the current session will be used to deserialize the > paging state, instead of the actual version used to serialize it, and the > request will fail. > CASSANDRA-15176 solves half of this problem by enabling 3.0 nodes to > serialize mis-versioned PagingStates. To address the other side of the issue, > 2.1 nodes receiving V4 PagingStates, we can introduce a property to cap the > max native protocol version that the 3.0 nodes will negotiate with clients. > If we cap this to V3 during upgrades, no V4 connections will be established > and so no incompatible PagingStates will be sent to clients. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15319) Add support for network topology and tracing to in-JVM dtests.
[ https://issues.apache.org/jira/browse/CASSANDRA-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945847#comment-16945847 ] Alex Petrov commented on CASSANDRA-15319: - Thank you for the patch! I only have one suggestion that I described [here|https://github.com/apache/cassandra/pull/354], please let me know what you think about it. +1 otherwise. > Add support for network topology and tracing to in-JVM dtests. > -- > > Key: CASSANDRA-15319 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15319 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > Labels: pull-request-available > Time Spent: 4h > Remaining Estimate: 0h > > While working on CASSANDRA-15318, testing it properly with an in-JVM test > requires setting up the network topology and tracing requests to check which > nodes performed forwarding. > > In support of testing, make it possible to create in-JVM clusters with nodes > appearing in different datacenter/racks and add support for executing queries > with tracing enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15346) ReadTimeout: Error from server: code=1200 [Coordinator node timed out waiting for replica nodes' responses]
N Sujit Kumar created CASSANDRA-15346:
-
Summary: ReadTimeout: Error from server: code=1200 [Coordinator
node timed out waiting for replica nodes' responses]
Key: CASSANDRA-15346
URL: https://issues.apache.org/jira/browse/CASSANDRA-15346
Project: Cassandra
Issue Type: Bug
Components: CQL/Semantics, CQL/Syntax
Reporter: N Sujit Kumar
Hi,
We have created table with below schema:
create table test_table(col_1 text, col_2 text, col_3 text, col_4 text, col_5
text, col_6 text, col_7 text, PRIMARY KEY (col_1, col_2, col_3, col_4, col_5));
{color:#de350b}this table contains nearly billions of records.(huge record
count) {color}
and tried to query like below,
select * from test_table where col_1='value' and col_2='value'; -->
{color:#00875a}getting results{color}
but when we tried like below,
select * from test_table where col_1='value' and col_3='value' allow filtering;
-->{color:#de350b} not getting{color} results
select * from test_table where col_1='value' and col_4='value' allow filtering;
--> {color:#de350b}not getting{color} results
we are getting below error:
"ReadTimeout: Error from server: code=1200 [Coordinator node timed out waiting
for replica nodes' responses] message="Operation timed out - received only 0
responses." info=\{'received_responses': 0, 'required_responses': 1,
'consistency': 'ONE'}"
After i got above error, i have extended the timeout parameters from 5 seconds
to 60 minutes in cassandra.yaml configuration file.
{color:#de350b}then result came, but taking very long time with 50 minutes of
execution time.{color}
Can anyone suggest me to solve the "ReadTimeout:" issue without extending the
configuration?
Thanks,
Sujit
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15345) Incorrect result on conditional UPDATE with static and regular conditions
[
https://issues.apache.org/jira/browse/CASSANDRA-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin updated CASSANDRA-15345:
---
Resolution: Invalid
Status: Resolved (was: Triage Needed)
Sorry, this is invalid.
> Incorrect result on conditional UPDATE with static and regular conditions
> -
>
> Key: CASSANDRA-15345
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15345
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Konstantin
>Priority: Normal
>
> The below example conditional update is wrongly evaluated to True and applied
> even though clustering key 'k1' is not present in the table:
> CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
> 'replication_factor': 1};
> CREATE TABLE test_table (id int, k text, version int static, v text, PRIMARY
> KEY (id, k));
> INSERT INTO test_table(id, version) VALUES (0, 0);
> SELECT * FROM test_table;
> id | k | version | v
> +--+-+--
> 0 | null | 0 | null
> (1 rows)
> SELECT * FROM test_table WHERE id=0 AND k='k1';
> id | k | version | v
> +---+-+---
> (0 rows)
> UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version = 0;
> [applied]
> ---
> True
> SELECT * FROM test_table;
> id | k | version | v
> ++-+-
> 0 | k1 | 1 | foo
> (1 rows)
> DROP TABLE test_table;
> DROP KEYSPACE test_keyspace;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15345) Incorrect result on conditional UPDATE with static and regular conditions
[
https://issues.apache.org/jira/browse/CASSANDRA-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin updated CASSANDRA-15345:
---
Description:
The below example conditional update is wrongly evaluated to True and applied
even though clustering key 'k1' is not present in the table:
CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
'replication_factor': 1};
CREATE TABLE test_table (id int, k text, version int static, v text, PRIMARY
KEY (id, k));
INSERT INTO test_table(id, version) VALUES (0, 0);
SELECT * FROM test_table;
id | k | version | v
+--+-+--
0 | null | 0 | null
(1 rows)
SELECT * FROM test_table WHERE id=0 AND k='k1';
id | k | version | v
+---+-+---
(0 rows)
UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version = 0;
[applied]
---
True
SELECT * FROM test_table;
id | k | version | v
++-+-
0 | k1 | 1 | foo
(1 rows)
DROP TABLE test_table;
DROP KEYSPACE test_keyspace;
was:
The below example conditional update is wrongly evaluated to True and applied
even though clustering key 'k1' is not present in the table:
{{CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
'replication_factor': 1};}}
{{CREATE TABLE test_table (id int, k text, version int static, v text, PRIMARY
KEY (id, k));}}
{{INSERT INTO test_table(id, version) VALUES (0, 0);}}
{{SELECT * FROM test_table;}}{{id | k | version | v}}
{{+--+-+--}}
{{ 0 | null | 0 | null}}{{(1 rows)}}
{{SELECT * FROM test_table WHERE id=0 AND k='k1';}}{{id | k | version | v}}
{{+---+-+---}}{{(0 rows)}}
{{UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version =
0;}}{{[applied]}}
{{---}}
{{ True}}{{SELECT * FROM test_table;}}{{id | k | version | v}}
{{++-+-}}
{{ 0 | k1 | 1 | foo}}{{(1 rows)}}
{{DROP TABLE test_table;}}
{{DROP KEYSPACE test_keyspace;}}
> Incorrect result on conditional UPDATE with static and regular conditions
> -
>
> Key: CASSANDRA-15345
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15345
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Konstantin
>Priority: Normal
>
> The below example conditional update is wrongly evaluated to True and applied
> even though clustering key 'k1' is not present in the table:
> CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
> 'replication_factor': 1};
> CREATE TABLE test_table (id int, k text, version int static, v text, PRIMARY
> KEY (id, k));
> INSERT INTO test_table(id, version) VALUES (0, 0);
> SELECT * FROM test_table;
> id | k | version | v
> +--+-+--
> 0 | null | 0 | null
> (1 rows)
> SELECT * FROM test_table WHERE id=0 AND k='k1';
> id | k | version | v
> +---+-+---
> (0 rows)
> UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version = 0;
> [applied]
> ---
> True
> SELECT * FROM test_table;
> id | k | version | v
> ++-+-
> 0 | k1 | 1 | foo
> (1 rows)
> DROP TABLE test_table;
> DROP KEYSPACE test_keyspace;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15345) Incorrect result on conditional UPDATE with static and regular conditions
Konstantin created CASSANDRA-15345:
--
Summary: Incorrect result on conditional UPDATE with static and
regular conditions
Key: CASSANDRA-15345
URL: https://issues.apache.org/jira/browse/CASSANDRA-15345
Project: Cassandra
Issue Type: Bug
Components: CQL/Semantics
Reporter: Konstantin
The below example conditional update is wrongly evaluated to True and applied
even though clustering key 'k1' is not present in the table:
```
CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
'replication_factor': 1};
CREATE TABLE test_table (id int, k text, version int static, v text, PRIMARY
KEY (id, k));
INSERT INTO test_table(id, version) VALUES (0, 0);
SELECT * FROM test_table;
id | k | version | v
+--+-+--
0 | null | 0 | null
(1 rows)
SELECT * FROM test_table WHERE id=0 AND k='k1';
id | k | version | v
+---+-+---
(0 rows)
UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version = 0;
[applied]
---
True
SELECT * FROM test_table;
id | k | version | v
++-+-
0 | k1 | 1 | foo
(1 rows)
DROP TABLE test_table;
DROP KEYSPACE test_keyspace;
```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15345) Incorrect result on conditional UPDATE with static and regular conditions
[
https://issues.apache.org/jira/browse/CASSANDRA-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin updated CASSANDRA-15345:
---
Description:
The below example conditional update is wrongly evaluated to True and applied
even though clustering key 'k1' is not present in the table:
{{CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
'replication_factor': 1};}}
\{{ CREATE TABLE test_table (id int, k text, version int static, v text,
PRIMARY KEY (id, k));}}
\{{ INSERT INTO test_table(id, version) VALUES (0, 0);}}
\{{ SELECT * FROM test_table;}}{{id | k | version | v}}
{{ +++-}}
\{{ 0 | null | 0 | null}}{{(1 rows)}}
\{{ SELECT * FROM test_table WHERE id=0 AND k='k1';}}{{id | k | version | v}}
{{ +++---}}{{(0 rows)}}
\{{ UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version
= 0;}}{{[applied]}}
\{{ ---}}
\{{ True}}{{SELECT * FROM test_table;}}{{id | k | version | v}}
{{ +++--}}
\{{ 0 | k1 | 1 | foo}}{{(1 rows)}}
\{{ DROP TABLE test_table;}}
\{{ DROP KEYSPACE test_keyspace;}}
was:
The below example conditional update is wrongly evaluated to True and applied
even though clustering key 'k1' is not present in the table:
```
{{CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
'replication_factor': 1};}}
{{ CREATE TABLE test_table (id int, k text, version int static, v text, PRIMARY
KEY (id, k));}}
{{ INSERT INTO test_table(id, version) VALUES (0, 0);}}
{{ SELECT * FROM test_table;}}{{id | k | version | v}}
{{ ++---+--}}
{{ 0 | null | 0 | null}}{{(1 rows)}}
{{ SELECT * FROM test_table WHERE id=0 AND k='k1';}}{{id | k | version | v}}
{{ +++---}}{{(0 rows)}}
{{ UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version =
0;}}{{[applied]}}
{{ ---}}
{{ True}}{{SELECT * FROM test_table;}}{{id | k | version | v}}
{{ ++-+-}}
{{ 0 | k1 | 1 | foo}}{{(1 rows)}}
{{ DROP TABLE test_table;}}
{{ DROP KEYSPACE test_keyspace;}}{{```}}
> Incorrect result on conditional UPDATE with static and regular conditions
> -
>
> Key: CASSANDRA-15345
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15345
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Konstantin
>Priority: Normal
>
> The below example conditional update is wrongly evaluated to True and applied
> even though clustering key 'k1' is not present in the table:
> {{CREATE KEYSPACE test_keyspace WITH replication = \{'class':
> 'SimpleStrategy', 'replication_factor': 1};}}
> \{{ CREATE TABLE test_table (id int, k text, version int static, v text,
> PRIMARY KEY (id, k));}}
> \{{ INSERT INTO test_table(id, version) VALUES (0, 0);}}
> \{{ SELECT * FROM test_table;}}{{id | k | version | v}}
> {{ +++-}}
> \{{ 0 | null | 0 | null}}{{(1 rows)}}
> \{{ SELECT * FROM test_table WHERE id=0 AND k='k1';}}{{id | k | version | v}}
> {{ +++---}}{{(0 rows)}}
> \{{ UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF
> version = 0;}}{{[applied]}}
> \{{ ---}}
> \{{ True}}{{SELECT * FROM test_table;}}{{id | k | version | v}}
> {{ +++--}}
> \{{ 0 | k1 | 1 | foo}}{{(1 rows)}}
> \{{ DROP TABLE test_table;}}
> \{{ DROP KEYSPACE test_keyspace;}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15345) Incorrect result on conditional UPDATE with static and regular conditions
[
https://issues.apache.org/jira/browse/CASSANDRA-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin updated CASSANDRA-15345:
---
Description:
The below example conditional update is wrongly evaluated to True and applied
even though clustering key 'k1' is not present in the table:
{{CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
'replication_factor': 1};}}
{{CREATE TABLE test_table (id int, k text, version int static, v text, PRIMARY
KEY (id, k));}}
{{INSERT INTO test_table(id, version) VALUES (0, 0);}}
{{SELECT * FROM test_table;}}{{id | k | version | v}}
{{+--+-+--}}
{{ 0 | null | 0 | null}}{{(1 rows)}}
{{SELECT * FROM test_table WHERE id=0 AND k='k1';}}{{id | k | version | v}}
{{+---+-+---}}{{(0 rows)}}
{{UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version =
0;}}{{[applied]}}
{{---}}
{{ True}}{{SELECT * FROM test_table;}}{{id | k | version | v}}
{{++-+-}}
{{ 0 | k1 | 1 | foo}}{{(1 rows)}}
{{DROP TABLE test_table;}}
{{DROP KEYSPACE test_keyspace;}}
was:
The below example conditional update is wrongly evaluated to True and applied
even though clustering key 'k1' is not present in the table:
{{CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
'replication_factor': 1};}}
\{{ CREATE TABLE test_table (id int, k text, version int static, v text,
PRIMARY KEY (id, k));}}
\{{ INSERT INTO test_table(id, version) VALUES (0, 0);}}
\{{ SELECT * FROM test_table;}}{{id | k | version | v}}
{{ +++-}}
\{{ 0 | null | 0 | null}}{{(1 rows)}}
\{{ SELECT * FROM test_table WHERE id=0 AND k='k1';}}{{id | k | version | v}}
{{ +++---}}{{(0 rows)}}
\{{ UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version
= 0;}}{{[applied]}}
\{{ ---}}
\{{ True}}{{SELECT * FROM test_table;}}{{id | k | version | v}}
{{ +++--}}
\{{ 0 | k1 | 1 | foo}}{{(1 rows)}}
\{{ DROP TABLE test_table;}}
\{{ DROP KEYSPACE test_keyspace;}}
> Incorrect result on conditional UPDATE with static and regular conditions
> -
>
> Key: CASSANDRA-15345
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15345
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Konstantin
>Priority: Normal
>
> The below example conditional update is wrongly evaluated to True and applied
> even though clustering key 'k1' is not present in the table:
> {{CREATE KEYSPACE test_keyspace WITH replication = \{'class':
> 'SimpleStrategy', 'replication_factor': 1};}}
> {{CREATE TABLE test_table (id int, k text, version int static, v text,
> PRIMARY KEY (id, k));}}
> {{INSERT INTO test_table(id, version) VALUES (0, 0);}}
> {{SELECT * FROM test_table;}}{{id | k | version | v}}
> {{+--+-+--}}
> {{ 0 | null | 0 | null}}{{(1 rows)}}
> {{SELECT * FROM test_table WHERE id=0 AND k='k1';}}{{id | k | version | v}}
> {{+---+-+---}}{{(0 rows)}}
> {{UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version =
> 0;}}{{[applied]}}
> {{---}}
> {{ True}}{{SELECT * FROM test_table;}}{{id | k | version | v}}
> {{++-+-}}
> {{ 0 | k1 | 1 | foo}}{{(1 rows)}}
> {{DROP TABLE test_table;}}
> {{DROP KEYSPACE test_keyspace;}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15345) Incorrect result on conditional UPDATE with static and regular conditions
[
https://issues.apache.org/jira/browse/CASSANDRA-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin updated CASSANDRA-15345:
---
Description:
The below example conditional update is wrongly evaluated to True and applied
even though clustering key 'k1' is not present in the table:
```
{{CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
'replication_factor': 1};}}
{{ CREATE TABLE test_table (id int, k text, version int static, v text, PRIMARY
KEY (id, k));}}
{{ INSERT INTO test_table(id, version) VALUES (0, 0);}}
{{ SELECT * FROM test_table;}}{{id | k | version | v}}
{{ ++---+--}}
{{ 0 | null | 0 | null}}{{(1 rows)}}
{{ SELECT * FROM test_table WHERE id=0 AND k='k1';}}{{id | k | version | v}}
{{ +++---}}{{(0 rows)}}
{{ UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version =
0;}}{{[applied]}}
{{ ---}}
{{ True}}{{SELECT * FROM test_table;}}{{id | k | version | v}}
{{ ++-+-}}
{{ 0 | k1 | 1 | foo}}{{(1 rows)}}
{{ DROP TABLE test_table;}}
{{ DROP KEYSPACE test_keyspace;}}{{```}}
was:
The below example conditional update is wrongly evaluated to True and applied
even though clustering key 'k1' is not present in the table:
```
CREATE KEYSPACE test_keyspace WITH replication = \{'class': 'SimpleStrategy',
'replication_factor': 1};
CREATE TABLE test_table (id int, k text, version int static, v text, PRIMARY
KEY (id, k));
INSERT INTO test_table(id, version) VALUES (0, 0);
SELECT * FROM test_table;
id | k | version | v
+--+-+--
0 | null | 0 | null
(1 rows)
SELECT * FROM test_table WHERE id=0 AND k='k1';
id | k | version | v
+---+-+---
(0 rows)
UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version = 0;
[applied]
---
True
SELECT * FROM test_table;
id | k | version | v
++-+-
0 | k1 | 1 | foo
(1 rows)
DROP TABLE test_table;
DROP KEYSPACE test_keyspace;
```
> Incorrect result on conditional UPDATE with static and regular conditions
> -
>
> Key: CASSANDRA-15345
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15345
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Semantics
>Reporter: Konstantin
>Priority: Normal
>
> The below example conditional update is wrongly evaluated to True and applied
> even though clustering key 'k1' is not present in the table:
> ```
> {{CREATE KEYSPACE test_keyspace WITH replication = \{'class':
> 'SimpleStrategy', 'replication_factor': 1};}}
> {{ CREATE TABLE test_table (id int, k text, version int static, v text,
> PRIMARY KEY (id, k));}}
> {{ INSERT INTO test_table(id, version) VALUES (0, 0);}}
> {{ SELECT * FROM test_table;}}{{id | k | version | v}}
> {{ ++---+--}}
> {{ 0 | null | 0 | null}}{{(1 rows)}}
> {{ SELECT * FROM test_table WHERE id=0 AND k='k1';}}{{id | k | version | v}}
> {{ +++---}}{{(0 rows)}}
> {{ UPDATE test_table SET v='foo', version=1 WHERE id=0 AND k='k1' IF version
> = 0;}}{{[applied]}}
> {{ ---}}
> {{ True}}{{SELECT * FROM test_table;}}{{id | k | version | v}}
> {{ ++-+-}}
> {{ 0 | k1 | 1 | foo}}{{(1 rows)}}
> {{ DROP TABLE test_table;}}
> {{ DROP KEYSPACE test_keyspace;}}{{```}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
