[jira] [Commented] (CASSANDRA-15778) CorruptSSTableException after a 2.1 SSTable is upgraded to 3.0, failing reads
[
https://issues.apache.org/jira/browse/CASSANDRA-15778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123353#comment-17123353
]
Sumanth Pasupuleti commented on CASSANDRA-15778:
Thanks for the patch [~ifesdjeen]. I was able to validate both the flows of the
patch on the actual data that I was able to repro the issue with.
In either of the flows, the resulting table ended up with the following schema,
and doing a select * on the table includes the third column.
{code:java}
cqlsh:ks> desc "cf";
CREATE TABLE ks."cf" (
key text,
value text,
value1 blob,
PRIMARY KEY (key, value)
) WITH COMPACT STORAGE
AND CLUSTERING ORDER BY (value ASC)
...
{code}
A couple of comments on the patch:
1. It maybe helpful to add the following tests to {{testAlterTableAlterType()}}
method.
{code:java}
createTable("CREATE TABLE %s (a int, value int, PRIMARY KEY (a,value))
WITH COMPACT STORAGE");
assertInvalidMessage("Altering of types is not allowed",
"ALTER TABLE %s ALTER value TYPE
'org.apache.cassandra.db.marshal.IntegerType'");
execute("ALTER TABLE %s ALTER value1 TYPE
'org.apache.cassandra.db.marshal.BytesType'");
{code}
2. For the system property
{{cassandra.init_dense_table_compact_value_as_bytes}}, I am not sure if folks
may find it useful to control what keyspace/cf this needs to be applied to. I
personally feel it may be rare enough to ignore this, but wanted to bring it up
nevertheless.
> CorruptSSTableException after a 2.1 SSTable is upgraded to 3.0, failing reads
> -
>
> Key: CASSANDRA-15778
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15778
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction, Local/SSTable
>Reporter: Sumanth Pasupuleti
>Assignee: Alex Petrov
>Priority: Normal
> Fix For: 3.0.x
>
>
> Below is the exception with stack trace. This issue is consistently
> reproduce-able.
> {code:java}
> ERROR [SharedPool-Worker-1] 2020-05-01 14:57:57,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,main]ERROR [SharedPool-Worker-1] 2020-05-01
> 14:57:57,661 AbstractLocalAwareExecutorService.java:169 - Uncaught exception
> on thread
> Thread[SharedPool-Worker-1,5,main]org.apache.cassandra.io.sstable.CorruptSSTableException:
> Corrupted:
> /mnt/data/cassandra/data// at
> org.apache.cassandra.db.columniterator.AbstractSSTableIterator$Reader.hasNext(AbstractSSTableIterator.java:349)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.columniterator.AbstractSSTableIterator.hasNext(AbstractSSTableIterator.java:220)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.columniterator.SSTableIterator.hasNext(SSTableIterator.java:33)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:129)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:129)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:129)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:131)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:87)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:77)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
>
[jira] [Updated] (CASSANDRA-15844) Create table Asynchronously or creating table contact the same node from many client threads at same time may causing data lose
[
https://issues.apache.org/jira/browse/CASSANDRA-15844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maxwellguo updated CASSANDRA-15844:
---
Summary: Create table Asynchronously or creating table contact the same
node from many client threads at same time may causing data lose (was: Create
table Asynchronously or contact the same node from many client threads at same
time may causing data lose)
> Create table Asynchronously or creating table contact the same node from many
> client threads at same time may causing data lose
> ---
>
> Key: CASSANDRA-15844
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15844
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
>Reporter: maxwellguo
>Assignee: maxwellguo
>Priority: Normal
> Attachments: createkeyspace.jpg, keyspace inner.jpg, schemaversion.jpg
>
>
> When creating a table from on one coordinator node from some client threads
> at the same time, Or creating a table using session.executeAsync() method,
> may cause the schema'information incorrect. Seriously will causing data lose.
> For my test. I use executeAsync() to create table one by one using the same
> table name (Though I do konw create table should be synchronously, but some
> of our customers may create table using executAsync() ). My expectations is
> that the last cql
> {code:java}
> CREATE TABLE ks.tb (name text PRIMARY KEY , age int, adds text, height text)
> {code}
> should take effect .
> !createkeyspace.jpg!
> But after runing the code, I foud that the result is not what I am expected.
> the schema struct is is :
> {code:java}
> CREATE TABLE ks.tb (name text PRIMARY KEY , age int, adds text, sex int,
> height int)
> {code}
> !keyspace inner.jpg!
> And the schema version in the memory and on the disk is not the same.
> !schemaversion.jpg!
> When add a new columnfamily (creat a new table), the request of creating same
> table with different schema definition arrived at the same time from
> different clients or using
> executeAsync method.
> {code:java}
> private static void announceNewColumnFamily(CFMetaData cfm, boolean
> announceLocally, boolean throwOnDuplicate, long timestamp) throws
> ConfigurationException
> {
> cfm.validate();
> KeyspaceMetadata ksm = Schema.instance.getKSMetaData(cfm.ksName);
> if (ksm == null)
> throw new ConfigurationException(String.format("Cannot add table
> '%s' to non existing keyspace '%s'.", cfm.cfName, cfm.ksName));
> // If we have a table or a view which has the same name, we can't add
> a new one
> else if (throwOnDuplicate && ksm.getTableOrViewNullable(cfm.cfName)
> != null)
> throw new AlreadyExistsException(cfm.ksName, cfm.cfName);
> logger.info("Create new table: {}", cfm);
> announce(SchemaKeyspace.makeCreateTableMutation(ksm, cfm, timestamp),
> announceLocally);
> }
> {code}
> The code of checking table existance may failed. And same table's request may
> all going to do announce() method;
> {code:java}
> public static synchronized void mergeSchema(Collection mutations,
> boolean forDynamoTTL)
> {
> // only compare the keyspaces affected by this set of schema mutations
> Set affectedKeyspaces =
> mutations.stream()
> .map(m -> UTF8Type.instance.compose(m.key().getKey()))
> .collect(Collectors.toSet());
> // fetch the current state of schema for the affected keyspaces only
> Keyspaces before = Schema.instance.getKeyspaces(affectedKeyspaces);
> // apply the schema mutations and flush
> mutations.forEach(Mutation::apply);
> if (FLUSH_SCHEMA_TABLES)
> flush();
> // fetch the new state of schema from schema tables (not applied to
> Schema.instance yet)
> Keyspaces after = fetchKeyspacesOnly(affectedKeyspaces);
> mergeSchema(before, after);
> scheduleDynamoTTLClean(forDynamoTTL, mutations);
> }
> {code}
> For we may write the new table definition into disk, so at last we saw
> {code:java}
> CREATE TABLE ks.tb (name text PRIMARY KEY , age int, adds text, sex int,
> height int)
> {code}
> in our case.
> And we also saw the different version in memory and disk.
> when writing data we using the schema in memory, but when we doing node
> restart the schema definition on disk will be used. Then may causing data
> lose.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail:
[jira] [Created] (CASSANDRA-15844) Create table Asynchronously or contact the same node from many client threads at same time may causing data lose
maxwellguo created CASSANDRA-15844:
--
Summary: Create table Asynchronously or contact the same node from
many client threads at same time may causing data lose
Key: CASSANDRA-15844
URL: https://issues.apache.org/jira/browse/CASSANDRA-15844
Project: Cassandra
Issue Type: Bug
Components: Cluster/Schema
Reporter: maxwellguo
Assignee: maxwellguo
Attachments: createkeyspace.jpg, keyspace inner.jpg, schemaversion.jpg
When creating a table from on one coordinator node from some client threads at
the same time, Or creating a table using session.executeAsync() method, may
cause the schema'information incorrect. Seriously will causing data lose.
For my test. I use executeAsync() to create table one by one using the same
table name (Though I do konw create table should be synchronously, but some of
our customers may create table using executAsync() ). My expectations is that
the last cql
{code:java}
CREATE TABLE ks.tb (name text PRIMARY KEY , age int, adds text, height text)
{code}
should take effect .
!createkeyspace.jpg!
But after runing the code, I foud that the result is not what I am expected.
the schema struct is is :
{code:java}
CREATE TABLE ks.tb (name text PRIMARY KEY , age int, adds text, sex int, height
int)
{code}
!keyspace inner.jpg!
And the schema version in the memory and on the disk is not the same.
!schemaversion.jpg!
When add a new columnfamily (creat a new table), the request of creating same
table with different schema definition arrived at the same time from different
clients or using
executeAsync method.
{code:java}
private static void announceNewColumnFamily(CFMetaData cfm, boolean
announceLocally, boolean throwOnDuplicate, long timestamp) throws
ConfigurationException
{
cfm.validate();
KeyspaceMetadata ksm = Schema.instance.getKSMetaData(cfm.ksName);
if (ksm == null)
throw new ConfigurationException(String.format("Cannot add table
'%s' to non existing keyspace '%s'.", cfm.cfName, cfm.ksName));
// If we have a table or a view which has the same name, we can't add a
new one
else if (throwOnDuplicate && ksm.getTableOrViewNullable(cfm.cfName) !=
null)
throw new AlreadyExistsException(cfm.ksName, cfm.cfName);
logger.info("Create new table: {}", cfm);
announce(SchemaKeyspace.makeCreateTableMutation(ksm, cfm, timestamp),
announceLocally);
}
{code}
The code of checking table existance may failed. And same table's request may
all going to do announce() method;
{code:java}
public static synchronized void mergeSchema(Collection mutations,
boolean forDynamoTTL)
{
// only compare the keyspaces affected by this set of schema mutations
Set affectedKeyspaces =
mutations.stream()
.map(m -> UTF8Type.instance.compose(m.key().getKey()))
.collect(Collectors.toSet());
// fetch the current state of schema for the affected keyspaces only
Keyspaces before = Schema.instance.getKeyspaces(affectedKeyspaces);
// apply the schema mutations and flush
mutations.forEach(Mutation::apply);
if (FLUSH_SCHEMA_TABLES)
flush();
// fetch the new state of schema from schema tables (not applied to
Schema.instance yet)
Keyspaces after = fetchKeyspacesOnly(affectedKeyspaces);
mergeSchema(before, after);
scheduleDynamoTTLClean(forDynamoTTL, mutations);
}
{code}
For we may write the new table definition into disk, so at last we saw
{code:java}
CREATE TABLE ks.tb (name text PRIMARY KEY , age int, adds text, sex int, height
int)
{code}
in our case.
And we also saw the different version in memory and disk.
when writing data we using the schema in memory, but when we doing node restart
the schema definition on disk will be used. Then may causing data lose.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15234) Standardise config and JVM parameters
[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121528#comment-17121528
]
Ekaterina Dimitrova commented on CASSANDRA-15234:
-
I think that with my CCM patch all dtests should be fine now but I didn't
manage to run them with my CCM patch in CircleCI. I was advised to change only
the repo in requirements.txt but configuration errors appear and I can't run
the tests.
[~mck], is there a way this to be done in Jenkins?
Otherwise I can try locally but this will take at least half a day to run the
dtests...
[~dcapwell] [~mck] if you have any ideas how to deal with this task efficiently
will be appreciated.
> Standardise config and JVM parameters
> -
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Benedict Elliott Smith
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15835) Upgrade-dtests on trunk not working in CircleCI
[
https://issues.apache.org/jira/browse/CASSANDRA-15835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121410#comment-17121410
]
David Capwell commented on CASSANDRA-15835:
---
bq. since the Jenkins tests are our tests of record at this point, do we think
it appropriate to block cutting beta-1 on this?
Jenkins doesn't run upgrade tests, only Circle CI.
> Upgrade-dtests on trunk not working in CircleCI
> ---
>
> Key: CASSANDRA-15835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15835
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Robert Stupp
>Assignee: Robert Stupp
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> ~3600 Upgrade-dtests are failing in CircleCI for trunk due to the missing
> {{JAVA8_HOME}} environment variable.
> Patching the Docker image is rather simple by creating a new image:
> {code}
> FROM nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200406
> ENV JAVA8_HOME=/usr/lib/jvm/java-8-openjdk-amd64
> {code}
> Pushed the above to Docker hub as
> [snazy/cassandra-testing-ubuntu1910-java11-w-dependencies:202005261540|https://hub.docker.com/layers/snazy/cassandra-testing-ubuntu1910-java11-w-dependencies/202005261540/images/sha256-ac8a713be58694f095c491921e006c2d1a7823a3c23299e477198e2c93a6bbd7?context=explore]
> The size of the whole Docker image is a little concerning though (1.85G
> compressed), but that's out of the scope of this ticket.
> I'll prepare a patch soon-ish.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15685) flaky testWithMismatchingPending - org.apache.cassandra.distributed.test.PreviewRepairTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121396#comment-17121396
]
David Capwell edited comment on CASSANDRA-15685 at 6/1/20, 11:24 PM:
-
[~bdeggleston] [~marcuse] could we get your thoughts on this? preview repair
isn't allowed to be run concurrently with IR, but IR completes before the
message is handled on the participant; the below is impacted by this race
condition.
{code}
nodetool repair foo bar
# does not look to be running concurrently with the above IR, since it was
notified of success
# but the commit message may not have been seen yet which cause this to be
concurrent with the above
nodetool repair foo bar --validate
{code}
See here
https://github.com/apache/cassandra/blob/ec1808a34f9aa5ae0b956c1527828566f4ba2be5/src/java/org/apache/cassandra/repair/consistent/CoordinatorSession.java#L234-L244.
We send the message but don't make sure its ack on.
was (Author: dcapwell):
[~bdeggleston] [~marcuse] could we get your thoughts on this? preview repair
isn't allowed to be run concurrently with IR, but IR completes before the
message is handled on the participant; the below is impacted by this race
condition.
{code}
nodetool repair foo bar
# does not look to be running concurrently with the above IR, since it was
notified of success
# but the commit message may not have been seen yet which cause this to be
concurrent with the above
nodetool repair foo bar --validate
{code}
> flaky testWithMismatchingPending -
> org.apache.cassandra.distributed.test.PreviewRepairTest
> --
>
> Key: CASSANDRA-15685
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15685
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Kevin Gallardo
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Attachments: log-CASSANDRA-15685.txt, output
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Observed in:
> https://app.circleci.com/pipelines/github/newkek/cassandra/34/workflows/1c6b157d-13c3-48a9-85fb-9fe8c153256b/jobs/191/tests
> Failure:
> {noformat}
> testWithMismatchingPending -
> org.apache.cassandra.distributed.test.PreviewRepairTest
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.distributed.test.PreviewRepairTest.testWithMismatchingPending(PreviewRepairTest.java:97)
> {noformat}
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FCASSANDRA-15685]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15685) flaky testWithMismatchingPending - org.apache.cassandra.distributed.test.PreviewRepairTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121396#comment-17121396
]
David Capwell commented on CASSANDRA-15685:
---
[~bdeggleston] [~marcuse] could we get your thoughts on this? preview repair
isn't allowed to be run concurrently with IR, but IR completes before the
message is handled on the participant; the below is impacted by this race
condition.
{code}
nodetool repair foo bar
# does not look to be running concurrently with the above IR, since it was
notified of success
# but the commit message may not have been seen yet which cause this to be
concurrent with the above
nodetool repair foo bar --validate
{code}
> flaky testWithMismatchingPending -
> org.apache.cassandra.distributed.test.PreviewRepairTest
> --
>
> Key: CASSANDRA-15685
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15685
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Kevin Gallardo
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Attachments: log-CASSANDRA-15685.txt, output
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Observed in:
> https://app.circleci.com/pipelines/github/newkek/cassandra/34/workflows/1c6b157d-13c3-48a9-85fb-9fe8c153256b/jobs/191/tests
> Failure:
> {noformat}
> testWithMismatchingPending -
> org.apache.cassandra.distributed.test.PreviewRepairTest
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.distributed.test.PreviewRepairTest.testWithMismatchingPending(PreviewRepairTest.java:97)
> {noformat}
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FCASSANDRA-15685]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15838) Add deb and rpm packaging to artifacts test script
[
https://issues.apache.org/jira/browse/CASSANDRA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121342#comment-17121342
]
Michael Semb Wever edited comment on CASSANDRA-15838 at 6/1/20, 9:25 PM:
-
Patch at
https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15838
An offline conversation with [~mshuler] raised the concern about the source
artefacts being rebuilt from scratch from the git sha inside the docker
containers.
Being able to pass in the already built source artefact into the docker
containers, so there is the same original source artefact re-used in both the
deb and rpm packages, is considered a requirement but slated for a later
ticket. The priority in this ticket is to create a more robust (tested)
approach to the deb/rpm packages that we distribute. It's currently too brittle
with the debian patches are only applied and tested when cutting a release, and
not having any "nightlies" of deb/rpm available. Take eg the version.properties
[breakage|CASSANDRA-15830] in the alphas.
To test locally…
{code}cd cassandra
../cassandra-builds/build-scripts/cassandra-artifact.sh
# the "builds/" directory should now contain normal build artefacts as well as
the deb and rpm artefacts
{code}
To test in Jenkins
- set up local jenkins
- run the dsl job from the branch, including the following the env
!Screenshot 2020-06-01 at 12.29.21.png|width=500!
- after a successful build of the `Cassandra-*-artifacts` job, the following
artifacts should be attached
!Screenshot 2020-06-01 at 23.24.39.png|width=500!
To test the release process…
{code}
cd cassandra
../cassandra-builds/cassandra-release/prepare_release.sh -f
{code}
was (Author: michaelsembwever):
Patch at
https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15838
An offline conversation with [~mshuler] raised the concern about the source
artefacts being rebuilt from scratch from the git sha inside the docker
containers.
Being able to pass in the already built source artefact into the docker
containers, so there is the same original source artefact re-used in both the
deb and rpm packages, is considered a requirement but slated for a later
ticket. The priority in this ticket is to create a more robust (tested)
approach to the deb/rpm packages that we distribute. It's currently too brittle
with the debian patches are only applied and tested when cutting a release, and
not having any "nightlies" of deb/rpm available. Take eg the version.properties
[breakage|CASSANDRA-15830] in the alphas.
To test locally…
{code}cd cassandra
../cassandra-builds/build-scripts/cassandra-artifact.sh
# the "builds/" directory should now contain normal build artefacts as well as
the deb and rpm artefacts
{code}
To test in Jenkins
- set up local jenkins
- run the dsl job from the branch, including the following the env
!Screenshot 2020-06-01 at 12.29.21.png|width=500!
- after a successful build of the `Cassandra-*-artifacts` job, the following
artifacts should be attached
To test the release process…
{code}
cd cassandra
../cassandra-builds/cassandra-release/prepare_release.sh -f
{code}
> Add deb and rpm packaging to artifacts test script
> --
>
> Key: CASSANDRA-15838
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15838
> Project: Cassandra
> Issue Type: Task
> Components: Build, CI, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: Screenshot 2020-06-01 at 12.29.21.png, Screenshot
> 2020-06-01 at 23.24.39.png
>
>
> Currently we have no way of testing debian or rpm packaging. This is a
> problem, it hurts when cutting releases as well as afterwards (like
> CASSANDRA-15830).
> This ticket is to add testing of debian or rpm packaging into the artifacts
> test script.
> This will also provide "nightly" build artifacts for the deb and rpm packages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15838) Add deb and rpm packaging to artifacts test script
[ https://issues.apache.org/jira/browse/CASSANDRA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-15838: --- Attachment: Screenshot 2020-06-01 at 23.24.39.png > Add deb and rpm packaging to artifacts test script > -- > > Key: CASSANDRA-15838 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15838 > Project: Cassandra > Issue Type: Task > Components: Build, CI, Packaging >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0-beta > > Attachments: Screenshot 2020-06-01 at 12.29.21.png, Screenshot > 2020-06-01 at 23.24.39.png > > > Currently we have no way of testing debian or rpm packaging. This is a > problem, it hurts when cutting releases as well as afterwards (like > CASSANDRA-15830). > This ticket is to add testing of debian or rpm packaging into the artifacts > test script. > This will also provide "nightly" build artifacts for the deb and rpm packages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15838) Add deb and rpm packaging to artifacts test script
[
https://issues.apache.org/jira/browse/CASSANDRA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121342#comment-17121342
]
Michael Semb Wever edited comment on CASSANDRA-15838 at 6/1/20, 9:24 PM:
-
Patch at
https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15838
An offline conversation with [~mshuler] raised the concern about the source
artefacts being rebuilt from scratch from the git sha inside the docker
containers.
Being able to pass in the already built source artefact into the docker
containers, so there is the same original source artefact re-used in both the
deb and rpm packages, is considered a requirement but slated for a later
ticket. The priority in this ticket is to create a more robust (tested)
approach to the deb/rpm packages that we distribute. It's currently too brittle
with the debian patches are only applied and tested when cutting a release, and
not having any "nightlies" of deb/rpm available. Take eg the version.properties
[breakage|CASSANDRA-15830] in the alphas.
To test locally…
{code}cd cassandra
../cassandra-builds/build-scripts/cassandra-artifact.sh
# the "builds/" directory should now contain normal build artefacts as well as
the deb and rpm artefacts
{code}
To test in Jenkins
- set up local jenkins
- run the dsl job from the branch, including the following the env
!Screenshot 2020-06-01 at 12.29.21.png|width=500!
- after a successful build of the `Cassandra-*-artifacts` job, the following
artifacts should be attached
To test the release process…
{code}
cd cassandra
../cassandra-builds/cassandra-release/prepare_release.sh -f
{code}
was (Author: michaelsembwever):
Patch at
https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15838
An offline conversation with [~mshuler] raised the concern about the source
artefacts being rebuilt from scratch from the git sha inside the docker
containers.
Being able to pass in the already built source artefact into the docker
containers, so there is the same original source artefact re-used in both the
deb and rpm packages, is considered a requirement but slated for a later
ticket. The priority in this ticket is to create a more robust (tested)
approach to the deb/rpm packages that we distribute. It's currently too brittle
with the debian patches are only applied and tested when cutting a release, and
not having any "nightlies" of deb/rpm available. Take eg the version.properties
[breakage|CASSANDRA-15830] in the alphas.
To test locally…
{code}cd cassandra
../cassandra-builds/build-scripts/cassandra-artifact.sh
# the "builds/" directory should now contain normal build artefacts as well as
the deb and rpm artefacts
{code}
To test in Jenkins
- set up local jenkins
- run the dsl job from the branch, including the following the env
!Screenshot 2020-06-01 at 12.29.21.png|width=500!
To test the release process…
{code}
cd cassandra
../cassandra-builds/cassandra-release/prepare_release.sh -f
{code}
> Add deb and rpm packaging to artifacts test script
> --
>
> Key: CASSANDRA-15838
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15838
> Project: Cassandra
> Issue Type: Task
> Components: Build, CI, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: Screenshot 2020-06-01 at 12.29.21.png
>
>
> Currently we have no way of testing debian or rpm packaging. This is a
> problem, it hurts when cutting releases as well as afterwards (like
> CASSANDRA-15830).
> This ticket is to add testing of debian or rpm packaging into the artifacts
> test script.
> This will also provide "nightly" build artifacts for the deb and rpm packages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15838) Add deb and rpm packaging to artifacts test script
[
https://issues.apache.org/jira/browse/CASSANDRA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121342#comment-17121342
]
Michael Semb Wever edited comment on CASSANDRA-15838 at 6/1/20, 9:22 PM:
-
Patch at
https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15838
An offline conversation with [~mshuler] raised the concern about the source
artefacts being rebuilt from scratch from the git sha inside the docker
containers.
Being able to pass in the already built source artefact into the docker
containers, so there is the same original source artefact re-used in both the
deb and rpm packages, is considered a requirement but slated for a later
ticket. The priority in this ticket is to create a more robust (tested)
approach to the deb/rpm packages that we distribute. It's currently too brittle
with the debian patches are only applied and tested when cutting a release, and
not having any "nightlies" of deb/rpm available. Take eg the version.properties
[breakage|CASSANDRA-15830] in the alphas.
To test locally…
{code}cd cassandra
../cassandra-builds/build-scripts/cassandra-artifact.sh
# the "builds/" directory should now contain normal build artefacts as well as
the deb and rpm artefacts
{code}
To test in Jenkins
- set up local jenkins
- run the dsl job from the branch, including the following the env
!Screenshot 2020-06-01 at 12.29.21.png|width=500!
To test the release process…
{code}
cd cassandra
../cassandra-builds/cassandra-release/prepare_release.sh -f
{code}
was (Author: michaelsembwever):
Patch at
https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15838
To test locally…
{code}cd cassandra
../cassandra-builds/build-scripts/cassandra-artifact.sh
# the "builds/" directory should now contain normal build artefacts as well as
the deb and rpm artefacts
{code}
To test in Jenkins
- set up local jenkins
- run the dsl job from the branch, including the following the env
!Screenshot 2020-06-01 at 12.29.21.png|width=500!
To test the release process…
{code}
cd cassandra
../cassandra-builds/cassandra-release/prepare_release.sh -f
{code}
> Add deb and rpm packaging to artifacts test script
> --
>
> Key: CASSANDRA-15838
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15838
> Project: Cassandra
> Issue Type: Task
> Components: Build, CI, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: Screenshot 2020-06-01 at 12.29.21.png
>
>
> Currently we have no way of testing debian or rpm packaging. This is a
> problem, it hurts when cutting releases as well as afterwards (like
> CASSANDRA-15830).
> This ticket is to add testing of debian or rpm packaging into the artifacts
> test script.
> This will also provide "nightly" build artifacts for the deb and rpm packages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15838) Add deb and rpm packaging to artifacts test script
[
https://issues.apache.org/jira/browse/CASSANDRA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121342#comment-17121342
]
Michael Semb Wever commented on CASSANDRA-15838:
Patch at
https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15838
To test locally…
{code}cd cassandra
../cassandra-builds/build-scripts/cassandra-artifact.sh
# the "builds/" directory should now contain normal build artefacts as well as
the deb and rpm artefacts
{code}
To test in Jenkins
- set up local jenkins
- run the dsl job from the branch, including the following the env
!Screenshot 2020-06-01 at 12.29.21.png|width=200!
To test the release process…
{code}
cd cassandra
../cassandra-builds/cassandra-release/prepare_release.sh -f
{code}
> Add deb and rpm packaging to artifacts test script
> --
>
> Key: CASSANDRA-15838
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15838
> Project: Cassandra
> Issue Type: Task
> Components: Build, CI, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: Screenshot 2020-06-01 at 12.29.21.png
>
>
> Currently we have no way of testing debian or rpm packaging. This is a
> problem, it hurts when cutting releases as well as afterwards (like
> CASSANDRA-15830).
> This ticket is to add testing of debian or rpm packaging into the artifacts
> test script.
> This will also provide "nightly" build artifacts for the deb and rpm packages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15838) Add deb and rpm packaging to artifacts test script
[
https://issues.apache.org/jira/browse/CASSANDRA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121342#comment-17121342
]
Michael Semb Wever edited comment on CASSANDRA-15838 at 6/1/20, 9:17 PM:
-
Patch at
https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15838
To test locally…
{code}cd cassandra
../cassandra-builds/build-scripts/cassandra-artifact.sh
# the "builds/" directory should now contain normal build artefacts as well as
the deb and rpm artefacts
{code}
To test in Jenkins
- set up local jenkins
- run the dsl job from the branch, including the following the env
!Screenshot 2020-06-01 at 12.29.21.png|width=500!
To test the release process…
{code}
cd cassandra
../cassandra-builds/cassandra-release/prepare_release.sh -f
{code}
was (Author: michaelsembwever):
Patch at
https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15838
To test locally…
{code}cd cassandra
../cassandra-builds/build-scripts/cassandra-artifact.sh
# the "builds/" directory should now contain normal build artefacts as well as
the deb and rpm artefacts
{code}
To test in Jenkins
- set up local jenkins
- run the dsl job from the branch, including the following the env
!Screenshot 2020-06-01 at 12.29.21.png|width=200!
To test the release process…
{code}
cd cassandra
../cassandra-builds/cassandra-release/prepare_release.sh -f
{code}
> Add deb and rpm packaging to artifacts test script
> --
>
> Key: CASSANDRA-15838
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15838
> Project: Cassandra
> Issue Type: Task
> Components: Build, CI, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: Screenshot 2020-06-01 at 12.29.21.png
>
>
> Currently we have no way of testing debian or rpm packaging. This is a
> problem, it hurts when cutting releases as well as afterwards (like
> CASSANDRA-15830).
> This ticket is to add testing of debian or rpm packaging into the artifacts
> test script.
> This will also provide "nightly" build artifacts for the deb and rpm packages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15838) Add deb and rpm packaging to artifacts test script
[ https://issues.apache.org/jira/browse/CASSANDRA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-15838: --- Attachment: Screenshot 2020-06-01 at 12.29.21.png > Add deb and rpm packaging to artifacts test script > -- > > Key: CASSANDRA-15838 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15838 > Project: Cassandra > Issue Type: Task > Components: Build, CI, Packaging >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0-beta > > Attachments: Screenshot 2020-06-01 at 12.29.21.png > > > Currently we have no way of testing debian or rpm packaging. This is a > problem, it hurts when cutting releases as well as afterwards (like > CASSANDRA-15830). > This ticket is to add testing of debian or rpm packaging into the artifacts > test script. > This will also provide "nightly" build artifacts for the deb and rpm packages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15838) Add deb and rpm packaging to artifacts test script
[ https://issues.apache.org/jira/browse/CASSANDRA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-15838: --- Description: Currently we have no way of testing debian or rpm packaging. This is a problem, it hurts when cutting releases as well as afterwards (like CASSANDRA-15830). This ticket is to add testing of debian or rpm packaging into the artifacts test script. This will also provide "nightly" build artifacts for the deb and rpm packages. was: Currently we have no way of testing debian or rpm packaging. This is a problem, it hurts when cutting releases as well as afterwards (like CASSANDRA-15830). This ticket is to add testing of debian or rpm packaging into the artifacts test script. > Add deb and rpm packaging to artifacts test script > -- > > Key: CASSANDRA-15838 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15838 > Project: Cassandra > Issue Type: Task > Components: Build, CI, Packaging >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0-beta > > > Currently we have no way of testing debian or rpm packaging. This is a > problem, it hurts when cutting releases as well as afterwards (like > CASSANDRA-15830). > This ticket is to add testing of debian or rpm packaging into the artifacts > test script. > This will also provide "nightly" build artifacts for the deb and rpm packages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15838) Add deb and rpm packaging to artifacts test script
[
https://issues.apache.org/jira/browse/CASSANDRA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120336#comment-17120336
]
Michael Semb Wever edited comment on CASSANDRA-15838 at 6/1/20, 9:09 PM:
-
Current approach I'm taking is
- extend the {{cassandra-builds/build-scripts/cassandra-*-packaging.sh}}
scripts to build on SHAs (as well as tags and branches),
- include calling the {{cassandra-*-packaging.sh}} scripts from the
{{cassandra-artifacts.sh}} scripts,
- get {{prepare_release.sh}} script to re-use the {{cassandra-*-packaging.sh}}
scripts,
- have jenkins artifact jobs save the deb and rpm packages, so they are
available as "nightlies" (along with the tar.gz files)
Similar/Related (previous) issues:
- CASSANDRA-13487
- CASSANDRA-14712
- CASSANDRA-13433
- CASSANDRA-13252
- CASSANDRA-13230
(fyi [~mshuler], [~spod], [~stefan.miklosovic])
was (Author: michaelsembwever):
Current approach I'm taking is
- extend the {{cassandra-builds/build-scripts/cassandra-*-packaging.sh}}
scripts to build on SHAs (as well as tags and branches),
- include calling the {{cassandra-*-packaging.sh}} scripts from the
{{cassandra-artifacts.sh}} scripts,
- get {{prepare_release.sh}} script to re-use the {{cassandra-*-packaging.sh}}
scripts,
- have jenkins artifact jobs save the deb and rpm packages, so they are
available as "nightlies" (along with the tar.gz files)
(fyi [~mshuler], [~spod])
> Add deb and rpm packaging to artifacts test script
> --
>
> Key: CASSANDRA-15838
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15838
> Project: Cassandra
> Issue Type: Task
> Components: Build, CI, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Currently we have no way of testing debian or rpm packaging. This is a
> problem, it hurts when cutting releases as well as afterwards (like
> CASSANDRA-15830).
> This ticket is to add testing of debian or rpm packaging into the artifacts
> test script.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15778) CorruptSSTableException after a 2.1 SSTable is upgraded to 3.0, failing reads
[
https://issues.apache.org/jira/browse/CASSANDRA-15778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121290#comment-17121290
]
David Capwell commented on CASSANDRA-15778:
---
bq. Could you elaborate a bit? Stack trace doesn't change in this case, and
exception itself hasn't changed from the old version.
Think code will speak loader.
{code}
if (meta.isDense() && meta.compactValueColumn().type instanceof EmptyType)
{
if (validator != null
&& validator.getType() instanceof BytesType
& meta.compactValueColumn().equals(def))
{
cfm = meta.copyWithNewCompactValueType(validator.getType());
break;
}
else
{
throw new InvalidRequestException("Altering of compaction value column
types is only allowed if changing to bytes, but given " + validator.getType());
}
}
{code}
If I know that the column has always been an integer and I attempt to set as a
int32 I get an exception saying that alter isn't allowed; this exception can
imply that there is no way to fix the issue. To make it more actionable, it
would be better to say that alter is only allowed to be bytes and that the
provided type is not supported.
> CorruptSSTableException after a 2.1 SSTable is upgraded to 3.0, failing reads
> -
>
> Key: CASSANDRA-15778
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15778
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction, Local/SSTable
>Reporter: Sumanth Pasupuleti
>Assignee: Alex Petrov
>Priority: Normal
> Fix For: 3.0.x
>
>
> Below is the exception with stack trace. This issue is consistently
> reproduce-able.
> {code:java}
> ERROR [SharedPool-Worker-1] 2020-05-01 14:57:57,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,main]ERROR [SharedPool-Worker-1] 2020-05-01
> 14:57:57,661 AbstractLocalAwareExecutorService.java:169 - Uncaught exception
> on thread
> Thread[SharedPool-Worker-1,5,main]org.apache.cassandra.io.sstable.CorruptSSTableException:
> Corrupted:
> /mnt/data/cassandra/data// at
> org.apache.cassandra.db.columniterator.AbstractSSTableIterator$Reader.hasNext(AbstractSSTableIterator.java:349)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.columniterator.AbstractSSTableIterator.hasNext(AbstractSSTableIterator.java:220)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.columniterator.SSTableIterator.hasNext(SSTableIterator.java:33)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:129)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:129)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:129)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:131)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:87)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:77)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Serializer.serialize(UnfilteredPartitionIterators.java:294)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadResponse.java:187)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
> org.apache.cassandra.db.ReadResponse$LocalDataResponse.(ReadResponse.java:180)
> ~[nf-cassandra-3.0.19.8.jar:3.0.19.8] at
>
[jira] [Updated] (CASSANDRA-15843) Include DROPPED_COLUMNS in schema digest computation.
[ https://issues.apache.org/jira/browse/CASSANDRA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-15843: -- Reviewers: Aleksey Yeschenko, Aleksey Yeschenko (was: Aleksey Yeschenko) Aleksey Yeschenko, Aleksey Yeschenko Status: Review In Progress (was: Patch Available) > Include DROPPED_COLUMNS in schema digest computation. > - > > Key: CASSANDRA-15843 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15843 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > Fix For: 4.0-alpha > > > CASSANDRA-11050 introduced dropped columns but excluded it from schema digest > computations, with a comment to include the table in the next major release - > 4.0. > Change SchemaKeyspace to include DROPPED_COLUMNS in the schema digest > computation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15843) Include DROPPED_COLUMNS in schema digest computation.
[ https://issues.apache.org/jira/browse/CASSANDRA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121288#comment-17121288 ] Aleksey Yeschenko commented on CASSANDRA-15843: --- LGTM pending CI results. > Include DROPPED_COLUMNS in schema digest computation. > - > > Key: CASSANDRA-15843 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15843 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > Fix For: 4.0-alpha > > > CASSANDRA-11050 introduced dropped columns but excluded it from schema digest > computations, with a comment to include the table in the next major release - > 4.0. > Change SchemaKeyspace to include DROPPED_COLUMNS in the schema digest > computation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15843) Include DROPPED_COLUMNS in schema digest computation.
[ https://issues.apache.org/jira/browse/CASSANDRA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-15843: -- Status: Ready to Commit (was: Review In Progress) > Include DROPPED_COLUMNS in schema digest computation. > - > > Key: CASSANDRA-15843 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15843 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > Fix For: 4.0-alpha > > > CASSANDRA-11050 introduced dropped columns but excluded it from schema digest > computations, with a comment to include the table in the next major release - > 4.0. > Change SchemaKeyspace to include DROPPED_COLUMNS in the schema digest > computation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15843) Include DROPPED_COLUMNS in schema digest computation.
[ https://issues.apache.org/jira/browse/CASSANDRA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Meredith updated CASSANDRA-15843: - Test and Documentation Plan: Check for regressions in existing unit tests. Status: Patch Available (was: Open) > Include DROPPED_COLUMNS in schema digest computation. > - > > Key: CASSANDRA-15843 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15843 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > Fix For: 4.0-alpha > > > CASSANDRA-11050 introduced dropped columns but excluded it from schema digest > computations, with a comment to include the table in the next major release - > 4.0. > Change SchemaKeyspace to include DROPPED_COLUMNS in the schema digest > computation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15843) Include DROPPED_COLUMNS in schema digest computation.
[ https://issues.apache.org/jira/browse/CASSANDRA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121281#comment-17121281 ] Jon Meredith commented on CASSANDRA-15843: -- [Pull Request|https://github.com/apache/cassandra/pull/610] [CircleCI - Java 8|https://app.circleci.com/pipelines/github/jonmeredith/cassandra/347/workflows/10d75c53-b8bf-480b-93f3-63d9e4a5488e] (you may need to be logged in to CircleCI to see this) [CircleCI - Java11|https://app.circleci.com/pipelines/github/jonmeredith/cassandra/347/workflows/8e4447dd-4bab-4c81-80e4-07eafe3425dc] (you may need to be logged in to CircleCI to see this) > Include DROPPED_COLUMNS in schema digest computation. > - > > Key: CASSANDRA-15843 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15843 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > Fix For: 4.0-alpha > > > CASSANDRA-11050 introduced dropped columns but excluded it from schema digest > computations, with a comment to include the table in the next major release - > 4.0. > Change SchemaKeyspace to include DROPPED_COLUMNS in the schema digest > computation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15843) Include DROPPED_COLUMNS in schema digest computation.
[ https://issues.apache.org/jira/browse/CASSANDRA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Meredith updated CASSANDRA-15843: - Change Category: Semantic Complexity: Low Hanging Fruit Fix Version/s: 4.0-alpha Status: Open (was: Triage Needed) > Include DROPPED_COLUMNS in schema digest computation. > - > > Key: CASSANDRA-15843 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15843 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > Fix For: 4.0-alpha > > > CASSANDRA-11050 introduced dropped columns but excluded it from schema digest > computations, with a comment to include the table in the next major release - > 4.0. > Change SchemaKeyspace to include DROPPED_COLUMNS in the schema digest > computation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15843) Include DROPPED_COLUMNS in schema digest computation.
Jon Meredith created CASSANDRA-15843: Summary: Include DROPPED_COLUMNS in schema digest computation. Key: CASSANDRA-15843 URL: https://issues.apache.org/jira/browse/CASSANDRA-15843 Project: Cassandra Issue Type: Improvement Components: Cluster/Schema Reporter: Jon Meredith CASSANDRA-11050 introduced dropped columns but excluded it from schema digest computations, with a comment to include the table in the next major release - 4.0. Change SchemaKeyspace to include DROPPED_COLUMNS in the schema digest computation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15843) Include DROPPED_COLUMNS in schema digest computation.
[ https://issues.apache.org/jira/browse/CASSANDRA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Meredith reassigned CASSANDRA-15843: Assignee: Jon Meredith > Include DROPPED_COLUMNS in schema digest computation. > - > > Key: CASSANDRA-15843 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15843 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > > CASSANDRA-11050 introduced dropped columns but excluded it from schema digest > computations, with a comment to include the table in the next major release - > 4.0. > Change SchemaKeyspace to include DROPPED_COLUMNS in the schema digest > computation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11107) Add native_transport_address and native_transport_broadcast_address yaml options
[
https://issues.apache.org/jira/browse/CASSANDRA-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-11107:
Reviewers: (was: Sam Tunnicliffe)
> Add native_transport_address and native_transport_broadcast_address yaml
> options
>
>
> Key: CASSANDRA-11107
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11107
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: n0rad
>Assignee: Joel Knighton
>Priority: Low
> Labels: remove-reopen
>
> I'm starting cassandra on a container with this /etc/hosts
> {quote}
> 127.0.0.1rkt-235c219a-f0dc-4958-9e03-5afe2581bbe1 localhost
> ::1 rkt-235c219a-f0dc-4958-9e03-5afe2581bbe1 localhost
> {quote}
> I have the default configuration except :
> {quote}
> - seeds: "10.1.1.1"
> listen_address : 10.1.1.1
> {quote}
> cassandra will start listening on *127.0.0.1:9042*
> if I set *rpc_address:10.1.1.1* , even if *start_rpc: false*, cassandra will
> listen on 10.1.1.1
> Since rpc is not started, I assumed that *rpc_address* and
> *broadcast_rpc_address* will be ignored
> It took me a while to figure that. There may be something to do around this
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15600) Algorithmic token allocation does not handle the racks = RF case well
[ https://issues.apache.org/jira/browse/CASSANDRA-15600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121134#comment-17121134 ] Kornel Pal commented on CASSANDRA-15600: [~e.dimitrova] you have added a generateSplits method to ReplicationAwareTokenAllocator, but it does not seem to be used. New comments suggest that splits are supposed to be used, but generateRandomTokens is used instead. Could you please double check whether some intended changes are missing from the commit. > Algorithmic token allocation does not handle the racks = RF case well > - > > Key: CASSANDRA-15600 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15600 > Project: Cassandra > Issue Type: Bug > Components: Feature/Virtual Nodes >Reporter: Branimir Lambov >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0, 4.0-alpha4 > > Attachments: CASSANDRA-15600 unit.txt, CASSANDRA-15600-jvm.txt.zip, > Screen Shot 2020-03-02 at 6.55.41 PM.png > > > When the number of racks in a data centre is equal to the replication factor, > the node allocation algorithm may calculate the target ownership incorrectly > and allocate unsuitable tokens. This causes some inefficiency when the number > of nodes in the DC is small, and significant problems if the number of nodes > in each rack is different. > In this case (racks count equal to replication factor) the load within each > rack is effectively distributed independently. The allocation algorithm > should reflect that, restricting the allocation space to the rack (instead of > the DC) and using the RF=1 solution. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15792) test_speculative_data_request - read_repair_test.TestSpeculativeReadRepair
[ https://issues.apache.org/jira/browse/CASSANDRA-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121116#comment-17121116 ] Gianluca Righetto edited comment on CASSANDRA-15792 at 6/1/20, 4:01 PM: [~jmckenzie] After investigating this for some time now, I determined this is mostly related to a low write timeout used in TestSpeculativeReadRepair. That may lead to a speculated write to a different node depending on how long the original node takes to apply the repair mutation, but the test assertion is expecting no speculated writes. In other words, this is mostly a problem with the test, not with C* runtime, which is doing the right thing. In order to fix this, I made it accept speculated writes in the original test, but I also replicated the test method in a different test class with a longer write timeout to reduce the likelihood of speculated writes. Of course, since this is all time based, the new test may still fail under a system with high CPU contention, but at least for now I can't easily reproduce the failure anymore (whereas it was failing consistently for me before). There are other tests that guarantee the speculated write will happen when needed, the tricky part is testing it won't happen within a time frame, since it depends on system performance. Here's the pull request in my cassandra-dtest fork: [https://github.com/grighetto/cassandra-dtest/pull/1] Regarding the fixver, I'm ok with moving this to beta, even though the fix is already available, it still needs to go through review, but since this is not a runtime problem, I wouldn't say this is a blocker for alpha. was (Author: gianluca): [~jmckenzie] After investigating this for some time now, I determined this is mostly related to a low write timeout used in TestSpeculativeReadRepair. That may lead to a speculated write to a different node depending on how long the original node takes to apply the repair mutation, but the test assertion is expecting no speculated writes. In other words, this is mostly a problem with the test, not with C* runtime, which is doing the right thing. In order to fix this, I made it accept speculated writes in the original test, but I also replicated the test method in a different test class with a longer write timeout to reduce the likelihood of speculated writes. Of course, since this is all time based, the new test may still fail under a system with high CPU contention, but at least for now I can't easily reproduce the failure anymore (whereas it was failing consistently for me before). Here's the pull request in my cassandra-dtest fork: [https://github.com/grighetto/cassandra-dtest/pull/1] Regarding the fixver, I'm ok with moving this to beta, even though the fix is already available, it still needs to go through review, but since this is not a runtime problem, I wouldn't say this is a blocker for alpha. > test_speculative_data_request - read_repair_test.TestSpeculativeReadRepair > -- > > Key: CASSANDRA-15792 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15792 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Gianluca Righetto >Priority: Normal > Fix For: 4.0-alpha > > > Failing on the latest trunk here: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/127/workflows/dfba669d-4a5c-4553-b6a2-85647d0d8d2b/jobs/668/tests > Failing once in 30 times as per Jenkins: > https://jenkins-cm4.apache.org/job/Cassandra-trunk-dtest/69/testReport/dtest.read_repair_test/TestSpeculativeReadRepair/test_speculative_data_request/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15802) Commented-out lines that end in a semicolon cause an error.
[ https://issues.apache.org/jira/browse/CASSANDRA-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rens Groothuijsen updated CASSANDRA-15802: -- Test and Documentation Plan: N/A Status: Patch Available (was: Open) > Commented-out lines that end in a semicolon cause an error. > --- > > Key: CASSANDRA-15802 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15802 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter, CQL/Syntax >Reporter: null >Assignee: Rens Groothuijsen >Priority: Normal > Attachments: cqlsh.png > > Time Spent: 10m > Remaining Estimate: 0h > > Commented-out lines that end in a semicolon cause an error. > For example: > /* > describe keyspaces; > */ > > This produces an error: > SyntaxException: line 2:22 no viable alternative at input ' (...* > describe keyspaces;...) > > It works as expected if you use syntax: > -- describe keyspaces; > > Environment: > python:3.7.7-slim-stretch (docker image) > > I found that this was first seen here, and was patched, but the bug appears > to have resurfaced: > https://issues.apache.org/jira/browse/CASSANDRA-2488 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15792) test_speculative_data_request - read_repair_test.TestSpeculativeReadRepair
[ https://issues.apache.org/jira/browse/CASSANDRA-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gianluca Righetto updated CASSANDRA-15792: -- Test and Documentation Plan: Confirm that both tests below pass consistently now. TestSpeculativeReadRepair::test_speculative_data_request TestSpeculativeReadRepairLongerTimeout::test_speculative_data_request_without_speculative_write Status: Patch Available (was: In Progress) > test_speculative_data_request - read_repair_test.TestSpeculativeReadRepair > -- > > Key: CASSANDRA-15792 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15792 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Gianluca Righetto >Priority: Normal > Fix For: 4.0-alpha > > > Failing on the latest trunk here: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/127/workflows/dfba669d-4a5c-4553-b6a2-85647d0d8d2b/jobs/668/tests > Failing once in 30 times as per Jenkins: > https://jenkins-cm4.apache.org/job/Cassandra-trunk-dtest/69/testReport/dtest.read_repair_test/TestSpeculativeReadRepair/test_speculative_data_request/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15792) test_speculative_data_request - read_repair_test.TestSpeculativeReadRepair
[ https://issues.apache.org/jira/browse/CASSANDRA-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121116#comment-17121116 ] Gianluca Righetto commented on CASSANDRA-15792: --- [~jmckenzie] After investigating this for some time now, I determined this is mostly related to a low write timeout used in TestSpeculativeReadRepair. That may lead to a speculated write to a different node depending on how long the original node takes to apply the repair mutation, but the test assertion is expecting no speculated writes. In other words, this is mostly a problem with the test, not with C* runtime, which is doing the right thing. In order to fix this, I made it accept speculated writes in the original test, but I also replicated the test method in a different test class with a longer write timeout to reduce the likelihood of speculated writes. Of course, since this is all time based, the new test may still fail under a system with high CPU contention, but at least for now I can't easily reproduce the failure anymore (whereas it was failing consistently for me before). Here's the pull request in my cassandra-dtest fork: [https://github.com/grighetto/cassandra-dtest/pull/1] Regarding the fixver, I'm ok with moving this to beta, even though the fix is already available, it still needs to go through review, but since this is not a runtime problem, I wouldn't say this is a blocker for alpha. > test_speculative_data_request - read_repair_test.TestSpeculativeReadRepair > -- > > Key: CASSANDRA-15792 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15792 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Gianluca Righetto >Priority: Normal > Fix For: 4.0-alpha > > > Failing on the latest trunk here: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/127/workflows/dfba669d-4a5c-4553-b6a2-85647d0d8d2b/jobs/668/tests > Failing once in 30 times as per Jenkins: > https://jenkins-cm4.apache.org/job/Cassandra-trunk-dtest/69/testReport/dtest.read_repair_test/TestSpeculativeReadRepair/test_speculative_data_request/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15666) Race condition when completing stream sessions
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ZhaoYang updated CASSANDRA-15666:
-
Reviewers: Benjamin Lerer, Sergio Bossa (was: Benjamin Lerer, Sergio
Bossa, ZhaoYang)
> Race condition when completing stream sessions
> --
>
> Key: CASSANDRA-15666
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15666
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Streaming and Messaging
>Reporter: Sergio Bossa
>Assignee: ZhaoYang
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0, 4.0-alpha5
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{StreamSession#prepareAsync()}} executes, as the name implies,
> asynchronously from the IO thread: this opens up for race conditions between
> the sending of the {{PrepareSynAckMessage}} and the call to
> {{StreamSession#maybeCompleted()}}. I.e., the following could happen:
> 1) Node A sends {{PrepareSynAckMessage}} from the {{prepareAsync()}} thread.
> 2) Node B receives it and starts streaming.
> 3) Node A receives the streamed file and sends {{ReceivedMessage}}.
> 4) At this point, if this was the only file to stream, both nodes are ready
> to close the session via {{maybeCompleted()}}, but:
> a) Node A will call it twice from both the IO thread and the thread at #1,
> closing the session and its channels.
> b) Node B will attempt to send a {{CompleteMessage}}, but will fail because
> the session has been closed in the meantime.
> There are other subtle variations of the pattern above, depending on the
> order of concurrently sent/received messages.
> I believe the best fix would be to modify the message exchange so that:
> 1) Only the "follower" is allowed to send the {{CompleteMessage}}.
> 2) Only the "initiator" is allowed to close the session and its channels
> after receiving the {{CompleteMessage}}.
> By doing so, the message exchange logic would be easier to reason about,
> which is overall a win anyway.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-8612) Read metrics should be updated on all types of reads
[ https://issues.apache.org/jira/browse/CASSANDRA-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121076#comment-17121076 ] Chris Lohfink commented on CASSANDRA-8612: -- Yeah thats pretty much it. its gonna be bit of auditing the existing metrics and adding where it only captures one case. If you are including latencies this gets a bit more confusing. We have "read latencies" for single partition latencies and "coordinator scan" latencies for range queries. Really it seems like "read" should be them merged and maybe have a range/single specific one. This could be like a gauge that merges the metrics at read time (like keyspace/table parent latencies do). But if keeping latencies outta scope of this I dont think it's necessary to support the 2 different types still. For tombstones per read/sstables per read I think it makes more sense to just have a single metric, and it seems to me more like a bug that C* doesnt even include them in range reads. > Read metrics should be updated on all types of reads > > > Key: CASSANDRA-8612 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8612 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Chris Lohfink >Priority: Low > Labels: lhf, metrics > Attachments: 0001-Update-read-metrics-on-all-types-of-reads.patch > > > Metrics like "sstables per read" are not updated on a range slice. Although > separating things out for each type of read could make sense like we do for > latencies, only exposing the metrics for one type can be a little confusing > when people do a query and see nothing increases. I think its sufficient to > use the same metrics for all reads. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15842) Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15842: Fix Version/s: 4.0-beta > Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc > - > > Key: CASSANDRA-15842 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15842 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > Time Spent: 20m > Remaining Estimate: 0h > > Failing for the past [28 > builds|https://ci-cassandra.apache.org/job/Cassandra-trunk/153/testReport/org.apache.cassandra.schema/SchemaTest/testTransKsMigration_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.schema.SchemaTest.testTransKsMigration(SchemaTest.java:46) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15842) Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15842: Test and Documentation Plan: See PR Status: Patch Available (was: In Progress) > Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc > - > > Key: CASSANDRA-15842 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15842 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > > Failing for the past [28 > builds|https://ci-cassandra.apache.org/job/Cassandra-trunk/153/testReport/org.apache.cassandra.schema/SchemaTest/testTransKsMigration_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.schema.SchemaTest.testTransKsMigration(SchemaTest.java:46) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15842) Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120923#comment-17120923 ] Berenguer Blasi commented on CASSANDRA-15842: - Whoever reviews this one please take a look at CASSANDRA-15841 as well. > Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc > - > > Key: CASSANDRA-15842 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15842 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Failing for the past [28 > builds|https://ci-cassandra.apache.org/job/Cassandra-trunk/153/testReport/org.apache.cassandra.schema/SchemaTest/testTransKsMigration_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.schema.SchemaTest.testTransKsMigration(SchemaTest.java:46) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15841) Fix flaky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120924#comment-17120924 ] Berenguer Blasi commented on CASSANDRA-15841: - Whoever reviews this one please take a look at CASSANDRA-15842 as well. > Fix flaky > junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc > > > Key: CASSANDRA-15841 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15841 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > Time Spent: 20m > Remaining Estimate: 0h > > Failing for the past [29 > buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15842) Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15842: Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Normal Discovered By: Unit Test Severity: Normal Assignee: Berenguer Blasi Status: Open (was: Triage Needed) > Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc > - > > Key: CASSANDRA-15842 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15842 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Failing for the past [28 > builds|https://ci-cassandra.apache.org/job/Cassandra-trunk/153/testReport/org.apache.cassandra.schema/SchemaTest/testTransKsMigration_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.schema.SchemaTest.testTransKsMigration(SchemaTest.java:46) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15841) Fix flaky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15841: Summary: Fix flaky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc (was: Fix flacky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc) > Fix flaky > junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc > > > Key: CASSANDRA-15841 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15841 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > Time Spent: 20m > Remaining Estimate: 0h > > Failing for the past [29 > buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15842) Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc
Berenguer Blasi created CASSANDRA-15842: --- Summary: Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc Key: CASSANDRA-15842 URL: https://issues.apache.org/jira/browse/CASSANDRA-15842 Project: Cassandra Issue Type: Bug Components: Test/unit Reporter: Berenguer Blasi Failing for the past [28 builds|https://ci-cassandra.apache.org/job/Cassandra-trunk/153/testReport/org.apache.cassandra.schema/SchemaTest/testTransKsMigration_cdc/] java.lang.NullPointerException at org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) at org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) at org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) at org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) at org.apache.cassandra.schema.SchemaTest.testTransKsMigration(SchemaTest.java:46) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15841) Fix flacky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15841: Test and Documentation Plan: See PR Status: Patch Available (was: In Progress) > Fix flacky > junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc > - > > Key: CASSANDRA-15841 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15841 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > Time Spent: 10m > Remaining Estimate: 0h > > Failing for the past [29 > buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15841) Fix flacky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15841: Complexity: Normal Severity: Normal Status: Open (was: Triage Needed) > Fix flacky > junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc > - > > Key: CASSANDRA-15841 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15841 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Failing for the past [29 > buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15841) Fix flacky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15841: Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Discovered By: Unit Test Fix Version/s: 4.0-beta > Fix flacky > junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc > - > > Key: CASSANDRA-15841 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15841 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Failing for the past [29 > buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15841) Fix flacky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
[
https://issues.apache.org/jira/browse/CASSANDRA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-15841:
Description:
Failing for the past [29
buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/]
java.lang.NullPointerException
at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312)
at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89)
at
org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413)
at
org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467)
at
org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785)
at
org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62)
was:
Failing for the past [29
buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/]
{{java.lang.NullPointerException
at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312)
at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89)
at
org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413)
at
org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467)
at
org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785)
at
org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62)}}
> Fix flacky
> junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
> -
>
> Key: CASSANDRA-15841
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15841
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Priority: Normal
>
> Failing for the past [29
> buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/]
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312)
> at
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413)
> at
> org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467)
> at
> org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785)
> at
> org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15841) Fix flacky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
[ https://issues.apache.org/jira/browse/CASSANDRA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi reassigned CASSANDRA-15841: --- Assignee: Berenguer Blasi > Fix flacky > junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc > - > > Key: CASSANDRA-15841 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15841 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > > Failing for the past [29 > buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15841) Fix flacky junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
Berenguer Blasi created CASSANDRA-15841:
---
Summary: Fix flacky
junit.framework.TestSuite.org.apache.cassandra.io.sstable.CQLSSTableWriterTest-cdc
Key: CASSANDRA-15841
URL: https://issues.apache.org/jira/browse/CASSANDRA-15841
Project: Cassandra
Issue Type: Bug
Components: Test/unit
Reporter: Berenguer Blasi
Failing for the past [29
buils|https://ci-cassandra.apache.org/job/Cassandra-trunk/154/testReport/junit.framework/TestSuite/org_apache_cassandra_io_sstable_CQLSSTableWriterTest_cdc/]
{{java.lang.NullPointerException
at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312)
at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89)
at
org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413)
at
org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467)
at
org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785)
at
org.apache.cassandra.io.sstable.CQLSSTableWriterTest.setup(CQLSSTableWriterTest.java:62)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
