[jira] [Commented] (CASSANDRA-16670) Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest

2021-06-02 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356154#comment-17356154
 ] 

Berenguer Blasi commented on CASSANDRA-16670:
-

ViewComplexTest seems to be the only split that timeouts out sometimes, so I 
almost go it right. It might need another split #justfyi

> Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest
> 
>
> Key: CASSANDRA-16670
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16670
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> *ViewComplexTest*
> Flaky 
> [test|https://ci-cassandra.apache.org/job/Cassandra-4.0/43/testReport/junit/org.apache.cassandra.cql3/ViewComplexTest/testPartialDeleteSelectedColumnWithoutFlush_3_/]
>  and move back away from 'long' section.
> *InsertUpdateIfConditionTest* (CASSANDRA-16676)
> Fails 
> [here|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/testListItem_2__clusterMinVersion_4_0_0_rc2_SNAPSHOT_/]
>  with a timeout. We can see in the history it takes quite a while in 
> [CI|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/history/]
>  _but_ it takes just 1m locally. Probably due to constrained resources. 
> Looking at the 
> [individual|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/]
>  test cases, for compression i.e., we can see 378 at an average of 1s each it 
> can easily go over the timeout of 240s. Recommendation is to either move to 
> 'long' section of to raise the timeout for the class for CI.
> *ViewFilteringTest*
> Move back from 'long' section



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-16707:

Status: Ready to Commit  (was: Review In Progress)

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping

2021-06-02 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-16708:

Fix Version/s: 4.0.x
   4.0
   4.0-rc2

> Fix 
> org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
> ---
>
> Key: CASSANDRA-16708
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16708
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping

2021-06-02 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-16708:

 Bug Category: Parent values: Correctness(12982)
   Complexity: Low Hanging Fruit
  Component/s: Test/unit
Discovered By: Unit Test
 Severity: Low
   Status: Open  (was: Triage Needed)

> Fix 
> org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
> ---
>
> Key: CASSANDRA-16708
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16708
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
>
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-16708) Fix org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping

2021-06-02 Thread Ekaterina Dimitrova (Jira)
Ekaterina Dimitrova created CASSANDRA-16708:
---

 Summary: Fix 
org.apache.cassandra.tools.nodetool.StatusTest.testOutputWhileBootstrapping
 Key: CASSANDRA-16708
 URL: https://issues.apache.org/jira/browse/CASSANDRA-16708
 Project: Cassandra
  Issue Type: Bug
Reporter: Ekaterina Dimitrova
Assignee: Ekaterina Dimitrova


[https://jenkins-cm4.apache.org/job/Cassandra-4.0/71/testReport/junit/org.apache.cassandra.tools.nodetool/StatusTest/testOutputWhileBootstrapping_cdc/]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Assigned] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe reassigned CASSANDRA-16707:
---

Assignee: Caleb Rackliffe

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-16707:

Reviewers: Brandon Williams, Yifan Cai  (was: Brandon Williams, Caleb 
Rackliffe, Yifan Cai)

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-16707:

Reviewers: Brandon Williams, Yifan Cai, Caleb Rackliffe  (was: Brandon 
Williams, Caleb Rackliffe, Yifan Cai)
   Brandon Williams, Yifan Cai, Caleb Rackliffe  (was: Brandon 
Williams, Yifan Cai)
   Status: Review In Progress  (was: Patch Available)

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Yifan Cai (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355943#comment-17355943
 ] 

Yifan Cai commented on CASSANDRA-16707:
---

+1 on the patch.

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Yifan Cai (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355942#comment-17355942
 ] 

Yifan Cai commented on CASSANDRA-16707:
---

I think we also need to synchronize the implementation in the JmxTimer.

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-16707:

Reviewers: Brandon Williams, Yifan Cai  (was: Brandon Williams)

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-16707:

Test and Documentation Plan: n/a
 Status: Patch Available  (was: In Progress)

[patch|https://github.com/apache/cassandra/pull/1035], 
[j8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/248/workflows/e3aa2faf-e8c9-415e-9bbc-d6bab47a7123],
 
[j11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/248/workflows/117c61b9-165c-4006-a2fd-6c220d6460d2]

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-16707:

Reviewers: Brandon Williams

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355911#comment-17355911
 ] 

Brandon Williams commented on CASSANDRA-16707:
--

+1 if you just want to ninja a synchronize in there.

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-16707:

 Bug Category: Parent values: Correctness(12982)Level 1 values: Transient 
Incorrect Response(12987)
   Complexity: Low Hanging Fruit
Discovered By: Code Inspection
Fix Version/s: 4.x
   4.0.x
 Severity: Low
   Status: Open  (was: Triage Needed)

> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This 
> isn’t a hot path, and there is a multi-part calculation based on it in 
> {{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe

2021-06-02 Thread Caleb Rackliffe (Jira)
Caleb Rackliffe created CASSANDRA-16707:
---

 Summary: JmxHistogram#getRecentValues() is not thread-safe
 Key: CASSANDRA-16707
 URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
 Project: Cassandra
  Issue Type: Bug
  Components: Observability/JMX
Reporter: Caleb Rackliffe


Published {{JmxHistogram}} instances do not protect their “last” field. This 
isn’t a hot path, and there is a multi-part calculation based on it in 
{{getRecentValues()}}, so we should probably just synchronize that method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site

2021-06-02 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-16706:

Fix Version/s: 4.0-rc

> Bring the latest in-tree docs updates to the web site
> -
>
> Key: CASSANDRA-16706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16706
> Project: Cassandra
>  Issue Type: Task
>  Components: Legacy/Documentation and Website
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0-rc
>
>
> Below two doc changes have to be published on the web site: 
>  * 
> [https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7]
>  * CASSANDRA-16682



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16381) nodetool removenode error “Conflicting replica added”

2021-06-02 Thread Caleb Rackliffe (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355900#comment-17355900
 ] 

Caleb Rackliffe commented on CASSANDRA-16381:
-

bq. A simple fix is to change the behaviour of RangesAtEndpoint.add(..) from 
Conflict.NONE to Conflict.DUPLICATE, but I'm not too sure if that is safe…

Did we ever figure out what about CASSANDRA-14404 started generating duplicates?

> nodetool removenode error “Conflicting replica added”
> -
>
> Key: CASSANDRA-16381
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16381
> Project: Cassandra
>  Issue Type: Bug
>  Components: Consistency/Bootstrap and Decommission
>Reporter: vincent royer
>Assignee: Michael Semb Wever
>Priority: Urgent
> Fix For: 4.0, 4.0-rc1
>
> Attachments: dtest.tar.bz2, node1.tar.bz2, node2.tar.bz2, 
> node3.tar.bz2
>
>
> When testing elassandra on C* 4.0, integration tests with ccm systematically 
> failed on removing a node with the following error “Conflicting replica 
> added” . [This integration test 
> |https://github.com/strapdata/elassandra/blob/v6.8.4-strapdata/integ-test/test-cleanup-repair.sh#L289]
>  was ok with Elassandra based on Cassandra 3.11, and there is no changes in 
> that test. Moreover, it seems there is no cassandra-test (dtest) for removing 
> a node (there is only one removenode test for transient replication). The 
> topology_test.py remove a node from the CCM cluster, but it does not call 
> nodetool removenode.
> I wonder if we have a non-tested regression here in C 4.0 ?
> {noformat}
> ++ ccm node1 nodetool status
> ++ awk ‘/127.0.0.3/ \{ print $7 }’
> + HOST_ID3=6d2e858f-dacc-4c7c-a626-14b45f6b3b94
> + ccm node3 stop
> + ccm node1 nodetool removenode 6d2e858f-dacc-4c7c-a626-14b45f6b3b94
> Traceback (most recent call last):
>   File “/usr/local/bin/ccm”, line 4, in 
> __import__(‘pkg_resources’).run_script(‘ccm==3.1.6’, ‘ccm’)
>   File 
> “/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/__init__.py”,
>  line 742, in run_script
> self.require(requires)[0].run_script(script_name, ns)
>   File 
> “/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/__init__.py”,
>  line 1674, in run_script
> exec(script_code, namespace, namespace)
>   File 
> “/Library/Python/2.7/site-packages/ccm-3.1.6-py2.7.egg/EGG-INFO/scripts/ccm”, 
> line 112, in   File 
> “build/bdist.macosx-10.14-intel/egg/ccmlib/cmds/node_cmds.py”, line 233, in 
> run
>   File “build/bdist.macosx-10.14-intel/egg/ccmlib/node.py”, line 848, in 
> nodetool
>   File “build/bdist.macosx-10.14-intel/egg/ccmlib/node.py”, line 2131, in 
> handle_external_tool_process
> ccmlib.node.ToolError: Subprocess [‘nodetool’, ‘-h’, ‘localhost’, ‘-p’, 
> ‘7100’, ‘removenode’, ‘6d2e858f-dacc-4c7c-a626-14b45f6b3b94’] exited with 
> non-zero status; exit status: 1;
> stdout: nodetool: Conflicting replica added (expected unique ranges): 
> Full(/127.0.0.1:7000,(4949329179655327935,6135417578204142297]); existing: 
> Full(/127.0.0.1:7000,(4949329179655327935,6135417578204142297])
> See ‘nodetool help’ or ‘nodetool help ’.++ finish
> ++ echo ‘ERROR occurs, test failed’
> ERROR occurs, test failed
> ++ ‘[’ ‘!’ -z ‘’ ‘]’
> ++ exit 1
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-16381) nodetool removenode error “Conflicting replica added”

2021-06-02 Thread Caleb Rackliffe (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355900#comment-17355900
 ] 

Caleb Rackliffe edited comment on CASSANDRA-16381 at 6/2/21, 6:11 PM:
--

bq. A simple fix is to change the behaviour of RangesAtEndpoint.add(..) from 
Conflict.NONE to Conflict.DUPLICATE, but I'm not too sure if that is safe…

Did we ever figure out what about CASSANDRA-14404 started generating duplicates?

(Aside: I'm guessing this is one of the things we would have discovered in 
CASSANDRA-14669...)


was (Author: maedhroz):
bq. A simple fix is to change the behaviour of RangesAtEndpoint.add(..) from 
Conflict.NONE to Conflict.DUPLICATE, but I'm not too sure if that is safe…

Did we ever figure out what about CASSANDRA-14404 started generating duplicates?

> nodetool removenode error “Conflicting replica added”
> -
>
> Key: CASSANDRA-16381
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16381
> Project: Cassandra
>  Issue Type: Bug
>  Components: Consistency/Bootstrap and Decommission
>Reporter: vincent royer
>Assignee: Michael Semb Wever
>Priority: Urgent
> Fix For: 4.0, 4.0-rc1
>
> Attachments: dtest.tar.bz2, node1.tar.bz2, node2.tar.bz2, 
> node3.tar.bz2
>
>
> When testing elassandra on C* 4.0, integration tests with ccm systematically 
> failed on removing a node with the following error “Conflicting replica 
> added” . [This integration test 
> |https://github.com/strapdata/elassandra/blob/v6.8.4-strapdata/integ-test/test-cleanup-repair.sh#L289]
>  was ok with Elassandra based on Cassandra 3.11, and there is no changes in 
> that test. Moreover, it seems there is no cassandra-test (dtest) for removing 
> a node (there is only one removenode test for transient replication). The 
> topology_test.py remove a node from the CCM cluster, but it does not call 
> nodetool removenode.
> I wonder if we have a non-tested regression here in C 4.0 ?
> {noformat}
> ++ ccm node1 nodetool status
> ++ awk ‘/127.0.0.3/ \{ print $7 }’
> + HOST_ID3=6d2e858f-dacc-4c7c-a626-14b45f6b3b94
> + ccm node3 stop
> + ccm node1 nodetool removenode 6d2e858f-dacc-4c7c-a626-14b45f6b3b94
> Traceback (most recent call last):
>   File “/usr/local/bin/ccm”, line 4, in 
> __import__(‘pkg_resources’).run_script(‘ccm==3.1.6’, ‘ccm’)
>   File 
> “/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/__init__.py”,
>  line 742, in run_script
> self.require(requires)[0].run_script(script_name, ns)
>   File 
> “/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources/__init__.py”,
>  line 1674, in run_script
> exec(script_code, namespace, namespace)
>   File 
> “/Library/Python/2.7/site-packages/ccm-3.1.6-py2.7.egg/EGG-INFO/scripts/ccm”, 
> line 112, in   File 
> “build/bdist.macosx-10.14-intel/egg/ccmlib/cmds/node_cmds.py”, line 233, in 
> run
>   File “build/bdist.macosx-10.14-intel/egg/ccmlib/node.py”, line 848, in 
> nodetool
>   File “build/bdist.macosx-10.14-intel/egg/ccmlib/node.py”, line 2131, in 
> handle_external_tool_process
> ccmlib.node.ToolError: Subprocess [‘nodetool’, ‘-h’, ‘localhost’, ‘-p’, 
> ‘7100’, ‘removenode’, ‘6d2e858f-dacc-4c7c-a626-14b45f6b3b94’] exited with 
> non-zero status; exit status: 1;
> stdout: nodetool: Conflicting replica added (expected unique ranges): 
> Full(/127.0.0.1:7000,(4949329179655327935,6135417578204142297]); existing: 
> Full(/127.0.0.1:7000,(4949329179655327935,6135417578204142297])
> See ‘nodetool help’ or ‘nodetool help ’.++ finish
> ++ echo ‘ERROR occurs, test failed’
> ERROR occurs, test failed
> ++ ‘[’ ‘!’ -z ‘’ ‘]’
> ++ exit 1
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site

2021-06-02 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-16706:

Test and Documentation Plan: 
https://issues.apache.org/jira/browse/CASSANDRA-16706?filter=-1#

 

Only staging is prepared at the moment, as soon as it is approved and looks 
fine, the asf-site will also be committed
 Status: Patch Available  (was: In Progress)

> Bring the latest in-tree docs updates to the web site
> -
>
> Key: CASSANDRA-16706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16706
> Project: Cassandra
>  Issue Type: Task
>  Components: Legacy/Documentation and Website
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2
>
>
> Below two doc changes have to be published on the web site: 
>  * 
> [https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7]
>  * CASSANDRA-16682



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site

2021-06-02 Thread Ekaterina Dimitrova (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355866#comment-17355866
 ] 

Ekaterina Dimitrova commented on CASSANDRA-16706:
-

I haven't updated the web site before and we are in transition to a new web 
site so I would like to thank [~mck] for guiding me. The readme is not up to 
date now while the transition to the new web site and antora is still ongoing.

As part of this ticket I will also sync the branches asf-site and   
asf-staging. The latest commit in asf-staging had conflicts for all files with 
the respective commit (but with different sha) in asf-site so I just got in 
favor the one in asf-site. The rest of the commits were cherry-picked and I 
added the newly generated docs

PR available [here|https://github.com/apache/cassandra-website/pull/59]

[~mck] do you mind to review when you have a bit of time, please?

> Bring the latest in-tree docs updates to the web site
> -
>
> Key: CASSANDRA-16706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16706
> Project: Cassandra
>  Issue Type: Task
>  Components: Legacy/Documentation and Website
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2
>
>
> Below two doc changes have to be published on the web site: 
>  * 
> [https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7]
>  * CASSANDRA-16682



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-16702) Latest 3.x Cassandra (3.11.10) fails to start after updating corretto jdk from 8.252 to 8.292

2021-06-02 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355192#comment-17355192
 ] 

Brandon Williams edited comment on CASSANDRA-16702 at 6/2/21, 4:53 PM:
---

||Branch||CI||Circle||
|[cassandra-3.0|https://github.com/driftx/cassandra/tree/CASSANDRA-16702]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/829/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/829/pipeline]|[3.0|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-16702]
|[cassandra-3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-16702-3.11]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/830/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/830/pipeline]|[3.11|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-16702-3.11]
|[cassandra-4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-16702-4.0]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/831/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/831/pipeline]|[4.0|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-16702-4.0]
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-16702-trunk]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/832/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/832/pipeline]|[trunk|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-16702-trunk]



was (Author: brandon.williams):

||Branch||CI||
|[cassandra-3.0|https://github.com/driftx/cassandra/tree/CASSANDRA-16703]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/829/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/829/pipeline]|
|[cassandra-3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-16703-3.11]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/830/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/830/pipeline]|
|[cassandra-4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-16703-4.0]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/831/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/831/pipeline]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-16703-trunk]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/832/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/832/pipeline]|


> Latest 3.x Cassandra (3.11.10) fails to start after updating corretto jdk 
> from 8.252 to 8.292
> -
>
> Key: CASSANDRA-16702
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16702
> Project: Cassandra
>  Issue Type: Bug
>  Components: Dependencies
>Reporter: Alexey Barsov
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> Cassandra fails to start with the following exception
> {code:java}
> [2021-05-22 03:19:04,790] [Apache Cassandra Error] 
> java.lang.UnsatisfiedLinkError: 
> C:\Users\alexey.barsov\AppData\Local\Temp\jna--1630081341\jna2627169091367567840.dll:
>  Can't find dependent libraries
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> java.lang.ClassLoader$NativeLibrary.load(Native Method)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> java.lang.ClassLoader.loadLibrary(ClassLoader.java:1817)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> java.lang.Runtime.load0(Runtime.java:810)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> java.lang.System.load(System.java:1088)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> com.sun.jna.Native.loadNativeDispatchLibraryFromClasspath(Native.java:851)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> com.sun.jna.Native.loadNativeDispatchLibrary(Native.java:826)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> com.sun.jna.Native.(Native.java:140)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> org.apache.cassandra.utils.WindowsTimer.(WindowsTimer.java:35)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:630)
>  [2021-05-22 03:19:04,790] [Apache Cassandra Error] at 
> 

[jira] [Commented] (CASSANDRA-16689) Flaky LeaveAndBootstrapTest

2021-06-02 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355800#comment-17355800
 ] 

Brandon Williams commented on CASSANDRA-16689:
--

This is rather odd since this occurs in Util.createInitialRing, where it does 
not appear to be used incorrectly, so I would expect this to be more widespread 
given the use of this function in about 8 other tests.  I have not been able to 
reproduce myself and the multiplexer has been no help there either: 
https://app.circleci.com/pipelines/github/driftx/cassandra/141/workflows/5b322f7d-32ce-41ec-88cb-7af1236af133/jobs/1099/steps

> Flaky LeaveAndBootstrapTest
> ---
>
> Key: CASSANDRA-16689
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16689
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> Failing in a circle run 
> [here|https://app.circleci.com/pipelines/github/bereng/cassandra/309/workflows/a645b956-dcd7-431e-b109-7857af3c523f/jobs/2937]
> {noformat}
> Testcase: 
> testStateJumpToNormal(org.apache.cassandra.service.LeaveAndBootstrapTest):  
> Caused an ERROR
> [junit-timeout] null
> [junit-timeout] java.lang.NullPointerException
> [junit-timeout]   at 
> org.apache.cassandra.service.StorageService.updatePeerInfo(StorageService.java:2418)
> [junit-timeout]   at 
> org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2756)
> [junit-timeout]   at 
> org.apache.cassandra.service.StorageService.onChange(StorageService.java:2299)
> [junit-timeout]   at 
> org.apache.cassandra.Util.createInitialRing(Util.java:236)
> [junit-timeout]   at 
> org.apache.cassandra.service.LeaveAndBootstrapTest.testStateJumpToNormal(LeaveAndBootstrapTest.java:550)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site

2021-06-02 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-16706:

Change Category: Semantic
 Complexity: Low Hanging Fruit
Component/s: Legacy/Documentation and Website
  Fix Version/s: 4.0-rc2
 Status: Open  (was: Triage Needed)

> Bring the latest in-tree docs updates to the web site
> -
>
> Key: CASSANDRA-16706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16706
> Project: Cassandra
>  Issue Type: Task
>  Components: Legacy/Documentation and Website
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2
>
>
> Below two doc changes have to be published on the web site: 
>  * 
> [https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7]
>  * CASSANDRA-16682



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-16706) Bring the latest in-tree docs updates to the web site

2021-06-02 Thread Ekaterina Dimitrova (Jira)
Ekaterina Dimitrova created CASSANDRA-16706:
---

 Summary: Bring the latest in-tree docs updates to the web site
 Key: CASSANDRA-16706
 URL: https://issues.apache.org/jira/browse/CASSANDRA-16706
 Project: Cassandra
  Issue Type: Task
Reporter: Ekaterina Dimitrova
Assignee: Ekaterina Dimitrova


Below two doc changes have to be published on the web site: 
 * 
[https://github.com/apache/cassandra/commit/55b4b8dd3bae0004d3128a7f9fe8474526f608c7]
 * CASSANDRA-16682



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies

2021-06-02 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355795#comment-17355795
 ] 

Brandon Williams commented on CASSANDRA-16704:
--

LGTM, [~mck] can you take a look as well?

> Fix imports; run tests with packaged dependencies
> -
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build, Test/burn, Test/unit
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
> Fix For: 4.0.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars. 
> The tests would be more reflective of the behavior of a runtime environment 
> if the test classpath only contained jars that are bundled with the binary 
> release, together with explicit test dependencies. Ideally we'd use the 
> build/lib/ jars for the classpath since that's what gets packaged, but since 
> these aren't available at test compile time and should be identical to lib/ 
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to 
> "org.apache.commons.lang", which is not available at runtime (should be 
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both 
> test/ and src/ classes, and makes some simple substitutions in the tests such 
> as using AbstractMap.SimpleEntry in place of 
> org.apache.commons.collections.keyvalue.AbstractMapEntry.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies

2021-06-02 Thread Brandon Williams (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-16704:
-
Test and Documentation Plan: run ci
 Status: Patch Available  (was: Open)

> Fix imports; run tests with packaged dependencies
> -
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build, Test/burn, Test/unit
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
> Fix For: 4.0.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars. 
> The tests would be more reflective of the behavior of a runtime environment 
> if the test classpath only contained jars that are bundled with the binary 
> release, together with explicit test dependencies. Ideally we'd use the 
> build/lib/ jars for the classpath since that's what gets packaged, but since 
> these aren't available at test compile time and should be identical to lib/ 
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to 
> "org.apache.commons.lang", which is not available at runtime (should be 
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both 
> test/ and src/ classes, and makes some simple substitutions in the tests such 
> as using AbstractMap.SimpleEntry in place of 
> org.apache.commons.collections.keyvalue.AbstractMapEntry.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies

2021-06-02 Thread Brandon Williams (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-16704:
-
Fix Version/s: 4.0.x

> Fix imports; run tests with packaged dependencies
> -
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build, Test/burn, Test/unit
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
> Fix For: 4.0.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars. 
> The tests would be more reflective of the behavior of a runtime environment 
> if the test classpath only contained jars that are bundled with the binary 
> release, together with explicit test dependencies. Ideally we'd use the 
> build/lib/ jars for the classpath since that's what gets packaged, but since 
> these aren't available at test compile time and should be identical to lib/ 
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to 
> "org.apache.commons.lang", which is not available at runtime (should be 
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both 
> test/ and src/ classes, and makes some simple substitutions in the tests such 
> as using AbstractMap.SimpleEntry in place of 
> org.apache.commons.collections.keyvalue.AbstractMapEntry.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16686) Queries returning static content when the partition has no rows might fail to return some rows

2021-06-02 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andres de la Peña updated CASSANDRA-16686:
--
Reviewers: Andres de la Peña, Jacek Lewandowski, Andres de la Peña  (was: 
Andres de la Peña, Jacek Lewandowski)
   Andres de la Peña, Jacek Lewandowski, Andres de la Peña  (was: 
Andres de la Peña, Jacek Lewandowski)
   Status: Review In Progress  (was: Patch Available)

> Queries returning static content when the partition has no rows might fail to 
> return some rows
> --
>
> Key: CASSANDRA-16686
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16686
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-rc
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> The problem can be reproduced with the following test:
> {code}
> @Test
> public void testStaticColumnDeletionWithMultipleStaticColumns() throws 
> Throwable
> {
> createTable("CREATE TABLE %s (pk int, ck int, s1 int static, s2 int 
> static, v int, PRIMARY KEY(pk, ck))");
> execute("INSERT INTO %s (pk, s1, s2) VALUES (1, 1, 1) USING TIMESTAMP 
> 1000");
> flush();
> execute("INSERT INTO %s (pk, s1) VALUES (1, 2) USING TIMESTAMP 2000");
> flush();
> execute("DELETE s1 FROM %s USING TIMESTAMP 3000 WHERE pk = 1");
> flush();
> assertRows(execute("SELECT * FROM %s WHERE pk=1"), row(1, null, null, 
> 1, null));
> assertRows(execute("SELECT s1, s2 FROM %s WHERE pk=1"), row((Integer) 
> null, 1));
> assertRows(execute("SELECT s1 FROM %s WHERE pk=1"), row((Integer) 
> null)); // <-FAIL
> }
> {code}
> This problem is a regression in 4.0 and trunk



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16637) LongLeveledCompactionStrategyCQLTest.stressTestCompactionStrategyManager fails

2021-06-02 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355578#comment-17355578
 ] 

Berenguer Blasi commented on CASSANDRA-16637:
-

That was fast! thx :-)

> LongLeveledCompactionStrategyCQLTest.stressTestCompactionStrategyManager fails
> --
>
> Key: CASSANDRA-16637
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16637
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Compaction/LCS
>Reporter: Adam Holmberg
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0.x
>
>
> Test is failing occasionally as follows:
> {noformat}
> Caused by: java.lang.AssertionError: Got unexpected overlap in level 3
>   at 
> org.apache.cassandra.db.compaction.LeveledGenerations.addAll(LeveledGenerations.java:161)
>   at 
> org.apache.cassandra.db.compaction.LeveledManifest.addSSTables(LeveledManifest.java:131)
>   at 
> org.apache.cassandra.db.compaction.LeveledCompactionStrategy.addSSTable(LeveledCompactionStrategy.java:365)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.startup(CompactionStrategyManager.java:312)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.reload(CompactionStrategyManager.java:532)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.maybeReloadDiskBoundaries(CompactionStrategyManager.java:495)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.handleNotification(CompactionStrategyManager.java:743)
>   at org.apache.cassandra.db.lifecycle.Tracker.notify(Tracker.java:508)
>   at 
> org.apache.cassandra.db.lifecycle.Tracker.notifyDiscarded(Tracker.java:502)
>   at 
> org.apache.cassandra.db.lifecycle.Tracker.replaceFlushed(Tracker.java:373)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.replaceFlushed(ColumnFamilyStore.java:1592)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore$Flush.flushMemtable(ColumnFamilyStore.java:1194)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1075)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at 
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {noformat}
> [Recent 
> ci|https://ci-cassandra.apache.org/job/Cassandra-trunk/476/testReport/junit/org.apache.cassandra.db.compaction/LongLeveledCompactionStrategyCQLTest/stressTestCompactionStrategyManager/]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16637) LongLeveledCompactionStrategyCQLTest.stressTestCompactionStrategyManager fails

2021-06-02 Thread Marcus Eriksson (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355569#comment-17355569
 ] 

Marcus Eriksson commented on CASSANDRA-16637:
-

https://github.com/apache/cassandra/commit/aef535cae16986c10f635e71dcbcf0759310ac29
 to 4.0 and merged up

> LongLeveledCompactionStrategyCQLTest.stressTestCompactionStrategyManager fails
> --
>
> Key: CASSANDRA-16637
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16637
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Compaction/LCS
>Reporter: Adam Holmberg
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0.x
>
>
> Test is failing occasionally as follows:
> {noformat}
> Caused by: java.lang.AssertionError: Got unexpected overlap in level 3
>   at 
> org.apache.cassandra.db.compaction.LeveledGenerations.addAll(LeveledGenerations.java:161)
>   at 
> org.apache.cassandra.db.compaction.LeveledManifest.addSSTables(LeveledManifest.java:131)
>   at 
> org.apache.cassandra.db.compaction.LeveledCompactionStrategy.addSSTable(LeveledCompactionStrategy.java:365)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.startup(CompactionStrategyManager.java:312)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.reload(CompactionStrategyManager.java:532)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.maybeReloadDiskBoundaries(CompactionStrategyManager.java:495)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.handleNotification(CompactionStrategyManager.java:743)
>   at org.apache.cassandra.db.lifecycle.Tracker.notify(Tracker.java:508)
>   at 
> org.apache.cassandra.db.lifecycle.Tracker.notifyDiscarded(Tracker.java:502)
>   at 
> org.apache.cassandra.db.lifecycle.Tracker.replaceFlushed(Tracker.java:373)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.replaceFlushed(ColumnFamilyStore.java:1592)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore$Flush.flushMemtable(ColumnFamilyStore.java:1194)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1075)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at 
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {noformat}
> [Recent 
> ci|https://ci-cassandra.apache.org/job/Cassandra-trunk/476/testReport/junit/org.apache.cassandra.db.compaction/LongLeveledCompactionStrategyCQLTest/stressTestCompactionStrategyManager/]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch trunk updated (2316a9b -> bedf6ca)

2021-06-02 Thread marcuse
This is an automated email from the ASF dual-hosted git repository.

marcuse pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git.


from 2316a9b  Merge branch 'cassandra-4.0' into trunk
 new aef535c  Temporarily remove overlap check in tests
 new bedf6ca  Merge branch 'cassandra-4.0' into trunk

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/java/org/apache/cassandra/db/compaction/LeveledGenerations.java | 2 --
 1 file changed, 2 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk

2021-06-02 Thread marcuse
This is an automated email from the ASF dual-hosted git repository.

marcuse pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git

commit bedf6ca998744207bc0ded4fc3a2b80e0e1e8b86
Merge: 2316a9b aef535c
Author: Marcus Eriksson 
AuthorDate: Wed Jun 2 10:27:33 2021 +0200

Merge branch 'cassandra-4.0' into trunk

 src/java/org/apache/cassandra/db/compaction/LeveledGenerations.java | 2 --
 1 file changed, 2 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch cassandra-4.0 updated: Temporarily remove overlap check in tests

2021-06-02 Thread marcuse
This is an automated email from the ASF dual-hosted git repository.

marcuse pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
 new aef535c  Temporarily remove overlap check in tests
aef535c is described below

commit aef535cae16986c10f635e71dcbcf0759310ac29
Author: Marcus Eriksson 
AuthorDate: Wed May 19 11:56:12 2021 +0200

Temporarily remove overlap check in tests

Patch by marcuse; reviewed by Berenguer Blasi and Ekaterina Dimitrova for 
CASSANDRA-16637
---
 src/java/org/apache/cassandra/db/compaction/LeveledGenerations.java | 2 --
 1 file changed, 2 deletions(-)

diff --git 
a/src/java/org/apache/cassandra/db/compaction/LeveledGenerations.java 
b/src/java/org/apache/cassandra/db/compaction/LeveledGenerations.java
index d160eed..64027f2 100644
--- a/src/java/org/apache/cassandra/db/compaction/LeveledGenerations.java
+++ b/src/java/org/apache/cassandra/db/compaction/LeveledGenerations.java
@@ -155,8 +155,6 @@ class LeveledGenerations
 if (before != null && before.last.compareTo(sstable.first) >= 0 ||
 after != null && after.first.compareTo(sstable.last) <= 0)
 {
-if (strictLCSChecksTest) // we can only assert this in tests 
since this is normal when for example moving sstables from unrepaired to 
repaired
-throw new AssertionError("Got unexpected overlap in level 
"+sstable.getSSTableLevel());
 sendToL0(sstable);
 }
 else

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16637) LongLeveledCompactionStrategyCQLTest.stressTestCompactionStrategyManager fails

2021-06-02 Thread Marcus Eriksson (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355566#comment-17355566
 ] 

Marcus Eriksson commented on CASSANDRA-16637:
-

right, I'll commit

> LongLeveledCompactionStrategyCQLTest.stressTestCompactionStrategyManager fails
> --
>
> Key: CASSANDRA-16637
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16637
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Compaction/LCS
>Reporter: Adam Holmberg
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0.x
>
>
> Test is failing occasionally as follows:
> {noformat}
> Caused by: java.lang.AssertionError: Got unexpected overlap in level 3
>   at 
> org.apache.cassandra.db.compaction.LeveledGenerations.addAll(LeveledGenerations.java:161)
>   at 
> org.apache.cassandra.db.compaction.LeveledManifest.addSSTables(LeveledManifest.java:131)
>   at 
> org.apache.cassandra.db.compaction.LeveledCompactionStrategy.addSSTable(LeveledCompactionStrategy.java:365)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.startup(CompactionStrategyManager.java:312)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.reload(CompactionStrategyManager.java:532)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.maybeReloadDiskBoundaries(CompactionStrategyManager.java:495)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.handleNotification(CompactionStrategyManager.java:743)
>   at org.apache.cassandra.db.lifecycle.Tracker.notify(Tracker.java:508)
>   at 
> org.apache.cassandra.db.lifecycle.Tracker.notifyDiscarded(Tracker.java:502)
>   at 
> org.apache.cassandra.db.lifecycle.Tracker.replaceFlushed(Tracker.java:373)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.replaceFlushed(ColumnFamilyStore.java:1592)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore$Flush.flushMemtable(ColumnFamilyStore.java:1194)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1075)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at 
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {noformat}
> [Recent 
> ci|https://ci-cassandra.apache.org/job/Cassandra-trunk/476/testReport/junit/org.apache.cassandra.db.compaction/LongLeveledCompactionStrategyCQLTest/stressTestCompactionStrategyManager/]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16637) LongLeveledCompactionStrategyCQLTest.stressTestCompactionStrategyManager fails

2021-06-02 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1736#comment-1736
 ] 

Berenguer Blasi commented on CASSANDRA-16637:
-

This is still [coming 
up|https://ci-cassandra.apache.org/job/Cassandra-4.0/70/testReport/junit/org.apache.cassandra.db.compaction/LongLeveledCompactionStrategyCQLTest/stressTestCompactionStrategyManager/]
 in 4.0 CI

Didn't we settle we'd at least merge that check removal to get a clean CI in 
4.0? #collaborating

> LongLeveledCompactionStrategyCQLTest.stressTestCompactionStrategyManager fails
> --
>
> Key: CASSANDRA-16637
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16637
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Compaction/LCS
>Reporter: Adam Holmberg
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0.x
>
>
> Test is failing occasionally as follows:
> {noformat}
> Caused by: java.lang.AssertionError: Got unexpected overlap in level 3
>   at 
> org.apache.cassandra.db.compaction.LeveledGenerations.addAll(LeveledGenerations.java:161)
>   at 
> org.apache.cassandra.db.compaction.LeveledManifest.addSSTables(LeveledManifest.java:131)
>   at 
> org.apache.cassandra.db.compaction.LeveledCompactionStrategy.addSSTable(LeveledCompactionStrategy.java:365)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.startup(CompactionStrategyManager.java:312)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.reload(CompactionStrategyManager.java:532)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.maybeReloadDiskBoundaries(CompactionStrategyManager.java:495)
>   at 
> org.apache.cassandra.db.compaction.CompactionStrategyManager.handleNotification(CompactionStrategyManager.java:743)
>   at org.apache.cassandra.db.lifecycle.Tracker.notify(Tracker.java:508)
>   at 
> org.apache.cassandra.db.lifecycle.Tracker.notifyDiscarded(Tracker.java:502)
>   at 
> org.apache.cassandra.db.lifecycle.Tracker.replaceFlushed(Tracker.java:373)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore.replaceFlushed(ColumnFamilyStore.java:1592)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore$Flush.flushMemtable(ColumnFamilyStore.java:1194)
>   at 
> org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1075)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at 
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> {noformat}
> [Recent 
> ci|https://ci-cassandra.apache.org/job/Cassandra-trunk/476/testReport/junit/org.apache.cassandra.db.compaction/LongLeveledCompactionStrategyCQLTest/stressTestCompactionStrategyManager/]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16670) Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest

2021-06-02 Thread Berenguer Blasi (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Berenguer Blasi updated CASSANDRA-16670:

  Since Version: 4.0
Source Control Link: 
https://github.com/apache/cassandra/commit/6ad259238d82d7fe752eff6373d55bd225d8c630
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

> Flaky ViewComplexTest, ViewFilteringTest and InsertUpdateIfConditionTest
> 
>
> Key: CASSANDRA-16670
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16670
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.x
>
>
> *ViewComplexTest*
> Flaky 
> [test|https://ci-cassandra.apache.org/job/Cassandra-4.0/43/testReport/junit/org.apache.cassandra.cql3/ViewComplexTest/testPartialDeleteSelectedColumnWithoutFlush_3_/]
>  and move back away from 'long' section.
> *InsertUpdateIfConditionTest* (CASSANDRA-16676)
> Fails 
> [here|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/testListItem_2__clusterMinVersion_4_0_0_rc2_SNAPSHOT_/]
>  with a timeout. We can see in the history it takes quite a while in 
> [CI|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/history/]
>  _but_ it takes just 1m locally. Probably due to constrained resources. 
> Looking at the 
> [individual|https://ci-cassandra.apache.org/job/Cassandra-4.0/46/testReport/junit/org.apache.cassandra.cql3.validation.operations/InsertUpdateIfConditionTest/]
>  test cases, for compression i.e., we can see 378 at an average of 1s each it 
> can easily go over the timeout of 240s. Recommendation is to either move to 
> 'long' section of to raise the timeout for the class for CI.
> *ViewFilteringTest*
> Move back from 'long' section



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch trunk updated (3af9b0a -> 2316a9b)

2021-06-02 Thread bereng
This is an automated email from the ASF dual-hosted git repository.

bereng pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git.


from 3af9b0a  Merge branch 'cassandra-4.0' into trunk
 new 6ad2592  Flaky ViewComplexTest, ViewFilteringTest and 
InsertUpdateIfConditionTest
 new 2316a9b  Merge branch 'cassandra-4.0' into trunk

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/apache/cassandra/cql3/ViewComplexTest.java | 1450 -
 .../apache/cassandra/cql3/ViewFilteringTest.java   | 2167 
 .../cassandra/cql3/ViewComplexDeletionsTest.java   |  501 +
 .../apache/cassandra/cql3/ViewComplexTTLTest.java  |  277 +++
 .../org/apache/cassandra/cql3/ViewComplexTest.java |  609 ++
 .../cassandra/cql3/ViewComplexUpdatesTest.java |  372 
 .../cql3/ViewFilteringClusteringTest.java  |  662 ++
 .../apache/cassandra/cql3/ViewFilteringPKTest.java |  656 ++
 .../apache/cassandra/cql3/ViewFilteringTest.java   | 1044 ++
 .../InsertUpdateIfConditionCollectionsTest.java|  921 +
 .../InsertUpdateIfConditionStaticsTest.java|  379 
 .../operations/InsertUpdateIfConditionTest.java| 1512 +-
 12 files changed, 5433 insertions(+), 5117 deletions(-)
 delete mode 100644 test/long/org/apache/cassandra/cql3/ViewComplexTest.java
 delete mode 100644 test/long/org/apache/cassandra/cql3/ViewFilteringTest.java
 create mode 100644 
test/unit/org/apache/cassandra/cql3/ViewComplexDeletionsTest.java
 create mode 100644 test/unit/org/apache/cassandra/cql3/ViewComplexTTLTest.java
 create mode 100644 test/unit/org/apache/cassandra/cql3/ViewComplexTest.java
 create mode 100644 
test/unit/org/apache/cassandra/cql3/ViewComplexUpdatesTest.java
 create mode 100644 
test/unit/org/apache/cassandra/cql3/ViewFilteringClusteringTest.java
 create mode 100644 test/unit/org/apache/cassandra/cql3/ViewFilteringPKTest.java
 create mode 100644 test/unit/org/apache/cassandra/cql3/ViewFilteringTest.java
 create mode 100644 
test/unit/org/apache/cassandra/cql3/validation/operations/InsertUpdateIfConditionCollectionsTest.java
 create mode 100644 
test/unit/org/apache/cassandra/cql3/validation/operations/InsertUpdateIfConditionStaticsTest.java

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk

2021-06-02 Thread bereng
This is an automated email from the ASF dual-hosted git repository.

bereng pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git

commit 2316a9b7f116546d1c839bdcd77ef2f2c7288e24
Merge: 3af9b0a 6ad2592
Author: Bereng 
AuthorDate: Wed Jun 2 09:33:22 2021 +0200

Merge branch 'cassandra-4.0' into trunk

 .../org/apache/cassandra/cql3/ViewComplexTest.java | 1450 -
 .../apache/cassandra/cql3/ViewFilteringTest.java   | 2167 
 .../cassandra/cql3/ViewComplexDeletionsTest.java   |  501 +
 .../apache/cassandra/cql3/ViewComplexTTLTest.java  |  277 +++
 .../org/apache/cassandra/cql3/ViewComplexTest.java |  609 ++
 .../cassandra/cql3/ViewComplexUpdatesTest.java |  372 
 .../cql3/ViewFilteringClusteringTest.java  |  662 ++
 .../apache/cassandra/cql3/ViewFilteringPKTest.java |  656 ++
 .../apache/cassandra/cql3/ViewFilteringTest.java   | 1044 ++
 .../InsertUpdateIfConditionCollectionsTest.java|  921 +
 .../InsertUpdateIfConditionStaticsTest.java|  379 
 .../operations/InsertUpdateIfConditionTest.java| 1512 +-
 12 files changed, 5433 insertions(+), 5117 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org