[cassandra-website] branch asf-staging updated (e3d94fc2 -> 5d984b10)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard e3d94fc2 generate docs for 5dd84ab2 new 5d984b10 generate docs for 5dd84ab2 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (e3d94fc2) \ N -- N -- N refs/heads/asf-staging (5d984b10) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4970898 -> 4970898 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18200) Cassandra messaging to self changed behavior
[ https://issues.apache.org/jira/browse/CASSANDRA-18200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maciej Sokol updated CASSANDRA-18200: - Attachment: (was: patch) > Cassandra messaging to self changed behavior > > > Key: CASSANDRA-18200 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18200 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Maciej Sokol >Priority: Normal > Attachments: patch.txt > > > During testing of Cassandra on AWS, we noticed some behavior changes between > Cassandra 3.11 and Cassandra 4.0 when it comes to messaging. > When performing a range query with consistency local_quorum, Cassandra sents > a request to itself and some peers. > In case of Cassandra 4.0, it's trying to connect to itself using the > broadcast_address while in Cassandra 3.11 it's connecting using the local > address (see > [https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java#L152]. > This translation seems to be missing in Cassandra 4.X. I think the best place > to fix it would be here (see attached file): > [https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/OutboundConnectionSettings.java#L451] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18200) Cassandra messaging to self changed behavior
[ https://issues.apache.org/jira/browse/CASSANDRA-18200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maciej Sokol updated CASSANDRA-18200: - Attachment: patch.txt > Cassandra messaging to self changed behavior > > > Key: CASSANDRA-18200 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18200 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Maciej Sokol >Priority: Normal > Attachments: patch.txt > > > During testing of Cassandra on AWS, we noticed some behavior changes between > Cassandra 3.11 and Cassandra 4.0 when it comes to messaging. > When performing a range query with consistency local_quorum, Cassandra sents > a request to itself and some peers. > In case of Cassandra 4.0, it's trying to connect to itself using the > broadcast_address while in Cassandra 3.11 it's connecting using the local > address (see > [https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java#L152]. > This translation seems to be missing in Cassandra 4.X. I think the best place > to fix it would be here (see attached file): > [https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/OutboundConnectionSettings.java#L451] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18200) Cassandra messaging to self changed behavior
[ https://issues.apache.org/jira/browse/CASSANDRA-18200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maciej Sokol updated CASSANDRA-18200: - Attachment: patch > Cassandra messaging to self changed behavior > > > Key: CASSANDRA-18200 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18200 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Maciej Sokol >Priority: Normal > Attachments: patch > > > During testing of Cassandra on AWS, we noticed some behavior changes between > Cassandra 3.11 and Cassandra 4.0 when it comes to messaging. > When performing a range query with consistency local_quorum, Cassandra sents > a request to itself and some peers. > In case of Cassandra 4.0, it's trying to connect to itself using the > broadcast_address while in Cassandra 3.11 it's connecting using the local > address (see > [https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java#L152]. > This translation seems to be missing in Cassandra 4.X. I think the best place > to fix it would be here (see attached file): > [https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/OutboundConnectionSettings.java#L451] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18200) Cassandra messaging to self changed behavior
[ https://issues.apache.org/jira/browse/CASSANDRA-18200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maciej Sokol updated CASSANDRA-18200: - Description: During testing of Cassandra on AWS, we noticed some behavior changes between Cassandra 3.11 and Cassandra 4.0 when it comes to messaging. When performing a range query with consistency local_quorum, Cassandra sents a request to itself and some peers. In case of Cassandra 4.0, it's trying to connect to itself using the broadcast_address while in Cassandra 3.11 it's connecting using the local address (see [https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java#L152]. This translation seems to be missing in Cassandra 4.X. I think the best place to fix it would be here (see attached file): [https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/OutboundConnectionSettings.java#L451] was: During testing of Cassandra on AWS, we noticed some behavior changes between Cassandra 3.11 and Cassandra 4.0 when it comes to messaging. When performing a range query with consistency local_quorum, Cassandra sents a request to itself and some peers. In case of Cassandra 4.0, it's trying to connect to itself using the broadcast_address while in Cassandra 3.11 it's connecting using the local address (see https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java#L152. This translation seems to be missing in Cassandra 4.X, i think the best place to fix it would be here: [https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/OutboundConnectionSettings.java#L451] > Cassandra messaging to self changed behavior > > > Key: CASSANDRA-18200 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18200 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Maciej Sokol >Priority: Normal > > During testing of Cassandra on AWS, we noticed some behavior changes between > Cassandra 3.11 and Cassandra 4.0 when it comes to messaging. > When performing a range query with consistency local_quorum, Cassandra sents > a request to itself and some peers. > In case of Cassandra 4.0, it's trying to connect to itself using the > broadcast_address while in Cassandra 3.11 it's connecting using the local > address (see > [https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java#L152]. > This translation seems to be missing in Cassandra 4.X. I think the best place > to fix it would be here (see attached file): > [https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/OutboundConnectionSettings.java#L451] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18200) Cassandra messaging to self changed behavior
Maciej Sokol created CASSANDRA-18200: Summary: Cassandra messaging to self changed behavior Key: CASSANDRA-18200 URL: https://issues.apache.org/jira/browse/CASSANDRA-18200 Project: Cassandra Issue Type: Bug Components: Messaging/Internode Reporter: Maciej Sokol During testing of Cassandra on AWS, we noticed some behavior changes between Cassandra 3.11 and Cassandra 4.0 when it comes to messaging. When performing a range query with consistency local_quorum, Cassandra sents a request to itself and some peers. In case of Cassandra 4.0, it's trying to connect to itself using the broadcast_address while in Cassandra 3.11 it's connecting using the local address (see https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java#L152. This translation seems to be missing in Cassandra 4.X, i think the best place to fix it would be here: [https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/OutboundConnectionSettings.java#L451] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18155) Coordinator level metrics for read response and mutation row and column counts
[
https://issues.apache.org/jira/browse/CASSANDRA-18155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680899#comment-17680899
]
Caleb Rackliffe commented on CASSANDRA-18155:
-
The CircleCI link above should still be valid, but I have to take a quick look
at the last run.
> Coordinator level metrics for read response and mutation row and column counts
> --
>
> Key: CASSANDRA-18155
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18155
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> We propose creating a new metric group, {{ClientRequestSize}}, that will
> house 4 new coordinator-level metrics:
> 1.) ColumnsRead - the total number of columns returned from the database to
> clients
> 2.) RowsRead - the total number of rows returned from the database to clients
> 3.) ColumnsWritten - the total number of columns written to the database by
> clients
> 4.) RowsWritten - the total number of rows written to the database by clients
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14227) Extend maximum expiration date
[
https://issues.apache.org/jira/browse/CASSANDRA-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680895#comment-17680895
]
Berenguer Blasi edited comment on CASSANDRA-14227 at 1/26/23 5:46 AM:
--
Uint POC seems to be OK as well on the latency side. There are latencies on 2
completely different tests with even 2 diff test tooling:
10 averaged runs latency
[^screenshot-3.png]
!screenshot-3.png!
Averaged latency on a 1h test
[^screenshot-4.png]
!screenshot-4.png!
was (Author: bereng):
Uint POC seems to be OK as well on the latency side. There are latencies on 2
completely different tests with even 2 diff test tooling:
10 averaged runs latency
!screenshot-3.png|thumbnail!
Averaged latency on a 1h test
!screenshot-4.png|thumbnail!
> Extend maximum expiration date
> --
>
> Key: CASSANDRA-14227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14227
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Paulo Motta (Deprecated)
>Assignee: Berenguer Blasi
>Priority: Urgent
> Fix For: 4.x
>
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png
>
>
> The maximum expiration timestamp that can be represented by the storage
> engine is
> 2038-01-19T03:14:06+00:00 due to the encoding of {{localExpirationTime}} as
> an int32.
> On CASSANDRA-14092 we added an overflow policy which rejects requests with
> expiration above the maximum date as a temporary measure, but we should
> remove this limitation by updating the storage engine to support at least the
> maximum allowed TTL of 20 years.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14227) Extend maximum expiration date
[
https://issues.apache.org/jira/browse/CASSANDRA-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680895#comment-17680895
]
Berenguer Blasi commented on CASSANDRA-14227:
-
Uint POC seems to be OK as well on the latency side. There are latencies on 2
completely different tests with even 2 diff test tooling:
10 averaged runs latency
!screenshot-3.png|thumbnail!
Averaged latency on a 1h test
!screenshot-4.png|thumbnail!
> Extend maximum expiration date
> --
>
> Key: CASSANDRA-14227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14227
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Paulo Motta (Deprecated)
>Assignee: Berenguer Blasi
>Priority: Urgent
> Fix For: 4.x
>
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png
>
>
> The maximum expiration timestamp that can be represented by the storage
> engine is
> 2038-01-19T03:14:06+00:00 due to the encoding of {{localExpirationTime}} as
> an int32.
> On CASSANDRA-14092 we added an overflow policy which rejects requests with
> expiration above the maximum date as a temporary measure, but we should
> remove this limitation by updating the storage engine to support at least the
> maximum allowed TTL of 20 years.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14227) Extend maximum expiration date
[
https://issues.apache.org/jira/browse/CASSANDRA-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-14227:
Attachment: screenshot-4.png
> Extend maximum expiration date
> --
>
> Key: CASSANDRA-14227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14227
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Paulo Motta (Deprecated)
>Assignee: Berenguer Blasi
>Priority: Urgent
> Fix For: 4.x
>
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png
>
>
> The maximum expiration timestamp that can be represented by the storage
> engine is
> 2038-01-19T03:14:06+00:00 due to the encoding of {{localExpirationTime}} as
> an int32.
> On CASSANDRA-14092 we added an overflow policy which rejects requests with
> expiration above the maximum date as a temporary measure, but we should
> remove this limitation by updating the storage engine to support at least the
> maximum allowed TTL of 20 years.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14227) Extend maximum expiration date
[
https://issues.apache.org/jira/browse/CASSANDRA-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-14227:
Attachment: screenshot-3.png
> Extend maximum expiration date
> --
>
> Key: CASSANDRA-14227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14227
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Paulo Motta (Deprecated)
>Assignee: Berenguer Blasi
>Priority: Urgent
> Fix For: 4.x
>
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png
>
>
> The maximum expiration timestamp that can be represented by the storage
> engine is
> 2038-01-19T03:14:06+00:00 due to the encoding of {{localExpirationTime}} as
> an int32.
> On CASSANDRA-14092 we added an overflow policy which rejects requests with
> expiration above the maximum date as a temporary measure, but we should
> remove this limitation by updating the storage engine to support at least the
> maximum allowed TTL of 20 years.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18155) Coordinator level metrics for read response and mutation row and column counts
[
https://issues.apache.org/jira/browse/CASSANDRA-18155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680894#comment-17680894
]
Berenguer Blasi commented on CASSANDRA-18155:
-
LGTM so far. We'll need a CI run?
> Coordinator level metrics for read response and mutation row and column counts
> --
>
> Key: CASSANDRA-18155
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18155
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> We propose creating a new metric group, {{ClientRequestSize}}, that will
> house 4 new coordinator-level metrics:
> 1.) ColumnsRead - the total number of columns returned from the database to
> clients
> 2.) RowsRead - the total number of rows returned from the database to clients
> 3.) ColumnsWritten - the total number of columns written to the database by
> clients
> 4.) RowsWritten - the total number of rows written to the database by clients
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18197: - Fix Version/s: (was: 4.x) > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.15, 4.0.8, 4.1.1, 4.2 > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18181:
Test and Documentation Plan:
The build finished successfully.
Submitting the patch for review:
||Patch||CircleCI||Jenkins||CircleCI||
|[trunk|https://github.com/ekaterinadimitrova2/cassandra/commit/a06dbb6b8f90d5b92dfa6ebffd276a218fae57fe]|[simulator
tests, still not running in
Jenkns|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2185/workflows/5370326f-a9b9-472a-a226-675b24201f3c]|[first
try;
|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2220/]
[the aborted built successfully
rerun|https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/]|in-jvm
and unit tests(J17 test workflow, non-related failures expected) -
[J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2182/workflows/9ca49487-937a-4c72-bc78-4fbefe23db76],
[J17|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2182/workflows/e3dc630b-b7a4-4f5b-8f29-489bf43ad90f]|
was:
The build finished successfully.
Submitting the patch for review:
||Patch||CircleCI||Jenkins||CircleCI||
|[trunk|https://github.com/ekaterinadimitrova2/cassandra/commit/a06dbb6b8f90d5b92dfa6ebffd276a218fae57fe]|[simulator
tests, still not running n
Jenkns|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2185/workflows/5370326f-a9b9-472a-a226-675b24201f3c]|[first
try|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2220/],
[the aborted built successfully
rerun|https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/]|in-jvm
and unit tests(J17 test workflow, non-related failures expected) -
[J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2182/workflows/9ca49487-937a-4c72-bc78-4fbefe23db76],
[J17|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2182/workflows/e3dc630b-b7a4-4f5b-8f29-489bf43ad90f]|
[~dcapwell], [~benedict] anyone of you up for review, we've already discussed
this briefly in CASSANDRA-17178?
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
>
[jira] [Updated] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18181:
Test and Documentation Plan:
The build finished successfully.
Submitting the patch for review:
||Patch||CircleCI||Jenkins||CircleCI||
|[trunk|https://github.com/ekaterinadimitrova2/cassandra/commit/a06dbb6b8f90d5b92dfa6ebffd276a218fae57fe]|[simulator
tests, still not running n
Jenkns|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2185/workflows/5370326f-a9b9-472a-a226-675b24201f3c]|[first
try|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2220/],
[the aborted built successfully
rerun|https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/]|in-jvm
and unit tests(J17 test workflow, non-related failures expected) -
[J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2182/workflows/9ca49487-937a-4c72-bc78-4fbefe23db76],
[J17|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2182/workflows/e3dc630b-b7a4-4f5b-8f29-489bf43ad90f]|
[~dcapwell], [~benedict] anyone of you up for review, we've already discussed
this briefly in CASSANDRA-17178?
Status: Patch Available (was: In Progress)
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680854#comment-17680854
]
Ekaterina Dimitrova commented on CASSANDRA-18181:
-
The build finished successfully.
Submitting the patch for review:
||Patch||CircleCI||Jenkins||CircleCI||
|[trunk|https://github.com/ekaterinadimitrova2/cassandra/commit/a06dbb6b8f90d5b92dfa6ebffd276a218fae57fe]|[simulator
tests, still not running n
Jenkns|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2185/workflows/5370326f-a9b9-472a-a226-675b24201f3c]|[first
try|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2220/],
[the aborted built successfully
rerun|https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/]|in-jvm
and unit tests(J17 test workflow, non-related failures expected) -
[J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2182/workflows/9ca49487-937a-4c72-bc78-4fbefe23db76],
[J17|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2182/workflows/e3dc630b-b7a4-4f5b-8f29-489bf43ad90f]|
[~dcapwell], [~benedict] anyone of you up for review, we've already discussed
this briefly in CASSANDRA-17178?
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18199) WEBSITE - Homepage update for Cassandra Summit announcement
[ https://issues.apache.org/jira/browse/CASSANDRA-18199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diogenese Topper updated CASSANDRA-18199: - Change Category: Semantic Complexity: Normal Impacts: Docs (was: None) Test and Documentation Plan: * update headlining blog post and text at the top of the homepage * add image for/to headlining blog/text > WEBSITE - Homepage update for Cassandra Summit announcement > --- > > Key: CASSANDRA-18199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18199 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Priority: Normal > > This ticket is to capture the work associated with updating the Apache > Cassandra website to highlight the upcoming Cassandra Summit. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18199) WEBSITE - Homepage update for Cassandra Summit announcement
Diogenese Topper created CASSANDRA-18199: Summary: WEBSITE - Homepage update for Cassandra Summit announcement Key: CASSANDRA-18199 URL: https://issues.apache.org/jira/browse/CASSANDRA-18199 Project: Cassandra Issue Type: Task Components: Documentation/Website Reporter: Diogenese Topper This ticket is to capture the work associated with updating the Apache Cassandra website to highlight the upcoming Cassandra Summit. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18194) PaxosPrepare may add instances to the Electorate that are not in gossip
[ https://issues.apache.org/jira/browse/CASSANDRA-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-18194: Reviewers: Blake Eggleston, Blake Eggleston Blake Eggleston, Blake Eggleston (was: Blake Eggleston) Status: Review In Progress (was: Patch Available) > PaxosPrepare may add instances to the Electorate that are not in gossip > --- > > Key: CASSANDRA-18194 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18194 > Project: Cassandra > Issue Type: Bug > Components: Feature/Lightweight Transactions >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.1.x > > > org.apache.cassandra.service.paxos.PaxosPrepare.RequestHandler#execute is > given a list of electorate from the peer and attempts to compute its own, > then replies back with this set. > On the peer side, we then have the set we sent and the set from the other > instance... we then fetch the EndpointState from Gossiper and store into a > Map, a map we later attempt to inject into Gossip. > It is possible that Gossiper does not know about the instance yet, so returns > a null; causing a NullPointerException in downstream code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18194) PaxosPrepare may add instances to the Electorate that are not in gossip
[ https://issues.apache.org/jira/browse/CASSANDRA-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-18194: Status: Ready to Commit (was: Review In Progress) +1 thanks > PaxosPrepare may add instances to the Electorate that are not in gossip > --- > > Key: CASSANDRA-18194 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18194 > Project: Cassandra > Issue Type: Bug > Components: Feature/Lightweight Transactions >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.1.x > > > org.apache.cassandra.service.paxos.PaxosPrepare.RequestHandler#execute is > given a list of electorate from the peer and attempts to compute its own, > then replies back with this set. > On the peer side, we then have the set we sent and the set from the other > instance... we then fetch the EndpointState from Gossiper and store into a > Map, a map we later attempt to inject into Gossip. > It is possible that Gossiper does not know about the instance yet, so returns > a null; causing a NullPointerException in downstream code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17708) Fix flaky testOutboundConnectionsAreRejectedWhenAuthFails
[ https://issues.apache.org/jira/browse/CASSANDRA-17708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680817#comment-17680817 ] Caleb Rackliffe commented on CASSANDRA-17708: - Saw this again while testing a trunk-based patch (or at least saw the failure from an issue duplicated by this one): https://app.circleci.com/pipelines/github/maedhroz/cassandra/670/workflows/6263f55f-e94b-4ef7-b4f3-975ba0c1fd64/jobs/5859/tests#failed-test-0 > Fix flaky testOutboundConnectionsAreRejectedWhenAuthFails > - > > Key: CASSANDRA-17708 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17708 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > testOutboundConnectionsAreRejectedWhenAuthFails was introduced in > CASSANDRA-17661 > It seems it was introduced flaky from the very beginning as per this run in a > loop - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=flaky-testOutboundConnectionsAreRejectedWhenAuthFails=all] > CC [~janaki.manchala] , [~jonmeredith], [~ycai] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18155) Coordinator level metrics for read response and mutation row and column counts
[
https://issues.apache.org/jira/browse/CASSANDRA-18155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680813#comment-17680813
]
Caleb Rackliffe commented on CASSANDRA-18155:
-
[~bereng] Check out
https://github.com/apache/cassandra/pull/2105/commits/a4e5c94bb98b372d9d62c39beaa4f6ee1bd0b8f6
> Coordinator level metrics for read response and mutation row and column counts
> --
>
> Key: CASSANDRA-18155
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18155
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> We propose creating a new metric group, {{ClientRequestSize}}, that will
> house 4 new coordinator-level metrics:
> 1.) ColumnsRead - the total number of columns returned from the database to
> clients
> 2.) RowsRead - the total number of rows returned from the database to clients
> 3.) ColumnsWritten - the total number of columns written to the database by
> clients
> 4.) RowsWritten - the total number of rows written to the database by clients
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680809#comment-17680809
]
Ekaterina Dimitrova edited comment on CASSANDRA-18181 at 1/25/23 9:20 PM:
--
Oops, I totally misread.
I just reloaded it
[here|https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/],
thanks!
was (Author: e.dimitrova):
Ops, totally misunderstood.
I just reloaded it
[here|https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/],
thanks!
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18197: - Fix Version/s: 3.11.15 4.0.8 4.1.1 4.2 (was: 3.11.x) (was: 4.0.x) (was: 4.1.x) Since Version: 3.11.12 Source Control Link: https://github.com/apache/cassandra/commit/03c86cfcb0dd31a9c904e2561e3f8a1f26357a44 Resolution: Fixed Status: Resolved (was: Ready to Commit) Thanks, committed. > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.15, 4.0.8, 4.1.1, 4.2, 4.x > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680809#comment-17680809
]
Ekaterina Dimitrova commented on CASSANDRA-18181:
-
Ops, totally misunderstood.
I just reloaded it
[here|https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/],
thanks!
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18197: - Status: Ready to Commit (was: Review In Progress) > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18197: - Reviewers: Michael Semb Wever (was: Brandon Williams, Michael Semb Wever) > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18197: - Reviewers: Michael Semb Wever, Brandon Williams Michael Semb Wever, Brandon Williams (was: Brandon Williams, Michael Semb Wever) Status: Review In Progress (was: Patch Available) > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (057edbe92e -> 60f5efe453)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 057edbe92e Merge branch 'cassandra-4.0' into cassandra-4.1 new 03c86cfcb0 Add concurrency to adoc generation in gen-nodetool-docs.py new c2e9e0d841 Merge branch 'cassandra-3.11' into cassandra-4.0 new 60f5efe453 Merge branch 'cassandra-4.0' into cassandra-4.1 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: doc/scripts/gen-nodetool-docs.py | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 60f5efe4536e43ea8dd00cee2ee332e17534a505 Merge: 057edbe92e c2e9e0d841 Author: Brandon Williams AuthorDate: Wed Jan 25 15:16:46 2023 -0600 Merge branch 'cassandra-4.0' into cassandra-4.1 doc/scripts/gen-nodetool-docs.py | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (f4eef07ef3 -> 93cc75ccdf)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from f4eef07ef3 Merge branch 'cassandra-4.1' into trunk new 03c86cfcb0 Add concurrency to adoc generation in gen-nodetool-docs.py new c2e9e0d841 Merge branch 'cassandra-3.11' into cassandra-4.0 new 60f5efe453 Merge branch 'cassandra-4.0' into cassandra-4.1 new 93cc75ccdf Merge branch 'cassandra-4.1' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: doc/scripts/gen-nodetool-docs.py | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 93cc75ccdfd6747aa2e5b2344496a99c62e39d8a Merge: f4eef07ef3 60f5efe453 Author: Brandon Williams AuthorDate: Wed Jan 25 15:17:00 2023 -0600 Merge branch 'cassandra-4.1' into trunk doc/scripts/gen-nodetool-docs.py | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit c2e9e0d8416866d6600444773f11f592711a5fe9 Merge: 299ead7534 03c86cfcb0 Author: Brandon Williams AuthorDate: Wed Jan 25 15:16:32 2023 -0600 Merge branch 'cassandra-3.11' into cassandra-4.0 doc/scripts/gen-nodetool-docs.py | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (299ead7534 -> c2e9e0d841)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 299ead7534 Merge branch 'cassandra-3.11' into cassandra-4.0 new 03c86cfcb0 Add concurrency to adoc generation in gen-nodetool-docs.py new c2e9e0d841 Merge branch 'cassandra-3.11' into cassandra-4.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: doc/scripts/gen-nodetool-docs.py | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated: Add concurrency to adoc generation in gen-nodetool-docs.py
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.11 by this push:
new 03c86cfcb0 Add concurrency to adoc generation in gen-nodetool-docs.py
03c86cfcb0 is described below
commit 03c86cfcb0dd31a9c904e2561e3f8a1f26357a44
Author: Brandon Williams
AuthorDate: Wed Jan 25 08:55:13 2023 -0600
Add concurrency to adoc generation in gen-nodetool-docs.py
Patch by brandonwiliams; reviewed by mck for CASSANDRA-18197
---
doc/scripts/gen-nodetool-docs.py | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/doc/scripts/gen-nodetool-docs.py b/doc/scripts/gen-nodetool-docs.py
index 1903dca876..efb79cf7a4 100644
--- a/doc/scripts/gen-nodetool-docs.py
+++ b/doc/scripts/gen-nodetool-docs.py
@@ -24,6 +24,10 @@ import sys
import subprocess
from subprocess import PIPE
from subprocess import Popen
+from itertools import islice
+from threading import Thread
+
+batch_size = 3
if(os.environ.get("SKIP_NODETOOL") == "1"):
sys.exit(0)
@@ -36,6 +40,16 @@ helpfilename = outdir + "/nodetool.txt"
command_re = re.compile("()([_a-z]+)")
commandADOCContent = "== {0}\n\n==
Usage\n[source,plaintext]\n\ninclude::example$TEXT/NODETOOL/{0}.txt[]\n\n"
+# https://docs.python.org/3/library/itertools.html#itertools-recipes
+def batched(iterable, n):
+"Batch data into tuples of length n. The last batch may be shorter."
+# batched('ABCDEFG', 3) --> ABC DEF G
+if n < 1:
+raise ValueError('n must be at least one')
+it = iter(iterable)
+while (batch := tuple(islice(it, n))):
+yield batch
+
# create the documentation directory
if not os.path.exists(outdir):
os.makedirs(outdir)
@@ -78,6 +92,12 @@ with open(outdir + "/nodetool.adoc", "w+") as output:
# create the command usage pages
with open(helpfilename, "r+") as helpfile:
-for commandLine in helpfile:
-command = command_re.match(commandLine)
-create_adoc(command)
+for clis in batched(helpfile, batch_size):
+threads = []
+for commandLine in clis:
+command = command_re.match(commandLine)
+t = Thread(target=create_adoc, args=[command])
+threads.append(t)
+t.start()
+for t in threads:
+t.join()
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16325) Update streaming metrics incrementally
[ https://issues.apache.org/jira/browse/CASSANDRA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680808#comment-17680808 ] Paulo Motta commented on CASSANDRA-16325: - LGTM, nice work Isaac! Prepared patch for commit [here|https://github.com/pauloricardomg/cassandra/commit/49946329d05b736943678345c2e110ce315940bc] and submitted a final round of CI: * [https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2228/] (queued) ok to merge if CI looks good [~smiklosovic]? > Update streaming metrics incrementally > -- > > Key: CASSANDRA-16325 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16325 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Paulo Motta >Assignee: Isaac Reath >Priority: Normal > Labels: lhf > Fix For: 4.2 > > Time Spent: 10h 50m > Remaining Estimate: 0h > > Currently the inbound and outbound streamed bytes metrics are incremented > after each file is streamed, what doesn't represent the current number of > bytes streamed since it can take a long time for a large file to be streamed. > We should update the metric incrementally as data is streamed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16325) Update streaming metrics incrementally
[ https://issues.apache.org/jira/browse/CASSANDRA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680808#comment-17680808 ] Paulo Motta edited comment on CASSANDRA-16325 at 1/25/23 9:15 PM: -- LGTM, nice work Isaac! Prepared patch for commit [here|https://github.com/pauloricardomg/cassandra/commit/49946329d05b736943678345c2e110ce315940bc] and submitted a final round of CI: * [https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2229/] (queued) ok to merge if CI looks good [~smiklosovic]? was (Author: paulo): LGTM, nice work Isaac! Prepared patch for commit [here|https://github.com/pauloricardomg/cassandra/commit/49946329d05b736943678345c2e110ce315940bc] and submitted a final round of CI: * [https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2228/] (queued) ok to merge if CI looks good [~smiklosovic]? > Update streaming metrics incrementally > -- > > Key: CASSANDRA-16325 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16325 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Paulo Motta >Assignee: Isaac Reath >Priority: Normal > Labels: lhf > Fix For: 4.2 > > Time Spent: 10h 50m > Remaining Estimate: 0h > > Currently the inbound and outbound streamed bytes metrics are incremented > after each file is streamed, what doesn't represent the current number of > bytes streamed since it can take a long time for a large file to be streamed. > We should update the metric incrementally as data is streamed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680807#comment-17680807
]
Michael Semb Wever commented on CASSANDRA-18181:
I did not initiate the matrix reloaded rerun. Just explaining how it's done.
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16325) Update streaming metrics incrementally
[ https://issues.apache.org/jira/browse/CASSANDRA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-16325: Status: Review In Progress (was: Changes Suggested) > Update streaming metrics incrementally > -- > > Key: CASSANDRA-16325 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16325 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Paulo Motta >Assignee: Isaac Reath >Priority: Normal > Labels: lhf > Fix For: 4.2 > > Time Spent: 10h 50m > Remaining Estimate: 0h > > Currently the inbound and outbound streamed bytes metrics are incremented > after each file is streamed, what doesn't represent the current number of > bytes streamed since it can take a long time for a large file to be streamed. > We should update the metric incrementally as data is streamed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680804#comment-17680804
]
Ekaterina Dimitrova commented on CASSANDRA-18181:
-
Thanks, [~mck]
{quote}[https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2157/]
{quote}
Is that the right link? I can see the yesterday aborted build, but I am not
sure where is the newly submitted one?
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18155) Coordinator level metrics for read response and mutation row and column counts
[
https://issues.apache.org/jira/browse/CASSANDRA-18155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680803#comment-17680803
]
Caleb Rackliffe commented on CASSANDRA-18155:
-
bq. Then we'll need the rest of the branches and CI for them
This is a new metric for trunk only.
> Coordinator level metrics for read response and mutation row and column counts
> --
>
> Key: CASSANDRA-18155
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18155
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> We propose creating a new metric group, {{ClientRequestSize}}, that will
> house 4 new coordinator-level metrics:
> 1.) ColumnsRead - the total number of columns returned from the database to
> clients
> 2.) RowsRead - the total number of rows returned from the database to clients
> 3.) ColumnsWritten - the total number of columns written to the database by
> clients
> 4.) RowsWritten - the total number of rows written to the database by clients
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18001) Add missing tests suites to CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18001: Test and Documentation Plan: ||Patch||LOWRES||MIDRES||HIGHRES|| |[4.1|https://github.com/ekaterinadimitrova2/cassandra/tree/18001-4.1-3]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-4.1-3]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-4.1-3-mid]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-4.1-3-high]| |[trunk|https://github.com/ekaterinadimitrova2/cassandra/tree/18001-trunk-3]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-trunk-3]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2130/workflows/9df2d073-c26a-4750-82e4-8b6645f37f9c]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-trunk-3-high2]| _*trunk still running - I will check it tomorrow morning_ 3.0, 3.11 and 4.0 will be finished in a second batch after we commit 4.1 and trunk and unblock it. *CONTINUATION Jan 25th 2023* Rebased and finished 3.0: ||Patch||LOWRES||MIDRES||HIGHRES|| |[3.0|https://github.com/ekaterinadimitrova2/cassandra/tree/18001-3.0-final]|[CircleCI #2196|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-3.0-final]|[CircleCI #2197|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-3.0-final-mid]|[CircleCI #2198|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-3.0-final-high]| As part of the patch: - Large DTests and cqlshlib tests were added - [the fix for split|https://github.com/ekaterinadimitrova2/cassandra/commit/514e07dfee300b1b972e860c2f61674fae0793c6#diff-bc7cfdde47dcf913bec381c90c03b51e430f1e4b34ff2ac1c419d87436c85137L914] of tests was back ported - [clean was removed|https://github.com/ekaterinadimitrova2/cassandra/commit/514e07dfee300b1b972e860c2f61674fae0793c6#diff-bc7cfdde47dcf913bec381c90c03b51e430f1e4b34ff2ac1c419d87436c85137L776] - [fixed|https://github.com/ekaterinadimitrova2/cassandra/commit/514e07dfee300b1b972e860c2f61674fae0793c6#diff-bc7cfdde47dcf913bec381c90c03b51e430f1e4b34ff2ac1c419d87436c85137L1278] number of tokens at one place as the default number is 32 not 16 (which was a change done in 4.0) *Note:* we still have Large DTests running with Large and not XLarge container, I can change that if we all agree about that on CASSANDRA-18051 If this is ok I will propagate the patch to 3.11 and 4.0. 4.0 will need everything but cqlshlib tests which were already added in the past. Then I will also run CI on all branches [~adelapena] , can you, please, take a look when you have time? was: ||Patch||LOWRES||MIDRES||HIGHRES|| |[4.1|https://github.com/ekaterinadimitrova2/cassandra/tree/18001-4.1-3]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-4.1-3]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-4.1-3-mid]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-4.1-3-high]| |[trunk|https://github.com/ekaterinadimitrova2/cassandra/tree/18001-trunk-3]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-trunk-3]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2130/workflows/9df2d073-c26a-4750-82e4-8b6645f37f9c]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-trunk-3-high2]| _*trunk still running - I will check it tomorrow morning_ 3.0, 3.11 and 4.0 will be finished in a second batch after we commit 4.1 and trunk and unblock it. Status: Patch Available (was: In Progress) > Add missing tests suites to CircleCI > > > Key: CASSANDRA-18001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18001 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Urgent > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc1, 4.1, 4.1.x, 4.2, 4.x > > > Burn tests to all branches, large Python DTests (with/without vnodes), > cqlshlib not tested in all branches and with all jdks; Java distributed tests > not running with J8/J11 4.0+ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18001) Add missing tests suites to CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680802#comment-17680802 ] Ekaterina Dimitrova commented on CASSANDRA-18001: - Rebased and finished 3.0: ||Patch||LOWRES||MIDRES||HIGHRES|| |[3.0|https://github.com/ekaterinadimitrova2/cassandra/tree/18001-3.0-final]|[CircleCI #2196|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-3.0-final]|[CircleCI #2197|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-3.0-final-mid]|[CircleCI #2198|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-3.0-final-high]| As part of the patch: - Large DTests and cqlshlib tests were added - [the fix for split|https://github.com/ekaterinadimitrova2/cassandra/commit/514e07dfee300b1b972e860c2f61674fae0793c6#diff-bc7cfdde47dcf913bec381c90c03b51e430f1e4b34ff2ac1c419d87436c85137L914] of tests was back ported - [clean was removed|https://github.com/ekaterinadimitrova2/cassandra/commit/514e07dfee300b1b972e860c2f61674fae0793c6#diff-bc7cfdde47dcf913bec381c90c03b51e430f1e4b34ff2ac1c419d87436c85137L776] - [fixed|https://github.com/ekaterinadimitrova2/cassandra/commit/514e07dfee300b1b972e860c2f61674fae0793c6#diff-bc7cfdde47dcf913bec381c90c03b51e430f1e4b34ff2ac1c419d87436c85137L1278] number of tokens at one place as the default number is 32 not 16 (which was a change done in 4.0) *Note:* we still have Large DTests running with Large and not XLarge container, I can change that if we all agree about that on CASSANDRA-18051 If this is ok I will propagate the patch to 3.11 and 4.0. 4.0 will need everything but cqlshlib tests which were already added in the past. Then I will also run CI on all branches [~adelapena] , can you, please, take a look when you have time? > Add missing tests suites to CircleCI > > > Key: CASSANDRA-18001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18001 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Urgent > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc1, 4.1, 4.1.x, 4.2, 4.x > > > Burn tests to all branches, large Python DTests (with/without vnodes), > cqlshlib not tested in all branches and with all jdks; Java distributed tests > not running with J8/J11 4.0+ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680800#comment-17680800 ] Michael Semb Wever commented on CASSANDRA-18197: +1 on the code changes. > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17092) CEP-15: Accord Beta
[
https://issues.apache.org/jira/browse/CASSANDRA-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680794#comment-17680794
]
Caleb Rackliffe commented on CASSANDRA-17092:
-
The {{cep-15-accord}} [feature
branch|https://github.com/apache/cassandra/commits/cep-15-accord] is now
rebased to trunk at commit {{eee052dad3ddce2b0ed951f7baa99f7efaf3684b}}.
> CEP-15: Accord Beta
> ---
>
> Key: CASSANDRA-17092
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17092
> Project: Cassandra
> Issue Type: Epic
> Components: Accord
>Reporter: Benedict Elliott Smith
>Assignee: Benedict Elliott Smith
>Priority: Normal
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680652#comment-17680652 ] Brandon Williams edited comment on CASSANDRA-18197 at 1/25/23 8:34 PM: --- Patch adds concurrency to the adoc generation, working in batches of 3 (more doesn't really help at least on my macine) and this cuts the run time to around 30s. ||Branch||CI|| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/821/workflows/2b13ee0b-a523-4d9f-bc58-1bb6a98894be]| |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/ab7f2d3b-f47d-4c60-80e0-99afd5961c8c], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/b707fbe5-d245-4bef-af49-191a4a54b201]| |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/7a76a7eb-0697-4ca8-a4a2-9c3985838c1f], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/cab41040-0506-460a-8022-ec944e879814]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/3ce42dbc-7b9e-4c85-8211-9c449d0870df], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/992604c1-3a14-4e64-8ede-10721fc15fbb]| Jenkins for a smoke test: [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2228/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2228/pipeline] was (Author: brandon.williams): Patch adds concurrency to the adoc generation, working in batches of 3 (more doesn't really help at least on my macine) and this cuts the run time to around 30s. ||Branch||CI|| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/821/workflows/2b13ee0b-a523-4d9f-bc58-1bb6a98894be]| |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/ab7f2d3b-f47d-4c60-80e0-99afd5961c8c], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/b707fbe5-d245-4bef-af49-191a4a54b201]| |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/7a76a7eb-0697-4ca8-a4a2-9c3985838c1f], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/cab41040-0506-460a-8022-ec944e879814]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/3ce42dbc-7b9e-4c85-8211-9c449d0870df], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/992604c1-3a14-4e64-8ede-10721fc15fbb]| Jenkins for a smoke test: [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2224/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2224/pipeline] > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 22/27: Refactor Timestamp/TxnId - Combine real and logical into a single 64-but HLC - Introduce 16 flag bits - Pack epoch (48-bits), HLC (64-bits) and flags (16-bits) into two longs in
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit ec23e3cc4b82a4ef0fe7ec157ba7261578c9f02f
Author: Benedict Elliott Smith
AuthorDate: Mon Jan 9 12:28:26 2023 +
Refactor Timestamp/TxnId
- Combine real and logical into a single 64-but HLC
- Introduce 16 flag bits
- Pack epoch (48-bits), HLC (64-bits) and flags (16-bits) into two longs
in memory
patch by Benedict; reviewed by Aleksey Yeschenko for CASSANDRA-18172
---
.build/include-accord.sh | 2 +-
.../cassandra/service/accord/AccordCommand.java| 14 +
.../service/accord/AccordCommandStore.java | 6 ++--
.../service/accord/AccordCommandsForKey.java | 8 ++---
.../cassandra/service/accord/AccordKeyspace.java | 36 +++---
.../service/accord/AccordObjectSizes.java | 2 +-
.../service/accord/AccordPartialCommand.java | 20 +++-
.../cassandra/service/accord/api/AccordAgent.java | 2 +-
.../service/accord/async/AsyncWriter.java | 5 +--
.../accord/serializers/CommandSerializers.java | 32 ---
.../service/accord/serializers/DepsSerializer.java | 3 ++
.../service/accord/AccordCommandStoreTest.java | 34 ++--
.../service/accord/AccordCommandTest.java | 10 +++---
.../cassandra/service/accord/AccordTestUtils.java | 19 ++--
.../service/accord/async/AsyncLoaderTest.java | 18 +--
.../service/accord/async/AsyncOperationTest.java | 4 +--
.../service/accord/async/AsyncWriterTest.java | 12
17 files changed, 101 insertions(+), 126 deletions(-)
diff --git a/.build/include-accord.sh b/.build/include-accord.sh
index 37bdcbe079..2144e80b17 100755
--- a/.build/include-accord.sh
+++ b/.build/include-accord.sh
@@ -25,7 +25,7 @@ set -o nounset
bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
accord_repo='https://github.com/apache/cassandra-accord.git'
-accord_branch='804a77d32c8ae45751a3a7f450b372560f08cacc'
+accord_branch='ad326d5df8d99d4799fa87de81482e3cb1fb92de'
accord_src="$bin/cassandra-accord"
checkout() {
diff --git a/src/java/org/apache/cassandra/service/accord/AccordCommand.java
b/src/java/org/apache/cassandra/service/accord/AccordCommand.java
index 2003e77ae1..5b4a8c2e9b 100644
--- a/src/java/org/apache/cassandra/service/accord/AccordCommand.java
+++ b/src/java/org/apache/cassandra/service/accord/AccordCommand.java
@@ -532,18 +532,6 @@ public class AccordCommand extends Command implements
AccordState
return executeAt.get();
}
-@Override
-public Txn.Kind kind()
-{
-return kind.get();
-}
-
-@Override
-public void setKind(Txn.Kind kind)
-{
-this.kind.set(kind);
-}
-
@Override
public void setExecuteAt(Timestamp timestamp)
{
@@ -636,7 +624,7 @@ public class AccordCommand extends Command implements
AccordState
private boolean canApplyWithCurrentScope(SafeCommandStore safeStore)
{
-Ranges ranges = safeStore.ranges().at(executeAt().epoch);
+Ranges ranges = safeStore.ranges().at(executeAt().epoch());
Seekables keys = partialTxn().keys();
for (int i=0,mi=keys.size(); i
forEach)
{
-switch (keyOrRange.kind())
+switch (keyOrRange.domain())
{
default: throw new AssertionError();
case Key:
@@ -217,7 +217,7 @@ public class AccordCommandStore extends CommandStore
@Override
public void forEach(Routable keyOrRange, Ranges slice,
Consumer forEach)
{
-switch (keyOrRange.kind())
+switch (keyOrRange.domain())
{
default: throw new AssertionError();
case Key:
@@ -272,7 +272,7 @@ public class AccordCommandStore extends CommandStore
{
Timestamp max = maxConflict(keys);
long epoch = latestEpoch();
-if (txnId.compareTo(max) > 0 && txnId.epoch >= epoch &&
!agent.isExpired(txnId, time.now()))
+if (txnId.compareTo(max) > 0 && txnId.epoch() >= epoch &&
!agent.isExpired(txnId, time.now()))
return txnId;
return time.uniqueNow(max);
diff --git
a/src/java/org/apache/cassandra/service/accord/AccordCommandsForKey.java
b/src/java/org/apache/cassandra/service/accord/AccordCommandsForKey.java
index 8a1715384e..437c3b5f66 100644
--- a/src/java/org/apache/cassandra/service/accord/AccordCommandsForKey.java
+++ b/src/java/org/apache/cassandra/service/accord/AccordCommandsForKey.java
@@ -53,7 +53,7 @@ import org.assertj.core.util.VisibleForTesting;
import static accord.local.CommandsForKey.CommandTimeseries.TestDep.ANY_DEPS;
import static accord.local.CommandsForKey.CommandTimeseries.TestDep.WITHOUT;
import static
[cassandra] 15/27: Ninja for CASSANDRA-17719 disable the checks in increaseSlightly and decreaseSlightly to get back to the old behavior for now
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit da8c1c723f76eb401808719977aa35082b679036
Author: David Capwell
AuthorDate: Fri Dec 16 14:13:17 2022 -0800
Ninja for CASSANDRA-17719 disable the checks in increaseSlightly and
decreaseSlightly to get back to the old behavior for now
---
src/java/org/apache/cassandra/dht/Murmur3Partitioner.java | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/java/org/apache/cassandra/dht/Murmur3Partitioner.java
b/src/java/org/apache/cassandra/dht/Murmur3Partitioner.java
index d461d4cb79..1f7f3605e9 100644
--- a/src/java/org/apache/cassandra/dht/Murmur3Partitioner.java
+++ b/src/java/org/apache/cassandra/dht/Murmur3Partitioner.java
@@ -221,16 +221,21 @@ public class Murmur3Partitioner implements IPartitioner
@Override
public LongToken increaseSlightly()
{
-if (token == MAXIMUM)
-throw new IllegalArgumentException("Cannot increase above
MAXIMUM");
+// CASSANDRA-17109 Added the below checks, but paxos tests were
not updated, rather than fix
+// the paxos tests, disabling the checks for now. The current
paxos tests bias twards MIN but
+// not for MAX, which makes the test very flaky as when MAX is
generated the test fails...
+//if (token == MAXIMUM)
+//throw new IllegalArgumentException("Cannot increase above
MAXIMUM");
return new LongToken(token + 1);
}
public LongToken decreaseSlightly()
{
-if (equals(MINIMUM))
-throw new IllegalArgumentException("Cannot decrease below
MINIMUM");
+// CASSANDRA-17109 Added the below checks, but paxos tests were
not updated, rather than fix
+// the paxos tests, disabling the checks for now
+//if (equals(MINIMUM))
+//throw new IllegalArgumentException("Cannot decrease below
MINIMUM");
return new LongToken(token - 1);
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 19/27: ninja: pick a cassandra-accord SHA to build against to decouple source trees
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 9d57c19705adcd5cd4c392618186940aef62c8e2
Author: Benedict Elliott Smith
AuthorDate: Tue Jan 10 21:19:27 2023 +
ninja: pick a cassandra-accord SHA to build against to decouple source trees
---
.build/include-accord.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build/include-accord.sh b/.build/include-accord.sh
index 0dc01bf2ba..b1409603fb 100755
--- a/.build/include-accord.sh
+++ b/.build/include-accord.sh
@@ -25,7 +25,7 @@ set -o nounset
bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
accord_repo='https://github.com/apache/cassandra-accord.git'
-accord_branch='trunk'
+accord_branch='63c37e20cfe66a421c1b07ba1f430a9e6aabe4c5'
accord_src="$bin/cassandra-accord"
checkout() {
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 27/27: Post-rebase fixes around CASSANDRA-18099 and CASSANDRA-18114 (among other things)
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit c7fd7cbc53bb1c2eb77abd7ef32b6a6c19e35465
Author: Caleb Rackliffe
AuthorDate: Wed Jan 25 14:32:12 2023 -0600
Post-rebase fixes around CASSANDRA-18099 and CASSANDRA-18114 (among other
things)
---
src/java/org/apache/cassandra/cql3/Maps.java| 1 -
src/java/org/apache/cassandra/cql3/Operator.java| 7 +++
.../cassandra/cql3/conditions/ColumnCondition.java | 21 +++--
.../apache/cassandra/cql3/selection/Selector.java | 2 +-
.../cql3/statements/TransactionStatement.java | 2 +-
.../org/apache/cassandra/db/PartitionPosition.java | 3 +--
.../org/apache/cassandra/db/marshal/UserType.java | 2 +-
.../org/apache/cassandra/dht/AbstractBounds.java| 1 -
.../dht/IPartitionerDependentSerializer.java| 1 -
src/java/org/apache/cassandra/dht/Token.java| 8
.../service/accord/AccordCommandsForKey.java| 1 -
.../cassandra/service/accord/AccordKeyspace.java| 11 +--
.../service/accord/AccordSerializerVersion.java | 4 ++--
.../cassandra/service/accord/AccordSerializers.java | 20 +---
.../cassandra/service/accord/api/AccordAgent.java | 2 --
.../accord/serializers/CheckStatusSerializers.java | 1 -
.../accord/serializers/CommitSerializers.java | 1 -
.../service/accord/serializers/DepsSerializer.java | 12 ++--
.../service/accord/serializers/EnumSerializer.java | 4 ++--
.../service/accord/serializers/KeySerializers.java | 9 -
.../accord/serializers/ReadDataSerializers.java | 1 -
.../accord/serializers/WaitOnCommitSerializer.java | 1 -
.../service/accord/store/StoredNavigableMap.java| 2 --
.../cassandra/service/accord/txn/TxnCondition.java | 9 -
.../cassandra/service/accord/txn/TxnData.java | 2 +-
.../cassandra/service/accord/txn/TxnDataName.java | 8
.../cassandra/service/accord/txn/TxnReference.java | 5 ++---
.../service/accord/txn/TxnReferenceOperation.java | 17 -
.../service/accord/txn/TxnReferenceValue.java | 6 ++
.../cassandra/service/accord/txn/TxnUpdate.java | 9 -
.../apache/cassandra/utils/ArraySerializers.java| 5 ++---
.../org/apache/cassandra/utils/ByteBufferUtil.java | 4 ++--
.../paxos/PairOfSequencesAccordSimulation.java | 2 --
.../paxos/StrictSerializabilityValidator.java | 1 -
.../systems/InterceptingGlobalMethods.java | 3 ---
.../systems/InterceptorOfGlobalMethods.java | 3 +++
.../cql3/conditions/ColumnConditionTest.java| 8 +++-
.../dht/OrderPreservingPartitionerTest.java | 4
.../apache/cassandra/dht/PartitionerTestCase.java | 1 -
39 files changed, 85 insertions(+), 119 deletions(-)
diff --git a/src/java/org/apache/cassandra/cql3/Maps.java
b/src/java/org/apache/cassandra/cql3/Maps.java
index 872c1ce600..6f8c42a927 100644
--- a/src/java/org/apache/cassandra/cql3/Maps.java
+++ b/src/java/org/apache/cassandra/cql3/Maps.java
@@ -36,7 +36,6 @@ import org.apache.cassandra.db.guardrails.Guardrails;
import org.apache.cassandra.db.marshal.AbstractType;
import org.apache.cassandra.db.marshal.ByteBufferAccessor;
import org.apache.cassandra.db.marshal.MapType;
-import org.apache.cassandra.db.marshal.ReversedType;
import org.apache.cassandra.db.rows.Cell;
import org.apache.cassandra.db.rows.CellPath;
import org.apache.cassandra.exceptions.InvalidRequestException;
diff --git a/src/java/org/apache/cassandra/cql3/Operator.java
b/src/java/org/apache/cassandra/cql3/Operator.java
index 625e53ee83..5933f95705 100644
--- a/src/java/org/apache/cassandra/cql3/Operator.java
+++ b/src/java/org/apache/cassandra/cql3/Operator.java
@@ -33,7 +33,6 @@ import org.apache.cassandra.serializers.ListSerializer;
import org.apache.cassandra.utils.ByteBufferUtil;
import static com.google.common.base.Preconditions.checkArgument;
-import static com.google.common.primitives.Ints.checkedCast;
import static org.apache.cassandra.db.TypeSizes.sizeofUnsignedVInt;
public enum Operator
@@ -295,7 +294,7 @@ public enum Operator
* Creates a new Operator with the specified binary
representation.
* @param b the binary representation of this Enum value
*/
-private Operator(int b)
+Operator(int b)
{
this.b = b;
}
@@ -319,7 +318,7 @@ public enum Operator
*/
public void writeToUnsignedVInt(DataOutputPlus output) throws IOException
{
-output.writeUnsignedVInt(b);
+output.writeUnsignedVInt32(b);
}
public int getValue()
@@ -348,7 +347,7 @@ public enum Operator
*/
public static Operator readFromUnsignedVInt(DataInputPlus input) throws
IOException
{
-return fromBinary(checkedCast(input.readUnsignedVInt()));
+return
[cassandra] 02/27: Command table now uses a local version added to the payload rather than rely on a version column, and fixed a few feedback related issues
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 9327165d407dd4ea4c9af5b568ecd2a95474fa30
Author: David Capwell
AuthorDate: Fri Oct 21 16:29:28 2022 -0700
Command table now uses a local version added to the payload rather than
rely on a version column, and fixed a few feedback related issues
patch by David Capwell; reviewed by Blake Eggleston for CASSANDRA-17103
---
.build/include-accord.sh | 4 +-
.../db/filter/AbstractClusteringIndexFilter.java | 1 -
.../db/filter/ClusteringIndexSliceFilter.java | 1 -
.../apache/cassandra/db/partitions/Partition.java | 2 -
.../cassandra/io/LocalVersionedSerializer.java | 94 +
.../cassandra/io/MessageVersionProvider.java | 24
.../apache/cassandra/net/ResponseVerbHandler.java | 2 +-
.../cassandra/service/accord/AccordCommand.java| 1 +
.../service/accord/AccordCommandStore.java | 11 +-
.../service/accord/AccordCommandsForKey.java | 2 +-
.../cassandra/service/accord/AccordKeyspace.java | 145 -
.../service/accord/AccordMessageSink.java | 3 +-
.../service/accord/AccordPartialCommand.java | 85 +---
.../service/accord/AccordSerializerVersion.java| 114
.../cassandra/service/accord/AccordStateCache.java | 24 ++--
.../service/accord/async/AsyncLoader.java | 6 +-
.../service/accord/async/AsyncOperation.java | 26 ++--
.../service/accord/async/AsyncWriter.java | 14 +-
.../accord/serializers/AcceptSerializers.java | 6 +-
.../cassandra/simulator/asm/InterceptClasses.java | 3 +-
.../cassandra/simulator/SimulationRunner.java | 1 +
.../apache/cassandra/simulator/SimulatorUtils.java | 7 +-
.../service/accord/async/AsyncLoaderTest.java | 19 +--
.../service/accord/async/AsyncWriterTest.java | 3 +-
24 files changed, 382 insertions(+), 216 deletions(-)
diff --git a/.build/include-accord.sh b/.build/include-accord.sh
index 7069e22b6f..0dc01bf2ba 100755
--- a/.build/include-accord.sh
+++ b/.build/include-accord.sh
@@ -24,8 +24,8 @@ set -o nounset
bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
-accord_repo='https://github.com/bdeggleston/cassandra-accord.git'
-accord_branch='metadata-persistence'
+accord_repo='https://github.com/apache/cassandra-accord.git'
+accord_branch='trunk'
accord_src="$bin/cassandra-accord"
checkout() {
diff --git
a/src/java/org/apache/cassandra/db/filter/AbstractClusteringIndexFilter.java
b/src/java/org/apache/cassandra/db/filter/AbstractClusteringIndexFilter.java
index e1792d17f8..ddcaaed812 100644
--- a/src/java/org/apache/cassandra/db/filter/AbstractClusteringIndexFilter.java
+++ b/src/java/org/apache/cassandra/db/filter/AbstractClusteringIndexFilter.java
@@ -18,7 +18,6 @@
package org.apache.cassandra.db.filter;
import java.io.IOException;
-import java.util.Objects;
import org.apache.cassandra.schema.ColumnMetadata;
import org.apache.cassandra.schema.TableMetadata;
diff --git
a/src/java/org/apache/cassandra/db/filter/ClusteringIndexSliceFilter.java
b/src/java/org/apache/cassandra/db/filter/ClusteringIndexSliceFilter.java
index 1f4b72c810..178c96b453 100644
--- a/src/java/org/apache/cassandra/db/filter/ClusteringIndexSliceFilter.java
+++ b/src/java/org/apache/cassandra/db/filter/ClusteringIndexSliceFilter.java
@@ -20,7 +20,6 @@ package org.apache.cassandra.db.filter;
import java.io.IOException;
import java.util.List;
import java.nio.ByteBuffer;
-import java.util.Objects;
import org.apache.cassandra.schema.TableMetadata;
import org.apache.cassandra.db.*;
diff --git a/src/java/org/apache/cassandra/db/partitions/Partition.java
b/src/java/org/apache/cassandra/db/partitions/Partition.java
index 1daf20cd00..601934a8e7 100644
--- a/src/java/org/apache/cassandra/db/partitions/Partition.java
+++ b/src/java/org/apache/cassandra/db/partitions/Partition.java
@@ -21,12 +21,10 @@ import java.util.NavigableSet;
import javax.annotation.Nullable;
-import org.apache.cassandra.schema.TableId;
import org.apache.cassandra.schema.TableMetadata;
import org.apache.cassandra.db.*;
import org.apache.cassandra.db.rows.*;
import org.apache.cassandra.db.filter.ColumnFilter;
-import org.apache.cassandra.service.accord.api.AccordKey;
/**
* In-memory representation of a Partition.
diff --git a/src/java/org/apache/cassandra/io/LocalVersionedSerializer.java
b/src/java/org/apache/cassandra/io/LocalVersionedSerializer.java
new file mode 100644
index 00..739f007846
--- /dev/null
+++ b/src/java/org/apache/cassandra/io/LocalVersionedSerializer.java
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ *
[cassandra] 26/27: CASSANDRA-18154: CEP-15: Enhance returning SELECT to allow partition and clustering IN clauses to return multiple partitions/rows
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit cc6f89124c171d4aea6cd3852000c780f16b7e99
Author: David Capwell
AuthorDate: Thu Jan 12 12:07:54 2023 -0800
CASSANDRA-18154: CEP-15: Enhance returning SELECT to allow partition and
clustering IN clauses to return multiple partitions/rows
---
.build/cassandra-build-deps-template.xml | 5 +
.build/include-accord.sh | 2 +-
.build/parent-pom-template.xml | 21 +
ide/idea-iml-file.xml | 1 +
ide/idea/workspace.xml | 35 +-
.../metrics/AccordClientRequestMetrics.java| 37 +-
.../cassandra/service/accord/AccordCommand.java| 2 +
.../cassandra/service/accord/AccordService.java| 27 +
.../cassandra/utils/logging/ClassNameFilter.java | 38 +-
test/conf/logback-simulator.xml| 14 +
.../org/apache/cassandra/distributed/api/Row.java | 160 ++
.../apache/cassandra/distributed/impl/Query.java | 12 +-
.../distributed/util/QueryResultUtil.java | 2 +
.../org/apache/cassandra/simulator/ActionList.java | 4 +
.../AbstractPairOfSequencesPaxosSimulation.java| 201 +++
.../cassandra/simulator/paxos/HistoryChecker.java | 32 +-
.../{Observation.java => HistoryValidator.java}| 41 +-
.../simulator/paxos/LinearizabilityValidator.java | 83 +++
.../simulator/paxos/LoggingHistoryValidator.java | 73 +++
.../cassandra/simulator/paxos/Observation.java | 16 +-
.../paxos/PairOfSequencesAccordSimulation.java | 310 +--
.../paxos/PairOfSequencesPaxosSimulation.java | 165 +-
.../cassandra/simulator/paxos/PaxosSimulation.java | 53 +-
.../paxos/StrictSerializabilityValidator.java | 112
.../simulator/systems/SimulatedQuery.java | 5 +-
.../simulator/paxos/HistoryValidatorTest.java | 592 +
.../cassandra/service/accord/AccordTestUtils.java | 14 +-
.../org/apache/cassandra/utils/AssertionUtils.java | 46 +-
28 files changed, 1724 insertions(+), 379 deletions(-)
diff --git a/.build/cassandra-build-deps-template.xml
b/.build/cassandra-build-deps-template.xml
index 93387996ef..cfd2806fe7 100644
--- a/.build/cassandra-build-deps-template.xml
+++ b/.build/cassandra-build-deps-template.xml
@@ -127,5 +127,10 @@
com.fasterxml.jackson.dataformat
jackson-dataformat-yaml
+
+ accord
+ accord
+ tests
+
diff --git a/.build/include-accord.sh b/.build/include-accord.sh
index 2144e80b17..eabe4d204b 100755
--- a/.build/include-accord.sh
+++ b/.build/include-accord.sh
@@ -25,7 +25,7 @@ set -o nounset
bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
accord_repo='https://github.com/apache/cassandra-accord.git'
-accord_branch='ad326d5df8d99d4799fa87de81482e3cb1fb92de'
+accord_branch='5626c7c11400d4cf6d01a8e22517b53a83f5c512'
accord_src="$bin/cassandra-accord"
checkout() {
diff --git a/.build/parent-pom-template.xml b/.build/parent-pom-template.xml
index c582933234..218065968d 100644
--- a/.build/parent-pom-template.xml
+++ b/.build/parent-pom-template.xml
@@ -679,6 +679,27 @@
accord
1.0-SNAPSHOT
+
+accord
+accord
+1.0-SNAPSHOT
+tests
+test
+
+
+org.junit.jupiter
+junit-jupiter-api
+
+
+org.junit.jupiter
+junit-jupiter-engine
+
+
+ch.qos.logback
+logback-classic
+
+
+
io.airlift
airline
diff --git a/ide/idea-iml-file.xml b/ide/idea-iml-file.xml
index c0b55842fa..4c529892a4 100644
--- a/ide/idea-iml-file.xml
+++ b/ide/idea-iml-file.xml
@@ -39,6 +39,7 @@
+
diff --git a/ide/idea/workspace.xml b/ide/idea/workspace.xml
index a89921cc77..9248a8f6c9 100644
--- a/ide/idea/workspace.xml
+++ b/ide/idea/workspace.xml
@@ -167,7 +167,40 @@
-
diff --git
a/test/simulator/main/org/apache/cassandra/simulator/paxos/Observation.java
b/src/java/org/apache/cassandra/metrics/AccordClientRequestMetrics.java
similarity index 52%
copy from
test/simulator/main/org/apache/cassandra/simulator/paxos/Observation.java
copy to src/java/org/apache/cassandra/metrics/AccordClientRequestMetrics.java
index 546fd3179f..c95c3bd11f 100644
--- a/test/simulator/main/org/apache/cassandra/simulator/paxos/Observation.java
+++ b/src/java/org/apache/cassandra/metrics/AccordClientRequestMetrics.java
@@ -16,30 +16,31 @@
* limitations under the License.
*/
-package org.apache.cassandra.simulator.paxos;
+package org.apache.cassandra.metrics;
-class Observation implements
[cassandra] 20/27: CEP-15: (C*) Enhance returning SELECT to allow partition and clustering IN clauses to return multiple partitions/rows
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 4e596230abece703a6f735ca33ec64c5c10b263b
Author: David Capwell
AuthorDate: Thu Jan 12 14:24:32 2023 -0800
CEP-15: (C*) Enhance returning SELECT to allow partition and clustering IN
clauses to return multiple partitions/rows
patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-18154
---
.../cql3/statements/TransactionStatement.java | 43 +++--
.../cassandra/service/accord/txn/TxnDataName.java | 5 ++
.../distributed/test/accord/AccordCQLTest.java | 56 ++
3 files changed, 99 insertions(+), 5 deletions(-)
diff --git
a/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
b/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
index 4d3c732da0..e4893154b2 100644
--- a/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
+++ b/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
@@ -182,6 +182,24 @@ public class TransactionStatement implements CQLStatement
return new TxnNamedRead(namedSelect.name,
Iterables.getOnlyElement(selectQuery.queries));
}
+List createNamedReads(NamedSelect namedSelect, QueryOptions
options)
+{
+SelectStatement select = namedSelect.select;
+ReadQuery readQuery = select.getQuery(options, 0);
+
+// We reject reads from both LET and SELECT that do not specify a
single row.
+@SuppressWarnings("unchecked")
+SinglePartitionReadQuery.Group selectQuery
= (SinglePartitionReadQuery.Group) readQuery;
+
+if (selectQuery.queries.size() == 1)
+return Collections.singletonList(new
TxnNamedRead(namedSelect.name, Iterables.getOnlyElement(selectQuery.queries)));
+
+List list = new ArrayList<>(selectQuery.queries.size());
+for (int i = 0; i < selectQuery.queries.size(); i++)
+list.add(new TxnNamedRead(TxnDataName.returning(i),
selectQuery.queries.get(i)));
+return list;
+}
+
private List createNamedReads(QueryOptions options,
Consumer keyConsumer)
{
List reads = new ArrayList<>(assignments.size() + 1);
@@ -195,9 +213,11 @@ public class TransactionStatement implements CQLStatement
if (returningSelect != null)
{
-TxnNamedRead read = createNamedRead(returningSelect, options);
-keyConsumer.accept(read.key());
-reads.add(read);
+for (TxnNamedRead read : createNamedReads(returningSelect,
options))
+{
+keyConsumer.accept(read.key());
+reads.add(read);
+}
}
for (NamedSelect select : autoReads.values())
@@ -314,10 +334,23 @@ public class TransactionStatement implements CQLStatement
if (returningSelect != null)
{
-FilteredPartition partition =
data.get(TxnDataName.returning());
+SinglePartitionReadQuery.Group
selectQuery = (SinglePartitionReadQuery.Group)
returningSelect.select.getQuery(options, 0);
Selection.Selectors selectors =
returningSelect.select.getSelection().newSelectors(options);
ResultSetBuilder result = new
ResultSetBuilder(returningSelect.select.getResultMetadata(), selectors, null);
-
returningSelect.select.processPartition(partition.rowIterator(), options,
result, FBUtilities.nowInSeconds());
+if (selectQuery.queries.size() == 1)
+{
+FilteredPartition partition =
data.get(TxnDataName.returning());
+
returningSelect.select.processPartition(partition.rowIterator(), options,
result, FBUtilities.nowInSeconds());
+}
+else
+{
+int nowInSec = FBUtilities.nowInSeconds();
+for (int i = 0; i < selectQuery.queries.size(); i++)
+{
+FilteredPartition partition =
data.get(TxnDataName.returning(i));
+
returningSelect.select.processPartition(partition.rowIterator(), options,
result, nowInSec);
+}
+}
return new ResultMessage.Rows(result.build());
}
diff --git a/src/java/org/apache/cassandra/service/accord/txn/TxnDataName.java
b/src/java/org/apache/cassandra/service/accord/txn/TxnDataName.java
index 65b659747f..de672cad2e 100644
--- a/src/java/org/apache/cassandra/service/accord/txn/TxnDataName.java
+++ b/src/java/org/apache/cassandra/service/accord/txn/TxnDataName.java
@@ -90,6 +90,11 @@ public class TxnDataName implements Comparable
return RETURNING;
}
+public static TxnDataName returning(int index)
+{
+return new TxnDataName(Kind.RETURNING,
[cassandra] 13/27: Ninja for CASSANDRA-17719: When AccordCommand.setPartialTxn is called, make sure to update this.kind in order to make tests stable
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit ab1ffc85c325728d75bf8cd3e8d789a8f2b9c503
Author: David Capwell
AuthorDate: Fri Dec 16 11:18:47 2022 -0800
Ninja for CASSANDRA-17719: When AccordCommand.setPartialTxn is called,
make sure to update this.kind in order to make tests stable
---
src/java/org/apache/cassandra/service/accord/AccordCommand.java | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/java/org/apache/cassandra/service/accord/AccordCommand.java
b/src/java/org/apache/cassandra/service/accord/AccordCommand.java
index f27b45bb4c..2b4f36863d 100644
--- a/src/java/org/apache/cassandra/service/accord/AccordCommand.java
+++ b/src/java/org/apache/cassandra/service/accord/AccordCommand.java
@@ -497,6 +497,8 @@ public class AccordCommand extends Command implements
AccordState
public void setPartialTxn(PartialTxn txn)
{
this.partialTxn.set(txn);
+//TODO remove. This was added to fix tests after Partial Replication
was added, this was added for tests
+this.kind.set(txn.kind());
}
@Override
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 25/27: Ninja fix DatabaseDescriptorRefTest
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch cep-15-accord in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 14ba82a7230dc7d094b6129ceccfae685f6e4875 Author: Ariel Weisberg AuthorDate: Mon Jan 23 15:06:05 2023 -0500 Ninja fix DatabaseDescriptorRefTest --- test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java b/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java index 3ee05cf96f..9ef418b492 100644 --- a/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java +++ b/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java @@ -81,6 +81,7 @@ public class DatabaseDescriptorRefTest "org.apache.cassandra.config.Config$DiskOptimizationStrategy", "org.apache.cassandra.config.Config$FlushCompression", "org.apache.cassandra.config.Config$InternodeCompression", +"org.apache.cassandra.config.Config$LegacyPaxosStrategy", "org.apache.cassandra.config.Config$MemtableAllocationType", "org.apache.cassandra.config.Config$PaxosOnLinearizabilityViolation", "org.apache.cassandra.config.Config$PaxosStatePurging", - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 18/27: Ninja: Add AccordTestUtils.parse which was missing in the latest commit
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit f8243f41c9e96c4a0390558086ece078b0b6b15c
Author: David Capwell
AuthorDate: Mon Jan 9 13:20:58 2023 -0800
Ninja: Add AccordTestUtils.parse which was missing in the latest commit
---
.../unit/org/apache/cassandra/service/accord/AccordTestUtils.java | 8
1 file changed, 8 insertions(+)
diff --git a/test/unit/org/apache/cassandra/service/accord/AccordTestUtils.java
b/test/unit/org/apache/cassandra/service/accord/AccordTestUtils.java
index 4adad32d8a..20142c439b 100644
--- a/test/unit/org/apache/cassandra/service/accord/AccordTestUtils.java
+++ b/test/unit/org/apache/cassandra/service/accord/AccordTestUtils.java
@@ -174,6 +174,14 @@ public class AccordTestUtils
return statement.createTxn(ClientState.forInternalCalls(), options);
}
+public static TransactionStatement parse(String query)
+{
+TransactionStatement.Parsed parsed = (TransactionStatement.Parsed)
QueryProcessor.parseStatement(query);
+Assert.assertNotNull(parsed);
+TransactionStatement statement = (TransactionStatement)
parsed.prepare(ClientState.forInternalCalls());
+return statement;
+}
+
public static Txn createTxn(int readKey, int... writeKeys)
{
StringBuilder sb = new StringBuilder("BEGIN TRANSACTION\n");
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 09/27: Ninja for CASSANDRA-17719: Adder/Substraction should return NULL if either the current or the user value are NULL
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 436638c1a55edba06a6737fc528f703f39c76ace
Author: David Capwell
AuthorDate: Mon Dec 12 15:50:29 2022 -0800
Ninja for CASSANDRA-17719: Adder/Substraction should return NULL if either
the current or the user value are NULL
---
src/java/org/apache/cassandra/cql3/Constants.java | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/java/org/apache/cassandra/cql3/Constants.java
b/src/java/org/apache/cassandra/cql3/Constants.java
index 068a04035b..108073d5b2 100644
--- a/src/java/org/apache/cassandra/cql3/Constants.java
+++ b/src/java/org/apache/cassandra/cql3/Constants.java
@@ -536,7 +536,7 @@ public abstract class Constants
@SuppressWarnings("unchecked") NumberType type =
(NumberType) column.type;
ByteBuffer increment = t.bindAndGet(params.options);
if (increment == null)
-throw new InvalidRequestException("Invalid null value for
number increment");
+return;
ByteBuffer current = getCurrentCellBuffer(partitionKey,
params);
if (current == null)
return;
@@ -546,6 +546,8 @@ public abstract class Constants
else if (column.type instanceof StringType)
{
ByteBuffer append = t.bindAndGet(params.options);
+if (append == null)
+return;
ByteBuffer current = getCurrentCellBuffer(partitionKey,
params);
if (current == null)
return;
@@ -590,7 +592,7 @@ public abstract class Constants
NumberType type = (NumberType) column.type;
ByteBuffer bytes = t.bindAndGet(params.options);
if (bytes == null)
-throw new InvalidRequestException("Invalid null value for
number decrement");
+return;
ByteBuffer current = getCurrentCellBuffer(partitionKey,
params);
if (current == null)
return;
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 11/27: Ninja for CASSANDRA-17719: When a reference sees a null, return Constants.NULL_VALUE rather than try to parse it
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit cdc52fac53511d5bcb8a3a8cffe6e109d3ce6bf5
Author: David Capwell
AuthorDate: Mon Dec 12 15:52:20 2022 -0800
Ninja for CASSANDRA-17719: When a reference sees a null, return
Constants.NULL_VALUE rather than try to parse it
---
.../org/apache/cassandra/service/accord/txn/TxnReferenceOperation.java | 2 ++
src/java/org/apache/cassandra/service/accord/txn/TxnReferenceValue.java | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git
a/src/java/org/apache/cassandra/service/accord/txn/TxnReferenceOperation.java
b/src/java/org/apache/cassandra/service/accord/txn/TxnReferenceOperation.java
index 9ab0194e96..695b920d91 100644
---
a/src/java/org/apache/cassandra/service/accord/txn/TxnReferenceOperation.java
+++
b/src/java/org/apache/cassandra/service/accord/txn/TxnReferenceOperation.java
@@ -238,6 +238,8 @@ public class TxnReferenceOperation
private Term toTerm(TxnData data, AbstractType receivingType,
ProtocolVersion version)
{
ByteBuffer bytes = value.compute(data, receivingType);
+if (bytes == null)
+return Constants.NULL_VALUE;
return toTerm(bytes, receivingType, version);
}
diff --git
a/src/java/org/apache/cassandra/service/accord/txn/TxnReferenceValue.java
b/src/java/org/apache/cassandra/service/accord/txn/TxnReferenceValue.java
index 1041968458..fb4a54f8d5 100644
--- a/src/java/org/apache/cassandra/service/accord/txn/TxnReferenceValue.java
+++ b/src/java/org/apache/cassandra/service/accord/txn/TxnReferenceValue.java
@@ -89,7 +89,7 @@ public abstract class TxnReferenceValue
@Override
public String toString()
{
-return ByteBufferUtil.bytesToHex(value);
+return "Constant=" + ByteBufferUtil.bytesToHex(value);
}
@Override
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 12/27: Ninja for CASSANDRA-17719: TransactionStatement now logs every exception, will revert before trunk but needed for debugging
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 3af82af9cb838fa58f78aabf567d60896ce6de45
Author: David Capwell
AuthorDate: Tue Dec 13 12:05:30 2022 -0800
Ninja for CASSANDRA-17719: TransactionStatement now logs every exception,
will revert before trunk but needed for debugging
---
.../cql3/statements/TransactionStatement.java | 85 +-
1 file changed, 49 insertions(+), 36 deletions(-)
diff --git
a/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
b/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
index 064c6abf83..baead627dc 100644
--- a/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
+++ b/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
@@ -37,6 +37,9 @@ import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Preconditions;
import com.google.common.collect.Iterables;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import accord.api.Key;
import accord.primitives.Keys;
import accord.primitives.Txn;
@@ -81,6 +84,8 @@ import static
org.apache.cassandra.utils.Clock.Global.nanoTime;
public class TransactionStatement implements CQLStatement
{
+private static final Logger logger =
LoggerFactory.getLogger(TransactionStatement.class);
+
public static final String DUPLICATE_TUPLE_NAME_MESSAGE = "The name '%s'
has already been used by a LET assignment.";
public static final String INCOMPLETE_PRIMARY_KEY_LET_MESSAGE = "SELECT in
LET assignment without LIMIT 1 must specify all primary key elements; CQL %s";
public static final String INCOMPLETE_PRIMARY_KEY_SELECT_MESSAGE = "Normal
SELECT without LIMIT 1 must specify all primary key elements; CQL %s";
@@ -292,52 +297,60 @@ public class TransactionStatement implements CQLStatement
@Override
public ResultMessage execute(QueryState state, QueryOptions options, long
queryStartNanoTime)
{
-for (NamedSelect assignment : assignments)
-checkAtMostOneRowSpecified(state.getClientState(), options,
assignment.select, INCOMPLETE_PRIMARY_KEY_LET_MESSAGE);
+try
+{
+for (NamedSelect assignment : assignments)
+checkAtMostOneRowSpecified(state.getClientState(), options,
assignment.select, INCOMPLETE_PRIMARY_KEY_LET_MESSAGE);
-if (returningSelect != null)
-checkAtMostOneRowSpecified(state.getClientState(), options,
returningSelect.select, INCOMPLETE_PRIMARY_KEY_SELECT_MESSAGE);
+if (returningSelect != null)
+checkAtMostOneRowSpecified(state.getClientState(), options,
returningSelect.select, INCOMPLETE_PRIMARY_KEY_SELECT_MESSAGE);
-TxnData data =
AccordService.instance().coordinate(createTxn(state.getClientState(), options),
options);
-
-if (returningSelect != null)
-{
-FilteredPartition partition = data.get(TxnDataName.returning());
-Selection.Selectors selectors =
returningSelect.select.getSelection().newSelectors(options);
-ResultSetBuilder result = new
ResultSetBuilder(returningSelect.select.getResultMetadata(), selectors, null);
-returningSelect.select.processPartition(partition.rowIterator(),
options, result, FBUtilities.nowInSeconds());
-return new ResultMessage.Rows(result.build());
-}
-
-if (returningReferences != null)
-{
-List names = new
ArrayList<>(returningReferences.size());
-List columns = new
ArrayList<>(returningReferences.size());
+TxnData data =
AccordService.instance().coordinate(createTxn(state.getClientState(), options),
options);
-for (RowDataReference reference : returningReferences)
+if (returningSelect != null)
{
-ColumnMetadata forMetadata = reference.toResultMetadata();
-names.add(forMetadata);
-columns.add(reference.column());
+FilteredPartition partition =
data.get(TxnDataName.returning());
+Selection.Selectors selectors =
returningSelect.select.getSelection().newSelectors(options);
+ResultSetBuilder result = new
ResultSetBuilder(returningSelect.select.getResultMetadata(), selectors, null);
+
returningSelect.select.processPartition(partition.rowIterator(), options,
result, FBUtilities.nowInSeconds());
+return new ResultMessage.Rows(result.build());
}
-ResultSetBuilder result = new ResultSetBuilder(new
ResultSet.ResultMetadata(names), Selection.noopSelector(), null);
-result.newRow(options.getProtocolVersion(), null, null, columns);
-
-for (int i = 0; i < returningReferences.size(); i++)
+
[cassandra] 21/27: Shard local CommandStores on contiguous ranges
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit f9f2d93447add98dc4784a331310245138312183
Author: Benedict Elliott Smith
AuthorDate: Sun Jan 8 22:06:38 2023 +
Shard local CommandStores on contiguous ranges
patch by Benedict; reviewed by Aleksey Yeschenko for CASSANDRA-18142
---
.build/include-accord.sh | 2 +-
.../cassandra/db/marshal/ByteArrayAccessor.java| 2 +
.../apache/cassandra/dht/AccordBytesSplitter.java | 89
.../org/apache/cassandra/dht/AccordSplitter.java | 103
.../cassandra/dht/ByteOrderedPartitioner.java | 8 +
.../org/apache/cassandra/dht/IPartitioner.java | 3 +
.../org/apache/cassandra/dht/LocalPartitioner.java | 8 +
.../apache/cassandra/dht/Murmur3Partitioner.java | 22 +
.../cassandra/dht/OrderPreservingPartitioner.java | 65 ++-
.../apache/cassandra/dht/RandomPartitioner.java| 20 +
src/java/org/apache/cassandra/dht/Splitter.java| 8 +-
src/java/org/apache/cassandra/schema/TableId.java | 2 +-
.../cassandra/service/accord/AccordCommand.java| 16 +-
.../service/accord/AccordCommandStore.java | 516 +++--
.../service/accord/AccordCommandStores.java| 51 +-
.../cassandra/service/accord/AccordKeyspace.java | 22 +-
.../service/accord/AccordObjectSizes.java | 3 +-
.../service/accord/AccordSerializers.java | 2 +-
.../cassandra/service/accord/AccordService.java| 6 +
.../service/accord/AccordTopologyUtils.java| 52 +--
.../cassandra/service/accord/ListenerProxy.java| 9 +-
.../cassandra/service/accord/TokenRange.java | 5 +-
.../service/accord/api/AccordRoutableKey.java | 36 +-
.../service/accord/api/AccordRoutingKey.java | 105 +++--
.../cassandra/service/accord/api/PartitionKey.java | 26 +-
.../service/accord/async/AsyncOperation.java | 4 +-
.../cassandra/service/accord/txn/TxnData.java | 17 +-
.../cassandra/service/accord/txn/TxnNamedRead.java | 2 +-
.../cassandra/service/accord/txn/TxnUpdate.java| 2 +-
.../cassandra/dht/ByteOrderedPartitionerTest.java | 16 +
.../apache/cassandra/dht/LengthPartitioner.java| 34 +-
.../dht/OrderPreservingPartitionerTest.java| 20 +-
.../apache/cassandra/dht/PartitionerTestCase.java | 115 +
.../service/accord/AccordCommandTest.java | 7 +-
.../cassandra/service/accord/AccordTestUtils.java | 81 +---
.../service/accord/AccordTopologyTest.java | 4 +-
.../service/accord/api/AccordKeyTest.java | 40 +-
.../service/accord/async/AsyncOperationTest.java | 4 +-
.../accord/serializers/CommandSerializersTest.java | 5 +-
.../service/accord/txn/AbstractKeySortedTest.java | 2 +-
40 files changed, 1005 insertions(+), 529 deletions(-)
diff --git a/.build/include-accord.sh b/.build/include-accord.sh
index b1409603fb..37bdcbe079 100755
--- a/.build/include-accord.sh
+++ b/.build/include-accord.sh
@@ -25,7 +25,7 @@ set -o nounset
bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
accord_repo='https://github.com/apache/cassandra-accord.git'
-accord_branch='63c37e20cfe66a421c1b07ba1f430a9e6aabe4c5'
+accord_branch='804a77d32c8ae45751a3a7f450b372560f08cacc'
accord_src="$bin/cassandra-accord"
checkout() {
diff --git a/src/java/org/apache/cassandra/db/marshal/ByteArrayAccessor.java
b/src/java/org/apache/cassandra/db/marshal/ByteArrayAccessor.java
index d7108992da..4926027a7b 100644
--- a/src/java/org/apache/cassandra/db/marshal/ByteArrayAccessor.java
+++ b/src/java/org/apache/cassandra/db/marshal/ByteArrayAccessor.java
@@ -25,6 +25,7 @@ import java.nio.charset.Charset;
import java.util.Arrays;
import java.util.UUID;
+import accord.utils.Invariants;
import org.apache.cassandra.db.Digest;
import org.apache.cassandra.db.TypeSizes;
import org.apache.cassandra.io.util.DataInputPlus;
@@ -107,6 +108,7 @@ public class ByteArrayAccessor implements
ValueAccessor
@Override
public byte[] slice(byte[] input, int offset, int length)
{
+Invariants.checkArgument(offset + length <= input.length);
return Arrays.copyOfRange(input, offset, offset + length);
}
diff --git a/src/java/org/apache/cassandra/dht/AccordBytesSplitter.java
b/src/java/org/apache/cassandra/dht/AccordBytesSplitter.java
new file mode 100644
index 00..c27bc43599
--- /dev/null
+++ b/src/java/org/apache/cassandra/dht/AccordBytesSplitter.java
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the
[cassandra] 17/27: Refactor AccordTestBase to block retries on non-idempotent transactions. Some tests may be flaky now due to Preempted being thrown.
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 237208e850ae384c32558cf1da7cc1854ef25444
Author: David Capwell
AuthorDate: Mon Dec 19 16:07:20 2022 -0800
Refactor AccordTestBase to block retries on non-idempotent transactions.
Some tests may be flaky now due to Preempted being thrown.
---
.../cql3/statements/ModificationStatement.java | 12
.../cql3/statements/TransactionStatement.java | 5 ++
.../cql3/transactions/ReferenceOperation.java | 10 +++
.../distributed/test/accord/AccordCQLTest.java | 10 +--
.../distributed/test/accord/AccordTestBase.java| 71 --
5 files changed, 97 insertions(+), 11 deletions(-)
diff --git
a/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java
b/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java
index abf393f811..41ae242cf9 100644
--- a/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java
+++ b/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java
@@ -809,6 +809,18 @@ public abstract class ModificationStatement implements
CQLStatement.SingleKeyspa
return new TxnReferenceOperations(metadata, clustering, regularOps,
staticOps);
}
+@VisibleForTesting
+public void migrateReadRequiredOperations()
+{
+operations.migrateReadRequiredOperations();
+}
+
+@VisibleForTesting
+public List getSubstitutions()
+{
+return operations.allSubstitutions();
+}
+
public TxnWrite.Fragment getTxnWriteFragment(int index, ClientState state,
QueryOptions options)
{
// When an Operation requires a read, this cannot be done right away
and must be done by the transaction itself,
diff --git
a/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
b/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
index baead627dc..4d3c732da0 100644
--- a/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
+++ b/src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java
@@ -131,6 +131,11 @@ public class TransactionStatement implements CQLStatement
this.bindVariables = bindVariables;
}
+public List getUpdates()
+{
+return updates;
+}
+
@Override
public List getBindVariables()
{
diff --git
a/src/java/org/apache/cassandra/cql3/transactions/ReferenceOperation.java
b/src/java/org/apache/cassandra/cql3/transactions/ReferenceOperation.java
index e89e616545..d4858eec8e 100644
--- a/src/java/org/apache/cassandra/cql3/transactions/ReferenceOperation.java
+++ b/src/java/org/apache/cassandra/cql3/transactions/ReferenceOperation.java
@@ -76,6 +76,16 @@ public class ReferenceOperation
return new ReferenceOperation(receiver, kind, key, field, value);
}
+public TxnReferenceOperation.Kind getKind()
+{
+return kind;
+}
+
+public ReferenceValue getValue()
+{
+return value;
+}
+
public ColumnMetadata getReceiver()
{
return receiver;
diff --git
a/test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTest.java
b/test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTest.java
index 50318a00d1..1315bed14f 100644
---
a/test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTest.java
@@ -400,7 +400,7 @@ public class AccordCQLTest extends AccordTestBase
" SELECT row1.v;\n" +
" UPDATE " + currentTable + " SET v " +
operation + " 1 WHERE k = 1;\n" +
"COMMIT TRANSACTION";
- assertRowEqualsWithPreemptedRetry(cluster, new Object[] {
startingValue }, update);
+ assertRowEquals(cluster, new Object[] { startingValue },
update);
String check = "BEGIN TRANSACTION\n" +
" SELECT v FROM " + currentTable + " WHERE k
= 1;\n" +
@@ -1424,7 +1424,7 @@ public class AccordCQLTest extends AccordTestBase
" SELECT row0.counter,
row0.other_counter;\n" +
" UPDATE " + currentTable + " SET
other_counter += 1, counter += row0.counter WHERE k = 0 AND c = 1;\n" +
"COMMIT TRANSACTION";
- assertRowEqualsWithPreemptedRetry(cluster, new Object[] { 1,
1 }, update);
+ assertRowEquals(cluster, new Object[] { 1, 1 }, update);
String check = "BEGIN TRANSACTION\n" +
" SELECT counter, other_counter FROM " +
currentTable + " WHERE k = 0 AND c = 1;\n" +
@@ -1448,7 +1448,7 @@ public class AccordCQLTest extends
[cassandra] 14/27: Ninja for CASSANDRA-17719: Changed AsyncWriterTest#commandsPerKeyDenormalization to use SaveStatus rather than Status
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch cep-15-accord in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 7055f4d9e34577f775e555c74b570280176b1955 Author: David Capwell AuthorDate: Fri Dec 16 12:46:57 2022 -0800 Ninja for CASSANDRA-17719: Changed AsyncWriterTest#commandsPerKeyDenormalization to use SaveStatus rather than Status --- .../org/apache/cassandra/service/accord/async/AsyncWriterTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/unit/org/apache/cassandra/service/accord/async/AsyncWriterTest.java b/test/unit/org/apache/cassandra/service/accord/async/AsyncWriterTest.java index 9d2e1e5a2b..3e148498ce 100644 --- a/test/unit/org/apache/cassandra/service/accord/async/AsyncWriterTest.java +++ b/test/unit/org/apache/cassandra/service/accord/async/AsyncWriterTest.java @@ -26,6 +26,7 @@ import org.junit.BeforeClass; import org.junit.Test; import accord.local.Command; +import accord.local.SaveStatus; import accord.local.Status; import accord.primitives.Ranges; import accord.primitives.Timestamp; @@ -147,7 +148,7 @@ public class AsyncWriterTest AccordCommand command = new AccordCommand(txnId).initialize(); command.setPartialTxn(txn.slice(ranges, true)); command.setExecuteAt(executeAt); -command.setStatus(Status.Accepted); +command.setSaveStatus(SaveStatus.AcceptedWithDefinition); AsyncContext context = new AsyncContext(); context.commands.add(command); save(commandStore, context); - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-15-accord updated (0ddfbbdeee -> c7fd7cbc53)
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a change to branch cep-15-accord in repository https://gitbox.apache.org/repos/asf/cassandra.git discard 0ddfbbdeee CASSANDRA-18154: CEP-15: Enhance returning SELECT to allow partition and clustering IN clauses to return multiple partitions/rows discard 56d7e69143 Ninja fix DatabaseDescriptorRefTest omit a3ccd4d93d Support CAS and serial read on Accord omit 47accb9e17 ninja fix CASSANDRA-18142: System.distributedKeyspaces is unsorted omit 722ba2e7c6 Refactor Timestamp/TxnId - Combine real and logical into a single 64-but HLC - Introduce 16 flag bits - Pack epoch (48-bits), HLC (64-bits) and flags (16-bits) into two longs in memory omit 1315eb7700 Shard local CommandStores on contiguous ranges omit 46d10778da CEP-15: (C*) Enhance returning SELECT to allow partition and clustering IN clauses to return multiple partitions/rows omit d6bd2401e9 ninja: pick a cassandra-accord SHA to build against to decouple source trees omit 62f895adcf Ninja: Add AccordTestUtils.parse which was missing in the latest commit omit 8d8283b909 Refactor AccordTestBase to block retries on non-idempotent transactions. Some tests may be flaky now due to Preempted being thrown. omit 0f4c6cec28 Ninja for CASSANDRA-17719: accord.primitives.Range#someIntersectingRoutingKey was added but does not work in all cases in C* due to sentinal values, added logic to return a C* friendly token omit 82947c3d58 Ninja for CASSANDRA-17719 disable the checks in increaseSlightly and decreaseSlightly to get back to the old behavior for now omit 74602f5734 Ninja for CASSANDRA-17719: Changed AsyncWriterTest#commandsPerKeyDenormalization to use SaveStatus rather than Status omit 31d5d73b32 Ninja for CASSANDRA-17719: When AccordCommand.setPartialTxn is called, make sure to update this.kind in order to make tests stable omit aac0fe0ff6 Ninja for CASSANDRA-17719: TransactionStatement now logs every exception, will revert before trunk but needed for debugging omit 80a8dc69ef Ninja for CASSANDRA-17719: When a reference sees a null, return Constants.NULL_VALUE rather than try to parse it omit 6a1b857ef5 Ninja for CASSANDRA-17719: Add @Simulate(with = MONITORS) to MultiReadFuture to get simulator working omit 5509a1bfb6 Ninja for CASSANDRA-17719: Adder/Substraction should return NULL if either the current or the user value are NULL omit 33f670bab6 CEP-15: Multi-Partition Transaction CQL Support (Alpha) omit aef9979502 CEP-15: Routables - Integrate accord-core changes for CASSANDRA-18087 omit a5fd6b3bbb Invalidation fixes/improvements - Integrate accord-core changes for CASSANDRA-18057 omit 822bff2c72 Refactor response tracking to improve efficiency and clarity; introduce dedicated property tests; re-activate fast-path during range movements omit 9368684e5c Transaction Expiration omit c3514ce877 Partial Replication of Transaction State omit 83a5f7a69d Command table now uses a local version added to the payload rather than rely on a version column, and fixed a few feedback related issues omit e6cbeb39e0 CEP-15 (C*): Messaging and storage engine integration add 377e114cb1 Introduce compaction priorities to prevent upgrade compaction inability to finish add c56952efb5 HintedHandoffAddRemoveNodesTest now accounts for the fact that StorageMetrics.totalHints is not updated synchronously w/ writes add adb0128485 Merge branch 'cassandra-4.0' into cassandra-4.1 add 97a5ff9925 Merge branch 'cassandra-4.1' into trunk add b6d8e2ce6b Make disabling auto snapshot on selected tables possible add d6aee7e08c Optionally avoid hint transfer during decommission add 49cd4b5f79 Fix PaxosRepairTest#paxosRepairVersionGate add 703ccdee29 Merge branch cassandra-4.1 into trunk add 51944c5e68 Make sure preview repairs don't optimise streams unless configured to add ac25d6929e Better handle null state in Gossip schema migration to avoid NPE add 3f46c7d88b Merge branch 'cassandra-4.0' into cassandra-4.1 add 9355e70eaf Merge branch 'cassandra-4.1' into trunk add f65f123780 Prevent flakiness in MixedModeMessageForwardTest add 67e9f7bdc4 Merge branch 'cassandra-4.0' into cassandra-4.1 add e73b7ba2c0 Merge branch 'cassandra-4.1' into trunk add f77e6cd3a0 Remove usage of deprecated javax certificate class add 76be530a36 Fix schema reset functionality add d8bbeb9e39 Merge branch 'cassandra-4.0' into cassandra-4.1 add 56ea39ec70 Merge branch 'cassandra-4.1' into trunk add bd2ecb3454 Add metrics around storage usage and compression add ff5f4833aa Prevent NullPointerException when changing neverPurgeTombstones from true to false add e89b214d06 Allow disabling hotness persistence for high sstable counts add 4c85c6a403 key_cache_save_period, row_cache_save_period,
[cassandra] 23/27: ninja fix CASSANDRA-18142: System.distributedKeyspaces is unsorted
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit ac8d9b343a05c31b94e540b9954ccdf021b97aac
Author: Benedict Elliott Smith
AuthorDate: Thu Jan 19 20:50:11 2023 +
ninja fix CASSANDRA-18142: System.distributedKeyspaces is unsorted
---
.../org/apache/cassandra/service/accord/AccordTopologyUtils.java | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
a/src/java/org/apache/cassandra/service/accord/AccordTopologyUtils.java
b/src/java/org/apache/cassandra/service/accord/AccordTopologyUtils.java
index bc6ec7e7b6..2c56f56b14 100644
--- a/src/java/org/apache/cassandra/service/accord/AccordTopologyUtils.java
+++ b/src/java/org/apache/cassandra/service/accord/AccordTopologyUtils.java
@@ -97,11 +97,12 @@ public class AccordTopologyUtils
public static Topology createTopology(long epoch)
{
TokenMetadata tokenMetadata =
StorageService.instance.getTokenMetadata();
+List keyspaces = new
ArrayList<>(Schema.instance.distributedKeyspaces().names());
+keyspaces.sort(String::compareTo);
+
List shards = new ArrayList<>();
-for (String keyspace : Schema.instance.distributedKeyspaces().names())
-{
+for (String keyspace : keyspaces)
shards.addAll(createShards(keyspace, tokenMetadata));
-}
return new Topology(epoch, shards.toArray(new Shard[0]));
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 04/27: Transaction Expiration
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit b3c07040b845576b9ee9cefad1226d2acac5987d
Author: Benedict Elliott Smith
AuthorDate: Tue Nov 8 10:21:19 2022 +
Transaction Expiration
Ensure old or abandoned transactions are invalidated wherever possible.
patch by Benedict; reviewed by Ariel Weisberg for CASSANDRA-18041
---
.../cassandra/service/accord/AccordCommandStore.java | 16 ++--
.../apache/cassandra/service/accord/api/AccordAgent.java | 8
.../apache/cassandra/service/accord/AccordTestUtils.java | 2 ++
3 files changed, 20 insertions(+), 6 deletions(-)
diff --git
a/src/java/org/apache/cassandra/service/accord/AccordCommandStore.java
b/src/java/org/apache/cassandra/service/accord/AccordCommandStore.java
index 227efdf738..12b84a40c4 100644
--- a/src/java/org/apache/cassandra/service/accord/AccordCommandStore.java
+++ b/src/java/org/apache/cassandra/service/accord/AccordCommandStore.java
@@ -266,12 +266,6 @@ public class AccordCommandStore extends CommandStore
implements SafeCommandStore
return dataStore;
}
-@Override
-public Timestamp uniqueNow(Timestamp atLeast)
-{
-return time.uniqueNow(atLeast);
-}
-
public void processBlocking(Runnable runnable)
{
try
@@ -321,6 +315,16 @@ public class AccordCommandStore extends CommandStore
implements SafeCommandStore
}
@Override
+public Timestamp preaccept(TxnId txnId, Keys keys)
+{
+Timestamp max = maxConflict(keys);
+long epoch = latestEpoch();
+if (txnId.compareTo(max) > 0 && txnId.epoch >= epoch &&
!agent.isExpired(txnId, time.now()))
+return txnId;
+
+return time.uniqueNow(max);
+}
+
public Timestamp maxConflict(Keys keys)
{
// TODO: efficiency
diff --git a/src/java/org/apache/cassandra/service/accord/api/AccordAgent.java
b/src/java/org/apache/cassandra/service/accord/api/AccordAgent.java
index 8ed2c5ea24..6375bdc7b9 100644
--- a/src/java/org/apache/cassandra/service/accord/api/AccordAgent.java
+++ b/src/java/org/apache/cassandra/service/accord/api/AccordAgent.java
@@ -23,6 +23,7 @@ import accord.api.Result;
import accord.local.Command;
import accord.local.Node;
import accord.primitives.Timestamp;
+import accord.primitives.TxnId;
public class AccordAgent implements Agent
{
@@ -49,4 +50,11 @@ public class AccordAgent implements Agent
{
// TODO: this
}
+
+@Override
+public boolean isExpired(TxnId initiated, long now)
+{
+// TODO: this
+return false;
+}
}
diff --git a/test/unit/org/apache/cassandra/service/accord/AccordTestUtils.java
b/test/unit/org/apache/cassandra/service/accord/AccordTestUtils.java
index 2219a89b09..ad74eaa467 100644
--- a/test/unit/org/apache/cassandra/service/accord/AccordTestUtils.java
+++ b/test/unit/org/apache/cassandra/service/accord/AccordTestUtils.java
@@ -241,6 +241,7 @@ public class AccordTestUtils
{
@Override public Id id() { return node;}
@Override public long epoch() {return 1; }
+@Override public long now() {return now.getAsLong(); }
@Override public Timestamp uniqueNow(Timestamp atLeast) { return
new Timestamp(1, now.getAsLong(), 0, node); }
};
return new InMemoryCommandStore.Synchronized(0, 0, 1, 8,
@@ -262,6 +263,7 @@ public class AccordTestUtils
{
@Override public Id id() { return node;}
@Override public long epoch() {return 1; }
+@Override public long now() {return now.getAsLong(); }
@Override public Timestamp uniqueNow(Timestamp atLeast) { return
new Timestamp(1, now.getAsLong(), 0, node); }
};
return new AccordCommandStore(0, 0, 0, 1,
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 16/27: Ninja for CASSANDRA-17719: accord.primitives.Range#someIntersectingRoutingKey was added but does not work in all cases in C* due to sentinal values, added logic to return a C* frien
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 771a1a69137785b34ba93df81c612cff11a471c8
Author: David Capwell
AuthorDate: Mon Dec 19 13:03:41 2022 -0800
Ninja for CASSANDRA-17719:
accord.primitives.Range#someIntersectingRoutingKey was added but does not work
in all cases in C* due to sentinal values, added logic to return a C* friendly
token
---
.../cassandra/service/accord/TokenRange.java | 9 +
.../service/accord/api/AccordRoutingKey.java | 9 +
.../distributed/test/accord/AccordCQLTest.java | 154 +++
.../test/accord/AccordIntegrationTest.java | 208 -
.../distributed/test/accord/AccordTestBase.java| 10 +-
5 files changed, 181 insertions(+), 209 deletions(-)
diff --git a/src/java/org/apache/cassandra/service/accord/TokenRange.java
b/src/java/org/apache/cassandra/service/accord/TokenRange.java
index 22683d4b8e..7fb1ca8f34 100644
--- a/src/java/org/apache/cassandra/service/accord/TokenRange.java
+++ b/src/java/org/apache/cassandra/service/accord/TokenRange.java
@@ -47,6 +47,15 @@ public class TokenRange extends Range.EndInclusive
return new TokenRange((AccordRoutingKey) start, (AccordRoutingKey)
end);
}
+@Override
+public RoutingKey someIntersectingRoutingKey()
+{
+RoutingKey pick = startInclusive() ? start() : end();
+if (pick instanceof SentinelKey)
+pick = ((SentinelKey) pick).toTokenKey();
+return pick;
+}
+
public static final IVersionedSerializer serializer = new
IVersionedSerializer()
{
@Override
diff --git
a/src/java/org/apache/cassandra/service/accord/api/AccordRoutingKey.java
b/src/java/org/apache/cassandra/service/accord/api/AccordRoutingKey.java
index 055658a503..e9c600ae4a 100644
--- a/src/java/org/apache/cassandra/service/accord/api/AccordRoutingKey.java
+++ b/src/java/org/apache/cassandra/service/accord/api/AccordRoutingKey.java
@@ -25,6 +25,7 @@ import accord.api.Key;
import accord.api.RoutingKey;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.db.TypeSizes;
+import org.apache.cassandra.dht.IPartitioner;
import org.apache.cassandra.dht.Token;
import org.apache.cassandra.io.IVersionedSerializer;
import org.apache.cassandra.io.util.DataInputPlus;
@@ -95,6 +96,14 @@ public abstract class AccordRoutingKey extends
AccordRoutableKey implements Rout
return new SentinelKey(tableId, false);
}
+public TokenKey toTokenKey()
+{
+IPartitioner partitioner = DatabaseDescriptor.getPartitioner();
+return new TokenKey(tableId, isMin ?
+
partitioner.getMinimumToken().increaseSlightly() :
+
partitioner.getMaximumToken().decreaseSlightly());
+}
+
@Override
public Token token()
{
diff --git
a/test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTest.java
b/test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTest.java
index 1909fb69fb..50318a00d1 100644
---
a/test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTest.java
@@ -24,16 +24,25 @@ import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.Set;
+import java.util.stream.Collectors;
+import java.util.stream.StreamSupport;
+import com.google.common.base.Splitter;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
+
+import accord.primitives.Unseekables;
+import accord.topology.Topologies;
import org.apache.cassandra.cql3.functions.types.utils.Bytes;
import org.apache.cassandra.db.marshal.Int32Type;
import org.apache.cassandra.db.marshal.ListType;
import org.apache.cassandra.db.marshal.MapType;
import org.apache.cassandra.db.marshal.SetType;
import org.apache.cassandra.db.marshal.UTF8Type;
+import org.apache.cassandra.dht.Murmur3Partitioner;
+import org.apache.cassandra.service.accord.AccordTestUtils;
+import org.apache.cassandra.utils.ByteBufferUtil;
import org.assertj.core.api.Assertions;
import org.junit.BeforeClass;
import org.junit.Ignore;
@@ -68,6 +77,67 @@ public class AccordCQLTest extends AccordTestBase
SHARED_CLUSTER.schemaChange("CREATE TYPE " + KEYSPACE + ".person
(height int, age int)");
}
+@Test
+public void testMultipleShards() throws Exception
+{
+String keyspace = "multipleShards";
+String currentTable = keyspace + ".tbl";
+List ddls = Arrays.asList("CREATE KEYSPACE " + keyspace + "
WITH REPLICATION={'class':'SimpleStrategy', 'replication_factor': 1}",
+
[cassandra] 05/27: Refactor response tracking to improve efficiency and clarity; introduce dedicated property tests; re-activate fast-path during range movements
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 559973c65e83faba04e430cd5d90a465c4e1a113
Author: Benedict Elliott Smith
AuthorDate: Mon Nov 28 16:07:26 2022 +
Refactor response tracking to improve efficiency and clarity; introduce
dedicated property tests; re-activate fast-path during range movements
patch by Benedict; reviewed by Ariel Weisberg for CASSANDRA-18056
---
src/java/org/apache/cassandra/service/accord/AccordService.java| 2 ++
.../service/accord/serializers/BeginInvalidationSerializers.java | 7 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/java/org/apache/cassandra/service/accord/AccordService.java
b/src/java/org/apache/cassandra/service/accord/AccordService.java
index 02c62510b6..1400d6e2f1 100644
--- a/src/java/org/apache/cassandra/service/accord/AccordService.java
+++ b/src/java/org/apache/cassandra/service/accord/AccordService.java
@@ -26,6 +26,7 @@ import java.util.concurrent.TimeoutException;
import com.google.common.annotations.VisibleForTesting;
import accord.impl.SimpleProgressLog;
+import accord.impl.SizeOfIntersectionSorter;
import accord.local.Node;
import accord.messages.Reply;
import accord.messages.Request;
@@ -75,6 +76,7 @@ public class AccordService implements Shutdownable
new AccordAgent(),
new Random(),
scheduler,
+ SizeOfIntersectionSorter.SUPPLIER,
SimpleProgressLog::new,
AccordCommandStores::new);
this.nodeShutdown = toShutdownable(node);
diff --git
a/src/java/org/apache/cassandra/service/accord/serializers/BeginInvalidationSerializers.java
b/src/java/org/apache/cassandra/service/accord/serializers/BeginInvalidationSerializers.java
index 9596761f35..d4ebe727f9 100644
---
a/src/java/org/apache/cassandra/service/accord/serializers/BeginInvalidationSerializers.java
+++
b/src/java/org/apache/cassandra/service/accord/serializers/BeginInvalidationSerializers.java
@@ -21,6 +21,7 @@ package org.apache.cassandra.service.accord.serializers;
import java.io.IOException;
import accord.api.RoutingKey;
+import accord.local.SaveStatus;
import accord.local.Status;
import accord.messages.BeginInvalidation;
import accord.messages.BeginInvalidation.InvalidateNack;
@@ -70,14 +71,14 @@ public class BeginInvalidationSerializers
{
void serializeOk(InvalidateOk ok, DataOutputPlus out, int version)
throws IOException
{
-CommandSerializers.status.serialize(ok.status, out, version);
+CommandSerializers.saveStatus.serialize(ok.status, out, version);
serializeNullable(KeySerializers.abstractRoute, ok.route, out,
version);
serializeNullable(KeySerializers.routingKey, ok.homeKey, out,
version);
}
InvalidateOk deserializeOk(DataInputPlus in, int version) throws
IOException
{
-Status status = CommandSerializers.status.deserialize(in, version);
+SaveStatus status = CommandSerializers.saveStatus.deserialize(in,
version);
AbstractRoute route =
deserializeNullable(KeySerializers.abstractRoute, in, version);
RoutingKey homeKey =
deserializeNullable(KeySerializers.routingKey, in, version);
return new InvalidateOk(status, route, homeKey);
@@ -85,7 +86,7 @@ public class BeginInvalidationSerializers
long serializedOkSize(InvalidateOk ok, int version)
{
-return CommandSerializers.status.serializedSize(ok.status, version)
+return CommandSerializers.saveStatus.serializedSize(ok.status,
version)
+ serializedSizeNullable(KeySerializers.abstractRoute,
ok.route, version)
+ serializedSizeNullable(KeySerializers.routingKey,
ok.homeKey, version);
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 06/27: Invalidation fixes/improvements - Integrate accord-core changes for CASSANDRA-18057
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit f0cc5bf357511fe56f3906f69d64fadce3e7b0e6
Author: Benedict Elliott Smith
AuthorDate: Mon Nov 21 12:22:38 2022 +
Invalidation fixes/improvements
- Integrate accord-core changes for CASSANDRA-18057
patch by Benedict; reviewed by Ariel Weisberg for CASSANDRA-18057
---
.build/include-accord.sh | 4 +-
.../cassandra/service/accord/AccordCommand.java| 31 +++--
.../service/accord/AccordCommandStore.java | 6 ++
.../cassandra/service/accord/AccordKeyspace.java | 11 ++-
.../service/accord/AccordPartialCommand.java | 4 +-
.../service/accord/async/AsyncWriter.java | 5 +-
.../accord/serializers/AcceptSerializers.java | 32 +
.../serializers/BeginInvalidationSerializers.java | 81 ++
.../service/accord/AccordCommandTest.java | 3 +-
.../service/accord/async/AsyncWriterTest.java | 6 +-
10 files changed, 96 insertions(+), 87 deletions(-)
diff --git a/.build/include-accord.sh b/.build/include-accord.sh
index 0dc01bf2ba..ea1e0544df 100755
--- a/.build/include-accord.sh
+++ b/.build/include-accord.sh
@@ -24,8 +24,8 @@ set -o nounset
bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
-accord_repo='https://github.com/apache/cassandra-accord.git'
-accord_branch='trunk'
+accord_repo='https://github.com/belliottsmith/cassandra-accord.git'
+accord_branch='bugfix-invalidation'
accord_src="$bin/cassandra-accord"
checkout() {
diff --git a/src/java/org/apache/cassandra/service/accord/AccordCommand.java
b/src/java/org/apache/cassandra/service/accord/AccordCommand.java
index e7e526495f..45885f657d 100644
--- a/src/java/org/apache/cassandra/service/accord/AccordCommand.java
+++ b/src/java/org/apache/cassandra/service/accord/AccordCommand.java
@@ -18,11 +18,14 @@
package org.apache.cassandra.service.accord;
+import java.util.Map;
import java.util.Objects;
import java.util.TreeMap;
import java.util.TreeSet;
import java.util.concurrent.atomic.AtomicInteger;
+import javax.annotation.Nullable;
+
import com.google.common.base.Preconditions;
import org.slf4j.Logger;
@@ -115,6 +118,7 @@ public class AccordCommand extends Command implements
AccordState
public final StoredValue homeKey;
public final StoredValue progressKey;
public final StoredValue partialTxn;
+public final StoredValue kind; // TODO: store this in TxnId
public final StoredValue promised;
public final StoredValue accepted;
public final StoredValue executeAt;
@@ -141,6 +145,7 @@ public class AccordCommand extends Command implements
AccordState
progressKey = new StoredValue<>(rw());
route = new StoredValue<>(rw());
partialTxn = new StoredValue<>(rw());
+kind = new StoredValue<>(rw());
promised = new StoredValue<>(rw());
accepted = new StoredValue<>(rw());
executeAt = new StoredValue<>(rw());
@@ -235,6 +240,7 @@ public class AccordCommand extends Command implements
AccordState
progressKey.set(null);
route.set(null);
partialTxn.set(null);
+kind.set(null);
executeAt.load(null);
promised.set(Ballot.ZERO);
accepted.set(Ballot.ZERO);
@@ -525,7 +531,13 @@ public class AccordCommand extends Command implements
AccordState
@Override
public Txn.Kind kind()
{
-return partialTxn.get().kind();
+return kind.get();
+}
+
+@Override
+public void setKind(Txn.Kind kind)
+{
+this.kind.set(kind);
}
@Override
@@ -762,7 +774,6 @@ public class AccordCommand extends Command implements
AccordState
waitingOnCommit.blindAdd(txnId);
}
-@Override
public boolean isWaitingOnCommit()
{
return !waitingOnCommit.getView().isEmpty();
@@ -788,7 +799,6 @@ public class AccordCommand extends Command implements
AccordState
waitingOnApply.blindPut(executeAt, txnId);
}
-@Override
public boolean isWaitingOnApply()
{
return !waitingOnApply.getView().isEmpty();
@@ -802,10 +812,21 @@ public class AccordCommand extends Command implements
AccordState
}
@Override
-public TxnId firstWaitingOnApply()
+public boolean isWaitingOnDependency()
+{
+return isWaitingOnCommit() || isWaitingOnApply();
+}
+
+@Override
+public TxnId firstWaitingOnApply(@Nullable TxnId ifExecutesBefore)
{
if (!isWaitingOnApply())
return null;
-return waitingOnApply.getView().firstEntry().getValue();
+
+Map.Entry first =
waitingOnApply.getView().firstEntry();
+if (ifExecutesBefore == null ||
first.getKey().compareTo(ifExecutesBefore) < 0)
+return first.getValue();
+
+return null;
}
}
diff
[cassandra] 10/27: Ninja for CASSANDRA-17719: Add @Simulate(with = MONITORS) to MultiReadFuture to get simulator working
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 12d8af0ae5a8db85771c4879a83b74161d0ca7dd
Author: David Capwell
AuthorDate: Mon Dec 12 15:50:59 2022 -0800
Ninja for CASSANDRA-17719: Add @Simulate(with = MONITORS) to
MultiReadFuture to get simulator working
---
src/java/org/apache/cassandra/service/accord/txn/TxnRead.java | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/java/org/apache/cassandra/service/accord/txn/TxnRead.java
b/src/java/org/apache/cassandra/service/accord/txn/TxnRead.java
index 9626d81220..94ad0693f1 100644
--- a/src/java/org/apache/cassandra/service/accord/txn/TxnRead.java
+++ b/src/java/org/apache/cassandra/service/accord/txn/TxnRead.java
@@ -39,6 +39,7 @@ import org.apache.cassandra.io.util.DataOutputPlus;
import org.apache.cassandra.service.accord.api.PartitionKey;
import org.apache.cassandra.service.accord.serializers.KeySerializers;
import org.apache.cassandra.utils.ObjectSizes;
+import org.apache.cassandra.utils.Simulate;
import org.apache.cassandra.utils.concurrent.AsyncPromise;
import org.apache.cassandra.utils.concurrent.Future;
import org.apache.cassandra.utils.concurrent.ImmediateFuture;
@@ -46,6 +47,7 @@ import org.apache.cassandra.utils.concurrent.ImmediateFuture;
import static org.apache.cassandra.utils.ArraySerializers.deserializeArray;
import static org.apache.cassandra.utils.ArraySerializers.serializeArray;
import static org.apache.cassandra.utils.ArraySerializers.serializedArraySize;
+import static org.apache.cassandra.utils.Simulate.With.MONITORS;
public class TxnRead extends AbstractKeySorted implements Read
{
@@ -143,6 +145,7 @@ public class TxnRead extends
AbstractKeySorted implements Read
return new MultiReadFuture(futures);
}
+@Simulate(with = MONITORS)
private static class MultiReadFuture extends AsyncPromise implements
BiConsumer
{
private Data result = null;
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16290) Consistency can be violated when bootstrap or decommission is resumed after node restart
[
https://issues.apache.org/jira/browse/CASSANDRA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680790#comment-17680790
]
Paulo Motta commented on CASSANDRA-16290:
-
unassigning since I don't think this is being actively worked on
> Consistency can be violated when bootstrap or decommission is resumed after
> node restart
>
>
> Key: CASSANDRA-16290
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16290
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Bootstrap and Decommission
>Reporter: Paulo Motta
>Priority: Normal
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> Since CASSANDRA-12008, successfully transferred ranges during decommission
> are saved on the {{system.transferred_ranges}} table. This allow skipping
> ranges already transferred when a failed decommission is retried with
> {{nodetool decommission}}.
> If instead of resuming the decommission, an operator restarts the node, waits
> N minutes and then performs a new decommission, the previously transferred
> ranges will be skipped during streaming, and any writes received by the
> decommissioned node during these N minutes will not be replicated to the new
> range owner, what violates consistency.
> This issue is analogous to the issue mentioned [on this
> comment|https://issues.apache.org/jira/browse/CASSANDRA-8838?focusedCommentId=16900234=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16900234]
> for resumable bootstrap (CASSANDRA-8838).
> In order to prevent consistency violations we should clear the
> {{system.transferred_ranges}} state during node restart, and maybe a system
> property to disable it. While we're at this, we should change the default of
> {{-Dcassandra.reset_bootstrap_progress}} to {{true}} to clear the
> {{system.available_ranges}} state by default when a bootstrapping node is
> restarted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16290) Consistency can be violated when bootstrap or decommission is resumed after node restart
[
https://issues.apache.org/jira/browse/CASSANDRA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta reassigned CASSANDRA-16290:
---
Assignee: (was: David Paulk)
> Consistency can be violated when bootstrap or decommission is resumed after
> node restart
>
>
> Key: CASSANDRA-16290
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16290
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Bootstrap and Decommission
>Reporter: Paulo Motta
>Priority: Normal
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> Since CASSANDRA-12008, successfully transferred ranges during decommission
> are saved on the {{system.transferred_ranges}} table. This allow skipping
> ranges already transferred when a failed decommission is retried with
> {{nodetool decommission}}.
> If instead of resuming the decommission, an operator restarts the node, waits
> N minutes and then performs a new decommission, the previously transferred
> ranges will be skipped during streaming, and any writes received by the
> decommissioned node during these N minutes will not be replicated to the new
> range owner, what violates consistency.
> This issue is analogous to the issue mentioned [on this
> comment|https://issues.apache.org/jira/browse/CASSANDRA-8838?focusedCommentId=16900234=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16900234]
> for resumable bootstrap (CASSANDRA-8838).
> In order to prevent consistency violations we should clear the
> {{system.transferred_ranges}} state during node restart, and maybe a system
> property to disable it. While we're at this, we should change the default of
> {{-Dcassandra.reset_bootstrap_progress}} to {{true}} to clear the
> {{system.available_ranges}} state by default when a bootstrapping node is
> restarted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18198) "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680789#comment-17680789
]
Brandon Williams commented on CASSANDRA-18198:
--
I thought perhaps the image had some version of 'py' that indeed lacked the
'io' submodule, but it's not only there, py.io.get_terminal_width() can be
called and returns the correct width.
> "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
> --
>
> Key: CASSANDRA-18198
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18198
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Claude Warren
>Assignee: Brandon Williams
>Priority: Normal
>
> {{title = 'Timeout'}}
> {{stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>}}
> {{{}sep = '+'{}}}{{{}def write_title(title, stream=None, sep="~"):{}}}
> {{{}"""Write a section title.{}}}{{{}If *stream* is None sys.stderr will be
> used, *sep* is used to{}}}
> {{draw the line.}}
> {{"""}}
> {{if stream is None:}}
> {{stream = sys.stderr}}
> {{> width = py.io.get_terminal_width()}}
> {{E AttributeError: module 'py' has no attribute 'io}}
>
> is reported in multiple tests as noted below.
> possibly a class loader issue associated with CASSANDRA-18150
> 4.1
> [https://ci-cassandra.apache.org/job/Cassandra-4.1/256/testReport/dtest-offheap.repair_tests.incremental_repair_test/TestIncRepair/test_multiple_full_repairs_lcs]
> 3.11
> [https://ci-cassandra.apache.org/job/Cassandra-3.11/424/testReport/dtest.bootstrap_test/TestBootstrap/test_simultaneous_bootstrap/]
> 3.0
> [https://ci-cassandra.apache.org/job/Cassandra-3.0/328/testReport/dtest-upgrade.upgrade_tests.upgrade_supercolumns_test/TestSCUpgrade/test_upgrade_super_columns_through_all_versions/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18198) "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680785#comment-17680785
]
Brandon Williams commented on CASSANDRA-18198:
--
I thought this was a problem with python 3.11 in CASSANDRA-18188, but I believe
the actual cause is that the 'py' dependency isn't being found by the
pytest-timeout package. Which means these are just tests that timed out
through pytest.mark.timeout, which then triggered the error produced.
This is strange, though. If I run the docker image and go into the venv, the
'py' package is already there:
{noformat}
$ docker run -it apache/cassandra-testing-ubuntu2004-java11 /bin/bash
cassandra@c2ce4e76c5ee:~$ . ./env3.8/bin/activate
(env3.8) cassandra@c2ce4e76c5ee:~$ pip install py
Requirement already satisfied: py in ./env3.8/lib/python3.8/site-packages
(1.11.0)
WARNING: You are using pip version 22.0.4; however, version 22.3.1 is available.
You should consider upgrading via the '/home/cassandra/env3.8/bin/python -m pip
install --upgrade pip' command.
(env3.8) cassandra@c2ce4e76c5ee:~$
{noformat}
We can still add defense in depth however by declaring it explicitly, which
I've done
[here|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-18198]. I've
started a Jenkins run, but the chances of hitting a timeout in one of the
affected tests aren't great:
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2226/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2226/pipeline]
> "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
> --
>
> Key: CASSANDRA-18198
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18198
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Claude Warren
>Assignee: Brandon Williams
>Priority: Normal
>
> {{title = 'Timeout'}}
> {{stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>}}
> {{{}sep = '+'{}}}{{{}def write_title(title, stream=None, sep="~"):{}}}
> {{{}"""Write a section title.{}}}{{{}If *stream* is None sys.stderr will be
> used, *sep* is used to{}}}
> {{draw the line.}}
> {{"""}}
> {{if stream is None:}}
> {{stream = sys.stderr}}
> {{> width = py.io.get_terminal_width()}}
> {{E AttributeError: module 'py' has no attribute 'io}}
>
> is reported in multiple tests as noted below.
> possibly a class loader issue associated with CASSANDRA-18150
> 4.1
> [https://ci-cassandra.apache.org/job/Cassandra-4.1/256/testReport/dtest-offheap.repair_tests.incremental_repair_test/TestIncRepair/test_multiple_full_repairs_lcs]
> 3.11
> [https://ci-cassandra.apache.org/job/Cassandra-3.11/424/testReport/dtest.bootstrap_test/TestBootstrap/test_simultaneous_bootstrap/]
> 3.0
> [https://ci-cassandra.apache.org/job/Cassandra-3.0/328/testReport/dtest-upgrade.upgrade_tests.upgrade_supercolumns_test/TestSCUpgrade/test_upgrade_super_columns_through_all_versions/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[
https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680756#comment-17680756
]
Ekaterina Dimitrova edited comment on CASSANDRA-17973 at 1/25/23 7:09 PM:
--
{quote}Because there are so many repositories and build/test components
involved, to untangle the introduction of jdk17, we're looking at temporarily
introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then
removing jdk8.
{quote}
Just to clarify, we do not plan to introduce it in CI (J8+J11+J17). There is
ongoing discussion to enable trunk to compile and test J17 when people want and
when everything is ready to close CASSANDRA-16895, we will switch from J8+J11
to J11+J17 in CI. Feature branch to enable people to test was considered but it
will make it more complicated. More info will be shared broadly soon.
was (Author: e.dimitrova):
{quote}Because there are so many repositories and build/test components
involved, to untangle the introduction of jdk17, we're looking at temporarily
introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then
removing jdk8.
{quote}
Just to clarify, we do not plan to introduce it in CI (J8+J11+J17). There is
ongoing discussion to enable trunk to compile and test J17 when people want and
when everything is ready to close CASSANDRA-16895, we will switch from J8+J11
to J11+J17. Feature branch to enable people to test was considered but it will
make it more complicated. More info will be shared broadly soon.
> Change trunk 4.2 to 5.0
> ---
>
> Key: CASSANDRA-17973
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17973
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> 1. Bump trunk's version
> {code}
> git switch trunk
> # increment version to 5.0
> edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc
> {code}
> 2. Update jvm-dtest supported upgrade paths
> -
> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96
>
> 3. Update `4.2` to jira versions
> Change `4.2` to `5.0`
> Change `4.x` to `5.x`
> 4. Update docker images to include cassandra-5.0
> (Docker images also need to be deployed)
> 5. Add pipeline to ci-cassandra
> https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51
> 6. Add dtest version and upgrade paths
> -
> https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py
> - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374
> -
> https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41
> 7. Update how_to_commit documentation
> https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[
https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680756#comment-17680756
]
Ekaterina Dimitrova edited comment on CASSANDRA-17973 at 1/25/23 7:09 PM:
--
{quote}Because there are so many repositories and build/test components
involved, to untangle the introduction of jdk17, we're looking at temporarily
introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then
removing jdk8.
{quote}
Just to clarify, we do not plan to introduce it in CI (J8+J11+J17). There is
ongoing discussion to enable trunk to compile and test J17 when people want and
when everything is ready to close CASSANDRA-16895, we will switch from J8+J11
to J11+J17 in CI. Feature branch to enable people to test was considered but it
will make it more complicated. More info will be shared broadly soon, this
strategy is fresh idea
was (Author: e.dimitrova):
{quote}Because there are so many repositories and build/test components
involved, to untangle the introduction of jdk17, we're looking at temporarily
introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then
removing jdk8.
{quote}
Just to clarify, we do not plan to introduce it in CI (J8+J11+J17). There is
ongoing discussion to enable trunk to compile and test J17 when people want and
when everything is ready to close CASSANDRA-16895, we will switch from J8+J11
to J11+J17 in CI. Feature branch to enable people to test was considered but it
will make it more complicated. More info will be shared broadly soon.
> Change trunk 4.2 to 5.0
> ---
>
> Key: CASSANDRA-17973
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17973
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> 1. Bump trunk's version
> {code}
> git switch trunk
> # increment version to 5.0
> edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc
> {code}
> 2. Update jvm-dtest supported upgrade paths
> -
> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96
>
> 3. Update `4.2` to jira versions
> Change `4.2` to `5.0`
> Change `4.x` to `5.x`
> 4. Update docker images to include cassandra-5.0
> (Docker images also need to be deployed)
> 5. Add pipeline to ci-cassandra
> https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51
> 6. Add dtest version and upgrade paths
> -
> https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py
> - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374
> -
> https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41
> 7. Update how_to_commit documentation
> https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[
https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680756#comment-17680756
]
Ekaterina Dimitrova commented on CASSANDRA-17973:
-
{quote}Because there are so many repositories and build/test components
involved, to untangle the introduction of jdk17, we're looking at temporarily
introducing jdk17 (CASSANDRA-18179) then completing jdk17 support and then
removing jdk8.
{quote}
Just to clarify, we do not plan to introduce it in CI (J8+J11+J17). There is
ongoing discussion to enable trunk to compile and test J17 when people want and
when everything is ready to close CASSANDRA-16895, we will switch from J8+J11
to J11+J17. Feature branch to enable people to test was considered but it will
make it more complicated. More info will be shared broadly soon.
> Change trunk 4.2 to 5.0
> ---
>
> Key: CASSANDRA-17973
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17973
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> 1. Bump trunk's version
> {code}
> git switch trunk
> # increment version to 5.0
> edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc
> {code}
> 2. Update jvm-dtest supported upgrade paths
> -
> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96
>
> 3. Update `4.2` to jira versions
> Change `4.2` to `5.0`
> Change `4.x` to `5.x`
> 4. Update docker images to include cassandra-5.0
> (Docker images also need to be deployed)
> 5. Add pipeline to ci-cassandra
> https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51
> 6. Add dtest version and upgrade paths
> -
> https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py
> - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374
> -
> https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41
> 7. Update how_to_commit documentation
> https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17427) Improve unit tests performance
[ https://issues.apache.org/jira/browse/CASSANDRA-17427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680750#comment-17680750 ] Michael Semb Wever commented on CASSANDRA-17427: That ci-cassandra.a.o build looks surprisingly nice! +1 from me. (Can we get a circleci run too please) > Improve unit tests performance > -- > > Key: CASSANDRA-17427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17427 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Attachments: screenshot-1.png > > Time Spent: 5h 20m > Remaining Estimate: 0h > > There a couple of small improvements to run unit tests a bit faster -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[
https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680745#comment-17680745
]
Michael Semb Wever edited comment on CASSANDRA-17973 at 1/25/23 6:46 PM:
-
bq. Should we consider dropping JDK8 support while at it? Supporting three JDKs
(8, 11, 17) would likely be an unreasonable burden that might not be worth it
at this point in Java8 long life.
That is the plan! (and has agreement on dev@)
[~e.dimitrova] is leading the effort. Because there are so many repositories
and build/test components involved, to untangle the introduction of jdk17,
we're looking at temporarily introducing jdk17 (CASSANDRA-18179) then
completing jdk17 support and then removing jdk8. The removal of jdk8 is a
trigger to bump build.xml to 5.0 (this ticket). This work is in progress and is
a top and pressing priority.
was (Author: michaelsembwever):
bq. Should we consider dropping JDK8 support while at it? Supporting three JDKs
(8, 11, 17) would likely be an unreasonable burden that might not be worth it
at this point in Java8 long life.
That is the plan! (and has agreement on dev@)
[~e.dimitrova] is leading the effort. Because there are so many repositories
and build/test components involved, to untangle the introduction of jdk17,
we're looking at temporarily introducing jdk17 (CASSANDRA-18179) then
completing jdk17 support and then removing jdk8. The removal of jdk8 is a
trigger to bump build.xml to 5.0 (this ticket). This work is in progress and
has first priority.
> Change trunk 4.2 to 5.0
> ---
>
> Key: CASSANDRA-17973
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17973
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> 1. Bump trunk's version
> {code}
> git switch trunk
> # increment version to 5.0
> edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc
> {code}
> 2. Update jvm-dtest supported upgrade paths
> -
> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96
>
> 3. Update `4.2` to jira versions
> Change `4.2` to `5.0`
> Change `4.x` to `5.x`
> 4. Update docker images to include cassandra-5.0
> (Docker images also need to be deployed)
> 5. Add pipeline to ci-cassandra
> https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51
> 6. Add dtest version and upgrade paths
> -
> https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py
> - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374
> -
> https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41
> 7. Update how_to_commit documentation
> https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[
https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680745#comment-17680745
]
Michael Semb Wever commented on CASSANDRA-17973:
bq. Should we consider dropping JDK8 support while at it? Supporting three JDKs
(8, 11, 17) would likely be an unreasonable burden that might not be worth it
at this point in Java8 long life.
That is the plan! (and has agreement on dev@)
[~e.dimitrova] is leading the effort. Because there are so many repositories
and build/test components involved, to untangle the introduction of jdk17,
we're looking at temporarily introducing jdk17 (CASSANDRA-18179) then
completing jdk17 support and then removing jdk8. The removal of jdk8 is a
trigger to bump build.xml to 5.0 (this ticket). This work is in progress and
has first priority.
> Change trunk 4.2 to 5.0
> ---
>
> Key: CASSANDRA-17973
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17973
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> 1. Bump trunk's version
> {code}
> git switch trunk
> # increment version to 5.0
> edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc
> {code}
> 2. Update jvm-dtest supported upgrade paths
> -
> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96
>
> 3. Update `4.2` to jira versions
> Change `4.2` to `5.0`
> Change `4.x` to `5.x`
> 4. Update docker images to include cassandra-5.0
> (Docker images also need to be deployed)
> 5. Add pipeline to ci-cassandra
> https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51
> 6. Add dtest version and upgrade paths
> -
> https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py
> - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374
> -
> https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41
> 7. Update how_to_commit documentation
> https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[
https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680742#comment-17680742
]
Aleksey Yeschenko commented on CASSANDRA-17973:
---
Should we consider dropping JDK8 support while at it? Supporting three JDKs (8,
11, 17) would likely be an unreasonable burden that might not be worth it at
this point in Java8 long life.
> Change trunk 4.2 to 5.0
> ---
>
> Key: CASSANDRA-17973
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17973
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> 1. Bump trunk's version
> {code}
> git switch trunk
> # increment version to 5.0
> edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc
> {code}
> 2. Update jvm-dtest supported upgrade paths
> -
> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96
>
> 3. Update `4.2` to jira versions
> Change `4.2` to `5.0`
> Change `4.x` to `5.x`
> 4. Update docker images to include cassandra-5.0
> (Docker images also need to be deployed)
> 5. Add pipeline to ci-cassandra
> https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51
> 6. Add dtest version and upgrade paths
> -
> https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py
> - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374
> -
> https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41
> 7. Update how_to_commit documentation
> https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18198) "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18198:
-
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Component/s: Test/dtest/python
Discovered By: User Report
Severity: Low
Status: Open (was: Triage Needed)
> "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
> --
>
> Key: CASSANDRA-18198
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18198
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Claude Warren
>Assignee: Brandon Williams
>Priority: Normal
>
> {{title = 'Timeout'}}
> {{stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>}}
> {{{}sep = '+'{}}}{{{}def write_title(title, stream=None, sep="~"):{}}}
> {{{}"""Write a section title.{}}}{{{}If *stream* is None sys.stderr will be
> used, *sep* is used to{}}}
> {{draw the line.}}
> {{"""}}
> {{if stream is None:}}
> {{stream = sys.stderr}}
> {{> width = py.io.get_terminal_width()}}
> {{E AttributeError: module 'py' has no attribute 'io}}
>
> is reported in multiple tests as noted below.
> possibly a class loader issue associated with CASSANDRA-18150
> 4.1
> [https://ci-cassandra.apache.org/job/Cassandra-4.1/256/testReport/dtest-offheap.repair_tests.incremental_repair_test/TestIncRepair/test_multiple_full_repairs_lcs]
> 3.11
> [https://ci-cassandra.apache.org/job/Cassandra-3.11/424/testReport/dtest.bootstrap_test/TestBootstrap/test_simultaneous_bootstrap/]
> 3.0
> [https://ci-cassandra.apache.org/job/Cassandra-3.0/328/testReport/dtest-upgrade.upgrade_tests.upgrade_supercolumns_test/TestSCUpgrade/test_upgrade_super_columns_through_all_versions/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18197: - Test and Documentation Plan: run CI Status: Patch Available (was: Open) > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680652#comment-17680652 ] Brandon Williams edited comment on CASSANDRA-18197 at 1/25/23 5:36 PM: --- Patch adds concurrency to the adoc generation, working in batches of 3 (more doesn't really help at least on my macine) and this cuts the run time to around 30s. ||Branch||CI|| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/821/workflows/2b13ee0b-a523-4d9f-bc58-1bb6a98894be]| |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/ab7f2d3b-f47d-4c60-80e0-99afd5961c8c], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/b707fbe5-d245-4bef-af49-191a4a54b201]| |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/7a76a7eb-0697-4ca8-a4a2-9c3985838c1f], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/cab41040-0506-460a-8022-ec944e879814]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/3ce42dbc-7b9e-4c85-8211-9c449d0870df], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/992604c1-3a14-4e64-8ede-10721fc15fbb]| Jenkins for a smoke test: [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2224/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2224/pipeline] was (Author: brandon.williams): Patch adds concurrency to the adoc generation, working in batches of 3 (more doesn't really help at least on my macine) and this cuts the run time to around 30s. ||Branch||CI|| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/821/workflows/2b13ee0b-a523-4d9f-bc58-1bb6a98894be]| |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/ab7f2d3b-f47d-4c60-80e0-99afd5961c8c], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/b707fbe5-d245-4bef-af49-191a4a54b201]| |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/7a76a7eb-0697-4ca8-a4a2-9c3985838c1f], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/cab41040-0506-460a-8022-ec944e879814]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/3ce42dbc-7b9e-4c85-8211-9c449d0870df], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/992604c1-3a14-4e64-8ede-10721fc15fbb]| > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18196) Initial Merge of Accord Feature Branch to Trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680710#comment-17680710
]
Benedict Elliott Smith commented on CASSANDRA-18196:
No, there is not. But, I do not believe this would determine the fix version
anyway.
> Initial Merge of Accord Feature Branch to Trunk
> ---
>
> Key: CASSANDRA-18196
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18196
> Project: Cassandra
> Issue Type: Task
> Components: Accord
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: High
> Fix For: 4.x
>
>
> Once we've resolved our feature flags situation (see CASSANDRA-18195) and
> in-flight work (see CASSANDRA-18192) we want before merge, here is the rough
> plan for getting {{cep-15-accord}} merged to {{trunk}}:
> 1.) Run cep-15-accord pre-squash against CircleCI to establish a baseline.
> 2.) Squash ninja commits out of cep-15-accord and rerun tests pre-rebase.
> 2.) Rebase cep-15-accord to trunk and rerun tests.
> 4.) Merge cep-15-accord to trunk if tests are clean and there are no public
> objections.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17973) Change trunk 4.2 to 5.0
[
https://issues.apache.org/jira/browse/CASSANDRA-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680708#comment-17680708
]
Caleb Rackliffe commented on CASSANDRA-17973:
-
I would add CASSANDRA-16052 to this list, because of its small breaking changes
to the secondary index API.
CC [~mike_tr_adamson]
> Change trunk 4.2 to 5.0
> ---
>
> Key: CASSANDRA-17973
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17973
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> 1. Bump trunk's version
> {code}
> git switch trunk
> # increment version to 5.0
> edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc
> {code}
> 2. Update jvm-dtest supported upgrade paths
> -
> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96
>
> 3. Update `4.2` to jira versions
> Change `4.2` to `5.0`
> Change `4.x` to `5.x`
> 4. Update docker images to include cassandra-5.0
> (Docker images also need to be deployed)
> 5. Add pipeline to ci-cassandra
> https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51
> 6. Add dtest version and upgrade paths
> -
> https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py
> - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374
> -
> https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41
> 7. Update how_to_commit documentation
> https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18196) Initial Merge of Accord Feature Branch to Trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680704#comment-17680704
]
Caleb Rackliffe commented on CASSANDRA-18196:
-
[~mck] I don't think we have, but I'll double check w/ [~benedict].
> Initial Merge of Accord Feature Branch to Trunk
> ---
>
> Key: CASSANDRA-18196
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18196
> Project: Cassandra
> Issue Type: Task
> Components: Accord
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: High
> Fix For: 4.x
>
>
> Once we've resolved our feature flags situation (see CASSANDRA-18195) and
> in-flight work (see CASSANDRA-18192) we want before merge, here is the rough
> plan for getting {{cep-15-accord}} merged to {{trunk}}:
> 1.) Run cep-15-accord pre-squash against CircleCI to establish a baseline.
> 2.) Squash ninja commits out of cep-15-accord and rerun tests pre-rebase.
> 2.) Rebase cep-15-accord to trunk and rerun tests.
> 4.) Merge cep-15-accord to trunk if tests are clean and there are no public
> objections.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18196) Initial Merge of Accord Feature Branch to Trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18196:
Fix Version/s: (was: 5.x)
4.x
> Initial Merge of Accord Feature Branch to Trunk
> ---
>
> Key: CASSANDRA-18196
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18196
> Project: Cassandra
> Issue Type: Task
> Components: Accord
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: High
> Fix For: 4.x
>
>
> Once we've resolved our feature flags situation (see CASSANDRA-18195) and
> in-flight work (see CASSANDRA-18192) we want before merge, here is the rough
> plan for getting {{cep-15-accord}} merged to {{trunk}}:
> 1.) Run cep-15-accord pre-squash against CircleCI to establish a baseline.
> 2.) Squash ninja commits out of cep-15-accord and rerun tests pre-rebase.
> 2.) Rebase cep-15-accord to trunk and rerun tests.
> 4.) Merge cep-15-accord to trunk if tests are clean and there are no public
> objections.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18069) Add a new UNMASK permission
[
https://issues.apache.org/jira/browse/CASSANDRA-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18069:
--
Change Category: Semantic
Complexity: Normal
Status: Open (was: Triage Needed)
> Add a new UNMASK permission
> ---
>
> Key: CASSANDRA-18069
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18069
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> Add a new UNMASK permission allowing users with that permission to see the
> data masked by the masking functions attached to columns introduced by
> CASSANDRA-18068, as defined by
> [CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking].
> It would look like:
> {code}
> > CREATE TABLE patients (
> id timeuuid PRIMARY KEY,
> name text MASKED WITH default(),
> birth date MASKED WITH default()
> );
>
> > INSERT INTO patients(id, name, birth) VALUES (now(), 'alice', '1982-12-21');
>
> > CREATE USER unprivileged_user WITH PASSWORD 'xyz';
> > CREATE USER privileged_user WITH PASSWORD 'zyx';
>
> > GRANT SELECT ON ALL TABLE patients TO unprivileged_user;
> > GRANT SELECT ON ALL TABLE patients TO privileged_user;
> > GRANT UNMASK ON ALL TABLE patients TO privileged_user;
>
> > LOGIN unprivileged_user
>
> > SELECT name, birth FROM patients WHERE
> > id=db2b372f-f91b-4537-b46b-c478f8330c29;
>
> name| birth
> -+
> ale | 1900-01-01
>
> > LOGIN privileged_user
> > SELECT name, birth FROM patients WHERE
> > id=db2b372f-f91b-4537-b46b-c478f8330c29;
>
> name | birth
> ---+
> alice | 1982-12-21
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18198) "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claude Warren reassigned CASSANDRA-18198:
-
Assignee: Brandon Williams
> "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
> --
>
> Key: CASSANDRA-18198
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18198
> Project: Cassandra
> Issue Type: Bug
>Reporter: Claude Warren
>Assignee: Brandon Williams
>Priority: Normal
>
> {{title = 'Timeout'}}
> {{stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>}}
> {{{}sep = '+'{}}}{{{}def write_title(title, stream=None, sep="~"):{}}}
> {{{}"""Write a section title.{}}}{{{}If *stream* is None sys.stderr will be
> used, *sep* is used to{}}}
> {{draw the line.}}
> {{"""}}
> {{if stream is None:}}
> {{stream = sys.stderr}}
> {{> width = py.io.get_terminal_width()}}
> {{E AttributeError: module 'py' has no attribute 'io}}
>
> is reported in multiple tests as noted below.
> possibly a class loader issue associated with CASSANDRA-18150
> 4.1
> [https://ci-cassandra.apache.org/job/Cassandra-4.1/256/testReport/dtest-offheap.repair_tests.incremental_repair_test/TestIncRepair/test_multiple_full_repairs_lcs]
> 3.11
> [https://ci-cassandra.apache.org/job/Cassandra-3.11/424/testReport/dtest.bootstrap_test/TestBootstrap/test_simultaneous_bootstrap/]
> 3.0
> [https://ci-cassandra.apache.org/job/Cassandra-3.0/328/testReport/dtest-upgrade.upgrade_tests.upgrade_supercolumns_test/TestSCUpgrade/test_upgrade_super_columns_through_all_versions/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18198) "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
Claude Warren created CASSANDRA-18198:
-
Summary: "AttributeError: module 'py' has no attribute 'io'"
reported in multiple tests
Key: CASSANDRA-18198
URL: https://issues.apache.org/jira/browse/CASSANDRA-18198
Project: Cassandra
Issue Type: Bug
Reporter: Claude Warren
{{title = 'Timeout'}}
{{stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>}}
{{{}sep = '+'{}}}{{{}def write_title(title, stream=None, sep="~"):{}}}
{{{}"""Write a section title.{}}}{{{}If *stream* is None sys.stderr will be
used, *sep* is used to{}}}
{{draw the line.}}
{{"""}}
{{if stream is None:}}
{{stream = sys.stderr}}
{{> width = py.io.get_terminal_width()}}
{{E AttributeError: module 'py' has no attribute 'io}}
is reported in multiple tests as noted below.
possibly a class loader issue associated with CASSANDRA-18150
4.1
[https://ci-cassandra.apache.org/job/Cassandra-4.1/256/testReport/dtest-offheap.repair_tests.incremental_repair_test/TestIncRepair/test_multiple_full_repairs_lcs]
3.11
[https://ci-cassandra.apache.org/job/Cassandra-3.11/424/testReport/dtest.bootstrap_test/TestBootstrap/test_simultaneous_bootstrap/]
3.0
[https://ci-cassandra.apache.org/job/Cassandra-3.0/328/testReport/dtest-upgrade.upgrade_tests.upgrade_supercolumns_test/TestSCUpgrade/test_upgrade_super_columns_through_all_versions/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680662#comment-17680662
]
Michael Semb Wever commented on CASSANDRA-18181:
bq. Does anyone know how can I rerun only the aborted build in favor of saving
time and resources?
"Matrix Reloaded" on
https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2157/
(it won't change the result of the parent pipeline job though)
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18197: - Fix Version/s: 3.11.x 4.0.x 4.1.x 4.x > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680652#comment-17680652 ] Brandon Williams commented on CASSANDRA-18197: -- Patch adds concurrency to the adoc generation, working in batches of 3 (more doesn't really help at least on my macine) and this cuts the run time to around 30s. ||Branch||CI|| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/821/workflows/2b13ee0b-a523-4d9f-bc58-1bb6a98894be]| |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/ab7f2d3b-f47d-4c60-80e0-99afd5961c8c], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/820/workflows/b707fbe5-d245-4bef-af49-191a4a54b201]| |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/7a76a7eb-0697-4ca8-a4a2-9c3985838c1f], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/822/workflows/cab41040-0506-460a-8022-ec944e879814]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18197-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/3ce42dbc-7b9e-4c85-8211-9c449d0870df], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/823/workflows/992604c1-3a14-4e64-8ede-10721fc15fbb]| > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18197: Bug Category: Parent values: Correctness(12982) Complexity: Normal Component/s: Build Discovered By: User Report Severity: Low Status: Open (was: Triage Needed) > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
[ https://issues.apache.org/jira/browse/CASSANDRA-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-18197: Assignee: Brandon Williams > Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py > being slow > --- > > Key: CASSANDRA-18197 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 > Project: Cassandra > Issue Type: Bug >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > > As discussed on CASSANDRA-18181, recently we see builds aborted as python3 > ./scripts/gen-nodetool-docs.py is too slow. > According to [~brandon.williams] most of the time in the script is spent in > create_adoc, which is serially forking nodetool help for every command to > gather it. > CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18197) Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow
Ekaterina Dimitrova created CASSANDRA-18197: --- Summary: Builds being often aborted because of python3 ./scripts/gen-nodetool-docs.py being slow Key: CASSANDRA-18197 URL: https://issues.apache.org/jira/browse/CASSANDRA-18197 Project: Cassandra Issue Type: Bug Reporter: Ekaterina Dimitrova As discussed on CASSANDRA-18181, recently we see builds aborted as python3 ./scripts/gen-nodetool-docs.py is too slow. According to [~brandon.williams] most of the time in the script is spent in create_adoc, which is serially forking nodetool help for every command to gather it. CC [~Anthony Grasso] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680643#comment-17680643
]
Ekaterina Dimitrova commented on CASSANDRA-18181:
-
Thanks, I will open a ticket and ping Anthony there. Does anyone know how can I
rerun only the aborted build in favor of saving time and resources?
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16718) Changing listen_address with prefer_local may lead to issues
[ https://issues.apache.org/jira/browse/CASSANDRA-16718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680245#comment-17680245 ] Brandon Williams edited comment on CASSANDRA-16718 at 1/25/23 2:14 PM: --- ||Branch||CI|| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-16718-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/816/workflows/dba0aab7-0267-49bf-8306-19720c065b92] | |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-16718-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/815/workflows/e84f0d6c-6497-45f8-b81f-9443c59762a3] [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/815/workflows/c131fd88-74e7-46d6-869d-5199c11d898b] | |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-16718-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/814/workflows/82a2acd8-d124-4c93-b018-e29642655e33] [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/814/workflows/754fe3ba-a08f-4ceb-b95f-65596e1710b0] | |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-16718-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/813/workflows/bf6e0bcf-53a2-4888-bc8d-3234af2b3c23] [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/813/workflows/4df118dc-b1a7-4034-bc2e-114c5676126a] | The current state here is the 3.11 patch breaks test_prefer_local_reconnect_on_listen_address and seems to legitimately not reconnect (but does pass the restart test), and the 4.x patch doesn't seem to work, it's still holding on to the old address somewhere. was (Author: brandon.williams): ||Branch||CI|| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-16718-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/816/workflows/dba0aab7-0267-49bf-8306-19720c065b92] | |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-16718-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/815/workflows/e84f0d6c-6497-45f8-b81f-9443c59762a3] [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/815/workflows/c131fd88-74e7-46d6-869d-5199c11d898b] | |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-16718-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/814/workflows/82a2acd8-d124-4c93-b018-e29642655e33] [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/814/workflows/754fe3ba-a08f-4ceb-b95f-65596e1710b0] | |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-16718-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/813/workflows/bf6e0bcf-53a2-4888-bc8d-3234af2b3c23] [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/813/workflows/4df118dc-b1a7-4034-bc2e-114c5676126a] | > Changing listen_address with prefer_local may lead to issues > > > Key: CASSANDRA-16718 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16718 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Jan Karlsson >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > Many container based solution function by assigning new listen_addresses when > nodes are stopped. Changing the listen_address is usually as simple as > turning off the node and changing the yaml file. > However, if prefer_local is enabled, I observed that nodes were unable to > join the cluster and fail with 'Unable to gossip with any seeds'. > Trace shows that the changing node will try to communicate with the existing > node but the response is never received. I assume it is because the existing > node attempts to communicate with the local address during the shadow round. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18196) Initial Merge of Accord Feature Branch to Trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680619#comment-17680619
]
Michael Semb Wever edited comment on CASSANDRA-18196 at 1/25/23 1:36 PM:
-
[~maedhroz], is there anything about what will be merged to trunk that breaks
upgrade compatibility against 3.x versions? If not, fixVersion should be 4.x.
If so, it needs to be expressed, fixVersion 5.x is then appropriate and it
should be a blocker to CASSANDRA-17973.
was (Author: michaelsembwever):
[~maedhroz], is there anything about what will be merged to trunk that breaks
upgrade compatibility against 3.x versions? If not, fixVersion should be 4.x.
If so, it needs to be expressed, fixVersion 5.x is appropriate and it should be
a blocker to CASSANDRA-17973.
> Initial Merge of Accord Feature Branch to Trunk
> ---
>
> Key: CASSANDRA-18196
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18196
> Project: Cassandra
> Issue Type: Task
> Components: Accord
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: High
> Fix For: 5.x
>
>
> Once we've resolved our feature flags situation (see CASSANDRA-18195) and
> in-flight work (see CASSANDRA-18192) we want before merge, here is the rough
> plan for getting {{cep-15-accord}} merged to {{trunk}}:
> 1.) Run cep-15-accord pre-squash against CircleCI to establish a baseline.
> 2.) Squash ninja commits out of cep-15-accord and rerun tests pre-rebase.
> 2.) Rebase cep-15-accord to trunk and rerun tests.
> 4.) Merge cep-15-accord to trunk if tests are clean and there are no public
> objections.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18196) Initial Merge of Accord Feature Branch to Trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680619#comment-17680619
]
Michael Semb Wever commented on CASSANDRA-18196:
[~maedhroz], is there anything about what will be merged to trunk that breaks
upgrade compatibility against 3.x versions? If not, fixVersion should be 4.x.
If so, it needs to be expressed, fixVersion 5.x is appropriate and it should be
a blocker to CASSANDRA-17973.
> Initial Merge of Accord Feature Branch to Trunk
> ---
>
> Key: CASSANDRA-18196
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18196
> Project: Cassandra
> Issue Type: Task
> Components: Accord
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: High
> Fix For: 5.x
>
>
> Once we've resolved our feature flags situation (see CASSANDRA-18195) and
> in-flight work (see CASSANDRA-18192) we want before merge, here is the rough
> plan for getting {{cep-15-accord}} merged to {{trunk}}:
> 1.) Run cep-15-accord pre-squash against CircleCI to establish a baseline.
> 2.) Squash ninja commits out of cep-15-accord and rerun tests pre-rebase.
> 2.) Rebase cep-15-accord to trunk and rerun tests.
> 4.) Merge cep-15-accord to trunk if tests are clean and there are no public
> objections.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
