[jira] [Commented] (CASSANDRA-18707) Test failure: junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-.jdk11
[
https://issues.apache.org/jira/browse/CASSANDRA-18707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769003#comment-17769003
]
Berenguer Blasi commented on CASSANDRA-18707:
-
No hurries and thanks for your time
> Test failure:
> junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-.jdk11
>
>
>
> Key: CASSANDRA-18707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18707
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: TESTS-TestSuites.xml.xz
>
>
> Seen here:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1650/testReport/junit.framework/TestSuite/org_apache_cassandra_distributed_test_CASMultiDCTest__jdk11/]
> h3.
> {code:java}
> Error Message
> Schema agreement not reached. Schema versions of the instances:
> [ef1c8e05-a06d-388d-a46d-53cc22a94762, 6c386108-1805-3985-b48e-8016012a0207,
> 6c386108-1805-3985-b48e-8016012a0207, ef1c8e05-a06d-388d-a46d-53cc22a94762]
> Stacktrace
> java.lang.IllegalStateException: Schema agreement not reached. Schema
> versions of the instances: [ef1c8e05-a06d-388d-a46d-53cc22a94762,
> 6c386108-1805-3985-b48e-8016012a0207, 6c386108-1805-3985-b48e-8016012a0207,
> ef1c8e05-a06d-388d-a46d-53cc22a94762] at
> org.apache.cassandra.distributed.impl.AbstractCluster$ChangeMonitor.waitForCompletion(AbstractCluster.java:907)
> at
> org.apache.cassandra.distributed.impl.AbstractCluster.lambda$schemaChange$8(AbstractCluster.java:836)
> at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96) at
> org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61) at
> org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17674) Test failure: org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage
[
https://issues.apache.org/jira/browse/CASSANDRA-17674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769002#comment-17769002
]
Berenguer Blasi commented on CASSANDRA-17674:
-
Oh apologies. If we look at the exceptions of the failed tests I'll copy here
before they disappear:
{noformat}
java.util.concurrent.ExecutionException: java.lang.RuntimeException:
java.util.concurrent.ExecutionException: java.lang.RuntimeException:
java.util.concurrent.TimeoutException:
org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@454d32c4[Shutting
down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
218] did not terminate on time
at
java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
at
java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
at
org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:227)
at
org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage(DropCompactStorageTest.java:49)
Caused by: java.lang.RuntimeException: java.util.concurrent.ExecutionException:
java.lang.RuntimeException: java.util.concurrent.TimeoutException:
org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@454d32c4[Shutting
down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
218] did not terminate on time
at
org.apache.cassandra.distributed.impl.IsolatedExecutor$ThrowingRunnable.lambda$toRunnable$0(IsolatedExecutor.java:235)
at
java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at
org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
at java.lang.Thread.run(Thread.java:750)
Caused by: java.util.concurrent.ExecutionException: java.lang.RuntimeException:
java.util.concurrent.TimeoutException:
org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@454d32c4[Shutting
down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
218] did not terminate on time
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
at
org.apache.cassandra.distributed.impl.IsolatedExecutor$ThrowingRunnable.lambda$toRunnable$0(IsolatedExecutor.java:231)
Caused by: java.lang.RuntimeException: java.util.concurrent.TimeoutException:
org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@454d32c4[Shutting
down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
218] did not terminate on time
at org.apache.cassandra.utils.Throwables.maybeFail(Throwables.java:62)
at
org.apache.cassandra.distributed.impl.Instance.lambda$shutdown$28(Instance.java:810)
at
org.apache.cassandra.distributed.impl.IsolatedExecutor.lambda$null$8(IsolatedExecutor.java:114)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
Caused by: java.util.concurrent.TimeoutException:
org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@454d32c4[Shutting
down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
218] did not terminate on time
at
org.apache.cassandra.utils.ExecutorUtils.awaitTerminationUntil(ExecutorUtils.java:107)
at
org.apache.cassandra.utils.ExecutorUtils.awaitTermination(ExecutorUtils.java:96)
at
org.apache.cassandra.utils.ExecutorUtils.shutdownNowAndWait(ExecutorUtils.java:139)
at
org.apache.cassandra.concurrent.StageManager.shutdownAndWait(StageManager.java:128)
at
org.apache.cassandra.distributed.impl.Instance.lambda$null$26(Instance.java:803)
at
org.apache.cassandra.distributed.impl.Instance.lambda$parallelRun$32(Instance.java:968)
{noformat}
You'll notice {{Instance.java:810}} is being mentioned and that doesn't match a
line of code atm. Same for other lines of code, they match to blank lines. And
in theory I am looking at the right source from the dtests jar build. So there
is some SHA dance going on here I haven't pinned down yet. Everything should
match to HEAD as we're not testing against any tag.
> Test failure:
> org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage
>
>
> Key: CASSANDRA-17674
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17674
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769001#comment-17769001 ] Berenguer Blasi commented on CASSANDRA-18688: - CASSANDRA_JDK_GT_SUPPORTED? > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18728) [Transient Bug] Incorrect ByteBuffer representation of ColumnIdentifiers when 3.11.15 loading legacy data from 2.x
[
https://issues.apache.org/jira/browse/CASSANDRA-18728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ke Han updated CASSANDRA-18728:
---
Description:
h1. Bug Description
When using Cassandra 3.11.15 to load legacy data from 2.2.10, I noticed that
the byte representation of the column identifier is incorrect.
The legacy data contain two tables, and the schema is as follows.
{code:java}
cqlsh> desc test.alpha ;
CREATE TABLE test.alpha (
key text PRIMARY KEY,
foo text
) WITH COMPACT STORAGE
AND bloom_filter_fp_chance = 0.01
AND caching = '{"keys":"ALL", "rows_per_partition":"NONE"}'
AND comment = ''
AND compaction = {'min_threshold': '4', 'class':
'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
'max_threshold': '32'}
AND compression = {'sstable_compression':
'org.apache.cassandra.io.compress.LZ4Compressor'}
AND dclocal_read_repair_chance = 0.1
AND default_time_to_live = 0
AND gc_grace_seconds = 864000
AND max_index_interval = 2048
AND memtable_flush_period_in_ms = 0
AND min_index_interval = 128
AND read_repair_chance = 0.0
AND speculative_retry = 'NONE';
cqlsh> DESC test.foos ;
CREATE TABLE test.foos (
key text PRIMARY KEY,
"666f6f" text
) WITH COMPACT STORAGE
AND bloom_filter_fp_chance = 0.01
AND caching = '{"keys":"ALL", "rows_per_partition":"NONE"}'
AND comment = ''
AND compaction = {'min_threshold': '4', 'class':
'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
'max_threshold': '32'}
AND compression = {'sstable_compression':
'org.apache.cassandra.io.compress.LZ4Compressor'}
AND dclocal_read_repair_chance = 0.1
AND default_time_to_live = 0
AND gc_grace_seconds = 864000
AND max_index_interval = 2048
AND memtable_flush_period_in_ms = 0
AND min_index_interval = 128
AND read_repair_chance = 0.0
AND speculative_retry = 'NONE';
CREATE INDEX idx_foo ON test.foos ("666f6f"); {code}
There exists a column in test.foo with {*}name = "666f6f"{*}, the corresponding
byte representation should be Hex(666f6f) == {*}363636663666{*}. However, when
3.11.15 loads the data and creating the column, if we check the value in
byteBuffer, the it still stores "666f6f".
{code:java}
// src/java/org/apache/cassandra/schema/SchemaKeyspace.java
public static ColumnDefinition createColumnFromRow(UntypedResultSet.Row row,
Types types)
{
String keyspace = row.getString("keyspace_name");
String table = row.getString("table_name");
ColumnDefinition.Kind kind =
ColumnDefinition.Kind.valueOf(row.getString("kind").toUpperCase());
int position = row.getInt("position");
ClusteringOrder order =
ClusteringOrder.valueOf(row.getString("clustering_order").toUpperCase());
AbstractType type = parse(keyspace, row.getString("type"), types);
if (order == ClusteringOrder.DESC)
type = ReversedType.getInstance(type);
// Injected log to check byteBuffer value
logger.info(String.format("column_name = %s, column_name_bytes = %s" ,
row.getString("column_name"), new
String(row.getBytes("column_name_bytes").array(), StandardCharsets.UTF_8)));
ColumnIdentifier name = new
ColumnIdentifier(row.getBytes("column_name_bytes"),
row.getString("column_name"));
return new ColumnDefinition(keyspace, table, name, type, position, kind);
}{code}
h2. Logs
INFO [main] 2023-08-07 02:21:53,762 SchemaKeyspace.java:1136 -
*{color:#de350b}column_name = 666f6f, column_name_bytes = foo{color}*
It should be : +column_name_bytes = {color:#172b4d}666f6f{color}+
{code:java}
INFO [main] 2023-08-07 02:21:53,722 StorageService.java:773 - Populating token
metadata from system tables
INFO [main] 2023-08-07 02:21:53,736 StorageService.java:780 - Token metadata:
Normal Tokens:
localhost/127.0.0.1:[95610762103941981519101009083045058398]INFO [main]
2023-08-07 02:21:53,756 SchemaKeyspace.java:1136 - column_name = column1,
column_name_bytes = column1
INFO [main] 2023-08-07 02:21:53,756 SchemaKeyspace.java:1136 - column_name =
foo, column_name_bytes = foo
INFO [main] 2023-08-07 02:21:53,756 SchemaKeyspace.java:1136 - column_name =
key, column_name_bytes = key
INFO [main] 2023-08-07 02:21:53,756 SchemaKeyspace.java:1136 - column_name =
value, column_name_bytes = value
INFO [main] 2023-08-07 02:21:53,762 SchemaKeyspace.java:1136 - column_name =
666f6f, column_name_bytes = foo // Incorrect!
INFO [main] 2023-08-07 02:21:53,762 SchemaKeyspace.java:1136 - column_name =
column1, column_name_bytes = column1{code}
h1. Reproduce Method
I have attached the data tar file, if start up Cassandra 3.11.15 with it and
inject a the log statement to print out the buffer value, we can notice that
the value is incorrect in the log.
h1. Thoughts
This is a transient bug which won't lead to exceptions or error logs. But the
incorrect byte representation might lead to some issues.
This bug shares the same
[jira] [Updated] (CASSANDRA-18728) [Transient Bug] Incorrect ByteBuffer representation of ColumnIdentifiers when 3.11.15 loading legacy data from 2.x
[
https://issues.apache.org/jira/browse/CASSANDRA-18728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ke Han updated CASSANDRA-18728:
---
Description:
h1. Bug Description
When using Cassandra 3.11.16 to load legacy data from 2.2.10, I noticed that
the byte representation of the column identifier is incorrect.
The legacy data contain two tables, and the schema is as follows.
{code:java}
cqlsh> desc test.alpha ;
CREATE TABLE test.alpha (
key text PRIMARY KEY,
foo text
) WITH COMPACT STORAGE
AND bloom_filter_fp_chance = 0.01
AND caching = '{"keys":"ALL", "rows_per_partition":"NONE"}'
AND comment = ''
AND compaction = {'min_threshold': '4', 'class':
'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
'max_threshold': '32'}
AND compression = {'sstable_compression':
'org.apache.cassandra.io.compress.LZ4Compressor'}
AND dclocal_read_repair_chance = 0.1
AND default_time_to_live = 0
AND gc_grace_seconds = 864000
AND max_index_interval = 2048
AND memtable_flush_period_in_ms = 0
AND min_index_interval = 128
AND read_repair_chance = 0.0
AND speculative_retry = 'NONE';
cqlsh> DESC test.foos ;
CREATE TABLE test.foos (
key text PRIMARY KEY,
"666f6f" text
) WITH COMPACT STORAGE
AND bloom_filter_fp_chance = 0.01
AND caching = '{"keys":"ALL", "rows_per_partition":"NONE"}'
AND comment = ''
AND compaction = {'min_threshold': '4', 'class':
'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
'max_threshold': '32'}
AND compression = {'sstable_compression':
'org.apache.cassandra.io.compress.LZ4Compressor'}
AND dclocal_read_repair_chance = 0.1
AND default_time_to_live = 0
AND gc_grace_seconds = 864000
AND max_index_interval = 2048
AND memtable_flush_period_in_ms = 0
AND min_index_interval = 128
AND read_repair_chance = 0.0
AND speculative_retry = 'NONE';
CREATE INDEX idx_foo ON test.foos ("666f6f"); {code}
There exists a column in test.foo with {*}name = "666f6f"{*}, the corresponding
byte representation should be Hex(666f6f) == {*}363636663666{*}. However, when
3.11.15 loads the data and creating the column, if we check the value in
byteBuffer, the it still stores "666f6f".
{code:java}
// src/java/org/apache/cassandra/schema/SchemaKeyspace.java
public static ColumnDefinition createColumnFromRow(UntypedResultSet.Row row,
Types types)
{
String keyspace = row.getString("keyspace_name");
String table = row.getString("table_name");
ColumnDefinition.Kind kind =
ColumnDefinition.Kind.valueOf(row.getString("kind").toUpperCase());
int position = row.getInt("position");
ClusteringOrder order =
ClusteringOrder.valueOf(row.getString("clustering_order").toUpperCase());
AbstractType type = parse(keyspace, row.getString("type"), types);
if (order == ClusteringOrder.DESC)
type = ReversedType.getInstance(type);
// Injected log to check byteBuffer value
logger.info(String.format("column_name = %s, column_name_bytes = %s" ,
row.getString("column_name"), new
String(row.getBytes("column_name_bytes").array(), StandardCharsets.UTF_8)));
ColumnIdentifier name = new
ColumnIdentifier(row.getBytes("column_name_bytes"),
row.getString("column_name"));
return new ColumnDefinition(keyspace, table, name, type, position, kind);
}{code}
h2. Logs
INFO [main] 2023-08-07 02:21:53,762 SchemaKeyspace.java:1136 -
*{color:#de350b}column_name = 666f6f, column_name_bytes = foo{color}*
It should be : +column_name_bytes = {color:#172b4d}666f6f{color}+
{code:java}
INFO [main] 2023-08-07 02:21:53,722 StorageService.java:773 - Populating token
metadata from system tables
INFO [main] 2023-08-07 02:21:53,736 StorageService.java:780 - Token metadata:
Normal Tokens:
localhost/127.0.0.1:[95610762103941981519101009083045058398]INFO [main]
2023-08-07 02:21:53,756 SchemaKeyspace.java:1136 - column_name = column1,
column_name_bytes = column1
INFO [main] 2023-08-07 02:21:53,756 SchemaKeyspace.java:1136 - column_name =
foo, column_name_bytes = foo
INFO [main] 2023-08-07 02:21:53,756 SchemaKeyspace.java:1136 - column_name =
key, column_name_bytes = key
INFO [main] 2023-08-07 02:21:53,756 SchemaKeyspace.java:1136 - column_name =
value, column_name_bytes = value
INFO [main] 2023-08-07 02:21:53,762 SchemaKeyspace.java:1136 - column_name =
666f6f, column_name_bytes = foo // Incorrect!
INFO [main] 2023-08-07 02:21:53,762 SchemaKeyspace.java:1136 - column_name =
column1, column_name_bytes = column1{code}
h1. Reproduce Method
I have attached the data tar file, if start up Cassandra 3.11.16 with it and
inject a the log statement to print out the buffer value, we can notice that
the value is incorrect in the log.
h1. Thoughts
This is a transient bug which won't lead to exceptions or error logs. But the
incorrect byte representation might lead to some issues.
This bug shares the same
[cassandra-website] branch asf-staging updated (7b4e58257 -> 3ace86f4d)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 7b4e58257 generate docs for bc8bfc13 new 3ace86f4d generate docs for bc8bfc13 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (7b4e58257) \ N -- N -- N refs/heads/asf-staging (3ace86f4d) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch CASS-18231-CEP-7 updated: remove conflict header
This is an automated email from the ASF dual-hosted git repository. polandll pushed a commit to branch CASS-18231-CEP-7 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/CASS-18231-CEP-7 by this push: new b3621317d2 remove conflict header b3621317d2 is described below commit b3621317d2cc07a8420db1b54537aa2d3ce28651 Author: Lorina Poland AuthorDate: Mon Sep 25 14:53:40 2023 -0700 remove conflict header --- doc/modules/cassandra/nav.adoc | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/modules/cassandra/nav.adoc b/doc/modules/cassandra/nav.adoc index 90120629f8..bacf5073db 100644 --- a/doc/modules/cassandra/nav.adoc +++ b/doc/modules/cassandra/nav.adoc @@ -112,4 +112,3 @@ xref:cassandra:reference/cql-commands/drop-index.adoc[] ** xref:cassandra:integrating/plugins/index.adoc[] ->>> 55fdbd6096 (Changes required to add SAI to the docs.) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/02: add reference/index.adoc
This is an automated email from the ASF dual-hosted git repository. polandll pushed a commit to branch CASS-18231-CEP-7 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit c65910c9a048a4d39311bb2efd79bb36a5bb63d2 Author: Lorina Poland AuthorDate: Mon Sep 25 14:50:05 2023 -0700 add reference/index.adoc --- doc/modules/cassandra/pages/reference/index.adoc | 4 1 file changed, 4 insertions(+) diff --git a/doc/modules/cassandra/pages/reference/index.adoc b/doc/modules/cassandra/pages/reference/index.adoc new file mode 100644 index 00..28e17467a8 --- /dev/null +++ b/doc/modules/cassandra/pages/reference/index.adoc @@ -0,0 +1,4 @@ += Reference + +* xref:cassandra:reference/cql-commands/commands-toc.adoc[CQL commands] +* xref:cassandra:reference/java17.adoc[Java 17 usage] \ No newline at end of file - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch CASS-18231-CEP-7 created (now c65910c9a0)
This is an automated email from the ASF dual-hosted git repository. polandll pushed a change to branch CASS-18231-CEP-7 in repository https://gitbox.apache.org/repos/asf/cassandra.git at c65910c9a0 add reference/index.adoc This branch includes the following new commits: new d5c5fd17f5 Add initial SAI docs for CEP-7. new c65910c9a0 add reference/index.adoc The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18811) Set right client auth for creating SSL context in mTLS optional mode
[ https://issues.apache.org/jira/browse/CASSANDRA-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768910#comment-17768910 ] Jon Meredith commented on CASSANDRA-18811: -- Rebased after CASSANDRA-18681 and reran CI CI Results (pending): ||Branch||Source||Circle CI||Jenkins|| |cassandra-5.0|[branch|https://github.com/jonmeredith/cassandra/tree/commit_remote_branch/CASSANDRA-18811-cassandra-5.0-5FC0DA43-601D-43C5-AA55-8B64708CDDBB]|[build|https://app.circleci.com/pipelines/github/jonmeredith/cassandra?branch=commit_remote_branch%2FCASSANDRA-18811-cassandra-5.0-5FC0DA43-601D-43C5-AA55-8B64708CDDBB]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/2603/]| |trunk|[branch|https://github.com/jonmeredith/cassandra/tree/commit_remote_branch/CASSANDRA-18811-trunk-5FC0DA43-601D-43C5-AA55-8B64708CDDBB]|[build|https://app.circleci.com/pipelines/github/jonmeredith/cassandra?branch=commit_remote_branch%2FCASSANDRA-18811-trunk-5FC0DA43-601D-43C5-AA55-8B64708CDDBB]|[build|unknown]| > Set right client auth for creating SSL context in mTLS optional mode > > > Key: CASSANDRA-18811 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18811 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Client, Messaging/Internode >Reporter: Jyothsna Konisa >Assignee: Jyothsna Konisa >Priority: Normal > Fix For: 4.1.x, 5.0-alpha, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Adding a new value `optional` for require_client_auth in Encryption options. > when require_client_auth is optional, the SSL context that is created will > allow client connections that provide a client certificate along with the > client connections that do not provide certificates. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18811) Set right client auth for creating SSL context in mTLS optional mode
[ https://issues.apache.org/jira/browse/CASSANDRA-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Meredith updated CASSANDRA-18811: - Reviewers: Andy Tolbert, Dinesh Joshi, Jon Meredith (was: Jon Meredith) > Set right client auth for creating SSL context in mTLS optional mode > > > Key: CASSANDRA-18811 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18811 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Client, Messaging/Internode >Reporter: Jyothsna Konisa >Assignee: Jyothsna Konisa >Priority: Normal > Fix For: 4.1.x, 5.0-alpha, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Adding a new value `optional` for require_client_auth in Encryption options. > when require_client_auth is optional, the SSL context that is created will > allow client connections that provide a client certificate along with the > client connections that do not provide certificates. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18883) CEP-15: Support State Eviction
Caleb Rackliffe created CASSANDRA-18883: --- Summary: CEP-15: Support State Eviction Key: CASSANDRA-18883 URL: https://issues.apache.org/jira/browse/CASSANDRA-18883 Project: Cassandra Issue Type: Improvement Reporter: Caleb Rackliffe Assignee: Benedict Elliott Smith Permit the state machine to erase transactions that are known to be applied across the cluster. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18681) Internode legacy SSL storage port certificate is not hot reloaded on update
[
https://issues.apache.org/jira/browse/CASSANDRA-18681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Meredith updated CASSANDRA-18681:
-
Fix Version/s: 4.1.4
5.0-alpha2
Since Version: 4.1.0
Source Control Link:
https://github.com/apache/cassandra/commit/b9586501a6b6cdfe465302448018785652c9b966
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Also included a minor fix to examples/sslfactory/build.xml to resolve an error
about duplicate logback libraries on the class path.
> Internode legacy SSL storage port certificate is not hot reloaded on update
> ---
>
> Key: CASSANDRA-18681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18681
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.1.4, 5.0-alpha2
>
>
> In CASSANDRA-1 the SSLContext cache was changed to clear individual
> {{EncryptionOptions}} from the SslContext cache if they needed reloading to
> reduce resource consumption. Before the change if ANY cert needed hot
> reloading, the SSLContext cache would be cleared for ALL certs.
> If the legacy SSL storage port is configured, a new {{EncryptionOptions}}
> object is created in {{org.apache.cassandra.net.InboundSockets#addBindings}}
> just for binding the socket, but never gets cleared as the change in port
> means it no longer matches the configuration retrieved from
> {{DatabaseDescriptor}} in
> {{org.apache.cassandra.net.MessagingServiceMBeanImpl#reloadSslCertificates}}.
> This is unlikely to be an issue in practice as the legacy SSL internode
> socket is only used in mixed version clusters with pre-4.0 nodes, so the cert
> only needs to stay valid until all nodes upgrade to 4.x or above.
> One way to avoid this class of failures is to just check the entries present
> in the SSLContext cache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18681) Internode legacy SSL storage port certificate is not hot reloaded on update
[
https://issues.apache.org/jira/browse/CASSANDRA-18681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Meredith updated CASSANDRA-18681:
-
Status: Ready to Commit (was: Changes Suggested)
> Internode legacy SSL storage port certificate is not hot reloaded on update
> ---
>
> Key: CASSANDRA-18681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18681
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
>
> In CASSANDRA-1 the SSLContext cache was changed to clear individual
> {{EncryptionOptions}} from the SslContext cache if they needed reloading to
> reduce resource consumption. Before the change if ANY cert needed hot
> reloading, the SSLContext cache would be cleared for ALL certs.
> If the legacy SSL storage port is configured, a new {{EncryptionOptions}}
> object is created in {{org.apache.cassandra.net.InboundSockets#addBindings}}
> just for binding the socket, but never gets cleared as the change in port
> means it no longer matches the configuration retrieved from
> {{DatabaseDescriptor}} in
> {{org.apache.cassandra.net.MessagingServiceMBeanImpl#reloadSslCertificates}}.
> This is unlikely to be an issue in practice as the legacy SSL internode
> socket is only used in mixed version clusters with pre-4.0 nodes, so the cert
> only needs to stay valid until all nodes upgrade to 4.x or above.
> One way to avoid this class of failures is to just check the entries present
> in the SSLContext cache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into cassandra-5.0
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a commit to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit a4be70930f4d1bd24ac30b79cf146265da5f3c2f Merge: d16e8d3653 b9586501a6 Author: Jon Meredith AuthorDate: Mon Sep 25 14:25:31 2023 -0600 Merge branch 'cassandra-4.1' into cassandra-5.0 CHANGES.txt| 1 + examples/ssl-factory/build.xml | 2 +- .../cassandra/net/InboundConnectionInitiator.java | 4 +- .../org/apache/cassandra/net/InboundSockets.java | 12 +++ .../cassandra/net/InternodeConnectionUtils.java| 1 + .../cassandra/net/MessagingServiceMBeanImpl.java | 10 +- .../cassandra/net/OutboundConnectionInitiator.java | 3 +- .../org/apache/cassandra/security/SSLFactory.java | 82 +--- .../cassandra/transport/PipelineConfigurator.java | 8 +- .../apache/cassandra/transport/SimpleClient.java | 3 +- .../test/AbstractEncryptionOptionsImpl.java| 2 +- .../security/DefaultSslContextFactoryTest.java | 2 +- .../security/PEMBasedSslContextFactoryTest.java| 4 +- .../apache/cassandra/security/SSLFactoryTest.java | 105 ++--- 14 files changed, 153 insertions(+), 86 deletions(-) diff --cc CHANGES.txt index e5f38dbd9a,d902ca1e1c..c0ffd79145 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,211 -1,6 +1,212 @@@ -4.1.4 +5.0-alpha2 + * Do not create sstable files before registering in txn (CASSANDRA-18737) + * Do not log stacktrace on mismatched cache and schema version and checksum error in AutoSavingCache (CASSANDRA-18862) + * Remove wrong assertion in SSTableLoader (CASSANDRA-18840) + * Fix accessing java.nio.Bits.TOTAL_CAPACITY in Java17 (CASSANDRA-18848) + * Remove metrics-reporter-config dependency (CASSANDRA-18743) + * Fix SAI's SegmentMetadata min and max primary keys (CASSANDRA-18734) + * Remove commons-codec dependency (CASSANDRA-18772) +Merged from 4.1: + * Internode legacy SSL storage port certificate is not hot reloaded on update (CASSANDRA-18681) * Nodetool paxos-only repair is no longer incremental (CASSANDRA-18466) +Merged from 4.0: + * JMH improvements - faster build and async profiler (CASSANDRA-18871) + * Enable 3rd party JDK installations for Debian package (CASSANDRA-18844) +Merged from 3.11: +Merged from 3.0: + * Add cqlshrc.sample and credentials.sample into Debian package (CASSANDRA-18818) + + +5.0-alpha1 + * Fix rpm installations to work with jdk17 (CASSANDRA-18817) + * Fix Depends and Build-Depends for Java for Debian packages (CASSANDRA-18809) + * Update command line flags --add-exports and --add-opens for JDK17 (CASSANDRA-18439) + * Update commons-lang3 to 3.13.0 (CASSANDRA-18789) + * Forbid SAI indexes with analysis options on primary key columns (CASSANDRA-18782) + * Expose bootstrap failure state via JMX and nodetool info (CASSANDRA-18749) + * Reduce size of per-SSTable index components for SAI (CASSANDRA-18673) + * Remove unnecessary Netty dependencies after upgrade to version 4.1.96 (CASSANDRA-18729) + * Prevent InaccessibleObjectException when the Leak Detector is traversing objects (CASSANDRA-18708) + * Remove legacy command line options from cassandra-stress (CASSANDRA-18529) + * Remove commitlog_sync_batch_window_in_ms (CASSANDRA-17161) + * Upgrade JMH from 1.21 to 1.36 (CASSANDRA-18696) + * Add guardrail for vector dimensions (CASSANDRA-18730) + * Upgraded Netty to 4.1.96, added BouncyCastle dependency (CASSANDRA-17992) + * Fix for (unsupported) big endian unaligned architecture, eg s390x (CASSANDRA-17723) + * CIDR filtering authorizer (CASSANDRA-18592) + * Remove 3.x from the versions checked for prepared statement behaviour (CASSANDRA-18695) + * Add vector similarity functions (CASSANDRA-18640) + * Lift MessagingService.minimum_version to 40 (CASSANDRA-18314) + * Introduce pluggable crypto providers and default to AmazonCorrettoCryptoProvider (CASSANDRA-18624) + * Improved DeletionTime serialization (CASSANDRA-18648) + * CEP-7: Storage Attached Indexes (CASSANDRA-16052) + * Add equals/hashCode override for ServerEncryptionOptions (CASSANDRA-18428) + * Upgrade ECJ to version 3.33.0 (CASSANDRA-18190) + * Fix ClassCastException from jdk GaloisCounterMode when using JDK17 provider (CASSANDRA-18180) + * Drop JDK8, add JDK17 (CASSANDRA-18255) + * Remove WaitingOnFreeMemtableSpace and DroppedMutations metrics (CASSANDRA-18298) + * Upgrade Jamm version to 0.4.0 (CASSANDRA-17884, CASSANDRA-16304, CASSANDRA-18329) + * Remove legacy 3.0/3.11 buffer pool metrics (CASSANDRA-18313) + * Add AzureSnitch (CASSANDRA-18646) + * Implementation of the Unified Compaction Strategy as described in CEP-26 (CASSANDRA-18397) + * Upgrade commons cli to 1.5.0 (CASSANDRA-18659) + * Disable the deprecated keyspace/table thresholds and convert them to guardrails (CASSANDRA-18617) + * Deprecate CloudstackSnitch
[cassandra] branch cassandra-4.1 updated: Internode legacy SSL storage port certificate is not hot reloaded on update
This is an automated email from the ASF dual-hosted git repository.
jonmeredith pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.1 by this push:
new b9586501a6 Internode legacy SSL storage port certificate is not hot
reloaded on update
b9586501a6 is described below
commit b9586501a6b6cdfe465302448018785652c9b966
Author: Jon Meredith
AuthorDate: Thu Sep 21 16:07:29 2023 -0600
Internode legacy SSL storage port certificate is not hot reloaded on update
patch by Jon Meredith; reviewed by Dinesh Joshi, Francisco Guerrero for
CASSANDRA-18681
---
CHANGES.txt| 1 +
.../cassandra/net/InboundConnectionInitiator.java | 3 +-
.../org/apache/cassandra/net/InboundSockets.java | 12 +++
.../org/apache/cassandra/net/MessagingService.java | 1 +
.../cassandra/net/MessagingServiceMBeanImpl.java | 10 +-
.../cassandra/net/OutboundConnectionInitiator.java | 4 +-
.../org/apache/cassandra/security/SSLFactory.java | 82 +---
.../cassandra/transport/PipelineConfigurator.java | 8 +-
.../apache/cassandra/transport/SimpleClient.java | 3 +-
.../test/AbstractEncryptionOptionsImpl.java| 2 +-
.../security/DefaultSslContextFactoryTest.java | 2 +-
.../security/PEMBasedSslContextFactoryTest.java| 2 +-
.../apache/cassandra/security/SSLFactoryTest.java | 107 ++---
13 files changed, 153 insertions(+), 84 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index adc7860393..d902ca1e1c 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.1.4
+ * Internode legacy SSL storage port certificate is not hot reloaded on update
(CASSANDRA-18681)
* Nodetool paxos-only repair is no longer incremental (CASSANDRA-18466)
* Waiting indefinitely on ReceivedMessage response in StreamSession#receive()
can cause deadlock (CASSANDRA-18733)
* Allow empty keystore_password in encryption_options (CASSANDRA-18778)
diff --git a/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
b/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
index 807d0262d8..3067b587c9 100644
--- a/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
+++ b/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
@@ -549,7 +549,8 @@ public class InboundConnectionInitiator
{
final boolean verifyPeerCertificate = true;
SslContext sslContext =
SSLFactory.getOrCreateSslContext(encryptionOptions, verifyPeerCertificate,
-
ISslContextFactory.SocketType.SERVER);
+
ISslContextFactory.SocketType.SERVER,
+
SSL_FACTORY_CONTEXT_DESCRIPTION);
InetSocketAddress peer =
encryptionOptions.require_endpoint_verification ? (InetSocketAddress)
channel.remoteAddress() : null;
SslHandler sslHandler = newSslHandler(channel, sslContext, peer);
logger.trace("{} inbound netty SslContext: context={}, engine={}",
description, sslContext.getClass().getName(),
sslHandler.engine().getClass().getName());
diff --git a/src/java/org/apache/cassandra/net/InboundSockets.java
b/src/java/org/apache/cassandra/net/InboundSockets.java
index 58cd88e6d9..80309aa443 100644
--- a/src/java/org/apache/cassandra/net/InboundSockets.java
+++ b/src/java/org/apache/cassandra/net/InboundSockets.java
@@ -24,6 +24,8 @@ import java.util.function.Consumer;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableList;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import io.netty.channel.Channel;
import io.netty.channel.ChannelFuture;
@@ -43,6 +45,7 @@ import org.apache.cassandra.utils.concurrent.FutureCombiner;
class InboundSockets
{
+private static Logger logger =
LoggerFactory.getLogger(InboundSockets.class);
/**
* A simple struct to wrap up the components needed for each listening
socket.
*/
@@ -219,6 +222,15 @@ class InboundSockets
if (settings.encryption.legacy_ssl_storage_port_enabled)
{
+// Initialize hot reloading here rather than in
org.apache.cassandra.security.SSLFactory.initHotReloading
+// as the legacySettings.encryption.sslContextFactory is not
shared outside the messaging system.
+// Any SslContexts created will be checked when
checkCertFilesForHotReloading is called if initialization
+// is successful.
+try {
+
legacySettings.encryption.sslContextFactoryInstance.initHotReloading();
+} catch (Throwable tr) {
+logger.warn("Unable to initialize hot reloading for legacy
internode socket - continuing disabled", tr);
+}
[cassandra] branch trunk updated (77912be753 -> cfe48de019)
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 77912be753 Merge branch 'cassandra-5.0' into trunk new b9586501a6 Internode legacy SSL storage port certificate is not hot reloaded on update new a4be70930f Merge branch 'cassandra-4.1' into cassandra-5.0 new cfe48de019 Merge branch 'cassandra-5.0' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + examples/ssl-factory/build.xml | 2 +- .../cassandra/net/InboundConnectionInitiator.java | 4 +- .../org/apache/cassandra/net/InboundSockets.java | 12 +++ .../cassandra/net/InternodeConnectionUtils.java| 1 + .../cassandra/net/MessagingServiceMBeanImpl.java | 10 +- .../cassandra/net/OutboundConnectionInitiator.java | 3 +- .../org/apache/cassandra/security/SSLFactory.java | 82 +--- .../cassandra/transport/PipelineConfigurator.java | 8 +- .../apache/cassandra/transport/SimpleClient.java | 3 +- .../test/AbstractEncryptionOptionsImpl.java| 2 +- .../security/DefaultSslContextFactoryTest.java | 2 +- .../security/PEMBasedSslContextFactoryTest.java| 4 +- .../apache/cassandra/security/SSLFactoryTest.java | 105 ++--- 14 files changed, 153 insertions(+), 86 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit cfe48de0196993d13d25a799c4d13ac3309d5ae6 Merge: 77912be753 a4be70930f Author: Jon Meredith AuthorDate: Mon Sep 25 14:26:29 2023 -0600 Merge branch 'cassandra-5.0' into trunk CHANGES.txt| 1 + examples/ssl-factory/build.xml | 2 +- .../cassandra/net/InboundConnectionInitiator.java | 4 +- .../org/apache/cassandra/net/InboundSockets.java | 12 +++ .../cassandra/net/InternodeConnectionUtils.java| 1 + .../cassandra/net/MessagingServiceMBeanImpl.java | 10 +- .../cassandra/net/OutboundConnectionInitiator.java | 3 +- .../org/apache/cassandra/security/SSLFactory.java | 82 +--- .../cassandra/transport/PipelineConfigurator.java | 8 +- .../apache/cassandra/transport/SimpleClient.java | 3 +- .../test/AbstractEncryptionOptionsImpl.java| 2 +- .../security/DefaultSslContextFactoryTest.java | 2 +- .../security/PEMBasedSslContextFactoryTest.java| 4 +- .../apache/cassandra/security/SSLFactoryTest.java | 105 ++--- 14 files changed, 153 insertions(+), 86 deletions(-) diff --cc CHANGES.txt index add2a95196,c0ffd79145..183367fda2 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -11,11 -7,12 +11,12 @@@ Merged from 5.0 * Fix SAI's SegmentMetadata min and max primary keys (CASSANDRA-18734) * Remove commons-codec dependency (CASSANDRA-18772) Merged from 4.1: + * Internode legacy SSL storage port certificate is not hot reloaded on update (CASSANDRA-18681) * Nodetool paxos-only repair is no longer incremental (CASSANDRA-18466) Merged from 4.0: - * JMH improvements - faster build and async profiler (CASSANDRA-18871) * Enable 3rd party JDK installations for Debian package (CASSANDRA-18844) Merged from 3.11: + * Revert CASSANDRA-18543 (CASSANDRA-18854) Merged from 3.0: * Add cqlshrc.sample and credentials.sample into Debian package (CASSANDRA-18818) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (d16e8d3653 -> a4be70930f)
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from d16e8d3653 Do not create sstable files before registering in txn new b9586501a6 Internode legacy SSL storage port certificate is not hot reloaded on update new a4be70930f Merge branch 'cassandra-4.1' into cassandra-5.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + examples/ssl-factory/build.xml | 2 +- .../cassandra/net/InboundConnectionInitiator.java | 4 +- .../org/apache/cassandra/net/InboundSockets.java | 12 +++ .../cassandra/net/InternodeConnectionUtils.java| 1 + .../cassandra/net/MessagingServiceMBeanImpl.java | 10 +- .../cassandra/net/OutboundConnectionInitiator.java | 3 +- .../org/apache/cassandra/security/SSLFactory.java | 82 +--- .../cassandra/transport/PipelineConfigurator.java | 8 +- .../apache/cassandra/transport/SimpleClient.java | 3 +- .../test/AbstractEncryptionOptionsImpl.java| 2 +- .../security/DefaultSslContextFactoryTest.java | 2 +- .../security/PEMBasedSslContextFactoryTest.java| 4 +- .../apache/cassandra/security/SSLFactoryTest.java | 105 ++--- 14 files changed, 153 insertions(+), 86 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (1050fc5ae -> 7b4e58257)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 1050fc5ae generate docs for bc8bfc13 new 7b4e58257 generate docs for bc8bfc13 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1050fc5ae) \ N -- N -- N refs/heads/asf-staging (7b4e58257) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768897#comment-17768897 ] Michael Semb Wever edited comment on CASSANDRA-18688 at 9/25/23 8:16 PM: - yes, but that'll change each time we switch supported jdks. can't say i'm a fan of constantly changing the variable name. and i'm keen for the CASSANDRA_ prefix. it's easy to provide specifics in the failure message, e.g. the variable only opens the use of higher jdks. was (Author: michaelsembwever): yes, but that'll change each time we switch supported jdks. can't say i'm a fan of constantly changing the variable name. and i'm keen for the CASSANDRA_ prefix. > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768900#comment-17768900
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
{quote}yes, but that'll change each time we switch supported jdks. can't say
i'm a fan of constantly changing the variable name. and i'm keen for the
CASSANDRA_ prefix.
{quote}
Good point, I am slight more in favor of CASSANDRA_JDK_UNSUPPORTED then
> Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out
> of that
>
>
> Key: CASSANDRA-18688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18688
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: shylaja kokoori
>Priority: Normal
> Fix For: 5.0.x
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, we limit our users from building with non-default Java versions in
> build.xml.
> They can easily hack build.xml for test purposes with different versions.
> Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit
> people to those two, but only to everything >= 11. We should also put an
> upper limit of 17 in our Cassandra startup scripts. We can also add a flag to
> opt-out if someone wants to test with newer versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768900#comment-17768900
]
Ekaterina Dimitrova edited comment on CASSANDRA-18688 at 9/25/23 8:15 PM:
--
{quote}yes, but that'll change each time we switch supported jdks. can't say
i'm a fan of constantly changing the variable name. and i'm keen for the
CASSANDRA_ prefix.
{quote}
Good point, I am personally slightly more in favor of CASSANDRA_JDK_UNSUPPORTED
then
was (Author: e.dimitrova):
{quote}yes, but that'll change each time we switch supported jdks. can't say
i'm a fan of constantly changing the variable name. and i'm keen for the
CASSANDRA_ prefix.
{quote}
Good point, I am slight more in favor of CASSANDRA_JDK_UNSUPPORTED then
> Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out
> of that
>
>
> Key: CASSANDRA-18688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18688
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: shylaja kokoori
>Priority: Normal
> Fix For: 5.0.x
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, we limit our users from building with non-default Java versions in
> build.xml.
> They can easily hack build.xml for test purposes with different versions.
> Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit
> people to those two, but only to everything >= 11. We should also put an
> upper limit of 17 in our Cassandra startup scripts. We can also add a flag to
> opt-out if someone wants to test with newer versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768897#comment-17768897 ] Michael Semb Wever commented on CASSANDRA-18688: yes, but that'll change each time we switch supported jdks. can't say i'm a fan of constantly changing the variable name. and i'm keen for the CASSANDRA_ prefix. > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768896#comment-17768896 ] Ekaterina Dimitrova commented on CASSANDRA-18688: - The thing is that it is not ANY. We prohibit below 11 and between 11 and 17. The flag allows only versions beyond 17 > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768896#comment-17768896
]
Ekaterina Dimitrova edited comment on CASSANDRA-18688 at 9/25/23 8:11 PM:
--
{quote}CASSANDRA_JDK_ANY or CASSANDRA_JDK_UNSUPPORTED ?
{quote}
The thing is that it is not ANY. We prohibit below 11 and between 11 and 17.
The flag allows only versions beyond 17
was (Author: e.dimitrova):
The thing is that it is not ANY. We prohibit below 11 and between 11 and 17.
The flag allows only versions beyond 17
> Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out
> of that
>
>
> Key: CASSANDRA-18688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18688
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: shylaja kokoori
>Priority: Normal
> Fix For: 5.0.x
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, we limit our users from building with non-default Java versions in
> build.xml.
> They can easily hack build.xml for test purposes with different versions.
> Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit
> people to those two, but only to everything >= 11. We should also put an
> upper limit of 17 in our Cassandra startup scripts. We can also add a flag to
> opt-out if someone wants to test with newer versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18707) Test failure: junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-.jdk11
[
https://issues.apache.org/jira/browse/CASSANDRA-18707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768895#comment-17768895
]
Ekaterina Dimitrova commented on CASSANDRA-18707:
-
Sorry, got pulled into something else. I will be looking into this soon
> Test failure:
> junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-.jdk11
>
>
>
> Key: CASSANDRA-18707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18707
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: TESTS-TestSuites.xml.xz
>
>
> Seen here:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1650/testReport/junit.framework/TestSuite/org_apache_cassandra_distributed_test_CASMultiDCTest__jdk11/]
> h3.
> {code:java}
> Error Message
> Schema agreement not reached. Schema versions of the instances:
> [ef1c8e05-a06d-388d-a46d-53cc22a94762, 6c386108-1805-3985-b48e-8016012a0207,
> 6c386108-1805-3985-b48e-8016012a0207, ef1c8e05-a06d-388d-a46d-53cc22a94762]
> Stacktrace
> java.lang.IllegalStateException: Schema agreement not reached. Schema
> versions of the instances: [ef1c8e05-a06d-388d-a46d-53cc22a94762,
> 6c386108-1805-3985-b48e-8016012a0207, 6c386108-1805-3985-b48e-8016012a0207,
> ef1c8e05-a06d-388d-a46d-53cc22a94762] at
> org.apache.cassandra.distributed.impl.AbstractCluster$ChangeMonitor.waitForCompletion(AbstractCluster.java:907)
> at
> org.apache.cassandra.distributed.impl.AbstractCluster.lambda$schemaChange$8(AbstractCluster.java:836)
> at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96) at
> org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61) at
> org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768893#comment-17768893 ] Michael Semb Wever commented on CASSANDRA-18688: CASSANDRA_JDK_ANY or CASSANDRA_JDK_UNSUPPORTED > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768893#comment-17768893 ] Michael Semb Wever edited comment on CASSANDRA-18688 at 9/25/23 8:02 PM: - CASSANDRA_JDK_ANY or CASSANDRA_JDK_UNSUPPORTED ? was (Author: michaelsembwever): CASSANDRA_JDK_ANY or CASSANDRA_JDK_UNSUPPORTED > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17674) Test failure: org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage
[
https://issues.apache.org/jira/browse/CASSANDRA-17674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768891#comment-17768891
]
Ekaterina Dimitrova commented on CASSANDRA-17674:
-
{quote}The difficulty comes from the non-matching code lines even when looking
at the correct jar builds.
{quote}
I am not sure I understand what you mean here.
> Test failure:
> org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage
>
>
> Key: CASSANDRA-17674
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17674
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Andres de la Peña
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
>
> The Java upgrade dtest
> {{org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage}}
> is ~68% flaky on 4.0 and ~2% flaky on trunk, at least in CircleCI:
> * 4.0:
> [https://app.circleci.com/pipelines/github/adelapena/cassandra/1622/workflows/0086c3b1-a552-4c7a-8278-2f759cee5bdf/jobs/17288]
> * trunk:
> [https://app.circleci.com/pipelines/github/adelapena/cassandra/1624/workflows/c4ce2b95-998f-459b-830e-8e3fa6637e15/jobs/17293]
> The error for 4.0 is:
> {code:java}
> java.util.concurrent.ExecutionException: java.lang.RuntimeException:
> java.util.concurrent.ExecutionException: java.lang.RuntimeException:
> java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at
> java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
> at
> java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:227)
> at
> org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage(DropCompactStorageTest.java:49)
> Caused by: java.lang.RuntimeException:
> java.util.concurrent.ExecutionException: java.lang.RuntimeException:
> java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at
> org.apache.cassandra.distributed.impl.IsolatedExecutor$ThrowingRunnable.lambda$toRunnable$0(IsolatedExecutor.java:235)
> at
> java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.util.concurrent.ExecutionException:
> java.lang.RuntimeException: java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> at
> org.apache.cassandra.distributed.impl.IsolatedExecutor$ThrowingRunnable.lambda$toRunnable$0(IsolatedExecutor.java:231)
> Caused by: java.lang.RuntimeException: java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at org.apache.cassandra.utils.Throwables.maybeFail(Throwables.java:62)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$shutdown$28(Instance.java:810)
> at
> org.apache.cassandra.distributed.impl.IsolatedExecutor.lambda$null$8(IsolatedExecutor.java:114)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> Caused by: java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at
> org.apache.cassandra.utils.ExecutorUtils.awaitTerminationUntil(ExecutorUtils.java:107)
> at
>
[jira] [Updated] (CASSANDRA-17674) Test failure: org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage
[
https://issues.apache.org/jira/browse/CASSANDRA-17674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-17674:
Reviewers: (was: Ekaterina Dimitrova)
> Test failure:
> org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage
>
>
> Key: CASSANDRA-17674
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17674
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Andres de la Peña
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
>
> The Java upgrade dtest
> {{org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage}}
> is ~68% flaky on 4.0 and ~2% flaky on trunk, at least in CircleCI:
> * 4.0:
> [https://app.circleci.com/pipelines/github/adelapena/cassandra/1622/workflows/0086c3b1-a552-4c7a-8278-2f759cee5bdf/jobs/17288]
> * trunk:
> [https://app.circleci.com/pipelines/github/adelapena/cassandra/1624/workflows/c4ce2b95-998f-459b-830e-8e3fa6637e15/jobs/17293]
> The error for 4.0 is:
> {code:java}
> java.util.concurrent.ExecutionException: java.lang.RuntimeException:
> java.util.concurrent.ExecutionException: java.lang.RuntimeException:
> java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at
> java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
> at
> java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:227)
> at
> org.apache.cassandra.distributed.upgrade.DropCompactStorageTest.testDropCompactStorage(DropCompactStorageTest.java:49)
> Caused by: java.lang.RuntimeException:
> java.util.concurrent.ExecutionException: java.lang.RuntimeException:
> java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at
> org.apache.cassandra.distributed.impl.IsolatedExecutor$ThrowingRunnable.lambda$toRunnable$0(IsolatedExecutor.java:235)
> at
> java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.util.concurrent.ExecutionException:
> java.lang.RuntimeException: java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> at
> org.apache.cassandra.distributed.impl.IsolatedExecutor$ThrowingRunnable.lambda$toRunnable$0(IsolatedExecutor.java:231)
> Caused by: java.lang.RuntimeException: java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at org.apache.cassandra.utils.Throwables.maybeFail(Throwables.java:62)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$shutdown$28(Instance.java:810)
> at
> org.apache.cassandra.distributed.impl.IsolatedExecutor.lambda$null$8(IsolatedExecutor.java:114)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> Caused by: java.util.concurrent.TimeoutException:
> org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor@6fa17524[Shutting
> down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks =
> 218] did not terminate on time
> at
> org.apache.cassandra.utils.ExecutorUtils.awaitTerminationUntil(ExecutorUtils.java:107)
> at
> org.apache.cassandra.utils.ExecutorUtils.awaitTermination(ExecutorUtils.java:96)
> at
> org.apache.cassandra.utils.ExecutorUtils.shutdownNowAndWait(ExecutorUtils.java:139)
> at
>
[jira] [Updated] (CASSANDRA-18866) Node sends multiple inflight echos
[ https://issues.apache.org/jira/browse/CASSANDRA-18866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18866: -- Test and Documentation Plan: CI Status: Patch Available (was: In Progress) > Node sends multiple inflight echos > -- > > Key: CASSANDRA-18866 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18866 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Cameron Zemek >Assignee: Cameron Zemek >Priority: Normal > Attachments: 18866-regression.patch, duplicates.log, echo.log > > > CASSANDRA-18854 rolled back the changes from CASSANDRA-18845. In particular, > 18845 had change to only allow 1 inflight ECHO request at a time. As per > 18854 some tests have an error rate due to this change. Creating this ticket > to discuss this further. As the current state also does not have retry logic, > it just allowing multiple ECHO requests inflight at the same time so less > likely that all ECHO will timeout or get lost. > With the change from 18845 adding in some extra logging to track what is > going on, I do see it retrying ECHOs. Likewise, I patched a node to drop ECHO > requests from a node and also see it retrying ECHOs when it doesn't get a > reply. > Therefore, I think the problem is more specific than the dropping of one ECHO > request. Yes there no retry logic for failed ECHO requests, but this is the > case even both before and after 18845. ECHO requests are only sent via gossip > verb handlers calling applyStateLocally. In these failed tests I therefore > assuming their cases where it won't call markAlive when other nodes consider > the node UP but its marked DOWN by a node. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18773) Compactions are slow
[
https://issues.apache.org/jira/browse/CASSANDRA-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18773:
--
Status: Ready to Commit (was: Review In Progress)
> Compactions are slow
>
>
> Key: CASSANDRA-18773
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18773
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction
>Reporter: Cameron Zemek
>Assignee: Cameron Zemek
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: 18773.patch, compact-poc.patch, flamegraph.png,
> stress.yaml
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> I have noticed that compactions involving a lot of sstables are very slow
> (for example major compactions). I have attached a cassandra stress profile
> that can generate such a dataset under ccm. In my local test I have 2567
> sstables at 4Mb each.
> I added code to track wall clock time of various parts of the code. One
> problematic part is ManyToOne constructor. Tracing through the code for every
> partition creating a ManyToOne for all the sstable iterators for each
> partition. In my local test get a measy 60Kb/sec read speed, and bottlenecked
> on single core CPU (since this code is single threaded) with it spending 85%
> of the wall clock time in ManyToOne constructor.
> As another datapoint to show its the merge iterator part of the code using
> the cfstats from [https://github.com/instaclustr/cassandra-sstable-tools/]
> which reads all the sstables but does no merging gets 26Mb/sec read speed.
> Tracking back from ManyToOne call I see this in
> UnfilteredPartitionIterators::merge
> {code:java}
> for (int i = 0; i < toMerge.size(); i++)
> {
> if (toMerge.get(i) == null)
> {
> if (null == empty)
> empty = EmptyIterators.unfilteredRow(metadata,
> partitionKey, isReverseOrder);
> toMerge.set(i, empty);
> }
> }
> {code}
> Not sure what purpose of creating these empty rows are. But on a whim I
> removed all these empty iterators before passing to ManyToOne and then all
> the wall clock time shifted to CompactionIterator::hasNext() and read speed
> increased to 1.5Mb/s.
> So there are further bottlenecks in this code path it seems, but the first is
> this ManyToOne and having to build it for every partition read.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18773) Compactions are slow
[
https://issues.apache.org/jira/browse/CASSANDRA-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768884#comment-17768884
]
Stefan Miklosovic commented on CASSANDRA-18773:
---
Does anybody else want to take a look? [~blambov] already +1ed that on the PR
so I guess if nobody objects how the builds look like we can approach the
actual merge?
I'll give it a day or two, my target is to merge on this Wednesday 27th.
> Compactions are slow
>
>
> Key: CASSANDRA-18773
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18773
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction
>Reporter: Cameron Zemek
>Assignee: Cameron Zemek
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: 18773.patch, compact-poc.patch, flamegraph.png,
> stress.yaml
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> I have noticed that compactions involving a lot of sstables are very slow
> (for example major compactions). I have attached a cassandra stress profile
> that can generate such a dataset under ccm. In my local test I have 2567
> sstables at 4Mb each.
> I added code to track wall clock time of various parts of the code. One
> problematic part is ManyToOne constructor. Tracing through the code for every
> partition creating a ManyToOne for all the sstable iterators for each
> partition. In my local test get a measy 60Kb/sec read speed, and bottlenecked
> on single core CPU (since this code is single threaded) with it spending 85%
> of the wall clock time in ManyToOne constructor.
> As another datapoint to show its the merge iterator part of the code using
> the cfstats from [https://github.com/instaclustr/cassandra-sstable-tools/]
> which reads all the sstables but does no merging gets 26Mb/sec read speed.
> Tracking back from ManyToOne call I see this in
> UnfilteredPartitionIterators::merge
> {code:java}
> for (int i = 0; i < toMerge.size(); i++)
> {
> if (toMerge.get(i) == null)
> {
> if (null == empty)
> empty = EmptyIterators.unfilteredRow(metadata,
> partitionKey, isReverseOrder);
> toMerge.set(i, empty);
> }
> }
> {code}
> Not sure what purpose of creating these empty rows are. But on a whim I
> removed all these empty iterators before passing to ManyToOne and then all
> the wall clock time shifted to CompactionIterator::hasNext() and read speed
> increased to 1.5Mb/s.
> So there are further bottlenecks in this code path it seems, but the first is
> this ManyToOne and having to build it for every partition read.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18773) Compactions are slow
[
https://issues.apache.org/jira/browse/CASSANDRA-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18773:
--
Reviewers: Branimir Lambov, Stefan Miklosovic
Status: Review In Progress (was: Needs Committer)
> Compactions are slow
>
>
> Key: CASSANDRA-18773
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18773
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction
>Reporter: Cameron Zemek
>Assignee: Cameron Zemek
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: 18773.patch, compact-poc.patch, flamegraph.png,
> stress.yaml
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> I have noticed that compactions involving a lot of sstables are very slow
> (for example major compactions). I have attached a cassandra stress profile
> that can generate such a dataset under ccm. In my local test I have 2567
> sstables at 4Mb each.
> I added code to track wall clock time of various parts of the code. One
> problematic part is ManyToOne constructor. Tracing through the code for every
> partition creating a ManyToOne for all the sstable iterators for each
> partition. In my local test get a measy 60Kb/sec read speed, and bottlenecked
> on single core CPU (since this code is single threaded) with it spending 85%
> of the wall clock time in ManyToOne constructor.
> As another datapoint to show its the merge iterator part of the code using
> the cfstats from [https://github.com/instaclustr/cassandra-sstable-tools/]
> which reads all the sstables but does no merging gets 26Mb/sec read speed.
> Tracking back from ManyToOne call I see this in
> UnfilteredPartitionIterators::merge
> {code:java}
> for (int i = 0; i < toMerge.size(); i++)
> {
> if (toMerge.get(i) == null)
> {
> if (null == empty)
> empty = EmptyIterators.unfilteredRow(metadata,
> partitionKey, isReverseOrder);
> toMerge.set(i, empty);
> }
> }
> {code}
> Not sure what purpose of creating these empty rows are. But on a whim I
> removed all these empty iterators before passing to ManyToOne and then all
> the wall clock time shifted to CompactionIterator::hasNext() and read speed
> increased to 1.5Mb/s.
> So there are further bottlenecks in this code path it seems, but the first is
> this ManyToOne and having to build it for every partition read.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18547) Refactor cqlsh On/Off switch implementation and make the output consistent
[
https://issues.apache.org/jira/browse/CASSANDRA-18547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768612#comment-17768612
]
Stefan Miklosovic edited comment on CASSANDRA-18547 at 9/25/23 7:21 PM:
trunk j17 pre-commit
https://app.circleci.com/pipelines/github/instaclustr/cassandra/3229/workflows/6156bd0d-2363-44b0-8f1b-59a55581aec3
5.0 j17 pre-commit
https://app.circleci.com/pipelines/github/instaclustr/cassandra/3231/workflows/196b607b-320a-4f33-8974-d530ee81f642
The original patch for dtest (1) had one minor problem in it. The above build
is the result of this branch (2) with the fix (3).
Since this is changing only Python stuff, I do not consider a build for Java 11
necessary.
This was built for trunk but should go to 5.0 (4) as well.
I manually tested that dtests still work with cassandra-4.1 branch.
(1) https://github.com/apache/cassandra-dtest/pull/232/files
(2) https://github.com/instaclustr/cassandra/commits/CASSANDRA-18547-trunk
(3)
https://github.com/smiklosovic/cassandra-dtest/commit/f2d575e80005c9c9713743197b9ab4249359aac7
(4)
https://github.com/instaclustr/cassandra/commit/23eccd18220ddd7a46e5806da904adde0e149328
was (Author: smiklosovic):
trunk j17 pre-commit
https://app.circleci.com/pipelines/github/instaclustr/cassandra/3223/workflows/6f148552-ea7b-4f1b-bb08-a549b60e1b05
5.0 j17 pre-commit
https://app.circleci.com/pipelines/github/instaclustr/cassandra/3231/workflows/196b607b-320a-4f33-8974-d530ee81f642
The original patch for dtest (1) had one minor problem in it. The above build
is the result of this branch (2) with the fix (3).
Since this is changing only Python stuff, I do not consider a build for Java 11
necessary.
This was built for trunk but should go to 5.0 (4) as well.
I manually tested that dtests still work with cassandra-4.1 branch.
(1) https://github.com/apache/cassandra-dtest/pull/232/files
(2) https://github.com/instaclustr/cassandra/commits/CASSANDRA-18547-trunk
(3)
https://github.com/smiklosovic/cassandra-dtest/commit/f2d575e80005c9c9713743197b9ab4249359aac7
(4)
https://github.com/instaclustr/cassandra/commit/23eccd18220ddd7a46e5806da904adde0e149328
> Refactor cqlsh On/Off switch implementation and make the output consistent
> --
>
> Key: CASSANDRA-18547
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18547
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This change refactors the On/Off switch implemented in the class
> SwitchCommand and subclass SwitchCommandWithValue of cqlshmain.py to use an
> Enum with static methods instead of custom classes.
> The body of on_off_switch + enum definition requires just 15 lines of code vs
> 33 in SwitchCommand.
> The existing code is hard to read, including the usage in the code, which
> instantiates a SwitchCommand object in-order to invoke the execute method:
>
> {code:java}
> self.tracing_enabled = SwitchCommand("TRACING",
> "Tracing").execute(self.tracing_enabled, parsed, self.printerr){code}
> this can be replaced by a more familiar direct function call:
> {code:java}
> self.tracing_enabled = self.on_off_toggle("TRACING", "Tracing",
> self.tracing_enabled, parsed.get_binding('switch')){code}
>
> The refactoring also updates the command output for consistency. Instead of
> the current:
> {code:java}
> > tracing on
> Now Tracing is enabled
> > paging on
> Query paging is already enabled. Use PAGING OFF to disable.
> > expand on
> Now Expanded output is enabled
> {code}
> replace with more succinct and consistent, using 'ON/OFF' instead of
> enabled/disabled and removing the redundant 'Now':
> {code:java}
> > tracing on
> TRACING set to ON
> > paging on
> PAGING is already ON
> > expand on
> EXPAND set to ON
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-75) Shaded Sidecar client should shade Jackson completely to avoid incompatibility issues
[ https://issues.apache.org/jira/browse/CASSANDRASC-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRASC-75: -- Reviewers: Dinesh Joshi, Francisco Guerrero Status: Review In Progress (was: Patch Available) > Shaded Sidecar client should shade Jackson completely to avoid > incompatibility issues > - > > Key: CASSANDRASC-75 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-75 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 1.0 > > > Before, we were shading almost all of Jackson but left the annotations > unshaded/relocated. However, this causes problems in older Spark environments > where the annotations in the class path don’t quite match what the other > shaded parts of Jackson expect (missing classes being the most serious > issue). This can cause the library to fail on certain Spark versions. > > We should shade +all+ of Jackson in the shaded client to prevent these issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] 5 closed pull request #15: [CASSANDRA-18810] Cassandra Analytics Start-Up Validation
5 closed pull request #15: [CASSANDRA-18810] Cassandra Analytics Start-Up Validation URL: https://github.com/apache/cassandra-analytics/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18810) Cassandra Analytics Start-Up Validation
[ https://issues.apache.org/jira/browse/CASSANDRA-18810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18810: -- Fix Version/s: NA Source Control Link: https://github.com/apache/cassandra-analytics/commit/f24951ab6ea2b1e9af4013b030675c70d31adb90 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as [f24951ab|https://github.com/apache/cassandra-analytics/commit/f24951ab6ea2b1e9af4013b030675c70d31adb90] > Cassandra Analytics Start-Up Validation > --- > > Key: CASSANDRA-18810 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18810 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Fix For: NA > > Time Spent: 6.5h > Remaining Estimate: 0h > > Cassandra Analytics should perform a start-up validation of network > connectivity to Cassandra and Cassandra Sidecar, as well as of authentication > materials -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-analytics] branch trunk updated: CASSANDRA-18810: Cassandra Analytics Start-Up Validation
This is an automated email from the ASF dual-hosted git repository.
ycai pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-analytics.git
The following commit(s) were added to refs/heads/trunk by this push:
new f24951a CASSANDRA-18810: Cassandra Analytics Start-Up Validation
f24951a is described below
commit f24951ab6ea2b1e9af4013b030675c70d31adb90
Author: Yuriy Semchyshyn
AuthorDate: Mon Aug 14 14:09:12 2023 -0500
CASSANDRA-18810: Cassandra Analytics Start-Up Validation
Patch by Yuriy Semchyshyn; Reviewed by Dinesh Joshi, Francisco Guerrero,
Yifan Cai for CASSANDRA-18810
---
CHANGES.txt| 1 +
build.gradle | 1 +
.../java/org/apache/cassandra/clients/Sidecar.java | 36 --
.../cassandra/spark/bulkwriter/BulkSparkConf.java | 18 ++-
.../bulkwriter/CassandraBulkWriterContext.java | 10 +-
.../spark/bulkwriter/CassandraClusterInfo.java | 8 ++
.../spark/bulkwriter/CassandraContext.java | 16 ++-
.../cassandra/spark/bulkwriter/ClusterInfo.java| 3 +-
.../cassandra/spark/bulkwriter/RecordWriter.java | 2 +
.../cassandra/spark/data/CassandraDataLayer.java | 20 ++-
.../spark/data/CassandraDataSourceHelper.java | 3 +
.../spark/validation/CassandraValidation.java | 58 +
.../spark/validation/KeyStoreValidation.java | 94 ++
.../spark/validation/SidecarValidation.java| 58 +
.../cassandra/spark/validation/SslValidation.java | 48 +++
.../spark/validation/StartupValidatable.java | 33 +
.../spark/validation/StartupValidation.java| 49 +++
.../spark/validation/StartupValidator.java | 79
.../spark/validation/TrustStoreValidation.java | 93 ++
.../cassandra/secrets/TestSecretsProvider.java | 141 +
.../spark/bulkwriter/MockBulkWriterContext.java| 9 ++
.../spark/validation/KeyStoreValidationTests.java | 99 +++
.../spark/validation/StartupValidatorTests.java| 74 +++
.../cassandra/spark/validation/TestValidation.java | 52
.../validation/TrustStoreValidationTests.java | 97 ++
.../resources/validation/keystore-certificate.p12 | Bin 0 -> 1046 bytes
.../test/resources/validation/keystore-empty.p12 | Bin 0 -> 103 bytes
.../resources/validation/keystore-malformed.p12| 1 +
.../test/resources/validation/keystore-private.p12 | Bin 0 -> 2520 bytes
.../test/resources/validation/keystore-secret.p12 | Bin 0 -> 405 bytes
.../org/apache/cassandra/spark/utils/Throwing.java | 20 +++
31 files changed, 1102 insertions(+), 21 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 37b126d..a26e455 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
1.0.0
+ * Cassandra Analytics Start-Up Validation (CASSANDRA-18810)
* Expose per partition on-disk usage through new DataFrame that utilizes the
Index.db SSTable file components (CASSANDRA-18683)
* Fix bulk writes with Buffered RowBufferMode (CASSANDRA-18692)
* Minor Refactoring to Improve Code Reusability (CASSANDRA-18684)
diff --git a/build.gradle b/build.gradle
index 837c6fe..eb689a4 100644
--- a/build.gradle
+++ b/build.gradle
@@ -70,6 +70,7 @@ tasks.register('buildIgnoreRatList', Exec) {
description 'Builds a list of ignored files for the rat task from the
unversioned git files'
commandLine 'bash', '-c', 'git clean --force -d --dry-run -x | cut -c 14-'
doFirst {
+Files.createDirectories(file("${buildDir}").toPath())
standardOutput new FileOutputStream("${buildDir}/.rat-excludes.txt")
}
// allows task to fail when git/cut commands are unavailable or fail
diff --git
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java
index 0871ddd..f1f7c1f 100644
---
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java
+++
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java
@@ -37,7 +37,8 @@ import o.a.c.sidecar.client.shaded.io.vertx.core.VertxOptions;
import org.apache.cassandra.secrets.SecretsProvider;
import org.apache.cassandra.sidecar.client.HttpClientConfig;
import org.apache.cassandra.sidecar.client.SidecarClient;
-import org.apache.cassandra.sidecar.client.SidecarConfig;
+import org.apache.cassandra.sidecar.client.SidecarClientConfig;
+import org.apache.cassandra.sidecar.client.SidecarClientConfigImpl;
import org.apache.cassandra.sidecar.client.SidecarInstance;
import org.apache.cassandra.sidecar.client.SidecarInstancesProvider;
import org.apache.cassandra.sidecar.client.VertxHttpClient;
@@ -49,6 +50,10 @@ import org.apache.cassandra.spark.bulkwriter.BulkSparkConf;
import org.apache.cassandra.spark.data.FileType;
import
[jira] [Assigned] (CASSANDRA-18361) Test Failure: secondary_indexes_test.py::TestSecondaryIndexes::test_failing_manual_rebuild_index
[
https://issues.apache.org/jira/browse/CASSANDRA-18361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski reassigned CASSANDRA-18361:
-
Assignee: Jacek Lewandowski
> Test Failure:
> secondary_indexes_test.py::TestSecondaryIndexes::test_failing_manual_rebuild_index
>
>
> Key: CASSANDRA-18361
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18361
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Andres de la Peña
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The Python dtest
> {{secondary_indexes_test.py::TestSecondaryIndexes::test_failing_manual_rebuild_index}}
> is flaky, at least for trunk:
> *
> https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/secondary_indexes_test/TestSecondaryIndexes/test_failing_manual_rebuild_index
> *
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1501/testReport/dtest.secondary_indexes_test/TestSecondaryIndexes/test_failing_manual_rebuild_index/
> {code}
> Error Message
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node1] 'ERROR [Reference-Reaper] 2023-03-23
> 00:23:43,597 Ref.java:237 - LEAK DETECTED: a reference (class
> org.apache.cassandra.io.util.FileHandle$Cleanup@967019010:/home/cassandra/cassandra/cassandra-dtest/tmp/dtest-hgjoy8rq/test/node1/data0/k/t-b7dae870c91011eda58f05bc40bfcaa1/nc-1-big-Index.db)
> to class
> org.apache.cassandra.io.util.FileHandle$Cleanup@967019010:/home/cassandra/cassandra/cassandra-dtest/tmp/dtest-hgjoy8rq/test/node1/data0/k/t-b7dae870c91011eda58f05bc40bfcaa1/nc-1-big-Index.db
> was not released before the reference was garbage collected']"
> Stacktrace
> Unexpected error found in node logs (see stdout for full details). Errors:
> [[node1] 'ERROR [Reference-Reaper] 2023-03-23 00:23:43,597 Ref.java:237 -
> LEAK DETECTED: a reference (class
> org.apache.cassandra.io.util.FileHandle$Cleanup@967019010:/home/cassandra/cassandra/cassandra-dtest/tmp/dtest-hgjoy8rq/test/node1/data0/k/t-b7dae870c91011eda58f05bc40bfcaa1/nc-1-big-Index.db)
> to class
> org.apache.cassandra.io.util.FileHandle$Cleanup@967019010:/home/cassandra/cassandra/cassandra-dtest/tmp/dtest-hgjoy8rq/test/node1/data0/k/t-b7dae870c91011eda58f05bc40bfcaa1/nc-1-big-Index.db
> was not released before the reference was garbage collected']
> {code}
> The failure can be reproduced in CircleCI:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2732/workflows/829434ab-2d1a-4e1c-8c7f-42449fcfda22
> The CircleCI config I used to reproduce the test failure can be generated
> with:
> {code}
> .circleci/generate.sh -p \
> -e REPEATED_DTESTS_COUNT=200 \
> -e
> REPEATED_DTESTS=secondary_indexes_test.py::TestSecondaryIndexes::test_failing_manual_rebuild_index
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18810) Cassandra Analytics Start-Up Validation
[ https://issues.apache.org/jira/browse/CASSANDRA-18810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18810: -- Status: Review In Progress (was: Patch Available) > Cassandra Analytics Start-Up Validation > --- > > Key: CASSANDRA-18810 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18810 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 6.5h > Remaining Estimate: 0h > > Cassandra Analytics should perform a start-up validation of network > connectivity to Cassandra and Cassandra Sidecar, as well as of authentication > materials -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18810) Cassandra Analytics Start-Up Validation
[ https://issues.apache.org/jira/browse/CASSANDRA-18810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18810: -- Status: Ready to Commit (was: Review In Progress) > Cassandra Analytics Start-Up Validation > --- > > Key: CASSANDRA-18810 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18810 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 6.5h > Remaining Estimate: 0h > > Cassandra Analytics should perform a start-up validation of network > connectivity to Cassandra and Cassandra Sidecar, as well as of authentication > materials -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18810) Cassandra Analytics Start-Up Validation
[ https://issues.apache.org/jira/browse/CASSANDRA-18810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuriy Semchyshyn updated CASSANDRA-18810: - Test and Documentation Plan: https://github.com/apache/cassandra-analytics/pull/15 Status: Patch Available (was: Open) > Cassandra Analytics Start-Up Validation > --- > > Key: CASSANDRA-18810 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18810 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 6.5h > Remaining Estimate: 0h > > Cassandra Analytics should perform a start-up validation of network > connectivity to Cassandra and Cassandra Sidecar, as well as of authentication > materials -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-75) Shaded Sidecar client should shade Jackson completely to avoid incompatibility issues
[ https://issues.apache.org/jira/browse/CASSANDRASC-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768822#comment-17768822 ] Francisco Guerrero commented on CASSANDRASC-75: --- +1, thanks for the patch! > Shaded Sidecar client should shade Jackson completely to avoid > incompatibility issues > - > > Key: CASSANDRASC-75 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-75 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 1.0 > > > Before, we were shading almost all of Jackson but left the annotations > unshaded/relocated. However, this causes problems in older Spark environments > where the annotations in the class path don’t quite match what the other > shaded parts of Jackson expect (missing classes being the most serious > issue). This can cause the library to fail on certain Spark versions. > > We should shade +all+ of Jackson in the shaded client to prevent these issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18810) Cassandra Analytics Start-Up Validation
[ https://issues.apache.org/jira/browse/CASSANDRA-18810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18810: -- Reviewers: Dinesh Joshi, Francisco Guerrero, Yifan Cai (was: Francisco Guerrero, Yifan Cai) > Cassandra Analytics Start-Up Validation > --- > > Key: CASSANDRA-18810 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18810 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 6.5h > Remaining Estimate: 0h > > Cassandra Analytics should perform a start-up validation of network > connectivity to Cassandra and Cassandra Sidecar, as well as of authentication > materials -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768821#comment-17768821
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Thanks [~skokoori] , I left a round of review comments on the PR.
{quote}I have added an env var CASSANDRA_USE_ALL_JDK to enable non-LTS Java
use. Does that name work?
{quote}
Naming is hard!
How about USE_POST_JDK_17? Technically, we allow those now, but not all JDKs. I
am open to other suggestions, too.
> Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out
> of that
>
>
> Key: CASSANDRA-18688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18688
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: shylaja kokoori
>Priority: Normal
> Fix For: 5.0.x
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, we limit our users from building with non-default Java versions in
> build.xml.
> They can easily hack build.xml for test purposes with different versions.
> Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit
> people to those two, but only to everything >= 11. We should also put an
> upper limit of 17 in our Cassandra startup scripts. We can also add a flag to
> opt-out if someone wants to test with newer versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18810) Cassandra Analytics Start-Up Validation
[ https://issues.apache.org/jira/browse/CASSANDRA-18810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768820#comment-17768820 ] Yifan Cai commented on CASSANDRA-18810: --- +1 on the patch. > Cassandra Analytics Start-Up Validation > --- > > Key: CASSANDRA-18810 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18810 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 6.5h > Remaining Estimate: 0h > > Cassandra Analytics should perform a start-up validation of network > connectivity to Cassandra and Cassandra Sidecar, as well as of authentication > materials -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768819#comment-17768819 ] Maxim Muzafarov commented on CASSANDRA-18878: - The build: https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/374/workflows/e96bfe2c-7cad-4eeb-9673-937ea5595f7c > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.11.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18737) Test failure: org.apache.cassandra.io.sstable.SSTableLoaderTest (testLoadingIncompleteSSTable-.jdk17)
[
https://issues.apache.org/jira/browse/CASSANDRA-18737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18737:
--
Fix Version/s: 5.0-alpha2
5.1
(was: 5.x)
(was: 5.0.x)
Since Version: 5.0-alpha1
Source Control Link:
https://github.com/apache/cassandra/commit/d16e8d3653dce8ed767a040c06dbaabc47a9b474
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Test failure: org.apache.cassandra.io.sstable.SSTableLoaderTest
> (testLoadingIncompleteSSTable-.jdk17)
> -
>
> Key: CASSANDRA-18737
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18737
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Brandon Williams
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-alpha2, 5.1
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {noformat}
> java.lang.RuntimeException: Failed to list files in
> /tmp/1409486429862512729/SSTableLoaderTest/Standard2-57877ac036d311eea01f83fcb8f6fee5
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:77)
> at
> org.apache.cassandra.db.lifecycle.LifecycleTransaction.getFiles(LifecycleTransaction.java:626)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.openSSTables(SSTableLoader.java:103)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.stream(SSTableLoader.java:202)
> at
> org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable(SSTableLoaderTest.java:213)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: org.apache.cassandra.io.sstable.CorruptSSTableException:
> Corrupted:
> /tmp/1409486429862512729/SSTableLoaderTest/Standard2-57877ac036d311eea01f83fcb8f6fee5/nc-17-big
> at
> org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder.build(SSTableReaderLoadingBuilder.java:111)
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:397)
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.openForBatch(SSTableReader.java:373)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.lambda$openSSTables$0(SSTableLoader.java:152)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.lambda$innerList$2(LogAwareFileLister.java:99)
> at
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178)
> at
> java.base/java.util.TreeMap$EntrySpliterator.forEachRemaining(TreeMap.java:3287)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.innerList(LogAwareFileLister.java:101)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:73)
> Caused by: java.lang.NullPointerException
> at
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:903)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.buildSummaryAndBloomFilter(BigSSTableReaderLoadingBuilder.java:193)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.openComponents(BigSSTableReaderLoadingBuilder.java:116)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.openComponents(BigSSTableReaderLoadingBuilder.java:58)
> at
> org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder.build(SSTableReaderLoadingBuilder.java:92)
> {noformat}
> Seen here:
> https://app.circleci.com/pipelines/github/driftx/cassandra/1174/workflows/263f1e22-e4d0-48b8-b3e2-496edb30a068/jobs/41924/tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18737) Test failure: org.apache.cassandra.io.sstable.SSTableLoaderTest (testLoadingIncompleteSSTable-.jdk17)
[
https://issues.apache.org/jira/browse/CASSANDRA-18737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18737:
--
Status: Ready to Commit (was: Review In Progress)
> Test failure: org.apache.cassandra.io.sstable.SSTableLoaderTest
> (testLoadingIncompleteSSTable-.jdk17)
> -
>
> Key: CASSANDRA-18737
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18737
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Brandon Williams
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {noformat}
> java.lang.RuntimeException: Failed to list files in
> /tmp/1409486429862512729/SSTableLoaderTest/Standard2-57877ac036d311eea01f83fcb8f6fee5
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:77)
> at
> org.apache.cassandra.db.lifecycle.LifecycleTransaction.getFiles(LifecycleTransaction.java:626)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.openSSTables(SSTableLoader.java:103)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.stream(SSTableLoader.java:202)
> at
> org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable(SSTableLoaderTest.java:213)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: org.apache.cassandra.io.sstable.CorruptSSTableException:
> Corrupted:
> /tmp/1409486429862512729/SSTableLoaderTest/Standard2-57877ac036d311eea01f83fcb8f6fee5/nc-17-big
> at
> org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder.build(SSTableReaderLoadingBuilder.java:111)
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:397)
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.openForBatch(SSTableReader.java:373)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.lambda$openSSTables$0(SSTableLoader.java:152)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.lambda$innerList$2(LogAwareFileLister.java:99)
> at
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178)
> at
> java.base/java.util.TreeMap$EntrySpliterator.forEachRemaining(TreeMap.java:3287)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.innerList(LogAwareFileLister.java:101)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:73)
> Caused by: java.lang.NullPointerException
> at
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:903)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.buildSummaryAndBloomFilter(BigSSTableReaderLoadingBuilder.java:193)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.openComponents(BigSSTableReaderLoadingBuilder.java:116)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.openComponents(BigSSTableReaderLoadingBuilder.java:58)
> at
> org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder.build(SSTableReaderLoadingBuilder.java:92)
> {noformat}
> Seen here:
> https://app.circleci.com/pipelines/github/driftx/cassandra/1174/workflows/263f1e22-e4d0-48b8-b3e2-496edb30a068/jobs/41924/tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 77912be753a1fde8436746d3df946a400d180656 Merge: 02cdaf5b92 d16e8d3653 Author: Jacek Lewandowski AuthorDate: Mon Sep 25 18:47:56 2023 +0200 Merge branch 'cassandra-5.0' into trunk * cassandra-5.0: Do not create sstable files before registering in txn CHANGES.txt| 4 +- .../cassandra/db/compaction/CompactionManager.java | 4 +- .../apache/cassandra/db/compaction/Upgrader.java | 2 +- .../db/compaction/unified/ShardedMultiWriter.java | 2 +- .../compaction/writers/CompactionAwareWriter.java | 2 +- .../io/compress/CompressedSequentialWriter.java| 2 +- .../io/sstable/SimpleSSTableMultiWriter.java | 2 +- .../cassandra/io/sstable/format/SSTableWriter.java | 97 ++--- .../io/sstable/format/SortedTableWriter.java | 76 ++-- .../io/sstable/format/big/BigTableWriter.java | 125 ++-- .../io/sstable/format/bti/BtiTableWriter.java | 174 +++-- .../apache/cassandra/io/util/SequentialWriter.java | 7 +- .../cassandra/db/SerializationHeaderTest.java | 1 - .../db/lifecycle/RealTransactionsTest.java | 2 +- .../io/sstable/SSTableFlushObserverTest.java | 216 ++--- .../io/sstable/SSTableWriterTestBase.java | 2 +- .../org/apache/cassandra/io/sstable/ScrubTest.java | 1 - .../io/sstable/format/bti/PartitionIndexTest.java | 8 +- 18 files changed, 430 insertions(+), 297 deletions(-) diff --cc CHANGES.txt index 78d3fa9a01,e5f38dbd9a..add2a95196 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,7 -1,5 +1,9 @@@ -5.0-alpha2 +5.1 + * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) + * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) +Merged from 5.0: + * Do not create sstable files before registering in txn (CASSANDRA-18737) ++ * Remove wrong assertion in SSTableLoader (CASSANDRA-18840) * Do not log stacktrace on mismatched cache and schema version and checksum error in AutoSavingCache (CASSANDRA-18862) * Remove wrong assertion in SSTableLoader (CASSANDRA-18840) * Fix accessing java.nio.Bits.TOTAL_CAPACITY in Java17 (CASSANDRA-18848) @@@ -17,9 -15,8 +19,7 @@@ Merged from 3.11 Merged from 3.0: * Add cqlshrc.sample and credentials.sample into Debian package (CASSANDRA-18818) -- 5.0-alpha1 - * Remove wrong assertion in SSTableLoader (CASSANDRA-18840) * Fix rpm installations to work with jdk17 (CASSANDRA-18817) * Fix Depends and Build-Depends for Java for Debian packages (CASSANDRA-18809) * Update command line flags --add-exports and --add-opens for JDK17 (CASSANDRA-18439) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (54ef3a1c7e -> d16e8d3653)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 54ef3a1c7e Merge branch 'cassandra-4.1' into cassandra-5.0 add d16e8d3653 Do not create sstable files before registering in txn No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../cassandra/db/compaction/CompactionManager.java | 4 +- .../apache/cassandra/db/compaction/Upgrader.java | 2 +- .../db/compaction/unified/ShardedMultiWriter.java | 2 +- .../compaction/writers/CompactionAwareWriter.java | 2 +- .../io/compress/CompressedSequentialWriter.java| 2 +- .../io/sstable/SimpleSSTableMultiWriter.java | 2 +- .../cassandra/io/sstable/format/SSTableWriter.java | 97 ++--- .../io/sstable/format/SortedTableWriter.java | 76 ++-- .../io/sstable/format/big/BigTableWriter.java | 125 ++-- .../io/sstable/format/bti/BtiTableWriter.java | 174 +++-- .../apache/cassandra/io/util/SequentialWriter.java | 7 +- .../cassandra/db/SerializationHeaderTest.java | 1 - .../db/lifecycle/RealTransactionsTest.java | 2 +- .../io/sstable/SSTableFlushObserverTest.java | 216 ++--- .../io/sstable/SSTableWriterTestBase.java | 2 +- .../org/apache/cassandra/io/sstable/ScrubTest.java | 1 - .../io/sstable/format/bti/PartitionIndexTest.java | 8 +- 18 files changed, 429 insertions(+), 295 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (02cdaf5b92 -> 77912be753)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 02cdaf5b92 Merge branch 'cassandra-5.0' into trunk add d16e8d3653 Do not create sstable files before registering in txn new 77912be753 Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 4 +- .../cassandra/db/compaction/CompactionManager.java | 4 +- .../apache/cassandra/db/compaction/Upgrader.java | 2 +- .../db/compaction/unified/ShardedMultiWriter.java | 2 +- .../compaction/writers/CompactionAwareWriter.java | 2 +- .../io/compress/CompressedSequentialWriter.java| 2 +- .../io/sstable/SimpleSSTableMultiWriter.java | 2 +- .../cassandra/io/sstable/format/SSTableWriter.java | 97 ++--- .../io/sstable/format/SortedTableWriter.java | 76 ++-- .../io/sstable/format/big/BigTableWriter.java | 125 ++-- .../io/sstable/format/bti/BtiTableWriter.java | 174 +++-- .../apache/cassandra/io/util/SequentialWriter.java | 7 +- .../cassandra/db/SerializationHeaderTest.java | 1 - .../db/lifecycle/RealTransactionsTest.java | 2 +- .../io/sstable/SSTableFlushObserverTest.java | 216 ++--- .../io/sstable/SSTableWriterTestBase.java | 2 +- .../org/apache/cassandra/io/sstable/ScrubTest.java | 1 - .../io/sstable/format/bti/PartitionIndexTest.java | 8 +- 18 files changed, 430 insertions(+), 297 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (6b8a3139d -> 1050fc5ae)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 6b8a3139d generate docs for bc8bfc13 new 1050fc5ae generate docs for bc8bfc13 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (6b8a3139d) \ N -- N -- N refs/heads/asf-staging (1050fc5ae) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18876) The vector data type shouldn't support empty value
[ https://issues.apache.org/jira/browse/CASSANDRA-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768788#comment-17768788 ] David Capwell commented on CASSANDRA-18876: --- Overall LGTM, few non-blocking questions about `VectorType` change > The vector data type shouldn't support empty value > -- > > Key: CASSANDRA-18876 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18876 > Project: Cassandra > Issue Type: Bug > Components: Feature/Vector Search >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > As discussed on [the mail > list|https://lists.apache.org/thread/qq0jkm6rlkd2slfmhgz7om14tbpys891], the > vector data type shouldn't allow empty values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18876) The vector data type shouldn't support empty value
[ https://issues.apache.org/jira/browse/CASSANDRA-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18876: -- Reviewers: David Capwell, David Capwell David Capwell, David Capwell (was: David Capwell) Status: Review In Progress (was: Patch Available) > The vector data type shouldn't support empty value > -- > > Key: CASSANDRA-18876 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18876 > Project: Cassandra > Issue Type: Bug > Components: Feature/Vector Search >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > As discussed on [the mail > list|https://lists.apache.org/thread/qq0jkm6rlkd2slfmhgz7om14tbpys891], the > vector data type shouldn't allow empty values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18874) Add Jepsen's Elle to Accord and Paxos validation
[ https://issues.apache.org/jira/browse/CASSANDRA-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] C. Scott Andreas updated CASSANDRA-18874: - Summary: Add Jepsen's Elle to Accord and Paxos validation (was: Add Jepson's Elle to Accord and Paxos validation) > Add Jepsen's Elle to Accord and Paxos validation > > > Key: CASSANDRA-18874 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18874 > Project: Cassandra > Issue Type: Improvement > Components: Accord, Feature/Lightweight Transactions >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 5.x > > > Paxos and Accord both use a custom validator to make sure we offer Strict > Serializability, but to increase confidence we should use external validators > as well, such as Jepson’s Elle. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18877) remove bytebuddy / byteman from production classpath and remove compress-lzf dependency from build deps
[ https://issues.apache.org/jira/browse/CASSANDRA-18877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768744#comment-17768744 ] Michael Semb Wever commented on CASSANDRA-18877: 4.x too works for me. i'd expect the same breakages if any in both places (i.e. same review and testing is required) > remove bytebuddy / byteman from production classpath and remove compress-lzf > dependency from build deps > --- > > Key: CASSANDRA-18877 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18877 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > I was digging in the project deps and if you compare all libs in "libs" dir > and all libs in "build/lib/jars", there are indeed some differences which are > OK however in build/lib/jars there are also libraries for byteman and > byte-buddy. This is clearly wrong as these dependecies should not be > accessible from the production code, only from tests. > The reason they are accessible in prod code is that there is the class > TestRateLimiter (1). I do not have a clue why that class is in the prod code > in the first place. The only place it is referenced in is here (2) but that > byteman script is not loaded anywhere in tests. I was also checking Python > dtests. > I think this is some leftover or something like "I will keep it here when I > need it", but as nobody seems to do, I strongly advocate for removing it and > making bytebuddy and byteman only test scoped dependencies as it should be. > A reader who pays attention notices that these dependencies are of provided > scope which is a trick to have it compilable but not among the libraries in > the production runtime and it does not do any harm as it is never invoked > from the production code (if it was, it would fail on missing imports) > neverthless this is still an issue which should be addressed. We were doing > something similar with assertj dependency recently. > The second issue is that there is a dependency on compress-lzf in build > dependencies. This is not necessary either as that library was removed from > the repository in (3) but it still somehow leaked to the build process again. > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/TestRateLimiter.java > (2) > https://github.com/apache/cassandra/blob/trunk/test/resources/byteman/mutation_limiter.btm > (3) > https://github.com/apache/cassandra/commit/fc92db2b9b56c143516026ba29cecdec37e286bb -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-accord] branch trunk updated: CEP-15: Minimize transaction state kept in system tables (#62)
This is an automated email from the ASF dual-hosted git repository.
aleksey pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-accord.git
The following commit(s) were added to refs/heads/trunk by this push:
new 79fc1ebf CEP-15: Minimize transaction state kept in system tables (#62)
79fc1ebf is described below
commit 79fc1ebf7db6aa5e616dbef1bc61b616fea3c2c6
Author: Aleksey Yeschenko
AuthorDate: Mon Sep 25 16:07:44 2023 +0100
CEP-15: Minimize transaction state kept in system tables (#62)
* CEP-15: Minimize transaction state kept in system tables
patch by Aleksey Yeschenko; reviewed by Ariel Weisberg for CASSANDRA-18573
---
.../src/main/java/accord/api/ProgressLog.java | 3 +-
accord-core/src/main/java/accord/api/Read.java | 1 +
accord-core/src/main/java/accord/api/Update.java | 1 +
.../src/main/java/accord/coordinate/FetchData.java | 255 +
.../java/accord/coordinate/RecoverWithRoute.java | 8 +-
.../src/main/java/accord/local/Command.java| 124 ++-
accord-core/src/main/java/accord/local/Node.java | 11 +-
.../main/java/accord/local/SerializerSupport.java | 413 +
accord-core/src/main/java/accord/local/Status.java | 9 +-
.../src/main/java/accord/messages/Apply.java | 37 +-
.../src/main/java/accord/messages/Commit.java | 23 +-
.../main/java/accord/messages/InformDurable.java | 11 -
.../{api/Read.java => messages/LocalMessage.java} | 24 +-
.../src/main/java/accord/messages/MessageType.java | 105 --
.../src/main/java/accord/messages/Propagate.java | 371 ++
.../src/main/java/accord/primitives/Deps.java | 2 +-
.../main/java/accord/primitives/PartialDeps.java | 9 +-
.../main/java/accord/primitives/PartialTxn.java| 18 +-
.../src/main/java/accord/primitives/Writes.java| 7 +-
accord-core/src/test/java/accord/Utils.java| 2 +
.../src/test/java/accord/impl/basic/Cluster.java | 3 +-
.../test/java/accord/impl/mock/MockCluster.java| 2 +
.../java/accord/local/ImmutableCommandTest.java| 2 +-
.../src/main/java/accord/maelstrom/Cluster.java| 3 +-
.../src/main/java/accord/maelstrom/Main.java | 3 +-
25 files changed, 1079 insertions(+), 368 deletions(-)
diff --git a/accord-core/src/main/java/accord/api/ProgressLog.java
b/accord-core/src/main/java/accord/api/ProgressLog.java
index 4ede480f..47244c17 100644
--- a/accord-core/src/main/java/accord/api/ProgressLog.java
+++ b/accord-core/src/main/java/accord/api/ProgressLog.java
@@ -142,8 +142,7 @@ public interface ProgressLog
void executed(Command command, ProgressShard shard);
/**
- * The transaction's outcome has been durably recorded (but not
necessarily applied) at a quorum of all shards,
- * including at least those node's ids that are provided.
+ * The transaction's outcome has been durably recorded (but not
necessarily applied) at a quorum of all shards.
*
* If this replica has not witnessed the outcome of the transaction, it
should poll a majority of each shard
* for its outcome.
diff --git a/accord-core/src/main/java/accord/api/Read.java
b/accord-core/src/main/java/accord/api/Read.java
index b9eaf2a1..7def168c 100644
--- a/accord-core/src/main/java/accord/api/Read.java
+++ b/accord-core/src/main/java/accord/api/Read.java
@@ -32,4 +32,5 @@ public interface Read
AsyncChain read(Seekable key, Txn.Kind kind, SafeCommandStore
commandStore, Timestamp executeAt, DataStore store);
Read slice(Ranges ranges);
Read merge(Read other);
+default boolean isEqualOrFuller(Read other) { return true; }
}
diff --git a/accord-core/src/main/java/accord/api/Update.java
b/accord-core/src/main/java/accord/api/Update.java
index 8a56efcc..fa8493e5 100644
--- a/accord-core/src/main/java/accord/api/Update.java
+++ b/accord-core/src/main/java/accord/api/Update.java
@@ -36,4 +36,5 @@ public interface Update
Write apply(Timestamp executeAt, @Nullable Data data);
Update slice(Ranges ranges);
Update merge(Update other);
+default boolean isEqualOrFuller(Update other) { return true; }
}
diff --git a/accord-core/src/main/java/accord/coordinate/FetchData.java
b/accord-core/src/main/java/accord/coordinate/FetchData.java
index 774df8ab..0188a0a7 100644
--- a/accord-core/src/main/java/accord/coordinate/FetchData.java
+++ b/accord-core/src/main/java/accord/coordinate/FetchData.java
@@ -15,37 +15,23 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package accord.coordinate;
import java.util.function.BiConsumer;
-import accord.api.RoutingKey;
-import accord.local.Command;
-import accord.local.Commands;
import accord.local.Node;
-import accord.local.PreLoadContext;
-import accord.local.SafeCommand;
-import accord.local.SafeCommandStore;
import accord.local.Status;
import
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768737#comment-17768737 ] Maxim Muzafarov commented on CASSANDRA-14667: - The slf4j upgdate is here: https://issues.apache.org/jira/browse/CASSANDRA-18882 > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Attachments: signature.asc, signature.asc, signature.asc, > signature.asc > > Time Spent: 1.5h > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[ https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768731#comment-17768731 ] Maxim Muzafarov commented on CASSANDRA-18882: - trunk: https://github.com/apache/cassandra/pull/2726/files 5.0: https://github.com/apache/cassandra/pull/2727/files > Update the slf4j-api library in order to avoid potential leaks > -- > > Key: CASSANDRA-18882 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18882 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The proposed update is 1.7.24 (current) > 1.7.36 (latest) > The following commits are included in the newer slf4j-api and that currently > look very useful for us: > - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] > Potential memory leaks if there is no underlying implementation > - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] > Add test for all happy flow cases > - > [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22=newest=1)] > EventRecodingLogger debug logs as TRACE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[ https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18882: Test and Documentation Plan: Run CI, documentation is not required. Status: Patch Available (was: Open) > Update the slf4j-api library in order to avoid potential leaks > -- > > Key: CASSANDRA-18882 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18882 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The proposed update is 1.7.24 (current) > 1.7.36 (latest) > The following commits are included in the newer slf4j-api and that currently > look very useful for us: > - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] > Potential memory leaks if there is no underlying implementation > - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] > Add test for all happy flow cases > - > [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22=newest=1)] > EventRecodingLogger debug logs as TRACE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[ https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18882: Change Category: Operability Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > Update the slf4j-api library in order to avoid potential leaks > -- > > Key: CASSANDRA-18882 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18882 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > > The proposed update is 1.7.24 (current) > 1.7.36 (latest) > The following commits are included in the newer slf4j-api and that currently > look very useful for us: > - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] > Potential memory leaks if there is no underlying implementation > - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] > Add test for all happy flow cases > - > [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22=newest=1)] > EventRecodingLogger debug logs as TRACE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[ https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18882: Component/s: Dependencies > Update the slf4j-api library in order to avoid potential leaks > -- > > Key: CASSANDRA-18882 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18882 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > > The proposed update is 1.7.24 (current) > 1.7.36 (latest) > The following commits are included in the newer slf4j-api and that currently > look very useful for us: > - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] > Potential memory leaks if there is no underlying implementation > - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] > Add test for all happy flow cases > - > [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22=newest=1)] > EventRecodingLogger debug logs as TRACE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
[ https://issues.apache.org/jira/browse/CASSANDRA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18882: Fix Version/s: 5.0.x 5.x > Update the slf4j-api library in order to avoid potential leaks > -- > > Key: CASSANDRA-18882 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18882 > Project: Cassandra > Issue Type: Task >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > > The proposed update is 1.7.24 (current) > 1.7.36 (latest) > The following commits are included in the newer slf4j-api and that currently > look very useful for us: > - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] > Potential memory leaks if there is no underlying implementation > - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] > Add test for all happy flow cases > - > [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22=newest=1)] > EventRecodingLogger debug logs as TRACE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18882) Update the slf4j-api library in order to avoid potential leaks
Maxim Muzafarov created CASSANDRA-18882: --- Summary: Update the slf4j-api library in order to avoid potential leaks Key: CASSANDRA-18882 URL: https://issues.apache.org/jira/browse/CASSANDRA-18882 Project: Cassandra Issue Type: Task Reporter: Maxim Muzafarov Assignee: Maxim Muzafarov The proposed update is 1.7.24 (current) > 1.7.36 (latest) The following commits are included in the newer slf4j-api and that currently look very useful for us: - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] Potential memory leaks if there is no underlying implementation - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] Add test for all happy flow cases - [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22=newest=1)] EventRecodingLogger debug logs as TRACE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18877) remove bytebuddy / byteman from production classpath and remove compress-lzf dependency from build deps
[ https://issues.apache.org/jira/browse/CASSANDRA-18877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768728#comment-17768728 ] Stefan Miklosovic commented on CASSANDRA-18877: --- [~mck] do we want to do this for 4.x too or 5.x is just enough? > remove bytebuddy / byteman from production classpath and remove compress-lzf > dependency from build deps > --- > > Key: CASSANDRA-18877 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18877 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > I was digging in the project deps and if you compare all libs in "libs" dir > and all libs in "build/lib/jars", there are indeed some differences which are > OK however in build/lib/jars there are also libraries for byteman and > byte-buddy. This is clearly wrong as these dependecies should not be > accessible from the production code, only from tests. > The reason they are accessible in prod code is that there is the class > TestRateLimiter (1). I do not have a clue why that class is in the prod code > in the first place. The only place it is referenced in is here (2) but that > byteman script is not loaded anywhere in tests. I was also checking Python > dtests. > I think this is some leftover or something like "I will keep it here when I > need it", but as nobody seems to do, I strongly advocate for removing it and > making bytebuddy and byteman only test scoped dependencies as it should be. > A reader who pays attention notices that these dependencies are of provided > scope which is a trick to have it compilable but not among the libraries in > the production runtime and it does not do any harm as it is never invoked > from the production code (if it was, it would fail on missing imports) > neverthless this is still an issue which should be addressed. We were doing > something similar with assertj dependency recently. > The second issue is that there is a dependency on compress-lzf in build > dependencies. This is not necessary either as that library was removed from > the repository in (3) but it still somehow leaked to the build process again. > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/TestRateLimiter.java > (2) > https://github.com/apache/cassandra/blob/trunk/test/resources/byteman/mutation_limiter.btm > (3) > https://github.com/apache/cassandra/commit/fc92db2b9b56c143516026ba29cecdec37e286bb -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18881) Test failure: org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest-.jdk11
[
https://issues.apache.org/jira/browse/CASSANDRA-18881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18881:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Component/s: Test/unit
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Test failure:
> org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest-.jdk11
>
> ---
>
> Key: CASSANDRA-18881
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18881
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Ekaterina Dimitrova
>Priority: Normal
>
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1718/testReport/org.apache.cassandra.tools.nodetool/ForceCompactionTest/forceCompactMultipleRowsTombstoneTest__jdk11/]
> h3.
> {code:java}
> Stacktrace
> junit.framework.AssertionFailedError at
> org.apache.cassandra.tools.nodetool.ForceCompactionTest.verifyNotContainsTombstones(ForceCompactionTest.java:251)
> at
> org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest(ForceCompactionTest.java:129)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18881) Test failure: org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest-.jdk11
[
https://issues.apache.org/jira/browse/CASSANDRA-18881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18881:
Fix Version/s: 5.x
> Test failure:
> org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest-.jdk11
>
> ---
>
> Key: CASSANDRA-18881
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18881
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1718/testReport/org.apache.cassandra.tools.nodetool/ForceCompactionTest/forceCompactMultipleRowsTombstoneTest__jdk11/]
> h3.
> {code:java}
> Stacktrace
> junit.framework.AssertionFailedError at
> org.apache.cassandra.tools.nodetool.ForceCompactionTest.verifyNotContainsTombstones(ForceCompactionTest.java:251)
> at
> org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest(ForceCompactionTest.java:129)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18881) Test failure: org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest-.jdk11
Ekaterina Dimitrova created CASSANDRA-18881:
---
Summary: Test failure:
org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest-.jdk11
Key: CASSANDRA-18881
URL: https://issues.apache.org/jira/browse/CASSANDRA-18881
Project: Cassandra
Issue Type: Bug
Reporter: Ekaterina Dimitrova
[https://ci-cassandra.apache.org/job/Cassandra-trunk/1718/testReport/org.apache.cassandra.tools.nodetool/ForceCompactionTest/forceCompactMultipleRowsTombstoneTest__jdk11/]
h3.
{code:java}
Stacktrace
junit.framework.AssertionFailedError at
org.apache.cassandra.tools.nodetool.ForceCompactionTest.verifyNotContainsTombstones(ForceCompactionTest.java:251)
at
org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest(ForceCompactionTest.java:129)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18880) Test failure: dtest-novnode.transient_replication_test.TestTransientReplicationRepairStreamEntireSSTable.test_optimized_primary_range_repair_with_lcs
[
https://issues.apache.org/jira/browse/CASSANDRA-18880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18880:
Fix Version/s: 5.x
> Test failure:
> dtest-novnode.transient_replication_test.TestTransientReplicationRepairStreamEntireSSTable.test_optimized_primary_range_repair_with_lcs
> -
>
> Key: CASSANDRA-18880
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18880
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
> h3.
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1718/testReport/dtest-novnode.transient_replication_test/TestTransientReplicationRepairStreamEntireSSTable/test_optimized_primary_range_repair_with_lcs_3/
> {code:java}
> Error Message
> failed on setup with "TypeError: 'list' object is not callable"
> Stacktrace
> self =
> object at 0x7f4b3a4e4ac0> fixture_dtest_setup = object at 0x7f4b3a583250> @pytest.fixture(scope='function', autouse=True) def
> setup_cluster(self, fixture_dtest_setup): > self.tokens = self.tokens() E
> TypeError: 'list' object is not callable transient_replication_test.py:206:
> TypeError
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18880) Test failure: dtest-novnode.transient_replication_test.TestTransientReplicationRepairStreamEntireSSTable.test_optimized_primary_range_repair_with_lcs
[
https://issues.apache.org/jira/browse/CASSANDRA-18880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18880:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Component/s: Test/dtest/python
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Test failure:
> dtest-novnode.transient_replication_test.TestTransientReplicationRepairStreamEntireSSTable.test_optimized_primary_range_repair_with_lcs
> -
>
> Key: CASSANDRA-18880
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18880
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Ekaterina Dimitrova
>Priority: Normal
>
> h3.
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1718/testReport/dtest-novnode.transient_replication_test/TestTransientReplicationRepairStreamEntireSSTable/test_optimized_primary_range_repair_with_lcs_3/
> {code:java}
> Error Message
> failed on setup with "TypeError: 'list' object is not callable"
> Stacktrace
> self =
> object at 0x7f4b3a4e4ac0> fixture_dtest_setup = object at 0x7f4b3a583250> @pytest.fixture(scope='function', autouse=True) def
> setup_cluster(self, fixture_dtest_setup): > self.tokens = self.tokens() E
> TypeError: 'list' object is not callable transient_replication_test.py:206:
> TypeError
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18880) Test failure: dtest-novnode.transient_replication_test.TestTransientReplicationRepairStreamEntireSSTable.test_optimized_primary_range_repair_with_lcs
Ekaterina Dimitrova created CASSANDRA-18880:
---
Summary: Test failure:
dtest-novnode.transient_replication_test.TestTransientReplicationRepairStreamEntireSSTable.test_optimized_primary_range_repair_with_lcs
Key: CASSANDRA-18880
URL: https://issues.apache.org/jira/browse/CASSANDRA-18880
Project: Cassandra
Issue Type: Bug
Reporter: Ekaterina Dimitrova
h3.
https://ci-cassandra.apache.org/job/Cassandra-trunk/1718/testReport/dtest-novnode.transient_replication_test/TestTransientReplicationRepairStreamEntireSSTable/test_optimized_primary_range_repair_with_lcs_3/
{code:java}
Error Message
failed on setup with "TypeError: 'list' object is not callable"
Stacktrace
self =
fixture_dtest_setup = @pytest.fixture(scope='function', autouse=True) def
setup_cluster(self, fixture_dtest_setup): > self.tokens = self.tokens() E
TypeError: 'list' object is not callable transient_replication_test.py:206:
TypeError
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768691#comment-17768691
]
Ekaterina Dimitrova commented on CASSANDRA-14667:
-
Thank you, [~mmuzaf]
{quote}So, I think we can create another issue to do the update 1.7.24 > 1.7.36.
{quote}
I agree with you, even low priority one
> Upgrade Dropwizard Metrics to 4.x
> -
>
> Key: CASSANDRA-14667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
> Project: Cassandra
> Issue Type: Task
> Components: Observability/Metrics
>Reporter: Stig Rohde Døssing
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Attachments: signature.asc, signature.asc, signature.asc,
> signature.asc
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for
> Java 9 compatibility. It would be good to upgrade the Metrics library as part
> of the version of Cassandra that adds Java 9 compatibility
> (https://issues.apache.org/jira/browse/CASSANDRA-9608).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768182#comment-17768182
]
Ekaterina Dimitrova edited comment on CASSANDRA-14667 at 9/25/23 1:23 PM:
--
I have a question: does anyone know why we opted in for JmxReporter at the
first place in NodeProbe - I believe the usage of JmxReporter was added in
CASSANDRA-14523. Why was it not used CassandraMetricsRegistry as we do
[now|https://github.com/apache/cassandra/pull/2238/files#diff-92f8748902f03f37a4f7db56b4dfb7d226adcf3839141e6adb8ebbc575020d57R1835]?
It is also done everywhere else in NodeProbe. [~cnlwsu] ?
{quote}Better be safe than sorry.
{quote}
+1
{quote}ant resolver plugin has some bugs in it
{quote}
[~mck] , do you have links? I agree with [~smiklosovic] and [~mmuzaf] that it
is good to follow up on that. At least to be sure we do things correctly. But
that is, of course, not a blocker for this ticket. Let's collect the info we
already have and follow up on this.
I also reviewed the logback release notes (Thank you for the link!!). The only
breaking change I saw was regarding DBAPPENDER, which we do not use. (Do we?) I
saw RollingFileAppender, ConsoleAppender, AsyncAppender, InstrumentedAppender,
FileAppender.
*Question:* Do we need to highlight anything specific in the NEWS.txt regarding
the new dropwizard version, or just the CHANGES.txt entry that we bumped the
version is enough?
For completeness, below is the changelog for the drivers:
[https://github.com/datastax/java-driver/tree/3.x/changelog]
I noticed we exclude with the driver - netty-buffer, netty-codec,
netty-handler, netty-transport and a few other dependencies. [~smiklosovic],
you've been working on some new exclusions for netty after the last upgrade;
anything else we need to do here with the driver in that regard?
I will push the full CI when we confirm what we do with slf4j-api and the
drivers' exclusions. I want to run the full test suite with upgrade tests,
etc., and I would like to prevent doing it 4 instead of only 2 times (5.0 and
trunk).
was (Author: e.dimitrova):
I have a question: does anyone know why we opted in for JmxReporter at the
first place in NodeProbe - I believe the usage of JmxReporter was added in
CASSANDRA-14523. Why was it not used CassandraMetricsRegistry as we do
[now|https://github.com/apache/cassandra/pull/2238/files#diff-92f8748902f03f37a4f7db56b4dfb7d226adcf3839141e6adb8ebbc575020d57R1835]?
It is also done everywhere else in NodeProbe. [~cnlwsu] ?
{quote}Better be safe than sorry.
{quote}
+1
{quote}ant resolver plugin has some bugs in it
{quote}
[~mck] , do you have links? I agree with [~smiklosovic] and [~mmuzaf] that it
is good to follow up on that. At least to be sure we do things correctly. But
that is, of course, not a blocker for this ticket. Let's collect the info we
already have and follow up on this.
I do not see in the PR slf4j-api being updated. I thought we will update that
one, too?
It is important to mention this note from 1.7.35 for SLF4J:
{code:java}
• In this release, the "slf4j-log4j12" artifact automatically instructs Maven
to use the "slf4j-reload4j" artifact instead. As you might have guessed, the
"slf4j-reload4j" binding delegates log processing to the reload4j logging
framework.
The reload4j project is a fork of Apache log4j version 1.2.17 with the goal of
fixing pressing security issues. It is intended as a drop-in replacement for
log4j version 1.2.17. By drop-in, we mean the replacement of log4j.jar with
reload4j.jar in your build with no source code changes in .java files being
necessary.
{code}
While I do not see issues here, I wanted to mention it for visibility.
I also reviewed the logback release notes (Thank you for the link!!). The only
breaking change I saw was regarding DBAPPENDER, which we do not use. (Do we?) I
saw RollingFileAppender, ConsoleAppender, AsyncAppender, InstrumentedAppender,
FileAppender.
*Question:* Do we need to highlight anything specific in the NEWS.txt regarding
the new dropwizard version, or just the CHANGES.txt entry that we bumped the
version is enough?
For completeness, below is the changelog for the drivers:
[https://github.com/datastax/java-driver/tree/3.x/changelog]
I noticed we exclude with the driver - netty-buffer, netty-codec,
netty-handler, netty-transport and a few other dependencies. [~smiklosovic],
you've been working on some new exclusions for netty after the last upgrade;
anything else we need to do here with the driver in that regard?
I will push the full CI when we confirm what we do with slf4j-api and the
drivers' exclusions. I want to run the full test suite with upgrade tests,
etc., and I would like to prevent doing it 4 instead of only 2 times (5.0 and
trunk).
> Upgrade Dropwizard Metrics to 4.x
> -
>
>
[jira] [Commented] (CASSANDRA-18805) Upgrade caffeine to 3.1.8
[
https://issues.apache.org/jira/browse/CASSANDRA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768686#comment-17768686
]
Ekaterina Dimitrova commented on CASSANDRA-18805:
-
Thanks. I think that is a good call. I noticed today we have some flakiness in
that test class even today. Look here:
[https://ci-cassandra.apache.org/job/Cassandra-trunk/1718/testReport/org.apache.cassandra.tools.nodetool/InvalidateCIDRPermissionsCacheTest/testInvalidateAllCidrPermissions_compression_jdk11/]
h3.
{code:java}
Error Message
expected:<[3]L> but was:<[2]L>
Stacktrace
junit.framework.AssertionFailedError: expected:<[3]L> but was:<[2]L> at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method) at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
org.apache.cassandra.tools.nodetool.InvalidateCIDRPermissionsCacheTest.testInvalidateAllCidrPermissions(InvalidateCIDRPermissionsCacheTest.java:144)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{code}
{quote}I will run the change under circle CI couple of times and let you know
how it goes.
{quote}
Thanks, looking forward to it. As mentioned on the PR on Friday, I will be
happy to consolidate all changes.
> Upgrade caffeine to 3.1.8
> -
>
> Key: CASSANDRA-18805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18805
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> 3.1.8 is based on Java 11. This version is testing with newer JDK versions,
> while 2.x versions are based on JDK8, and as I understand, only bug-fix
> releases are expected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18547) Refactor cqlsh On/Off switch implementation and make the output consistent
[
https://issues.apache.org/jira/browse/CASSANDRA-18547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768685#comment-17768685
]
Stefan Miklosovic commented on CASSANDRA-18547:
---
[~brandon.williams] would you take a look, please? It would basically unblock
CASSANDRA-18861 too.
> Refactor cqlsh On/Off switch implementation and make the output consistent
> --
>
> Key: CASSANDRA-18547
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18547
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This change refactors the On/Off switch implemented in the class
> SwitchCommand and subclass SwitchCommandWithValue of cqlshmain.py to use an
> Enum with static methods instead of custom classes.
> The body of on_off_switch + enum definition requires just 15 lines of code vs
> 33 in SwitchCommand.
> The existing code is hard to read, including the usage in the code, which
> instantiates a SwitchCommand object in-order to invoke the execute method:
>
> {code:java}
> self.tracing_enabled = SwitchCommand("TRACING",
> "Tracing").execute(self.tracing_enabled, parsed, self.printerr){code}
> this can be replaced by a more familiar direct function call:
> {code:java}
> self.tracing_enabled = self.on_off_toggle("TRACING", "Tracing",
> self.tracing_enabled, parsed.get_binding('switch')){code}
>
> The refactoring also updates the command output for consistency. Instead of
> the current:
> {code:java}
> > tracing on
> Now Tracing is enabled
> > paging on
> Query paging is already enabled. Use PAGING OFF to disable.
> > expand on
> Now Expanded output is enabled
> {code}
> replace with more succinct and consistent, using 'ON/OFF' instead of
> enabled/disabled and removing the redundant 'Now':
> {code:java}
> > tracing on
> TRACING set to ON
> > paging on
> PAGING is already ON
> > expand on
> EXPAND set to ON
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768677#comment-17768677 ] Maxim Muzafarov edited comment on CASSANDRA-14667 at 9/25/23 12:53 PM: --- Actually, there are some commits that I have missed for the slf4j-api - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] Potential memory leaks if there is no underlying implementation - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] Add test for all happy flow cases - [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22=newest=1)] EventRecodingLogger debug logs as TRACE These last three issues were fixed in 1.7.30 and no changes have been applied since then. So, I think we can create another issue to do the update 1.7.24 > 1.7.36. was (Author: mmuzaf): Actually, there are some commits that I have missed for the slf4j-api - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] Potential memory leaks if there is no underlying implementation - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] Add test for all happy flow cases - [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22=newest=1) EventRecodingLogger debug logs as TRACE These last three issues were fixed in 1.7.30 and no changes have been applied since then. So, I think we can create another issue to do the update 1.7.24 > 1.7.36. > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Attachments: signature.asc, signature.asc, signature.asc, > signature.asc > > Time Spent: 1.5h > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768677#comment-17768677 ] Maxim Muzafarov commented on CASSANDRA-14667: - Actually, there are some commits that I have missed for the slf4j-api - [SLF4J-469|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02569.html] Potential memory leaks if there is no underlying implementation - [SLF4j-466|https://www.mail-archive.com/slf4j-dev@qos.ch/msg02499.html] Add test for all happy flow cases - [SLF4J-460|https://www.mail-archive.com/search?l=slf4j-...@qos.ch=subject:%22%5C%5Bslf4j%5C-dev%5C%5D+%5C%5BJIRA%5C%5D+%5C%28SLF4J%5C-460%5C%29+EventRecodingLogger+debug+logs+as%09TRACE%22=newest=1) EventRecodingLogger debug logs as TRACE These last three issues were fixed in 1.7.30 and no changes have been applied since then. So, I think we can create another issue to do the update 1.7.24 > 1.7.36. > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Attachments: signature.asc, signature.asc, signature.asc, > signature.asc > > Time Spent: 1.5h > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768672#comment-17768672 ] Maxim Muzafarov commented on CASSANDRA-14667: - [~e.dimitrova] I didn't see a clear agreement to update the slf4j-api library, so I didn't include it in the patch. For me, the there are a few reasons for not doing this in this patch: - The slf4j-api dependency is important in its own right and deserves its own patch, in case we have to revert the following patch due to some undiscovered problem and/or slf4j still needs to be preserved; - The slf4j-api module is a module that provides a public API, and according to the slf4j release policy only changes between the major releases, even if you still see the patch versions it is released as a maven module without any changes and nothing more. For example, the latest change related to this module itself is change c6c7a98a7ee1e71382348ae3e41ff7818dfafd65 dated Dec 16, 2019 despite the latest 1.7.36 version is released on Feb 8, 2022. - We've already removed this library from the transitive dependencies for the dropwizrd library. In summary, including the slf4j-api version update is not required for this patch. The API that is provided by slf4j and that is used by Cassandra is the same and it only overcomplicates the overall solution by causing unnecessary questions for those developers who will be faced with this patch later. So I suggest proceeding with this patch without the slf4j-api alongside the update and if we still want to - create another issue for it, but for the same reasons that were mentioned above there is no need for the 1.7.24 > 1.7.36 upgrade as it gives us nothing. > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Attachments: signature.asc, signature.asc, signature.asc, > signature.asc > > Time Spent: 1.5h > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768671#comment-17768671
]
Stefan Miklosovic edited comment on CASSANDRA-18399 at 9/25/23 12:37 PM:
-
I am not telling to close this. All I am saying is that I am most probably not
going to use it and all I am asking is to do it in such a way that how I am
doing it will not be changed. That seems to be the case.
If there is a general consensus / majority which wants it well ... sure.
I think it would be appropriate to send this to ML to gather some opinions to
see if there is enough people who are going to use it so it makes sense to add
it. I want to avoid situation when two / three people are going to use that but
virtually nobody else. Right now the primary users of this seem to be yourself,
David and Josh? Who else? Is that enough to merge it?
was (Author: smiklosovic):
I am not telling to close this. All I am saying is that I am most probably not
going to use it and all I am asking is to do it in such a way that how I am
doing it will not be changed. That seems to be the case.
If there is a general consensus / majority which wants it well ... sure.
I think it would be appropriate to send this to ML to gather some opinions to
see if there is enough people who are going to use to so it makes sense to add
it. I want to avoid situation when two / three people are going to use that but
virtually nobody else. Right now the primary users of this seem to be yourself,
David and Josh? Who else? Is that enough to merge it?
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
>
[jira] [Commented] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768671#comment-17768671
]
Stefan Miklosovic commented on CASSANDRA-18399:
---
I am not telling to close this. All I am saying is that I am most probably not
going to use it and all I am asking is to do it in such a way that how I am
doing it will not be changed. That seems to be the case.
If there is a general consensus / majority which wants it well ... sure.
I think it would be appropriate to send this to ML to gather some opinions to
see if there is enough people who are going to use to so it makes sense to add
it. I want to avoid situation when two / three people are going to use that but
virtually nobody else. Right now the primary users of this seem to be yourself,
David and Josh? Who else? Is that enough to merge it?
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit cassandra-3.11
> git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n a71d4e3408 && git commit -a --amend --no-edit # a71d4e3408
> DO NOT MERGE - CircleCI config
> git cherry-pick -n 6dc53f4e97 && git commit -a --amend --no-edit # 6dc53f4e97
> fixes
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff
[jira] [Updated] (CASSANDRA-18842) Jenkins: Add python upgrade dtests running with vnodes
[ https://issues.apache.org/jira/browse/CASSANDRA-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18842: --- Test and Documentation Plan: use in-tree scripts, against 18665 patch to validate Status: Patch Available (was: Open) > Jenkins: Add python upgrade dtests running with vnodes > -- > > Key: CASSANDRA-18842 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18842 > Project: Cassandra > Issue Type: Task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > > Python upgrade dtests are currently only running with non-vnodes. > A number of tests are broken if using vnodes, mostly missing > `@pytest.mark.no_vnodes` annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768667#comment-17768667
]
Jacek Lewandowski commented on CASSANDRA-18399:
---
By the time you want to push changes, they should be already rebased so no
merge conflicts should surprise you.
I'm not going to force it, obviously everything can be done manually. I found
it annoying to do that by hand when merging multi-version PRs as I needed to
repeat my work with slight differences for base version, non-trunk and trunk.
Commit template can be pasted or provided by git; reviewer names can be copy
pasted from Jira manually - that is also true - the script aims to make it
faster and less error-prone.
Will close this ticket and submit it to my own repo.
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit cassandra-3.11
> git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n a71d4e3408 && git commit -a --amend --no-edit # a71d4e3408
> DO NOT MERGE - CircleCI config
> git cherry-pick -n 6dc53f4e97 && git commit -a --amend --no-edit # 6dc53f4e97
> fixes
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-4.0..HEAD -- .circleci/ | git apply -R --index) &&
> git
[jira] [Updated] (CASSANDRA-18842) Jenkins: Add python upgrade dtests running with vnodes
[ https://issues.apache.org/jira/browse/CASSANDRA-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18842: --- Fix Version/s: 5.0.x 5.x > Jenkins: Add python upgrade dtests running with vnodes > -- > > Key: CASSANDRA-18842 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18842 > Project: Cassandra > Issue Type: Task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.0.x, 5.x > > > Python upgrade dtests are currently only running with non-vnodes. > A number of tests are broken if using vnodes, mostly missing > `@pytest.mark.no_vnodes` annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18879) Modernize CQLSH datetime conversions
[
https://issues.apache.org/jira/browse/CASSANDRA-18879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18879:
---
Description:
Python 3.x introduced many updates to datetime conversion which allows
simplified conversions.
1. For example, tracing.py defines a function datetime_from_utc_to_local() but
datetime now has a native function astimezone() which will convert UTC to local
time.
Review the following users of datetime which apply conversions:
* cqlshmain.py
* formatting.py
* tracing.py
Example:
{code:java}
>>> a = datetime.datetime.now().astimezone(tz.tzutc())
>>> a
datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
>>> b = a.astimezone()
>>> b
datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
See [PEP 495|https://peps.python.org/pep-0495/]
was:
Python 3.x introduced many updates to datetime conversion which allows
simplified conversions and zoneinfo replaces pytz.
1. For example, tracing.py defines a function datetime_from_utc_to_local() but
datetime now has a native function astimezone() which will convert UTC to local
time.
Review the following users of datetime which apply conversions:
* cqlshmain.py
* formatting.py
* tracing.py
Example:
{code:java}
>>> a = datetime.datetime.now().astimezone(tz.tzutc())
>>> a
datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
>>> b = a.astimezone()
>>> b
datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
See [PEP 495|https://peps.python.org/pep-0495/]
2. zoneinfo replaces pytz, which is now deprecated. The old pytz is used only
in cqlshmain.py,
> Modernize CQLSH datetime conversions
>
>
> Key: CASSANDRA-18879
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18879
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Priority: Low
>
> Python 3.x introduced many updates to datetime conversion which allows
> simplified conversions.
> 1. For example, tracing.py defines a function datetime_from_utc_to_local()
> but datetime now has a native function astimezone() which will convert UTC to
> local time.
> Review the following users of datetime which apply conversions:
> * cqlshmain.py
> * formatting.py
> * tracing.py
> Example:
> {code:java}
> >>> a = datetime.datetime.now().astimezone(tz.tzutc())
> >>> a
> datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
> >>> b = a.astimezone()
> >>> b
> datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
> tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
> See [PEP 495|https://peps.python.org/pep-0495/]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18842) Jenkins: Add python upgrade dtests running with vnodes
[ https://issues.apache.org/jira/browse/CASSANDRA-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18842: --- Change Category: Quality Assurance Complexity: Low Hanging Fruit Assignee: Michael Semb Wever Status: Open (was: Triage Needed) > Jenkins: Add python upgrade dtests running with vnodes > -- > > Key: CASSANDRA-18842 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18842 > Project: Cassandra > Issue Type: Task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > > Python upgrade dtests are currently only running with non-vnodes. > A number of tests are broken if using vnodes, mostly missing > `@pytest.mark.no_vnodes` annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18879) Modernize CQLSH datetime conversions
[
https://issues.apache.org/jira/browse/CASSANDRA-18879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18879:
---
Description:
Python 3.x introduced many updates to datetime conversion which allows
simplified conversions and zoneinfo replaces pytz.
1. For example, tracing.py defines a function datetime_from_utc_to_local() but
datetime now has a native function astimezone() which will convert UTC to local
time.
Review the following users of datetime which apply conversions:
* cqlshmain.py
* formatting.py
* tracing.py
Example:
{code:java}
>>> a = datetime.datetime.now().astimezone(tz.tzutc())
>>> a
datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
>>> b = a.astimezone()
>>> b
datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
See [PEP 495|https://peps.python.org/pep-0495/]
2. zoneinfo replaces pytz, which is now deprecated. The old pytz is used only
in cqlshmain.py,
was:
Python 3.x introduced many updates to datetime conversion which allows
simplified conversions.
For example, tracing.py defines a function datetime_from_utc_to_local() but
datetime now has a native function astimezone() which will convert UTC to local
time.
Review the following users of datetime which apply conversions:
* cqlshmain.py
* formatting.py
* tracing.py
Example:
{code:java}
>>> a = datetime.datetime.now().astimezone(tz.tzutc())
>>> a
datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
>>> b = a.astimezone()
>>> b
datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
See [PEP 495|https://peps.python.org/pep-0495/]
> Modernize CQLSH datetime conversions
>
>
> Key: CASSANDRA-18879
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18879
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Priority: Low
>
> Python 3.x introduced many updates to datetime conversion which allows
> simplified conversions and zoneinfo replaces pytz.
> 1. For example, tracing.py defines a function datetime_from_utc_to_local()
> but datetime now has a native function astimezone() which will convert UTC to
> local time.
> Review the following users of datetime which apply conversions:
> * cqlshmain.py
> * formatting.py
> * tracing.py
> Example:
> {code:java}
> >>> a = datetime.datetime.now().astimezone(tz.tzutc())
> >>> a
> datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
> >>> b = a.astimezone()
> >>> b
> datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
> tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
> See [PEP 495|https://peps.python.org/pep-0495/]
> 2. zoneinfo replaces pytz, which is now deprecated. The old pytz is used
> only in cqlshmain.py,
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768662#comment-17768662
]
Stefan Miklosovic commented on CASSANDRA-18399:
---
Good to know. Anyway, is it really that tiresome for people to update
changes.txt by hand and enumerate authors in the commit message? I would never
think it is such a hassle we need to have scripts for that ... from my
perspective the biggest chunk of work is merging up if some conflict happens
and I found my way to deal with that.
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit cassandra-3.11
> git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n a71d4e3408 && git commit -a --amend --no-edit # a71d4e3408
> DO NOT MERGE - CircleCI config
> git cherry-pick -n 6dc53f4e97 && git commit -a --amend --no-edit # 6dc53f4e97
> fixes
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-4.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-4.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-4.1 -> cassandra-4.1
> #
>
[jira] [Commented] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768660#comment-17768660
]
Jacek Lewandowski commented on CASSANDRA-18399:
---
One thing - it does not execute anything - it generates commands and put them
into a script which you can edit, copy / paste, whatever.
On the other hand, apart from many people having their own scripts, the final
result should be more or less the same - a single commit in the branch for the
oldest version and then proper forward merges + appropriate updates in
CHANGES.txt + a commit message matching the template.
Even if you don't want to do run the script this prepares, one can use the
tools provided here which does:
- commit message generation - you can edit it, but it fills the reviewers for
example
- update CHANGES.txt
- verify branches history - say branch for version N must include all commits
from version N-1 + merge commit from N-1 to N
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit cassandra-3.11
> git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n a71d4e3408 && git commit -a --amend --no-edit # a71d4e3408
> DO NOT MERGE - CircleCI config
> git cherry-pick -n 6dc53f4e97 && git commit -a --amend --no-edit # 6dc53f4e97
> fixes
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
>
[jira] [Comment Edited] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768650#comment-17768650
]
Stefan Miklosovic edited comment on CASSANDRA-18399 at 9/25/23 11:42 AM:
-
For the record I am not running any merging scripts either. I have my customly
tailored way how I merge up and if this is merged my workflow would not change
because of that. While I understand that somebody may have a different view on
this, until everybody agrees this is necessary and we are going to use it I am
reluctant to merge that and impose the workflow on others. If we do, we should
ensure that people can still do all of that manually as before if they want and
nobody needs to deal with scripting introduced here. Everybody's workflow is
different and I am cool with having my scripts locally / .gitignored ...
was (Author: smiklosovic):
For the record I am not running any merging scripts either. I have my customly
tailored way how I merge up and if this is merged my workflow would not change
because of that. While I understand that somebody may have a different view on
this, until everybody agrees this is necessary and we are going to use it I am
reluctant to merge that and impose the workflow on others. We should be sure
that people can still do all of that manually as before if they want.
Everybody's workflow is different and I am cool with having my scripts locally
/ .gitignored ...
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit cassandra-3.11
> git cherry-pick
[jira] [Updated] (CASSANDRA-18839) Catch SSLHandshakeExceptions exceptions
[
https://issues.apache.org/jira/browse/CASSANDRA-18839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18839:
---
Change Category: Operability
Complexity: Low Hanging Fruit
Status: Open (was: Triage Needed)
> Catch SSLHandshakeExceptions exceptions
> ---
>
> Key: CASSANDRA-18839
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18839
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Client
>Reporter: Brad Schoening
>Priority: Low
>
> When SSL connection errors occur, they tend to flood the log with stack
> traces and lack the identity of the remote client IP. Instead,
> PreV5Handlers.decode() could catch SSLHandshakeException and provide a brief,
> more informative WARN level message instead of the verbose and mostly
> unhelpful stack trace.
> I.e.,
> {code:java}
> [WARN ] [epollEventLoopGroup-5-5] cluster_id=3 ip_address=10.0.0.1
> PreV5Handlers.java:261 - SSLHandshakeException in client networking with peer
> 10.0.0.10:9042 error:10d7:SSL
> routines:OPENSSL_internal:SSL_HANDSHAKE_FAILURE {code}
> instead of the current ones which flood the logs:
> {code:java}
> 2023-09-12 00:00:25,368 [WARN ] [epollEventLoopGroup-5-5] cluster_id=3
> ip_address=10.0.0.1 PreV5Handlers.java:261 - Unknown exception in client
> networking
> io.netty.handler.codec.DecoderException: javax.net.ssl.SSLHandshakeException:
> error:10d7:SSL routines:OPENSSL_internal:SSL_HANDSHAKE_FAILURE
> at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:478)
> at
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
> at
> io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> at
> io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
> at
> io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)
> at
> io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480)
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
> at
> io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: javax.net.ssl.SSLHandshakeException: error:10d7:SSL
> routines:OPENSSL_internal:SSL_HANDSHAKE_FAILURE
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine.shutdownWithError(ReferenceCountedOpenSslEngine.java:1031)
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine.sslReadErrorResult(ReferenceCountedOpenSslEngine.java:1321)
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine.unwrap(ReferenceCountedOpenSslEngine.java:1270)
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine.unwrap(ReferenceCountedOpenSslEngine.java:1346)
> at
> io.netty.handler.ssl.ReferenceCountedOpenSslEngine.unwrap(ReferenceCountedOpenSslEngine.java:1389)
> at
> io.netty.handler.ssl.SslHandler$SslEngineType$1.unwrap(SslHandler.java:206)
> at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1387)
> at
> io.netty.handler.ssl.SslHandler.decodeNonJdkCompatible(SslHandler.java:1294)
> at io.netty.handler.ssl.SslHandler.decode(SslHandler.java:1331)
> at
> io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:508)
> at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:447)
> ... 15 common frames omitted {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768650#comment-17768650
]
Stefan Miklosovic edited comment on CASSANDRA-18399 at 9/25/23 11:40 AM:
-
For the record I am not running any merging scripts either. I have my customly
tailored way how I merge up and if this is merged my workflow would not change
because of that. While I understand that somebody may have a different view on
this, however until everybody agrees this is necessary and we are going to use
it I am reluctant to merge that and impose the workflow on others. We should be
sure that people can still do all of that manually as before if they want.
Everybody's workflow is different and I am cool with having my scripts locally
/ .gitignored ...
was (Author: smiklosovic):
For the record I am not running any merging scripts either. I have my customly
tailored way how I merge up and if this is merged my workflow would not change
because of that. While I understand that somebody may have a different view on
this, however until everybody agrees this is necessary and we are going to use
it I am reluctant to merge that and impose my workflow on others (even done in
a good faith and if the solution is opt-in). Everybody's workflow is different
and I am cool with having my scripts locally / .gitignored ...
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit cassandra-3.11
> git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
> Save host id to
[jira] [Comment Edited] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768650#comment-17768650
]
Stefan Miklosovic edited comment on CASSANDRA-18399 at 9/25/23 11:40 AM:
-
For the record I am not running any merging scripts either. I have my customly
tailored way how I merge up and if this is merged my workflow would not change
because of that. While I understand that somebody may have a different view on
this, until everybody agrees this is necessary and we are going to use it I am
reluctant to merge that and impose the workflow on others. We should be sure
that people can still do all of that manually as before if they want.
Everybody's workflow is different and I am cool with having my scripts locally
/ .gitignored ...
was (Author: smiklosovic):
For the record I am not running any merging scripts either. I have my customly
tailored way how I merge up and if this is merged my workflow would not change
because of that. While I understand that somebody may have a different view on
this, however until everybody agrees this is necessary and we are going to use
it I am reluctant to merge that and impose the workflow on others. We should be
sure that people can still do all of that manually as before if they want.
Everybody's workflow is different and I am cool with having my scripts locally
/ .gitignored ...
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit cassandra-3.11
> git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit #
[jira] [Updated] (CASSANDRA-18879) Modernize CQLSH datetime conversions
[
https://issues.apache.org/jira/browse/CASSANDRA-18879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18879:
---
Description:
Python 3.x introduced many updates to datetime conversion which allows
simplified conversions.
For example, tracing.py defines a function datetime_from_utc_to_local() but
datetime now has a native function astimezone() which will convert UTC to local
time.
Review the following users of datetime which apply conversions:
* cqlshmain.py
* formatting.py
* tracing.py
Example:
{code:java}
>>> a = datetime.datetime.now().astimezone(tz.tzutc())
>>> a
datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
>>> b = a.astimezone()
>>> b
datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
See [PEP 495|https://peps.python.org/pep-0495/]
was:
Python 3.x introduced many updates to datetime conversion which allows
simplified conversions.
For example, tracing.py defines a function datetime_from_utc_to_local() but
datetime now has a native function astimezone() which will convert UTC to local
time.
Example:
{code:java}
>>> a = datetime.datetime.now().astimezone(tz.tzutc())
>>> a
datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
>>> b = a.astimezone()
>>> b
datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
See [PEP 495|https://peps.python.org/pep-0495/]
> Modernize CQLSH datetime conversions
>
>
> Key: CASSANDRA-18879
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18879
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Priority: Low
>
> Python 3.x introduced many updates to datetime conversion which allows
> simplified conversions.
> For example, tracing.py defines a function datetime_from_utc_to_local() but
> datetime now has a native function astimezone() which will convert UTC to
> local time.
> Review the following users of datetime which apply conversions:
> * cqlshmain.py
> * formatting.py
> * tracing.py
> Example:
> {code:java}
> >>> a = datetime.datetime.now().astimezone(tz.tzutc())
> >>> a
> datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
> >>> b = a.astimezone()
> >>> b
> datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
> tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
> See [PEP 495|https://peps.python.org/pep-0495/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768650#comment-17768650
]
Stefan Miklosovic commented on CASSANDRA-18399:
---
For the record I am not running any merging scripts either. I have my customly
tailored way how I merge up and if this is merged my workflow would not change
because of that. While I understand that somebody may have a different view on
this, however until everybody agrees this is necessary and we are going to use
it I am reluctant to merge that and impose my workflow on others (even done in
a good faith and if the solution is opt-in). Everybody's workflow is different
and I am cool with having my scripts locally / .gitignored ...
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit cassandra-3.11
> git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n a71d4e3408 && git commit -a --amend --no-edit # a71d4e3408
> DO NOT MERGE - CircleCI config
> git cherry-pick -n 6dc53f4e97 && git commit -a --amend --no-edit # 6dc53f4e97
> fixes
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-4.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all
[jira] [Updated] (CASSANDRA-18879) Modernize CQLSH datetime conversions
[
https://issues.apache.org/jira/browse/CASSANDRA-18879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18879:
---
Change Category: Code Clarity
Complexity: Low Hanging Fruit
Priority: Low (was: Normal)
Status: Open (was: Triage Needed)
> Modernize CQLSH datetime conversions
>
>
> Key: CASSANDRA-18879
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18879
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Priority: Low
>
> Python 3.x introduced many updates to datetime conversion which allows
> simplified conversions.
> For example, tracing.py defines a function datetime_from_utc_to_local() but
> datetime now has a native function astimezone() which will convert UTC to
> local time.
> Example:
> {code:java}
> >>> a = datetime.datetime.now().astimezone(tz.tzutc())
> >>> a
> datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
> >>> b = a.astimezone()
> >>> b
> datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
> tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
> See [PEP 495|https://peps.python.org/pep-0495/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18879) Modernize CQLSH datetime conversions
Brad Schoening created CASSANDRA-18879:
--
Summary: Modernize CQLSH datetime conversions
Key: CASSANDRA-18879
URL: https://issues.apache.org/jira/browse/CASSANDRA-18879
Project: Cassandra
Issue Type: Improvement
Components: CQL/Interpreter
Reporter: Brad Schoening
Python 3.x introduced many updates to datetime conversion which allows
simplified conversions.
For example, tracing.py defines a function datetime_from_utc_to_local() but
datetime now has a native function astimezone() which will convert UTC to local
time.
Example:
{code:java}
>>> a = datetime.datetime.now().astimezone(tz.tzutc())
>>> a
datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
>>> b = a.astimezone()
>>> b
datetime.datetime(2023, 9, 25, 14, 22, 36, 251705,
tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EEST')) {code}
See [PEP 495|https://peps.python.org/pep-0495/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18878) Upgrade snappy java library
[ https://issues.apache.org/jira/browse/CASSANDRA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18878: Description: The snappy java library needs to be updated to fix the latest CVEs. [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] was: The snappy java library is needed to be upgraded to fix the latest CVEs. https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv > Upgrade snappy java library > --- > > Key: CASSANDRA-18878 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18878 > Project: Cassandra > Issue Type: Task > Components: Local/Commit Log, Messaging/Internode >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: High > Fix For: 3.11.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The snappy java library needs to be updated to fix the latest CVEs. > [https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
