[jira] [Comment Edited] (CASSANDRA-18314) Lift MessagingService.minimum_version to 40
[ https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783522#comment-17783522 ] Stefan Miklosovic edited comment on CASSANDRA-18314 at 11/7/23 7:55 AM: There is one bug so far I found, that is, we removed "too much" from HintDescriptor and this needs to go back (1). I am in the process of fixing this and making sure hints from times of 3.0 and 4.0 are indeed possible to be read in 5.0. I think these fixes might go in via CASSANDRA-19002. Hence, at the end of this effort in 19002, we should have tests for sstables, commit logs and hints and that all is readable from times of 3.0 and newer. (1) https://github.com/instaclustr/cassandra/commit/b1f0e2934da2776fe7835b5b87fdfda6e5ca29f5#diff-8223ad998e5ecde3546ee32f657e7e870ce62bf5d91674246fd36fa8a9b50226 was (Author: smiklosovic): There is one bug so far I found, that is, we removed "too much" from HintDescriptor and this need to go back (1). I am in the process of fixing this and making sure hints from times of 3.0 and 4.0 are indeed possible to be read in 5.0. I think these fixes might to in via CASSANDRA-19002. Hence, at the end of this effort in 19002, we should have tests for sstables, commit logs and hints and that all is readable from times of 3.0 and newer. (1) https://github.com/instaclustr/cassandra/commit/b1f0e2934da2776fe7835b5b87fdfda6e5ca29f5#diff-8223ad998e5ecde3546ee32f657e7e870ce62bf5d91674246fd36fa8a9b50226 > Lift MessagingService.minimum_version to 40 > --- > > Key: CASSANDRA-18314 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18314 > Project: Cassandra > Issue Type: Task > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.0, 5.0-alpha1 > > Time Spent: 15h 20m > Remaining Estimate: 0h > > MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in > Cassandra 5.0 anymore. > (Cassandra 5.0 currently is still using VERSION_40) > Patch: > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk > Raises the question whether backward compatibility to the previous major is > defined by the Cassandra version or by the internal component version > (MessagingService). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18314) Lift MessagingService.minimum_version to 40
[ https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783522#comment-17783522 ] Stefan Miklosovic commented on CASSANDRA-18314: --- There is one bug so far I found, that is, we removed "too much" from HintDescriptor and this need to go back (1). I am in the process of fixing this and making sure hints from times of 3.0 and 4.0 are indeed possible to be read in 5.0. I think these fixes might to in via CASSANDRA-19002. Hence, at the end of this effort in 19002, we should have tests for sstables, commit logs and hints and that all is readable from times of 3.0 and newer. (1) https://github.com/instaclustr/cassandra/commit/b1f0e2934da2776fe7835b5b87fdfda6e5ca29f5#diff-8223ad998e5ecde3546ee32f657e7e870ce62bf5d91674246fd36fa8a9b50226 > Lift MessagingService.minimum_version to 40 > --- > > Key: CASSANDRA-18314 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18314 > Project: Cassandra > Issue Type: Task > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.0, 5.0-alpha1 > > Time Spent: 15h 20m > Remaining Estimate: 0h > > MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in > Cassandra 5.0 anymore. > (Cassandra 5.0 currently is still using VERSION_40) > Patch: > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk > Raises the question whether backward compatibility to the previous major is > defined by the Cassandra version or by the internal component version > (MessagingService). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18945) Unified Compaction Strategy is creating too many sstables
[ https://issues.apache.org/jira/browse/CASSANDRA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783517#comment-17783517 ] Stefan Miklosovic edited comment on CASSANDRA-18945 at 11/7/23 7:47 AM: So ... this is interesting. It fails the multiplexer of j17_jvm_dtests_vnode_repeat as well as the individual test in j17_jvm_dtests_vnode What is interesting is that it does not fail j17_jvm_dtests_repeat (without vnode). java17_separate_tests which runs j17_jvm_dtests_vnode does not fail it either. I am trying to run j17_jvm_dtests_vnode_repeat for java17_separate_tests if it indeed fails there too. This is the PR against trunk. This is the branch (2) (1) https://app.circleci.com/pipelines/github/instaclustr/cassandra/3443/workflows/97bfb70b-146a-4da8-afaf-7f5909b0492d (2) https://github.com/instaclustr/cassandra/commits/CASSANDRA-18945-trunk was (Author: smiklosovic): So ... this is interesting. It fails the multiplexer of j17_jvm_dtests_vnode_repeat as well as the individual test in j17_jvm_dtests_vnode What is interesting is that it does not fail j17_jvm_dtests_repeat (without vnode). java17_separate_tests which runs j17_jvm_dtests_vnode does not fail it either. I am trying to run j17_jvm_dtests_vnode_repeat for java17_separate_tests if it indeed fails there too. This is the PR against trunk. (1) https://app.circleci.com/pipelines/github/instaclustr/cassandra/3443/workflows/97bfb70b-146a-4da8-afaf-7f5909b0492d > Unified Compaction Strategy is creating too many sstables > - > > Key: CASSANDRA-18945 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18945 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: Branimir Lambov >Assignee: Ethan Brown >Priority: Normal > Fix For: 5.0-beta > > Attachments: file_ucs_shenandoah.html, file_ucs_shenandoah_3.html, > file_ucs_shenandoah_off_heap_memtable.html, > file_ucs_shenandoah_on_heap_memtable_2.html, > file_ucs_shenandoah_on_heap_memtable_3.html, key-value-oss.html > > Time Spent: 1h 50m > Remaining Estimate: 0h > > The unified compaction strategy currently aims to create sstables with close > to the same size, defaulting to 1 GiB. Unfortunately tests show that > Cassandra starts to have performance problems when the number of sstables > grows to the order of a thousand, and in particular that even 1 TiB of data > with the default configuration is creating too many sstables for efficient > processing. This matters even more for SAI, where the number of sstables in > the system can have a proportional effect on the complexity of operations. > It is quite easy to create a configuration option that allows sstables to > take some part of the data growth by adding a multiplier to [the shard count > calculation|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md#sharding] > formula, replacing > {{2 ^ round(log2(d / (t * b))) * b}} > with > {{2 ^ round((1 - 휆) * log2(d / (t * b))) * b}}, > where 휆 is a parameter whose value is between 0 and 1. > With this, a 휆 of 0.5 would mean that shard count and sstable size grow in > parallel at the square root of the data size growth. 0 would result in no > growth, and 1 in always using the same number of shards. > It may also be valuable to introduce a threshold for engaging the base shard > count to avoid splitting lowest-level sstables into fragments that are too > small. > Once both of these are in place, we can set defaults that better suit all > node densities, including 10 TiB and beyond, for example: > - target size of 1 GiB > - 휆 of 1/3 > - base shard count of 4 > - minimum size 100 MiB -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18945) Unified Compaction Strategy is creating too many sstables
[ https://issues.apache.org/jira/browse/CASSANDRA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783517#comment-17783517 ] Stefan Miklosovic commented on CASSANDRA-18945: --- So ... this is interesting. It fails the multiplexer of j17_jvm_dtests_vnode_repeat as well as the individual test in j17_jvm_dtests_vnode What is interesting is that it does not fail j17_jvm_dtests_repeat (without vnode). java17_separate_tests which runs j17_jvm_dtests_vnode does not fail it either. I am trying to run j17_jvm_dtests_vnode_repeat for java17_separate_tests if it indeed fails there too. This is the PR against trunk. (1) https://app.circleci.com/pipelines/github/instaclustr/cassandra/3443/workflows/97bfb70b-146a-4da8-afaf-7f5909b0492d > Unified Compaction Strategy is creating too many sstables > - > > Key: CASSANDRA-18945 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18945 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: Branimir Lambov >Assignee: Ethan Brown >Priority: Normal > Fix For: 5.0-beta > > Attachments: file_ucs_shenandoah.html, file_ucs_shenandoah_3.html, > file_ucs_shenandoah_off_heap_memtable.html, > file_ucs_shenandoah_on_heap_memtable_2.html, > file_ucs_shenandoah_on_heap_memtable_3.html, key-value-oss.html > > Time Spent: 1h 50m > Remaining Estimate: 0h > > The unified compaction strategy currently aims to create sstables with close > to the same size, defaulting to 1 GiB. Unfortunately tests show that > Cassandra starts to have performance problems when the number of sstables > grows to the order of a thousand, and in particular that even 1 TiB of data > with the default configuration is creating too many sstables for efficient > processing. This matters even more for SAI, where the number of sstables in > the system can have a proportional effect on the complexity of operations. > It is quite easy to create a configuration option that allows sstables to > take some part of the data growth by adding a multiplier to [the shard count > calculation|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md#sharding] > formula, replacing > {{2 ^ round(log2(d / (t * b))) * b}} > with > {{2 ^ round((1 - 휆) * log2(d / (t * b))) * b}}, > where 휆 is a parameter whose value is between 0 and 1. > With this, a 휆 of 0.5 would mean that shard count and sstable size grow in > parallel at the square root of the data size growth. 0 would result in no > growth, and 1 in always using the same number of shards. > It may also be valuable to introduce a threshold for engaging the base shard > count to avoid splitting lowest-level sstables into fragments that are too > small. > Once both of these are in place, we can set defaults that better suit all > node densities, including 10 TiB and beyond, for example: > - target size of 1 GiB > - 휆 of 1/3 > - base shard count of 4 > - minimum size 100 MiB -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18945) Unified Compaction Strategy is creating too many sstables
[ https://issues.apache.org/jira/browse/CASSANDRA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18945: -- Status: Changes Suggested (was: Review In Progress) > Unified Compaction Strategy is creating too many sstables > - > > Key: CASSANDRA-18945 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18945 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: Branimir Lambov >Assignee: Ethan Brown >Priority: Normal > Fix For: 5.0-beta > > Attachments: file_ucs_shenandoah.html, file_ucs_shenandoah_3.html, > file_ucs_shenandoah_off_heap_memtable.html, > file_ucs_shenandoah_on_heap_memtable_2.html, > file_ucs_shenandoah_on_heap_memtable_3.html, key-value-oss.html > > Time Spent: 1h 50m > Remaining Estimate: 0h > > The unified compaction strategy currently aims to create sstables with close > to the same size, defaulting to 1 GiB. Unfortunately tests show that > Cassandra starts to have performance problems when the number of sstables > grows to the order of a thousand, and in particular that even 1 TiB of data > with the default configuration is creating too many sstables for efficient > processing. This matters even more for SAI, where the number of sstables in > the system can have a proportional effect on the complexity of operations. > It is quite easy to create a configuration option that allows sstables to > take some part of the data growth by adding a multiplier to [the shard count > calculation|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md#sharding] > formula, replacing > {{2 ^ round(log2(d / (t * b))) * b}} > with > {{2 ^ round((1 - 휆) * log2(d / (t * b))) * b}}, > where 휆 is a parameter whose value is between 0 and 1. > With this, a 휆 of 0.5 would mean that shard count and sstable size grow in > parallel at the square root of the data size growth. 0 would result in no > growth, and 1 in always using the same number of shards. > It may also be valuable to introduce a threshold for engaging the base shard > count to avoid splitting lowest-level sstables into fragments that are too > small. > Once both of these are in place, we can set defaults that better suit all > node densities, including 10 TiB and beyond, for example: > - target size of 1 GiB > - 휆 of 1/3 > - base shard count of 4 > - minimum size 100 MiB -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783488#comment-17783488 ] Berenguer Blasi commented on CASSANDRA-18688: - There is a [pending question|https://github.com/apache/cassandra/pull/2563#discussion_r1336232693] in the PR cc/[~mck] [~stefan.miklosovic] and I would at least rebase. > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 3.5.x copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1818: URL: https://github.com/apache/cassandra-java-driver/pull/1818 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 3.3.x copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1816: URL: https://github.com/apache/cassandra-java-driver/pull/1816 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 3.4.x copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1817: URL: https://github.com/apache/cassandra-java-driver/pull/1817 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 3.2.x copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1815: URL: https://github.com/apache/cassandra-java-driver/pull/1815 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 3.10.x copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1814: URL: https://github.com/apache/cassandra-java-driver/pull/1814 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 3.10.2 fixes copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1813: URL: https://github.com/apache/cassandra-java-driver/pull/1813 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 3.1.x copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1812: URL: https://github.com/apache/cassandra-java-driver/pull/1812 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 3.0.x copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1811: URL: https://github.com/apache/cassandra-java-driver/pull/1811 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 2.2 copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1810: URL: https://github.com/apache/cassandra-java-driver/pull/1810 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 2.1 copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1809: URL: https://github.com/apache/cassandra-java-driver/pull/1809 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 2.0.9 fixes copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1808: URL: https://github.com/apache/cassandra-java-driver/pull/1808 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 2.0 copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1806: URL: https://github.com/apache/cassandra-java-driver/pull/1806 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 2.0.10 fixes copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1807: URL: https://github.com/apache/cassandra-java-driver/pull/1807 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 1.0 copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1805: URL: https://github.com/apache/cassandra-java-driver/pull/1805 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-18969: 3.x copyright check [cassandra-java-driver]
hhughes opened a new pull request, #1804: URL: https://github.com/apache/cassandra-java-driver/pull/1804 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18934) Downgrade to 4.1 fails due to schema changes
[ https://issues.apache.org/jira/browse/CASSANDRA-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783480#comment-17783480 ] Jeremiah Jordan commented on CASSANDRA-18934: - By clean commitlog I mean no commitlog. Aka you shutdown using drain such that the commitlog is cleared out on shutdown. > Downgrade to 4.1 fails due to schema changes > > > Key: CASSANDRA-18934 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18934 > Project: Cassandra > Issue Type: Bug > Components: Local/Startup and Shutdown >Reporter: David Capwell >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > > We are required to support 5.0 downgrading to 4.1 as a migration step, but we > don’t have tests to show this is working… I wrote a quick test to make sure a > change we needed in Accord wouldn’t block the downgrade and see that we fail > right now. > {code} > ERROR 20:56:39 Exiting due to error while processing commit log during > initialization. > org.apache.cassandra.db.commitlog.CommitLogReadHandler$CommitLogReadException: > Unexpected error deserializing mutation; saved to > /var/folders/h1/s_3p1x3s3hl0hltbpck67m0hgn/T/mutation418421767150092dat. > This may be caused by replaying a mutation against a table with the same > name but incompatible schema. Exception follows: java.lang.RuntimeException: > Unknown column compaction_properties during deserialization > at > org.apache.cassandra.db.commitlog.CommitLogReader.readMutation(CommitLogReader.java:464) > at > org.apache.cassandra.db.commitlog.CommitLogReader.readSection(CommitLogReader.java:397) > at > org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:244) > at > org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:147) > at > org.apache.cassandra.db.commitlog.CommitLogReplayer.replayFiles(CommitLogReplayer.java:191) > at > org.apache.cassandra.db.commitlog.CommitLog.recoverFiles(CommitLog.java:223) > at > org.apache.cassandra.db.commitlog.CommitLog.recoverSegmentsOnDisk(CommitLog.java:204) > {code} > This was caused by a schema change in CASSANDRA-18061 > {code} > /* > * Licensed to the Apache Software Foundation (ASF) under one > * or more contributor license agreements. See the NOTICE file > * distributed with this work for additional information > * regarding copyright ownership. The ASF licenses this file > * to you under the Apache License, Version 2.0 (the > * "License"); you may not use this file except in compliance > * with the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ > package org.apache.cassandra.distributed.upgrade; > import java.io.IOException; > import java.io.File; > import java.util.concurrent.atomic.AtomicBoolean; > import org.junit.Test; > import org.apache.cassandra.distributed.api.IUpgradeableInstance; > public class DowngradeTest extends UpgradeTestBase > { > @Test > public void test() throws Throwable > { > AtomicBoolean first = new AtomicBoolean(true); > new TestCase() > .nodes(1) > .withConfig(c -> { > if (first.compareAndSet(true, false)) > c.set("storage_compatibility_mode", "CASSANDRA_4"); > }) > .downgradeTo(v41) > .setup(cluster -> {}) > // Uncomment if you want to test what happens after reading the commit log, > which fails right now > //.runBeforeNodeRestart((cluster, nodeId) -> { > //IUpgradeableInstance inst = cluster.get(nodeId); > //File f = new File((String) > inst.config().get("commitlog_directory")); > //deleteRecursive(f); > //}) > .runAfterClusterUpgrade(cluster -> {}) > .run(); > } > private void deleteRecursive(File f) > { > if (f.isDirectory()) > { > File[] children = f.listFiles(); > if (children != null) > { > for (File c : children) > deleteRecursive(c); > } > } > f.delete(); > } > } > {code} > {code} > diff --git > a/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java > > b/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java > index 5ee8780204..b4111e3b44 100644
Re: [PR] CASSANDRA-16969 4.12.x license check [cassandra-java-driver]
hhughes commented on PR #1764: URL: https://github.com/apache/cassandra-java-driver/pull/1764#issuecomment-1797830059 I've opened #1803 which has a properly formatted `Jenkinsfile` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 4.12.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1803: URL: https://github.com/apache/cassandra-java-driver/pull/1803 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/core/src/main/resources/META-INF/services/reactor.blockhound.integration.BlockHoundIntegration /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/duplicate-dependencies.txt /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/netty-dependency-optional.txt /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/netty-dependency.txt /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/ordered-dependencies.txt /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/test-dependencies.txt /Users/henry.hughes/repos/java-driver/integration-tests/src/test/resources/META-INF/services/com.datastax.oss.driver.api.mapper.result.MapperResultProducerService /Users/henry.hughes/repos/java-driver/manual/.nav /Users/henry.hughes/repos/java-driver/manual/core/dse/.nav /Users/henry.hughes/repos/java-driver/manual/core/dse/graph/.nav /Users/henry.hughes/repos/java-driver/manual/core/dse/graph/fluent/.nav /Users/henry.hughes/repos/java-driver/manual/core/statements/.nav /Users/henry.hughes/repos/java-driver/manual/developer/.nav /Users/henry.hughes/repos/java-driver/manual/developer/common/.nav /Users/henry.hughes/repos/java-driver/manual/mapper/.nav /Users/henry.hughes/repos/java-driver/manual/mapper/daos/.nav /Users/henry.hughes/repos/java-driver/manual/query_builder/.nav /Users/henry.hughes/repos/java-driver/manual/query_builder/schema/.nav /Users/henry.hughes/repos/java-driver/mapper-processor/src/main/resources/META-INF/services/javax.annotation.processing.Processor /Users/henry.hughes/repos/java-driver/test-infra/src/main/resources/client.crt /Users/henry.hughes/repos/java-driver/test-infra/src/main/resources/client.key -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.11.x license check [cassandra-java-driver]
hhughes commented on PR #1775: URL: https://github.com/apache/cassandra-java-driver/pull/1775#issuecomment-1797829134 I've opened #1802 which has a properly formatted `Jenkinsfile` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 4.11.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1802: URL: https://github.com/apache/cassandra-java-driver/pull/1802 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/core/src/main/resources/META-INF/services/reactor.blockhound.integration.BlockHoundIntegration /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/duplicate-dependencies.txt /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/netty-dependency-optional.txt /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/netty-dependency.txt /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/ordered-dependencies.txt /Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/test-dependencies.txt /Users/henry.hughes/repos/java-driver/integration-tests/src/test/resources/META-INF/services/com.datastax.oss.driver.api.mapper.result.MapperResultProducerService /Users/henry.hughes/repos/java-driver/manual/.nav /Users/henry.hughes/repos/java-driver/manual/core/dse/.nav /Users/henry.hughes/repos/java-driver/manual/core/dse/graph/.nav /Users/henry.hughes/repos/java-driver/manual/core/dse/graph/fluent/.nav /Users/henry.hughes/repos/java-driver/manual/core/statements/.nav /Users/henry.hughes/repos/java-driver/manual/developer/.nav /Users/henry.hughes/repos/java-driver/manual/developer/common/.nav /Users/henry.hughes/repos/java-driver/manual/mapper/.nav /Users/henry.hughes/repos/java-driver/manual/mapper/daos/.nav /Users/henry.hughes/repos/java-driver/manual/query_builder/.nav /Users/henry.hughes/repos/java-driver/manual/query_builder/schema/.nav /Users/henry.hughes/repos/java-driver/mapper-processor/src/main/resources/META-INF/services/javax.annotation.processing.Processor /Users/henry.hughes/repos/java-driver/test-infra/src/main/resources/client.crt /Users/henry.hughes/repos/java-driver/test-infra/src/main/resources/client.key -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-website) branch asf-staging updated (9eff814d9 -> c34b41fc3)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 9eff814d9 generate docs for a69b82d6 new c34b41fc3 generate docs for a69b82d6 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (9eff814d9) \ N -- N -- N refs/heads/asf-staging (c34b41fc3) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7662) Implement templated CREATE TABLE functionality (CREATE TABLE LIKE)
[ https://issues.apache.org/jira/browse/CASSANDRA-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783465#comment-17783465 ] Maxwell Guo commented on CASSANDRA-7662: I just saw the original patch of [~aleksey] which merge the like with create table. if we do not going to copy data, I think thing may be easier. [~epsi.rex] simply pass tablemetadata to create table statement may be not work for this patch, as tablemetadata contains not only the columns , table param which described the table schema, but also trigger ,index and so on which is should not be copied. You can just build a new one I think. Besides, some tests is needed. > Implement templated CREATE TABLE functionality (CREATE TABLE LIKE) > -- > > Key: CASSANDRA-7662 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7662 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/CQL >Reporter: Aleksey Yeschenko >Priority: Low > Labels: AdventCalendar2021, lhf > Fix For: 5.x > > Attachments: 7662.patch, CASSANDRA-7662.patch > > > Implement templated CREATE TABLE functionality (CREATE TABLE LIKE) to > simplify creating new tables duplicating existing ones (see parent_table part > of http://www.postgresql.org/docs/9.1/static/sql-createtable.html). > CREATE TABLE LIKE ; - would create a new table with > the same columns and options as > +Additional info for newcomers:+ > In order to implement this change you will need to change the Parser.g ANTLR > file located in the src/antlr directory and the java classes corresponding to > the CREATE statement located in the > org.apache.cassandra.cql3.statements.schema package. > The unit test for the CQL logic are located under > org.apache.cassandra.cql3.validation > cqlsh parsing will need to be modified to support the new LIKE syntax. The > logic is in pylib/cqlshlib/cql3handling.py and the test in > pylib/cqlshlib/test/test_cqlsh_completion.py -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18934) Downgrade to 4.1 fails due to schema changes
[ https://issues.apache.org/jira/browse/CASSANDRA-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783464#comment-17783464 ] Maxwell Guo commented on CASSANDRA-18934: - Any background on downgrade, and What is the current specific progress? [~dcapwell][~jjordan][~claude]. I think we can make a clean commitlog and even a system table data before downgrade back to 4.1 , but I think we should know we are going to do that , as I think we can not doing normal reading and writing operations,while cleaning the log at the same time. Am I right ? > Downgrade to 4.1 fails due to schema changes > > > Key: CASSANDRA-18934 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18934 > Project: Cassandra > Issue Type: Bug > Components: Local/Startup and Shutdown >Reporter: David Capwell >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > > We are required to support 5.0 downgrading to 4.1 as a migration step, but we > don’t have tests to show this is working… I wrote a quick test to make sure a > change we needed in Accord wouldn’t block the downgrade and see that we fail > right now. > {code} > ERROR 20:56:39 Exiting due to error while processing commit log during > initialization. > org.apache.cassandra.db.commitlog.CommitLogReadHandler$CommitLogReadException: > Unexpected error deserializing mutation; saved to > /var/folders/h1/s_3p1x3s3hl0hltbpck67m0hgn/T/mutation418421767150092dat. > This may be caused by replaying a mutation against a table with the same > name but incompatible schema. Exception follows: java.lang.RuntimeException: > Unknown column compaction_properties during deserialization > at > org.apache.cassandra.db.commitlog.CommitLogReader.readMutation(CommitLogReader.java:464) > at > org.apache.cassandra.db.commitlog.CommitLogReader.readSection(CommitLogReader.java:397) > at > org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:244) > at > org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:147) > at > org.apache.cassandra.db.commitlog.CommitLogReplayer.replayFiles(CommitLogReplayer.java:191) > at > org.apache.cassandra.db.commitlog.CommitLog.recoverFiles(CommitLog.java:223) > at > org.apache.cassandra.db.commitlog.CommitLog.recoverSegmentsOnDisk(CommitLog.java:204) > {code} > This was caused by a schema change in CASSANDRA-18061 > {code} > /* > * Licensed to the Apache Software Foundation (ASF) under one > * or more contributor license agreements. See the NOTICE file > * distributed with this work for additional information > * regarding copyright ownership. The ASF licenses this file > * to you under the Apache License, Version 2.0 (the > * "License"); you may not use this file except in compliance > * with the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ > package org.apache.cassandra.distributed.upgrade; > import java.io.IOException; > import java.io.File; > import java.util.concurrent.atomic.AtomicBoolean; > import org.junit.Test; > import org.apache.cassandra.distributed.api.IUpgradeableInstance; > public class DowngradeTest extends UpgradeTestBase > { > @Test > public void test() throws Throwable > { > AtomicBoolean first = new AtomicBoolean(true); > new TestCase() > .nodes(1) > .withConfig(c -> { > if (first.compareAndSet(true, false)) > c.set("storage_compatibility_mode", "CASSANDRA_4"); > }) > .downgradeTo(v41) > .setup(cluster -> {}) > // Uncomment if you want to test what happens after reading the commit log, > which fails right now > //.runBeforeNodeRestart((cluster, nodeId) -> { > //IUpgradeableInstance inst = cluster.get(nodeId); > //File f = new File((String) > inst.config().get("commitlog_directory")); > //deleteRecursive(f); > //}) > .runAfterClusterUpgrade(cluster -> {}) > .run(); > } > private void deleteRecursive(File f) > { > if (f.isDirectory()) > { > File[] children = f.listFiles(); > if (children != null) > { > for (File c : children) > deleteRecursive(c); > } > } > f.delete(); >
[jira] [Updated] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxwell Guo updated CASSANDRA-18994: Reviewers: Caleb Rackliffe, Maxwell Guo, Stefan Miklosovic (was: Caleb Rackliffe, Stefan Miklosovic) > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.index.sai.plan.Expression.add(Expression.java:171) > at > org.apache.cassandra.index.sai.plan.Operation.buildIndexExpressions(Operation.java:136) > at > org.apache.cassandra.index.sai.plan.Operation$AndNode.analyze(Operation.java:303) > at > org.apache.cassandra.index.sai.plan.Operation$Node.doTreeAnalysis(Operation.java:266) > at > org.apache.cassandra.index.sai.plan.Operation$Node.analyzeTree(Operation.java:251) > at > org.apache.cassandra.index.sai.plan.Operation.buildIterator(Operation.java:185) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher$ResultRetriever.(StorageAttachedIndexSearcher.java:151) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher.search(StorageAttachedIndexSearcher.java:107) > at >
[jira] [Commented] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[ https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783461#comment-17783461 ] Paulo Motta commented on CASSANDRA-19001: - Hi Ekaterina, thanks for looking into this! I will try to reproduce and get back to you ASAP. > Check whether the startup warnings for unknown modules represent a legit > problem or cosmetic issue > -- > > Key: CASSANDRA-19001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19001 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta > > > During the 5.0 alpha 2 release > [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr], > [~paulo] raised the following concerns: > {code:java} > Launched a tarball-based 5.0-alpha2 container on top of > "eclipse-temurin:17-jre-focal" and the server starts up fine, can run > nodetool and cqlsh. > I got these seemingly harmless JDK17 warnings during startup and when > running nodetool (no warnings on JDK11): > WARNING: Unknown module: jdk.attach specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-opens > WARNING: A terminally deprecated method in java.lang.System has been called > WARNING: System::setSecurityManager has been called by > org.apache.cassandra.security.ThreadAwareSecurityManager > (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar) > WARNING: Please consider reporting this to the maintainers of > org.apache.cassandra.security.ThreadAwareSecurityManager > WARNING: System::setSecurityManager will be removed in a future release > Anybody knows if these warnings are legit/expected ? We can create > follow-up tickets if needed. > $ java --version > openjdk 17.0.9 2023-10-17 > OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9) > OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode, > sharing) > {code} > {code:java} > Clarification: - When running nodetool only the "Unknown module" warnings > show up. All warnings show up during startup.{code} > We need to verify whether this presents a real problem in the features where > those modules are expected to be used, or if it is a false alarm. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 3.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1801: URL: https://github.com/apache/cassandra-java-driver/pull/1801 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.crt /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.key /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/driver-tests/osgi/.gitignore /Users/henry.hughes/repos/java-driver/manual/object_mapper/.nav /Users/henry.hughes/repos/java-driver/manual/statements/.nav /Users/henry.hughes/repos/java-driver/upgrade_guide/migrating_from_astyanax/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 3.5.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1800: URL: https://github.com/apache/cassandra-java-driver/pull/1800 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.crt /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.key /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/driver-tests/osgi/.gitignore /Users/henry.hughes/repos/java-driver/manual/object_mapper/.nav /Users/henry.hughes/repos/java-driver/manual/statements/.nav /Users/henry.hughes/repos/java-driver/upgrade_guide/migrating_from_astyanax/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 3.4.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1799: URL: https://github.com/apache/cassandra-java-driver/pull/1799 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.crt /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.key /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/driver-tests/osgi/.gitignore /Users/henry.hughes/repos/java-driver/manual/object_mapper/.nav /Users/henry.hughes/repos/java-driver/manual/statements/.nav /Users/henry.hughes/repos/java-driver/upgrade_guide/migrating_from_astyanax/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 3.3.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1798: URL: https://github.com/apache/cassandra-java-driver/pull/1798 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.crt /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.key /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/driver-tests/osgi/.gitignore /Users/henry.hughes/repos/java-driver/manual/object_mapper/.nav /Users/henry.hughes/repos/java-driver/manual/statements/.nav /Users/henry.hughes/repos/java-driver/upgrade_guide/migrating_from_astyanax/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 3.2.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1797: URL: https://github.com/apache/cassandra-java-driver/pull/1797 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.crt /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.key /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/driver-tests/osgi/.gitignore /Users/henry.hughes/repos/java-driver/manual/object_mapper/.nav /Users/henry.hughes/repos/java-driver/manual/statements/.nav /Users/henry.hughes/repos/java-driver/upgrade_guide/migrating_from_astyanax/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 3.10.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1796: URL: https://github.com/apache/cassandra-java-driver/pull/1796 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/Jenkinsfile.disabled /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.crt /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.key /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/driver-tests/osgi/.gitignore /Users/henry.hughes/repos/java-driver/manual/object_mapper/.nav /Users/henry.hughes/repos/java-driver/manual/statements/.nav /Users/henry.hughes/repos/java-driver/upgrade_guide/migrating_from_astyanax/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 3.10.2 fixes license check [cassandra-java-driver]
hhughes opened a new pull request, #1795: URL: https://github.com/apache/cassandra-java-driver/pull/1795 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.crt /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.key /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/driver-tests/osgi/.gitignore /Users/henry.hughes/repos/java-driver/manual/object_mapper/.nav /Users/henry.hughes/repos/java-driver/manual/statements/.nav /Users/henry.hughes/repos/java-driver/upgrade_guide/migrating_from_astyanax/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 3.1.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1794: URL: https://github.com/apache/cassandra-java-driver/pull/1794 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.crt /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.key /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/driver-tests/osgi/.gitignore /Users/henry.hughes/repos/java-driver/manual/object_mapper/.nav /Users/henry.hughes/repos/java-driver/manual/statements/.nav /Users/henry.hughes/repos/java-driver/upgrade_guide/migrating_from_astyanax/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 3.0.x license check [cassandra-java-driver]
hhughes opened a new pull request, #1793: URL: https://github.com/apache/cassandra-java-driver/pull/1793 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.crt /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/client.key /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/manual/object_mapper/.nav /Users/henry.hughes/repos/java-driver/manual/statements/.nav /Users/henry.hughes/repos/java-driver/upgrade_guide/migrating_from_astyanax/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 2.2 license check [cassandra-java-driver]
hhughes opened a new pull request, #1792: URL: https://github.com/apache/cassandra-java-driver/pull/1792 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/features/object_mapper/.nav /Users/henry.hughes/repos/java-driver/src/main/config/ide/eclipse.importorder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 2.1 license check [cassandra-java-driver]
hhughes opened a new pull request, #1791: URL: https://github.com/apache/cassandra-java-driver/pull/1791 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/manual/statements/.nav -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 2.0.9 fixes license check [cassandra-java-driver]
hhughes opened a new pull request, #1790: URL: https://github.com/apache/cassandra-java-driver/pull/1790 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/src/main/config/ide/eclipse.importorder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 2.0.10 fixes license check [cassandra-java-driver]
hhughes opened a new pull request, #1789: URL: https://github.com/apache/cassandra-java-driver/pull/1789 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener /Users/henry.hughes/repos/java-driver/src/main/config/ide/eclipse.importorder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 2.0 license check [cassandra-java-driver]
hhughes opened a new pull request, #1788: URL: https://github.com/apache/cassandra-java-driver/pull/1788 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-16969: 1.0 license check [cassandra-java-driver]
hhughes opened a new pull request, #1787: URL: https://github.com/apache/cassandra-java-driver/pull/1787 Files with unapproved licenses: /Users/henry.hughes/repos/java-driver/.gitignore /Users/henry.hughes/repos/java-driver/driver-core/src/test/resources/META-INF/services/org.testng.ITestNGListener -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783442#comment-17783442 ] Ekaterina Dimitrova commented on CASSANDRA-18992: - In the meantime, I started the preliminary 5.0 CI run here - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18992-review-5.0] Let's see what it will show. [~aweisberg], can you be a second reviewer here, please? > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18992: Reviewers: Ekaterina Dimitrova Status: Review In Progress (was: Patch Available) > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-website) branch asf-staging updated (fb2f2a15c -> 9eff814d9)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard fb2f2a15c generate docs for a69b82d6 new 9eff814d9 generate docs for a69b82d6 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (fb2f2a15c) \ N -- N -- N refs/heads/asf-staging (9eff814d9) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[ https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783439#comment-17783439 ] Ekaterina Dimitrova edited comment on CASSANDRA-19001 at 11/7/23 1:22 AM: -- 1) Actually, I do not see now the security manager warnings on startup, only on compile. But adding a suppression to the ThreadAwareSecurityManager should help with those _I think:_ {code:java} @SuppressWarnings("removal") public final class ThreadAwareSecurityManager extends SecurityManager{code} [~paulo] , do you mind to test whether this suppression solves completely the issue for you? I cannot reproduce this startup warning, only compilation. 2) SJK cannot run sjk hh if not run with JDK. Nothing to do there and it gives an error message that explains that you should not use JRE. I do not like hacks to remove warnings when they have a real meaning so my suggestion is to add below comment in the options file. When people setup their Cassandra nodes they will decide what to do. {code:java} # You cannot run nodetool sjk hh without below option with JDK17. # It will generate a startup warning for missing module when using JRE and not JDK; sjk hh will not be available. # If you want to use JRE and not see the warning, you can comment below option. --add-exports jdk.attach/sun.tools.attach=ALL-UNNAMED{code} 3) I tried running our CI without using the options that generate the reported warnings. Our CI does not show any problems, except the sjk error mentioned: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19001-5.0] Though we know this doesn't mean there is no hidden problem. I just submitted an OpenHFT github issue question to verify what potential impact might be. Better to get advice from the source instead of guessing on my own. was (Author: e.dimitrova): 1) Actually, I do not see now the security manager warnings on startup, only on compile. But adding a suppression to the ThreadAwareSecurityManager should help with those _I think:_ {code:java} @SuppressWarnings("removal") public final class ThreadAwareSecurityManager extends SecurityManager{code} [~paulo] , do you mind to test whether this suppression solves completely the issue for you? I cannot reproduce this startup warning, only compilation. 2) SJK cannot run sjk hh if not run with JDK. Nothing to do there and it gives an error message that explains that. I do not like hacks to remove warnings when they have a real meaning so my suggestion is to add below comment in the options file. When people setup their Cassandra nodes they will decide what to do. {code:java} # You cannot run nodetool sjk hh without below option with JDK17. # It will generate a startup warning for missing module when using JRE and not JDK; sjk hh will not be available. # If you want to use JRE and not see the warning, you can comment below option. --add-exports jdk.attach/sun.tools.attach=ALL-UNNAMED{code} 3) I tried running our CI without using the options that generate the reported warnings. Our CI does not show any problems, except the sjk error mentioned: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19001-5.0] Though we know this doesn't mean there is no hidden problem. I just submitted an OpenHFT github issue question to verify what potential impact might be. Better to get advice from the source instead of guessing on my own. > Check whether the startup warnings for unknown modules represent a legit > problem or cosmetic issue > -- > > Key: CASSANDRA-19001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19001 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta > > > During the 5.0 alpha 2 release > [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr], > [~paulo] raised the following concerns: > {code:java} > Launched a tarball-based 5.0-alpha2 container on top of > "eclipse-temurin:17-jre-focal" and the server starts up fine, can run > nodetool and cqlsh. > I got these seemingly harmless JDK17 warnings during startup and when > running nodetool (no warnings on JDK11): > WARNING: Unknown module: jdk.attach specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-opens > WARNING: A terminally deprecated method in java.lang.System has been called > WARNING: System::setSecurityManager has been called by > org.apache.cassandra.security.ThreadAwareSecurityManager >
[jira] [Comment Edited] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[ https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783439#comment-17783439 ] Ekaterina Dimitrova edited comment on CASSANDRA-19001 at 11/7/23 1:21 AM: -- 1) Actually, I do not see now the security manager warnings on startup, only on compile. But adding a suppression to the ThreadAwareSecurityManager should help with those _I think:_ {code:java} @SuppressWarnings("removal") public final class ThreadAwareSecurityManager extends SecurityManager{code} [~paulo] , do you mind to test whether this suppression solves completely the issue for you? I cannot reproduce this startup warning, only compilation. 2) SJK cannot run sjk hh if not run with JDK. Nothing to do there and it gives an error message that explains that. I do not like hacks to remove warnings when they have a real meaning so my suggestion is to add below comment in the options file. When people setup their Cassandra nodes they will decide what to do. {code:java} # You cannot run nodetool sjk hh without below option with JDK17. # It will generate a startup warning for missing module when using JRE and not JDK; sjk hh will not be available. # If you want to use JRE and not see the warning, you can comment below option. --add-exports jdk.attach/sun.tools.attach=ALL-UNNAMED{code} 3) I tried running our CI without using the options that generate the reported warnings. Our CI does not show any problems, except the sjk error mentioned: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19001-5.0] Though we know this doesn't mean there is no hidden problem. I just submitted an OpenHFT github issue question to verify what potential impact might be. Better to get advice from the source instead of guessing on my own. was (Author: e.dimitrova): 1) Actually, I do not see now the security managers on startup, only on compile. But adding a suppression to the ThreadAwareSecurityManager should help with those _I think:_ {code:java} @SuppressWarnings("removal") public final class ThreadAwareSecurityManager extends SecurityManager{code} [~paulo] , do you mind to test whether this suppression solves completely the issue for you? I cannot reproduce this startup warning, only compilation. 2) SJK cannot run sjk hh if not run with JDK. Nothing to do there and it gives an error message that explains that. I do not like hacks to remove warnings when they have a real meaning so my suggestion is to add below comment in the options file. When people setup their Cassandra nodes they will decide what to do. {code:java} # You cannot run nodetool sjk hh without below option with JDK17. # It will generate a startup warning for missing module when using JRE and not JDK; sjk hh will not be available. # If you want to use JRE and not see the warning, you can comment below option. --add-exports jdk.attach/sun.tools.attach=ALL-UNNAMED{code} 3) I tried running our CI without using the options that generate the reported warnings. Our CI does not show any problems, except the sjk error mentioned: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19001-5.0] Though we know this doesn't mean there is no hidden problem. I just submitted an OpenHFT github issue question to verify what potential impact might be. Better to get advice from the source instead of guessing on my own. > Check whether the startup warnings for unknown modules represent a legit > problem or cosmetic issue > -- > > Key: CASSANDRA-19001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19001 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta > > > During the 5.0 alpha 2 release > [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr], > [~paulo] raised the following concerns: > {code:java} > Launched a tarball-based 5.0-alpha2 container on top of > "eclipse-temurin:17-jre-focal" and the server starts up fine, can run > nodetool and cqlsh. > I got these seemingly harmless JDK17 warnings during startup and when > running nodetool (no warnings on JDK11): > WARNING: Unknown module: jdk.attach specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-opens > WARNING: A terminally deprecated method in java.lang.System has been called > WARNING: System::setSecurityManager has been called by > org.apache.cassandra.security.ThreadAwareSecurityManager > (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar) >
[jira] [Commented] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[ https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783439#comment-17783439 ] Ekaterina Dimitrova commented on CASSANDRA-19001: - 1) Actually, I do not see now the security managers on startup, only on compile. But adding a suppression to the ThreadAwareSecurityManager should help with those _I think:_ {code:java} @SuppressWarnings("removal") public final class ThreadAwareSecurityManager extends SecurityManager{code} [~paulo] , do you mind to test whether this suppression solves completely the issue for you? I cannot reproduce this startup warning, only compilation. 2) SJK cannot run sjk hh if not run with JDK. Nothing to do there and it gives an error message that explains that. I do not like hacks to remove warnings when they have a real meaning so my suggestion is to add below comment in the options file. When people setup their Cassandra nodes they will decide what to do. {code:java} # You cannot run nodetool sjk hh without below option with JDK17. # It will generate a startup warning for missing module when using JRE and not JDK; sjk hh will not be available. # If you want to use JRE and not see the warning, you can comment below option. --add-exports jdk.attach/sun.tools.attach=ALL-UNNAMED{code} 3) I tried running our CI without using the options that generate the reported warnings. Our CI does not show any problems, except the sjk error mentioned: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19001-5.0] Though we know this doesn't mean there is no hidden problem. I just submitted an OpenHFT github issue question to verify what potential impact might be. Better to get advice from the source instead of guessing on my own. > Check whether the startup warnings for unknown modules represent a legit > problem or cosmetic issue > -- > > Key: CASSANDRA-19001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19001 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta > > > During the 5.0 alpha 2 release > [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr], > [~paulo] raised the following concerns: > {code:java} > Launched a tarball-based 5.0-alpha2 container on top of > "eclipse-temurin:17-jre-focal" and the server starts up fine, can run > nodetool and cqlsh. > I got these seemingly harmless JDK17 warnings during startup and when > running nodetool (no warnings on JDK11): > WARNING: Unknown module: jdk.attach specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-exports > WARNING: Unknown module: jdk.compiler specified to --add-opens > WARNING: A terminally deprecated method in java.lang.System has been called > WARNING: System::setSecurityManager has been called by > org.apache.cassandra.security.ThreadAwareSecurityManager > (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar) > WARNING: Please consider reporting this to the maintainers of > org.apache.cassandra.security.ThreadAwareSecurityManager > WARNING: System::setSecurityManager will be removed in a future release > Anybody knows if these warnings are legit/expected ? We can create > follow-up tickets if needed. > $ java --version > openjdk 17.0.9 2023-10-17 > OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9) > OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode, > sharing) > {code} > {code:java} > Clarification: - When running nodetool only the "Unknown module" warnings > show up. All warnings show up during startup.{code} > We need to verify whether this presents a real problem in the features where > those modules are expected to be used, or if it is a false alarm. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19003) Get Sidecar port through CassandraContext for more flexibility
[ https://issues.apache.org/jira/browse/CASSANDRA-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-19003: - Reviewers: Dinesh Joshi, Josh McKenzie > Get Sidecar port through CassandraContext for more flexibility > --- > > Key: CASSANDRA-19003 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19003 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > > We get sidecar port from `BulkSparkConf` but it will be better if we get it > from `CassandraContext` provides more flexibility -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] Get sidecar port through cassandra context [cassandra-analytics]
sarankk opened a new pull request, #18: URL: https://github.com/apache/cassandra-analytics/pull/18 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] JAVA-3129: Change Snappy version and corresponding manual page [cassandra-java-driver]
SiyaoIsHiding commented on code in PR #1736: URL: https://github.com/apache/cassandra-java-driver/pull/1736#discussion_r1384216062 ## manual/core/compression/README.md: ## @@ -74,7 +74,7 @@ Dependency: org.xerial.snappy snappy-java - 1.1.2.6 + 1.1.10.4 Review Comment: Henry found that. He's a genius . ## manual/core/compression/README.md: ## @@ -74,7 +74,7 @@ Dependency: org.xerial.snappy snappy-java - 1.1.2.6 + 1.1.10.4 Review Comment: Henry found that. He's a genius . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.7.x license check [cassandra-java-driver]
hhughes commented on PR #1786: URL: https://github.com/apache/cassandra-java-driver/pull/1786#issuecomment-1797069088 Nit: needs retitling to `CASSANDRA-16969 4.8.0_fixes license check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783408#comment-17783408 ] shylaja kokoori commented on CASSANDRA-18688: - Are there any other changes needed for this ticket? > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18874) Add Jepsen's Elle to Accord and Paxos validation
[ https://issues.apache.org/jira/browse/CASSANDRA-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18874: Reviewers: Caleb Rackliffe Status: Review In Progress (was: Patch Available) > Add Jepsen's Elle to Accord and Paxos validation > > > Key: CASSANDRA-18874 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18874 > Project: Cassandra > Issue Type: Improvement > Components: Accord, Feature/Lightweight Transactions >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 5.x > > > Paxos and Accord both use a custom validator to make sure we offer Strict > Serializability, but to increase confidence we should use external validators > as well, such as Jepson’s Elle. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18956) Metadata Loss caused by unchecked rename column when upgrading from 2.x to 3.0.29
[ https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783403#comment-17783403 ] Ke Han commented on CASSANDRA-18956: [~smiklosovic] Of course. Thanks for the help! :) > Metadata Loss caused by unchecked rename column when upgrading from 2.x to > 3.0.29 > - > > Key: CASSANDRA-18956 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18956 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Distributed Metadata >Reporter: Ke Han >Assignee: Ke Han >Priority: Normal > Fix For: 3.0.x > > Attachments: data.tar.gz, signature.asc, signature.asc, > signature.asc, signature.asc, signature.asc > > Time Spent: 2.5h > Remaining Estimate: 0h > > After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released > 2023-05-05), if user performs a rename operation to rename the primary key to > an existing column, it will succeed, and the original column will get lost > permanently. > h1. Reproduce > Start up single cassandra node 2.1.22 > Start up *cassandra-cli* > {code:java} > bin/cassandra-cli {code} > Execute the following commands using cassandra-cli interface > {code:java} > create keyspace test with strategy_options = {replication_factor:1} and > placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy'; > use test; > create column family foos > with column_type = 'Standard' > and comparator = 'BytesType' > and key_validation_class = 'UTF8Type' > and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}]; > {code} > Stop the daemon > {code:java} > bin/nodetool -h :::127.0.0.1 stopdaemon {code} > Upgrade, start up new version, start up cqlsh with *bin/cqlsh* > {code:java} > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > key text PRIMARY KEY, > "2f" text > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> ALTER TABLE test.foos RENAME key TO "2f"; > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > "2f" text PRIMARY KEY > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> SELECT * FROM test.foos ; > 2f > > (0 rows) {code} > h1. Root Cause > The root cause is a missing check for the existing column when the table > comparator from the old version is BytesType. > I have uploaded the data dir, use it to start up 3.0.29 and execute the > commands will reproduce this bug. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] JAVA-3051: Memory leak [cassandra-java-driver]
hhughes commented on code in PR #1743: URL: https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1380850607 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/LoadBalancingPolicyWrapper.java: ## @@ -31,13 +31,7 @@ import com.datastax.oss.driver.shaded.guava.common.collect.ImmutableSet; import edu.umd.cs.findbugs.annotations.NonNull; import edu.umd.cs.findbugs.annotations.Nullable; -import java.util.ArrayList; -import java.util.Collections; -import java.util.HashMap; -import java.util.List; -import java.util.Map; -import java.util.Queue; -import java.util.Set; +import java.util.*; Review Comment: please remove wildcard imports (this should result in a warning that fails the build) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18956) Metadata Loss caused by unchecked rename column when upgrading from 2.x to 3.0.29
[ https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783395#comment-17783395 ] Stefan Miklosovic commented on CASSANDRA-18956: --- CI seems good, I am +1. We need to have another committer for this (there is such a policy for this). We are very busy with delivering of 5.0 so this will be reviewed, realistically, after 5.0 is out. Please ping me after 5.0 is out so we take care of this. For the reference I was running this branch (1) with this CI (2) (1) https://github.com/instaclustr/cassandra/commits/CASSANDRA-18956-3.0 (2) https://app.circleci.com/pipelines/github/instaclustr/cassandra/3439/workflows/99f3f349-ae1d-4817-bc77-f4821ebc4089 > Metadata Loss caused by unchecked rename column when upgrading from 2.x to > 3.0.29 > - > > Key: CASSANDRA-18956 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18956 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Distributed Metadata >Reporter: Ke Han >Assignee: Ke Han >Priority: Normal > Fix For: 3.0.x > > Attachments: data.tar.gz, signature.asc, signature.asc, > signature.asc, signature.asc, signature.asc > > Time Spent: 2.5h > Remaining Estimate: 0h > > After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released > 2023-05-05), if user performs a rename operation to rename the primary key to > an existing column, it will succeed, and the original column will get lost > permanently. > h1. Reproduce > Start up single cassandra node 2.1.22 > Start up *cassandra-cli* > {code:java} > bin/cassandra-cli {code} > Execute the following commands using cassandra-cli interface > {code:java} > create keyspace test with strategy_options = {replication_factor:1} and > placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy'; > use test; > create column family foos > with column_type = 'Standard' > and comparator = 'BytesType' > and key_validation_class = 'UTF8Type' > and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}]; > {code} > Stop the daemon > {code:java} > bin/nodetool -h :::127.0.0.1 stopdaemon {code} > Upgrade, start up new version, start up cqlsh with *bin/cqlsh* > {code:java} > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > key text PRIMARY KEY, > "2f" text > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> ALTER TABLE test.foos RENAME key TO "2f"; > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > "2f" text PRIMARY KEY > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> SELECT * FROM test.foos ; > 2f > > (0 rows) {code} > h1. Root Cause > The root cause is a missing check for the existing column when the table > comparator from the old version is BytesType. > I have uploaded the data dir, use it to start up 3.0.29 and execute the > commands will reproduce this bug. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18956) Metadata Loss caused by unchecked rename column when upgrading from 2.x to 3.0.29
[ https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18956: -- Status: Review In Progress (was: Changes Suggested) > Metadata Loss caused by unchecked rename column when upgrading from 2.x to > 3.0.29 > - > > Key: CASSANDRA-18956 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18956 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Distributed Metadata >Reporter: Ke Han >Assignee: Ke Han >Priority: Normal > Fix For: 3.0.x > > Attachments: data.tar.gz, signature.asc, signature.asc, > signature.asc, signature.asc, signature.asc > > Time Spent: 2.5h > Remaining Estimate: 0h > > After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released > 2023-05-05), if user performs a rename operation to rename the primary key to > an existing column, it will succeed, and the original column will get lost > permanently. > h1. Reproduce > Start up single cassandra node 2.1.22 > Start up *cassandra-cli* > {code:java} > bin/cassandra-cli {code} > Execute the following commands using cassandra-cli interface > {code:java} > create keyspace test with strategy_options = {replication_factor:1} and > placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy'; > use test; > create column family foos > with column_type = 'Standard' > and comparator = 'BytesType' > and key_validation_class = 'UTF8Type' > and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}]; > {code} > Stop the daemon > {code:java} > bin/nodetool -h :::127.0.0.1 stopdaemon {code} > Upgrade, start up new version, start up cqlsh with *bin/cqlsh* > {code:java} > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > key text PRIMARY KEY, > "2f" text > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> ALTER TABLE test.foos RENAME key TO "2f"; > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > "2f" text PRIMARY KEY > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> SELECT * FROM test.foos ; > 2f > > (0 rows) {code} > h1. Root Cause > The root cause is a missing check for the existing column when the table > comparator from the old version is BytesType. > I have uploaded the data dir, use it to start up 3.0.29 and execute the > commands will reproduce this bug. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18956) Metadata Loss caused by unchecked rename column when upgrading from 2.x to 3.0.29
[ https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18956: -- Status: Needs Committer (was: Review In Progress) > Metadata Loss caused by unchecked rename column when upgrading from 2.x to > 3.0.29 > - > > Key: CASSANDRA-18956 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18956 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Distributed Metadata >Reporter: Ke Han >Assignee: Ke Han >Priority: Normal > Fix For: 3.0.x > > Attachments: data.tar.gz, signature.asc, signature.asc, > signature.asc, signature.asc, signature.asc > > Time Spent: 2.5h > Remaining Estimate: 0h > > After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released > 2023-05-05), if user performs a rename operation to rename the primary key to > an existing column, it will succeed, and the original column will get lost > permanently. > h1. Reproduce > Start up single cassandra node 2.1.22 > Start up *cassandra-cli* > {code:java} > bin/cassandra-cli {code} > Execute the following commands using cassandra-cli interface > {code:java} > create keyspace test with strategy_options = {replication_factor:1} and > placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy'; > use test; > create column family foos > with column_type = 'Standard' > and comparator = 'BytesType' > and key_validation_class = 'UTF8Type' > and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}]; > {code} > Stop the daemon > {code:java} > bin/nodetool -h :::127.0.0.1 stopdaemon {code} > Upgrade, start up new version, start up cqlsh with *bin/cqlsh* > {code:java} > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > key text PRIMARY KEY, > "2f" text > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> ALTER TABLE test.foos RENAME key TO "2f"; > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > "2f" text PRIMARY KEY > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> SELECT * FROM test.foos ; > 2f > > (0 rows) {code} > h1. Root Cause > The root cause is a missing check for the existing column when the table > comparator from the old version is BytesType. > I have uploaded the data dir, use it to start up 3.0.29 and execute the > commands will reproduce this bug. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19004) Refactor negotiatedProtocolMustBeAcceptedProtocolTest to more clearly specify supported/deprecated protocol versions
Ariel Weisberg created CASSANDRA-19004: -- Summary: Refactor negotiatedProtocolMustBeAcceptedProtocolTest to more clearly specify supported/deprecated protocol versions Key: CASSANDRA-19004 URL: https://issues.apache.org/jira/browse/CASSANDRA-19004 Project: Cassandra Issue Type: Improvement Reporter: Ariel Weisberg Right now it's a little inconsistent and there is some code duplication between client and internode versions of the test. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19003) Get Sidecar port through CassandraContext for more flexibility
[ https://issues.apache.org/jira/browse/CASSANDRA-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Saranya Krishnakumar updated CASSANDRA-19003: - Change Category: Code Clarity Complexity: Low Hanging Fruit Component/s: Analytics Library Status: Open (was: Triage Needed) > Get Sidecar port through CassandraContext for more flexibility > --- > > Key: CASSANDRA-19003 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19003 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > > We get sidecar port from `BulkSparkConf` but it will be better if we get it > from `CassandraContext` provides more flexibility -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19003) Get Sidecar port through CassandraContext for more flexibility
Saranya Krishnakumar created CASSANDRA-19003: Summary: Get Sidecar port through CassandraContext for more flexibility Key: CASSANDRA-19003 URL: https://issues.apache.org/jira/browse/CASSANDRA-19003 Project: Cassandra Issue Type: Task Reporter: Saranya Krishnakumar Assignee: Saranya Krishnakumar We get sidecar port from `BulkSparkConf` but it will be better if we get it from `CassandraContext` provides more flexibility -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18993) Harry-found silent data loss issue
[ https://issues.apache.org/jira/browse/CASSANDRA-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783368#comment-17783368 ] Alex Petrov commented on CASSANDRA-18993: - Current hypothesis is that both issues are the same. I will post more details as soon as I get a chance! > Harry-found silent data loss issue > -- > > Key: CASSANDRA-18993 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18993 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Alex Petrov >Priority: Normal > Fix For: 4.1.x, 5.0-beta, 5.x > > > Harry has discovered a silent data loss bug in trunk, but it goes all the way > back to appx 4.1. > Some rows are not visble after flush. Compared Harry repro running a memtable > instead of a regular Harry model, and it still reproduces (in other words, it > is almost certainly not a Harry issue). > Simple schema, and only one flush is required for repro, so not an unlikely > bug. Max partition size is 1k rows, so not an unlikely setup here, either. No > concurrency involved; reproduces stably. Good chance this is related to the > fact the schema has DESC clusterings. > I am working on posting a Harry branch that stably reproduces it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18993) Harry-found silent data loss issue
[ https://issues.apache.org/jira/browse/CASSANDRA-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783367#comment-17783367 ] Paulo Motta commented on CASSANDRA-18993: - Is this the same as CASSANDRA-18932 or something else? > Harry-found silent data loss issue > -- > > Key: CASSANDRA-18993 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18993 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Alex Petrov >Priority: Normal > Fix For: 4.1.x, 5.0-beta, 5.x > > > Harry has discovered a silent data loss bug in trunk, but it goes all the way > back to appx 4.1. > Some rows are not visble after flush. Compared Harry repro running a memtable > instead of a regular Harry model, and it still reproduces (in other words, it > is almost certainly not a Harry issue). > Simple schema, and only one flush is required for repro, so not an unlikely > bug. Max partition size is 1k rows, so not an unlikely setup here, either. No > concurrency involved; reproduces stably. Good chance this is related to the > fact the schema has DESC clusterings. > I am working on posting a Harry branch that stably reproduces it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] JAVA-3051: Memory leak [cassandra-java-driver]
SiyaoIsHiding commented on PR #1743: URL: https://github.com/apache/cassandra-java-driver/pull/1743#issuecomment-1796372202 We explored several alternatives for unit testing this memory leak fix but decided to give up testing it, as we could not find a reliable way to test the garbage collector's behavior. ### The unit test we wrote and considered: https://github.com/apache/cassandra-java-driver/blob/cb61eb8c34d1dd7417c03fec95d6e13e9185d537/core/src/test/java/com/datastax/oss/driver/internal/core/metadata/LoadBalancingPolicyWrapperMemoryLeakTest.java#L118-L142 This test: 1. creates two `DefaultNode` 2. creates two `WeakReference` pointing to the nodes, just to poke their existence later 3. initializes the policy 4. clear all the strong references 5. requests for garbage collection 6. verify the node is collected ### We checked that 1. In my local environment (Zulu 8.72.0.17-CA-macos-aarch64), this test will succeed, and if I revert the changes from `WeakHashMap` to the strong `HashMap`, this test will fail. 2. Before all the strong references are cleared, poking the memory, the referring objects to the `weakNode2` are: a. `weakNode2` and `weakReference2` b. `InterceptedInvocation`s by Mockito c. `HashMap` of `allNodes` stored in `when(metadata.getNodes()).thenReturn(allNodes);` d. wanted in `Equals` statement in ` await().atMost(10, TimeUnit.SECONDS).until(() -> weakReference2.get() == null);` These are all expected and no reference is leaked. 3. If `evaluateDistance` of nodes does not return `IGNORED`, they will be stored in `BasicLoadBalancingPolicy.liveNodes`. But nodes there can be removed later by `onDown` or `onRemoved`. We suppose this is intended. ### We considered that According to [this](https://stackoverflow.com/questions/11174328/testing-weakreference/36917692) post, `System.gc()` is more like a request/hint that some JVM will ignore, and there is no reliable way to force garbage collection. This means the test above may fail in other environments, but the last thing we want is a flaky test. We think workarounds like generating a huge amount of garbage to trigger garbage collection may not be worth it, either. Therefore, we concluded that no test may be the best choice for now, and the checks we perform above may be sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18932) Harry-found CorruptSSTableException / RT Closer issue when reading entire partition
[ https://issues.apache.org/jira/browse/CASSANDRA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18932: Fix Version/s: 5.0.x > Harry-found CorruptSSTableException / RT Closer issue when reading entire > partition > --- > > Key: CASSANDRA-18932 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18932 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Alex Petrov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Attachments: node1_.zip, operation.log.zip, screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > While testing some new machinery for Harry, I have encountered a new RT > closer / SSTable Corruption issue. I have grounds to believe this was > introduced during the last year. > Issue seems to happen because of intricate interleaving of flushes with > writes and deletes. > {code:java} > ERROR [ReadStage-2] 2023-10-16 18:47:06,696 JVMStabilityInspector.java:76 - > Exception in thread Thread[ReadStage-2,5,SharedPool] > org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted: > RandomAccessReader:BufferManagingRebufferer.Aligned:CompressedChunkReader.Mmap(/Users/ifesdjeen/foss/java/apache-cassandra-4.0/data/data1/harry/table_1-07c35a606c0a11eeae7a4f6ca489eb0c/nc-5-big-Data.db > - LZ4Compressor, chunk length 16384, data length 232569) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator$AbstractReader.hasNext(AbstractSSTableIterator.java:381) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator.hasNext(AbstractSSTableIterator.java:242) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:376) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:188) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:157) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:534) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:402) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:151) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:101) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:86) > at > org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Serializer.serialize(UnfilteredPartitionIterators.java:343) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadResponse.java:201) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.(ReadResponse.java:186) > at > org.apache.cassandra.db.ReadResponse.createDataResponse(ReadResponse.java:48) > at > org.apache.cassandra.db.ReadCommand.createResponse(ReadCommand.java:346) > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:2186) > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2581) > at > org.apache.cassandra.concurrent.ExecutionFailure$2.run(ExecutionFailure.java:163) > at
[jira] [Updated] (CASSANDRA-18932) Harry-found CorruptSSTableException / RT Closer issue when reading entire partition
[ https://issues.apache.org/jira/browse/CASSANDRA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18932: Fix Version/s: 5.0-beta > Harry-found CorruptSSTableException / RT Closer issue when reading entire > partition > --- > > Key: CASSANDRA-18932 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18932 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Alex Petrov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.x > > Attachments: node1_.zip, operation.log.zip, screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > While testing some new machinery for Harry, I have encountered a new RT > closer / SSTable Corruption issue. I have grounds to believe this was > introduced during the last year. > Issue seems to happen because of intricate interleaving of flushes with > writes and deletes. > {code:java} > ERROR [ReadStage-2] 2023-10-16 18:47:06,696 JVMStabilityInspector.java:76 - > Exception in thread Thread[ReadStage-2,5,SharedPool] > org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted: > RandomAccessReader:BufferManagingRebufferer.Aligned:CompressedChunkReader.Mmap(/Users/ifesdjeen/foss/java/apache-cassandra-4.0/data/data1/harry/table_1-07c35a606c0a11eeae7a4f6ca489eb0c/nc-5-big-Data.db > - LZ4Compressor, chunk length 16384, data length 232569) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator$AbstractReader.hasNext(AbstractSSTableIterator.java:381) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator.hasNext(AbstractSSTableIterator.java:242) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:376) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:188) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:157) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:534) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:402) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:151) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:101) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:86) > at > org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Serializer.serialize(UnfilteredPartitionIterators.java:343) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadResponse.java:201) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.(ReadResponse.java:186) > at > org.apache.cassandra.db.ReadResponse.createDataResponse(ReadResponse.java:48) > at > org.apache.cassandra.db.ReadCommand.createResponse(ReadCommand.java:346) > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:2186) > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2581) > at > org.apache.cassandra.concurrent.ExecutionFailure$2.run(ExecutionFailure.java:163) > at
[jira] [Commented] (CASSANDRA-18932) Harry-found CorruptSSTableException / RT Closer issue when reading entire partition
[ https://issues.apache.org/jira/browse/CASSANDRA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783350#comment-17783350 ] Maxim Muzafarov commented on CASSANDRA-18932: - The same reproducer doesn't reproduce the exception for the 4.1 and 4.0 branches, so the problem may be slightly different for CASSANDRA-18915 > Harry-found CorruptSSTableException / RT Closer issue when reading entire > partition > --- > > Key: CASSANDRA-18932 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18932 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Alex Petrov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Attachments: node1_.zip, operation.log.zip, screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > While testing some new machinery for Harry, I have encountered a new RT > closer / SSTable Corruption issue. I have grounds to believe this was > introduced during the last year. > Issue seems to happen because of intricate interleaving of flushes with > writes and deletes. > {code:java} > ERROR [ReadStage-2] 2023-10-16 18:47:06,696 JVMStabilityInspector.java:76 - > Exception in thread Thread[ReadStage-2,5,SharedPool] > org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted: > RandomAccessReader:BufferManagingRebufferer.Aligned:CompressedChunkReader.Mmap(/Users/ifesdjeen/foss/java/apache-cassandra-4.0/data/data1/harry/table_1-07c35a606c0a11eeae7a4f6ca489eb0c/nc-5-big-Data.db > - LZ4Compressor, chunk length 16384, data length 232569) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator$AbstractReader.hasNext(AbstractSSTableIterator.java:381) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator.hasNext(AbstractSSTableIterator.java:242) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:376) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:188) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:157) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:534) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:402) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:151) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:101) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:86) > at > org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Serializer.serialize(UnfilteredPartitionIterators.java:343) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadResponse.java:201) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.(ReadResponse.java:186) > at > org.apache.cassandra.db.ReadResponse.createDataResponse(ReadResponse.java:48) > at > org.apache.cassandra.db.ReadCommand.createResponse(ReadCommand.java:346) > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:2186) > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2581) > at >
[jira] [Commented] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783341#comment-17783341 ] Caleb Rackliffe commented on CASSANDRA-18994: - {quote} It is little bit disappointing we still need ALLOW FILTERING on that. e.g. {quote} I'm guessing the intent here is to indicate that we might be doing post-filtering on the actual index result over a potentially still very large amount of data. On the other hand, it's not the same as scanning the backing table itself, so requiring AF does feel a bit odd. (i.e. Even though the index isn't actually supporting the OR/IN query, it's not actually causing us to read any more row data from disk than the primary index query already has.) > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.index.sai.plan.Expression.add(Expression.java:171) > at > org.apache.cassandra.index.sai.plan.Operation.buildIndexExpressions(Operation.java:136) > at > org.apache.cassandra.index.sai.plan.Operation$AndNode.analyze(Operation.java:303) > at > org.apache.cassandra.index.sai.plan.Operation$Node.doTreeAnalysis(Operation.java:266) >
[jira] [Commented] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783338#comment-17783338 ] Caleb Rackliffe commented on CASSANDRA-18994: - [~smiklosovic] Had a quick chat w/ [~mike_tr_adamson], and we're going to take care of CASSANDRA-18166 first. If it fixes this issue, we'll avoid an unnecessary commit... > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.index.sai.plan.Expression.add(Expression.java:171) > at > org.apache.cassandra.index.sai.plan.Operation.buildIndexExpressions(Operation.java:136) > at > org.apache.cassandra.index.sai.plan.Operation$AndNode.analyze(Operation.java:303) > at > org.apache.cassandra.index.sai.plan.Operation$Node.doTreeAnalysis(Operation.java:266) > at > org.apache.cassandra.index.sai.plan.Operation$Node.analyzeTree(Operation.java:251) > at > org.apache.cassandra.index.sai.plan.Operation.buildIterator(Operation.java:185) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher$ResultRetriever.(StorageAttachedIndexSearcher.java:151) > at >
[jira] [Commented] (CASSANDRA-18932) Harry-found CorruptSSTableException / RT Closer issue when reading entire partition
[ https://issues.apache.org/jira/browse/CASSANDRA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783337#comment-17783337 ] Maxim Muzafarov commented on CASSANDRA-18932: - The commit mentioned above is for CASSANDRA-17056 and the issue is only related to 5.0 as it has this fix version, however, the same exception stack trace we've got for 4.0.4 for production environement that is mentioned here: CASSANDRA-18915 > Harry-found CorruptSSTableException / RT Closer issue when reading entire > partition > --- > > Key: CASSANDRA-18932 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18932 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Alex Petrov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Attachments: node1_.zip, operation.log.zip, screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > While testing some new machinery for Harry, I have encountered a new RT > closer / SSTable Corruption issue. I have grounds to believe this was > introduced during the last year. > Issue seems to happen because of intricate interleaving of flushes with > writes and deletes. > {code:java} > ERROR [ReadStage-2] 2023-10-16 18:47:06,696 JVMStabilityInspector.java:76 - > Exception in thread Thread[ReadStage-2,5,SharedPool] > org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted: > RandomAccessReader:BufferManagingRebufferer.Aligned:CompressedChunkReader.Mmap(/Users/ifesdjeen/foss/java/apache-cassandra-4.0/data/data1/harry/table_1-07c35a606c0a11eeae7a4f6ca489eb0c/nc-5-big-Data.db > - LZ4Compressor, chunk length 16384, data length 232569) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator$AbstractReader.hasNext(AbstractSSTableIterator.java:381) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator.hasNext(AbstractSSTableIterator.java:242) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:376) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:188) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:157) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:534) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:402) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:151) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:101) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:86) > at > org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Serializer.serialize(UnfilteredPartitionIterators.java:343) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadResponse.java:201) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.(ReadResponse.java:186) > at > org.apache.cassandra.db.ReadResponse.createDataResponse(ReadResponse.java:48) > at > org.apache.cassandra.db.ReadCommand.createResponse(ReadCommand.java:346) > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:2186) > at >
(cassandra) branch trunk updated (537ab03f58 -> 10d031bda4)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 537ab03f58 Merge branch 'cassandra-5.0' into trunk new 009d1ca9ee Increment version to 5.0-beta1 new 10d031bda4 Merge branch 'cassandra-5.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-5.0 updated: Increment version to 5.0-beta1
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-5.0 by this push: new 009d1ca9ee Increment version to 5.0-beta1 009d1ca9ee is described below commit 009d1ca9ee94fd5e4c641cb36b35d7e09c112913 Author: Mick Semb Wever AuthorDate: Mon Nov 6 19:43:46 2023 +0100 Increment version to 5.0-beta1 ref: https://lists.apache.org/thread/ndycyjg4zh7zt31gm7w823v0gj506m63 --- CHANGES.txt | 2 +- build.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index a94b3ba7e4..c9ec2e1ea0 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,4 @@ -5.0-alpha3 +5.0-beta1 * Upgrade Python driver to 3.28.0 (CASSANDRA-18960) * Add retries to IR messages (CASSANDRA-18962) * Add metrics and logging to repair retries (CASSANDRA-18952) diff --git a/build.xml b/build.xml index 7bc0f79a74..e45f9a4efd 100644 --- a/build.xml +++ b/build.xml @@ -32,7 +32,7 @@ - + https://gitbox.apache.org/repos/asf/cassandra.git"/> https://gitbox.apache.org/repos/asf/cassandra.git"/> https://gitbox.apache.org/repos/asf?p=cassandra.git;a=tree"/> - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 10d031bda4352249faf524246bd5c4f42a13f620 Merge: 537ab03f58 009d1ca9ee Author: Mick Semb Wever AuthorDate: Mon Nov 6 19:49:07 2023 +0100 Merge branch 'cassandra-5.0' into trunk * cassandra-5.0: Increment version to 5.0-beta1 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18932) Harry-found CorruptSSTableException / RT Closer issue when reading entire partition
[ https://issues.apache.org/jira/browse/CASSANDRA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783334#comment-17783334 ] Maxim Muzafarov edited comment on CASSANDRA-18932 at 11/6/23 6:50 PM: -- I seem to have boiled the reproducer down to 100 lines. [~jlewandowski] explained to me the cause of the problem since it was related to his patch, so I'll try to take a look at it and figure out how to fix it, but it might take a while since I'm not familiar with that part of the code at all. If this is urgent and you want to fix it anyway I think my investigation might hopefully be useful in the issue review phase :-) was (Author: mmuzaf): I seem to have boiled the reproducer down to 100 lines. [~jlewandowski] explained to me the cause of the problem since it was related to his patch, so I'll try to take a look at it and figure out how to fix it, but it might take a while since I'm not familiar with that part of the code at all. If this is urgent and you want to fix it anyway I think my investigation might hopefully be helpful in the issue review phase :-) > Harry-found CorruptSSTableException / RT Closer issue when reading entire > partition > --- > > Key: CASSANDRA-18932 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18932 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Alex Petrov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Attachments: node1_.zip, operation.log.zip, screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > While testing some new machinery for Harry, I have encountered a new RT > closer / SSTable Corruption issue. I have grounds to believe this was > introduced during the last year. > Issue seems to happen because of intricate interleaving of flushes with > writes and deletes. > {code:java} > ERROR [ReadStage-2] 2023-10-16 18:47:06,696 JVMStabilityInspector.java:76 - > Exception in thread Thread[ReadStage-2,5,SharedPool] > org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted: > RandomAccessReader:BufferManagingRebufferer.Aligned:CompressedChunkReader.Mmap(/Users/ifesdjeen/foss/java/apache-cassandra-4.0/data/data1/harry/table_1-07c35a606c0a11eeae7a4f6ca489eb0c/nc-5-big-Data.db > - LZ4Compressor, chunk length 16384, data length 232569) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator$AbstractReader.hasNext(AbstractSSTableIterator.java:381) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator.hasNext(AbstractSSTableIterator.java:242) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:376) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:188) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:157) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:534) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:402) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:151) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:101) > at >
[jira] [Commented] (CASSANDRA-18932) Harry-found CorruptSSTableException / RT Closer issue when reading entire partition
[ https://issues.apache.org/jira/browse/CASSANDRA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783334#comment-17783334 ] Maxim Muzafarov commented on CASSANDRA-18932: - I seem to have boiled the reproducer down to 100 lines. [~jlewandowski] explained to me the cause of the problem since it was related to his patch, so I'll try to take a look at it and figure out how to fix it, but it might take a while since I'm not familiar with that part of the code at all. If this is urgent and you want to fix it anyway I think my investigation might hopefully be helpful in the issue review phase :-) > Harry-found CorruptSSTableException / RT Closer issue when reading entire > partition > --- > > Key: CASSANDRA-18932 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18932 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Alex Petrov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Attachments: node1_.zip, operation.log.zip, screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > While testing some new machinery for Harry, I have encountered a new RT > closer / SSTable Corruption issue. I have grounds to believe this was > introduced during the last year. > Issue seems to happen because of intricate interleaving of flushes with > writes and deletes. > {code:java} > ERROR [ReadStage-2] 2023-10-16 18:47:06,696 JVMStabilityInspector.java:76 - > Exception in thread Thread[ReadStage-2,5,SharedPool] > org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted: > RandomAccessReader:BufferManagingRebufferer.Aligned:CompressedChunkReader.Mmap(/Users/ifesdjeen/foss/java/apache-cassandra-4.0/data/data1/harry/table_1-07c35a606c0a11eeae7a4f6ca489eb0c/nc-5-big-Data.db > - LZ4Compressor, chunk length 16384, data length 232569) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator$AbstractReader.hasNext(AbstractSSTableIterator.java:381) > at > org.apache.cassandra.io.sstable.AbstractSSTableIterator.hasNext(AbstractSSTableIterator.java:242) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:376) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:188) > at > org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:157) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:534) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:402) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:151) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:101) > at > org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:86) > at > org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Serializer.serialize(UnfilteredPartitionIterators.java:343) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadResponse.java:201) > at > org.apache.cassandra.db.ReadResponse$LocalDataResponse.(ReadResponse.java:186) > at > org.apache.cassandra.db.ReadResponse.createDataResponse(ReadResponse.java:48) > at >
[jira] [Comment Edited] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783330#comment-17783330 ] Stefan Miklosovic edited comment on CASSANDRA-18994 at 11/6/23 6:44 PM: I am OK with that. +1. Waiting for [~maedhroz] to review too. Caleb, would you mind to eventually merge this as well? Thanks EDIT: I added one nit to the test case. It is little bit disappointing we still need ALLOW FILTERING on that. e.g. {code} SELECT pk FROM %s WHERE val1 = 1 AND val2 in ('11', '22') ALLOW FILTERING {code} I am not sure how this works internally but this is basically as following, no? {code} SELECT pk FROM %s WHERE val1 = 1 AND val2 = '11' SELECT pk FROM %s WHERE val1 = 1 AND val2 = '22' {code} was (Author: smiklosovic): I am OK with that. +1. Waiting for [~maedhroz] to review too. Caleb, would you mind to eventually merge this as well? Thanks > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.index.sai.plan.Expression.add(Expression.java:171) > at > org.apache.cassandra.index.sai.plan.Operation.buildIndexExpressions(Operation.java:136) > at >
[jira] [Updated] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18994: -- Reviewers: Caleb Rackliffe, Stefan Miklosovic (was: Caleb Rackliffe) > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.index.sai.plan.Expression.add(Expression.java:171) > at > org.apache.cassandra.index.sai.plan.Operation.buildIndexExpressions(Operation.java:136) > at > org.apache.cassandra.index.sai.plan.Operation$AndNode.analyze(Operation.java:303) > at > org.apache.cassandra.index.sai.plan.Operation$Node.doTreeAnalysis(Operation.java:266) > at > org.apache.cassandra.index.sai.plan.Operation$Node.analyzeTree(Operation.java:251) > at > org.apache.cassandra.index.sai.plan.Operation.buildIterator(Operation.java:185) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher$ResultRetriever.(StorageAttachedIndexSearcher.java:151) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher.search(StorageAttachedIndexSearcher.java:107) > at >
[jira] [Commented] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783330#comment-17783330 ] Stefan Miklosovic commented on CASSANDRA-18994: --- I am OK with that. +1. Waiting for [~maedhroz] to review too. Caleb, would you mind to eventually merge this as well? Thanks > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.index.sai.plan.Expression.add(Expression.java:171) > at > org.apache.cassandra.index.sai.plan.Operation.buildIndexExpressions(Operation.java:136) > at > org.apache.cassandra.index.sai.plan.Operation$AndNode.analyze(Operation.java:303) > at > org.apache.cassandra.index.sai.plan.Operation$Node.doTreeAnalysis(Operation.java:266) > at > org.apache.cassandra.index.sai.plan.Operation$Node.analyzeTree(Operation.java:251) > at > org.apache.cassandra.index.sai.plan.Operation.buildIterator(Operation.java:185) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher$ResultRetriever.(StorageAttachedIndexSearcher.java:151) > at >
[jira] [Updated] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18994: -- Status: Needs Committer (was: Review In Progress) > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.index.sai.plan.Expression.add(Expression.java:171) > at > org.apache.cassandra.index.sai.plan.Operation.buildIndexExpressions(Operation.java:136) > at > org.apache.cassandra.index.sai.plan.Operation$AndNode.analyze(Operation.java:303) > at > org.apache.cassandra.index.sai.plan.Operation$Node.doTreeAnalysis(Operation.java:266) > at > org.apache.cassandra.index.sai.plan.Operation$Node.analyzeTree(Operation.java:251) > at > org.apache.cassandra.index.sai.plan.Operation.buildIterator(Operation.java:185) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher$ResultRetriever.(StorageAttachedIndexSearcher.java:151) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher.search(StorageAttachedIndexSearcher.java:107) > at > org.apache.cassandra.db.ReadCommand.executeLocally(ReadCommand.java:431)
[jira] [Updated] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18994: -- Reviewers: Caleb Rackliffe, Stefan Miklosovic, Stefan Miklosovic (was: Caleb Rackliffe, Stefan Miklosovic) Caleb Rackliffe, Stefan Miklosovic, Stefan Miklosovic (was: Caleb Rackliffe, Stefan Miklosovic) Status: Review In Progress (was: Patch Available) > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.index.sai.plan.Expression.add(Expression.java:171) > at > org.apache.cassandra.index.sai.plan.Operation.buildIndexExpressions(Operation.java:136) > at > org.apache.cassandra.index.sai.plan.Operation$AndNode.analyze(Operation.java:303) > at > org.apache.cassandra.index.sai.plan.Operation$Node.doTreeAnalysis(Operation.java:266) > at > org.apache.cassandra.index.sai.plan.Operation$Node.analyzeTree(Operation.java:251) > at > org.apache.cassandra.index.sai.plan.Operation.buildIterator(Operation.java:185) > at >
[jira] [Updated] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Adamson updated CASSANDRA-18994: - Test and Documentation Plan: CI runs for this fix are in the comment section Status: Patch Available (was: Open) > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.index.sai.plan.Expression.add(Expression.java:171) > at > org.apache.cassandra.index.sai.plan.Operation.buildIndexExpressions(Operation.java:136) > at > org.apache.cassandra.index.sai.plan.Operation$AndNode.analyze(Operation.java:303) > at > org.apache.cassandra.index.sai.plan.Operation$Node.doTreeAnalysis(Operation.java:266) > at > org.apache.cassandra.index.sai.plan.Operation$Node.analyzeTree(Operation.java:251) > at > org.apache.cassandra.index.sai.plan.Operation.buildIterator(Operation.java:185) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher$ResultRetriever.(StorageAttachedIndexSearcher.java:151) > at > org.apache.cassandra.index.sai.plan.StorageAttachedIndexSearcher.search(StorageAttachedIndexSearcher.java:107) >
[jira] [Updated] (CASSANDRA-18956) Metadata Loss caused by unchecked rename column when upgrading from 2.x to 3.0.29
[ https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] miklosovic updated CASSANDRA-18956: --- Attachment: signature.asc hat is fine, I run CI with "Ignored" annotation on top of that abstract class. It has to be like that. Sent from ProtonMail mobile \ > Metadata Loss caused by unchecked rename column when upgrading from 2.x to > 3.0.29 > - > > Key: CASSANDRA-18956 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18956 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Distributed Metadata >Reporter: Ke Han >Assignee: Ke Han >Priority: Normal > Fix For: 3.0.x > > Attachments: data.tar.gz, signature.asc, signature.asc, > signature.asc, signature.asc, signature.asc > > Time Spent: 2.5h > Remaining Estimate: 0h > > After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released > 2023-05-05), if user performs a rename operation to rename the primary key to > an existing column, it will succeed, and the original column will get lost > permanently. > h1. Reproduce > Start up single cassandra node 2.1.22 > Start up *cassandra-cli* > {code:java} > bin/cassandra-cli {code} > Execute the following commands using cassandra-cli interface > {code:java} > create keyspace test with strategy_options = {replication_factor:1} and > placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy'; > use test; > create column family foos > with column_type = 'Standard' > and comparator = 'BytesType' > and key_validation_class = 'UTF8Type' > and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}]; > {code} > Stop the daemon > {code:java} > bin/nodetool -h :::127.0.0.1 stopdaemon {code} > Upgrade, start up new version, start up cqlsh with *bin/cqlsh* > {code:java} > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > key text PRIMARY KEY, > "2f" text > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> ALTER TABLE test.foos RENAME key TO "2f"; > cqlsh> desc test.foos ; > CREATE TABLE test.foos ( > "2f" text PRIMARY KEY > ) WITH COMPACT STORAGE > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '64', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND crc_check_chance = 1.0 > AND dclocal_read_repair_chance = 0.1 > AND default_time_to_live = 0 > AND gc_grace_seconds = 864000 > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair_chance = 0.0 > AND speculative_retry = 'NONE'; > cqlsh> SELECT * FROM test.foos ; > 2f > > (0 rows) {code} > h1. Root Cause > The root cause is a missing check for the existing column when the table > comparator from the old version is BytesType. > I have uploaded the data dir, use it to start up 3.0.29 and execute the > commands will reproduce this bug. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18994) SAI range query does not play together with "IN"
[ https://issues.apache.org/jira/browse/CASSANDRA-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783323#comment-17783323 ] Mike Adamson commented on CASSANDRA-18994: -- Here are patches for 5.0 and trunk, along with CI runs: |[5.0|https://github.com/apache/cassandra/pull/2864]|[CI|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/364]| |[trunk|https://github.com/apache/cassandra/pull/2865]|[CI|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/365]| The error was happening because the IN operator is not caught by any restrictions and is allowed on indexed or non-indexed columns. SAI, currently, does not support IN so it was hitting the assert at a point where we were expecting a valid operator. Unfortunately, we have a situation, that will hopefully be fixed by CASSANDRA-18166, where this code path can be used in a situation where we don't have an index for the column that supports the operator. The fix has been to change the assert to include whether the index context being used represents an indexed column. If it doesn't, then we can legitimately continue and ignore the operator. > SAI range query does not play together with "IN" > > > Key: CASSANDRA-18994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18994 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Stefan Miklosovic >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta > > > I am using schema from the website's quickstart. > {code} > cqlsh> DESCRIBE KEYSPACE cycling ; > CREATE KEYSPACE cycling WITH replication = {'class': 'SimpleStrategy', > 'replication_factor': '1'} AND durable_writes = true; > CREATE TABLE cycling.cyclist_semi_pro ( > id int PRIMARY KEY, > affiliation text, > age int, > country text, > firstname text, > lastname text, > registration date > ) WITH additional_write_policy = '99p' > AND allow_auto_snapshot = true > AND bloom_filter_fp_chance = 0.01 > AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'} > AND cdc = false > AND comment = '' > AND compaction = {'class': > 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', > 'max_threshold': '32', 'min_threshold': '4'} > AND compression = {'chunk_length_in_kb': '16', 'class': > 'org.apache.cassandra.io.compress.LZ4Compressor'} > AND memtable = 'default' > AND crc_check_chance = 1.0 > AND default_time_to_live = 0 > AND extensions = {} > AND gc_grace_seconds = 864000 > AND incremental_backups = true > AND max_index_interval = 2048 > AND memtable_flush_period_in_ms = 0 > AND min_index_interval = 128 > AND read_repair = 'BLOCKING' > AND speculative_retry = '99p'; > CREATE CUSTOM INDEX age_sai_idx ON cycling.cyclist_semi_pro (age) USING > 'StorageAttachedIndex'; > CREATE CUSTOM INDEX country_sai_idx ON cycling.cyclist_semi_pro (country) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX lastname_sai_idx ON cycling.cyclist_semi_pro (lastname) > USING 'StorageAttachedIndex' WITH OPTIONS = {'ascii': 'true', > 'case_sensitive': 'false', 'normalize': 'true'}; > CREATE CUSTOM INDEX registration_sai_idx ON cycling.cyclist_semi_pro > (registration) USING 'StorageAttachedIndex'; > {code} > Then I do: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd'); > InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot > execute this query as it might involve data filtering and thus may have > unpredictable performance. If you want to execute this query despite the > performance unpredictability, use ALLOW FILTERING" > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE lastname in ('Cantona', > 'Boyd') ALLOW FILTERING; > id | affiliation | age | country | firstname | lastname | registration > +-+-+-+---+--+-- > 5 | Como Velocità | 24 | ITA | Irene | Cantona | 2012-07-22 > 20 | London Cyclists | 18 | GBR |Leslie | Boyd | 2012-12-15 > {code} > But check this: > {code} > cqlsh> SELECT * FROM cycling.cyclist_semi_pro WHERE registration > > '2010-01-01' AND registration < '2015-12-31' and lastname in ('Cantona', > 'Boyd') allow filtering; > ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] > message="Operation failed - received 0 responses and 1 failures: UNKNOWN from > localhost/127.0.0.1:7000" info={'consistency': 'ONE', 'required_responses': > 1, 'received_responses': 0, 'failures': 1, 'error_code_map': {'127.0.0.1': > '0x'}} > {code} > and in the logs: > {code} >
[jira] [Commented] (CASSANDRA-18940) SAI post-filtering reads don't update local table latency metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-18940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783311#comment-17783311 ] Caleb Rackliffe commented on CASSANDRA-18940: - [~rustyrazorblade] originally pointed out the issue. What would you want as an operator? A single metric that includes all local reads from all sources, or splitting out the local reads that come from SAI? > SAI post-filtering reads don't update local table latency metrics > - > > Key: CASSANDRA-18940 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18940 > Project: Cassandra > Issue Type: Bug > Components: Feature/2i Index, Feature/SAI, Observability/Metrics >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0-beta, 5.x > > Attachments: > draft_fix_for_SAI_post-filtering_reads_not_updating_local_table_metrics.patch > > > Once an SAI index finds matches (primary keys), it reads the associated rows > and post-filters them to incorporate partial writes, tombstones, etc. > However, those reads are not currently updating the local table latency > metrics. It should be simple enough to attach a metrics recording > transformation to the iterator produced by querying local storage. (I've > attached a patch that should apply cleanly to trunk, but there may be a > better way...) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783299#comment-17783299 ] Michael Semb Wever edited comment on CASSANDRA-18969 at 11/6/23 5:33 PM: - Committed (making spotbugs-annotation and jcip-annotations as provided dependencies, with tests to ensure they are not needed at runtime): * https://github.com/apache/cassandra-java-driver/pull/1741 * https://github.com/apache/cassandra-java-driver/pull/1744 * https://github.com/apache/cassandra-java-driver/pull/1745 * https://github.com/apache/cassandra-java-driver/pull/1746 * https://github.com/apache/cassandra-java-driver/pull/1747 * https://github.com/apache/cassandra-java-driver/pull/1748 * https://github.com/apache/cassandra-java-driver/pull/1749 * https://github.com/apache/cassandra-java-driver/pull/1750 * https://github.com/apache/cassandra-java-driver/pull/1751 * https://github.com/apache/cassandra-java-driver/pull/1752 * https://github.com/apache/cassandra-java-driver/pull/1753 * https://github.com/apache/cassandra-java-driver/pull/1754 * https://github.com/apache/cassandra-java-driver/pull/1755 * https://github.com/apache/cassandra-java-driver/pull/1756 was (Author: michaelsembwever): Committed * https://github.com/apache/cassandra-java-driver/pull/1741 * https://github.com/apache/cassandra-java-driver/pull/1744 * https://github.com/apache/cassandra-java-driver/pull/1745 * https://github.com/apache/cassandra-java-driver/pull/1746 * https://github.com/apache/cassandra-java-driver/pull/1747 * https://github.com/apache/cassandra-java-driver/pull/1748 * https://github.com/apache/cassandra-java-driver/pull/1749 * https://github.com/apache/cassandra-java-driver/pull/1750 * https://github.com/apache/cassandra-java-driver/pull/1751 * https://github.com/apache/cassandra-java-driver/pull/1752 * https://github.com/apache/cassandra-java-driver/pull/1753 * https://github.com/apache/cassandra-java-driver/pull/1754 * https://github.com/apache/cassandra-java-driver/pull/1755 * https://github.com/apache/cassandra-java-driver/pull/1756 > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 5.5h > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * -spotbugs is LGPL, in 4.x, and not correctly made provided scope- > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783299#comment-17783299 ] Michael Semb Wever commented on CASSANDRA-18969: Committed * https://github.com/apache/cassandra-java-driver/pull/1741 * https://github.com/apache/cassandra-java-driver/pull/1744 * https://github.com/apache/cassandra-java-driver/pull/1745 * https://github.com/apache/cassandra-java-driver/pull/1746 * https://github.com/apache/cassandra-java-driver/pull/1747 * https://github.com/apache/cassandra-java-driver/pull/1748 * https://github.com/apache/cassandra-java-driver/pull/1749 * https://github.com/apache/cassandra-java-driver/pull/1750 * https://github.com/apache/cassandra-java-driver/pull/1751 * https://github.com/apache/cassandra-java-driver/pull/1752 * https://github.com/apache/cassandra-java-driver/pull/1753 * https://github.com/apache/cassandra-java-driver/pull/1754 * https://github.com/apache/cassandra-java-driver/pull/1755 * https://github.com/apache/cassandra-java-driver/pull/1756 > Pre-release required legal changes for cassandra-java-driver > > > Key: CASSANDRA-18969 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18969 > Project: Cassandra > Issue Type: Sub-task > Components: Build >Reporter: Michael Semb Wever >Priority: Urgent > Time Spent: 5.5h > Remaining Estimate: 0h > > TODO > * there is still code copyrighted to others that isn't mentioned in > NOTICE.txt (e.g. ci/install-jdk.sh ) > * "© DataStax" still appears in the README > * -spotbugs is LGPL, in 4.x, and not correctly made provided scope- > * add any BSD/MIT deps to LICENCE > * ensure copyright headers are on all files, use rat plugin > These things must be done before a release. > Cat X deps we included as build tool by using scope provided we should put a > test in to ensure they work at runtime without the dep doesn't regress in the > future. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-java-driver) branch 4.12.x updated: Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.12.x branch]
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch 4.12.x in repository https://gitbox.apache.org/repos/asf/cassandra-java-driver.git The following commit(s) were added to refs/heads/4.12.x by this push: new d71dd429c Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.12.x branch] d71dd429c is described below commit d71dd429c37572e380bcc041ff3b7a2f1d09c240 Author: Henry Hughes AuthorDate: Wed Nov 1 12:50:18 2023 -0700 Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.12.x branch] patch by Henry Hughes; reviewed by Mick Semb Wever for CASSANDRA-18969 --- core-shaded/pom.xml| 2 + core/pom.xml | 2 + {metrics/micrometer => distribution-tests}/pom.xml | 94 ++ .../oss/driver/api/core/DriverDependencyTest.java | 84 +++ .../driver/api/core/OptionalDependencyTest.java| 47 +++ .../driver/api/core/ProvidedDependencyTest.java| 45 +++ examples/pom.xml | 5 ++ integration-tests/pom.xml | 5 ++ manual/core/integration/README.md | 31 --- mapper-processor/pom.xml | 2 + mapper-runtime/pom.xml | 2 + metrics/micrometer/pom.xml | 10 +++ metrics/microprofile/pom.xml | 10 +++ osgi-tests/pom.xml | 6 ++ pom.xml| 1 + query-builder/pom.xml | 2 + test-infra/pom.xml | 2 +- 17 files changed, 281 insertions(+), 69 deletions(-) diff --git a/core-shaded/pom.xml b/core-shaded/pom.xml index f76cc01e5..bbd8900ae 100644 --- a/core-shaded/pom.xml +++ b/core-shaded/pom.xml @@ -107,10 +107,12 @@ com.github.stephenc.jcip jcip-annotations + provided com.github.spotbugs spotbugs-annotations + provided - -javadoc-jar -package - - jar - - - javadoc - -** - - - - +org.apache.maven.plugins +maven-surefire-plugin + + 1 + org.revapi revapi-maven-plugin - true + +maven-install-plugin + + true + + + +maven-deploy-plugin + + true + + + +org.sonatype.plugins +nexus-staging-maven-plugin + + true + + diff --git a/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java b/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java new file mode 100644 index 0..16952e3d7 --- /dev/null +++ b/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.datastax.oss.driver.api.core; + +import static org.assertj.core.api.Assertions.assertThat; + +import com.datastax.oss.driver.api.core.session.Session; +import com.datastax.oss.driver.api.mapper.MapperBuilder; +import com.datastax.oss.driver.api.querybuilder.QueryBuilder; +import com.datastax.oss.driver.api.testinfra.CassandraResourceRule; +import com.datastax.oss.driver.internal.core.util.Reflection; +import com.datastax.oss.driver.internal.mapper.processor.MapperProcessor; +import com.datastax.oss.driver.internal.metrics.micrometer.MicrometerMetricsFactory; +import com.datastax.oss.driver.internal.metrics.microprofile.MicroProfileMetricsFactory; +import org.junit.Test; + +public class DriverDependencyTest { + @Test + public void should_include_core_jar() { +assertThat(Reflection.loadClass(null, "com.datastax.oss.driver.api.core.session.Session")) +
Re: [PR] CASSANDRA-18969: Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.12.x branch] [cassandra-java-driver]
michaelsembwever merged PR #1756: URL: https://github.com/apache/cassandra-java-driver/pull/1756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-website) branch asf-staging updated (4fad66cab -> fb2f2a15c)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 4fad66cab generate docs for 3d6c1852 add a69b82d6b Update cassandra-summit-banner-1000x250.png with latest image details new fb2f2a15c generate docs for a69b82d6 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (4fad66cab) \ N -- N -- N refs/heads/asf-staging (fb2f2a15c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../events/cassandra-summit-banner-1000x250.png| Bin 65651 -> 246826 bytes .../tools/nodetool/invalidatepermissionscache.html | 3 +-- .../tools/nodetool/invalidatepermissionscache.html | 3 +-- .../events/cassandra-summit-banner-1000x250.png| Bin 65651 -> 246826 bytes site-ui/build/ui-bundle.zip| Bin 4881412 -> 4881412 bytes 5 files changed, 2 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-java-driver) branch 4.11.x updated: Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.11.x branch]
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch 4.11.x in repository https://gitbox.apache.org/repos/asf/cassandra-java-driver.git The following commit(s) were added to refs/heads/4.11.x by this push: new 52e61f5bd Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.11.x branch] 52e61f5bd is described below commit 52e61f5bdfae02044ee490b0ab636687b454d008 Author: Henry Hughes AuthorDate: Wed Nov 1 12:50:18 2023 -0700 Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.11.x branch] patch by Henry Hughes; reviewed by Mick Semb Wever for CASSANDRA-18969 --- core-shaded/pom.xml| 2 + core/pom.xml | 2 + {metrics/micrometer => distribution-tests}/pom.xml | 94 ++ .../oss/driver/api/core/DriverDependencyTest.java | 84 +++ .../driver/api/core/OptionalDependencyTest.java| 47 +++ .../driver/api/core/ProvidedDependencyTest.java| 45 +++ examples/pom.xml | 5 ++ integration-tests/pom.xml | 5 ++ manual/core/integration/README.md | 31 --- mapper-processor/pom.xml | 2 + mapper-runtime/pom.xml | 2 + metrics/micrometer/pom.xml | 10 +++ metrics/microprofile/pom.xml | 10 +++ osgi-tests/pom.xml | 6 ++ pom.xml| 1 + query-builder/pom.xml | 2 + test-infra/pom.xml | 2 +- 17 files changed, 281 insertions(+), 69 deletions(-) diff --git a/core-shaded/pom.xml b/core-shaded/pom.xml index f6deeb70b..239e29eec 100644 --- a/core-shaded/pom.xml +++ b/core-shaded/pom.xml @@ -107,10 +107,12 @@ com.github.stephenc.jcip jcip-annotations + provided com.github.spotbugs spotbugs-annotations + provided - -javadoc-jar -package - - jar - - - javadoc - -** - - - - +org.apache.maven.plugins +maven-surefire-plugin + + 1 + org.revapi revapi-maven-plugin - true + +maven-install-plugin + + true + + + +maven-deploy-plugin + + true + + + +org.sonatype.plugins +nexus-staging-maven-plugin + + true + + diff --git a/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java b/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java new file mode 100644 index 0..16952e3d7 --- /dev/null +++ b/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.datastax.oss.driver.api.core; + +import static org.assertj.core.api.Assertions.assertThat; + +import com.datastax.oss.driver.api.core.session.Session; +import com.datastax.oss.driver.api.mapper.MapperBuilder; +import com.datastax.oss.driver.api.querybuilder.QueryBuilder; +import com.datastax.oss.driver.api.testinfra.CassandraResourceRule; +import com.datastax.oss.driver.internal.core.util.Reflection; +import com.datastax.oss.driver.internal.mapper.processor.MapperProcessor; +import com.datastax.oss.driver.internal.metrics.micrometer.MicrometerMetricsFactory; +import com.datastax.oss.driver.internal.metrics.microprofile.MicroProfileMetricsFactory; +import org.junit.Test; + +public class DriverDependencyTest { + @Test + public void should_include_core_jar() { +assertThat(Reflection.loadClass(null, "com.datastax.oss.driver.api.core.session.Session")) +
Re: [PR] CASSANDRA-18969: Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.11.x branch] [cassandra-java-driver]
michaelsembwever merged PR #1755: URL: https://github.com/apache/cassandra-java-driver/pull/1755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-java-driver) branch 4.8.0_fixes updated: Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.8.0_fixes branch]
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch 4.8.0_fixes in repository https://gitbox.apache.org/repos/asf/cassandra-java-driver.git The following commit(s) were added to refs/heads/4.8.0_fixes by this push: new 8f44b6d61 Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.8.0_fixes branch] 8f44b6d61 is described below commit 8f44b6d61ef04c2dd6767f39b2f386175fbeb92a Author: Henry Hughes AuthorDate: Wed Nov 1 12:50:18 2023 -0700 Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.8.0_fixes branch] patch by Henry Hughes; reviewed by Mick Semb Wever for CASSANDRA-18969 --- core-shaded/pom.xml| 2 + core/pom.xml | 2 + {metrics/micrometer => distribution-tests}/pom.xml | 90 +++--- .../oss/driver/api/core/DriverDependencyTest.java | 84 .../driver/api/core/OptionalDependencyTest.java| 35 + .../driver/api/core/ProvidedDependencyTest.java| 45 +++ examples/pom.xml | 5 ++ integration-tests/pom.xml | 5 ++ manual/core/integration/README.md | 31 mapper-processor/pom.xml | 2 + mapper-runtime/pom.xml | 2 + metrics/micrometer/pom.xml | 10 +++ metrics/microprofile/pom.xml | 10 +++ osgi-tests/pom.xml | 6 ++ pom.xml| 1 + query-builder/pom.xml | 2 + test-infra/pom.xml | 2 +- 17 files changed, 269 insertions(+), 65 deletions(-) diff --git a/core-shaded/pom.xml b/core-shaded/pom.xml index 57edc74fc..779bb8ff5 100644 --- a/core-shaded/pom.xml +++ b/core-shaded/pom.xml @@ -109,10 +109,12 @@ com.github.stephenc.jcip jcip-annotations + provided com.github.spotbugs spotbugs-annotations + provided - -javadoc-jar -package - - jar - - - javadoc - -** - - - - +org.apache.maven.plugins +maven-surefire-plugin + + 1 + org.revapi revapi-maven-plugin - true + +maven-install-plugin + + true + + + +maven-deploy-plugin + + true + + + +org.sonatype.plugins +nexus-staging-maven-plugin + + true + + diff --git a/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java b/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java new file mode 100644 index 0..16952e3d7 --- /dev/null +++ b/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.datastax.oss.driver.api.core; + +import static org.assertj.core.api.Assertions.assertThat; + +import com.datastax.oss.driver.api.core.session.Session; +import com.datastax.oss.driver.api.mapper.MapperBuilder; +import com.datastax.oss.driver.api.querybuilder.QueryBuilder; +import com.datastax.oss.driver.api.testinfra.CassandraResourceRule; +import com.datastax.oss.driver.internal.core.util.Reflection; +import com.datastax.oss.driver.internal.mapper.processor.MapperProcessor; +import com.datastax.oss.driver.internal.metrics.micrometer.MicrometerMetricsFactory; +import com.datastax.oss.driver.internal.metrics.microprofile.MicroProfileMetricsFactory; +import org.junit.Test; + +public class DriverDependencyTest { + @Test + public void should_include_core_jar() { +assertThat(Reflection.loadClass(null, "com.datastax.oss.driver.api.core.session.Session")) +
Re: [PR] CASSANDRA-18969: Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.8.0_fixes branch] [cassandra-java-driver]
michaelsembwever merged PR #1754: URL: https://github.com/apache/cassandra-java-driver/pull/1754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-java-driver) branch 4.7.x updated: Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.7.x branch]
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch 4.7.x in repository https://gitbox.apache.org/repos/asf/cassandra-java-driver.git The following commit(s) were added to refs/heads/4.7.x by this push: new e6cc45f5f Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.7.x branch] e6cc45f5f is described below commit e6cc45f5f9de2125467e0b12fb1e8483817645e2 Author: Henry Hughes AuthorDate: Wed Nov 1 12:50:18 2023 -0700 Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.7.x branch] patch by Henry Hughes; reviewed by Mick Semb Wever for CASSANDRA-18969 --- core-shaded/pom.xml| 2 + core/pom.xml | 2 + {test-infra => distribution-tests}/pom.xml | 82 -- .../oss/driver/api/core/DriverDependencyTest.java | 64 + .../driver/api/core/OptionalDependencyTest.java| 35 + .../driver/api/core/ProvidedDependencyTest.java| 45 examples/pom.xml | 5 ++ integration-tests/pom.xml | 5 ++ manual/core/integration/README.md | 31 mapper-processor/pom.xml | 2 + mapper-runtime/pom.xml | 2 + osgi-tests/pom.xml | 6 ++ pom.xml| 1 + query-builder/pom.xml | 2 + test-infra/pom.xml | 2 +- 15 files changed, 230 insertions(+), 56 deletions(-) diff --git a/core-shaded/pom.xml b/core-shaded/pom.xml index c813a8203..a3a0a2692 100644 --- a/core-shaded/pom.xml +++ b/core-shaded/pom.xml @@ -113,10 +113,12 @@ com.github.stephenc.jcip jcip-annotations + provided com.github.spotbugs spotbugs-annotations + provided - com.datastax.oss.simulacron - simulacron-native-server - true + com.datastax.oss + java-driver-mapper-runtime + test - - org.apache.commons - commons-exec - true + com.datastax.oss + java-driver-core + test - org.awaitility - awaitility + junit + junit + test -maven-jar-plugin +org.apache.maven.plugins +maven-surefire-plugin + + 1 + + + +org.revapi +revapi-maven-plugin + + true + + + +maven-install-plugin + + true + + + +maven-deploy-plugin - - - com.datastax.oss.driver.tests.infrastructure - - + true -org.apache.felix -maven-bundle-plugin +org.sonatype.plugins +nexus-staging-maven-plugin - - com.datastax.oss.driver.testinfra - -* -com.datastax.oss.driver.*.testinfra.*, com.datastax.oss.driver.assertions, com.datastax.oss.driver.categories - + true diff --git a/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java b/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java new file mode 100644 index 0..2c4a22f45 --- /dev/null +++ b/distribution-tests/src/test/java/com/datastax/oss/driver/api/core/DriverDependencyTest.java @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.datastax.oss.driver.api.core; + +import static org.assertj.core.api.Assertions.assertThat; + +import com.datastax.oss.driver.api.core.session.Session; +import com.datastax.oss.driver.api.mapper.MapperBuilder; +import com.datastax.oss.driver.api.querybuilder.QueryBuilder; +import com.datastax.oss.driver.api.testinfra.CassandraResourceRule; +import com.datastax.oss.driver.internal.core.util.Reflection; +import
Re: [PR] CASSANDRA-18969: Mark spotbugs-annotation and jcip-annotations as provided dependencies [4.7.x branch] [cassandra-java-driver]
michaelsembwever merged PR #1753: URL: https://github.com/apache/cassandra-java-driver/pull/1753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org