[jira] [Commented] (CASSANDRA-18951) Add option for MutualTlsAuthenticator to restrict the certificate age
[
https://issues.apache.org/jira/browse/CASSANDRA-18951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830690#comment-17830690
]
Dinesh Joshi commented on CASSANDRA-18951:
--
+1, thanks for the patch.
> Add option for MutualTlsAuthenticator to restrict the certificate age
> -
>
> Key: CASSANDRA-18951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18951
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Authorization
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> In {{org.apache.cassandra.auth.MutualTlsAuthenticator}}, we validate that a
> certificate is valid by looking at the identities inside the
> certificate and making sure the identity exists in the identity to role table.
> In some situations we may want to restrict the certificates
> we accept by rejecting certificates older than x amount of days. Some
> certificates can be generated with long expiration dates,
> and this might be undesired when you want to protect against potential
> certificates being compromised. For that reason, it is
> important to add an option, that when configured, we can limit the age of the
> certificate we accept for mTLS authentication.
> When enabled, this will force clients to have to renew certificates more
> frequently, reducing the exposure of a Cassandra cluster
> to leaked certificates.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18857) Allow CQL client certificate authentication to work without sending an AUTHENTICATE request
[
https://issues.apache.org/jira/browse/CASSANDRA-18857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812450#comment-17812450
]
Dinesh Joshi commented on CASSANDRA-18857:
--
+1, thanks for the patch!
> Allow CQL client certificate authentication to work without sending an
> AUTHENTICATE request
> ---
>
> Key: CASSANDRA-18857
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18857
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Encryption
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Attachments: ci_summary.html, result_details.tar.gz
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Currently when using {{MutualTlsAuthenticator}} or
> {{MutualTlsWithPasswordFallbackAuthenticator}} a client is prompted with an
> {{AUTHENTICATE}} message to which they must respond with an {{AUTH_RESPONSE}}
> (e.g. a user name and password). This shouldn't be needed as the role can be
> identified using only the certificate.
> To address this, we could add the capability to authenticate early in
> processing of a {{STARTUP}} message if we can determine that both the
> configured authenticator supports certificate authentication and a client
> certificate was provided. If the certificate can be authenticated, a
> {{READY}} response is returned, otherwise an {{ERROR}} is returned.
> This change can be done done in a fully backwards compatible way and requires
> no protocol or driver changes; I will supply a patch shortly!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14572) Expose all table metrics in virtual table
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800138#comment-17800138
]
Dinesh Joshi commented on CASSANDRA-14572:
--
hi [~mmuzaf] thanks for your patch. This is not a formal review but I wanted to
leave some brief observations -
1. I am concerned about the GC pressure this would generate if someone wrote a
script to constantly poll this virtual table. Maybe add some documentation that
discourages polling of this virtual table?
2. I am personally ok with adding the annotation processing. However, I would
suggest the use of some templating engine to generate the code. For example,
you could clean up {{SystemViewAnnotationProcessor::generate}} method with a
template engine. Right now it appears that it will be difficult to maintain it
the way it is written. I recognize this would mean we may need to pull in a
templating engine as a compile time dependency.
> Expose all table metrics in virtual table
> -
>
> Key: CASSANDRA-14572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14572
> Project: Cassandra
> Issue Type: New Feature
> Components: Legacy/Observability, Observability/Metrics
>Reporter: Chris Lohfink
>Assignee: Maxim Muzafarov
>Priority: Low
> Labels: virtual-tables
> Fix For: 5.x
>
> Attachments: keyspayces_group responses times.png, keyspayces_group
> summary.png, select keyspaces_group by string prefix.png, select
> keyspaces_group compare with wo.png, select keyspaces_group without
> value.png, systemv_views.metrics_dropped_message.png, thread_pools
> benchmark.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While we want a number of virtual tables to display data in a way thats great
> and intuitive like in nodetool. There is also much for being able to expose
> the metrics we have for tooling via CQL instead of JMX. This is more for the
> tooling and adhoc advanced users who know exactly what they are looking for.
> *Schema:*
> Initial idea is to expose data via {{((keyspace, table), metric)}} with a
> column for each metric value. Could also use a Map or UDT instead of the
> column based that can be a bit more specific to each metric type. To that end
> there can be a {{metric_type}} column and then a UDT for each metric type
> filled in, or a single value with more of a Map style. I am
> purposing the column type though as with {{ALLOW FILTERING}} it does allow
> more extensive query capabilities.
> *Implementations:*
> * Use reflection to grab all the metrics from TableMetrics (see:
> CASSANDRA-7622 impl). This is easiest and least abrasive towards new metric
> implementors... but its reflection and a kinda a bad idea.
> * Add a hook in TableMetrics to register with this virtual table when
> registering
> * Pull from the CassandraMetrics registery (either reporter or iterate
> through metrics query on read of virtual table)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19048) Audit table properties passed through Analytics CqlUtils
[ https://issues.apache.org/jira/browse/CASSANDRA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-19048: - Fix Version/s: NA Since Version: 5.0-alpha2 Source Control Link: https://github.com/apache/cassandra-analytics/commit/c73c76498b0c2b36705025de6b0b2a7bb38e758b Resolution: Fixed Status: Resolved (was: Ready to Commit) > Audit table properties passed through Analytics CqlUtils > > > Key: CASSANDRA-19048 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19048 > Project: Cassandra > Issue Type: Bug > Components: Analytics Library >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: NA > > Time Spent: 0.5h > Remaining Estimate: 0h > > In mixed version clusters, table properties (`WITH` clauses in the table > definition) have historically been moved or renamed without much thought to > backward-compatibility of external tools. This has caused breaking changes to > the Analytics library in the past. Therefore, the Analytics library removes > most table properties from the table schema it uses in order to avoid these > issues. However, it is currently too aggressive in this removal process. For > example, the `default_time_to_live` parameter is currently removed from the > table options, but the Bulk Writer should use this to set the appropriate TTL > when the user doesn’t specify it in the bulk job. > Similarly, compression options passed to the Bulk Writer should be honored so > that the appropriate compression algorithm is used when generating sstables. > The allowlist of options needs to be audited and improved to add additional > options where appropriate. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19048) Audit table properties passed through Analytics CqlUtils
[ https://issues.apache.org/jira/browse/CASSANDRA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-19048: - Status: Ready to Commit (was: Review In Progress) > Audit table properties passed through Analytics CqlUtils > > > Key: CASSANDRA-19048 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19048 > Project: Cassandra > Issue Type: Bug > Components: Analytics Library >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > In mixed version clusters, table properties (`WITH` clauses in the table > definition) have historically been moved or renamed without much thought to > backward-compatibility of external tools. This has caused breaking changes to > the Analytics library in the past. Therefore, the Analytics library removes > most table properties from the table schema it uses in order to avoid these > issues. However, it is currently too aggressive in this removal process. For > example, the `default_time_to_live` parameter is currently removed from the > table options, but the Bulk Writer should use this to set the appropriate TTL > when the user doesn’t specify it in the bulk job. > Similarly, compression options passed to the Bulk Writer should be honored so > that the appropriate compression algorithm is used when generating sstables. > The allowlist of options needs to be audited and improved to add additional > options where appropriate. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19048) Audit table properties passed through Analytics CqlUtils
[ https://issues.apache.org/jira/browse/CASSANDRA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-19048: - Reviewers: Dinesh Joshi, Francisco Guerrero, Yifan Cai (was: Francisco Guerrero, Yifan Cai) > Audit table properties passed through Analytics CqlUtils > > > Key: CASSANDRA-19048 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19048 > Project: Cassandra > Issue Type: Bug > Components: Analytics Library >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > In mixed version clusters, table properties (`WITH` clauses in the table > definition) have historically been moved or renamed without much thought to > backward-compatibility of external tools. This has caused breaking changes to > the Analytics library in the past. Therefore, the Analytics library removes > most table properties from the table schema it uses in order to avoid these > issues. However, it is currently too aggressive in this removal process. For > example, the `default_time_to_live` parameter is currently removed from the > table options, but the Bulk Writer should use this to set the appropriate TTL > when the user doesn’t specify it in the bulk job. > Similarly, compression options passed to the Bulk Writer should be honored so > that the appropriate compression algorithm is used when generating sstables. > The allowlist of options needs to be audited and improved to add additional > options where appropriate. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19048) Audit table properties passed through Analytics CqlUtils
[ https://issues.apache.org/jira/browse/CASSANDRA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791465#comment-17791465 ] Dinesh Joshi commented on CASSANDRA-19048: -- +1, thanks for the patch. > Audit table properties passed through Analytics CqlUtils > > > Key: CASSANDRA-19048 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19048 > Project: Cassandra > Issue Type: Bug > Components: Analytics Library >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > In mixed version clusters, table properties (`WITH` clauses in the table > definition) have historically been moved or renamed without much thought to > backward-compatibility of external tools. This has caused breaking changes to > the Analytics library in the past. Therefore, the Analytics library removes > most table properties from the table schema it uses in order to avoid these > issues. However, it is currently too aggressive in this removal process. For > example, the `default_time_to_live` parameter is currently removed from the > table options, but the Bulk Writer should use this to set the appropriate TTL > when the user doesn’t specify it in the bulk job. > Similarly, compression options passed to the Bulk Writer should be honored so > that the appropriate compression algorithm is used when generating sstables. > The allowlist of options needs to be audited and improved to add additional > options where appropriate. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19003) Get Sidecar port through CassandraContext for more flexibility
[ https://issues.apache.org/jira/browse/CASSANDRA-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786072#comment-17786072 ] Dinesh Joshi commented on CASSANDRA-19003: -- +1, thanks for the patch! > Get Sidecar port through CassandraContext for more flexibility > --- > > Key: CASSANDRA-19003 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19003 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > We get sidecar port from `BulkSparkConf` but it will be better if we get it > from `CassandraContext` provides more flexibility -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-83) Require gossip to be enabled for ring and token ranges mapping endpoints
[ https://issues.apache.org/jira/browse/CASSANDRASC-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784247#comment-17784247 ] Dinesh Joshi commented on CASSANDRASC-83: - +1, thanks for the patch! > Require gossip to be enabled for ring and token ranges mapping endpoints > > > Key: CASSANDRASC-83 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-83 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The ring and token ranges mapping endpoints leverage JMX to produce the > payload. Ring and token ranges mapping information is derived from gossip > information available to the Cassandra instance. If gossip has been disabled, > the information might provide an inconsistent view of the cluster which is > undesirable. We should instead return a 503 (Service Unavailable) to the > client whenever the client tries to access these endpoints and gossip has > been disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-83) Require gossip to be enabled for ring and token ranges mapping endpoints
[ https://issues.apache.org/jira/browse/CASSANDRASC-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRASC-83: Reviewers: Dinesh Joshi, Josh McKenzie > Require gossip to be enabled for ring and token ranges mapping endpoints > > > Key: CASSANDRASC-83 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-83 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The ring and token ranges mapping endpoints leverage JMX to produce the > payload. Ring and token ranges mapping information is derived from gossip > information available to the Cassandra instance. If gossip has been disabled, > the information might provide an inconsistent view of the cluster which is > undesirable. We should instead return a 503 (Service Unavailable) to the > client whenever the client tries to access these endpoints and gossip has > been disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19003) Get Sidecar port through CassandraContext for more flexibility
[ https://issues.apache.org/jira/browse/CASSANDRA-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-19003: - Reviewers: Dinesh Joshi, Josh McKenzie > Get Sidecar port through CassandraContext for more flexibility > --- > > Key: CASSANDRA-19003 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19003 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > > We get sidecar port from `BulkSparkConf` but it will be better if we get it > from `CassandraContext` provides more flexibility -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-81) Improve TokenRangeReplicasResponse payload
[
https://issues.apache.org/jira/browse/CASSANDRASC-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781908#comment-17781908
]
Dinesh Joshi commented on CASSANDRASC-81:
-
+1, thanks for the patch!
> Improve TokenRangeReplicasResponse payload
> --
>
> Key: CASSANDRASC-81
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-81
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> The {{TokenRangeReplicasResponse}} returns {{ReplicaMetadata}}. This
> information is used by clients to lookup the metadata. The lookup is done
> with the replica information, which consists of the host {{ip:port}}. Clients
> are looping over the {{ReplicaMetadata}} list and matching IP and port to
> retrieve the metadata object. Instead, we can improve the payload by changing
> the data structure from a list to a map, and have clients lookup by the
> replica (ip + port), without having to loop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-78) Fix token-ranges endpoint to handle gossip-info responses without 'status'
[
https://issues.apache.org/jira/browse/CASSANDRASC-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779192#comment-17779192
]
Dinesh Joshi commented on CASSANDRASC-78:
-
+1, thanks for the patch!
> Fix token-ranges endpoint to handle gossip-info responses without 'status'
> --
>
> Key: CASSANDRASC-78
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-78
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Rest API
>Reporter: Arjun Ashok
>Assignee: Arjun Ashok
>Priority: Normal
> Labels: pull-request-available
>
> This is a fix to look for the host status in ‘Status’ and ‘StatusWithPort’
> attributes in GossipInfo response to determine the ‘state’ of the node.
> Currently, we only check for ‘status’ which can be missing from gossipInfo in
> some cases, which will result in a replacement node status to be reported as
> `Joining` instead of `Replacing`.
> eg.
> {code:java}
> Found gossipInfoEntry={generation=1697736379,
> schema=6d6abc83-a600-35a4-8bbe-fe5edca6a63b, rack=rack1, heartbeat=119,
> releaseVersion=4.1.4-SNAPSHOT, hostId=--4000-8000-0006,
> nativeAddressAndPort=127.0.0.6:9042, load=76459.0,
> internalAddressAndPort=127.0.0.6:7012, sstableVersions=big-nb,
> tokens=, dc=datacenter1, netVersion=12,
> statusWithPort=BOOT_REPLACE,127.0.0.5:7012}{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRASC-77) Upgrade vertx to version 4.4.6
[ https://issues.apache.org/jira/browse/CASSANDRASC-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778842#comment-17778842 ] Dinesh Joshi edited comment on CASSANDRASC-77 at 10/23/23 10:30 PM: [~frankgh] could you please retitle this Jira since it is bringing new features to the sidecar in addition as a consequence of upgrading vert.x. +1, thanks for the patch! was (Author: djoshi3): +1, thanks for the patch! > Upgrade vertx to version 4.4.6 > -- > > Key: CASSANDRASC-77 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-77 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > Vertx 4.4.6 brings new features that we want to bring into Cassandra Sidecar: > 1. Hot reloading of SSL Certificates. With this feature, we can run Cassandra > Sidecar with TLS options configured, and when the certificate is expired, we > can instruct vertx to reload the certificate from disk without having to > restart the process. > 2. Traffic shaping options. This allows to introduce protections for the > service by providing ways to configure ingress/egress limits for the service, > as well as ingress limits for SSTable uploads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-77) Upgrade vertx to version 4.4.6
[ https://issues.apache.org/jira/browse/CASSANDRASC-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778842#comment-17778842 ] Dinesh Joshi commented on CASSANDRASC-77: - +1, thanks for the patch! > Upgrade vertx to version 4.4.6 > -- > > Key: CASSANDRASC-77 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-77 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > Vertx 4.4.6 brings new features that we want to bring into Cassandra Sidecar: > 1. Hot reloading of SSL Certificates. With this feature, we can run Cassandra > Sidecar with TLS options configured, and when the certificate is expired, we > can instruct vertx to reload the certificate from disk without having to > restart the process. > 2. Traffic shaping options. This allows to introduce protections for the > service by providing ways to configure ingress/egress limits for the service, > as well as ingress limits for SSTable uploads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18916) Start-Up Validation Should Log a Single Report
[ https://issues.apache.org/jira/browse/CASSANDRA-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774222#comment-17774222 ] Dinesh Joshi commented on CASSANDRA-18916: -- +1, thanks for the patch! > Start-Up Validation Should Log a Single Report > -- > > Key: CASSANDRA-18916 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18916 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > In order to improve readability of the log, start-up validation should > produce a complete report and emit it as a single event upon completion -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-74) Unable to stream index file components
[ https://issues.apache.org/jira/browse/CASSANDRASC-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774219#comment-17774219 ] Dinesh Joshi commented on CASSANDRASC-74: - +1, thanks for the patch! > Unable to stream index file components > -- > > Key: CASSANDRASC-74 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-74 > Project: Sidecar for Apache Cassandra > Issue Type: Bug > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The stream SSTables components API fails on secondary index files. When a > table has a secondary index defined, and we list the snapshot including the > secondary index files, and then try to stream the SSTable components, we will > see a 404 (Not Found) error. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18759) Introduce in-jvm dtest for testing in Analytics project
[ https://issues.apache.org/jira/browse/CASSANDRA-18759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772351#comment-17772351 ] Dinesh Joshi commented on CASSANDRA-18759: -- This is an excellent addition. Thank you for the patch. +1. > Introduce in-jvm dtest for testing in Analytics project > --- > > Key: CASSANDRA-18759 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18759 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Time Spent: 3h 50m > Remaining Estimate: 0h > > Now that the in-jvm dtest framework supports JMX, we’ve updated the Cassandra > sidecar to use that as its base test framework. We should use this support in > the Analytics project so we can run tests more quickly and allow for more > advanced testing (startup/shutdown/move/decommission/expand) > Work to complete this ticket would be to incorporate the sidecar’s test > framework into the analytics project and get the `SampleCassandraJob` to run > successfully on an in-jvm 3-node cluster with the Sidecar running. We can > then leverage this framework in future tests. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-73) Update token-ranges endpoint to return additional instance metadata
[ https://issues.apache.org/jira/browse/CASSANDRASC-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770110#comment-17770110 ] Dinesh Joshi commented on CASSANDRASC-73: - +1, thanks for the patch! > Update token-ranges endpoint to return additional instance metadata > --- > > Key: CASSANDRASC-73 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-73 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > Labels: pull-request-available > > Sidecar `token-range-replicas` endpoint to return the following additional > metadata for each instance: > * State. eg Normal, Joining, Leaving > * Status. eg. Up, Down > * Address: Replica host and port > * Name: Node name resolved from the above IP address -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-75) Shaded Sidecar client should shade Jackson completely to avoid incompatibility issues
[ https://issues.apache.org/jira/browse/CASSANDRASC-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768137#comment-17768137 ] Dinesh Joshi commented on CASSANDRASC-75: - +1, thanks for the patch. > Shaded Sidecar client should shade Jackson completely to avoid > incompatibility issues > - > > Key: CASSANDRASC-75 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-75 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 1.0 > > > Before, we we shading almost all of Jackson but left the annotations > unshaded/relocated. However, this causes problems in older Spark environments > where the annotations in the class path don’t quite match what the other > shaded parts of Jackson expect (missing classes being the most serious > issue). This can cause the library to fail on certain Spark versions. > > We should shade +all+ of Jackson in the shaded client to prevent these issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18810) Cassandra Analytics Start-Up Validation
[ https://issues.apache.org/jira/browse/CASSANDRA-18810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768136#comment-17768136 ] Dinesh Joshi commented on CASSANDRA-18810: -- +1, thanks for the patch. > Cassandra Analytics Start-Up Validation > --- > > Key: CASSANDRA-18810 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18810 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 6.5h > Remaining Estimate: 0h > > Cassandra Analytics should perform a start-up validation of network > connectivity to Cassandra and Cassandra Sidecar, as well as of authentication > materials -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18681) Internode legacy SSL storage port certificate is not hot reloaded on update
[
https://issues.apache.org/jira/browse/CASSANDRA-18681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766996#comment-17766996
]
Dinesh Joshi commented on CASSANDRA-18681:
--
+1, thanks for the patch!
> Internode legacy SSL storage port certificate is not hot reloaded on update
> ---
>
> Key: CASSANDRA-18681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18681
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
>
> In CASSANDRA-1 the SSLContext cache was changed to clear individual
> {{EncryptionOptions}} from the SslContext cache if they needed reloading to
> reduce resource consumption. Before the change if ANY cert needed hot
> reloading, the SSLContext cache would be cleared for ALL certs.
> If the legacy SSL storage port is configured, a new {{EncryptionOptions}}
> object is created in {{org.apache.cassandra.net.InboundSockets#addBindings}}
> just for binding the socket, but never gets cleared as the change in port
> means it no longer matches the configuration retrieved from
> {{DatabaseDescriptor}} in
> {{org.apache.cassandra.net.MessagingServiceMBeanImpl#reloadSslCertificates}}.
> This is unlikely to be an issue in practice as the legacy SSL internode
> socket is only used in mixed version clusters with pre-4.0 nodes, so the cert
> only needs to stay valid until all nodes upgrade to 4.x or above.
> One way to avoid this class of failures is to just check the entries present
> in the SSLContext cache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-60) Sidecar API to expose cluster topology information
[ https://issues.apache.org/jira/browse/CASSANDRASC-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764805#comment-17764805 ] Dinesh Joshi commented on CASSANDRASC-60: - +1, thanks for the patch! > Sidecar API to expose cluster topology information > -- > > Key: CASSANDRASC-60 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-60 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > Labels: pull-request-available > > This API will expose token ranges and the corresponding read and write > replicas. The write replica-set token ranges will include natural and pending > ranges, so clients can have a complete view of the cluster as nodes are > joining or leaving. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-69) Refactor Configuration
[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762475#comment-17762475
]
Dinesh Joshi commented on CASSANDRASC-69:
-
+1, thanks for the patch!
> Refactor Configuration
> --
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-71) Allow configuring permissions for uploaded SSTables
[
https://issues.apache.org/jira/browse/CASSANDRASC-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762476#comment-17762476
]
Dinesh Joshi commented on CASSANDRASC-71:
-
+1, thanks for the patch!
> Allow configuring permissions for uploaded SSTables
> ---
>
> Key: CASSANDRASC-71
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-71
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> When uploading SSTables, the default permissions are being set. Currently,
> 644 or {{rw---}} are the default permissions. Ideally, a user should be
> able to configure the desired file permissions used during an SSTable upload.
> This allows the Cassandra process to import the SSTable with the permissions
> suitable for the import process.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-72) [CircleCI] Split unit tests and integration tests
[ https://issues.apache.org/jira/browse/CASSANDRASC-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762473#comment-17762473 ] Dinesh Joshi commented on CASSANDRASC-72: - +1, thanks for the patch! > [CircleCI] Split unit tests and integration tests > - > > Key: CASSANDRASC-72 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-72 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > > As the number of integration tests continues to grow, it is desirable to > split unit tests and integration tests. It is also desirable to parallelize > integration tests, each integration test should be its own job. The goals of > this improvement are: > * Fail fast on checkstyle or minor errors > * Speed up test runtime by running integration tests in parallel > * Isolate failing tests to specific combinations of Cassandra -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18683) Expose per partition on-disk usage through new DataFrame that utilizes the Index.db SSTable file components.
[ https://issues.apache.org/jira/browse/CASSANDRA-18683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762170#comment-17762170 ] Dinesh Joshi commented on CASSANDRA-18683: -- +1, thanks for the patch. > Expose per partition on-disk usage through new DataFrame that utilizes the > Index.db SSTable file components. > > > Key: CASSANDRA-18683 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18683 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: James Berragan >Assignee: James Berragan >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > This addition to Cassandra Analytics provides a new > PartitionSizeTableProvider that generates a DataFrame returning the > compressed and uncompressed partition sizes for all partitions in a table by > utilizing the Index.db SSTable file component. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-70) Add Client Methods for Obtaining Sidecar and Cassandra Health
[ https://issues.apache.org/jira/browse/CASSANDRASC-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRASC-70: Reviewers: Dinesh Joshi, Francisco Guerrero, Yifan Cai (was: Francisco Guerrero, Yifan Cai) > Add Client Methods for Obtaining Sidecar and Cassandra Health > - > > Key: CASSANDRASC-70 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-70 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > Methods for obtaining Sidecar and Cassandra health need to be added to the > client. > Both of these methods will be used for start-up validation by the Analytics > library. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRASC-70) Add Client Methods for Obtaining Sidecar and Cassandra Health
[ https://issues.apache.org/jira/browse/CASSANDRASC-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi reassigned CASSANDRASC-70: --- Assignee: Yuriy Semchyshyn > Add Client Methods for Obtaining Sidecar and Cassandra Health > - > > Key: CASSANDRASC-70 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-70 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > Methods for obtaining Sidecar and Cassandra health need to be added to the > client. > Both of these methods will be used for start-up validation by the Analytics > library. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-70) Add Client Methods for Obtaining Sidecar and Cassandra Health
[ https://issues.apache.org/jira/browse/CASSANDRASC-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760103#comment-17760103 ] Dinesh Joshi commented on CASSANDRASC-70: - +1, thanks for the patch. > Add Client Methods for Obtaining Sidecar and Cassandra Health > - > > Key: CASSANDRASC-70 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-70 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > Methods for obtaining Sidecar and Cassandra health need to be added to the > client. > Both of these methods will be used for start-up validation by the Analytics > library. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-68) Add Metrics publisher interface to Sidecar to expose metrics for capture
[ https://issues.apache.org/jira/browse/CASSANDRASC-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759758#comment-17759758 ] Dinesh Joshi commented on CASSANDRASC-68: - +1, thanks for the patch! > Add Metrics publisher interface to Sidecar to expose metrics for capture > > > Key: CASSANDRASC-68 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-68 > Project: Sidecar for Apache Cassandra > Issue Type: New Feature > Components: Rest API >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: High > > We need metrics publisher interface in Sidecar to capture some of the metrics > like bytes written/streamed. > PR: [https://github.com/apache/cassandra-sidecar/pull/64] > CircleCI run: > [https://app.circleci.com/pipelines/github/sarankk/cassandra-sidecar] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18722) Support Dynamic Port Allocation for in-jvm dtest framework
[
https://issues.apache.org/jira/browse/CASSANDRA-18722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757575#comment-17757575
]
Dinesh Joshi commented on CASSANDRA-18722:
--
+1, thanks.
> Support Dynamic Port Allocation for in-jvm dtest framework
> --
>
> Key: CASSANDRA-18722
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18722
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, {{INodeProvisionStrategy}} supports two strategies
> {{OneNetworkInterface}} and {{MultipleNetworkInterfaces}}. However the
> {{seedPort}}, {{storagePorts}}, {{nativeTransportPorts}}, and {{jmxPorts}}
> are always fixed or a function of the node number.
> In order to better support parallel test runs, we need to support dynamic
> port allocation for the {{seedPort}}, {{storagePorts}},
> {{nativeTransportPorts}}, and {{jmxPorts}}. This would enable us to more
> easily write tests that can run in parallel. This effort is only a stepping
> stone in what's required to run more tests in parallel, but it allows us to
> begin somewhere with the in-jvm dtest framework.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18692) [Cassandra Analytics] Fix bulk writes with Buffered RowBufferMode
[
https://issues.apache.org/jira/browse/CASSANDRA-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dinesh Joshi updated CASSANDRA-18692:
-
Reviewers: Dinesh Joshi, Yifan Cai (was: Dinesh Joshi, Yifan Cai, Yifan
Cai)
> [Cassandra Analytics] Fix bulk writes with Buffered RowBufferMode
> --
>
> Key: CASSANDRA-18692
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18692
> Project: Cassandra
> Issue Type: Bug
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When setting {{Buffered}} {{RowBufferMode}} as part of the {{WriterOption's}}
> , {{org.apache.cassandra.spark.bulkwriter.RecordWriter}} ignores that
> configuration and uses the batch size to finalize an SSTable and start using
> a new one if new rows are available.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18692) [Cassandra Analytics] Fix bulk writes with Buffered RowBufferMode
[
https://issues.apache.org/jira/browse/CASSANDRA-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752174#comment-17752174
]
Dinesh Joshi commented on CASSANDRA-18692:
--
Branch: https://github.com/frankgh/cassandra-analytics/tree/CASSANDRA-18692
+1, thanks for the patch.
> [Cassandra Analytics] Fix bulk writes with Buffered RowBufferMode
> --
>
> Key: CASSANDRA-18692
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18692
> Project: Cassandra
> Issue Type: Bug
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When setting {{Buffered}} {{RowBufferMode}} as part of the {{WriterOption's}}
> , {{org.apache.cassandra.spark.bulkwriter.RecordWriter}} ignores that
> configuration and uses the batch size to finalize an SSTable and start using
> a new one if new rows are available.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18727) JMXUtil.getJmxConnector should retry connection attempts
[ https://issues.apache.org/jira/browse/CASSANDRA-18727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752169#comment-17752169 ] Dinesh Joshi commented on CASSANDRA-18727: -- +1, thanks for the patch. > JMXUtil.getJmxConnector should retry connection attempts > - > > Key: CASSANDRA-18727 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18727 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Labels: pull-request-available > > We previously added a JMXUtil class that makes it easy for dtests to get a > JMX connection. It ends up that occasionally the JMX server side needs more > time to start up (especially when stopping and restarting instances, which > we’re now doing more frequently, or when stopping and restarting the whole > cluster). In these cases, JMXUtil.getJmxConnector can fail, when it would be > possible to connect if a retry mechanism was added. We should add this > capability to the in-jvm dtest framework. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18727) JMXUtil.getJmxConnector should retry connection attempts
[ https://issues.apache.org/jira/browse/CASSANDRA-18727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18727: - Reviewers: Alex Petrov, Dinesh Joshi, Jon Meredith (was: Alex Petrov, Jon Meredith) > JMXUtil.getJmxConnector should retry connection attempts > - > > Key: CASSANDRA-18727 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18727 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Labels: pull-request-available > > We previously added a JMXUtil class that makes it easy for dtests to get a > JMX connection. It ends up that occasionally the JMX server side needs more > time to start up (especially when stopping and restarting instances, which > we’re now doing more frequently, or when stopping and restarting the whole > cluster). In these cases, JMXUtil.getJmxConnector can fail, when it would be > possible to connect if a retry mechanism was added. We should add this > capability to the in-jvm dtest framework. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-55) Extract integration test framework for use in other projects
[ https://issues.apache.org/jira/browse/CASSANDRASC-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749957#comment-17749957 ] Dinesh Joshi commented on CASSANDRASC-55: - +1, thanks for the patch. > Extract integration test framework for use in other projects > - > > Key: CASSANDRASC-55 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-55 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Labels: pull-request-available > > The CassandraIntegrationTest implementation in the Sidecar project can be > used in the Analytics project as well. > Extract the necessary classes into their own project so they can be more > easily used in other projects. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18554) mTLS based client and internode authenticators
[ https://issues.apache.org/jira/browse/CASSANDRA-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18554: - Fix Version/s: 5.0 Source Control Link: https://github.com/apache/cassandra/commit/f078c02cb58bddd735490b07548f7352f0eb09aa Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed. Thanks everybody. > mTLS based client and internode authenticators > -- > > Key: CASSANDRA-18554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18554 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Authorization >Reporter: Jyothsna Konisa >Assignee: Jyothsna Konisa >Priority: Normal > Fix For: 5.0 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > Cassandra currently doesn't have any certificate based authenticator for both > client connections and internode connections. If one wants to use certificate > based authentication protocol like TLS, in which clients send their > certificates for the TLS handshake, we can leverage the information from the > client certificate to identify a client. Using this authentication mechanism > one can avoid the pain of password generations, sharing and rotation. > Introducing following certificate based mTLS authenticators for internode and > client connections > MutualTlsAuthenticator (client authentication) > MutualTlsInternodeAuthenticator (internode authentication) > MutualTlsWithPasswordFallbackAuthenticator (for optional mode operation for > client authentication) > An implementation of MutualTlsCertificateValidator called > SpiffeCertificateValidator whose identity is SPIFFE that is embedded in SAN > of the client certificate. One can implement their own CertificateValidator > to match their needs and configure it in Cassandra.yaml -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18554) mTLS based client and internode authenticators
[ https://issues.apache.org/jira/browse/CASSANDRA-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18554: - Status: Ready to Commit (was: Review In Progress) +1, thanks for the patch. > mTLS based client and internode authenticators > -- > > Key: CASSANDRA-18554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18554 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Authorization >Reporter: Jyothsna Konisa >Assignee: Jyothsna Konisa >Priority: Normal > Time Spent: 3.5h > Remaining Estimate: 0h > > Cassandra currently doesn't have any certificate based authenticator for both > client connections and internode connections. If one wants to use certificate > based authentication protocol like TLS, in which clients send their > certificates for the TLS handshake, we can leverage the information from the > client certificate to identify a client. Using this authentication mechanism > one can avoid the pain of password generations, sharing and rotation. > Introducing following certificate based mTLS authenticators for internode and > client connections > MutualTlsAuthenticator (client authentication) > MutualTlsInternodeAuthenticator (internode authentication) > MutualTlsWithPasswordFallbackAuthenticator (for optional mode operation for > client authentication) > An implementation of MutualTlsCertificateValidator called > SpiffeCertificateValidator whose identity is SPIFFE that is embedded in SAN > of the client certificate. One can implement their own CertificateValidator > to match their needs and configure it in Cassandra.yaml -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18697) Skip ColumnFamilyStore#topPartitions initialization when client or tool mode
[
https://issues.apache.org/jira/browse/CASSANDRA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748721#comment-17748721
]
Dinesh Joshi commented on CASSANDRA-18697:
--
+1, thanks for the patch.
> Skip ColumnFamilyStore#topPartitions initialization when client or tool mode
>
>
> Key: CASSANDRA-18697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18697
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In {{org.apache.cassandra.db.ColumnFamilyStore}} the {{topPartitions}} is
> initialized when the keyspace is not a system keyspace. However, when running
> the cassandra library as client mode or tool mode, the initialization also
> happens. However, {{TopPartitionTracker}} performs queries to the {{system}}
> keyspace, which might not be available in most of the cases. For that reason,
> we should skip initialization of {{topPartitions}} when running on client
> mode or tool mode.
> In utilities and external libraries, this can produce a warning that is
> displayed with a stack trace. This warning can be misleading for end users,
> and can cause confusion. But more importantly, the initialization of
> {{topPartitions}} is not required in this mode.
> The warning is similar to this:
> {code:java}
> WARN org.apache.cassandra.db.SystemKeyspace: Could not load stored top
> SIZES partitions for ...
> org.apache.cassandra.db.KeyspaceNotDefinedException: keyspace system does
> not exist
> at
> org.apache.cassandra.schema.Schema.validateTable(Schema.java:xxx) ~[?:?]
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:xxx)
> ~[?:?]
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:xxx)
> ~[?:?]
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:xxx)
> ~[?:?]
> at
> org.apache.cassandra.cql3.QueryProcessor.parseAndPrepare(QueryProcessor.java:xxx)
> ~[?:?]
> ... {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18592) CIDR filtering authorizer for Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-18592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748702#comment-17748702 ] Dinesh Joshi commented on CASSANDRA-18592: -- +1, thank you for your patch. Good work. > CIDR filtering authorizer for Cassandra > --- > > Key: CASSANDRA-18592 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18592 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Authorization >Reporter: Shailaja Koppu >Assignee: Shailaja Koppu >Priority: Normal > Labels: authorization, cidr, features, security > Time Spent: 0.5h > Remaining Estimate: 0h > > Introducing a new authorizer, to allow or disallow users accesses based on > client's IP or CIDR group. Please see the confluence page for requirements > and detailed design of this feature > [https://cwiki.apache.org/confluence/display/CASSANDRA/CIDR+filtering+authorizer]. > Will post PR link and dev discussion soon. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18554) mTLS based client and internode authenticators
[ https://issues.apache.org/jira/browse/CASSANDRA-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747749#comment-17747749 ] Dinesh Joshi commented on CASSANDRA-18554: -- Please add CI run. > mTLS based client and internode authenticators > -- > > Key: CASSANDRA-18554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18554 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Authorization >Reporter: Jyothsna Konisa >Assignee: Jyothsna Konisa >Priority: Normal > Time Spent: 2.5h > Remaining Estimate: 0h > > Cassandra currently doesn't have any certificate based authenticator for both > client connections and internode connections. If one wants to use certificate > based authentication protocol like TLS, in which clients send their > certificates for the TLS handshake, we can leverage the information from the > client certificate to identify a client. Using this authentication mechanism > one can avoid the pain of password generations, sharing and rotation. > Introducing following certificate based mTLS authenticators for internode and > client connections > MutualTlsAuthenticator (client authentication) > MutualTlsInternodeAuthenticator (internode authentication) > MutualTlsWithPasswordFallbackAuthenticator (for optional mode operation for > client authentication) > An implementation of MutualTlsCertificateValidator called > SpiffeCertificateValidator whose identity is SPIFFE that is embedded in SAN > of the client certificate. One can implement their own CertificateValidator > to match their needs and configure it in Cassandra.yaml -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-67) Fix relocation of native libraries for vertx-client-shaded
[
https://issues.apache.org/jira/browse/CASSANDRASC-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747175#comment-17747175
]
Dinesh Joshi commented on CASSANDRASC-67:
-
+1, thanks for the patch.
> Fix relocation of native libraries for vertx-client-shaded
> --
>
> Key: CASSANDRASC-67
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-67
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> OpenSSL is currently unavailable in the {{vertx-client-shaded}} library. This
> is due to the incorrect relocation of the netty native libraries under
> {{META-INF/native/libnetty}}. In order to utilize native libraries, we need
> to fix the relocation and ensure that relocation is properly configured by
> adding tests guaranteeing OpenSSL is loading correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18684) [Analytics] Minor Refactoring to Improve Code Reusability
[ https://issues.apache.org/jira/browse/CASSANDRA-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747143#comment-17747143 ] Dinesh Joshi commented on CASSANDRA-18684: -- +1, thanks for the patch! > [Analytics] Minor Refactoring to Improve Code Reusability > - > > Key: CASSANDRA-18684 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18684 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: Refactoring, refactor, refactoring > > A very minor refactoring is needed in the `CassandraClusterInfo` class to > enable reuse of the code block handling retrieval of all `NodeSettings`. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-65) Enrich error message in RetriesExhaustedException for better visibility
[
https://issues.apache.org/jira/browse/CASSANDRASC-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745262#comment-17745262
]
Dinesh Joshi commented on CASSANDRASC-65:
-
+1, thanks for the patch.
> Enrich error message in RetriesExhaustedException for better visibility
> ---
>
> Key: CASSANDRASC-65
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-65
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Rest API
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
>
> The current error message of RetriesExhaustedException only states that a
> request exhausts the retries and fails. See below. It is not particularly
> helpful when debugging.
> I would like to enrich the error message to include the last response and
> responding server to provide better context on the failed request.
> {code:java}
> Caused by: java.util.concurrent.CompletionException:
> org.apache.cassandra.sidecar.client.exception.RetriesExhaustedException:
> Unable to complete request 'my_request' after 1 attempt
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18662) [Cassandra Analytics] Fix cassandra-analytics-core-example
[
https://issues.apache.org/jira/browse/CASSANDRA-18662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743922#comment-17743922
]
Dinesh Joshi commented on CASSANDRA-18662:
--
+1, thanks for the patch.
> [Cassandra Analytics] Fix cassandra-analytics-core-example
> --
>
> Key: CASSANDRA-18662
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18662
> Project: Cassandra
> Issue Type: Bug
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{cassandra-analytics-core-example}} recently broke from a couple of
> commits and we need to make it usable again so that users can easily engage
> in the project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-63) Support credential rotation in JmxClient
[
https://issues.apache.org/jira/browse/CASSANDRASC-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742930#comment-17742930
]
Dinesh Joshi commented on CASSANDRASC-63:
-
+1, thanks for the patch.
> Support credential rotation in JmxClient
>
>
> Key: CASSANDRASC-63
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-63
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> JMX credentials in a Cassandra instance can be rotated on a cadence, on every
> bounce, or by some other means. In those cases, the {{JmxClient}} will no
> longer be able to connect to the instance completely losing the ability to
> talk to that instance.
> In those cases, it is desirable for the {{JmxClient}} to support changes to
> be able to continue working correctly, without any potential downtime to the
> Sidecar service.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-64) File descriptor is not being closed on MD5 checksum
[ https://issues.apache.org/jira/browse/CASSANDRASC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742201#comment-17742201 ] Dinesh Joshi commented on CASSANDRASC-64: - +1, thanks for the patch. > File descriptor is not being closed on MD5 checksum > --- > > Key: CASSANDRASC-64 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-64 > Project: Sidecar for Apache Cassandra > Issue Type: Bug > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The file descriptor is not being closed when an MD5 checksum is performed > during SSTable upload. This could prevent the Sidecar JVM to not be able to > open more files when the ulimit has been reached -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-64) File descriptor is not being closed on MD5 checksum
[ https://issues.apache.org/jira/browse/CASSANDRASC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742135#comment-17742135 ] Dinesh Joshi commented on CASSANDRASC-64: - hi [~frankgh] thank you for the patch. It would be a good idea to add a test that will check for file descriptor leaks. You could run several iterations forcing failure and checking that the file descriptors are not accumulating in the test run. > File descriptor is not being closed on MD5 checksum > --- > > Key: CASSANDRASC-64 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-64 > Project: Sidecar for Apache Cassandra > Issue Type: Bug > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The file descriptor is not being closed when an MD5 checksum is performed > during SSTable upload. This could prevent the Sidecar JVM to not be able to > open more files when the ulimit has been reached -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18633) [Analytics] Add Caching of Node Settings to Improve Efficiency
[ https://issues.apache.org/jira/browse/CASSANDRA-18633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741759#comment-17741759 ] Dinesh Joshi commented on CASSANDRA-18633: -- +1, thanks for the patch! > [Analytics] Add Caching of Node Settings to Improve Efficiency > -- > > Key: CASSANDRA-18633 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18633 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > Currently, `CassandraClusterInfo` does not reuse results of a call to > `allNodeSettingsBlocking` from `Sidecar`. > We should improve efficiency by caching these results in order to prevent > multiple expensive cluster-wide calls. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[
https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737825#comment-17737825
]
Dinesh Joshi commented on CASSANDRA-18631:
--
+1, thanks.
> [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
> -
>
> Key: CASSANDRA-18631
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18631
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add the Release Audit Tool plugin to Cassandra Analytics to automate the
> {{check}} process and make it part of the regular Analytics build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-61) Add Release Audit Tool (RAT) plugin to Sidecar
[
https://issues.apache.org/jira/browse/CASSANDRASC-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737779#comment-17737779
]
Dinesh Joshi commented on CASSANDRASC-61:
-
+1, thanks.
> Add Release Audit Tool (RAT) plugin to Sidecar
> --
>
> Key: CASSANDRASC-61
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-61
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Add the Release Audit Tool plugin to Cassandra Sidecar to automate the
> {{check}} process and make it part of the regular Sidecar build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18574) [Analytics] Fix example documentation
[
https://issues.apache.org/jira/browse/CASSANDRA-18574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737394#comment-17737394
]
Dinesh Joshi commented on CASSANDRA-18574:
--
+1, thanks for the patch!
> [Analytics] Fix example documentation
> --
>
> Key: CASSANDRA-18574
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18574
> Project: Cassandra
> Issue Type: Improvement
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Low
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The documentation for the example job for Cassandra Analytics
> [link|https://github.com/apache/cassandra-analytics/blob/trunk/cassandra-analytics-core-example/README.md]
> configures Sidecar to use the local CCM cluster. This documentation is
> however broken since some feedback during the review of the Sidecar PR
> changed one of the yaml options from {{uploads_staging_dir}} to
> {{staging_dir}}.
> We need to update the documentation to reflect that change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-59) Expose JMX host and port from JMXClient
[ https://issues.apache.org/jira/browse/CASSANDRASC-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737393#comment-17737393 ] Dinesh Joshi commented on CASSANDRASC-59: - +1, thanks for the patch! > Expose JMX host and port from JMXClient > --- > > Key: CASSANDRASC-59 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-59 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > Many integrations require the JMX host and port configured for a given JMX > client. It is desired that this information is available in the > ICassandraDelegate. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-58) Support retries in Sidecar Client when MD5 checksum is mismatched
[ https://issues.apache.org/jira/browse/CASSANDRASC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737392#comment-17737392 ] Dinesh Joshi commented on CASSANDRASC-58: - +1, thanks for the patch! > Support retries in Sidecar Client when MD5 checksum is mismatched > - > > Key: CASSANDRASC-58 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-58 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > In rare occasions an SSTable upload will get corrupted during upload. Bit > flips are expected to occur occasionally while transmitting the SSTables from > the client to the server. The current behavior of the Sidecar Client in those > situations is to fail fast without any retries. > We want to support Sidecar Client retries when checksum mismatch occurs > during SSTable upload. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-53) [Sidecar Client] Allow unknown fields in the response
[
https://issues.apache.org/jira/browse/CASSANDRASC-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737391#comment-17737391
]
Dinesh Joshi commented on CASSANDRASC-53:
-
+1, thanks for the patch!
> [Sidecar Client] Allow unknown fields in the response
> -
>
> Key: CASSANDRASC-53
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-53
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> While testing CASSANDRASC-52 on the server side, the Sidecar client based off
> of {{trunk}} failed to deserialize the JSON payload with error
> {code:java}
> Caused by:
> o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException:
> Unrecognized field "sidecar" (class
> org.apache.cassandra.sidecar.common.NodeSettings), not marked as ignorable (2
> known properties: "releaseVersion", "partitioner"])
> at [Source:
> (byte[])"{"releaseVersion":"4.0.9-SNAPSHOT","partitioner":"org.apache.cassandra.dht.Murmur3Partitioner","sidecar":{"version":"1.0-SNAPSHOT"}}";
> line: 1, column: 107] (through reference chain:
> org.apache.cassandra.sidecar.common.NodeSettings["sidecar"])
> at
> o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61)
> at
> o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1132)
> {code}
> As we are evolving the code, we expect the API on the server side to evolve.
> The deployed clients need to tolerate these new fields in the response JSON
> payload to continue working correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-56) Create staging directory if it doesn't exists
[ https://issues.apache.org/jira/browse/CASSANDRASC-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737390#comment-17737390 ] Dinesh Joshi commented on CASSANDRASC-56: - +1, thanks for the patch! > Create staging directory if it doesn't exists > - > > Key: CASSANDRASC-56 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-56 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > During SSTable upload, the upload will fail if the configured staging > directory does not exist. When this occurs we must manually have to create > the directory, which increases the configuration toil. To improve the > experience, it is desired that Sidecar creates the staging directory if it > doesn't exist. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18600) [Analytics] Add NOTICE.txt in Cassandra Analytics
[
https://issues.apache.org/jira/browse/CASSANDRA-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737262#comment-17737262
]
Dinesh Joshi commented on CASSANDRA-18600:
--
[~bereng] what's the error that you're getting? There aren't any special
permissions for this repo. Can you ping me on ASF slack and we can look at it
together?
> [Analytics] Add NOTICE.txt in Cassandra Analytics
> --
>
> Key: CASSANDRA-18600
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18600
> Project: Cassandra
> Issue Type: Task
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Cassandra Analytics project is missing the {{NOTICE.txt}} file required
> for compliance with the ASF guidance
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-54) Add NOTICE.txt file
[ https://issues.apache.org/jira/browse/CASSANDRASC-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736349#comment-17736349 ] Dinesh Joshi commented on CASSANDRASC-54: - +1, thanks for the patch. > Add NOTICE.txt file > --- > > Key: CASSANDRASC-54 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-54 > Project: Sidecar for Apache Cassandra > Issue Type: Task > Components: Documentation >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > The Cassandra Sidecar project is missing the NOTICE.txt file required for > compliance with the ASF guidance -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18600) [Analytics] Add NOTICE.txt in Cassandra Analytics
[
https://issues.apache.org/jira/browse/CASSANDRA-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736348#comment-17736348
]
Dinesh Joshi commented on CASSANDRA-18600:
--
+1, thanks for the patch.
> [Analytics] Add NOTICE.txt in Cassandra Analytics
> --
>
> Key: CASSANDRA-18600
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18600
> Project: Cassandra
> Issue Type: Task
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Cassandra Analytics project is missing the {{NOTICE.txt}} file required
> for compliance with the ASF guidance
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18605) Cassandra Analytics - Adding support for TTL & Timestamps for bulk writes
[ https://issues.apache.org/jira/browse/CASSANDRA-18605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735882#comment-17735882 ] Dinesh Joshi commented on CASSANDRA-18605: -- +1, thanks for the patch! > Cassandra Analytics - Adding support for TTL & Timestamps for bulk writes > - > > Key: CASSANDRA-18605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18605 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: Jyothsna Konisa >Assignee: Jyothsna Konisa >Priority: Normal > Time Spent: 50m > Remaining Estimate: 0h > > In this patch we are adding support for Spark Bulk Writer writes with TTL & > Timestamp. TTL/ Timestamp can be constant where all rows in the RDD are > written with same TTL/Timestamp or per row based where each row has a > corresponding TTL/Timestamp present in a separate column in the RDD. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18599) Cassandra Analytics - Upgrade to use JUnit 5
[ https://issues.apache.org/jira/browse/CASSANDRA-18599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735880#comment-17735880 ] Dinesh Joshi commented on CASSANDRA-18599: -- +1, thanks for the patch. > Cassandra Analytics - Upgrade to use JUnit 5 > > > Key: CASSANDRA-18599 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18599 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > For future work, we’d like to use some features only available in JUnit 5 > (TestTemplates being the immediate need). > Upgrade cassandra-analytics dependencies to JUnit 5 and fix any test issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-57) Remove RESTEasy
[ https://issues.apache.org/jira/browse/CASSANDRASC-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735879#comment-17735879 ] Dinesh Joshi commented on CASSANDRASC-57: - +1, thanks for the patch. > Remove RESTEasy > --- > > Key: CASSANDRASC-57 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-57 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > RESTEasy has been replaced by vertx handlers in the project. Additionally, > Vertx offers OpenAPI support natively [1], which can be considered for future > improvements to the Sidecar project. > [1] https://vertx.io/docs/vertx-web-openapi/java/ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-51) Leverage in-jvm dtest framework for improved Sidecar testing
[ https://issues.apache.org/jira/browse/CASSANDRASC-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732783#comment-17732783 ] Dinesh Joshi commented on CASSANDRASC-51: - +1, thanks for the patch. > Leverage in-jvm dtest framework for improved Sidecar testing > > > Key: CASSANDRASC-51 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-51 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Labels: pull-request-available > > Today, the sidecar uses TestContainers > ([testcontainers.org|http://testcontainers.org/]) and a single-node, > single-data-directory Cassandra instance for all of its tests. While this has > worked well so far, it is incapable of doing some of the more complex testing > necessary to validate new endpoints and requires Docker locally and special > CircleCI setup for CI builds. > > Now that the in-jvm dtest framework supports JMX, we can leverage it to do > our testing in stead. It will enable us to do multi-node testing and exercise > code paths under conditions like joining/leaving/moving nodes, which is > critical for correctness. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-49) Automate adding ApacheV2 license header
[ https://issues.apache.org/jira/browse/CASSANDRASC-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732285#comment-17732285 ] Dinesh Joshi commented on CASSANDRASC-49: - +1, thank you for the patch! > Automate adding ApacheV2 license header > --- > > Key: CASSANDRASC-49 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-49 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Documentation >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > > Enhance the gradle build to set the copyright profile in the Intellij project > to add the ApacheV2 license header on creating new files. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17732195#comment-17732195 ] Dinesh Joshi commented on CASSANDRASC-52: - +1, thanks for the patch. > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18578) [Analytics] Circle CI Configuration for Cassandra Analytics
[ https://issues.apache.org/jira/browse/CASSANDRA-18578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731073#comment-17731073 ] Dinesh Joshi commented on CASSANDRA-18578: -- +1 LGTM. > [Analytics] Circle CI Configuration for Cassandra Analytics > --- > > Key: CASSANDRA-18578 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18578 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > > We need to add the CircleCI configuration to build and test the Cassandra > Analytics library. We need to test against all 4 profiles: > * cassandra-analytics-core-spark2-2.11-jdk8 > * cassandra-analytics-core-spark2-2.12-jdk8 > * cassandra-analytics-core-spark3-2.12-jdk11 > * cassandra-analytics-core-spark3-2.13-jdk11 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18545) [Analytics] Abstract mTLS provisioning via a SecretsProvider
[
https://issues.apache.org/jira/browse/CASSANDRA-18545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728988#comment-17728988
]
Dinesh Joshi commented on CASSANDRA-18545:
--
+1, thanks for the patch!
> [Analytics] Abstract mTLS provisioning via a SecretsProvider
>
>
> Key: CASSANDRA-18545
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18545
> Project: Cassandra
> Issue Type: Task
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>
> This enhancement allows us to abstract the mTLS secrets provisioning through
> a {{SecretsProvider}} interface. This will allow custom implementations of
> the {{SecretsProvider}} to be able to hook into the secrets provisioning. We
> need to provide a default implementation {{SslConfigSecretsProvider}} which
> provides secrets via the {{SslConfig}} which is parsed from the reader
> options.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18545) [Analytics] Abstract mTLS provisioning via a SecretsProvider
[
https://issues.apache.org/jira/browse/CASSANDRA-18545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dinesh Joshi updated CASSANDRA-18545:
-
Reviewers: Dinesh Joshi, Yifan Cai
Status: Review In Progress (was: Patch Available)
> [Analytics] Abstract mTLS provisioning via a SecretsProvider
>
>
> Key: CASSANDRA-18545
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18545
> Project: Cassandra
> Issue Type: Task
> Components: Analytics Library
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>
> This enhancement allows us to abstract the mTLS secrets provisioning through
> a {{SecretsProvider}} interface. This will allow custom implementations of
> the {{SecretsProvider}} to be able to hook into the secrets provisioning. We
> need to provide a default implementation {{SslConfigSecretsProvider}} which
> provides secrets via the {{SslConfig}} which is parsed from the reader
> options.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728987#comment-17728987 ] Dinesh Joshi commented on CASSANDRASC-52: - thanks for the patch Yuriy. Left some comments on the PR. > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-50) Remove deprecate health endpoint containing instance segment
[
https://issues.apache.org/jira/browse/CASSANDRASC-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728986#comment-17728986
]
Dinesh Joshi commented on CASSANDRASC-50:
-
+1, thanks for the patch!
> Remove deprecate health endpoint containing instance segment
>
>
> Key: CASSANDRASC-50
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-50
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> The Cassandra Health endpoint containing the instance segment in the path
> usage is deprecated. This endpoint is currently unused and it is replaced by
> the health endpoint with the {{instanceId}} query string parameter. Since the
> {{instanceId}} is optional we move the path param (mandatory) to the query
> param (optional).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-50) Remove deprecate health endpoint containing instance segment
[
https://issues.apache.org/jira/browse/CASSANDRASC-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dinesh Joshi updated CASSANDRASC-50:
Reviewers: Dinesh Joshi, Yifan Cai
Status: Review In Progress (was: Needs Committer)
> Remove deprecate health endpoint containing instance segment
>
>
> Key: CASSANDRASC-50
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-50
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> The Cassandra Health endpoint containing the instance segment in the path
> usage is deprecated. This endpoint is currently unused and it is replaced by
> the health endpoint with the {{instanceId}} query string parameter. Since the
> {{instanceId}} is optional we move the path param (mandatory) to the query
> param (optional).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRASC-52: Test and Documentation Plan: Unit testing Status: Patch Available (was: Open) > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRASC-52: Status: Review In Progress (was: Patch Available) > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18554) mTLS based client and internode authenticators
[ https://issues.apache.org/jira/browse/CASSANDRA-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18554: - Authors: Dinesh Joshi, Jyothsna Konisa (was: Jyothsna Konisa) > mTLS based client and internode authenticators > -- > > Key: CASSANDRA-18554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18554 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Authorization >Reporter: Jyothsna Konisa >Assignee: Jyothsna Konisa >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently doesn't have any certificate based authenticator for both > client connections and internode connections. If one wants to use certificate > based authentication protocol like TLS, in which clients send their > certificates for the TLS handshake, we can leverage the information from the > client certificate to identify a client. Using this authentication mechanism > one can avoid the pain of password generations, sharing and rotation. > Introducing following certificate based mTLS authenticators for internode and > client connections > MutualTlsAuthenticator (client authentication) > MutualTlsInternodeAuthenticator (internode authentication) > MutualTlsWithPasswordFallbackAuthenticator (for optional mode operation for > client authentication) > An implementation of MutualTlsCertificateValidator called > SpiffeCertificateValidator whose identity is SPIFFE that is embedded in SAN > of the client certificate. One can implement their own CertificateValidator > to match their needs and configure it in Cassandra.yaml -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18554) mTLS based client and internode authenticators
[ https://issues.apache.org/jira/browse/CASSANDRA-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18554: - Reviewers: Dinesh Joshi, Jon Meredith, Yifan Cai (was: Blake Eggleston, Dinesh Joshi, Jon Meredith, Yifan Cai) Status: Review In Progress (was: Patch Available) > mTLS based client and internode authenticators > -- > > Key: CASSANDRA-18554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18554 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Authorization >Reporter: Jyothsna Konisa >Assignee: Jyothsna Konisa >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently doesn't have any certificate based authenticator for both > client connections and internode connections. If one wants to use certificate > based authentication protocol like TLS, in which clients send their > certificates for the TLS handshake, we can leverage the information from the > client certificate to identify a client. Using this authentication mechanism > one can avoid the pain of password generations, sharing and rotation. > Introducing following certificate based mTLS authenticators for internode and > client connections > MutualTlsAuthenticator (client authentication) > MutualTlsInternodeAuthenticator (internode authentication) > MutualTlsWithPasswordFallbackAuthenticator (for optional mode operation for > client authentication) > An implementation of MutualTlsCertificateValidator called > SpiffeCertificateValidator whose identity is SPIFFE that is embedded in SAN > of the client certificate. One can implement their own CertificateValidator > to match their needs and configure it in Cassandra.yaml -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi reassigned CASSANDRASC-52: --- Assignee: Yuriy Semchyshyn (was: Dinesh Joshi) > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRASC-52: Reviewers: Dinesh Joshi, Yifan Cai > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18541) AUTH requests use too much resources
[ https://issues.apache.org/jira/browse/CASSANDRA-18541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724990#comment-17724990 ] Dinesh Joshi commented on CASSANDRA-18541: -- Can you provide steps to repro the issue? The CPU graphs are not entirely actionable on their own. If possible you can even capture flame graphs on one of the Cassandra nodes using the [async profiler|https://github.com/async-profiler/async-profiler]. > AUTH requests use too much resources > > > Key: CASSANDRA-18541 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18541 > Project: Cassandra > Issue Type: Bug >Reporter: Yury Vidineev >Priority: Normal > Attachments: Screenshot_20230520_000633.png, > Screenshot_20230520_000654.png > > > Hello. I see unexpected CPU usage in a rare situation that may be worth > digging into. > We have C* 4.0.9 on Debian running on Java 11.0.18. > It's a small cluster of 3 nodes on commodity hardware (6 cores CPU, 32 Gb > RAM, 2 x 512 Gb SSD NVME). > This ring has about 35 clients using Datastax Java Driver for Apache > Cassandra. > In the driver connection settings, we use the following: > CONNECTION_POOL_LOCAL_SIZE = 400 > CONNECTION_POOL_REMOTE_SIZE = 100 > > And for some reason, from time to time, it causes hundreds of AUTH requests > per second that leads to an enormous CPU usage. > And yes, it's easy not to use these settings in the driver, leaving defaults > that don't produce such an amount of AUTHs. But isn't it weird that ~150 AUTH > rps consume ~1200% CPU? > Please see attached graphs. > I have the following in the settings: > authenticator: PasswordAuthenticator > authorizer: CassandraAuthorizer > roles_validity_in_ms: 60 > permissions_validity_in_ms: 60 > credentials_validity_in_ms: 60 > Please let me know if I can provide any other necessary information. > Thanks for your work. Cassandra is amazing :) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16222) CEP-28: Reading and Writing Cassandra Data with Spark Bulk Analytics
[ https://issues.apache.org/jira/browse/CASSANDRA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724446#comment-17724446 ] Dinesh Joshi commented on CASSANDRA-16222: -- Committed [here|https://github.com/apache/cassandra-sidecar/commit/38cdacb2e7418e2aefbcffb1754dcd324c46028d] and [here|https://github.com/apache/cassandra-analytics/commit/1633cd9c6c3d88d5c66825fab76a369266509f7e]. Thanks, everybody. > CEP-28: Reading and Writing Cassandra Data with Spark Bulk Analytics > > > Key: CASSANDRA-16222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16222 > Project: Cassandra > Issue Type: New Feature > Components: Tool/external >Reporter: James Berragan >Assignee: Francisco Guerrero >Priority: Normal > Fix For: NA > > Attachments: sparkbulkreader.patch > > > *Description:* > This ticket introduces the Spark-Cassandra Bulk Analytics library and > associated Cassandra Sidecar endpoints. > > Please see > [CEP-28|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-28%3A+Reading+and+Writing+Cassandra+Data+with+Spark+Bulk+Analytics] > for more details, motivation, and available source code links. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16222) CEP-28: Reading and Writing Cassandra Data with Spark Bulk Analytics
[ https://issues.apache.org/jira/browse/CASSANDRA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-16222: - Source Control Link: https://github.com/apache/cassandra-analytics/commit/1633cd9c6c3d88d5c66825fab76a369266509f7e Resolution: Fixed Status: Resolved (was: Ready to Commit) > CEP-28: Reading and Writing Cassandra Data with Spark Bulk Analytics > > > Key: CASSANDRA-16222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16222 > Project: Cassandra > Issue Type: New Feature > Components: Tool/external >Reporter: James Berragan >Assignee: Francisco Guerrero >Priority: Normal > Fix For: NA > > Attachments: sparkbulkreader.patch > > > *Description:* > This ticket introduces the Spark-Cassandra Bulk Analytics library and > associated Cassandra Sidecar endpoints. > > Please see > [CEP-28|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-28%3A+Reading+and+Writing+Cassandra+Data+with+Spark+Bulk+Analytics] > for more details, motivation, and available source code links. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16222) CEP-28: Reading and Writing Cassandra Data with Spark Bulk Analytics
[ https://issues.apache.org/jira/browse/CASSANDRA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-16222: - Status: Ready to Commit (was: Review In Progress) +1 > CEP-28: Reading and Writing Cassandra Data with Spark Bulk Analytics > > > Key: CASSANDRA-16222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16222 > Project: Cassandra > Issue Type: New Feature > Components: Tool/external >Reporter: James Berragan >Assignee: Francisco Guerrero >Priority: Normal > Fix For: NA > > Attachments: sparkbulkreader.patch > > > *Description:* > This ticket introduces the Spark-Cassandra Bulk Analytics library and > associated Cassandra Sidecar endpoints. > > Please see > [CEP-28|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-28%3A+Reading+and+Writing+Cassandra+Data+with+Spark+Bulk+Analytics] > for more details, motivation, and available source code links. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18537) Add JMX utility class to in-jvm dtest to ease development of new tests using JMX
[ https://issues.apache.org/jira/browse/CASSANDRA-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724135#comment-17724135 ] Dinesh Joshi commented on CASSANDRA-18537: -- Committed, thanks for the patch! > Add JMX utility class to in-jvm dtest to ease development of new tests using > JMX > > > Key: CASSANDRA-18537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18537 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Priority: Normal > Fix For: NA > > > While reviewing CASSANDRA-18511, some repetitive code was identified across > the 4 branches, and 2 different tests, that would also be repeated for any > new usages of the JMX support in the in-jvm dtest framework. Therefore, a > utility class should be added to the dtest-api's `shared` package that will > simplify some of this repetitive and error-prone code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18537) Add JMX utility class to in-jvm dtest to ease development of new tests using JMX
[ https://issues.apache.org/jira/browse/CASSANDRA-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18537: - Fix Version/s: NA Source Control Link: https://github.com/apache/cassandra-in-jvm-dtest-api/commit/1e3bc4c3b34eae563547899645bfb3f0a1948c79 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Add JMX utility class to in-jvm dtest to ease development of new tests using > JMX > > > Key: CASSANDRA-18537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18537 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Priority: Normal > Fix For: NA > > > While reviewing CASSANDRA-18511, some repetitive code was identified across > the 4 branches, and 2 different tests, that would also be repeated for any > new usages of the JMX support in the in-jvm dtest framework. Therefore, a > utility class should be added to the dtest-api's `shared` package that will > simplify some of this repetitive and error-prone code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18537) Add JMX utility class to in-jvm dtest to ease development of new tests using JMX
[ https://issues.apache.org/jira/browse/CASSANDRA-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18537: - Status: Ready to Commit (was: Review In Progress) > Add JMX utility class to in-jvm dtest to ease development of new tests using > JMX > > > Key: CASSANDRA-18537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18537 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Priority: Normal > > While reviewing CASSANDRA-18511, some repetitive code was identified across > the 4 branches, and 2 different tests, that would also be repeated for any > new usages of the JMX support in the in-jvm dtest framework. Therefore, a > utility class should be added to the dtest-api's `shared` package that will > simplify some of this repetitive and error-prone code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18537) Add JMX utility class to in-jvm dtest to ease development of new tests using JMX
[ https://issues.apache.org/jira/browse/CASSANDRA-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724072#comment-17724072 ] Dinesh Joshi commented on CASSANDRA-18537: -- +1, thanks for the patch. > Add JMX utility class to in-jvm dtest to ease development of new tests using > JMX > > > Key: CASSANDRA-18537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18537 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Priority: Normal > > While reviewing CASSANDRA-18511, some repetitive code was identified across > the 4 branches, and 2 different tests, that would also be repeated for any > new usages of the JMX support in the in-jvm dtest framework. Therefore, a > utility class should be added to the dtest-api's `shared` package that will > simplify some of this repetitive and error-prone code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18537) Add JMX utility class to in-jvm dtest to ease development of new tests using JMX
[ https://issues.apache.org/jira/browse/CASSANDRA-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18537: - Status: Review In Progress (was: Patch Available) > Add JMX utility class to in-jvm dtest to ease development of new tests using > JMX > > > Key: CASSANDRA-18537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18537 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Priority: Normal > > While reviewing CASSANDRA-18511, some repetitive code was identified across > the 4 branches, and 2 different tests, that would also be repeated for any > new usages of the JMX support in the in-jvm dtest framework. Therefore, a > utility class should be added to the dtest-api's `shared` package that will > simplify some of this repetitive and error-prone code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18537) Add JMX utility class to in-jvm dtest to ease development of new tests using JMX
[ https://issues.apache.org/jira/browse/CASSANDRA-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18537: - Reviewers: Dinesh Joshi, Jon Meredith (was: Jon Meredith) > Add JMX utility class to in-jvm dtest to ease development of new tests using > JMX > > > Key: CASSANDRA-18537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18537 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Priority: Normal > > While reviewing CASSANDRA-18511, some repetitive code was identified across > the 4 branches, and 2 different tests, that would also be repeated for any > new usages of the JMX support in the in-jvm dtest framework. Therefore, a > utility class should be added to the dtest-api's `shared` package that will > simplify some of this repetitive and error-prone code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18511) Add support for JMX in the in-jvm dtest framework
[ https://issues.apache.org/jira/browse/CASSANDRA-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723320#comment-17723320 ] Dinesh Joshi commented on CASSANDRA-18511: -- dtest-api 0.0.14 is released. > Add support for JMX in the in-jvm dtest framework > - > > Key: CASSANDRA-18511 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18511 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Labels: pull-request-available > Fix For: 3.11.x, 4.0.x, 4.1.x, 5.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > In many cases, it would be useful to be able to enable JMX endpoints within > the in-jvm dtest framework, including the existing JMX Getter test, which > used to simply spin up a JMX registry and then leave it running. There are > quite a few JMX-related functions that don’t have tests today, and some > external usages of the in-jvm dtest framework could also benefit from > exposing JMX like we did Native before. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18511) Add support for JMX in the in-jvm dtest framework
[ https://issues.apache.org/jira/browse/CASSANDRA-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18511: - Reviewers: Alex Petrov > Add support for JMX in the in-jvm dtest framework > - > > Key: CASSANDRA-18511 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18511 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Labels: pull-request-available > Fix For: 3.11.x, 4.0.x, 4.1.x, 5.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > In many cases, it would be useful to be able to enable JMX endpoints within > the in-jvm dtest framework, including the existing JMX Getter test, which > used to simply spin up a JMX registry and then leave it running. There are > quite a few JMX-related functions that don’t have tests today, and some > external usages of the in-jvm dtest framework could also benefit from > exposing JMX like we did Native before. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18511) Add support for JMX in the in-jvm dtest framework
[ https://issues.apache.org/jira/browse/CASSANDRA-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18511: - Status: Ready to Commit (was: Review In Progress) > Add support for JMX in the in-jvm dtest framework > - > > Key: CASSANDRA-18511 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18511 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Labels: pull-request-available > Fix For: 3.11.x, 4.0.x, 4.1.x, 5.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > In many cases, it would be useful to be able to enable JMX endpoints within > the in-jvm dtest framework, including the existing JMX Getter test, which > used to simply spin up a JMX registry and then leave it running. There are > quite a few JMX-related functions that don’t have tests today, and some > external usages of the in-jvm dtest framework could also benefit from > exposing JMX like we did Native before. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18511) Add support for JMX in the in-jvm dtest framework
[ https://issues.apache.org/jira/browse/CASSANDRA-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18511: - Status: Review In Progress (was: Patch Available) > Add support for JMX in the in-jvm dtest framework > - > > Key: CASSANDRA-18511 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18511 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Labels: pull-request-available > Fix For: 3.11.x, 4.0.x, 4.1.x, 5.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > In many cases, it would be useful to be able to enable JMX endpoints within > the in-jvm dtest framework, including the existing JMX Getter test, which > used to simply spin up a JMX registry and then leave it running. There are > quite a few JMX-related functions that don’t have tests today, and some > external usages of the in-jvm dtest framework could also benefit from > exposing JMX like we did Native before. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18472) Docker images can no longer be built due to python2.7
[
https://issues.apache.org/jira/browse/CASSANDRA-18472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715187#comment-17715187
]
Dinesh Joshi commented on CASSANDRA-18472:
--
It would have been great if we would've had cqlsh as a separate repo /
sub-project. It would be easy to avoid issues such as these. Having Python 2
dependency for 3.0 and 3.11 is not great.
> Docker images can no longer be built due to python2.7
> -
>
> Key: CASSANDRA-18472
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18472
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
>
> {noformat}
> => [linux/amd64 35/56] WORKDIR /home/cassandra
>
> 0.1s
> => [linux/amd64 36/56] RUN echo 'export ANT_HOME=/usr/share/ant' >>
> /home/cassandra/.bashrc && echo 'export
> JAVA8_HOME=/usr/lib/jvm/java-8-openjdk-$(dpkg --print-architecture)' >>
> /home/cassandra/.b 0.2s
> => ERROR [linux/amd64 37/56] RUN virtualenv --python=python2.7 env2.7
>
> 0.5s
> --
> > [linux/amd64 37/56] RUN virtualenv --python=python2.7 env2.7:
> #100 0.424 RuntimeError: failed to find interpreter for Builtin discover of
> python_spec='python2.7'
> --
> ubuntu2004_j11.docker:128
>
> 126 | # included in the base image, the compiled objects are not updated
> by pip at run time, which can
> 127 | # cause errors if the tests rely on new driver functionality or
> bug fixes.
> 128 | >>> RUN virtualenv --python=python2.7 env2.7
> 129 | RUN chmod +x env2.7/bin/activate
> 130 | RUN /bin/bash -c "export CASS_DRIVER_NO_CYTHON=1
> CASS_DRIVER_NO_EXTENSIONS=1 && source ~/env2.7/bin/activate && pip2 install
> --upgrade pip && pip2 install -r /opt/requirements.txt && pip2 freeze --user"
>
> error: failed to solve: rpc error: code = Unknown desc = process "/bin/sh -c
> virtualenv --python=python2.7 env2.7" did not complete successfully: exit
> code: 1
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18373) Node Draining Should Abort All Current SSTables Imports
[ https://issues.apache.org/jira/browse/CASSANDRA-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708608#comment-17708608 ] Dinesh Joshi commented on CASSANDRA-18373: -- Thanks for the patch [~semchyshyn]. +1. Please address minor nits before committing. > Node Draining Should Abort All Current SSTables Imports > --- > > Key: CASSANDRA-18373 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18373 > Project: Cassandra > Issue Type: Improvement > Components: Local/Startup and Shutdown >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 1h > Remaining Estimate: 0h > > SS tables imports that will end up being ignored due to the node draining > should fail instead of succeeding. > Each active SS tables import should periodically check for the node status > and see whether or not it is `DRAINING`. > In case the node starts draining the import should abort immediately by > throwing an `InterruptedException`. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18373) Node Draining Should Abort All Current SSTables Imports
[ https://issues.apache.org/jira/browse/CASSANDRA-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-18373: - Reviewers: Dinesh Joshi, Yifan Cai (was: Yifan Cai) > Node Draining Should Abort All Current SSTables Imports > --- > > Key: CASSANDRA-18373 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18373 > Project: Cassandra > Issue Type: Improvement > Components: Local/Startup and Shutdown >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 1h > Remaining Estimate: 0h > > SS tables imports that will end up being ignored due to the node draining > should fail instead of succeeding. > Each active SS tables import should periodically check for the node status > and see whether or not it is `DRAINING`. > In case the node starts draining the import should abort immediately by > throwing an `InterruptedException`. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-48) Add an endpoint that gives information about the release version & partitioner name of a node
[
https://issues.apache.org/jira/browse/CASSANDRASC-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635990#comment-17635990
]
Dinesh Joshi commented on CASSANDRASC-48:
-
+1 thanks for the patch!
> Add an endpoint that gives information about the release version &
> partitioner name of a node
> -
>
> Key: CASSANDRASC-48
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-48
> Project: Sidecar for Apache Cassandra
> Issue Type: New Feature
> Components: Rest API
>Reporter: Jyothsna Konisa
>Assignee: Jyothsna Konisa
>Priority: Normal
> Labels: pull-request-available
>
> Add a new endpoint in sidecar that gives information about the release
> version & partitioner name of a node.
> GET /api/v1/cassandra/status
> GET /api/v1/cassandra/status?instanceId={id}
> Response
> {
> releaseVersion: "4.2-SNAPSHOT",
> partitioner: "org.apache.cassandra.dht.Murmur3Partitioner"
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-47) Introduce JMX foundation in Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635574#comment-17635574 ] Dinesh Joshi commented on CASSANDRASC-47: - +1, lgtm. thanks for the patch. > Introduce JMX foundation in Sidecar > --- > > Key: CASSANDRASC-47 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-47 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > Currently, Sidecar supports CQL access to the Cassandra instances it manages. > However, JMX support is not available at the moment. We need to introduce the > JMX foundation in Sidecar to support additional interactions with Cassandra > instances that are not available through the CQL protocol. > This ticket is intended for introducing the JMX foundation, that can later be > used for adding new functionality to Sidecar interactions with Cassandra > through JMX. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-47) Introduce JMX foundation in Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-47?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRASC-47: Reviewers: Dinesh Joshi, Yifan Cai (was: Yifan Cai) > Introduce JMX foundation in Sidecar > --- > > Key: CASSANDRASC-47 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-47 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > Currently, Sidecar supports CQL access to the Cassandra instances it manages. > However, JMX support is not available at the moment. We need to introduce the > JMX foundation in Sidecar to support additional interactions with Cassandra > instances that are not available through the CQL protocol. > This ticket is intended for introducing the JMX foundation, that can later be > used for adding new functionality to Sidecar interactions with Cassandra > through JMX. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-48) Add an endpoint that gives information about the release version & partitioner name of a node
[
https://issues.apache.org/jira/browse/CASSANDRASC-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dinesh Joshi updated CASSANDRASC-48:
Reviewers: Dinesh Joshi, Francisco Guerrero, Yifan Cai (was: Francisco
Guerrero, Yifan Cai)
> Add an endpoint that gives information about the release version &
> partitioner name of a node
> -
>
> Key: CASSANDRASC-48
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-48
> Project: Sidecar for Apache Cassandra
> Issue Type: New Feature
> Components: Rest API
>Reporter: Jyothsna Konisa
>Assignee: Jyothsna Konisa
>Priority: Normal
> Labels: pull-request-available
>
> Add a new endpoint in sidecar that gives information about the release
> version & partitioner name of a node.
> GET /api/v1/cassandra/status
> GET /api/v1/cassandra/status?instanceId={id}
> Response
> {
> releaseVersion: "4.2-SNAPSHOT",
> partitioner: "org.apache.cassandra.dht.Murmur3Partitioner"
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17870) nodetool/rebuild: Add flag to exclude nodes from local datacenter
[ https://issues.apache.org/jira/browse/CASSANDRA-17870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-17870: - Reviewers: Dinesh Joshi, Yifan Cai (was: Yifan Cai) > nodetool/rebuild: Add flag to exclude nodes from local datacenter > - > > Key: CASSANDRA-17870 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17870 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > Attachments: fix_nodetool_rebuild.diff > > Time Spent: 1h 20m > Remaining Estimate: 0h > > During expansion by Dc, when we issue nodetool/rebuild from new dc to rebuild > the data from other DCs. If src-dc is not passed explicitly, then C* tries to > rebuild the data from the same (new dc) dc. > We don’t exclude other nodes in the same DC. Only down sources and the local > node itself are excluded. > ``` > // We're _always_ filtering out a local node and down sources > addSourceFilter(new > RangeStreamer.FailureDetectorSourceFilter(failureDetector)); > addSourceFilter(new RangeStreamer.ExcludeLocalNodeFilter()); > ``` > We should fix nodetool/rebuild to exclude the local DC (from where we’re > executing the command) while issuing nodetool/rebuild without passing src dc > > Example: > in a 3 DC cluster, > ks1 has DC1, DC2 > ks2 has DC1, DC2, DC3 > ks3 has DC2 > now, we add a new DC [DC4] and configured it to all 3 keyspaces. > if we run rebuild with src DC as DC1, ks3 will fail as it does not have DC1. > Now, without src DC, the expectation is rebuild would auto pick up DCs for > each keyspace (let's say ks1: DC1, ks2: DC1, ks3: DC2) and would never fail > due to under-replicated keyspaces. > The issue with this approach (without src dc) is that, DC4 is getting picked > up during rebuild (as src), but DC4 does not have any data yet! > so, with the patch (ignore local dc flag), DC4 can be filtered out and let > the database pick up the right dc for each keyspace [from existing 3 DCs]. > -- this is what is the expectation after the patch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
