Re: [PR] JAVA-3118: Add support for vector data type in Schema Builder, QueryBuilder [cassandra-java-driver]

2024-06-11 Thread via GitHub
michaelsembwever commented on PR #1931: URL: https://github.com/apache/cassandra-java-driver/pull/1931#issuecomment-2161206094 i can't get this to compile ``` [ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.10.5:check (default) on project java-driver-query-builder: The

Re: [PR] JAVA-3118: Add support for vector data type in Schema Builder, QueryBuilder [cassandra-java-driver]

2024-06-11 Thread via GitHub
michaelsembwever commented on PR #1931: URL: https://github.com/apache/cassandra-java-driver/pull/1931#issuecomment-2161537686 Is there a separate ticket for vector similarity functions ? https://cassandra.apache.org/doc/latest/cassandra/developing/cql/functions.html#vector-similarity-f

Re: [PR] JAVA-3051: Memory leak [cassandra-java-driver]

2024-06-12 Thread via GitHub
absurdfarce commented on code in PR #1743: URL: https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1637559826 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/DefaultLoadBalancingPolicy.java: ## @@ -96,14 +100,39 @@ public class Defau

Re: [PR] JAVA-3051: Memory leak [cassandra-java-driver]

2024-06-12 Thread via GitHub
absurdfarce commented on code in PR #1743: URL: https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1637564082 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/DefaultLoadBalancingPolicy.java: ## @@ -96,14 +100,39 @@ public class Defau

Re: [PR] JAVA-3051: Memory leak [cassandra-java-driver]

2024-06-13 Thread via GitHub
absurdfarce commented on code in PR #1743: URL: https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1638440588 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/DefaultLoadBalancingPolicy.java: ## @@ -96,14 +100,39 @@ public class Defau

[PR] JAVA-3094: Fix decrement query error [cassandra-java-driver]

2024-06-14 Thread via GitHub
KSH-code opened a new pull request, #1686: URL: https://github.com/apache/cassandra-java-driver/pull/1686 If decrement with a negative value, then the query is made like `COLUMN = COLUMN--value`. so it can occur error because, double dashes (--) is used for comment. -- This is an automat

Re: [PR] JAVA-3094: Fix decrement query error [cassandra-java-driver]

2024-06-14 Thread via GitHub
KSH-code commented on PR #1686: URL: https://github.com/apache/cassandra-java-driver/pull/1686#issuecomment-2167657716 Can anybody check this again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] JAVA-3051: Memory leak [cassandra-java-driver]

2024-06-14 Thread via GitHub
SiyaoIsHiding commented on code in PR #1743: URL: https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1640458423 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/NodeStateEvent.java: ## @@ -53,14 +55,19 @@ public static NodeStateEvent remov

Re: [PR] JAVA-3051: Memory leak [cassandra-java-driver]

2024-06-17 Thread via GitHub
SiyaoIsHiding commented on code in PR #1743: URL: https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1643496542 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/DefaultLoadBalancingPolicy.java: ## @@ -274,40 +303,23 @@ protected boole

Re: [PR] Limit calls to Conversions.resolveExecutionProfile [cassandra-java-driver]

2024-06-17 Thread via GitHub
absurdfarce commented on code in PR #1623: URL: https://github.com/apache/cassandra-java-driver/pull/1623#discussion_r1643368749 ## core/src/main/java/com/datastax/oss/driver/internal/core/cql/Conversions.java: ## @@ -543,21 +543,44 @@ public static boolean resolveIdempotence(R

Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]

2024-06-17 Thread via GitHub
absurdfarce commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2174565098 A quick status update here: there's some overlap between the changes in this PR and some changes being proposed in @chibenwa's [PR](https://github.com/apache/cassandra-

[PR] CASSANDRA-19716: Invalid mapping when timestamp is used as a partitio… [cassandra-analytics]

2024-06-17 Thread via GitHub
frankgh opened a new pull request, #60: URL: https://github.com/apache/cassandra-analytics/pull/60 …n key during bulk writes Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRA-19716 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] CASSANDRA-19716: Invalid mapping when timestamp is used as a partitio… [cassandra-analytics]

2024-06-17 Thread via GitHub
yifan-c commented on code in PR #60: URL: https://github.com/apache/cassandra-analytics/pull/60#discussion_r1643623184 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/schema/TimestampType.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Softw

Re: [PR] CASSANDRA-19716: Invalid mapping when timestamp is used as a partitio… [cassandra-analytics]

2024-06-17 Thread via GitHub
frankgh commented on code in PR #60: URL: https://github.com/apache/cassandra-analytics/pull/60#discussion_r1643695104 ## cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/SparkTestUtils.java: ## @@ -167,21 +173,27 @@ public SparkConf defaultSpa

Re: [PR] Limit calls to Conversions.resolveExecutionProfile [cassandra-java-driver]

2024-06-18 Thread via GitHub
chibenwa commented on code in PR #1623: URL: https://github.com/apache/cassandra-java-driver/pull/1623#discussion_r1644169514 ## core/src/main/java/com/datastax/oss/driver/internal/core/cql/CqlRequestHandler.java: ## @@ -167,7 +168,8 @@ protected CqlRequestHandler( this.se

Re: [PR] Limit calls to Conversions.resolveExecutionProfile [cassandra-java-driver]

2024-06-18 Thread via GitHub
chibenwa commented on code in PR #1623: URL: https://github.com/apache/cassandra-java-driver/pull/1623#discussion_r1644181496 ## core/src/main/java/com/datastax/oss/driver/internal/core/cql/Conversions.java: ## @@ -543,21 +543,44 @@ public static boolean resolveIdempotence(Requ

Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]

2024-06-18 Thread via GitHub
SiyaoIsHiding commented on code in PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1644773185 ## core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java: ## @@ -46,28 +47,46 @@ default void onSuccess( @NonNull

Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]

2024-06-18 Thread via GitHub
ajweave commented on code in PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1644818928 ## core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java: ## @@ -46,28 +47,46 @@ default void onSuccess( @NonNull Driver

Re: [PR] Update com.github.jnr:jnr-posix to 3.1.18 to avoid M1 docker crash [cassandra-java-driver]

2024-06-21 Thread via GitHub
codefromthecrypt closed pull request #1904: Update com.github.jnr:jnr-posix to 3.1.18 to avoid M1 docker crash URL: https://github.com/apache/cassandra-java-driver/pull/1904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] JAVA-3051: Memory leak [cassandra-java-driver]

2024-06-22 Thread via GitHub
SiyaoIsHiding commented on code in PR #1743: URL: https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1649462101 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/NodeStateEvent.java: ## @@ -53,14 +55,19 @@ public static NodeStateEvent remov

Re: [PR] Limit calls to Conversions.resolveExecutionProfile [cassandra-java-driver]

2024-06-23 Thread via GitHub
absurdfarce commented on PR #1623: URL: https://github.com/apache/cassandra-java-driver/pull/1623#issuecomment-2185396040 Agree with @tolbertam; I'm pretty pleased with where this landed. I just kicked off a Jenkins build to make sure there aren't any unexpected test regressions or anythi

Re: [PR] Limit calls to Conversions.resolveExecutionProfile [cassandra-java-driver]

2024-06-23 Thread via GitHub
absurdfarce commented on PR #1623: URL: https://github.com/apache/cassandra-java-driver/pull/1623#issuecomment-2185525517 Bah, build failed due to a code formatting issue. @chibenwa can you run the following: ``` mvn com.coveo:fmt-maven-plugin:format ``` and commit the

Re: [PR] Add ExecutionInfo to RequestTracker methods [cassandra-java-driver]

2024-07-02 Thread via GitHub
lukasz-antoniak commented on PR #1640: URL: https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2191509703 @ajweave, @tolbertam, I have tried to solve my [comments](https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2135352720) and submitted PR to And

[PR] Fix tests failing on Jenkins [cassandra-java-driver]

2024-07-02 Thread via GitHub
lukasz-antoniak opened a new pull request, #1939: URL: https://github.com/apache/cassandra-java-driver/pull/1939 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix tests failing on Jenkins [cassandra-java-driver]

2024-07-02 Thread via GitHub
absurdfarce commented on code in PR #1939: URL: https://github.com/apache/cassandra-java-driver/pull/1939#discussion_r1662902550 ## integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteIT.java: ## @@ -56,8 +56,8 @@ // Do not run LWT tests in parallel because th

[PR] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-03 Thread via GitHub
jberragan opened a new pull request, #62: URL: https://github.com/apache/cassandra-analytics/pull/62 …inimal dependencies. - Add new module cassandra-analytics-common with no dependencies on Spark or Cassandra and minimal standard dependencies (Guava, Jackson, Commons Lang Kryo etc)

Re: [PR] Fix tests failing on Jenkins [cassandra-java-driver]

2024-07-04 Thread via GitHub
lukasz-antoniak commented on code in PR #1939: URL: https://github.com/apache/cassandra-java-driver/pull/1939#discussion_r1665282649 ## integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteIT.java: ## @@ -56,8 +56,8 @@ // Do not run LWT tests in parallel becaus

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-05 Thread via GitHub
bbotella commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1666880564 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/partitioner/NotEnoughReplicasException.java: ## @@ -20,7 +20,7 @@ package org.apa

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-05 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1666981782 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/partitioner/NotEnoughReplicasException.java: ## @@ -20,7 +20,7 @@ package org.ap

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-05 Thread via GitHub
bbotella commented on PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#issuecomment-2211159753 LGTM (nb) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-05 Thread via GitHub
5 commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1667082786 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/stats/IStats.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-08 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1668933421 ## cassandra-four-zero-bridge/src/main/java/org/apache/cassandra/spark/reader/MapBuffer.java: ## @@ -17,28 +17,21 @@ * under the License. */ -package o

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-08 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1668933421 ## cassandra-four-zero-bridge/src/main/java/org/apache/cassandra/spark/reader/MapBuffer.java: ## @@ -17,28 +17,21 @@ * under the License. */ -package o

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-08 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1668957381 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/ByteBufferUtils.java: ## @@ -30,20 +30,13 @@ import java.nio.charset.CharsetDec

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-10 Thread via GitHub
aweisberg commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1672788863 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/stats/IStats.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-10 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1672850714 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/LocalDataLayer.java: ## @@ -174,7 +174,7 @@ public static LocalDataLayer from(Map

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-10 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1672852859 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/streaming/CassandraFile.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-10 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1672861006 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/StreamScanner.java: ## @@ -49,30 +49,31 @@ * * Upon return from the next()

Re: [PR] Fix uncaught exception during graceful channel shutdown after exceeding max orphan ids [cassandra-java-driver]

2024-07-11 Thread via GitHub
christianaistleitner commented on PR #1938: URL: https://github.com/apache/cassandra-java-driver/pull/1938#issuecomment-390903 Is there still something that I need to do to get this PR merged? 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
frankgh commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1672572965 ## cassandra-four-zero-bridge/build.gradle: ## @@ -29,13 +29,15 @@ configurations { } dependencies { +compileOnly project(":cassandra-analytics-common"

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674285978 ## cassandra-analytics-common/build.gradle: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor li

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674319890 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/EmptyStreamScanner.java: ## @@ -24,13 +24,13 @@ public class EmptyStreamScanner

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674321387 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/LocalDataLayer.java: ## @@ -174,7 +174,7 @@ public static LocalDataLayer from(Map

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
frankgh commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674323150 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/EmptyStreamScanner.java: ## @@ -24,13 +24,13 @@ public class EmptyStreamScanner i

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674319890 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/EmptyStreamScanner.java: ## @@ -24,13 +24,13 @@ public class EmptyStreamScanner

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
frankgh commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674323821 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/StreamScanner.java: ## @@ -49,30 +49,31 @@ * * Upon return from the next() c

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
frankgh commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674325911 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/LocalDataLayer.java: ## @@ -174,7 +174,7 @@ public static LocalDataLayer from(Map op

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674392806 ## gradle.properties: ## @@ -28,6 +28,10 @@ mockitoVersion=3.12.4 jnaVersion=5.9.0 scala=2.12 spark=3 +kryoVersion=4.0.2 +commonsLangVersion=2.6 +slf4jApi

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674407220 ## gradle.properties: ## @@ -28,6 +28,10 @@ mockitoVersion=3.12.4 jnaVersion=5.9.0 scala=2.12 spark=3 +kryoVersion=4.0.2 +commonsLangVersion=2.6 +slf4jApi

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
frankgh commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674410766 ## gradle.properties: ## @@ -28,6 +28,10 @@ mockitoVersion=3.12.4 jnaVersion=5.9.0 scala=2.12 spark=3 +kryoVersion=4.0.2 +commonsLangVersion=2.6 +slf4jApiVe

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
frankgh commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674411336 ## gradle.properties: ## @@ -28,6 +28,10 @@ mockitoVersion=3.12.4 jnaVersion=5.9.0 scala=2.12 spark=3 +kryoVersion=4.0.2 +commonsLangVersion=2.6 +slf4jApiVe

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
jberragan commented on PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#issuecomment-2223627526 Most recent CircleCI: https://app.circleci.com/pipelines/github/jberragan/cassandra-analytics/17/workflows/a63c72d8-79b7-4ab4-879a-221dd76fa3e7 -- This is an automated messag

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-11 Thread via GitHub
yifan-c commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674811270 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/StreamScanner.java: ## @@ -49,30 +49,36 @@ * * Upon return from the next() c

[PR] manual: correct the codeblock directive [cassandra-java-driver]

2024-07-11 Thread via GitHub
tchaikov opened a new pull request, #1940: URL: https://github.com/apache/cassandra-java-driver/pull/1940 it should start with three backticks not four of them. otherwise sphinx warns like: ``` /home/kefu/dev/cassandra-java-driver/docs/_source/manual/mapper/daos/getentity/index.md

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-12 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1676165371 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/partitioner/TokenPartitioner.java: ## @@ -51,7 +51,7 @@ /** * Util class for

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-12 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1676167479 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/StreamScanner.java: ## @@ -49,30 +49,36 @@ * * Upon return from the next()

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-12 Thread via GitHub
yifan-c commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1676189363 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/stats/IStats.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-12 Thread via GitHub
jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1676203192 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/EmptyStreamScanner.java: ## @@ -24,13 +24,13 @@ public class EmptyStreamScanner

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-12 Thread via GitHub
jberragan commented on PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#issuecomment-2226399457 Latest CI: https://app.circleci.com/pipelines/github/jberragan/cassandra-analytics/25/workflows/e91b02d5-85eb-48bf-a5cb-bc71a942431f -- This is an automated message from the

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-12 Thread via GitHub
yifan-c commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1676492338 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/EmptyStreamScanner.java: ## @@ -24,13 +24,13 @@ public class EmptyStreamScanner i

Re: [PR] [CASSANDRA-19748] Refactoring to introduce new cassandra-analytics-common module with m… [cassandra-analytics]

2024-07-12 Thread via GitHub
yifan-c merged PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ca

[PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-13 Thread via GitHub
yifan-c opened a new pull request, #63: URL: https://github.com/apache/cassandra-analytics/pull/63 This patch introduces a new option SIDECAR_CONTACT_POINTS for both bulk writer and reader. The option name better describes the purpose, which is to specify the initial contact points to disco

[PR] Ninja fix for CASSANDRA-19748 [cassandra-analytics]

2024-07-15 Thread via GitHub
jberragan opened a new pull request, #64: URL: https://github.com/apache/cassandra-analytics/pull/64 Rename Stats SSTable generic name to prevent clashing with existing method generics -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
frankgh commented on code in PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680017755 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java: ## @@ -146,17 +148,16 @@ public class BulkSparkConf impleme

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
yifan-c commented on code in PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680052228 ## cassandra-analytics-core/src/test/spark3/org/apache/cassandra/spark/common/SidecarInstanceFactoryTest.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apac

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
yifan-c commented on code in PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680053097 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/MapUtils.java: ## @@ -239,4 +245,35 @@ public static boolean containsKey(Map opti

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
yifan-c commented on code in PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680056218 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java: ## @@ -240,38 +241,47 @@ protected Set buildBlockedInstance

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
yifan-c commented on code in PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680058191 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java: ## @@ -146,17 +148,16 @@ public class BulkSparkConf impleme

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
yifan-c commented on code in PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680072271 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/SidecarInstanceFactory.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Sof

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
yifan-c commented on code in PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680080380 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/SidecarInstanceFactory.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Sof

[PR] CASSANDRA-19774: Bump Cassandra Sidecar version [cassandra-analytics]

2024-07-16 Thread via GitHub
yifan-c opened a new pull request, #65: URL: https://github.com/apache/cassandra-analytics/pull/65 Commit sha: 55a9efee30555d3645680c6524043a6c9bc1194b Patch by Yifan Cai; Reviewed by Francisco Guerrero for CASSANDRA-19774 -- This is an automated message from the Apache Git Service.

Re: [PR] CASSANDRA-19774: Bump Cassandra Sidecar version [cassandra-analytics]

2024-07-16 Thread via GitHub
yifan-c merged PR #65: URL: https://github.com/apache/cassandra-analytics/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ca

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
frankgh commented on code in PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680162367 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/MapUtils.java: ## @@ -239,4 +245,35 @@ public static boolean containsKey(Map opti

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
frankgh commented on code in PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680162785 ## scripts/build-sidecar.sh: ## @@ -24,7 +24,7 @@ else SCRIPT_DIR=$( dirname -- "$( readlink -f -- "$0"; )"; ) SIDECAR_REPO="${SIDECAR_REPO:-https://git

Re: [PR] CASSANDRA-19772: Deprecate option SIDECAR_INSTANCES and replace with SIDECAR_CONTACT_POINTS [cassandra-analytics]

2024-07-16 Thread via GitHub
yifan-c merged PR #63: URL: https://github.com/apache/cassandra-analytics/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ca

[PR] CASSANDRA-19778: Split out BufferingInputStream stats into separate i… [cassandra-analytics]

2024-07-17 Thread via GitHub
jberragan opened a new pull request, #66: URL: https://github.com/apache/cassandra-analytics/pull/66 …nterface Split BufferingInputStream stats into separate interface so class level generics are not required for the Stats interface -- This is an automated message from the Apache G

Re: [PR] Ninja fix for CASSANDRA-19748 [cassandra-analytics]

2024-07-17 Thread via GitHub
jberragan closed pull request #64: Ninja fix for CASSANDRA-19748 URL: https://github.com/apache/cassandra-analytics/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Ninja fix for CASSANDRA-19748 [cassandra-analytics]

2024-07-17 Thread via GitHub
jberragan commented on PR #64: URL: https://github.com/apache/cassandra-analytics/pull/64#issuecomment-2233812606 Closing as this is fixed with CASSANDRA-19778 https://github.com/apache/cassandra-analytics/pull/66 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] CASSANDRA-19778: Split out BufferingInputStream stats into separate i… [cassandra-analytics]

2024-07-17 Thread via GitHub
jberragan commented on PR #66: URL: https://github.com/apache/cassandra-analytics/pull/66#issuecomment-2234251183 Green CI: https://app.circleci.com/pipelines/github/jberragan/cassandra-analytics/36/workflows/9d4038d0-1937-4623-a973-97564f3e7e72 -- This is an automated message from the A

Re: [PR] CASSANDRA-19778: Split out BufferingInputStream stats into separate i… [cassandra-analytics]

2024-07-17 Thread via GitHub
bbotella commented on PR #66: URL: https://github.com/apache/cassandra-analytics/pull/66#issuecomment-2234255069 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] CASSANDRA-19778: Split out BufferingInputStream stats into separate i… [cassandra-analytics]

2024-07-17 Thread via GitHub
yifan-c merged PR #66: URL: https://github.com/apache/cassandra-analytics/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ca

[PR] Update README.md [cassandra-java-driver]

2024-07-20 Thread via GitHub
davidhwilliams opened a new pull request, #1941: URL: https://github.com/apache/cassandra-java-driver/pull/1941 Update Maven Central search to correct group ID for `org.apache.cassandra` instead of `com.datastax.oss` -- This is an automated message from the Apache Git Service. To respond

[PR] Remove other uses of Apache Commons lang for hashcode, equality and r… [cassandra-analytics]

2024-07-22 Thread via GitHub
jberragan opened a new pull request, #67: URL: https://github.com/apache/cassandra-analytics/pull/67 …andom string generation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] CASSANDRA-19791: Remove other uses of Apache Commons lang for hashcode, equality and r… [cassandra-analytics]

2024-07-22 Thread via GitHub
yifan-c commented on code in PR #67: URL: https://github.com/apache/cassandra-analytics/pull/67#discussion_r1686998515 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/RandomUtils.java: ## @@ -100,8 +119,18 @@ public static InetAddress randomInet()

Re: [PR] CASSANDRA-19791: Remove other uses of Apache Commons lang for hashcode, equality and r… [cassandra-analytics]

2024-07-22 Thread via GitHub
jberragan commented on code in PR #67: URL: https://github.com/apache/cassandra-analytics/pull/67#discussion_r1687012258 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/RandomUtils.java: ## @@ -63,6 +64,24 @@ public static int randomPositiveInt(int

Re: [PR] CASSANDRA-19791: Remove other uses of Apache Commons lang for hashcode, equality and r… [cassandra-analytics]

2024-07-22 Thread via GitHub
yifan-c commented on code in PR #67: URL: https://github.com/apache/cassandra-analytics/pull/67#discussion_r1687028750 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/RandomUtils.java: ## @@ -63,6 +64,24 @@ public static int randomPositiveInt(int bo

Re: [PR] CASSANDRA-19791: Remove other uses of Apache Commons lang for hashcode, equality and r… [cassandra-analytics]

2024-07-22 Thread via GitHub
jberragan commented on code in PR #67: URL: https://github.com/apache/cassandra-analytics/pull/67#discussion_r1687050570 ## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/RandomUtils.java: ## @@ -63,6 +64,24 @@ public static int randomPositiveInt(int

Re: [PR] CASSANDRA-19791: Remove other uses of Apache Commons lang for hashcode, equality and r… [cassandra-analytics]

2024-07-22 Thread via GitHub
yifan-c merged PR #67: URL: https://github.com/apache/cassandra-analytics/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ca

[PR] Split out CassandraTypes into separate class [cassandra-analytics]

2024-07-22 Thread via GitHub
jberragan opened a new pull request, #68: URL: https://github.com/apache/cassandra-analytics/pull/68 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] Moving the repository to github.com/apache/cassandra-gocql-driver [cassandra-gocql-driver]

2024-07-24 Thread via GitHub
michaelsembwever commented on issue #1776: URL: https://github.com/apache/cassandra-gocql-driver/issues/1776#issuecomment-2248680435 done: https://github.com/apache/cassandra-gocql-driver Immediate actions: - rename `master` to `trunk` (per project-wide practice) - a few asteri

Re: [PR] CASSANDRA-19793 Split out CassandraTypes into separate module [cassandra-analytics]

2024-07-24 Thread via GitHub
yifan-c commented on code in PR #68: URL: https://github.com/apache/cassandra-analytics/pull/68#discussion_r1690542595 ## cassandra-four-zero-types/build.gradle: ## @@ -0,0 +1,63 @@ +import java.nio.file.Paths + +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] CASSANDRA-19793 Split out CassandraTypes into separate module [cassandra-analytics]

2024-07-24 Thread via GitHub
jberragan commented on code in PR #68: URL: https://github.com/apache/cassandra-analytics/pull/68#discussion_r1690545899 ## cassandra-bridge/src/main/java/org/apache/cassandra/bridge/CassandraBridge.java: ## @@ -200,65 +192,152 @@ public List supportedTypes() // Native

Re: [PR] CASSANDRA-19793 Split out CassandraTypes into separate module [cassandra-analytics]

2024-07-24 Thread via GitHub
jberragan commented on PR #68: URL: https://github.com/apache/cassandra-analytics/pull/68#issuecomment-2249087848 CI green: https://app.circleci.com/pipelines/github/jberragan/cassandra-analytics/55/workflows/57c0c708-3d2f-418d-ab98-295aa68fa054 -- This is an automated message from the A

Re: [I] Moving the repository to github.com/apache/cassandra-gocql-driver [cassandra-gocql-driver]

2024-07-25 Thread via GitHub
martin-sucha commented on issue #1776: URL: https://github.com/apache/cassandra-gocql-driver/issues/1776#issuecomment-2249788857 Thanks! One of the first steps should be updating the `CONTRIBUTING.md` to clarify what changed with the donation to the ASF and how to handle pull request

Re: [PR] CASSANDRA-19793 Split out CassandraTypes into separate module [cassandra-analytics]

2024-07-25 Thread via GitHub
frankgh commented on code in PR #68: URL: https://github.com/apache/cassandra-analytics/pull/68#discussion_r1692158885 ## cassandra-four-zero-types/build.gradle: ## @@ -0,0 +1,63 @@ +import java.nio.file.Paths + +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] CASSANDRA-19793 Split out CassandraTypes into separate module [cassandra-analytics]

2024-07-25 Thread via GitHub
jberragan commented on code in PR #68: URL: https://github.com/apache/cassandra-analytics/pull/68#discussion_r1692371164 ## cassandra-four-zero-types/build.gradle: ## @@ -0,0 +1,63 @@ +import java.nio.file.Paths + +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Implemented token bucket rate limiter [cassandra-gocql-driver]

2024-07-26 Thread via GitHub
martin-sucha commented on PR #1756: URL: https://github.com/apache/cassandra-gocql-driver/pull/1756#issuecomment-2252527922 It seems to me that the rate limiter should be an interface instead, so that a client that wants to use a different implementation could supply their own. Speci

Re: [PR] Implemented token bucket rate limiter [cassandra-gocql-driver]

2024-07-26 Thread via GitHub
joao-r-reis commented on PR #1756: URL: https://github.com/apache/cassandra-gocql-driver/pull/1756#issuecomment-2252568078 I agree that making this an interceptor-like interface would open up more use cases beyond rate limiting so it seems like a good idea to me 👍 -- This is an automate

Re: [I] Moving the repository to github.com/apache/cassandra-gocql-driver [cassandra-gocql-driver]

2024-07-26 Thread via GitHub
michaelsembwever commented on issue #1776: URL: https://github.com/apache/cassandra-gocql-driver/issues/1776#issuecomment-2253075641 https://issues.apache.org/jira/browse/INFRA-25998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] CASSANDRA-19793 Split out CassandraTypes into separate module [cassandra-analytics]

2024-07-26 Thread via GitHub
frankgh merged PR #68: URL: https://github.com/apache/cassandra-analytics/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ca

  1   2   3   4   5   6   7   8   9   10   >