Re: [PR] CASSANDRA-16969-copyright-check-4.5.0 fixes [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce closed pull request #1770: CASSANDRA-16969-copyright-check-4.5.0 fixes URL: https://github.com/apache/cassandra-java-driver/pull/1770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] CASSANDRA-16969-copyright-check-4.4.0 fixes [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce closed pull request #1768: CASSANDRA-16969-copyright-check-4.4.0 fixes URL: https://github.com/apache/cassandra-java-driver/pull/1768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] CASSANDRA-16969-copyright-check-4.4.0 fixes [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce commented on PR #1768: URL: https://github.com/apache/cassandra-java-driver/pull/1768#issuecomment-1954948316 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] CASSANDRA-16969-copyright-check-4.8.0 fixes [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce closed pull request #1774: CASSANDRA-16969-copyright-check-4.8.0 fixes URL: https://github.com/apache/cassandra-java-driver/pull/1774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] CASSANDRA-16969-copyright-check-4.7.x [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce closed pull request #1773: CASSANDRA-16969-copyright-check-4.7.x URL: https://github.com/apache/cassandra-java-driver/pull/1773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] CASSANDRA-16969-copyright-check-4.7.x [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce commented on PR #1773: URL: https://github.com/apache/cassandra-java-driver/pull/1773#issuecomment-1954946883 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] CASSANDRA-16969-copyright-check-4.3.0_fixes [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce commented on PR #1767: URL: https://github.com/apache/cassandra-java-driver/pull/1767#issuecomment-1954948486 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] CASSANDRA-16969-copyright-check-4.5.0 fixes [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce commented on PR #1770: URL: https://github.com/apache/cassandra-java-driver/pull/1770#issuecomment-1954947930 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] CASSANDRA-16969-copyright-check-4.3.x [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce closed pull request #1766: CASSANDRA-16969-copyright-check-4.3.x URL: https://github.com/apache/cassandra-java-driver/pull/1766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] CASSANDRA-16969-copyright-check-4.3.x [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce commented on PR #1766: URL: https://github.com/apache/cassandra-java-driver/pull/1766#issuecomment-1954948705 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] CASSANDRA-16969-copyright-check-4.2.x [cassandra-java-driver]

2024-02-20 Thread via GitHub
absurdfarce commented on PR #1765: URL: https://github.com/apache/cassandra-java-driver/pull/1765#issuecomment-1954948886 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Changelog updates to reflect work that went out in 4.18.0 [cassandra-java-driver]

2024-02-20 Thread via GitHub
tolbertam commented on code in PR #1914: URL: https://github.com/apache/cassandra-java-driver/pull/1914#discussion_r1496556628 ## changelog/README.md: ## @@ -21,6 +21,16 @@ under the License. +### 4.18.0 + +- [improvement] PR 1689: Add support for publishing percentile

[PR] CASSANDRA-19418 - Changes to report additional bulk analytics job stats for instrumentation [cassandra-analytics]

2024-02-21 Thread via GitHub
arjunashok opened a new pull request, #41: URL: https://github.com/apache/cassandra-analytics/pull/41 ## Changes - Update to relay the results of the spark tasks to the executor to instrument the total no. of rows written. - Abstracts the current `dialHome` implementation within

Re: [PR] CASSANDRA-19411: Bulk reader fails to produce a row when regular column values are null [cassandra-analytics]

2024-02-21 Thread via GitHub
frankgh closed pull request #40: CASSANDRA-19411: Bulk reader fails to produce a row when regular column values are null URL: https://github.com/apache/cassandra-analytics/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] CASSANDRA-19411: Bulk reader fails to produce a row when regular column values are null [cassandra-analytics]

2024-02-21 Thread via GitHub
frankgh commented on PR #40: URL: https://github.com/apache/cassandra-analytics/pull/40#issuecomment-1958435849 Closed via https://github.com/apache/cassandra-analytics/commit/46c35d0ef2efb66512133a7913df9936b0a80dc8 -- This is an automated message from the Apache Git Service. To

Re: [PR] JAVA-3080: Support PEM files for SSL [cassandra-java-driver]

2024-02-19 Thread via GitHub
yukim commented on PR #1678: URL: https://github.com/apache/cassandra-java-driver/pull/1678#issuecomment-1951916487 Rebased and updated the license header. Note that the current implementation does not implement hot reloading of PEM files like CASSANDRA-19180 does for keystore file.

Re: [PR] CASSANDRA-19369 Use XXHash32 for digest calculation of SSTables [cassandra-analytics]

2024-02-07 Thread via GitHub
yifan-c commented on code in PR #38: URL: https://github.com/apache/cassandra-analytics/pull/38#discussion_r1482390314 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java: ## @@ -128,12 +128,13 @@ public class BulkSparkConf

Re: [PR] CASSANDRA-19369 Use XXHash32 for digest calculation of SSTables [cassandra-analytics]

2024-02-06 Thread via GitHub
frankgh commented on code in PR #38: URL: https://github.com/apache/cassandra-analytics/pull/38#discussion_r1480589895 ## cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/QuoteIdentifiersWriteTest.java: ## @@ -76,58 +59,31 @@ class

Re: [PR] [CASSANDRA-19377] Startup Validation Failures when Checking Sidecar Connectivity (Analytics) [cassandra-analytics]

2024-02-07 Thread via GitHub
5 closed pull request #22: [CASSANDRA-19377] Startup Validation Failures when Checking Sidecar Connectivity (Analytics) URL: https://github.com/apache/cassandra-analytics/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] CASSANDRA-19369 Use XXHash32 for digest calculation of SSTables [cassandra-analytics]

2024-02-09 Thread via GitHub
JeetKunDoug commented on code in PR #38: URL: https://github.com/apache/cassandra-analytics/pull/38#discussion_r1484658554 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java: ## @@ -128,12 +128,13 @@ public class BulkSparkConf

[PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-06 Thread via GitHub
absurdfarce opened a new pull request, #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913 This patch also includes support for native_(address|port) as well as native_port_ssl which are being added to Cassandra. For more information on that aspect of this change take a

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-06 Thread via GitHub
absurdfarce commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1480698400 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -494,28 +499,50 @@ private void

Re: [PR] CASSANDRA-16999 covering ssl port [cassandra-java-driver]

2024-02-06 Thread via GitHub
absurdfarce commented on code in PR #1910: URL: https://github.com/apache/cassandra-java-driver/pull/1910#discussion_r1480702424 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -506,16 +506,32 @@ protected

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-06 Thread via GitHub
absurdfarce commented on PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#issuecomment-1931019450 Tested this via manual testing against the following configurations: * OSS C*, native_port support provided by @smiklosovic

Re: [PR] CASSANDRA-19180: Support reloading keystore in cassandra-java-driver [cassandra-java-driver]

2024-02-06 Thread via GitHub
absurdfarce commented on PR #1907: URL: https://github.com/apache/cassandra-java-driver/pull/1907#issuecomment-1931068838 FTR these changes got a clean run on DataStax Jenkins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Fix decode in VectorCodec [cassandra-java-driver]

2024-02-06 Thread via GitHub
absurdfarce commented on PR #1909: URL: https://github.com/apache/cassandra-java-driver/pull/1909#issuecomment-1931069233 FTR these changes got a clean run on DataStax Jenkins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-17 Thread via GitHub
absurdfarce commented on PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#issuecomment-1859640807 Regarding your alternate proposed implementation above @SiyaoIsHiding; I think we probably should prefer the version actually contained in this PR. We know _some_

Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-17 Thread via GitHub
absurdfarce commented on code in PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#discussion_r1429553321 ## core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java: ## @@ -225,22 +228,40 @@ protected

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-06 Thread via GitHub
yifan-c commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1416591381 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java: ## @@ -207,46 +203,62 @@ private Set

Re: [PR] CASSANDRA-18969: source files missing from sources jars due to maven … [cassandra-java-driver]

2023-12-06 Thread via GitHub
hhughes commented on PR #1900: URL: https://github.com/apache/cassandra-java-driver/pull/1900#issuecomment-1843370589 @michaelsembwever done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] CASSANDRA-18969: source files missing from sources jars due to maven … [cassandra-java-driver]

2023-12-06 Thread via GitHub
michaelsembwever commented on PR #1900: URL: https://github.com/apache/cassandra-java-driver/pull/1900#issuecomment-1842960983 Here's the commit (PR on top) to add the required checksums to the distribution* artefacts https://github.com/hhughes/java-driver/pull/1 -- This is an

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2023-12-23 Thread via GitHub
adutra commented on code in PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1435650327 ## core/src/main/java/com/datastax/oss/driver/api/core/config/TypedDriverOption.java: ## @@ -886,6 +886,16 @@ public String toString() {

[PR] Update com.github.jnr:jnr-posix to 3.1.18 to avoid M1 docker crash [cassandra-java-driver]

2023-12-14 Thread via GitHub
codefromthecrypt opened a new pull request, #1904: URL: https://github.com/apache/cassandra-java-driver/pull/1904 Zipkin found the following crash when running a docker container that uses this driver on Apple Silicon. Note: the problem doesn't happen when run via java directly on the

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-10 Thread via GitHub
arjunashok commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1422010350 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/TableSchema.java: ## @@ -94,6 +95,12 @@ public Object[] normalize(Object[]

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-10 Thread via GitHub
arjunashok commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1422019437 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/token/ConsistencyLevel.java: ## @@ -59,42 +87,34 @@ public boolean

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-10 Thread via GitHub
arjunashok commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1422004520 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -339,140 +336,190 @@ public String

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-10 Thread via GitHub
arjunashok commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1422005002 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -339,140 +336,190 @@ public String

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-10 Thread via GitHub
arjunashok commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1422015166 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CommitCoordinator.java: ## @@ -128,61 +128,51 @@ private Stream>

[PR] Flaky test in SSTableInputStreamTests [cassandra-analytics]

2023-12-12 Thread via GitHub
yifan-c opened a new pull request, #26: URL: https://github.com/apache/cassandra-analytics/pull/26 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] CASSANDRA-19198: Flaky test in SSTableInputStreamTests [cassandra-analytics]

2023-12-13 Thread via GitHub
yifan-c closed pull request #26: CASSANDRA-19198: Flaky test in SSTableInputStreamTests URL: https://github.com/apache/cassandra-analytics/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] CASSANDRA-19223: Column type mapping error for timestamp type during … [cassandra-analytics]

2023-12-28 Thread via GitHub
frankgh commented on code in PR #28: URL: https://github.com/apache/cassandra-analytics/pull/28#discussion_r1437860156 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/TableSchema.java: ## @@ -136,11 +136,11 @@ private static List>

Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-21 Thread via GitHub
absurdfarce commented on code in PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#discussion_r1434162481 ## core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java: ## @@ -225,22 +228,51 @@ protected

Re: [PR] CASSANDRA-19212: Fix forced Spark job timeout in ResiliencyTestBase [cassandra-analytics]

2023-12-20 Thread via GitHub
frankgh commented on code in PR #27: URL: https://github.com/apache/cassandra-analytics/pull/27#discussion_r1432995042 ## cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/ResiliencyTestBase.java: ## @@ -375,10 +375,22 @@ protected void

Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-20 Thread via GitHub
SiyaoIsHiding commented on code in PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#discussion_r1433158316 ## core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java: ## @@ -225,22 +228,40 @@ protected

Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-20 Thread via GitHub
SiyaoIsHiding commented on code in PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#discussion_r1433178698 ## core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java: ## @@ -225,22 +228,40 @@ protected

Re: [PR] [Updated] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-20 Thread via GitHub
frankgh commented on PR #25: URL: https://github.com/apache/cassandra-analytics/pull/25#issuecomment-1864839317 closed via https://github.com/apache/cassandra-analytics/commit/0aaf5659028dd874c8d666c636f11eae63c429e6 -- This is an automated message from the Apache Git Service. To

Re: [PR] [Updated] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-20 Thread via GitHub
frankgh closed pull request #25: [Updated] Cassandra 18852: Make bulk writer resilient to cluster resize events URL: https://github.com/apache/cassandra-analytics/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] CASSANDRA-19212: Fix forced Spark job timeout in ResiliencyTestBase [cassandra-analytics]

2023-12-20 Thread via GitHub
JeetKunDoug opened a new pull request, #27: URL: https://github.com/apache/cassandra-analytics/pull/27 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] CASSANDRA-19223: Column type mapping error for timestamp type during … [cassandra-analytics]

2023-12-21 Thread via GitHub
frankgh opened a new pull request, #28: URL: https://github.com/apache/cassandra-analytics/pull/28 …bulk writes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] JAVA-3055 CqlPrepareAsyncProcessor must handle cancellations of the r… [cassandra-java-driver]

2023-12-11 Thread via GitHub
lucboutier commented on PR #1725: URL: https://github.com/apache/cassandra-java-driver/pull/1725#issuecomment-1850149184 I made another PR for 3055 some time ago. Then had a review from a colleague for a better and simpler implementation which I believe is quite nice. See

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-11 Thread via GitHub
yifan-c commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1422438882 ## cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/ResiliencyTestBase.java: ## @@ -0,0 +1,501 @@ +/* + * Licensed to the

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-11 Thread via GitHub
yifan-c commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1422429361 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -339,140 +336,188 @@ public String

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-11 Thread via GitHub
arjunashok commented on PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#issuecomment-1850889037 Attempt to reopen PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-11 Thread via GitHub
arjunashok commented on PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#issuecomment-1850889132 Attempt to reopen PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-11 Thread via GitHub
arjunashok commented on PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#issuecomment-1850873871 Reopen attempt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-11 Thread via GitHub
arjunashok commented on PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#issuecomment-1850873520 Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-11 Thread via GitHub
arjunashok closed pull request #17: Cassandra 18852: Make bulk writer resilient to cluster resize events URL: https://github.com/apache/cassandra-analytics/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-11 Thread via GitHub
arjunashok commented on PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#issuecomment-1850885476 Attempt to reopen PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [Updated] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]

2023-12-11 Thread via GitHub
arjunashok opened a new pull request, #25: URL: https://github.com/apache/cassandra-analytics/pull/25 This is a copy of the PR: https://github.com/apache/cassandra-analytics/pull/17, which includes the review comments. ### Changes: Replaces dependency on Sidecar ring endpoint to

Re: [PR] CASSANDRA-19199 Remove write option VALIDATE_SSTABLES to enforce validation [cassandra-analytics]

2023-12-13 Thread via GitHub
frankgh closed pull request #24: CASSANDRA-19199 Remove write option VALIDATE_SSTABLES to enforce validation URL: https://github.com/apache/cassandra-analytics/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] CASSANDRA-19199 Remove write option VALIDATE_SSTABLES to enforce validation [cassandra-analytics]

2023-12-13 Thread via GitHub
frankgh commented on PR #24: URL: https://github.com/apache/cassandra-analytics/pull/24#issuecomment-1854452346 Closed via https://github.com/apache/cassandra-analytics/commit/672d66a64a21e23c4d81c089b426360c2bb708b7 -- This is an automated message from the Apache Git Service. To

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-02 Thread via GitHub
nitinitt commented on code in PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1440126405 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java: ## @@ -325,24 +338,63 @@ protected Queue

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-02 Thread via GitHub
nitinitt commented on PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-1874927651 Thanks @adutra for the insightful code review comments, really appreciate it. I'll address all of them and have an open question/clarification posted above. Happy New

[PR] CASSANDRA-19251 Speed up integration tests [cassandra-analytics]

2024-01-05 Thread via GitHub
frankgh opened a new pull request, #29: URL: https://github.com/apache/cassandra-analytics/pull/29 This commit introduces an opinionated way to run integration tests where a test class reuses the same in-jvm dtest cluster, and it offers certain ordering that help running tests faster.

Re: [PR] CASSANDRA-19251 Speed up integration tests [cassandra-analytics]

2024-01-10 Thread via GitHub
frankgh commented on PR #29: URL: https://github.com/apache/cassandra-analytics/pull/29#issuecomment-1884880308 Closed via https://github.com/apache/cassandra-analytics/commit/550bdfa1c6082537e2cfb93449128a61dbe3a1fb -- This is an automated message from the Apache Git Service. To

Re: [PR] CASSANDRA-19251 Speed up integration tests [cassandra-analytics]

2024-01-10 Thread via GitHub
frankgh closed pull request #29: CASSANDRA-19251 Speed up integration tests URL: https://github.com/apache/cassandra-analytics/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] CASSANDRA-19257 Fixes handling of blocked instances during CL validat… [cassandra-analytics]

2024-01-10 Thread via GitHub
yifan-c commented on code in PR #30: URL: https://github.com/apache/cassandra-analytics/pull/30#discussion_r1447772924 ## cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/RecordWriterTest.java: ## @@ -120,6 +122,34 @@ public void

Re: [PR] CASSANDRA-19212: Fix forced Spark job timeout in ResiliencyTestBase [cassandra-analytics]

2024-01-10 Thread via GitHub
JeetKunDoug commented on PR #27: URL: https://github.com/apache/cassandra-analytics/pull/27#issuecomment-1885331838 Closing the PR for now as we aren't running Spark jobs in a separate process any more. May revisit if we decide to pull that feature back in to the Analytics library. --

Re: [PR] CASSANDRA-19212: Fix forced Spark job timeout in ResiliencyTestBase [cassandra-analytics]

2024-01-10 Thread via GitHub
JeetKunDoug closed pull request #27: CASSANDRA-19212: Fix forced Spark job timeout in ResiliencyTestBase URL: https://github.com/apache/cassandra-analytics/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] CASSANDRA-19257 Fixes handling of blocked instances during CL validat… [cassandra-analytics]

2024-01-10 Thread via GitHub
frankgh commented on code in PR #30: URL: https://github.com/apache/cassandra-analytics/pull/30#discussion_r1447966454 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/StreamSession.java: ## @@ -180,6 +180,16 @@ List getReplicas() return

Re: [PR] CASSANDRA-19257 Fixes handling of blocked instances during CL validat… [cassandra-analytics]

2024-01-10 Thread via GitHub
frankgh closed pull request #30: CASSANDRA-19257 Fixes handling of blocked instances during CL validat… URL: https://github.com/apache/cassandra-analytics/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] CASSANDRA-19257 Fixes handling of blocked instances during CL validat… [cassandra-analytics]

2024-01-10 Thread via GitHub
frankgh commented on code in PR #30: URL: https://github.com/apache/cassandra-analytics/pull/30#discussion_r1448031205 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/StreamSession.java: ## @@ -169,7 +169,9 @@ List getReplicas() List

Re: [PR] CASSANDRA-19257 Fixes handling of blocked instances during CL validat… [cassandra-analytics]

2024-01-10 Thread via GitHub
arjunashok commented on code in PR #30: URL: https://github.com/apache/cassandra-analytics/pull/30#discussion_r1448037131 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/StreamSession.java: ## @@ -169,7 +169,9 @@ List getReplicas() List

Re: [PR] CASSANDRA-19257 Fixes handling of blocked instances during CL validat… [cassandra-analytics]

2024-01-10 Thread via GitHub
frankgh commented on PR #30: URL: https://github.com/apache/cassandra-analytics/pull/30#issuecomment-1885886516 Closed via https://github.com/apache/cassandra-analytics/commit/e8fb77f4813b469d73d39c84acf1e1fe7a40702b -- This is an automated message from the Apache Git Service. To

Re: [PR] CASSANDRA-19223: Column type mapping error for timestamp type during … [cassandra-analytics]

2024-01-10 Thread via GitHub
frankgh closed pull request #28: CASSANDRA-19223: Column type mapping error for timestamp type during … URL: https://github.com/apache/cassandra-analytics/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] CASSANDRA-19223: Column type mapping error for timestamp type during … [cassandra-analytics]

2024-01-10 Thread via GitHub
frankgh commented on PR #28: URL: https://github.com/apache/cassandra-analytics/pull/28#issuecomment-1885879729 Closed via https://github.com/apache/cassandra-analytics/commit/e82fceaecfe5ea04ac3ddff92be5a6a41456333c -- This is an automated message from the Apache Git Service. To

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-11 Thread via GitHub
nitinitt commented on code in PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449376273 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java: ## @@ -131,6 +135,15 @@ public

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-11 Thread via GitHub
nitinitt commented on code in PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449372202 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java: ## @@ -325,24 +338,63 @@ protected Queue

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-11 Thread via GitHub
nitinitt commented on code in PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449372615 ## core/src/test/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicyRemoteDcTest.java: ## @@ -0,0 +1,189 @@ +/* + *

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-11 Thread via GitHub
nitinitt commented on code in PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449526333 ## core/src/test/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicyRemoteDcTest.java: ## @@ -0,0 +1,189 @@ +/* + *

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-11 Thread via GitHub
nitinitt commented on code in PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449368834 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java: ## @@ -325,24 +338,63 @@ protected Queue

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-11 Thread via GitHub
nitinitt commented on PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-1888191613 Thanks @adutra for the code review, have addressed all the review comments. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-16 Thread via GitHub
sarankk opened a new pull request, #31: URL: https://github.com/apache/cassandra-analytics/pull/31 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Adds integration testing for blocklist handling [cassandra-analytics]

2024-01-16 Thread via GitHub
arjunashok opened a new pull request, #32: URL: https://github.com/apache/cassandra-analytics/pull/32 ### Changes - Adds spark config with default empty list for `blocked_instances` - Adds tests for blocked instances -- This is an automated message from the Apache Git Service. To

Re: [PR] Adds integration testing for blocklist handling [cassandra-analytics]

2024-01-17 Thread via GitHub
arjunashok commented on code in PR #32: URL: https://github.com/apache/cassandra-analytics/pull/32#discussion_r1456276685 ## cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/BlockedInstancesTest.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to

Re: [PR] [CASSANDRA-19272] Adds integration testing for blocklist handling [cassandra-analytics]

2024-01-17 Thread via GitHub
frankgh closed pull request #32: [CASSANDRA-19272] Adds integration testing for blocklist handling URL: https://github.com/apache/cassandra-analytics/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [CASSANDRA-19272] Adds integration testing for blocklist handling [cassandra-analytics]

2024-01-17 Thread via GitHub
frankgh commented on PR #32: URL: https://github.com/apache/cassandra-analytics/pull/32#issuecomment-1897046961 Closed via https://github.com/apache/cassandra-analytics/commit/fa6df8e2c09ad3d27bfe8c0ce016c839094630f6 -- This is an automated message from the Apache Git Service. To

Re: [PR] [CASSANDRASC-86] Startup Validation Failures when Checking Sidecar Connectivity [cassandra-analytics]

2024-01-17 Thread via GitHub
5 commented on code in PR #22: URL: https://github.com/apache/cassandra-analytics/pull/22#discussion_r1456527690 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/CassandraValidation.java: ## @@ -29,7 +29,7 @@ */ public class

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
frankgh commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456716322 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -146,6 +158,16 @@ public boolean clearSnapshot()

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
frankgh commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456715644 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java: ## @@ -341,24 +341,31 @@ private CompletionStage>

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456714473 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java: ## @@ -341,24 +341,31 @@ private CompletionStage>

Re: [PR] Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
sarankk commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456371369 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -91,6 +101,8 @@ private ClientConfig(Map options)

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456713939 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java: ## @@ -341,24 +341,31 @@ private CompletionStage>

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456718177 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java: ## @@ -341,24 +341,31 @@ private CompletionStage>

Re: [PR] Adds integration testing for blocklist handling [cassandra-analytics]

2024-01-17 Thread via GitHub
frankgh commented on code in PR #32: URL: https://github.com/apache/cassandra-analytics/pull/32#discussion_r1455673981 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/WriterOptions.java: ## @@ -50,4 +50,5 @@ public enum WriterOptions implements

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-18 Thread via GitHub
sarankk commented on PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#issuecomment-1899368851 As per @yifan-c suggestions, to avoid confusion caused by allowing both `clearSnapshot` option and `snapshotTTL` option, we are going ahead with following setting to determine

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-09 Thread via GitHub
adutra commented on code in PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1446225748 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java: ## @@ -325,24 +338,63 @@ protected Queue

Re: [PR] JAVA-3142: Ability to optionally specify remote dcs for deterministic failovers when remote dcs are used in query plan [cassandra-java-driver]

2024-01-09 Thread via GitHub
adutra commented on code in PR #1896: URL: https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1446150652 ## core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java: ## @@ -325,24 +338,63 @@ protected Queue

Re: [PR] CASSANDRA-19251 Speed up integration tests [cassandra-analytics]

2024-01-09 Thread via GitHub
yifan-c commented on code in PR #29: URL: https://github.com/apache/cassandra-analytics/pull/29#discussion_r1446791838 ## cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java: ## @@ -0,0 +1,417 @@

[PR] Handing error in asynchronous programming and ensuring future object … [cassandra-java-driver]

2024-01-03 Thread via GitHub
vararo27 opened a new pull request, #1905: URL: https://github.com/apache/cassandra-java-driver/pull/1905 …is completed on exception -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

<    1   2   3   4   5   6   7   8   9   10   >