[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388905#comment-16388905
]
ASF GitHub Bot commented on CASSANDRA-11381:
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388839#comment-16388839
]
ASF GitHub Bot commented on CASSANDRA-11381:
Github user michaelsembwever commented on
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387566#comment-16387566
]
ASF GitHub Bot commented on CASSANDRA-11381:
Github user michaelsembwever commented on
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369529#comment-16369529
]
ASF GitHub Bot commented on CASSANDRA-11381:
Github user michaelsembwever commented on a
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368978#comment-16368978
]
ASF GitHub Bot commented on CASSANDRA-11381:
Github user ptnapoleon commented on a diff
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368733#comment-16368733
]
ASF GitHub Bot commented on CASSANDRA-11381:
GitHub user michaelsembwever opened a pull
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047430#comment-16047430
]
mck commented on CASSANDRA-11381:
-
[~jkni], work on the dtest in
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047363#comment-16047363
]
mck commented on CASSANDRA-11381:
-
{quote}one minor nit that can be fixed on commit: new CHANGES.txt
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046602#comment-16046602
]
Joel Knighton commented on CASSANDRA-11381:
---
Great! I also ran dtests on some other
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036497#comment-16036497
]
mck commented on CASSANDRA-11381:
-
{quote}The 3.0 branch looks like it is an older version of the
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026830#comment-16026830
]
Joel Knighton commented on CASSANDRA-11381:
---
Thanks - this looks just about good. A few
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003987#comment-16003987
]
mck commented on CASSANDRA-11381:
-
[~jkni], dtests look good. are we ready to commit this?
> Node
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994472#comment-15994472
]
mck commented on CASSANDRA-11381:
-
[~jkni], i have finally come back to this…
{quote}CI revealed one
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704157#comment-15704157
]
Joel Knighton commented on CASSANDRA-11381:
---
Thanks - the patches look good and I put them
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671505#comment-15671505
]
mck commented on CASSANDRA-11381:
-
Makes sense, will update patches…
> Node running with
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645280#comment-15645280
]
Joel Knighton commented on CASSANDRA-11381:
---
Thanks for pinging me on this - as you
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643032#comment-15643032
]
mck commented on CASSANDRA-11381:
-
[~jkni] ping…?
> Node running with join_ring=false and
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553759#comment-15553759
]
mck commented on CASSANDRA-11381:
-
ping. is there anything outstanding here?
> Node running with
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406471#comment-15406471
]
Joel Knighton commented on CASSANDRA-11381:
---
[~michaelsembwever] - The scenario I was
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405823#comment-15405823
]
mck commented on CASSANDRA-11381:
-
…and reduced the timeouts in the dtest to 30 seconds.
All patches
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405706#comment-15405706
]
mck commented on CASSANDRA-11381:
-
Coming back to this issue now.
{quote}I've tested some scenarios
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259507#comment-15259507
]
Joel Knighton commented on CASSANDRA-11381:
---
I've tested some scenarios and can confirm
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258492#comment-15258492
]
Sam Tunnicliffe commented on CASSANDRA-11381:
-
Giving it some further thought, I think
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258251#comment-15258251
]
Sam Tunnicliffe commented on CASSANDRA-11381:
-
On top of that, custom
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258241#comment-15258241
]
Sam Tunnicliffe commented on CASSANDRA-11381:
-
Auth setup has to wait until the node has
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258156#comment-15258156
]
Joel Knighton commented on CASSANDRA-11381:
---
[~michaelsembwever], I definitely understand
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257906#comment-15257906
]
mck commented on CASSANDRA-11381:
-
{quote} - Is there a reason that we only setup auth in
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251385#comment-15251385
]
Joel Knighton commented on CASSANDRA-11381:
---
Thanks for the patches [~michaelsembwever] and
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249979#comment-15249979
]
Joel Knighton commented on CASSANDRA-11381:
---
No fault of Josh here, just a bit of a review
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249315#comment-15249315
]
mck commented on CASSANDRA-11381:
-
[~JoshuaMcKenzie], [~jkni], what's up?
> Node running with
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213410#comment-15213410
]
mck commented on CASSANDRA-11381:
-
Small update to the dtest. I had been writing dtests in the trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207726#comment-15207726
]
mck commented on CASSANDRA-11381:
-
[~JoshuaMcKenzie], the dtest is attached.
> Node running with
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204660#comment-15204660
]
Joshua McKenzie commented on CASSANDRA-11381:
-
bq. trying to figure out how to write a
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202064#comment-15202064
]
mck commented on CASSANDRA-11381:
-
@JoshuaMcKenzie, I've only run unit tests against trunk. And I'm
[
https://issues.apache.org/jira/browse/CASSANDRA-11381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201666#comment-15201666
]
Joshua McKenzie commented on CASSANDRA-11381:
-
Is this ticket Patch Available?
> Node
35 matches
Mail list logo