[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907693#comment-16907693 ] DeepakVohra commented on CASSANDRA-14185: - Added CASSANDRA-15280 Update help for nodetool tablehistograms > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Low > Fix For: 4.0 > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901560#comment-16901560 ] Chris Lohfink commented on CASSANDRA-14185: --- [~dvohra] please open a new issue to include that > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Low > Fix For: 4.0 > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901551#comment-16901551 ] DeepakVohra commented on CASSANDRA-14185: - Please also update the _help_ to include the provision to list histograms for all tables. Latest 4.0 build indicates requirement for a table. {code:java} nodetool help tablehistograms NAME nodetool tablehistograms - Print statistic histograms for a given table {code} > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Low > Fix For: 4.0 > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344306#comment-16344306 ] Jaydeepkumar Chovatia commented on CASSANDRA-14185: --- Hi [~jjirsa] First of all sorry for reaching out directly. This patch has been reviewed and approved by [~cnlwsu]. Now we need a committer to take a look at it and commit if everything is good. Can you or maybe point some committer who can help here? Jaydeep > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Minor > Fix For: 4.x > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344266#comment-16344266 ] Chris Lohfink commented on CASSANDRA-14185: --- nope, need a committer > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Minor > Fix For: 4.x > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344220#comment-16344220 ] Jaydeepkumar Chovatia commented on CASSANDRA-14185: --- Thanks [~cnlwsu] for the review! Is it possible for you to commit this to repo? Jaydeep > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Minor > Fix For: 4.x > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344115#comment-16344115 ] Chris Lohfink commented on CASSANDRA-14185: --- lgtm +1 > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Minor > Fix For: 4.x > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340161#comment-16340161 ] Jaydeepkumar Chovatia commented on CASSANDRA-14185: --- Hi [~cnlwsu] Please find updated patch with your code review comments incorporated here: ||trunk|| |[branch|https://github.com/jaydeepkumar1984/cassandra/commit/07b8c66ccecbad7c8b48e94c7539c9e9e0bc40f7]| |[uTest|https://circleci.com/gh/jaydeepkumar1984/cassandra/24]| Jaydeep > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Minor > Fix For: 4.x > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339721#comment-16339721 ] Jaydeepkumar Chovatia commented on CASSANDRA-14185: --- Thanks for the review [~cnlwsu]!, I will change it accordingly and will send you updated diff. > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Minor > Fix For: 4.x > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339638#comment-16339638 ] Chris Lohfink commented on CASSANDRA-14185: --- just trying it a little bit, the output is hard to understand with the intermixing of std out and std error. Might be nice to just go all standard out so piping and such will be readable. ie {code:java} ... system/batches histograms Percentile SSTables Write Latency Read LatencyPartition Size Cell Count (micros) (micros) (bytes) 50% 0.00 0.00 0.00 NaN NaN 75% 0.00 0.00 0.00 NaN NaN 95% 0.00 0.00 0.00 NaN NaN 98% 0.00 0.00 0.00 NaN NaN 99% 0.00 0.00 0.00 NaN NaN Min 0.00 0.00 0.00 NaN NaN Max 0.00 0.00 0.00 NaN NaN No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles system/built_views histograms Percentile SSTables Write Latency Read LatencyPartition Size Cell Count (micros) (micros) (bytes) 50% 0.00 0.00 0.00 NaN NaN 75% 0.00 0.00 0.00 NaN NaN 95% 0.00 0.00 0.00 NaN NaN 98% 0.00 0.00 0.00 NaN NaN 99% 0.00 0.00 0.00 NaN NaN Min 0.00 0.00 0.00 NaN NaN Max 0.00 0.00 0.00 NaN NaN No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles system/compaction_history histograms Percentile SSTables Write Latency Read LatencyPartition Size Cell Count (micros) (micros) (bytes) 50% 0.00 0.00 0.00 NaN NaN 75% 0.00 0.00 0.00 NaN NaN 95% 0.00 0.00 0.00 NaN NaN 98% 0.00 0.00 0.00 NaN NaN 99% 0.00 0.00 0.00 NaN NaN Min 0.00 0.00 0.00 NaN NaN Max 0.00 0.00 0.00 NaN NaN system/local histograms Percentile SSTables Write Latency Read LatencyPartition Size Cell Count (micros) (micros) (bytes) 50% 0.00 0.00 0.00 215 14 75% 0.00 0.00 0.00 5722 258 95% 0.00 0.00 0.00 5722 258 98% 0.00 0.00 0.00 5722 258 No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count' percentiles No SSTables exists, unable to calculate 'Partition Size' and 'Cell Count'
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335117#comment-16335117 ] Jaydeepkumar Chovatia commented on CASSANDRA-14185: --- Hi [~dbros...@apache.org] Sorry for reaching out directly, If you have some time then could you please review this patch? Jaydeep > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Minor > Fix For: 4.x > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14185) Nodetool tablehistograms to print statics for all the tables
[ https://issues.apache.org/jira/browse/CASSANDRA-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334984#comment-16334984 ] Jaydeepkumar Chovatia commented on CASSANDRA-14185: --- Please find patch details here: ||trunk|| |[branch|https://github.com/apache/cassandra/pull/187]| |[uTest|https://circleci.com/gh/jaydeepkumar1984/cassandra/23]| > Nodetool tablehistograms to print statics for all the tables > > > Key: CASSANDRA-14185 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14185 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jaydeepkumar Chovatia >Assignee: Jaydeepkumar Chovatia >Priority: Minor > Fix For: 4.x > > > Currently {{nodetool tablehistograms}} requires {{keyspacename.tablename}} as > argument always. If we want to print histograms for all the tables then we > will have to run this command for all the tables one after another. > It would be nice to have this command dump histogram for all the table at > once if no argument is provided, similar to {{nodetool tablestats}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org