[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910709#comment-16910709
]
Jon Meredith commented on CASSANDRA-15170:
--
Switched to the simpler/safer
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909454#comment-16909454
]
Jon Meredith commented on CASSANDRA-15170:
--
I tracked the problem down to the
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909356#comment-16909356
]
Jon Meredith commented on CASSANDRA-15170:
--
I've broken the trunk changes up into smaller
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908724#comment-16908724
]
Jon Meredith commented on CASSANDRA-15170:
--
2.2-3.11 look good. Lots of errors on trunk -
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908274#comment-16908274
]
Jon Meredith commented on CASSANDRA-15170:
--
Alright, squashed it all down to a commit
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908089#comment-16908089
]
Benedict commented on CASSANDRA-15170:
--
Thanks. Just a couple of tiny nits/questions:
The
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907479#comment-16907479
]
Jon Meredith commented on CASSANDRA-15170:
--
I've updated each of the branch for the
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905590#comment-16905590
]
Jon Meredith commented on CASSANDRA-15170:
--
Pushed and updated - upgrade tests now work on
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904092#comment-16904092
]
Jon Meredith commented on CASSANDRA-15170:
--
Thanks for explaining the issue with the
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904026#comment-16904026
]
Benedict commented on CASSANDRA-15170:
--
Thanks, looks good.
bq. The shutdown->shutdownNow
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904008#comment-16904008
]
Jon Meredith commented on CASSANDRA-15170:
--
Thanks for the review, and apologies for the
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903932#comment-16903932
]
Benedict commented on CASSANDRA-15170:
--
Thanks. It's looking good, just a few more minor(ish)
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903511#comment-16903511
]
Jon Meredith commented on CASSANDRA-15170:
--
Hopefully this is all the feedback addressed.
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901150#comment-16901150
]
Benedict commented on CASSANDRA-15170:
--
Thanks, the patch looks good overall. I've reviewed
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899690#comment-16899690
]
Jon Meredith commented on CASSANDRA-15170:
--
I've updated the branches and this should be
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890996#comment-16890996
]
Jon Meredith commented on CASSANDRA-15170:
--
Here's the latest - had all the updated
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888194#comment-16888194
]
Jon Meredith commented on CASSANDRA-15170:
--
Still searching for issues on trunk. The
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884770#comment-16884770
]
Jon Meredith commented on CASSANDRA-15170:
--
Thanks for the review - I forgot to remove a
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883755#comment-16883755
]
Alex Petrov commented on CASSANDRA-15170:
-
[~jmeredithco] thank you for the patch. I have
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881425#comment-16881425
]
Jon Meredith commented on CASSANDRA-15170:
--
Updated the branches with my latest efforts.
[
https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866992#comment-16866992
]
Jon Meredith commented on CASSANDRA-15170:
--
Branches with fixes merged up through the
21 matches
Mail list logo