[jira] [Commented] (CASSANDRA-15356) When streaming throws a FSError the DiskFailurePolicy does not get applied
[ https://issues.apache.org/jira/browse/CASSANDRA-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952172#comment-16952172 ] David Capwell commented on CASSANDRA-15356: --- Changing the description and title. Turns out that the disk failing policy is handled by CassandraDaemon and that dtests don't set that up properly so the stream tests had a false positive. I am repurposing this jira to now be "CassandraEntireSSTableStreamWriter throws IOException rather than FSError for disk issues, so doesn't get handled by disk failing policy" > When streaming throws a FSError the DiskFailurePolicy does not get applied > -- > > Key: CASSANDRA-15356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15356 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Streaming >Reporter: David Capwell >Priority: Normal > > Found while testing CASSANDRA-15332 > When streaming sees a IOException (in ChannelProxy), this gets converted to a > FSReadError but the stream logic doesn’t call the disk failure policy so will > not be properly handled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15356) When streaming throws a FSError the DiskFailurePolicy does not get applied
[ https://issues.apache.org/jira/browse/CASSANDRA-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951461#comment-16951461 ] David Capwell commented on CASSANDRA-15356: --- updated tests for 15332 to include streaming and they pass with a small change to CassandraOutgoingFile, but isn't exhaustive since it doesn't handle the full file case. > When streaming throws a FSError the DiskFailurePolicy does not get applied > -- > > Key: CASSANDRA-15356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15356 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Streaming >Reporter: David Capwell >Priority: Normal > > Found while testing CASSANDRA-15332 > When streaming sees a IOException (in ChannelProxy), this gets converted to a > FSReadError but the stream logic doesn’t call the disk failure policy so will > not be properly handled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15356) When streaming throws a FSError the DiskFailurePolicy does not get applied
[ https://issues.apache.org/jira/browse/CASSANDRA-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951458#comment-16951458 ] David Capwell commented on CASSANDRA-15356: --- org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamWriter#write this code path doesn't use ChannelProxy so won't return a FSError but rather a IOException > When streaming throws a FSError the DiskFailurePolicy does not get applied > -- > > Key: CASSANDRA-15356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15356 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Streaming >Reporter: David Capwell >Priority: Normal > > Found while testing CASSANDRA-15332 > When streaming sees a IOException (in ChannelProxy), this gets converted to a > FSReadError but the stream logic doesn’t call the disk failure policy so will > not be properly handled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
