[jira] [Commented] (CASSANDRA-7669) nodetool fails to connect when ipv6 host is specified
[ https://issues.apache.org/jira/browse/CASSANDRA-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084915#comment-14084915 ] Robert Stupp commented on CASSANDRA-7669: - It's [~aholmber]'s patch (just did some testing) > nodetool fails to connect when ipv6 host is specified > - > > Key: CASSANDRA-7669 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7669 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: java version "1.7.0_65" > Java(TM) SE Runtime Environment (build 1.7.0_65-b17) > Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode) >Reporter: Adam Holmberg >Assignee: Robert Stupp >Priority: Trivial > Fix For: 1.2.19, 2.0.10, 2.1.0 > > Attachments: nodetool_url_fmt.txt > > > The NodeProbe fmtUrl does not account for ipv6 addresses specified for > 'host'. > nodetool -h with ipv6 host address fails with cryptic error message > Adding square brackets as in http://www.ietf.org/rfc/rfc3986.txt section > 3.2.2 corrects this behavior. Patch attached. > {code:title=Before} > aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost > 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; > eval $cmd; done > bin/nodetool -h localhost -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 127.0.0.1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h ::1 -p 7100 version > nodetool: For input string: ":1:7100" > See 'nodetool help' or 'nodetool help '. > bin/nodetool -h 0::1 -p 7100 version > nodetool: For input string: ":1:7100" > See 'nodetool help' or 'nodetool help ’. > {code} > {code:title=After} > aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost > 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; > eval $cmd; done > bin/nodetool -h localhost -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 127.0.0.1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h ::1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 0::1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7669) nodetool fails to connect when ipv6 host is specified
[ https://issues.apache.org/jira/browse/CASSANDRA-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084719#comment-14084719 ] Robert Stupp commented on CASSANDRA-7669: - Sorry for the "-1" - have to revert it to a "+1"! Patch LGTM Tested with {{nodetool netstats}} , {{nodetool -h 127.0.0.1 netstats}} , {{nodetool -h ::1 netstats}} > nodetool fails to connect when ipv6 host is specified > - > > Key: CASSANDRA-7669 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7669 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: java version "1.7.0_65" > Java(TM) SE Runtime Environment (build 1.7.0_65-b17) > Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode) >Reporter: Adam Holmberg >Assignee: Robert Stupp >Priority: Trivial > Fix For: 2.0.10, 2.1.1 > > Attachments: nodetool_url_fmt.txt > > > The NodeProbe fmtUrl does not account for ipv6 addresses specified for > 'host'. > nodetool -h with ipv6 host address fails with cryptic error message > Adding square brackets as in http://www.ietf.org/rfc/rfc3986.txt section > 3.2.2 corrects this behavior. Patch attached. > {code:title=Before} > aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost > 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; > eval $cmd; done > bin/nodetool -h localhost -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 127.0.0.1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h ::1 -p 7100 version > nodetool: For input string: ":1:7100" > See 'nodetool help' or 'nodetool help '. > bin/nodetool -h 0::1 -p 7100 version > nodetool: For input string: ":1:7100" > See 'nodetool help' or 'nodetool help ’. > {code} > {code:title=After} > aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost > 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; > eval $cmd; done > bin/nodetool -h localhost -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 127.0.0.1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h ::1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 0::1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7669) nodetool fails to connect when ipv6 host is specified
[ https://issues.apache.org/jira/browse/CASSANDRA-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084685#comment-14084685 ] Robert Stupp commented on CASSANDRA-7669: - Yep. But currently -1 on the patch (since it's not IPv6 only). > nodetool fails to connect when ipv6 host is specified > - > > Key: CASSANDRA-7669 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7669 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: java version "1.7.0_65" > Java(TM) SE Runtime Environment (build 1.7.0_65-b17) > Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode) >Reporter: Adam Holmberg >Assignee: Robert Stupp >Priority: Trivial > Fix For: 2.0.10, 2.1.1 > > Attachments: nodetool_url_fmt.txt > > > The NodeProbe fmtUrl does not account for ipv6 addresses specified for > 'host'. > nodetool -h with ipv6 host address fails with cryptic error message > Adding square brackets as in http://www.ietf.org/rfc/rfc3986.txt section > 3.2.2 corrects this behavior. Patch attached. > {code:title=Before} > aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost > 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; > eval $cmd; done > bin/nodetool -h localhost -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 127.0.0.1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h ::1 -p 7100 version > nodetool: For input string: ":1:7100" > See 'nodetool help' or 'nodetool help '. > bin/nodetool -h 0::1 -p 7100 version > nodetool: For input string: ":1:7100" > See 'nodetool help' or 'nodetool help ’. > {code} > {code:title=After} > aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost > 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; > eval $cmd; done > bin/nodetool -h localhost -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 127.0.0.1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h ::1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 0::1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CASSANDRA-7669) nodetool fails to connect when ipv6 host is specified
[ https://issues.apache.org/jira/browse/CASSANDRA-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084184#comment-14084184 ] Adam Holmberg commented on CASSANDRA-7669: -- Yes. Tested patch with similar results on 2.1 (java 7), 2.0 (java 7), 1.2 (java 6,7) > nodetool fails to connect when ipv6 host is specified > - > > Key: CASSANDRA-7669 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7669 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: java version "1.7.0_65" > Java(TM) SE Runtime Environment (build 1.7.0_65-b17) > Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode) >Reporter: Adam Holmberg >Priority: Trivial > Fix For: 2.1.1 > > Attachments: nodetool_url_fmt.txt > > > The NodeProbe fmtUrl does not account for ipv6 addresses specified for > 'host'. > nodetool -h with ipv6 host address fails with cryptic error message > Adding square brackets as in http://www.ietf.org/rfc/rfc3986.txt section > 3.2.2 corrects this behavior. Patch attached. > {code:title=Before} > aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost > 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; > eval $cmd; done > bin/nodetool -h localhost -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 127.0.0.1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h ::1 -p 7100 version > nodetool: For input string: ":1:7100" > See 'nodetool help' or 'nodetool help '. > bin/nodetool -h 0::1 -p 7100 version > nodetool: For input string: ":1:7100" > See 'nodetool help' or 'nodetool help ’. > {code} > {code:title=After} > aholmberg-rmbp15:cassandra-2.1.0-rc4 adamholmberg$ for h in localhost > 127.0.0.1 ::1 0::1; do cmd="bin/nodetool -h $h -p 7100 version"; echo $cmd; > eval $cmd; done > bin/nodetool -h localhost -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 127.0.0.1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h ::1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > bin/nodetool -h 0::1 -p 7100 version > ReleaseVersion: 2.1.0-rc4-SNAPSHOT > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)