Repository: cassandra Updated Branches: refs/heads/trunk 6f5542792 -> c844bfeea
Log error when closing streaming connection at debug (this is good hygiene and remove a findBugs warning in particular) Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/59b8e171 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/59b8e171 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/59b8e171 Branch: refs/heads/trunk Commit: 59b8e171e91e4d714acac5ec195f40158e2e2971 Parents: 7acd0e6 Author: Sylvain Lebresne <sylv...@datastax.com> Authored: Tue May 19 10:31:48 2015 +0200 Committer: Sylvain Lebresne <sylv...@datastax.com> Committed: Tue May 19 10:31:52 2015 +0200 ---------------------------------------------------------------------- .../org/apache/cassandra/streaming/ConnectionHandler.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cassandra/blob/59b8e171/src/java/org/apache/cassandra/streaming/ConnectionHandler.java ---------------------------------------------------------------------- diff --git a/src/java/org/apache/cassandra/streaming/ConnectionHandler.java b/src/java/org/apache/cassandra/streaming/ConnectionHandler.java index 6092046..aa3504a 100644 --- a/src/java/org/apache/cassandra/streaming/ConnectionHandler.java +++ b/src/java/org/apache/cassandra/streaming/ConnectionHandler.java @@ -215,7 +215,12 @@ public class ConnectionHandler { socket.close(); } - catch (IOException ignore) {} + catch (IOException e) + { + // Erroring out while closing shouldn't happen but is not really a big deal, so just log + // it at DEBUG and ignore otherwise. + logger.debug("Unexpected error while closing streaming connection", e); + } } }
