[jira] [Comment Edited] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223100#comment-15223100 ] Pavel Yaskevich edited comment on CASSANDRA-11183 at 4/3/16 3:46 AM: - I think it would be better if instead of Set satisfiesBy and localSatisfiesBy methods are to have staticRow instead e.g. {{\{local\}SatisfiedBy(Unfiltered currentCluster, Row statics, boolean allowMissingColumns)}} and {{ColumnIndex.getValueOf(ColumnDefinition, Row cluster, Row statics, int now)}} would just pick correct row to get value data from by adding {{case STATIC}}. Edit: forgot to mention that doing the way in the patch breaks OR support, the only feasible way I see to fix that is to use the way I've described which doesn't really distinguesh without normal and static columns. was (Author: xedin): I think it would be better if instead of Set satisfiesBy and localSatisfiesBy methods are to have staticRow instead e.g. {{\{local\}SatisfiedBy(Unfiltered currentCluster, Row statics, boolean allowMissingColumns)}} and {{ColumnIndex.getValueOf(ColumnDefinition, Row cluster, Row statics, int now)}} would just pick correct row to get value data from by adding {{case STATIC}}. > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: patch_SASI_for_Static.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223100#comment-15223100 ] Pavel Yaskevich edited comment on CASSANDRA-11183 at 4/3/16 2:00 AM: - I think it would be better if instead of Set satisfiesBy and localSatisfiesBy methods are to have staticRow instead e.g. {{\{local\}SatisfiedBy(Unfiltered currentCluster, Row statics, boolean allowMissingColumns)}} and {{ColumnIndex.getValueOf(ColumnDefinition, Row cluster, Row statics, int now)}} would just pick correct row to get value data from by adding {{case STATIC}}. was (Author: xedin): I think it would be better if instead of Set satisfiesBy and localSatisfiesBy methods are to have staticRow instead e.g. {{\{local\}SatisfiedBy(Unfiltered currentCluster, Row statics, boolean allowMissingColumns)}} and {{ColumnIndex.getValue(ColumnDefinition, Row cluster, Row statics, int now)}} would just pick correct row to get value data from by adding {{case STATIC}}. > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Fix For: 3.6 > > Attachments: patch_SASI_for_Static.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-11183) Enable SASI index for static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222857#comment-15222857 ] DOAN DuyHai edited comment on CASSANDRA-11183 at 4/2/16 11:18 AM: -- Attached is the patch for this new feature. I also added a test in {{SASIIndexTest}} to ensure that conditions on static columns are working in combination with non static columns ... /cc [~xedin] [~beobal] for review was (Author: doanduyhai): Attached is the patch for this new feature. I also added a test in {{SASIIndexTest}} to ensure that conditions on static columns are working in combination with non static columns ... > Enable SASI index for static columns > > > Key: CASSANDRA-11183 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11183 > Project: Cassandra > Issue Type: Improvement > Components: CQL >Reporter: DOAN DuyHai >Assignee: DOAN DuyHai >Priority: Minor > Attachments: patch_SASI_for_Static.txt > > > This is a follow up ticket for post Cassandra 3.4 SASI integration. > Since [CASSANDRA-8103] it is possible to index static columns, which is > *extremely useful* for some scenarios (find all sensors whose characteristics > are saved in static columns) > /cc [~xedin] [~rustyrazorblade] [~jkrupan] -- This message was sent by Atlassian JIRA (v6.3.4#6332)