[jira] [Comment Edited] (CASSANDRA-14340) Refactor ColumnFamilyStore to Table

[Benjamin Lerer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418694#comment-16418694
 ] 

Benjamin Lerer edited comment on CASSANDRA-14340 at 3/29/18 10:22 AM:
--

I quickly scanned the patch. It seems to me that it will break backward 
compatibility for JMX in a surprising way for the users as the mbean name does 
not change but the interface change.

I think that for example it will be impossible to use nodetool from the 4.0 
version to manage a 3.11 node or the opposite. I do not know how much of a 
problem it can be during a cluster migration.

We should at least put an entry for that in the {{NEWS.txt}}

 

 


was (Author: blerer):
I quickly scanned the patch. It seems to me that it will break backward 
compatibility for JMX in a surprising way for the users as the mbean name does 
not change but the interface change. As this change is in 4.0 it should be ok 
as long as the change is clearly mentionned in the {{NEWS.txt}}.

> Refactor ColumnFamilyStore to Table
> ---
>
> Key: CASSANDRA-14340
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14340
> Project: Cassandra
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Jon Haddad
>Assignee: Jon Haddad
>Priority: Major
>
> This end result of this should change the ColumnFamily store, 
> ColumnFamilyStoreMBean, and tests that reference them by name.
> Deserves a note in news as this will break JMX compatibility and affect 
> scripts which change log level by class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-14340) Refactor ColumnFamilyStore to Table

[Jon Haddad (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414848#comment-16414848
 ] 

Jon Haddad edited comment on CASSANDRA-14340 at 3/28/18 5:51 PM:
-

Tests are passing in CircleCI.  There's a few dtests that are failing, I need 
to check on them.  At a glance they appear to be unrelated, I'll verify.  
Tables were registered previously using explicitly defined mbeans names, so I 
don't think anything needs to change there.

|[trunk|https://github.com/apache/cassandra/compare/trunk...rustyrazorblade:CASSANDRA-14340]
 |
|[CircleCI|https://circleci.com/gh/rustyrazorblade/cassandra/13]
|[dtests|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/518/]|



was (Author: rustyrazorblade):
Tests are passing in CircleCI.  There's a few dtests that are failing, I need 
to check on them.  At a glance they appear to be unrelated, I'll verify.  
Tables were registered previously using explicitly defined mbeans names, so I 
don't think anything needs to change there.

|[trunk|https://github.com/apache/cassandra/compare/trunk...rustyrazorblade:CASSANDRA-14340]
 |
|[CircleCI|https://circleci.com/gh/rustyrazorblade/cassandra/13]
|[dtests|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/lastBuild/]|


> Refactor ColumnFamilyStore to Table
> ---
>
> Key: CASSANDRA-14340
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14340
> Project: Cassandra
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Jon Haddad
>Assignee: Jon Haddad
>Priority: Major
>
> This end result of this should change the ColumnFamily store, 
> ColumnFamilyStoreMBean, and tests that reference them by name.
> Deserves a note in news as this will break JMX compatibility and affect 
> scripts which change log level by class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org