[jira] [Comment Edited] (CASSANDRA-14749) Collection Deletions for Dropped Columns in 2.1/3.0 mixed-mode can delete rows
[
https://issues.apache.org/jira/browse/CASSANDRA-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617331#comment-16617331
]
Robert Stupp edited comment on CASSANDRA-14749 at 9/17/18 10:21 AM:
Seems that this commit broke the build in cassandra-3.11:
{code:java}
build-test:
[javac] Compiling 540 source files to
/home/automaton/cassandra-src/build/test/classes
[javac]
/home/automaton/cassandra-src/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java:279:
error: Clustering is abstract; cannot be instantiated
[javac] builder.newRow(new Clustering(UTF8Serializer.instance.serialize("a")));
[javac] ^
[javac]
/home/automaton/cassandra-src/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java:280:
error: no suitable method found for
live(CFMetaData,ColumnDefinition,long,ByteBuffer,)
[javac] builder.addCell(BufferCell.live(table, v, 0L,
Int32Serializer.instance.serialize(1), null));
[javac] ^
[javac] method BufferCell.live(ColumnDefinition,long,ByteBuffer) is not
applicable
[javac] (actual and formal argument lists differ in length)
[javac] method BufferCell.live(ColumnDefinition,long,ByteBuffer,CellPath) is
not applicable
[javac] (actual and formal argument lists differ in length)
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 2 errors
{code}
was (Author: snazy):
Seems that this commit broke the build:
{code:java}
build-test:
[javac] Compiling 540 source files to
/home/automaton/cassandra-src/build/test/classes
[javac]
/home/automaton/cassandra-src/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java:279:
error: Clustering is abstract; cannot be instantiated
[javac] builder.newRow(new Clustering(UTF8Serializer.instance.serialize("a")));
[javac] ^
[javac]
/home/automaton/cassandra-src/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java:280:
error: no suitable method found for
live(CFMetaData,ColumnDefinition,long,ByteBuffer,)
[javac] builder.addCell(BufferCell.live(table, v, 0L,
Int32Serializer.instance.serialize(1), null));
[javac] ^
[javac] method BufferCell.live(ColumnDefinition,long,ByteBuffer) is not
applicable
[javac] (actual and formal argument lists differ in length)
[javac] method BufferCell.live(ColumnDefinition,long,ByteBuffer,CellPath) is
not applicable
[javac] (actual and formal argument lists differ in length)
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 2 errors
{code}
> Collection Deletions for Dropped Columns in 2.1/3.0 mixed-mode can delete rows
> --
>
> Key: CASSANDRA-14749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14749
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Benedict
>Assignee: Benedict
>Priority: Major
> Fix For: 3.0.18
>
>
> Similar to CASSANDRA-14568, if a 2.1 node sends a response to a 3.0 node
> containing a deletion for a dropped collection column, instead of deleting
> the collection, we will delete the row containing the collection.
>
> This is an admittedly unlikely cluster state but, during such a state, a
> great deal of data loss could happen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14749) Collection Deletions for Dropped Columns in 2.1/3.0 mixed-mode can delete rows
[
https://issues.apache.org/jira/browse/CASSANDRA-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613870#comment-16613870
]
Benedict edited comment on CASSANDRA-14749 at 9/14/18 12:34 PM:
-FWIW, I've been planning to file a ticket to audit the non-use of
{{getDroppedColumn}} also, off the back of this, and perhaps we should combine
the two efforts. I'm sure most uses of {{getColumn}} should have a
corresponding use of {{getDroppedColumn}} and I'm sure there have been other
oversights than this. We could keep two separate endeavours though.-
At least in trunk, it seems dropped columns have been considered in all places
that we invoke {{getColumn}}, besides in test cases
was (Author: benedict):
FWIW, I've been planning to file a ticket to audit the non-use of
{{getDroppedColumn}} also, off the back of this, and perhaps we should combine
the two efforts. I'm sure most uses of {{getColumn}} should have a
corresponding use of {{getDroppedColumn}} and I'm sure there have been other
oversights than this. We could keep two separate endeavours though.
> Collection Deletions for Dropped Columns in 2.1/3.0 mixed-mode can delete rows
> --
>
> Key: CASSANDRA-14749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14749
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Benedict
>Assignee: Benedict
>Priority: Major
> Fix For: 3.0.18
>
>
> Similar to CASSANDRA-14568, if a 2.1 node sends a response to a 3.0 node
> containing a deletion for a dropped collection column, instead of deleting
> the collection, we will delete the row containing the collection.
>
> This is an admittedly unlikely cluster state but, during such a state, a
> great deal of data loss could happen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14749) Collection Deletions for Dropped Columns in 2.1/3.0 mixed-mode can delete rows
[
https://issues.apache.org/jira/browse/CASSANDRA-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613795#comment-16613795
]
Benedict edited comment on CASSANDRA-14749 at 9/13/18 5:08 PM:
---
-Good job I did (split this out) - this time, Aleksey pointed out the
{{getDroppedColumn}} invokes another method {{getDroppedColumn(name,
isStatic)}} with a default parameter of {{false}} for {{isStatic}}- (That's
what I get for not refreshing the page)
I've pushed an update, but I think the defaulting variant of
{{getDroppedColumn}} probably shouldn't exist.
was (Author: benedict):
Good job I did (split this out) - this time, Aleksey pointed out the
{{getDroppedColumn}} invokes another method {{getDroppedColumn(name,
isStatic)}} with a default parameter of {{false}} for {{isStatic}}
I've pushed an update, but I think the defaulting variant of
{{getDroppedColumn}} probably shouldn't exist.
> Collection Deletions for Dropped Columns in 2.1/3.0 mixed-mode can delete rows
> --
>
> Key: CASSANDRA-14749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14749
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Benedict
>Assignee: Benedict
>Priority: Major
> Fix For: 3.0.18
>
>
> Similar to CASSANDRA-14568, if a 2.1 node sends a response to a 3.0 node
> containing a deletion for a dropped collection column, instead of deleting
> the collection, we will delete the row containing the collection.
>
> This is an admittedly unlikely cluster state but, during such a state, a
> great deal of data loss could happen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
