[jira] [Comment Edited] (CASSANDRA-15015) Cassandra metrics documentation is not correct for Hint_delays metric

2019-02-20 Thread Anup Shirolkar (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773595#comment-16773595
 ] 

Anup Shirolkar edited comment on CASSANDRA-15015 at 2/21/19 2:12 AM:
-

[~djoshi3] I have attached a patch now. Can you please review it. Thanks.

Sorry, I had to delete the patch I had submitted last time as I did not follow 
the process. I think its all good now.

Also created a branch in case required for review:

[https://github.com/instaclustr/cassandra/tree/150150] 


was (Author: anupshirolkar):
[~djoshi3] I have attached a patch now. Can you please review it. Thanks.

Sorry, I had to delete the patch I had submitted last time as I did not follow 
the process. I think its all good now.

> Cassandra metrics documentation is not correct for Hint_delays metric
> -
>
> Key: CASSANDRA-15015
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15015
> Project: Cassandra
>  Issue Type: Bug
>  Components: Documentation/Blog
>Reporter: Anup Shirolkar
>Assignee: Anup Shirolkar
>Priority: Minor
>  Labels: documentation, easyfix, low-hanging-fruit
> Fix For: 3.0.19, 3.11.5, 4.0
>
> Attachments: 150150-trunk.txt
>
>
> The Cassandra metrics for hint delays are not correctly referred on the 
> documentation web page: 
> [http://cassandra.apache.org/doc/latest/operating/metrics.html#hintsservice-metrics]
>  
> The metrics are defined in the 
> [code|https://github.com/apache/cassandra/blob/06209037ea56b5a2a49615a99f1542d6ea1b2947/src/java/org/apache/cassandra/metrics/HintsServiceMetrics.java#L45-L52]
>  as 'Hint_delays' and 'Hint_delays-' but those are listed on the 
> website as 'Hints_delays' and 'Hints_delays-'.
> The documentation should be fixed by removing the extra 's' in Hints to match 
> it with code.
> The Jira for adding hint_delays: CASSANDRA-13234 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-15015) Cassandra metrics documentation is not correct for Hint_delays metric

2019-02-20 Thread Anup Shirolkar (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773595#comment-16773595
 ] 

Anup Shirolkar edited comment on CASSANDRA-15015 at 2/21/19 2:10 AM:
-

[~djoshi3] I have attached a patch now. Can you please review it. Thanks.

Sorry, I had to delete the patch I had submitted last time as I did not follow 
the process. I think its all good now.


was (Author: anupshirolkar):
[~djoshi3] I have attached a patch now. Can you please review it. Thanks.

> Cassandra metrics documentation is not correct for Hint_delays metric
> -
>
> Key: CASSANDRA-15015
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15015
> Project: Cassandra
>  Issue Type: Bug
>  Components: Documentation/Blog
>Reporter: Anup Shirolkar
>Assignee: Anup Shirolkar
>Priority: Minor
>  Labels: documentation, easyfix, low-hanging-fruit
> Fix For: 3.0.19, 3.11.5, 4.0
>
> Attachments: 150150-trunk.txt
>
>
> The Cassandra metrics for hint delays are not correctly referred on the 
> documentation web page: 
> [http://cassandra.apache.org/doc/latest/operating/metrics.html#hintsservice-metrics]
>  
> The metrics are defined in the 
> [code|https://github.com/apache/cassandra/blob/06209037ea56b5a2a49615a99f1542d6ea1b2947/src/java/org/apache/cassandra/metrics/HintsServiceMetrics.java#L45-L52]
>  as 'Hint_delays' and 'Hint_delays-' but those are listed on the 
> website as 'Hints_delays' and 'Hints_delays-'.
> The documentation should be fixed by removing the extra 's' in Hints to match 
> it with code.
> The Jira for adding hint_delays: CASSANDRA-13234 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org